Parent Project

PMD Results

The following document contains the results of PMD 4.2.5.

Files

org/apache/myfaces/trinidadinternal/agent/CapabilityValue.java

Violation Line
Avoid empty catch blocks 54 - 56

org/apache/myfaces/trinidadinternal/agent/TrinidadAgentImpl.java

Violation Line
Double checked locking is not thread safe in Java. 284 - 299

org/apache/myfaces/trinidadinternal/agent/parse/CapabilitiesDocumentParser.java

Violation Line
An empty statement (semicolon) not part of a loop 81
An empty statement (semicolon) not part of a loop 97

org/apache/myfaces/trinidadinternal/agent/parse/CapabilityDataDocumentParser.java

Violation Line
An empty statement (semicolon) not part of a loop 92

org/apache/myfaces/trinidadinternal/agent/parse/NameVersion.java

Violation Line
These nested if statements could be combined 365 - 366

org/apache/myfaces/trinidadinternal/application/NavigationHandlerImpl.java

Violation Line
Avoid unused private fields such as '_LOG'. 175

org/apache/myfaces/trinidadinternal/application/StateManagerImpl.java

Violation Line
Avoid unused method parameters such as 'context'. 1350 - 1355

org/apache/myfaces/trinidadinternal/application/ViewDeclarationLanguageFactoryImpl.java

Violation Line
Avoid unused imports such as 'java.beans.BeanInfo' 21
Avoid unused imports such as 'javax.faces.application.Resource' 37
Avoid unused imports such as 'javax.faces.component.UIComponent' 38
Avoid unused imports such as 'javax.faces.view.AttachedObjectHandler' 43
Avoid unused imports such as 'javax.faces.view.StateManagementStrategy' 44
Avoid unused imports such as 'javax.faces.view.ViewMetadata' 47

org/apache/myfaces/trinidadinternal/application/ViewHandlerImpl.java

Violation Line
An empty statement (semicolon) not part of a loop 161

org/apache/myfaces/trinidadinternal/config/CheckSerializationConfigurator.java

Violation Line
These nested if statements could be combined 968 - 971
These nested if statements could be combined 986 - 989

org/apache/myfaces/trinidadinternal/config/ConfigParser.java

Violation Line
An empty statement (semicolon) not part of a loop 104

org/apache/myfaces/trinidadinternal/config/GlobalConfiguratorImpl.java

Violation Line
Unnecessary final modifier in final class 90 - 122
Unnecessary final modifier in final class 147 - 165
These nested if statements could be combined 223 - 234
An empty statement (semicolon) not part of a loop 533
Avoid unused method parameters such as 'ec'. 650 - 658

org/apache/myfaces/trinidadinternal/config/URLEncoderExternalContext.java

Violation Line
Avoid unused imports such as 'java.io.UnsupportedEncodingException' 21
Avoid unused imports such as 'java.net.URLDecoder' 23
Avoid unused imports such as 'java.util.ArrayList' 25
Avoid unused imports such as 'java.util.HashMap' 26
Overriding method merely calls super 78 - 82
Overriding method merely calls super 85 - 89

org/apache/myfaces/trinidadinternal/config/upload/CompositeUploadedFileProcessorImpl.java

Violation Line
Avoid unused imports such as 'java.io.Serializable' 24
Avoid unused local variables such as 'test'. 114

org/apache/myfaces/trinidadinternal/config/upload/FileUploadConfiguratorImpl.java

Violation Line
Avoid unused imports such as 'javax.servlet.http.HttpServletRequest' 39
Avoid unused imports such as 'org.apache.myfaces.trinidad.webapp.UploadedFileProcessor' 50
These nested if statements could be combined 196 - 277
These nested if statements could be combined 441 - 454
Avoid empty catch blocks 612 - 615

org/apache/myfaces/trinidadinternal/config/upload/UploadRequestWrapper.java

Violation Line
Avoid unused imports such as 'java.util.Collections' 22
Avoid unused imports such as 'java.util.HashMap' 24
Avoid unused imports such as 'javax.portlet.ActionResponse' 29
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.share.util.CaboHttpUtils' 35

org/apache/myfaces/trinidadinternal/config/upload/UploadedFileImpl.java

Violation Line
Avoid unused imports such as 'java.io.Serializable' 29
Avoid unused imports such as 'java.util.Collections' 32
These nested if statements could be combined 101 - 104

org/apache/myfaces/trinidadinternal/config/upload/UploadedFileProcessorImpl.java

Violation Line
Avoid unused imports such as 'java.io.File' 21
Avoid unused imports such as 'java.util.Map' 24
Avoid unused imports such as 'javax.portlet.ActionRequest' 26
Avoid unused imports such as 'javax.portlet.PortletContext' 27
Avoid unused imports such as 'javax.portlet.PortletRequest' 28
Avoid unused imports such as 'javax.servlet.ServletContext' 30
Avoid unused imports such as 'javax.servlet.ServletRequest' 31
Avoid unused imports such as 'org.apache.myfaces.trinidad.logging.TrinidadLogger' 33
Avoid unused imports such as 'org.apache.myfaces.trinidad.util.ClassLoaderUtils' 35
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.context.external.PortletApplicationMap' 37
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.context.external.PortletInitParameterMap' 38
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.context.external.PortletRequestMap' 39
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.context.external.ServletApplicationMap' 40
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.context.external.ServletInitParameterMap' 41
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.context.external.ServletRequestMap' 42

org/apache/myfaces/trinidadinternal/config/upload/UploadedFiles.java

Violation Line
Avoid unused imports such as 'org.apache.myfaces.trinidad.logging.TrinidadLogger' 44

org/apache/myfaces/trinidadinternal/config/xmlHttp/XmlHttpConfigurator.java

Violation Line
Avoid unused imports such as 'java.lang.reflect.Proxy' 26
Avoid unused imports such as 'org.apache.myfaces.trinidad.util.ClassLoaderUtils' 44

org/apache/myfaces/trinidadinternal/config/xmlHttp/XmlHttpPortletExternalContext.java

Violation Line
Avoid unused imports such as 'java.io.Writer' 24

org/apache/myfaces/trinidadinternal/config/xmlHttp/XmlHttpServletResponse.java

Violation Line
Avoid unused imports such as 'javax.servlet.ServletResponse' 27

org/apache/myfaces/trinidadinternal/context/PageFlowScopeMap.java

Violation Line
Avoid unused method parameters such as 'cache'. 72 - 94

org/apache/myfaces/trinidadinternal/context/PartialViewContextFactoryImpl.java

Violation Line
Avoid unused imports such as 'javax.faces.context.FacesContextFactory' 22
Avoid unused private fields such as '_factory'. 44

org/apache/myfaces/trinidadinternal/context/PartialViewContextImpl.java

Violation Line
Avoid unused imports such as 'java.util.Collections' 25

org/apache/myfaces/trinidadinternal/context/RequestContextImpl.java

Violation Line
Avoid unused constructor parameters such as 'facesContext'. 981 - 983

org/apache/myfaces/trinidadinternal/context/external/NullEnumeration.java

Violation Line
Unnecessary final modifier in final class 30 - 33

org/apache/myfaces/trinidadinternal/context/external/ServletExternalContext.java

Violation Line
These nested if statements could be combined 205 - 209
Avoid unused private fields such as '_CHAR_ENCODING_CALLED'. 924

org/apache/myfaces/trinidadinternal/convert/ByteConverter.java

Violation Line
Avoid unused method parameters such as 'component'. 124 - 141
Avoid unused method parameters such as 'context'. 124 - 141

org/apache/myfaces/trinidadinternal/convert/ColorConverter.java

Violation Line
Avoid unused imports such as 'org.apache.myfaces.buildtools.maven2.plugin.builder.annotation.JSFJspProperty' 31

org/apache/myfaces/trinidadinternal/convert/ConverterUtils.java

Violation Line
Avoid unused method parameters such as 'component'. 212 - 268

org/apache/myfaces/trinidadinternal/convert/DateTimeConverter.java

Violation Line
An empty statement (semicolon) not part of a loop 390
Do not use if statements that are always true or always false 411
Avoid unused method parameters such as 'context'. 585 - 603

org/apache/myfaces/trinidadinternal/convert/DoubleConverter.java

Violation Line
Avoid unused method parameters such as 'component'. 97 - 102
Avoid unused method parameters such as 'context'. 97 - 102

org/apache/myfaces/trinidadinternal/convert/FloatConverter.java

Violation Line
Avoid unused method parameters such as 'component'. 97 - 102
Avoid unused method parameters such as 'context'. 97 - 102

org/apache/myfaces/trinidadinternal/convert/GenericConverterFactory.java

Violation Line
Avoid unused imports such as 'java.util.Collections' 22
Avoid unused imports such as 'javax.faces.context.FacesContext' 31

org/apache/myfaces/trinidadinternal/convert/IntegerConverter.java

Violation Line
Avoid unused method parameters such as 'component'. 131 - 148
Avoid unused method parameters such as 'context'. 131 - 148

org/apache/myfaces/trinidadinternal/convert/LongConverter.java

Violation Line
Avoid unused method parameters such as 'component'. 128 - 145
Avoid unused method parameters such as 'context'. 128 - 145

org/apache/myfaces/trinidadinternal/convert/NumberConverter.java

Violation Line
Avoid unused imports such as 'org.apache.myfaces.trinidad.util.IntegerUtils' 36
Avoid unused method parameters such as 'component'. 211 - 235
Avoid unused private fields such as '_LOG'. 256

org/apache/myfaces/trinidadinternal/convert/ShortConverter.java

Violation Line
Avoid unused method parameters such as 'component'. 127 - 144
Avoid unused method parameters such as 'context'. 127 - 144

org/apache/myfaces/trinidadinternal/el/OracleHelpProvider.java

Violation Line
These nested if statements could be combined 64 - 68

org/apache/myfaces/trinidadinternal/facelets/TimezonePropertyTagRule.java

Violation Line
Avoid unused private fields such as '_LOG'. 94

org/apache/myfaces/trinidadinternal/image/ImageTypeImpl.java

Violation Line
These nested if statements could be combined 80 - 85

org/apache/myfaces/trinidadinternal/image/cache/BaseColorizedIconKey.java

Violation Line
Avoid unused constructor parameters such as 'context'. 62 - 71
Avoid unused constructor parameters such as 'context'. 79 - 87

org/apache/myfaces/trinidadinternal/image/cache/Cache.java

Violation Line
An empty statement (semicolon) not part of a loop 235

org/apache/myfaces/trinidadinternal/image/cache/FileSystemImageCache.java

Violation Line
These nested if statements could be combined 599 - 600
Avoid unused method parameters such as 'context'. 997 - 1002
Avoid unused method parameters such as 'context'. 1189 - 1200
An empty statement (semicolon) not part of a loop 1676
These nested if statements could be combined 1690 - 1699

org/apache/myfaces/trinidadinternal/image/encode/OctreeQuantizer.java

Violation Line
These nested if statements could be combined 241 - 246

org/apache/myfaces/trinidadinternal/image/encode/PNGEncoder.java

Violation Line
Avoid unused imports such as 'java.util.Iterator' 29
Unnecessary final modifier in final class 480 - 492

org/apache/myfaces/trinidadinternal/image/laf/browser/BlafImageUtils.java

Violation Line
Avoid unused method parameters such as 'styleID'. 355 - 363
Avoid unused method parameters such as 'context'. 355 - 363
Avoid unused method parameters such as 'isNamed'. 355 - 363
Avoid unused method parameters such as 'key'. 355 - 363
Avoid unused private fields such as '_STYLE_ERROR'. 381
Avoid unused private fields such as '_LOG'. 386

org/apache/myfaces/trinidadinternal/image/laf/browser/ButtonPainter.java

Violation Line
An empty statement (semicolon) not part of a loop 401

org/apache/myfaces/trinidadinternal/image/painter/AdjustableBorderPainter.java

Violation Line
Avoid unused method parameters such as 'context'. 113 - 116
An empty statement (semicolon) not part of a loop 144
Avoid unused private fields such as '_styleNamePrefix'. 161

org/apache/myfaces/trinidadinternal/image/painter/ImageUtils.java

Violation Line
An empty statement (semicolon) not part of a loop 275
An empty statement (semicolon) not part of a loop 311
An empty statement (semicolon) not part of a loop 322

org/apache/myfaces/trinidadinternal/image/xml/encode/AbstractXMLEncoder.java

Violation Line
These nested if statements could be combined 353 - 354

org/apache/myfaces/trinidadinternal/image/xml/parse/FontParser.java

Violation Line
An empty statement (semicolon) not part of a loop 153

org/apache/myfaces/trinidadinternal/image/xml/parse/ImageParseUtils.java

Violation Line
An empty statement (semicolon) not part of a loop 86

org/apache/myfaces/trinidadinternal/io/DebugHtmlResponseWriter.java

Violation Line
These nested if statements could be combined 80 - 81

org/apache/myfaces/trinidadinternal/io/HTMLEscapes.java

Violation Line
Avoid unused private fields such as '_LOG'. 667

org/apache/myfaces/trinidadinternal/io/IndentingResponseWriter.java

Violation Line
These nested if statements could be combined 71 - 74

org/apache/myfaces/trinidadinternal/io/XhtmlResponseWriter.java

Violation Line
Avoid unused constructor parameters such as 'contentType'. 46 - 57

org/apache/myfaces/trinidadinternal/menu/ImmutableGroupNode.java

Violation Line
Avoid unused local variables such as 'accessKey'. 188
Avoid unused local variables such as 'label'. 303

org/apache/myfaces/trinidadinternal/menu/ImmutableItemNode.java

Violation Line
Avoid unused local variables such as 'accessKey'. 230
Avoid unused local variables such as 'label'. 384
Avoid unused local variables such as 'labelAndAcessKeyEval'. 463

org/apache/myfaces/trinidadinternal/menu/MenuContentHandlerImpl.java

Violation Line
Avoid unused local variables such as 'npe'. 336

org/apache/myfaces/trinidadinternal/menu/MenuContentHandlerUsingApiImpl.java

Violation Line
Avoid unused local variables such as 'npe'. 339

org/apache/myfaces/trinidadinternal/renderkit/RenderKitBase.java

Violation Line
These nested if statements could be combined 132 - 133

org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderKit.java

Violation Line
Avoid unused private fields such as '_BASIC_HTML_RENDERERS'. 762

org/apache/myfaces/trinidadinternal/renderkit/core/CoreResponseStateManager.java

Violation Line
These nested if statements could be combined 232 - 235
Avoid unused private fields such as '_BUFFER_SIZE'. 348

org/apache/myfaces/trinidadinternal/renderkit/core/DialogRequest.java

Violation Line
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.SkinSelectors' 35

org/apache/myfaces/trinidadinternal/renderkit/core/StyleContextImpl.java

Violation Line
An empty statement (semicolon) not part of a loop 373

org/apache/myfaces/trinidadinternal/renderkit/core/desktop/TrainRenderer.java

Violation Line
Avoid unused method parameters such as 'bean'. 916 - 954
Avoid unused constructor parameters such as 'context'. 958 - 988

org/apache/myfaces/trinidadinternal/renderkit/core/desktop/TreeTableRenderer.java

Violation Line
These nested if statements could be combined 558 - 575

org/apache/myfaces/trinidadinternal/renderkit/core/pages/CalendarDialogJSP.java

Violation Line
An empty statement (semicolon) not part of a loop 154

org/apache/myfaces/trinidadinternal/renderkit/core/pages/JspUtils.java

Violation Line
These nested if statements could be combined 73 - 75

org/apache/myfaces/trinidadinternal/renderkit/core/ppr/PPRResponseWriter.java

Violation Line
These nested if statements could be combined 449 - 458
Avoid unused private fields such as '_allowedIds'. 705

org/apache/myfaces/trinidadinternal/renderkit/core/ppr/PartialPageContextImpl.java

Violation Line
These nested if statements could be combined 256 - 257

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/AutoSubmitUtils.java

Violation Line
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.jsLibs.XhtmlScriptletFactory' 34
Avoid unused private fields such as '_START'. 342
Avoid unused private fields such as '_START_RADIO'. 343

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/BodyRenderer.java

Violation Line
Avoid unused imports such as 'java.beans.Beans' 21
Avoid unused method parameters such as 'rc'. 465 - 478

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ChooseDateRenderer.java

Violation Line
Avoid unused method parameters such as 'isInline'. 1522 - 1525

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/CoreFormData.java

Violation Line
An empty statement (semicolon) not part of a loop 328

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/FormElementRenderer.java

Violation Line
These nested if statements could be combined 229 - 230

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/FormRenderer.java

Violation Line
Avoid unused imports such as 'org.apache.myfaces.trinidad.component.UIXComponent' 41
These nested if statements could be combined 146 - 164
These nested if statements could be combined 1262 - 1283

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/FrameBorderLayoutRenderer.java

Violation Line
Avoid unused method parameters such as 'component'. 328 - 337
Avoid unused method parameters such as 'component'. 339 - 348
Avoid unused method parameters such as 'component'. 350 - 359

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/InputColorRenderer.java

Violation Line
Avoid unused method parameters such as 'component'. 76 - 87

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java

Violation Line
These nested if statements could be combined 372 - 390
These nested if statements could be combined 509 - 516

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/MediaRenderer.java

Violation Line
These nested if statements could be combined 615 - 622
These nested if statements could be combined 618 - 621
These nested if statements could be combined 1461 - 1465

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/NavigationPaneRenderer.java

Violation Line
Avoid unused method parameters such as 'component'. 333 - 345
Avoid unused local variables such as 'styleAppender'. 594

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/OutputLabelRenderer.java

Violation Line
These nested if statements could be combined 350 - 360

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/OutputUtils.java

Violation Line
These nested if statements could be combined 224 - 228

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/PanelAccordionRenderer.java

Violation Line
Avoid unused method parameters such as 'component'. 523 - 577

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/PanelBorderLayoutRenderer.java

Violation Line
Avoid unused method parameters such as 'component'. 876 - 933
Avoid unused method parameters such as 'useLR'. 876 - 933
Avoid unused method parameters such as 'isIE6'. 946 - 971
Avoid unused method parameters such as 'bean'. 946 - 971
Avoid unused method parameters such as 'bean'. 973 - 1019

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/PanelFormLayoutRenderer.java

Violation Line
These nested if statements could be combined 1107 - 1109
Avoid unused method parameters such as 'component'. 1175 - 1180
Avoid unused method parameters such as 'component'. 1187 - 1192
Avoid unused method parameters such as 'component'. 1199 - 1204
Avoid unused method parameters such as 'component'. 1211 - 1216
Avoid unused method parameters such as 'component'. 1223 - 1228

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/PanelGroupLayoutRenderer.java

Violation Line
An empty statement (semicolon) not part of a loop 82

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/PanelPartialRootRenderer.java

Violation Line
These nested if statements could be combined 146 - 150

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/PanelPopupRenderer.java

Violation Line
Avoid unused private fields such as '_LOG'. 458

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SelectRangeChoiceBarRenderer.java

Violation Line
These nested if statements could be combined 893 - 899
These nested if statements could be combined 932 - 933

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/ShowDetailRenderer.java

Violation Line
Avoid unused method parameters such as 'bean'. 507 - 536
Avoid unused local variables such as 'linkId'. 524

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SimpleInputNumberSpinboxRenderer.java

Violation Line
Avoid unused method parameters such as 'component'. 296 - 305
Avoid unused method parameters such as 'component'. 307 - 316
Avoid unused method parameters such as 'component'. 318 - 327

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SimpleInputTextRenderer.java

Violation Line
These nested if statements could be combined 460 - 461
An empty statement (semicolon) not part of a loop 814
An empty statement (semicolon) not part of a loop 820

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SimpleSelectBooleanRadioRenderer.java

Violation Line
These nested if statements could be combined 188 - 189
These nested if statements could be combined 217 - 231

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SimpleSelectManyRenderer.java

Violation Line
These nested if statements could be combined 633 - 636

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SimpleSelectOneRenderer.java

Violation Line
These nested if statements could be combined 127 - 129
These nested if statements could be combined 595 - 596

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SingleStepButtonBarRenderer.java

Violation Line
Avoid unused private fields such as '_SINGLE_CONTINUE_TEXT_KEY'. 330

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/TreeRenderer.java

Violation Line
Avoid unused local variables such as 'showLines'. 335
An empty statement (semicolon) not part of a loop 894
An empty statement (semicolon) not part of a loop 895
An empty statement (semicolon) not part of a loop 896
Avoid unused method parameters such as 'isFirstSibling'. 973 - 1015

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/XhtmlRenderer.java

Violation Line
These nested if statements could be combined 389 - 393
Do not use if statements that are always true or always false 921

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/XhtmlUtils.java

Violation Line
Avoid unused private fields such as '_CLIENT_BEHAVIORS_KEY'. 803
Avoid unused private fields such as '_PORTLET_LIB_TABLE_KEY'. 811

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/jsLibs/DialogStyleScriptlet.java

Violation Line
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.XhtmlUtils' 29

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/table/ColumnData.java

Violation Line
Avoid empty if statements 418
An empty statement (semicolon) not part of a loop 418

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/table/TableRenderingContext.java

Violation Line
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.SkinSelectors' 36
Avoid unused constructor parameters such as 'arc'. 49 - 106
These nested if statements could be combined 503 - 507

org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/table/TreeNodeColumnRenderer.java

Violation Line
Avoid empty catch blocks 231 - 233
Avoid empty catch blocks 234 - 236
Avoid empty catch blocks 237 - 239

org/apache/myfaces/trinidadinternal/renderkit/html/CellFormatRenderer.java

Violation Line
These nested if statements could be combined 94 - 97

org/apache/myfaces/trinidadinternal/renderkit/html/layout/CorePanelChoiceRenderer.java

Violation Line
Avoid unused method parameters such as 'component'. 298 - 315

org/apache/myfaces/trinidadinternal/renderkit/html/layout/CorePanelRadioRenderer.java

Violation Line
Avoid unused method parameters such as 'component'. 328 - 395

org/apache/myfaces/trinidadinternal/renderkit/html/layout/ShowOneListRendererBase.java

Violation Line
These nested if statements could be combined 592 - 598

org/apache/myfaces/trinidadinternal/share/data/ServletRequestParameters.java

Violation Line
These nested if statements could be combined 109 - 110

org/apache/myfaces/trinidadinternal/share/expl/Coercions.java

Violation Line
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 317
An empty statement (semicolon) not part of a loop 548

org/apache/myfaces/trinidadinternal/share/io/CachingNameResolver.java

Violation Line
These nested if statements could be combined 143 - 147

org/apache/myfaces/trinidadinternal/share/io/DefaultNameResolver.java

Violation Line
An empty statement (semicolon) not part of a loop 90

org/apache/myfaces/trinidadinternal/share/io/URLInputStreamProvider.java

Violation Line
Avoid unused imports such as 'java.beans.Beans' 21

org/apache/myfaces/trinidadinternal/share/nls/ImmutableDateFormatContext.java

Violation Line
Overriding method merely calls super 47 - 50

org/apache/myfaces/trinidadinternal/share/nls/ImmutableDecimalFormatContext.java

Violation Line
Overriding method merely calls super 60 - 63

org/apache/myfaces/trinidadinternal/share/nls/MutableLocaleContext.java

Violation Line
Unnecessary final modifier in final class 129 - 136
Unnecessary final modifier in final class 145 - 154

org/apache/myfaces/trinidadinternal/share/url/EncoderUtils.java

Violation Line
An empty statement (semicolon) not part of a loop 650

org/apache/myfaces/trinidadinternal/share/util/CaboHttpUtils.java

Violation Line
An empty statement (semicolon) not part of a loop 139

org/apache/myfaces/trinidadinternal/share/util/MultipartFormHandler.java

Violation Line
An empty statement (semicolon) not part of a loop 675

org/apache/myfaces/trinidadinternal/share/xml/ParseContextWrapper.java

Violation Line
Unnecessary final modifier in final class 142 - 145

org/apache/myfaces/trinidadinternal/share/xml/beans/BeanParser.java

Violation Line
These nested if statements could be combined 86 - 94

org/apache/myfaces/trinidadinternal/skin/AgentAtRuleMatcher.java

Violation Line
Unnecessary final modifier in final class 536 - 539
An empty statement (semicolon) not part of a loop 671
An empty statement (semicolon) not part of a loop 672
Unnecessary final modifier in final class 680 - 683
Unnecessary final modifier in final class 873 - 876

org/apache/myfaces/trinidadinternal/skin/SkinCSSDocumentHandler.java

Violation Line
Avoid unused method parameters such as 'expectedType'. 335 - 436

org/apache/myfaces/trinidadinternal/skin/SkinCSSParser.java

Violation Line
These nested if statements could be combined 82 - 85

org/apache/myfaces/trinidadinternal/skin/SkinExtension.java

Violation Line
These nested if statements could be combined 599 - 609
These nested if statements could be combined 625 - 633

org/apache/myfaces/trinidadinternal/skin/SkinImpl.java

Violation Line
These nested if statements could be combined 230 - 234

org/apache/myfaces/trinidadinternal/skin/SkinStyleSheetParserUtils.java

Violation Line
These nested if statements could be combined 156 - 157
These nested if statements could be combined 268 - 269

org/apache/myfaces/trinidadinternal/skin/SkinUtils.java

Violation Line
Avoid unused local variables such as 'sb'. 271
An empty statement (semicolon) not part of a loop 453

org/apache/myfaces/trinidadinternal/skin/StyleSheetEntry.java

Violation Line
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.share.xml.JaxpXMLProvider' 42
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.share.xml.XMLProvider' 44
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.style.xml.StyleSheetDocumentUtils' 47
An empty statement (semicolon) not part of a loop 217

org/apache/myfaces/trinidadinternal/skin/icon/BaseImageIcon.java

Violation Line
These nested if statements could be combined 217 - 218

org/apache/myfaces/trinidadinternal/skin/parse/CustomMetadataParser.java

Violation Line
Avoid unused imports such as 'org.apache.myfaces.trinidad.logging.TrinidadLogger' 25

org/apache/myfaces/trinidadinternal/skin/parse/SkinFeaturesParser.java

Violation Line
Avoid unused private fields such as '_LOG'. 111

org/apache/myfaces/trinidadinternal/skin/parse/SkinMetadataParser.java

Violation Line
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.XhtmlConstants' 29

org/apache/myfaces/trinidadinternal/skin/parse/SkinVersionParser.java

Violation Line
Avoid unused private fields such as '_LOG'. 109

org/apache/myfaces/trinidadinternal/skin/parse/SkinsNode.java

Violation Line
Avoid unused imports such as 'java.util.Collections' 21
Avoid unused imports such as 'java.util.Iterator' 22

org/apache/myfaces/trinidadinternal/skin/pregen/SkinPregenerationUtils.java

Violation Line
Avoid unused imports such as 'java.io.File' 23
Avoid unused imports such as 'java.io.FileNotFoundException' 24

org/apache/myfaces/trinidadinternal/skin/pregen/variant/AccessibilityVariantExtractor.java

Violation Line
Avoid unused imports such as 'java.util.Collections' 24

org/apache/myfaces/trinidadinternal/skin/pregen/variant/LocaleVariantExtractor.java

Violation Line
Avoid unused imports such as 'java.util.Collections' 23

org/apache/myfaces/trinidadinternal/skin/provider/BaseSkinProvider.java

Violation Line
These nested if statements could be combined 253 - 256
These nested if statements could be combined 349 - 361
These nested if statements could be combined 372 - 373

org/apache/myfaces/trinidadinternal/skin/provider/TrinidadBaseSkinProvider.java

Violation Line
Too many static imports may lead to messy code 19 - 249

org/apache/myfaces/trinidadinternal/style/UnmodifiableStyle.java

Violation Line
Avoid unused imports such as 'java.util.HashMap' 24
Avoid unused imports such as 'java.util.concurrent.ConcurrentHashMap' 25

org/apache/myfaces/trinidadinternal/style/cache/FileSystemStyleCache.java

Violation Line
These nested if statements could be combined 1392 - 1393
These nested if statements could be combined 1635 - 1637
These nested if statements could be combined 1636 - 1637
Avoid unused private fields such as '_outputDirectory'. 1892

org/apache/myfaces/trinidadinternal/style/util/CSSGenerationUtils.java

Violation Line
These nested if statements could be combined 840 - 847
Avoid empty if statements 995 - 997
Avoid unnecessary return statements 1004
These nested if statements could be combined 1117 - 1124

org/apache/myfaces/trinidadinternal/style/util/CSSUtils.java

Violation Line
An empty statement (semicolon) not part of a loop 548
These nested if statements could be combined 850 - 855

org/apache/myfaces/trinidadinternal/style/util/StyleUtils.java

Violation Line
Avoid unused private fields such as '_DOUBLE_COLON'. 167

org/apache/myfaces/trinidadinternal/style/xml/StyleSheetDocumentUtils.java

Violation Line
Avoid unused imports such as 'java.io.File' 21
Avoid unused imports such as 'java.io.IOException' 22
Avoid unused imports such as 'org.xml.sax.InputSource' 28
Avoid unused imports such as 'org.xml.sax.SAXException' 29
Avoid unused imports such as 'org.apache.myfaces.trinidad.share.io.NameResolver' 31
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.share.io.DefaultNameResolver' 32
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.share.xml.ParseContextImpl' 35
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.share.xml.XMLProvider' 38
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.share.xml.XMLUtils' 39
Avoid unused private methods such as '_getDefaultParserManager()'. 134
Avoid unused private fields such as '_LOG'. 172

org/apache/myfaces/trinidadinternal/style/xml/parse/ColorNodeParser.java

Violation Line
These nested if statements could be combined 63 - 64

org/apache/myfaces/trinidadinternal/style/xml/parse/ColorValidater.java

Violation Line
These nested if statements could be combined 47 - 48

org/apache/myfaces/trinidadinternal/style/xml/parse/EmbeddedIncludePropertyNode.java

Violation Line
Avoid unused private fields such as '_LOG'. 143

org/apache/myfaces/trinidadinternal/style/xml/parse/StyleSheetDocument.java

Violation Line
These nested if statements could be combined 1343 - 1344
An empty statement (semicolon) not part of a loop 2033
An empty statement (semicolon) not part of a loop 2058
Avoid unused private fields such as '_propertyCount'. 2116
Avoid unused private fields such as '_skinPropertyCount'. 2117
Avoid unused private fields such as '_IE_SUPPRESSED_PROPERTIES'. 2128
Avoid unused private fields such as '_DESTYLED_SUPPRESSED_PROPERTIES'. 2132

org/apache/myfaces/trinidadinternal/style/xml/parse/StyleSheetDocumentParser.java

Violation Line
Avoid unused imports such as 'java.net.URLConnection' 25
These nested if statements could be combined 156 - 162

org/apache/myfaces/trinidadinternal/style/xml/parse/StyleSheetNode.java

Violation Line
Avoid unused private methods such as '_copyLocaleArrayToSet(Locale)'. 531

org/apache/myfaces/trinidadinternal/taglib/ForEachTag.java

Violation Line
These nested if statements could be combined 476 - 480

org/apache/myfaces/trinidadinternal/taglib/listener/FileDownloadActionListenerTag.java

Violation Line
Avoid unused local variables such as 'parentELContext'. 74
Avoid unused local variables such as 'application'. 77

org/apache/myfaces/trinidadinternal/taglib/listener/ResetActionListenerTag.java

Violation Line
Overriding method merely calls super 63 - 66

org/apache/myfaces/trinidadinternal/taglib/listener/ReturnActionListenerTag.java

Violation Line
Avoid unused local variables such as 'parentELContext'. 66
Avoid unused local variables such as 'application'. 69

org/apache/myfaces/trinidadinternal/taglib/listener/SetActionListenerTag.java

Violation Line
Avoid unused local variables such as 'parentELContext'. 72
Avoid unused local variables such as 'application'. 75

org/apache/myfaces/trinidadinternal/taglib/util/TagUtils.java

Violation Line
Avoid unused imports such as 'javax.faces.application.Application' 34
Avoid unused imports such as 'javax.faces.context.FacesContext' 35
Unnecessary final modifier in final class 334 - 345

org/apache/myfaces/trinidadinternal/ui/BaseRenderer.java

Violation Line
These nested if statements could be combined 87 - 88

org/apache/myfaces/trinidadinternal/ui/RootRenderingContext.java

Violation Line
Avoid unused imports such as 'org.apache.myfaces.trinidad.context.RequestContext' 29
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.agent.TrinidadAgent' 50
These nested if statements could be combined 348 - 360
These nested if statements could be combined 350 - 359

org/apache/myfaces/trinidadinternal/ui/beans/BaseWebBean.java

Violation Line
Overriding method merely calls super 330 - 336
Overriding method merely calls super 344 - 348

org/apache/myfaces/trinidadinternal/ui/collection/FlaggedAttributeMap.java

Violation Line
These nested if statements could be combined 75 - 78

org/apache/myfaces/trinidadinternal/ui/laf/base/BaseLafRenderer.java

Violation Line
These nested if statements could be combined 571 - 575

org/apache/myfaces/trinidadinternal/ui/laf/base/BaseLafUtils.java

Violation Line
Avoid unused imports such as 'java.beans.Beans' 23
Avoid unused imports such as 'org.apache.myfaces.trinidad.style.Style' 35
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.style.StyleContext' 44
These nested if statements could be combined 144 - 145
Avoid unused method parameters such as 'context'. 1035 - 1069
Avoid empty if statements 1046 - 1059
An empty statement (semicolon) not part of a loop 1084

org/apache/myfaces/trinidadinternal/ui/laf/base/desktop/GlobalButtonRenderer.java

Violation Line
These nested if statements could be combined 149 - 155

org/apache/myfaces/trinidadinternal/ui/laf/base/desktop/MessageWrapper.java

Violation Line
Avoid unused imports such as 'javax.faces.el.ValueBinding' 23

org/apache/myfaces/trinidadinternal/ui/laf/base/pda/GlobalHeaderRenderer.java

Violation Line
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.style.CoreStyle' 29

org/apache/myfaces/trinidadinternal/ui/laf/base/pda/LinkRenderer.java

Violation Line
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.ui.laf.base.BaseLafUtils' 27

org/apache/myfaces/trinidadinternal/ui/laf/base/pda/ShowItemRenderer.java

Violation Line
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.share.url.URLEncoder' 26

org/apache/myfaces/trinidadinternal/ui/laf/base/pda/TabBarRenderer.java

Violation Line
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.style.CoreStyle' 29

org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/AccentedLafIconProvider.java

Violation Line
These nested if statements could be combined 129 - 130
Avoid unused method parameters such as 'styleClass'. 244 - 288

org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/BreadCrumbsRenderer.java

Violation Line
Avoid unused method parameters such as 'isLastChild'. 375 - 392
Avoid unused constructor parameters such as 'breadCrumbs'. 443 - 455

org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/ChoiceRenderer.java

Violation Line
These nested if statements could be combined 84 - 95

org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/CommandItemRenderer.java

Violation Line
Avoid unused imports such as 'org.apache.myfaces.trinidad.component.UIXCommand' 26

org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/FormElementRenderer.java

Violation Line
These nested if statements could be combined 125 - 130
These nested if statements could be combined 154 - 158

org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/HiddenLabelUtils.java

Violation Line
These nested if statements could be combined 72 - 82

org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/ImageRenderer.java

Violation Line
These nested if statements could be combined 350 - 353

org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/LinkRenderer.java

Violation Line
These nested if statements could be combined 104 - 105

org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/NavigationBarRenderer.java

Violation Line
These nested if statements could be combined 1338 - 1342
These nested if statements could be combined 2448 - 2451

org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/NavigationPathRenderer.java

Violation Line
Avoid unused method parameters such as 'isLastChild'. 311 - 328
Avoid unused constructor parameters such as 'breadCrumbs'. 379 - 391

org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/ProcessChoiceBarRenderer.java

Violation Line
These nested if statements could be combined 696 - 699

org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/ProcessUtils.java

Violation Line
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.XhtmlUtils' 31
Avoid unused private methods such as '_createKeyValueArray(String,String,String,String,long,String,int,String,String)'. 351 - 361

org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/ShowItemRenderer.java

Violation Line
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.share.url.URLEncoder' 23

org/apache/myfaces/trinidadinternal/ui/laf/base/xhtml/XhtmlLafRenderer.java

Violation Line
These nested if statements could be combined 331 - 344
These nested if statements could be combined 1436 - 1447
These nested if statements could be combined 1477 - 1478
These nested if statements could be combined 1848 - 1852
These nested if statements could be combined 2162 - 2172
These nested if statements could be combined 2207 - 2208

org/apache/myfaces/trinidadinternal/ui/laf/simple/desktop/SimpleButtonUtils.java

Violation Line
These nested if statements could be combined 116 - 121
Avoid unused constructor parameters such as 'fContext'. 191 - 225
Avoid unused constructor parameters such as 'arc'. 191 - 225

org/apache/myfaces/trinidadinternal/uinode/UINodeFacesBean.java

Violation Line
These nested if statements could be combined 232 - 237
These nested if statements could be combined 255 - 256

org/apache/myfaces/trinidadinternal/util/ClassLoaderUtils.java

Violation Line
Avoid empty catch blocks 130 - 133
These nested if statements could be combined 386 - 389

org/apache/myfaces/trinidadinternal/util/ClassUtils.java

Violation Line
Avoid unused imports such as 'java.util.Arrays' 31
Avoid empty catch blocks 581 - 584

org/apache/myfaces/trinidadinternal/util/CopyOnWriteArrayMap.java

Violation Line
Avoid unused method parameters such as 'inStream'. 1131 - 1134

org/apache/myfaces/trinidadinternal/util/DateUtils.java

Violation Line
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.config.ConfigParser' 25

org/apache/myfaces/trinidadinternal/util/JavaIntrospector.java

Violation Line
An empty statement (semicolon) not part of a loop 433
An empty statement (semicolon) not part of a loop 447
An empty statement (semicolon) not part of a loop 467
These nested if statements could be combined 660 - 674
An empty statement (semicolon) not part of a loop 1344
An empty statement (semicolon) not part of a loop 1552
An empty statement (semicolon) not part of a loop 2076
An empty statement (semicolon) not part of a loop 2149
An empty statement (semicolon) not part of a loop 2204
An empty statement (semicolon) not part of a loop 2243

org/apache/myfaces/trinidadinternal/util/MessageUtils.java

Violation Line
Avoid unused imports such as 'javax.faces.application.FacesMessage.Severity' 24
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.MessageWrapper' 35

org/apache/myfaces/trinidadinternal/util/MimeUtility.java

Violation Line
Avoid empty catch blocks 72 - 75
An empty statement (semicolon) not part of a loop 192

org/apache/myfaces/trinidadinternal/util/ObjectInputStreamResolveClass.java

Violation Line
Avoid unused imports such as 'org.apache.myfaces.trinidadinternal.util.ObjectInputStreamResolveClass' 28
No need to import a type that lives in the same package 28

org/apache/myfaces/trinidadinternal/util/StateUtils.java

Violation Line
These nested if statements could be combined 211 - 217
Unnecessary final modifier in final class 247 - 267
Unnecessary final modifier in final class 278 - 307
Unnecessary final modifier in final class 362 - 381
Unnecessary final modifier in final class 383 - 386
Unnecessary final modifier in final class 391 - 421
Unnecessary final modifier in final class 423 - 426
Unnecessary final modifier in final class 428 - 461
Unnecessary final modifier in final class 543 - 650
Avoid empty catch blocks 638 - 643

org/apache/myfaces/trinidadinternal/util/TokenCache.java

Violation Line
These nested if statements could be combined 79 - 97

org/apache/myfaces/trinidadinternal/util/URLUtils.java

Violation Line
Avoid empty catch blocks 79 - 82

org/apache/myfaces/trinidadinternal/validator/ByteLengthValidator.java

Violation Line
Avoid unused method parameters such as 'maxLength'. 147 - 172
Avoid unused method parameters such as 'context'. 147 - 172

org/apache/myfaces/trinidadinternal/validator/DateRestrictionValidator.java

Violation Line
Avoid unused method parameters such as 'component'. 141 - 172
Avoid unused method parameters such as 'context'. 141 - 172

org/apache/myfaces/trinidadinternal/validator/DateTimeRangeValidator.java

Violation Line
Avoid unused method parameters such as 'component'. 148 - 185
Avoid unused method parameters such as 'context'. 148 - 185

org/apache/myfaces/trinidadinternal/validator/DoubleRangeValidator.java

Violation Line
Avoid unused method parameters such as 'component'. 102 - 133
Avoid unused method parameters such as 'context'. 102 - 133

org/apache/myfaces/trinidadinternal/validator/LengthValidator.java

Violation Line
Avoid unused method parameters such as 'component'. 135 - 169
Avoid unused method parameters such as 'context'. 135 - 169

org/apache/myfaces/trinidadinternal/validator/LongRangeValidator.java

Violation Line
Avoid unused method parameters such as 'component'. 103 - 134
Avoid unused method parameters such as 'context'. 103 - 134

org/apache/myfaces/trinidadinternal/validator/RegExpValidator.java

Violation Line
Avoid unused method parameters such as 'context'. 88 - 113

org/apache/myfaces/trinidadinternal/webapp/TrinidadFilterImpl.java

Violation Line
Avoid unused imports such as 'javax.faces.FactoryFinder' 29
Avoid unused imports such as 'javax.faces.context.FacesContextFactory' 33

org/apache/myfaces/trinidadinternal/webapp/wrappers/BasicHTMLBrowserRequestWrapper.java

Violation Line
Avoid unused imports such as 'java.util.Iterator' 24
Avoid unused imports such as 'java.util.Set' 26