FindBugs Bug Detector Report
The following document contains the results of FindBugs Report
FindBugs Version is 1.0.0
Threshold is Low
Effort is Default
Files
org.apache.myfaces.trinidad.resource.AggregatingResourceLoader$AggregatingURLConnection
| Bug | Category | Details | Line |
|---|---|---|---|
| org.apache.myfaces.trinidad.resource.AggregatingResourceLoader$AggregatingURLConnection.getInputStream() may fail to close stream | CORRECTNESS | OS_OPEN_STREAM | 234 |
org.apache.myfaces.trinidad.event.SelectionEvent
| Bug | Category | Details | Line |
|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.event.FacesListener to class org.apache.myfaces.trinidad.event.SelectionListener in org.apache.myfaces.trinidad.event.SelectionEvent.processListener(javax.faces.event.FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 61 |
org.apache.myfaces.trinidad.event.AttributeChangeEvent
| Bug | Category | Details | Line |
|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.event.FacesListener to class org.apache.myfaces.trinidad.event.AttributeChangeListener in org.apache.myfaces.trinidad.event.AttributeChangeEvent.processListener(javax.faces.event.FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 77 |
org.apache.myfaces.trinidad.event.ChartDrillDownEvent
| Bug | Category | Details | Line |
|---|---|---|---|
| Should org.apache.myfaces.trinidad.event.ChartDrillDownEvent.getSeriesIndices() return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 67 |
| Should org.apache.myfaces.trinidad.event.ChartDrillDownEvent.getYValueIndices() return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 84 |
| Should org.apache.myfaces.trinidad.event.ChartDrillDownEvent.getYValues() return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 100 |
| Should org.apache.myfaces.trinidad.event.ChartDrillDownEvent.getXValues() return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 117 |
| Unchecked/unconfirmed cast from javax.faces.event.FacesListener to class org.apache.myfaces.trinidad.event.ChartDrillDownListener in org.apache.myfaces.trinidad.event.ChartDrillDownEvent.processListener(javax.faces.event.FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 54 |
org.apache.myfaces.trinidad.event.ReturnEvent
| Bug | Category | Details | Line |
|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.event.FacesListener to class org.apache.myfaces.trinidad.event.ReturnListener in org.apache.myfaces.trinidad.event.ReturnEvent.processListener(javax.faces.event.FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 73 |
org.apache.myfaces.trinidad.event.RowDisclosureEvent
| Bug | Category | Details | Line |
|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.event.FacesListener to class org.apache.myfaces.trinidad.event.RowDisclosureListener in org.apache.myfaces.trinidad.event.RowDisclosureEvent.processListener(javax.faces.event.FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 62 |
org.apache.myfaces.trinidad.event.RangeChangeEvent
| Bug | Category | Details | Line |
|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.event.FacesListener to class org.apache.myfaces.trinidad.event.RangeChangeListener in org.apache.myfaces.trinidad.event.RangeChangeEvent.processListener(javax.faces.event.FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 103 |
org.apache.myfaces.trinidad.event.DisclosureEvent
| Bug | Category | Details | Line |
|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.event.FacesListener to class org.apache.myfaces.trinidad.event.DisclosureListener in org.apache.myfaces.trinidad.event.DisclosureEvent.processListener(javax.faces.event.FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 48 |
org.apache.myfaces.trinidad.event.LaunchEvent
| Bug | Category | Details | Line |
|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.event.FacesListener to class org.apache.myfaces.trinidad.event.LaunchListener in org.apache.myfaces.trinidad.event.LaunchEvent.processListener(javax.faces.event.FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 108 |
org.apache.myfaces.trinidad.event.FocusEvent
| Bug | Category | Details | Line |
|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.event.FacesListener to class org.apache.myfaces.trinidad.event.FocusListener in org.apache.myfaces.trinidad.event.FocusEvent.processListener(javax.faces.event.FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 46 |
org.apache.myfaces.trinidad.event.SortEvent
| Bug | Category | Details | Line |
|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.event.FacesListener to class org.apache.myfaces.trinidad.event.SortListener in org.apache.myfaces.trinidad.event.SortEvent.processListener(javax.faces.event.FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 63 |
org.apache.myfaces.trinidad.event.PollEvent
| Bug | Category | Details | Line |
|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.event.FacesListener to class org.apache.myfaces.trinidad.event.PollListener in org.apache.myfaces.trinidad.event.PollEvent.processListener(javax.faces.event.FacesListener) | STYLE | BC_UNCONFIRMED_CAST | 40 |
org.apache.myfaces.trinidad.model.XMLMenuModel
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.apache.myfaces.trinidad.model.XMLMenuModel._createModel() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | STYLE | REC_CATCH_EXCEPTION | 620 |
org.apache.myfaces.trinidad.model.SortableModel$Comp
| Bug | Category | Details | Line |
|---|---|---|---|
| org.apache.myfaces.trinidad.model.SortableModel$Comp implements Comparator but not Serializable | STYLE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | Not available |
org.apache.myfaces.trinidad.model.SortableModel$Inverter
| Bug | Category | Details | Line |
|---|---|---|---|
| org.apache.myfaces.trinidad.model.SortableModel$Inverter implements Comparator but not Serializable | STYLE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | Not available |
org.apache.myfaces.trinidad.validator.DoubleRangeValidator
| Bug | Category | Details | Line |
|---|---|---|---|
| Test for floating point equality in org.apache.myfaces.trinidad.validator.DoubleRangeValidator.validate(javax.faces.context.FacesContext,javax.faces.component.UIComponent,Object). | CORRECTNESS | FE_FLOATING_POINT_EQUALITY | 322 |
org.apache.myfaces.trinidad.validator.DateRestrictionValidator
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.apache.myfaces.trinidad.validator.DateRestrictionValidator._getInvalidMonths() invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | I18N | DM_CONVERT_CASE | 512 |
| Method org.apache.myfaces.trinidad.validator.DateRestrictionValidator._getInvalidDaysOfWeek() invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | I18N | DM_CONVERT_CASE | 527 |
org.apache.myfaces.trinidad.bean.FacesBeanFactory
| Bug | Category | Details | Line |
|---|---|---|---|
| Possible null pointer dereference in org.apache.myfaces.trinidad.bean.FacesBeanFactory.createFacesBean(String,String) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 104 |
| Possible null pointer dereference in org.apache.myfaces.trinidad.bean.FacesBeanFactory.createFacesBean(String,String) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 108 |
| Possible null pointer dereference in org.apache.myfaces.trinidad.bean.FacesBeanFactory.createFacesBean(String,String) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 113 |
org.apache.myfaces.trinidad.component.UIXComponentBase
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.apache.myfaces.trinidad.component.UIXComponentBase._createType() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | STYLE | REC_CATCH_EXCEPTION | 1416 |
org.apache.myfaces.trinidad.component.UIXCollection
| Bug | Category | Details | Line |
|---|---|---|---|
| Useless control flow in org.apache.myfaces.trinidad.component.UIXCollection.encodeBegin(javax.faces.context.FacesContext) | CORRECTNESS | UCF_USELESS_CONTROL_FLOW | 514 |
| Useless control flow in org.apache.myfaces.trinidad.component.UIXCollection.encodeEnd(javax.faces.context.FacesContext) | CORRECTNESS | UCF_USELESS_CONTROL_FLOW | 524 |
| Dead store to childCount in method org.apache.myfaces.trinidad.component.UIXCollection.saveStampState(javax.faces.context.FacesContext,javax.faces.component.UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 801 |
org.apache.myfaces.trinidad.component.StampState$SDState
| Bug | Category | Details | Line |
|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to class org.apache.myfaces.trinidad.component.UIXShowDetail in org.apache.myfaces.trinidad.component.StampState$SDState.saveRowState(javax.faces.component.UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 361 |
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to class org.apache.myfaces.trinidad.component.UIXShowDetail in org.apache.myfaces.trinidad.component.StampState$SDState.restoreRowState(javax.faces.component.UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 368 |
org.apache.myfaces.trinidad.component.StampState$TableState
| Bug | Category | Details | Line |
|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to class org.apache.myfaces.trinidad.component.UIXCollection in org.apache.myfaces.trinidad.component.StampState$TableState.saveRowState(javax.faces.component.UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 407 |
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to class org.apache.myfaces.trinidad.component.UIXCollection in org.apache.myfaces.trinidad.component.StampState$TableState.restoreRowState(javax.faces.component.UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 413 |
org.apache.myfaces.trinidad.component.StampState$EVHState
| Bug | Category | Details | Line |
|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to class javax.faces.component.EditableValueHolder in org.apache.myfaces.trinidad.component.StampState$EVHState.saveRowState(javax.faces.component.UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 439 |
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to class javax.faces.component.EditableValueHolder in org.apache.myfaces.trinidad.component.StampState$EVHState.restoreRowState(javax.faces.component.UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 451 |
org.apache.myfaces.trinidad.component.UIXTree
| Bug | Category | Details | Line |
|---|---|---|---|
| Class org.apache.myfaces.trinidad.component.UIXTree implements same interface as superclass. | STYLE | RI_REDUNDANT_INTERFACES | Not available |
org.apache.myfaces.trinidad.component.ChildArrayList
| Bug | Category | Details | Line |
|---|---|---|---|
| org.apache.myfaces.trinidad.component.ChildArrayList is Serializable; consider declaring a serialVersionUID | CORRECTNESS | SE_NO_SERIALVERSIONID | Not available |
| Class org.apache.myfaces.trinidad.component.ChildArrayList defines non-transient non-serializable instance field org.apache.myfaces.trinidad.component.ChildArrayList._parent | CORRECTNESS | SE_BAD_FIELD | Not available |
org.apache.myfaces.trinidad.component.UIXPage
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.apache.myfaces.trinidad.component.UIXPage.processFacetsAndChildren(javax.faces.context.FacesContext,javax.faces.event.PhaseId) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 159 |
org.apache.myfaces.trinidad.component.UIXNavigationLevel
| Bug | Category | Details | Line |
|---|---|---|---|
| Class org.apache.myfaces.trinidad.component.UIXNavigationLevel implements same interface as superclass. | STYLE | RI_REDUNDANT_INTERFACES | Not available |
org.apache.myfaces.trinidad.component.HierarchyUtils
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store to key in method org.apache.myfaces.trinidad.component.HierarchyUtils.__handleBroadcast(UIXHierarchy,javax.faces.event.FacesEvent,org.apache.myfaces.trinidad.model.RowKeySet,javax.faces.el.MethodBinding) | STYLE | DLS_DEAD_LOCAL_STORE | 58 |
org.apache.myfaces.trinidad.component.UIXNavigationPath
| Bug | Category | Details | Line |
|---|---|---|---|
| Class org.apache.myfaces.trinidad.component.UIXNavigationPath implements same interface as superclass. | STYLE | RI_REDUNDANT_INTERFACES | Not available |
org.apache.myfaces.trinidad.convert.DateTimeConverter
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.apache.myfaces.trinidad.convert.DateTimeConverter._getSimpleDateFormat(String,java.util.Locale) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | I18N | DM_CONVERT_CASE | 1435 |
| Class org.apache.myfaces.trinidad.convert.DateTimeConverter implements same interface as superclass. | STYLE | RI_REDUNDANT_INTERFACES | Not available |
org.apache.myfaces.trinidad.convert.RGBColorFormat
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.apache.myfaces.trinidad.convert.RGBColorFormat._subFormatHex(int,int,StringBuffer) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | I18N | DM_CONVERT_CASE | 553 |
org.apache.myfaces.trinidad.convert.ColorConverter
| Bug | Category | Details | Line |
|---|---|---|---|
| Possible null pointer dereference in org.apache.myfaces.trinidad.convert.ColorConverter._isEqualPatterns(String[]) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 587 |
| Possible null pointer dereference in org.apache.myfaces.trinidad.convert.ColorConverter._isEqualPatterns(String[]) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 587 |
org.apache.myfaces.trinidad.webapp.ResourceServlet$_ResourceLifecycle
| Bug | Category | Details | Line |
|---|---|---|---|
| Should org.apache.myfaces.trinidad.webapp.ResourceServlet$_ResourceLifecycle.getPhaseListeners() return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 510 |
org.apache.myfaces.trinidad.webapp.ResourceServlet
| Bug | Category | Details | Line |
|---|---|---|---|
| Class org.apache.myfaces.trinidad.webapp.ResourceServlet defines non-transient non-serializable instance field org.apache.myfaces.trinidad.webapp.ResourceServlet._facesContextFactory | CORRECTNESS | SE_BAD_FIELD | Not available |
| Class org.apache.myfaces.trinidad.webapp.ResourceServlet defines non-transient non-serializable instance field org.apache.myfaces.trinidad.webapp.ResourceServlet._lifecycle | CORRECTNESS | SE_BAD_FIELD | Not available |
| org.apache.myfaces.trinidad.webapp.ResourceServlet$_ResourceLifecycle stored into non-transient field org.apache.myfaces.trinidad.webapp.ResourceServlet._lifecycle | CORRECTNESS | SE_BAD_FIELD_STORE | 129 |
| Class org/apache/myfaces/trinidad/webapp/ResourceServlet._loaders extends Servlet class and uses instance variables. | STYLE | MTIA_SUSPECT_SERVLET_INSTANCE_FIELD | 91 |
| Class org/apache/myfaces/trinidad/webapp/ResourceServlet._facesContextFactory extends Servlet class and uses instance variables. | STYLE | MTIA_SUSPECT_SERVLET_INSTANCE_FIELD | 92 |
| Class org/apache/myfaces/trinidad/webapp/ResourceServlet._lifecycle extends Servlet class and uses instance variables. | STYLE | MTIA_SUSPECT_SERVLET_INSTANCE_FIELD | 93 |
| Class org/apache/myfaces/trinidad/webapp/ResourceServlet._debug extends Servlet class and uses instance variables. | STYLE | MTIA_SUSPECT_SERVLET_INSTANCE_FIELD | 420 |
org.apache.myfaces.trinidad.webapp.UIXComponentTag
| Bug | Category | Details | Line |
|---|---|---|---|
| Should org.apache.myfaces.trinidad.webapp.UIXComponentTag._parseNameTokens(String) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 552 |
| Unchecked/unconfirmed cast from javax.servlet.jsp.tagext.Tag to class org.apache.myfaces.trinidad.webapp.ELContextTag in org.apache.myfaces.trinidad.webapp.UIXComponentTag.doStartTag() | STYLE | BC_UNCONFIRMED_CAST | 81 |
org.apache.myfaces.trinidad.util.MessageFactory$CustomDetailErrorMessage
| Bug | Category | Details | Line |
|---|---|---|---|
| Class org.apache.myfaces.trinidad.util.MessageFactory$CustomDetailErrorMessage defines non-transient non-serializable instance field org.apache.myfaces.trinidad.util.MessageFactory$CustomDetailErrorMessage._customDetailErrorMessage | CORRECTNESS | SE_BAD_FIELD | Not available |
org.apache.myfaces.trinidad.util.ClassLoaderUtils
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.apache.myfaces.trinidad.util.ClassLoaderUtils.getServices(String) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught | STYLE | REC_CATCH_EXCEPTION | 275 |
org.apache.myfaces.trinidad.util.Base64InputStream
| Bug | Category | Details | Line |
|---|---|---|---|
| org.apache.myfaces.trinidad.convert.ColorConverter.DEFAULT_COLOR_FORMAT_PATTERNS should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 147 |
| The class org.apache.myfaces.trinidad.component.UIXComponentRef$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Should org.apache.myfaces.trinidad.resource.AggregatingResourceLoader$AggregatingURLStreamHandler be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| The class org.apache.myfaces.trinidad.webapp.ResourceServlet$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |