Checkstyle Results

The following document contains the results of Checkstyle . 

Summary

Files	Infos	Warnings	Errors
28	0	0	499

Files

Files	I	W	E
org/apache/myfaces/component/MethodBindingToMethodExpression.java	0	0	9
org/apache/myfaces/component/MethodExpressionToMethodBinding.java	0	0	21
org/apache/myfaces/converter/ConverterTag.java	0	0	1
org/apache/myfaces/custom/aliasbean/Alias.java	0	0	28
org/apache/myfaces/custom/aliasbean/AliasBean.java	0	0	14
org/apache/myfaces/custom/aliasbean/AliasBeansScope.java	0	0	8
org/apache/myfaces/custom/buffer/AbstractBuffer.java	0	0	5
org/apache/myfaces/custom/fileupload/AbstractHtmlInputFileUpload.java	0	0	4
org/apache/myfaces/custom/htmlTag/AbstractHtmlTag.java	0	0	1
org/apache/myfaces/custom/htmlTag/HtmlTagRenderer.java	0	0	7
org/apache/myfaces/custom/navigation/AbstractHtmlPanelNavigation.java	0	0	2
org/apache/myfaces/custom/navmenu/AbstractUINavigationMenuItem.java	0	0	40
org/apache/myfaces/custom/schedule/UISchedule.java	0	0	2
org/apache/myfaces/custom/selectitems/AbstractUISelectItems.java	0	0	16
org/apache/myfaces/custom/tabbedpane/TabChangeListenerTag.java	0	0	2
org/apache/myfaces/custom/tree/taglib/AbstractTreeTag.java	0	0	19
org/apache/myfaces/custom/updateactionlistener/UpdateActionListenerTag.java	0	0	6
org/apache/myfaces/renderkit/html/ext/HtmlCheckboxRenderer.java	0	0	23
org/apache/myfaces/renderkit/html/ext/HtmlMessageRenderer.java	0	0	20
org/apache/myfaces/renderkit/html/ext/HtmlRadioRenderer.java	0	0	5
org/apache/myfaces/renderkit/html/ext/HtmlTableRenderer.java	0	0	187
org/apache/myfaces/tomahawk/application/jsp/JspTilesTwoViewHandlerImpl.java	0	0	42
org/apache/myfaces/tomahawk/application/jsp/ViewResponseWrapper.java	0	0	10
org/apache/myfaces/validator/ValidatorBase.java	0	0	21
org/apache/myfaces/validator/ValidatorBaseTag.java	0	0	6

Rules

Rules	Violations	Severity
ConstantName format : "^_?((log)|([a-z][a-zA-Z]*ThreadLocal)|([A-Z][A-Z0-9]*(_[A-Z0-9]+)*))$"	0	Error
LocalVariableName	0	Error
MethodName format : "^_?[a-z][a-zA-Z0-9]*$"	0	Error
PackageName	0	Error
LocalFinalVariableName	1	Error
ParameterName	0	Error
StaticVariableName	0	Error
TypeName format : "^_?[A-Z][a-zA-Z0-9]*$"	0	Error
Header headerFile : "/home/lu4242/workspace/tomahawk/119/branches/1_1_9/core12/target/checkstyle-header.txt"	0	Error
AvoidStarImport	1	Error
IllegalImport	0	Error
RedundantImport	0	Error
UnusedImports	5	Error
FileLength	0	Error
LineLength ignorePattern : "@version|@see" max : "120"	26	Error
MethodLength max : "200"	0	Error
ParameterNumber max : "10"	0	Error
TabCharacter	0	Error
NeedBraces	83	Error
LeftCurly option : "nl"	357	Error
RightCurly option : "alone"	15	Error
DoubleCheckedLocking	0	Error
EmptyStatement	1	Error
EqualsHashCode	0	Error
InnerAssignment	2	Error
DefaultComesLast	0	Error
MissingSwitchDefault	0	Error
FallThrough	0	Error
MultipleVariableDeclarations	8	Error
UpperEll	0	Error

Details

org/apache/myfaces/component/MethodBindingToMethodExpression.java

Violation	Message	Line
	'if' construct must use '{}'s.	132
	Name 'PRIME' must match pattern '^[a-z][a-zA-Z0-9]*$'.	191
	'if' construct must use '{}'s.	200
	'if' construct must use '{}'s.	202
	'if' construct must use '{}'s.	204
	'if' construct must use '{}'s.	209
	'if' construct must use '{}'s.	212
	'if' construct must use '{}'s.	219
	'if' construct must use '{}'s.	225

org/apache/myfaces/component/MethodExpressionToMethodBinding.java

Violation	Message	Line
	'{' should be on a new line.	43
	'{' should be on a new line.	49
	'{' should be on a new line.	54
	'{' should be on a new line.	65
	'{' should be on a new line.	67
	'}' should be alone on a line.	69
	'{' should be on a new line.	69
	'}' should be alone on a line.	71
	'{' should be on a new line.	71
	'{' should be on a new line.	77
	'{' should be on a new line.	79
	'}' should be alone on a line.	81
	'{' should be on a new line.	81
	'}' should be alone on a line.	83
	'{' should be on a new line.	83
	'{' should be on a new line.	90
	'if' construct must use '{}'s.	91
	'{' should be on a new line.	95
	'if' construct must use '{}'s.	96
	'{' should be on a new line.	101
	'{' should be on a new line.	105

org/apache/myfaces/converter/ConverterTag.java

Violation	Message	Line
	'}' should be alone on a line.	114

org/apache/myfaces/custom/aliasbean/Alias.java

Violation	Message	Line
	Unused import - javax.faces.el.ValueBinding.	24
	'{' should be on a new line.	41
	'{' should be on a new line.	51
	'{' should be on a new line.	59
	'{' should be on a new line.	70
	'{' should be on a new line.	74
	'{' should be on a new line.	78
	'{' should be on a new line.	82
	'{' should be on a new line.	86
	'{' should be on a new line.	92
	'if' construct must use '{}'s.	93
	'{' should be on a new line.	97
	'{' should be on a new line.	102
	'{' should be on a new line.	103
	'}' should be alone on a line.	109
	'{' should be on a new line.	109
	'}' should be alone on a line.	112
	'{' should be on a new line.	112
	'{' should be on a new line.	120
	'if' construct must use '{}'s.	121
	'{' should be on a new line.	125
	'if' construct must use '{}'s.	127
	'if' construct must use '{}'s.	130
	'}' should be alone on a line.	132
	'{' should be on a new line.	132
	'{' should be on a new line.	148
	'if' construct must use '{}'s.	150
	'if' construct must use '{}'s.	157

org/apache/myfaces/custom/aliasbean/AliasBean.java

Violation	Message	Line
	Unused import - org.apache.myfaces.shared_tomahawk.util._ComponentUtils.	43
	'{' should be on a new line.	119
	'if' construct must use '{}'s.	146
	'if' construct must use '{}'s.	184
	'if' construct must use '{}'s.	186
	'if' construct must use '{}'s.	195
	'if' construct must use '{}'s.	211
	'if' construct must use '{}'s.	225
	'if' construct must use '{}'s.	270
	'if' construct must use '{}'s.	284
	'if' construct must use '{}'s.	298
	'{' should be on a new line.	308
	'{' should be on a new line.	313
	'if' construct must use '{}'s.	368

org/apache/myfaces/custom/aliasbean/AliasBeansScope.java

Violation	Message	Line
	'{' should be on a new line.	92
	'if' construct must use '{}'s.	114
	'if' construct must use '{}'s.	116
	'if' construct must use '{}'s.	125
	'if' construct must use '{}'s.	142
	'if' construct must use '{}'s.	156
	'for' construct must use '{}'s.	268
	'for' construct must use '{}'s.	280

org/apache/myfaces/custom/buffer/AbstractBuffer.java

Violation	Message	Line
	'{' should be on a new line.	79
	'{' should be on a new line.	89
	'{' should be on a new line.	92
	'}' should be alone on a line.	95
	'{' should be on a new line.	95

org/apache/myfaces/custom/fileupload/AbstractHtmlInputFileUpload.java

Violation	Message	Line
	'if' construct must use '{}'s.	127
	'{' should be on a new line.	190
	'if' construct must use '{}'s.	192
	'if' construct must use '{}'s.	196

org/apache/myfaces/custom/htmlTag/AbstractHtmlTag.java

Violation	Message	Line
	'if' construct must use '{}'s.	83

org/apache/myfaces/custom/htmlTag/HtmlTagRenderer.java

Violation	Message	Line
	Unused import - org.apache.myfaces.component.html.util.HtmlComponentUtils.	32
	'if' construct must use '{}'s.	63
	'{' should be on a new line.	93
	'{' should be on a new line.	95
	'{' should be on a new line.	97
	'{' should be on a new line.	100
	'if' construct must use '{}'s.	131

org/apache/myfaces/custom/navigation/AbstractHtmlPanelNavigation.java

Violation	Message	Line
	Line is longer than 120 characters.	70
	Line is longer than 120 characters.	111

org/apache/myfaces/custom/navmenu/AbstractUINavigationMenuItem.java

Violation	Message	Line
	'{' should be on a new line.	60
	'{' should be on a new line.	66
	'{' should be on a new line.	70
	'{' should be on a new line.	142
	'{' should be on a new line.	187
	'{' should be on a new line.	191
	'{' should be on a new line.	195
	'{' should be on a new line.	225
	'{' should be on a new line.	228
	'{' should be on a new line.	232
	'{' should be on a new line.	233
	'{' should be on a new line.	237
	'{' should be on a new line.	240
	'{' should be on a new line.	243
	'{' should be on a new line.	251
	'{' should be on a new line.	274
	'{' should be on a new line.	283
	'if' construct must use '{}'s.	284
	'{' should be on a new line.	289
	'{' should be on a new line.	291
	'{' should be on a new line.	293
	'{' should be on a new line.	298
	'{' should be on a new line.	304
	Inner assignments should be avoided.	307
	'{' should be on a new line.	307
	'if' construct must use '{}'s.	309
	'else' construct must use '{}'s.	311
	'{' should be on a new line.	316
	'{' should be on a new line.	318
	'{' should be on a new line.	321
	'{' should be on a new line.	326
	'{' should be on a new line.	328
	'{' should be on a new line.	331
	'{' should be on a new line.	335
	'{' should be on a new line.	338
	'{' should be on a new line.	345
	'{' should be on a new line.	346
	'{' should be on a new line.	348
	'{' should be on a new line.	351
	'{' should be on a new line.	358

org/apache/myfaces/custom/schedule/UISchedule.java

Violation	Message	Line
	'{' should be on a new line.	201
	'{' should be on a new line.	352

org/apache/myfaces/custom/selectitems/AbstractUISelectItems.java

Violation	Message	Line
	'{' should be on a new line.	48
	'{' should be on a new line.	97
	'{' should be on a new line.	102
	'{' should be on a new line.	105
	'{' should be on a new line.	108
	'{' should be on a new line.	110
	'{' should be on a new line.	112
	'{' should be on a new line.	115
	'{' should be on a new line.	119
	'{' should be on a new line.	127
	'{' should be on a new line.	129
	'{' should be on a new line.	141
	'if' construct must use '{}'s.	149
	'else' construct must use '{}'s.	151
	'{' should be on a new line.	157
	'{' should be on a new line.	161

org/apache/myfaces/custom/tabbedpane/TabChangeListenerTag.java

Violation	Message	Line
	'else' construct must use '{}'s.	103
	Line is longer than 120 characters.	104

org/apache/myfaces/custom/tree/taglib/AbstractTreeTag.java

Violation	Message	Line
	'{' should be on a new line.	40
	'{' should be on a new line.	46
	'{' should be on a new line.	50
	'{' should be on a new line.	54
	'{' should be on a new line.	58
	'{' should be on a new line.	62
	'{' should be on a new line.	66
	'{' should be on a new line.	73
	'{' should be on a new line.	76
	'{' should be on a new line.	79
	'{' should be on a new line.	88
	'{' should be on a new line.	92
	'{' should be on a new line.	102
	'{' should be on a new line.	111
	'{' should be on a new line.	116
	'{' should be on a new line.	117
	'}' should be alone on a line.	120
	'{' should be on a new line.	120
	'{' should be on a new line.	122

org/apache/myfaces/custom/updateactionlistener/UpdateActionListenerTag.java

Violation	Message	Line
	'if' construct must use '{}'s.	105
	'if' construct must use '{}'s.	106
	'if' construct must use '{}'s.	107
	Line is longer than 120 characters.	107
	Line is longer than 120 characters.	110
	'{' should be on a new line.	111

org/apache/myfaces/renderkit/html/ext/HtmlCheckboxRenderer.java

Violation	Message	Line
	'if' construct must use '{}'s.	80
	'if' construct must use '{}'s.	81
	'{' should be on a new line.	251
	Line is longer than 120 characters.	266
	'{' should be on a new line.	317
	'if' construct must use '{}'s.	321
	'{' should be on a new line.	327
	'{' should be on a new line.	336
	Line is longer than 120 characters.	337
	'if' construct must use '{}'s.	342
	'{' should be on a new line.	353
	'{' should be on a new line.	355
	'{' should be on a new line.	367
	'{' should be on a new line.	369
	'}' should be alone on a line.	371
	'{' should be on a new line.	371
	'{' should be on a new line.	376
	'{' should be on a new line.	377
	'{' should be on a new line.	380
	'}' should be alone on a line.	383
	'{' should be on a new line.	383
	Line is longer than 120 characters.	405
	'{' should be on a new line.	484

org/apache/myfaces/renderkit/html/ext/HtmlMessageRenderer.java

Violation	Message	Line
	'if' construct must use '{}'s.	83
	'if' construct must use '{}'s.	85
	'if' construct must use '{}'s.	98
	'if' construct must use '{}'s.	101
	'if' construct must use '{}'s.	102
	'if' construct must use '{}'s.	104
	'if' construct must use '{}'s.	120
	'if' construct must use '{}'s.	133
	'if' construct must use '{}'s.	136
	'if' construct must use '{}'s.	137
	'if' construct must use '{}'s.	139
	'if' construct must use '{}'s.	154
	'while' construct must use '{}'s.	172
	Inner assignments should be avoided.	172
	Empty statement.	172
	'if' construct must use '{}'s.	206
	'{' should be on a new line.	208
	'{' should be on a new line.	213
	Line is longer than 120 characters.	252
	'if' construct must use '{}'s.	291

org/apache/myfaces/renderkit/html/ext/HtmlRadioRenderer.java

Violation	Message	Line
	Unused import - javax.faces.component.UIInput.	26
	Unused import - org.apache.myfaces.shared_tomahawk.renderkit.html.HTML.	36
	'if' construct must use '{}'s.	66
	'if' construct must use '{}'s.	67
	Line is longer than 120 characters.	111

org/apache/myfaces/renderkit/html/ext/HtmlTableRenderer.java

Violation	Message	Line
	'{' should be on a new line.	63
	'{' should be on a new line.	77
	'{' should be on a new line.	78
	'{' should be on a new line.	90
	'{' should be on a new line.	91
	'{' should be on a new line.	103
	'{' should be on a new line.	104
	'{' should be on a new line.	114
	'{' should be on a new line.	115
	'{' should be on a new line.	124
	'{' should be on a new line.	127
	'{' should be on a new line.	132
	'{' should be on a new line.	133
	'{' should be on a new line.	141
	'{' should be on a new line.	142
	Line is longer than 120 characters.	149
	'{' should be on a new line.	149
	'{' should be on a new line.	150
	Line is longer than 120 characters.	155
	'{' should be on a new line.	158
	'{' should be on a new line.	160
	'{' should be on a new line.	167
	'{' should be on a new line.	168
	'{' should be on a new line.	175
	'{' should be on a new line.	178
	'{' should be on a new line.	183
	'{' should be on a new line.	186
	'{' should be on a new line.	191
	'{' should be on a new line.	194
	'{' should be on a new line.	204
	'{' should be on a new line.	207
	'{' should be on a new line.	210
	'{' should be on a new line.	213
	'{' should be on a new line.	219
	'{' should be on a new line.	246
	'{' should be on a new line.	250
	'{' should be on a new line.	261
	'{' should be on a new line.	262
	'{' should be on a new line.	264
	'{' should be on a new line.	268
	'{' should be on a new line.	276
	'{' should be on a new line.	277
	'{' should be on a new line.	279
	'{' should be on a new line.	283
	'{' should be on a new line.	288
	'{' should be on a new line.	289
	Each variable declaration must be in its own statement.	291
	'{' should be on a new line.	291
	'{' should be on a new line.	293
	'{' should be on a new line.	295
	'{' should be on a new line.	305
	'{' should be on a new line.	306
	'{' should be on a new line.	313
	'{' should be on a new line.	326
	'{' should be on a new line.	329
	Each variable declaration must be in its own statement.	337
	'{' should be on a new line.	337
	'{' should be on a new line.	339
	'{' should be on a new line.	341
	'{' should be on a new line.	349
	'{' should be on a new line.	353
	'{' should be on a new line.	359
	'{' should be on a new line.	364
	'{' should be on a new line.	367
	'{' should be on a new line.	370
	'{' should be on a new line.	376
	'{' should be on a new line.	380
	Each variable declaration must be in its own statement.	387
	'{' should be on a new line.	387
	'{' should be on a new line.	391
	'{' should be on a new line.	392
	'{' should be on a new line.	401
	'{' should be on a new line.	405
	'{' should be on a new line.	413
	'{' should be on a new line.	428
	'{' should be on a new line.	437
	Each variable declaration must be in its own statement.	438
	'{' should be on a new line.	438
	'{' should be on a new line.	466
	'{' should be on a new line.	467
	'{' should be on a new line.	469
	'{' should be on a new line.	470
	'{' should be on a new line.	486
	'{' should be on a new line.	487
	'{' should be on a new line.	490
	'{' should be on a new line.	494
	'{' should be on a new line.	498
	'{' should be on a new line.	501
	'{' should be on a new line.	513
	'{' should be on a new line.	514
	'{' should be on a new line.	516
	'{' should be on a new line.	520
	'{' should be on a new line.	527
	Line is longer than 120 characters.	548
	'{' should be on a new line.	548
	'{' should be on a new line.	551
	'{' should be on a new line.	556
	'{' should be on a new line.	560
	'{' should be on a new line.	563
	'{' should be on a new line.	566
	'{' should be on a new line.	572
	'{' should be on a new line.	573
	'{' should be on a new line.	609
	Each variable declaration must be in its own statement.	620
	'{' should be on a new line.	661
	'{' should be on a new line.	662
	'{' should be on a new line.	674
	'{' should be on a new line.	678
	'{' should be on a new line.	683
	'{' should be on a new line.	686
	'{' should be on a new line.	690
	'{' should be on a new line.	691
	'{' should be on a new line.	695
	'{' should be on a new line.	699
	'{' should be on a new line.	703
	'{' should be on a new line.	705
	'{' should be on a new line.	715
	'{' should be on a new line.	716
	'{' should be on a new line.	721
	'{' should be on a new line.	722
	'{' should be on a new line.	726
	'{' should be on a new line.	734
	'{' should be on a new line.	764
	'{' should be on a new line.	767
	Each variable declaration must be in its own statement.	769
	'{' should be on a new line.	769
	'{' should be on a new line.	771
	'{' should be on a new line.	775
	'{' should be on a new line.	790
	'{' should be on a new line.	791
	'{' should be on a new line.	795
	'{' should be on a new line.	807
	'{' should be on a new line.	813
	'{' should be on a new line.	816
	'{' should be on a new line.	820
	'{' should be on a new line.	825
	'{' should be on a new line.	837
	'{' should be on a new line.	838
	'{' should be on a new line.	839
	'{' should be on a new line.	843
	'{' should be on a new line.	849
	'{' should be on a new line.	852
	'{' should be on a new line.	856
	'{' should be on a new line.	861
	'{' should be on a new line.	868
	Line is longer than 120 characters.	869
	Each variable declaration must be in its own statement.	870
	'{' should be on a new line.	870
	'{' should be on a new line.	894
	'{' should be on a new line.	896
	'{' should be on a new line.	908
	'{' should be on a new line.	910
	Line is longer than 120 characters.	923
	'{' should be on a new line.	923
	'{' should be on a new line.	924
	Line is longer than 120 characters.	933
	'{' should be on a new line.	933
	'{' should be on a new line.	934
	'{' should be on a new line.	942
	'{' should be on a new line.	943
	'{' should be on a new line.	945
	'{' should be on a new line.	949
	'{' should be on a new line.	958
	'{' should be on a new line.	961
	Line is longer than 120 characters.	968
	'{' should be on a new line.	968
	'{' should be on a new line.	971
	'{' should be on a new line.	978
	'{' should be on a new line.	982
	'{' should be on a new line.	983
	'{' should be on a new line.	987
	'{' should be on a new line.	999
	'{' should be on a new line.	1002
	'{' should be on a new line.	1004
	'{' should be on a new line.	1007
	'{' should be on a new line.	1010
	'{' should be on a new line.	1013
	'{' should be on a new line.	1014
	'{' should be on a new line.	1015
	'{' should be on a new line.	1018
	'{' should be on a new line.	1021
	'{' should be on a new line.	1025
	'{' should be on a new line.	1040
	'{' should be on a new line.	1044
	'{' should be on a new line.	1048
	'{' should be on a new line.	1054
	'{' should be on a new line.	1058

org/apache/myfaces/tomahawk/application/jsp/JspTilesTwoViewHandlerImpl.java

Violation	Message	Line
	'{' should be on a new line.	72
	Line is longer than 120 characters.	81
	'{' should be on a new line.	88
	'{' should be on a new line.	90
	'{' should be on a new line.	116
	'{' should be on a new line.	131
	'}' should be alone on a line.	136
	'{' should be on a new line.	136
	'{' should be on a new line.	229
	'{' should be on a new line.	243
	'if' construct must use '{}'s.	255
	Line is longer than 120 characters.	255
	'if' construct must use '{}'s.	260
	'{' should be on a new line.	273
	'{' should be on a new line.	279
	'{' should be on a new line.	281
	'{' should be on a new line.	286
	'{' should be on a new line.	292
	'if' construct must use '{}'s.	293
	'{' should be on a new line.	296
	'{' should be on a new line.	387
	'{' should be on a new line.	388
	'{' should be on a new line.	392
	'{' should be on a new line.	393
	Line is longer than 120 characters.	411
	'{' should be on a new line.	411
	'{' should be on a new line.	412
	Line is longer than 120 characters.	415
	'{' should be on a new line.	416
	'{' should be on a new line.	419
	Line is longer than 120 characters.	433
	'{' should be on a new line.	471
	'{' should be on a new line.	484
	'{' should be on a new line.	486
	Each variable declaration must be in its own statement.	501
	Line is longer than 120 characters.	630
	'{' should be on a new line.	630
	'}' should be alone on a line.	634
	'{' should be on a new line.	634
	'{' should be on a new line.	649
	Line is longer than 120 characters.	666
	'{' should be on a new line.	666

org/apache/myfaces/tomahawk/application/jsp/ViewResponseWrapper.java

Violation	Message	Line
	Using the '.*' form of import should be avoided - java.io.*.	24
	'if' construct must use '{}'s.	116
	'if' construct must use '{}'s.	127
	'{' should be on a new line.	183
	'{' should be on a new line.	192
	'{' should be on a new line.	208
	'{' should be on a new line.	210
	'{' should be on a new line.	214
	'{' should be on a new line.	218
	'{' should be on a new line.	222

org/apache/myfaces/validator/ValidatorBase.java

Violation	Message	Line
	'{' should be on a new line.	46
	'if' construct must use '{}'s.	60
	'{' should be on a new line.	69
	'{' should be on a new line.	80
	'{' should be on a new line.	89
	'{' should be on a new line.	100
	'if' construct must use '{}'s.	101
	'{' should be on a new line.	110
	'{' should be on a new line.	118
	'{' should be on a new line.	126
	'{' should be on a new line.	133
	'{' should be on a new line.	137
	'{' should be on a new line.	148
	'}' should be alone on a line.	154
	'{' should be on a new line.	154
	'if' construct must use '{}'s.	169
	'if' construct must use '{}'s.	183
	'if' construct must use '{}'s.	259
	'if' construct must use '{}'s.	295
	'if' construct must use '{}'s.	296
	Line is longer than 120 characters.	317

org/apache/myfaces/validator/ValidatorBaseTag.java

Violation	Message	Line
	'{' should be on a new line.	35
	'{' should be on a new line.	41
	'{' should be on a new line.	55
	'if' construct must use '{}'s.	61
	Line is longer than 120 characters.	62
	'if' construct must use '{}'s.	66