PMD Results
The following document contains the results of PMD 3.9.
Files
Tobago Core - org/apache/myfaces/tobago/ajax/api/AjaxResponseRenderer.java
| Violation | Line |
|---|---|
| The class 'AjaxResponseRenderer' has a Cyclomatic Complexity of 3 (Highest = 6). | 51 - 221 |
| Private field 'callback' could be made final; it is only initialized in the declaration or constructor. | 59 |
| Private field 'contentType' could be made final; it is only initialized in the declaration or constructor. | 60 |
| Parameter 'facesContext' is not assigned and could be declared final | 66 |
| The method 'renderResponse' has a Cyclomatic Complexity of 6. | 66 - 103 |
| Local variable 'renderFactory' could be declared final | 68 - 69 |
| Local variable 'renderKit' could be declared final | 70 - 71 |
| Local variable 'incommingViewRoot' could be declared final | 73 - 74 |
| Avoid if (x != y) ..; else ..; | 75 - 102 |
| Use equals() to compare object references. | 75 |
| Local variable 'sessionMap' could be declared final | 80 |
| Local variable 'messageHolders' could be declared final | 83 |
| Local variable 'clientIds' could be declared final | 84 |
| Local variable 'clientId' could be declared final | 86 |
| Local variable 'messages' could be declared final | 87 |
| Avoid instantiating new objects inside loops | 89 |
| Parameter 'renderKit' is not assigned and could be declared final | 105 |
| Parameter 'facesContext' is not assigned and could be declared final | 105 |
| Parameter 'clientId' is not assigned and could be declared final | 105 |
| Parameter 'component' is not assigned and could be declared final | 106 |
| Local variable 'writer' could be declared final | 107 |
| Local variable 'contentWriter' could be declared final | 108 |
| Parameter 'renderKit' is not assigned and could be declared final | 139 |
| Parameter 'facesContext' is not assigned and could be declared final | 139 |
| Local variable 'stateWriter' could be declared final | 141 - 142 |
| Local variable 'stateManager' could be declared final | 145 |
| Local variable 'serializedView' could be declared final | 146 |
| Avoid reassigning parameters such as 'charset' | 150 |
| Parameter 'facesContext' is not assigned and could be declared final | 150 |
| Parameter 'contentType' is not assigned and could be declared final | 150 |
| Local variable 'response' could be declared final | 153 |
| Local variable 'sb' could be declared final | 155 |
| Parameter 'renderKit' is not assigned and could be declared final | 165 |
| Parameter 'facesContext' is not assigned and could be declared final | 165 |
| Parameter 'reloadRequired' is not assigned and could be declared final | 165 |
| The method 'writeResponse' has a Cyclomatic Complexity of 6. | 165 - 210 |
| Local variable 'externalContext' could be declared final | 168 |
| Local variable 'page' could be declared final | 171 |
| Avoid if (x != y) ..; else ..; | 173 - 177 |
| Local variable 'writer' could be declared final | 180 |
| Local variable 'ajaxComponents' could be declared final | 192 |
| Local variable 'component' could be declared final | 200 |
| Parameter 'externalContext' is not assigned and could be declared final | 212 |
Tobago Core - org/apache/myfaces/tobago/ajax/api/AjaxUtils.java
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 1 - 159 |
| The class 'AjaxUtils' has a Cyclomatic Complexity of 3 (Highest = 6). | 33 - 159 |
| Parameter 'compClass' is not assigned and could be declared final | 39 |
| Parameter 'facesContext' is not assigned and could be declared final | 39 |
| Parameter 'uiComponent' is not assigned and could be declared final | 39 |
| The method 'checkParamValidity' has a Cyclomatic Complexity of 5. | 39 - 53 |
| Parameter 'component' is not assigned and could be declared final | 58 |
| Parameter 'facesContext' is not assigned and could be declared final | 58 |
| The method 'encodeAjaxComponent' has a Cyclomatic Complexity of 5. | 58 - 69 |
| Local variable 'renderer' could be declared final | 65 |
| No need to check for null before an instanceof | 66 |
| Parameter 'facesContext' is not assigned and could be declared final | 71 |
| The method 'parseAndStoreComponents' has a Cyclomatic Complexity of 6. | 71 - 96 |
| Local variable 'parameterMap' could be declared final | 72 |
| Local variable 'ajaxComponentIds' could be declared final | 73 |
| Local variable 'tokenizer' could be declared final | 78 |
| Local variable 'ajaxComponents' could be declared final | 79 |
| Local variable 'viewRoot' could be declared final | 82 |
| Local variable 'ajaxId' could be declared final | 84 |
| Local variable 'ajaxComponent' could be declared final | 85 |
| Deeply nested if..then statements are hard to read | 87 - 89 |
| Parameter 'facesContext' is not assigned and could be declared final | 98 |
| Parameter 'facesContext' is not assigned and could be declared final | 104 |
| Parameter 'facesContext' is not assigned and could be declared final | 108 |
| Parameter 'clientId' is not assigned and could be declared final | 108 |
| Local variable 'ajaxComponents' could be declared final | 109 |
| Parameter 'facesContext' is not assigned and could be declared final | 115 |
| Parameter 'clientId' is not assigned and could be declared final | 115 |
| Parameter 'component' is not assigned and could be declared final | 119 |
| Parameter 'facesContext' is not assigned and could be declared final | 119 |
| The method 'addAjaxComponent' has a Cyclomatic Complexity of 5. | 119 - 130 |
| Local variable 'ajaxComponents' could be declared final | 121 |
| Avoid if (x != y) ..; else ..; | 127 |
| Avoid if (x != y) ..; else ..; | 128 |
| Parameter 'facesContext' is not assigned and could be declared final | 133 |
| Parameter 'clientId' is not assigned and could be declared final | 133 |
| Parameter 'component' is not assigned and could be declared final | 137 |
| Parameter 'facesContext' is not assigned and could be declared final | 137 |
| The method 'ensureDecoded' has a Cyclomatic Complexity of 5. | 137 - 151 |
| Local variable 'ajaxComponents' could be declared final | 138 |
| Parameter 'value' is not assigned and could be declared final | 153 |
Tobago Core - org/apache/myfaces/tobago/application/ViewHandlerImpl.java
| Violation | Line |
|---|---|
| Private field 'base' could be made final; it is only initialized in the declaration or constructor. | 36 |
| Parameter 'facesContext' is not assigned and could be declared final | 45 |
| Parameter 'facesContext' is not assigned and could be declared final | 49 |
| Parameter 'facesContext' is not assigned and could be declared final | 53 |
| Parameter 'viewId' is not assigned and could be declared final | 53 |
| Parameter 'facesContext' is not assigned and could be declared final | 74 |
| Parameter 'viewId' is not assigned and could be declared final | 74 |
| Parameter 'facesContext' is not assigned and could be declared final | 78 |
| Parameter 'path' is not assigned and could be declared final | 78 |
| Parameter 'facesContext' is not assigned and could be declared final | 82 |
| Parameter 'viewRoot' is not assigned and could be declared final | 82 |
| Parameter 'facesContext' is not assigned and could be declared final | 93 |
| Parameter 'viewId' is not assigned and could be declared final | 93 |
| Local variable 'viewRoot' could be declared final | 100 |
| Consider simply returning the value vs storing it in local variable 'viewRoot' | 101 |
| Parameter 'facesContext' is not assigned and could be declared final | 104 |
Tobago Core - org/apache/myfaces/tobago/bean/ResourceMap.java
| Violation | Line |
|---|---|
| The class 'ResourceMap' has a Cyclomatic Complexity of 4 (Highest = 6). | 32 - 86 |
| Parameter 'filename' is not assigned and could be declared final | 43 |
| The method 'setFilename' has a Cyclomatic Complexity of 6. | 43 - 62 |
| Local variable 'is' could be declared final | 48 |
| Parameter 'key' is not assigned and could be declared final | 66 |
| Parameter 'value' is not assigned and could be declared final | 66 |
| Parameter 'key' is not assigned and could be declared final | 76 |
| Local variable 'value' could be declared final | 77 |
Tobago Core - org/apache/myfaces/tobago/component/AbstractUICommand.java
| Violation | Line |
|---|---|
| The class 'AbstractUICommand' has a Cyclomatic Complexity of 3 (Highest = 5). | 37 - 87 |
| Parameter 'context' is not assigned and could be declared final | 40 |
| The method 'processDecodes' has a Cyclomatic Complexity of 5. | 40 - 63 |
| Local variable 'kids' could be declared final | 58 |
| Local variable 'kid' could be declared final | 60 |
| Parameter 'facesContext' is not assigned and could be declared final | 65 |
| Parameter 'facesEvent' is not assigned and could be declared final | 71 |
| Parameter 'callback' is not assigned and could be declared final | 83 |
| Parameter 'context' is not assigned and could be declared final | 83 |
| Parameter 'clientId' is not assigned and could be declared final | 83 |
Tobago Core - org/apache/myfaces/tobago/component/AbstractUIData.java
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 1 - 542 |
| The class 'AbstractUIData' has a Cyclomatic Complexity of 4 (Highest = 18). | 63 - 542 |
| Parameter 'facesContext' is not assigned and could be declared final | 85 |
| The method 'encodeBegin' has a Cyclomatic Complexity of 6. | 85 - 100 |
| Local variable 'renderer' could be declared final | 86 |
| No need to check for null before an instanceof | 87 |
| Local variable 'state' could be declared final | 91 |
| Parameter 'facesContext' is not assigned and could be declared final | 102 |
| Local variable 'renderer' could be declared final | 103 |
| No need to check for null before an instanceof | 104 |
| Parameter 'state' is not assigned and could be declared final | 111 |
| Parameter 'facesContext' is not assigned and could be declared final | 119 |
| Avoid if (x != y) ..; else ..; | 120 - 135 |
| Local variable 'columns' could be declared final | 142 |
| Local variable 'last' could be declared final | 151 |
| Local variable 'first' could be declared final | 156 |
| Local variable 'rows' could be declared final | 157 |
| Local variable 'rows' could be declared final | 170 |
| Parameter 'column' is not assigned and could be declared final | 177 |
| Local variable 'children' could be declared final | 178 |
| Local variable 'kid' could be declared final | 180 |
| Avoid if (x != y) ..; else ..; | 197 - 202 |
| Local variable 'rows' could be declared final | 206 |
| Local variable 'rowCount' could be declared final | 211 |
| Local variable 'tail' could be declared final | 212 |
| Avoid if (x != y) ..; else ..; | 213 |
| Parameter 'context' is not assigned and could be declared final | 216 |
| Parameter 'facesContext' is not assigned and could be declared final | 221 |
| Local variable 'state' could be declared final | 222 |
| Local variable 'attributes' could be declared final | 228 |
| Parameter 'context' is not assigned and could be declared final | 239 |
| Parameter 'context' is not assigned and could be declared final | 246 |
| Parameter 'savedState' is not assigned and could be declared final | 246 |
| Local variable 'values' could be declared final | 247 |
| Local variable 'columns' could be declared final | 253 |
| The method 'getRenderedColumns' has a Cyclomatic Complexity of 5. | 262 - 270 |
| Local variable 'columns' could be declared final | 263 |
| Parameter 'facesEvent' is not assigned and could be declared final | 280 |
| The method 'queueEvent' has a Cyclomatic Complexity of 9. | 280 - 306 |
| Local variable 'parent' could be declared final | 281 |
| Local variable 'source' could be declared final | 296 |
| Local variable 'sourceParent' could be declared final | 297 |
| Parameter 'facesEvent' is not assigned and could be declared final | 308 |
| The method 'broadcast' has a Cyclomatic Complexity of 6. | 308 - 326 |
| Local variable 'methodBinding' could be declared final | 319 |
| Avoid if (x != y) ..; else ..; | 320 - 324 |
| Parameter 'event' is not assigned and could be declared final | 328 |
| Parameter 'methodBinding' is not assigned and could be declared final | 328 |
| The method 'invokeMethodBinding' has a Cyclomatic Complexity of 5. | 328 - 342 |
| Local variable 'objects' could be declared final | 331 |
| Local variable 'cause' could be declared final | 334 |
| Parameter 'listener' is not assigned and could be declared final | 344 |
| Parameter 'listener' is not assigned and could be declared final | 352 |
| Parameter 'widthList' is not assigned and could be declared final | 360 |
| Parameter 'context' is not assigned and could be declared final | 364 |
| The method 'processDecodes' has a Cyclomatic Complexity of 13. | 364 - 385 |
| Local variable 'reload' could be declared final | 367 |
| Local variable 'immediate' could be declared final | 370 |
| Local variable 'update' could be declared final | 372 |
| Parameter 'facesContext' is not assigned and could be declared final | 387 |
| The method 'encodeAjax' has a Cyclomatic Complexity of 10. | 387 - 416 |
| Local variable 'renderer' could be declared final | 388 |
| No need to check for null before an instanceof | 389 |
| Local variable 'reload' could be declared final | 405 |
| Local variable 'immediate' could be declared final | 407 |
| Local variable 'update' could be declared final | 409 |
| Avoid reassigning parameters such as 'searchId' | 427 |
| Parameter 'callback' is not assigned and could be declared final | 434 |
| Parameter 'context' is not assigned and could be declared final | 434 |
| Parameter 'clientId' is not assigned and could be declared final | 434 |
| The method 'invokeOnComponent' has a Cyclomatic Complexity of 7. | 434 - 471 |
| Local variable 'oldRowIndex' could be declared final | 437 |
| Local variable 'sheetId' could be declared final | 439 |
| Local variable 'idx' could be declared final | 446 |
| Local variable 'rowIndex' could be declared final | 448 |
| Parameter 'pageEvent' is not assigned and could be declared final | 473 |
| The method 'performPaging' has a Cyclomatic Complexity of 18. | 473 - 540 |
Tobago Core - org/apache/myfaces/tobago/component/AbstractUIFileInput.java
| Violation | Line |
|---|---|
| This abstract class does not have any abstract methods | 30 - 54 |
| The class 'AbstractUIFileInput' has a Cyclomatic Complexity of 4 (Highest = 5). | 30 - 54 |
| Parameter 'facesContext' is not assigned and could be declared final | 32 |
| The method 'validate' has a Cyclomatic Complexity of 5. | 32 - 46 |
| Local variable 'file' could be declared final | 35 |
| Parameter 'facesContext' is not assigned and could be declared final | 48 |
| Local variable 'facesMessage' could be declared final | 49 - 50 |
Tobago Core - org/apache/myfaces/tobago/component/AbstractUIForm.java
| Violation | Line |
|---|---|
| The class 'AbstractUIForm' has a Cyclomatic Complexity of 4 (Highest = 5). | 34 - 113 |
| Parameter 'facesContext' is not assigned and could be declared final | 41 |
| Local variable 'kids' could be declared final | 48 |
| Local variable 'kid' could be declared final | 50 |
| Parameter 'b' is not assigned and could be declared final | 55 |
| Parameter 'facesContext' is not assigned and could be declared final | 64 |
| The method 'processValidators' has a Cyclomatic Complexity of 5. | 64 - 81 |
| Avoid if (x != y) ..; else ..; | 69 - 80 |
| Local variable 'kids' could be declared final | 75 |
| Local variable 'kid' could be declared final | 77 |
| Parameter 'facesContext' is not assigned and could be declared final | 83 |
| The method 'processUpdates' has a Cyclomatic Complexity of 5. | 83 - 100 |
| Avoid if (x != y) ..; else ..; | 88 - 99 |
| Local variable 'kids' could be declared final | 94 |
| Local variable 'kid' could be declared final | 96 |
| Parameter 'callback' is not assigned and could be declared final | 102 |
| Parameter 'context' is not assigned and could be declared final | 102 |
| Parameter 'clientId' is not assigned and could be declared final | 102 |
| These nested if statements could be combined | 106 - 108 |
| These nested if statements could be combined | 106 - 108 |
Tobago Core - org/apache/myfaces/tobago/component/AbstractUIGridLayout.java
| Violation | Line |
|---|---|
| The class 'AbstractUIGridLayout' has a Cyclomatic Complexity of 2 (Highest = 5). | 35 - 265 |
| Avoid instantiation through private constructors from outside of the constructor's class. | 39 |
| Parameter 'context' is not assigned and could be declared final | 68 |
| Parameter 'context' is not assigned and could be declared final | 80 |
| Parameter 'component' is not assigned and could be declared final | 87 |
| Parameter 'facesContext' is not assigned and could be declared final | 87 |
| Assigning an Object to null is a code smell. Consider refactoring. | 93 |
| The method 'createRows' has a Cyclomatic Complexity of 5. | 107 - 134 |
| Local variable 'rows' could be declared final | 108 |
| Local variable 'columnCount' could be declared final | 109 |
| Local variable 'children' could be declared final | 110 - 111 |
| Local variable 'spanX' could be declared final | 114 |
| Local variable 'spanY' could be declared final | 115 |
| Local variable 'r' could be declared final | 117 |
| Avoid instantiating new objects inside loops | 119 |
| Local variable 'c' could be declared final | 121 |
| Avoid instantiating new objects inside loops | 128 |
| Parameter 'rows' is not assigned and could be declared final | 136 |
| Parameter 'component' is not assigned and could be declared final | 146 |
| Parameter 'component' is not assigned and could be declared final | 151 |
| Parameter 'ignoreFree' is not assigned and could be declared final | 160 |
| The class 'Row' has a Cyclomatic Complexity of 2 (Highest = 5). | 164 - 240 |
| Parameter 'component' is not assigned and could be declared final | 174 |
| Parameter 'spanX' is not assigned and could be declared final | 174 |
| Local variable 'i' could be declared final | 176 |
| Avoid reassigning parameters such as 'end' | 182 |
| Parameter 'start' is not assigned and could be declared final | 182 |
| Parameter 'rendered' is not assigned and could be declared final | 182 |
| The method 'fill' has a Cyclomatic Complexity of 5. | 182 - 206 |
| Avoid instantiating new objects inside loops | 204 |
| Parameter 'columns' is not assigned and could be declared final | 225 |
| Parameter 'hidden' is not assigned and could be declared final | 237 |
| Private field 'rendered' could be made final; it is only initialized in the declaration or constructor. | 245 |
Tobago Core - org/apache/myfaces/tobago/component/AbstractUIMessages.java
| Violation | Line |
|---|---|
| The class 'AbstractUIMessages' has a Cyclomatic Complexity of 2 (Highest = 7). | 30 - 130 |
| Parameter 'facesContext' is not assigned and could be declared final | 32 |
| Avoid if (x != y) ..; else ..; | 37 - 41 |
| Local variable 'messages' could be declared final | 43 |
| Parameter 'clientIds' is not assigned and could be declared final | 53 |
| Parameter 'facesContext' is not assigned and could be declared final | 53 |
| The method 'collectMessageList' has a Cyclomatic Complexity of 7. | 53 - 73 |
| Local variable 'messages' could be declared final | 54 |
| Local variable 'clientId' could be declared final | 56 |
| Local variable 'i' could be declared final | 57 |
| Local variable 'facesMessage' could be declared final | 59 |
| Avoid instantiating new objects inside loops | 69 |
| Parameter 'clientId' is not assigned and could be declared final | 89 |
| Parameter 'facesMessage' is not assigned and could be declared final | 97 |
| Parameter 'item1' is not assigned and could be declared final | 103 |
| Parameter 'item2' is not assigned and could be declared final | 103 |
| Parameter 'key' is not assigned and could be declared final | 126 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 127 |
Tobago Core - org/apache/myfaces/tobago/component/AbstractUIPage.java
| Violation | Line |
|---|---|
| The class 'AbstractUIPage' has a Cyclomatic Complexity of 2 (Highest = 11). | 47 - 286 |
| Document empty method | 68 - 69 |
| Parameter 'context' is not assigned and could be declared final | 68 |
| Parameter 'facesContext' is not assigned and could be declared final | 71 |
| Parameter 'facesContext' is not assigned and could be declared final | 80 |
| Local variable 'kids' could be declared final | 89 |
| Local variable 'kid' could be declared final | 90 |
| Parameter 'facesContext' is not assigned and could be declared final | 95 |
| The method 'markSubmittedForm' has a Cyclomatic Complexity of 11. | 95 - 150 |
| Avoid empty catch blocks | 125 - 127 |
| Avoid empty catch blocks | 125 - 127 |
| Must handle exceptions | 125 - 127 |
| Avoid if (x != y) ..; else ..; | 136 - 149 |
| Local variable 'form' could be declared final | 137 |
| Parameter 'facesContext' is not assigned and could be declared final | 152 |
| The method 'checkTobagoRequest' has a Cyclomatic Complexity of 7. | 152 - 176 |
| Local variable 'contentType' could be declared final | 154 - 155 |
| Local variable 'request' could be declared final | 157 |
| Local variable 'wrappedRequest' could be declared final | 162 - 163 |
| Parameter 'context' is not assigned and could be declared final | 186 |
| Parameter 'facesContext' is not assigned and could be declared final | 191 |
| Local variable 'state' could be declared final | 192 |
| Parameter 'facesContext' is not assigned and could be declared final | 197 |
| Parameter 'pageState' is not assigned and could be declared final | 197 |
| Local variable 'tokenizer' could be declared final | 206 |
| Local variable 'width' could be declared final | 207 |
| Local variable 'height' could be declared final | 208 |
| Parameter 'facesContext' is not assigned and could be declared final | 221 |
| Parameter 'actionId' is not assigned and could be declared final | 239 |
| Parameter 'actionPosition' is not assigned and could be declared final | 247 |
| Parameter 'defaultActionId' is not assigned and could be declared final | 255 |
| Local variable 'requestWidth' could be declared final | 260 - 262 |
| Avoid if (x != y) ..; else ..; | 263 - 267 |
| Local variable 'requestHeight' could be declared final | 272 - 274 |
| Avoid if (x != y) ..; else ..; | 275 - 279 |
| Parameter 'callback' is not assigned and could be declared final | 282 |
| Parameter 'context' is not assigned and could be declared final | 282 |
| Parameter 'clientId' is not assigned and could be declared final | 282 |
Tobago Core - org/apache/myfaces/tobago/component/AbstractUIPopup.java
| Violation | Line |
|---|---|
| The class 'AbstractUIPopup' has a Cyclomatic Complexity of 2 (Highest = 5). | 35 - 156 |
| Parameter 'activated' is not assigned and could be declared final | 39 |
| Parameter 'facesContext' is not assigned and could be declared final | 43 |
| Local variable 'it' could be declared final | 45 |
| Local variable 'childOrFacet' could be declared final | 46 |
| Local variable 'action' could be declared final | 68 |
| The method 'isRedisplay' has a Cyclomatic Complexity of 5. | 72 - 84 |
| Local variable 'page' could be declared final | 74 |
| Local variable 'action' could be declared final | 75 |
| Local variable 'command' could be declared final | 77 |
| No need to check for null before an instanceof | 78 |
| Parameter 'context' is not assigned and could be declared final | 91 |
| Local variable 'it' could be declared final | 93 |
| Local variable 'childOrFacet' could be declared final | 94 |
| Parameter 'context' is not assigned and could be declared final | 104 |
| Local variable 'it' could be declared final | 106 |
| Local variable 'childOrFacet' could be declared final | 107 |
| Parameter 'context' is not assigned and could be declared final | 113 |
| Parameter 'context' is not assigned and could be declared final | 120 |
| Parameter 'savedState' is not assigned and could be declared final | 120 |
| Local variable 'values' could be declared final | 121 |
| Parameter 'context' is not assigned and could be declared final | 126 |
| Parameter 'facesContext' is not assigned and could be declared final | 131 |
| Parameter 'callback' is not assigned and could be declared final | 136 |
| Parameter 'context' is not assigned and could be declared final | 136 |
| Parameter 'clientId' is not assigned and could be declared final | 136 |
Tobago Core - org/apache/myfaces/tobago/component/AbstractUISelectBoolean.java
| Violation | Line |
|---|---|
| Parameter 'context' is not assigned and could be declared final | 43 |
| Parameter 'convertedValue' is not assigned and could be declared final | 43 |
| Local variable 'facesMessage' could be declared final | 45 - 46 |
Tobago Core - org/apache/myfaces/tobago/component/AbstractUISelectOne.java
| Violation | Line |
|---|---|
| The class 'AbstractUISelectOne' has a Cyclomatic Complexity of 5 (Highest = 4). | 30 - 46 |
| Parameter 'facesContext' is not assigned and could be declared final | 34 |
| Local variable 'submittedValue' could be declared final | 36 |
| Local variable 'facesMessage' could be declared final | 38 - 39 |
Tobago Core - org/apache/myfaces/tobago/component/AbstractUITabGroup.java
| Violation | Line |
|---|---|
| The class 'AbstractUITabGroup' has a Cyclomatic Complexity of 2 (Highest = 13). | 47 - 305 |
| Overriding method merely calls super | 63 - 65 |
| Parameter 'facesContext' is not assigned and could be declared final | 63 |
| Overriding method merely calls super | 63 - 65 |
| Parameter 'event' is not assigned and could be declared final | 68 |
| Parameter 'context' is not assigned and could be declared final | 80 |
| Document empty method | 81 - 82 |
| Parameter 'facesContext' is not assigned and could be declared final | 85 |
| Local variable 'tabs' could be declared final | 99 |
| Local variable 'kid' could be declared final | 101 |
| Parameter 'context' is not assigned and could be declared final | 119 |
| The method 'processDecodes' has a Cyclomatic Complexity of 6. | 119 - 142 |
| Avoid if (x != y) ..; else ..; | 120 - 141 |
| Local variable 'renderedTab' could be declared final | 128 |
| Parameter 'context' is not assigned and could be declared final | 145 |
| The method 'processValidators' has a Cyclomatic Complexity of 5. | 145 - 161 |
| Avoid if (x != y) ..; else ..; | 146 - 160 |
| Local variable 'renderedTab' could be declared final | 153 |
| Parameter 'context' is not assigned and could be declared final | 164 |
| The method 'processUpdates' has a Cyclomatic Complexity of 5. | 164 - 181 |
| Avoid if (x != y) ..; else ..; | 165 - 180 |
| Local variable 'renderedTab' could be declared final | 172 |
| Parameter 'facesEvent' is not assigned and could be declared final | 183 |
| The method 'broadcast' has a Cyclomatic Complexity of 13. | 183 - 225 |
| Local variable 'index' could be declared final | 186 |
| Local variable 'tabChangeListenerBinding' could be declared final | 192 |
| Local variable 'cause' could be declared final | 197 |
| No need to check for null before an instanceof | 198 |
| Local variable 'actionListenerBinding' could be declared final | 205 |
| Local variable 'cause' could be declared final | 210 |
| No need to check for null before an instanceof | 211 |
| Local variable 'defaultActionListener' could be declared final | 219 - 220 |
| Parameter 'listener' is not assigned and could be declared final | 229 |
| Local variable 'switchType' could be declared final | 237 |
| Parameter 'listener' is not assigned and could be declared final | 241 |
| Parameter 'facesContext' is not assigned and could be declared final | 249 |
| Parameter 'index' is not assigned and could be declared final | 264 |
| Parameter 'listener' is not assigned and could be declared final | 288 |
| Parameter 'listener' is not assigned and could be declared final | 302 |
Tobago Core - org/apache/myfaces/tobago/component/AbstractUITimeInput.java
| Violation | Line |
|---|---|
| Local variable 'converter' could be declared final | 34 |
| Local variable 'application' could be declared final | 37 - 38 |
| Local variable 'dateTimeConverter' could be declared final | 39 - 40 |
Tobago Core - org/apache/myfaces/tobago/component/AbstractUIToolBar.java
| Violation | Line |
|---|---|
| This abstract class does not have any abstract methods | 25 - 38 |
Tobago Core - org/apache/myfaces/tobago/component/AbstractUITree.java
| Violation | Line |
|---|---|
| The class 'AbstractUITree' has a Cyclomatic Complexity of 2 (Highest = 5). | 36 - 284 |
| Parameter 'context' is not assigned and could be declared final | 72 |
| Local variable 'builder' could be declared final | 82 |
| Parameter 'facesContext' is not assigned and could be declared final | 103 |
| Local variable 'i' could be declared final | 116 |
| Local variable 'uiComponent' could be declared final | 117 |
| Parameter 'context' is not assigned and could be declared final | 123 |
| The method 'validate' has a Cyclomatic Complexity of 5. | 123 - 166 |
| Local variable 'message' could be declared final | 158 |
| Parameter 'facesContext' is not assigned and could be declared final | 168 |
| Private field 'command' could be made final; it is only initialized in the declaration or constructor. | 270 |
Tobago Core - org/apache/myfaces/tobago/component/AbstractUITreeData.java
| Violation | Line |
|---|---|
| The class 'AbstractUITreeData' has a Cyclomatic Complexity of 2 (Highest = 6). | 38 - 348 |
| Private field 'pathStates' could be made final; it is only initialized in the declaration or constructor. | 67 |
| Parameter 'facesContext' is not assigned and could be declared final | 70 |
| Local variable 'node' could be declared final | 75 |
| Document empty method | 92 - 94 |
| Parameter 'facesContext' is not assigned and could be declared final | 92 |
| Parameter 'pathIndex' is not assigned and could be declared final | 100 |
| The method 'setPathIndex' has a Cyclomatic Complexity of 6. | 100 - 139 |
| Local variable 'facesContext' could be declared final | 106 |
| Local variable 'template' could be declared final | 108 |
| Avoid if (x != y) ..; else ..; | 118 - 129 |
| Assigning an Object to null is a code smell. Consider refactoring. | 126 |
| Assigning an Object to null is a code smell. Consider refactoring. | 127 |
| Assigning an Object to null is a code smell. Consider refactoring. | 128 |
| Local variable 'state' could be declared final | 131 |
| Parameter 'model' is not assigned and could be declared final | 141 |
| Parameter 'model' is not assigned and could be declared final | 145 |
| Local variable 'builder' could be declared final | 148 |
| Parameter 'model' is not assigned and could be declared final | 156 |
| Document empty method | 161 - 162 |
| Parameter 'context' is not assigned and could be declared final | 161 |
| Parameter 'facesContext' is not assigned and could be declared final | 165 |
| Parameter 'facesContext' is not assigned and could be declared final | 190 |
| Parameter 'context' is not assigned and could be declared final | 205 |
| Local variable 'clientId' could be declared final | 206 |
| Avoid reassigning parameters such as 'searchId' | 213 |
| Parameter 'event' is not assigned and could be declared final | 223 |
| Parameter 'event' is not assigned and could be declared final | 228 |
| Local variable 'originalEvent' could be declared final | 230 |
| Local variable 'eventPathIndex' could be declared final | 231 |
| Local variable 'currentPathIndex' could be declared final | 232 |
| Parameter 'context' is not assigned and could be declared final | 245 |
| Parameter 'context' is not assigned and could be declared final | 253 |
| Parameter 'state' is not assigned and could be declared final | 253 |
| Local variable 'values' could be declared final | 254 |
| Parameter 'var' is not assigned and could be declared final | 263 |
| Parameter 'currentNode' is not assigned and could be declared final | 271 |
| Parameter 'currentNodeId' is not assigned and could be declared final | 279 |
| Parameter 'currentParentNodeId' is not assigned and could be declared final | 287 |
| Private field 'wrappedFacesEvent' could be made final; it is only initialized in the declaration or constructor. | 295 |
| Private field 'pathIndex' could be made final; it is only initialized in the declaration or constructor. | 296 |
| Parameter 'phaseId' is not assigned and could be declared final | 310 |
| Parameter 'faceslistener' is not assigned and could be declared final | 326 |
| Parameter 'faceslistener' is not assigned and could be declared final | 331 |
Tobago Core - org/apache/myfaces/tobago/component/AbstractUITreeNode.java
| Violation | Line |
|---|---|
| Parameter 'model' is not assigned and could be declared final | 37 |
| Parameter 'model' is not assigned and could be declared final | 41 |
| Local variable 'builder' could be declared final | 44 |
| Parameter 'model' is not assigned and could be declared final | 52 |
| Parameter 'facesContext' is not assigned and could be declared final | 70 |
| Local variable 'clientId' could be declared final | 72 |
| Local variable 'tree' could be declared final | 73 |
| Local variable 'treeId' could be declared final | 74 |
| Avoid reassigning parameters such as 'component' | 82 |
Tobago Core - org/apache/myfaces/tobago/component/CreateComponentUtils.java
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 1 - 138 |
| Parameter 'componentType' is not assigned and could be declared final | 40 |
| Parameter 'rendererType' is not assigned and could be declared final | 40 |
| Parameter 'componentType' is not assigned and could be declared final | 44 |
| Parameter 'clientId' is not assigned and could be declared final | 44 |
| Parameter 'rendererType' is not assigned and could be declared final | 44 |
| Parameter 'componentType' is not assigned and could be declared final | 50 |
| Parameter 'facesContext' is not assigned and could be declared final | 50 |
| Parameter 'rendererType' is not assigned and could be declared final | 50 |
| Parameter 'componentType' is not assigned and could be declared final | 55 |
| Parameter 'facesContext' is not assigned and could be declared final | 55 |
| Parameter 'clientId' is not assigned and could be declared final | 55 |
| Parameter 'rendererType' is not assigned and could be declared final | 55 |
| Local variable 'component' could be declared final | 56 |
| Parameter 'value' is not assigned and could be declared final | 63 |
| Parameter 'label' is not assigned and could be declared final | 63 |
| Parameter 'align' is not assigned and could be declared final | 63 |
| Parameter 'sortable' is not assigned and could be declared final | 63 |
| Parameter 'value' is not assigned and could be declared final | 67 |
| Parameter 'label' is not assigned and could be declared final | 67 |
| Parameter 'align' is not assigned and could be declared final | 67 |
| Parameter 'sortable' is not assigned and could be declared final | 67 |
| Parameter 'clientId' is not assigned and could be declared final | 67 |
| Local variable 'text' could be declared final | 68 |
| Parameter 'child' is not assigned and could be declared final | 76 |
| Parameter 'label' is not assigned and could be declared final | 76 |
| Parameter 'align' is not assigned and could be declared final | 76 |
| Parameter 'sortable' is not assigned and could be declared final | 76 |
| Parameter 'child' is not assigned and could be declared final | 79 |
| Parameter 'label' is not assigned and could be declared final | 79 |
| Parameter 'align' is not assigned and could be declared final | 79 |
| Parameter 'sortable' is not assigned and could be declared final | 79 |
| Parameter 'clientId' is not assigned and could be declared final | 79 |
| Local variable 'column' could be declared final | 80 |
| Parameter 'label' is not assigned and could be declared final | 87 |
| Parameter 'align' is not assigned and could be declared final | 87 |
| Parameter 'sortable' is not assigned and could be declared final | 87 |
| Parameter 'label' is not assigned and could be declared final | 91 |
| Parameter 'align' is not assigned and could be declared final | 91 |
| Parameter 'sortable' is not assigned and could be declared final | 91 |
| Parameter 'clientId' is not assigned and could be declared final | 91 |
| Local variable 'column' could be declared final | 92 |
| Parameter 'facesContext' is not assigned and could be declared final | 100 |
| Parameter 'command' is not assigned and could be declared final | 101 |
| Parameter 'facesContext' is not assigned and could be declared final | 105 |
| Parameter 'command' is not assigned and could be declared final | 106 |
| Parameter 'clientId' is not assigned and could be declared final | 106 |
| Parameter 'command' is not assigned and could be declared final | 120 |
| Parameter 'facesContext' is not assigned and could be declared final | 120 |
| Parameter 'command' is not assigned and could be declared final | 124 |
| Parameter 'facesContext' is not assigned and could be declared final | 124 |
| Parameter 'clientId' is not assigned and could be declared final | 124 |
| Local variable 'checkbox' could be declared final | 125 - 126 |
| Local variable 'valueBinding' could be declared final | 129 |
| Avoid if (x != y) ..; else ..; | 130 - 135 |
Tobago Core - org/apache/myfaces/tobago/component/Sorter.java
| Violation | Line |
|---|---|
| The class 'Sorter' has a Cyclomatic Complexity of 7 (Highest = 27). | 52 - 217 |
| Parameter 'sortEvent' is not assigned and could be declared final | 58 |
| The method 'perform' has a Cyclomatic Complexity of 27. | 58 - 176 |
| Local variable 'column' could be declared final | 62 |
| Local variable 'data' could be declared final | 63 |
| Local variable 'facesContext' could be declared final | 69 |
| Local variable 'sheetState' could be declared final | 70 |
| Local variable 'child' could be declared final | 79 |
| Avoid if (x != y) ..; else ..; | 80 - 112 |
| Local variable 'var' could be declared final | 81 |
| Local variable 'descending' could be declared final | 102 |
| Avoid if (x != y) ..; else ..; | 174 |
| Parameter 'expressionString' is not assigned and could be declared final | 178 |
| Parameter 'uiColumn' is not assigned and could be declared final | 182 |
| Parameter 'children' is not assigned and could be declared final | 187 |
| The method 'getFirstSortableChild' has a Cyclomatic Complexity of 10. | 187 - 208 |
| Local variable 'iter' could be declared final | 190 |
| Parameter 'comparator' is not assigned and could be declared final | 214 |
Tobago Core - org/apache/myfaces/tobago/component/UIDatePicker.java
| Violation | Line |
|---|---|
| Parameter 'context' is not assigned and could be declared final | 40 |
| Parameter 'context' is not assigned and could be declared final | 47 |
| Parameter 'savedState' is not assigned and could be declared final | 47 |
| Local variable 'values' could be declared final | 48 |
| Parameter 'parent' is not assigned and could be declared final | 53 |
| Local variable 'child' could be declared final | 55 |
| Parameter 'forComponent' is not assigned and could be declared final | 79 |
| Parameter 'facesEvent' is not assigned and could be declared final | 83 |
| Local variable 'facesContext' could be declared final | 84 |
| Local variable 'popup' could be declared final | 85 |
| Local variable 'clientId' could be declared final | 86 |
| Local variable 'box' could be declared final | 87 |
| Local variable 'calendar' could be declared final | 88 |
| Local variable 'time' could be declared final | 90 |
| Parameter 'component' is not assigned and could be declared final | 97 |
| Parameter 'context' is not assigned and could be declared final | 97 |
| Local variable 'renderer' could be declared final | 98 |
Tobago Core - org/apache/myfaces/tobago/component/UIDefaultLayout.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'LOG'. | 32 |
| Avoid unused private fields such as 'LOG'. | 32 |
| Use block level rather than method level synchronization | 40 - 48 |
| Parameter 'component' is not assigned and could be declared final | 50 |
| Parameter 'facesContext' is not assigned and could be declared final | 50 |
Tobago Core - org/apache/myfaces/tobago/component/UIInputBase.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'LOG'. | 31 |
| Avoid unused private fields such as 'LOG'. | 31 |
| Parameter 'facesContext' is not assigned and could be declared final | 34 |
| Parameter 'facesContext' is not assigned and could be declared final | 40 |
Tobago Core - org/apache/myfaces/tobago/component/UILayout.java
| Violation | Line |
|---|---|
| This abstract class does not have any abstract methods | 33 - 81 |
| Avoid unused private fields such as 'LOG'. | 35 |
| Avoid unused private fields such as 'LOG'. | 35 |
| Document empty method | 37 - 40 |
| Parameter 'component' is not assigned and could be declared final | 37 |
| Parameter 'facesContext' is not assigned and could be declared final | 37 |
| Parameter 'component' is not assigned and could be declared final | 43 |
| Parameter 'facesContext' is not assigned and could be declared final | 43 |
| Parameter 'component' is not assigned and could be declared final | 48 |
| Parameter 'facesContext' is not assigned and could be declared final | 48 |
| Local variable 'layoutWidth' could be declared final | 49 |
| Local variable 'space' could be declared final | 51 |
| Local variable 'innerSpace' could be declared final | 52 |
| Parameter 'component' is not assigned and could be declared final | 57 |
| Parameter 'facesContext' is not assigned and could be declared final | 57 |
| Local variable 'layoutHeight' could be declared final | 58 |
| Local variable 'space' could be declared final | 60 |
| Local variable 'innerSpace' could be declared final | 61 |
| Parameter 'component' is not assigned and could be declared final | 66 |
| Parameter 'facesContext' is not assigned and could be declared final | 66 |
| Parameter 'component' is not assigned and could be declared final | 70 |
Tobago Core - org/apache/myfaces/tobago/component/UIPanelBase.java
| Violation | Line |
|---|---|
| The class 'UIPanelBase' has a Cyclomatic Complexity of 6 (Highest = 13). | 42 - 93 |
| Parameter 'facesContext' is not assigned and could be declared final | 45 |
| Parameter 'context' is not assigned and could be declared final | 51 |
| The method 'processDecodes' has a Cyclomatic Complexity of 13. | 51 - 73 |
| Local variable 'reload' could be declared final | 55 |
| Local variable 'immediate' could be declared final | 58 |
| Deeply nested if..then statements are hard to read | 59 - 69 |
| Local variable 'update' could be declared final | 60 |
| Parameter 'facesContext' is not assigned and could be declared final | 75 |
| The method 'encodeAjax' has a Cyclomatic Complexity of 7. | 75 - 87 |
| Local variable 'reload' could be declared final | 76 |
| Local variable 'immediate' could be declared final | 78 |
| Local variable 'update' could be declared final |