PMD Results

The following document contains the results of PMD 5.2.3.

Files

Tobago Core - org/apache/myfaces/tobago/component/Attributes.java

Violation Line
Parameter 'explicit' is not assigned and could be declared final 262
Avoid if (x != y) ..; else ..; 267271
Parameter 'name' is not assigned and could be declared final 274

Tobago Core - org/apache/myfaces/tobago/component/Facets.java

Violation Line
Document empty constructor 5051
Parameter 'event' is not assigned and could be declared final 54
Document empty constructor 5455

Tobago Core - org/apache/myfaces/tobago/component/LabelLayout.java

Violation Line
Parameter 'facesContext' is not assigned and could be declared final 88

Tobago Core - org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.java

Violation Line
This class has too many methods, consider refactoring it. 37241
Document empty constructor 4748
Consider using varargs for methods or constructors which take an array the last parameter. 96

Tobago Core - org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.java

Violation Line
Avoid using redundant field initializer for 'isTransient' 38
Unnecessary use of fully qualified name 'javax.faces.el.MethodNotFoundException' due to existing import 'javax.faces.el.MethodNotFoundException' 63
Consider using varargs for methods or constructors which take an array the last parameter. 70
Unnecessary use of fully qualified name 'javax.faces.el.MethodNotFoundException' due to existing import 'javax.faces.el.MethodNotFoundException' 76

Tobago Core - org/apache/myfaces/tobago/component/Sorter.java

Violation Line
Possible God class (WMC=51, ATFD=25, TCC=0.2) 20259
The class 'Sorter' has a Standard Cyclomatic Complexity of 6 (Highest = 28). 49258
The class 'Sorter' has a Modified Cyclomatic Complexity of 6 (Highest = 28). 49258
The class 'Sorter' has a Cyclomatic Complexity of 8 (Highest = 30). 49258
The method 'perform' has a Cyclomatic Complexity of 30. 64201
Avoid really long methods. 64201
The method perform() has an NPath complexity of 139872 64201
The method 'perform' has a Standard Cyclomatic Complexity of 28. 64201
The method 'perform' has a Modified Cyclomatic Complexity of 28. 64201
Avoid if (x != y) ..; else ..; 96137
Avoid if (x != y) ..; else ..; 99132
Avoid if (x != y) ..; else ..; 199
The method 'getFirstSortableChild' has a Cyclomatic Complexity of 13. 224249

Tobago Core - org/apache/myfaces/tobago/context/Markup.java

Violation Line
This class has too many methods, consider refactoring it. 57369
The class 'Markup' has a Standard Cyclomatic Complexity of 5 (Highest = 10). 57369
The class 'Markup' has a Cyclomatic Complexity of 5 (Highest = 11). 57369
The class 'Markup' has a Modified Cyclomatic Complexity of 5 (Highest = 10). 57369
Consider using varargs for methods or constructors which take an array the last parameter. 115
Consider using varargs for methods or constructors which take an array the last parameter. 125
Avoid if (x != y) ..; else ..; 185
Avoid if (x != y) ..; else ..; 197
Avoid if (x != y) ..; else ..; 198
Use equals() to compare object references. 221
Avoid if (x != y) ..; else ..; 224235
Avoid if (x != y) ..; else ..; 265274
The method 'contains' has a Modified Cyclomatic Complexity of 10. 326356
The method 'contains' has a Standard Cyclomatic Complexity of 10. 326356
The method 'contains' has a Cyclomatic Complexity of 11. 326356
Use equals() to compare object references. 327
Avoid if (x != y) ..; else ..; 333355
Avoid if (x != y) ..; else ..; 334343
Avoid if (x != y) ..; else ..; 345354

Tobago Core - org/apache/myfaces/tobago/context/MarkupConfig.java

Violation Line
Private field 'markups' could be made final; it is only initialized in the declaration or constructor. 30

Tobago Core - org/apache/myfaces/tobago/context/ThemeImpl.java

Violation Line
Possible God class (WMC=58, ATFD=16, TCC=0.0873015873015873) 20303
The class 'ThemeImpl' has a Modified Cyclomatic Complexity of 2 (Highest = 12). 33303
The class 'ThemeImpl' has a Cyclomatic Complexity of 2 (Highest = 12). 33303
The class 'ThemeImpl' has a Standard Cyclomatic Complexity of 2 (Highest = 12). 33303
Private field 'productionResources' could be made final; it is only initialized in the declaration or constructor. 45
Private field 'resources' could be made final; it is only initialized in the declaration or constructor. 46
Avoid using redundant field initializer for 'unmodifiable' 54
Deeply nested if..then statements are hard to read 143148
The method 'toString' has a Modified Cyclomatic Complexity of 12. 262302
The method 'toString' has a Standard Cyclomatic Complexity of 12. 262302
The method 'toString' has a Cyclomatic Complexity of 12. 262302
StringBuffer constructor is initialized with size 16, but has at least 112 characters appended. 263
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 264
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 265
Avoid if (x != y) ..; else ..; 267273
Avoid appending characters as strings in StringBuffer.append. 268
Avoid appending characters as strings in StringBuffer.append. 270
Avoid if (x != y) ..; else ..; 275
Local variable 's' could be declared final 275
Avoid appending characters as strings in StringBuffer.append. 276
Avoid if (x != y) ..; else ..; 280
Local variable 's' could be declared final 280
Avoid appending characters as strings in StringBuffer.append. 281
Local variable 's' could be declared final 285
Avoid if (x != y) ..; else ..; 285
Avoid appending characters as strings in StringBuffer.append. 286
Local variable 's' could be declared final 290
Avoid if (x != y) ..; else ..; 290
Avoid appending characters as strings in StringBuffer.append. 291
Avoid appending characters as strings in StringBuffer.append. 295
Avoid appending characters as strings in StringBuffer.append. 298

Tobago Core - org/apache/myfaces/tobago/context/ThemeResource.java

Violation Line
Avoid if (x != y) ..; else ..; 50
Avoid if (x != y) ..; else ..; 56

Tobago Core - org/apache/myfaces/tobago/context/ThemeResources.java

Violation Line
Parameter 'production' is not assigned and could be declared final 39
Parameter 'exclude' is not assigned and could be declared final 67
Parameter 'exclude' is not assigned and could be declared final 71

Tobago Core - org/apache/myfaces/tobago/context/TobagoBundle.java

Violation Line
Private field 'bundleName' could be made final; it is only initialized in the declaration or constructor. 49
Private field 'bundle' could be made final; it is only initialized in the declaration or constructor. 50
Private field 'props' could be made final; it is only initialized in the declaration or constructor. 78
Parameter 'stream' is not assigned and could be declared final 80
Parameter 'key' is not assigned and could be declared final 85
Local variable 'handleKeys' could be declared final 90
The class 'XMLResourceBundleControl' has a Cyclomatic Complexity of 6 (Highest = 10). 94136
Parameter 'baseName' is not assigned and could be declared final 96
The method 'newBundle' has a Cyclomatic Complexity of 10. 100135
Parameter 'baseName' is not assigned and could be declared final 101
Parameter 'locale' is not assigned and could be declared final 101
Parameter 'reload' is not assigned and could be declared final 101
Parameter 'loader' is not assigned and could be declared final 101
Parameter 'format' is not assigned and could be declared final 101
Avoid declaring a variable if it is unreferenced before a possible exit point. 108
Local variable 'bundleName' could be declared final 113
Local variable 'resourceName' could be declared final 114
Local variable 'url' could be declared final 115
Local variable 'connection' could be declared final 119
Local variable 'stream' could be declared final 126
Local variable 'bis' could be declared final 130
Avoid instantiation through private constructors from outside of the constructors class. 131

Tobago Core - org/apache/myfaces/tobago/context/TobagoContext.java

Violation Line
Local variable 'request' could be declared final 67
Parameter 'theme' is not assigned and could be declared final 83
Parameter 'userAgent' is not assigned and could be declared final 103
Parameter 'facesContext' is not assigned and could be declared final 107

Tobago Core - org/apache/myfaces/tobago/context/TobagoMessageBundle.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3144

Tobago Core - org/apache/myfaces/tobago/context/TobagoResourceBundle.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2941

Tobago Core - org/apache/myfaces/tobago/context/TransientStateHolder.java

Violation Line
Document empty constructor 3334

Tobago Core - org/apache/myfaces/tobago/context/UserAgent.java

Violation Line
The class 'UserAgent' has a Modified Cyclomatic Complexity of 3 (Highest = 19). 33390
The class 'UserAgent' has a Standard Cyclomatic Complexity of 3 (Highest = 19). 33390
The class 'UserAgent' has a Cyclomatic Complexity of 3 (Highest = 20). 33390
The String literal "msie" appears 12 times in this file; the first occurrence is on line 43 43
The String literal "opera" appears 4 times in this file; the first occurrence is on line 107 107
The String literal "mozilla" appears 4 times in this file; the first occurrence is on line 131 131
The String literal "gecko" appears 5 times in this file; the first occurrence is on line 154 154
The method 'getInstance' has a Modified Cyclomatic Complexity of 19. 279334
The method 'getInstance' has a Standard Cyclomatic Complexity of 19. 279334
The method 'getInstance' has a Cyclomatic Complexity of 20. 279334
Avoid if (x != y) ..; else ..; 350352
Consider using varargs for methods or constructors which take an array the last parameter. 364
Consider using varargs for methods or constructors which take an array the last parameter. 382

Tobago Core - org/apache/myfaces/tobago/convert/DurationConverter.java

Violation Line
Unnecessary wrapper object creation 65
Avoid declaring a variable if it is unreferenced before a possible exit point. 89
The default label should be the last label in a switch statement 129145

Tobago Core - org/apache/myfaces/tobago/el/ConstantMethodExpression.java

Violation Line
Document empty constructor 3536
Parameter 'outcome' is not assigned and could be declared final 38
Parameter 'context' is not assigned and could be declared final 43
Consider using varargs for methods or constructors which take an array the last parameter. 49
Parameter 'params' is not assigned and could be declared final 49
Parameter 'context' is not assigned and could be declared final 49
Parameter 'o' is not assigned and could be declared final 55
Local variable 'that' could be declared final 63
Avoid if (x != y) ..; else ..; 65
Parameter 'context' is not assigned and could be declared final 85
Parameter 'context' is not assigned and could be declared final 90
Parameter 'state' is not assigned and could be declared final 90

Tobago Core - org/apache/myfaces/tobago/el/UserWrapper.java

Violation Line
Private field 'roles' could be made final; it is only initialized in the declaration or constructor. 35

Tobago Core - org/apache/myfaces/tobago/event/CollapsibleActionListener.java

Violation Line
Parameter 'context' is not assigned and could be declared final 69
Parameter 'state' is not assigned and could be declared final 74
Parameter 'context' is not assigned and could be declared final 74
Parameter 'transientFlag' is not assigned and could be declared final 84

Tobago Core - org/apache/myfaces/tobago/event/FacesEventWrapper.java

Violation Line
Private field 'wrappedFacesEvent' could be made final; it is only initialized in the declaration or constructor. 31

Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionStateChangeListener.java

Violation Line
Avoid using redundant field initializer for 'isTransient' 33
Document empty constructor 3536

Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTabChangeListener.java

Violation Line
Avoid using redundant field initializer for 'isTransient' 33
Document empty constructor 3536

Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.java

Violation Line
Avoid using redundant field initializer for 'isTransient' 34
Document empty constructor 3637
Avoid unused private methods such as 'elContext()'. 48

Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.java

Violation Line
Avoid using redundant field initializer for 'isTransient' 33
Document empty constructor 3536
Avoid unused private methods such as 'elContext()'. 47

Tobago Core - org/apache/myfaces/tobago/event/PageActionEvent.java

Violation Line
Private field 'action' could be made final; it is only initialized in the declaration or constructor. 31

Tobago Core - org/apache/myfaces/tobago/event/ResetInputActionListener.java

Violation Line
Document empty constructor 3435
Consider using varargs for methods or constructors which take an array the last parameter. 37

Tobago Core - org/apache/myfaces/tobago/event/SortActionEvent.java

Violation Line
Private field 'column' could be made final; it is only initialized in the declaration or constructor. 31

Tobago Core - org/apache/myfaces/tobago/event/TreeExpansionEvent.java

Violation Line
Private field 'oldExpanded' could be made final; it is only initialized in the declaration or constructor. 30
Private field 'newExpanded' could be made final; it is only initialized in the declaration or constructor. 31

Tobago Core - org/apache/myfaces/tobago/event/TreeSelectedEvent.java

Violation Line
Private field 'oldSelected' could be made final; it is only initialized in the declaration or constructor. 30
Private field 'newSelected' could be made final; it is only initialized in the declaration or constructor. 31

Tobago Core - org/apache/myfaces/tobago/event/ValueExpressionResetInputActionListener.java

Violation Line
Document empty constructor 4445

Tobago Core - org/apache/myfaces/tobago/event/ValueExpressionSheetStateChangeListener.java

Violation Line
Document empty constructor 3738
Avoid if (x != y) ..; else ..; 4852
No need to check for null before an instanceof 85

Tobago Core - org/apache/myfaces/tobago/event/ValueExpressionTabChangeListener.java

Violation Line
Document empty constructor 3738
Avoid if (x != y) ..; else ..; 4852
No need to check for null before an instanceof 85

Tobago Core - org/apache/myfaces/tobago/facelets/AttributeHandler.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20356
Possible God class (WMC=77, ATFD=82, TCC=0.027777777777777776) 20356
The class 'AttributeHandler' has a Standard Cyclomatic Complexity of 6 (Highest = 50). 56356
The class 'AttributeHandler' has a Cyclomatic Complexity of 7 (Highest = 57). 56356
The class 'AttributeHandler' has a Modified Cyclomatic Complexity of 6 (Highest = 50). 56356
The method apply() has an NCSS line count of 158 74273
The method 'apply' has a Standard Cyclomatic Complexity of 50. 74273
The method 'apply' has a Cyclomatic Complexity of 57. 74273
The method 'apply' has a Modified Cyclomatic Complexity of 50. 74273
Avoid really long methods. 74273
Avoid if (x != y) ..; else ..; 81271
Avoid if (x != y) ..; else ..; 85103
Avoid if (x != y) ..; else ..; 108126
Avoid if (x != y) ..; else ..; 194201
Avoid if (x != y) ..; else ..; 262270
Consider using varargs for methods or constructors which take an array the last parameter. 297
Avoid if (x != y) ..; else ..; 303309

Tobago Core - org/apache/myfaces/tobago/facelets/ConverterHandler.java

Violation Line
Avoid declaring a variable if it is unreferenced before a possible exit point. 54
New exception is thrown in catch block, original stack trace may be lost 66
Deeply nested if..then statements are hard to read 6870

Tobago Core - org/apache/myfaces/tobago/facelets/EventHandler.java

Violation Line
Parameter 'config' is not assigned and could be declared final 81
Parameter 'ctx' is not assigned and could be declared final 86
Parameter 'parent' is not assigned and could be declared final 86
Parameter 'context' is not assigned and could be declared final 136
Parameter 'parent' is not assigned and could be declared final 136
Local variable 'faceletContext' could be declared final 138139
Avoid declaring a variable if it is unreferenced before a possible exit point. 138139
Avoid unused local variables such as 'faceletContext'. 138
Local variable 'cvh' could be declared final 142
Local variable 'clientBehaviors' could be declared final 154
Local variable 'clientBehaviorList' could be declared final 156
Local variable 'cb' could be declared final 158
Local variable 'ajaxBehavior' could be declared final 169
Parameter 'context' is not assigned and could be declared final 174
Parameter 'faceletContext' is not assigned and could be declared final 179
Parameter 'component' is not assigned and could be declared final 179
Parameter 'parent' is not assigned and could be declared final 179
Document empty constructor 207208
Parameter 'expr' is not assigned and could be declared final 210
Parameter 'event' is not assigned and could be declared final 214
Parameter 'state' is not assigned and could be declared final 224
Parameter 'context' is not assigned and could be declared final 224
Parameter 'context' is not assigned and could be declared final 231
Parameter 'newTransientValue' is not assigned and could be declared final 238

Tobago Core - org/apache/myfaces/tobago/facelets/FixCharacterEncodingFilter.java

Violation Line
Document empty method 5758

Tobago Core - org/apache/myfaces/tobago/facelets/MetaInfResourcesClasspathResourceResolver.java

Violation Line
Avoid reassigning parameters such as 'path' 55
Avoid reassigning parameters such as 'path' 55
This call to String.startsWith can be rewritten using String.charAt(0) 61

Tobago Core - org/apache/myfaces/tobago/facelets/Resource.java

Violation Line
These nested if statements could be combined 7274
Document empty method 114115
Avoid if (x != y) ..; else ..; 136

Tobago Core - org/apache/myfaces/tobago/facelets/ScriptHandler.java

Violation Line
Document empty method 3435
Document empty method 3839

Tobago Core - org/apache/myfaces/tobago/facelets/SegmentLayoutRule.java

Violation Line
These nested if statements could be combined 3953
Local variable 'a' could be declared final 40
Deeply nested if..then statements are hard to read 4143
Deeply nested if..then statements are hard to read 4446
Deeply nested if..then statements are hard to read 4749
Deeply nested if..then statements are hard to read 5052

Tobago Core - org/apache/myfaces/tobago/facelets/SheetStateChangeSourceRule.java

Violation Line
These nested if statements could be combined 4143

Tobago Core - org/apache/myfaces/tobago/facelets/SortActionSourceRule.java

Violation Line
These nested if statements could be combined 4244

Tobago Core - org/apache/myfaces/tobago/facelets/SpanHandler.java

Violation Line
Parameter 'parent' is not assigned and could be declared final 47

Tobago Core - org/apache/myfaces/tobago/facelets/SuggestMethodRule.java

Violation Line
These nested if statements could be combined 4244
These nested if statements could be combined 4751
Deeply nested if..then statements are hard to read 4850
These nested if statements could be combined 4850

Tobago Core - org/apache/myfaces/tobago/facelets/SupportsMarkupRule.java

Violation Line
Local variable 'a' could be declared final 41

Tobago Core - org/apache/myfaces/tobago/facelets/TabChangeListenerHandler.java

Violation Line
New exception is thrown in catch block, original stack trace may be lost 77
Deeply nested if..then statements are hard to read 7981
Avoid if (x != y) ..; else ..; 8388

Tobago Core - org/apache/myfaces/tobago/facelets/TabChangeSourceRule.java

Violation Line
These nested if statements could be combined 3840

Tobago Core - org/apache/myfaces/tobago/facelets/TagMethodExpression.java

Violation Line
New exception is thrown in catch block, original stack trace may be lost 64
New exception is thrown in catch block, original stack trace may be lost 66
New exception is thrown in catch block, original stack trace may be lost 68
Consider using varargs for methods or constructors which take an array the last parameter. 73
New exception is thrown in catch block, original stack trace may be lost 77
New exception is thrown in catch block, original stack trace may be lost 79
New exception is thrown in catch block, original stack trace may be lost 81

Tobago Core - org/apache/myfaces/tobago/facelets/TobagoComponentHandler.java

Violation Line
Local variable 'validator' could be declared final 94
Local variable 'entry' could be declared final 97
Local variable 'next' could be declared final 103

Tobago Core - org/apache/myfaces/tobago/internal/ajax/AjaxInternalUtils.java

Violation Line
Parameter 'facesContext' is not assigned and could be declared final 64

Tobago Core - org/apache/myfaces/tobago/internal/ajax/AjaxNavigationListener.java

Violation Line
Parameter 'facesContext' is not assigned and could be declared final 63

Tobago Core - org/apache/myfaces/tobago/internal/ajax/AjaxNavigationState.java

Violation Line
Private field 'viewRoot' could be made final; it is only initialized in the declaration or constructor. 52
Private field 'messages' could be made final; it is only initialized in the declaration or constructor. 54
Avoid if (x != y) ..; else ..; 113117
Avoid if (x != y) ..; else ..; 125132
Use equals() to compare object references. 136
Parameter 'facesContext' is not assigned and could be declared final 184
Local variable 'throwable' could be declared final 188
Parameter 'facesContext' is not assigned and could be declared final 196

Tobago Core - org/apache/myfaces/tobago/internal/behavior/AttachedListStateWrapper.java

Violation Line
Private field 'wrappedStateList' could be made final; it is only initialized in the declaration or constructor. 34
Parameter 'wrappedStateList' is not assigned and could be declared final 36

Tobago Core - org/apache/myfaces/tobago/internal/behavior/AttachedStateWrapper.java

Violation Line
Private field 'clazz' could be made final; it is only initialized in the declaration or constructor. 30
Private field 'wrappedStateObject' could be made final; it is only initialized in the declaration or constructor. 31
Parameter 'clazz' is not assigned and could be declared final 36
Parameter 'wrappedStateObject' is not assigned and could be declared final 36

Tobago Core - org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.java

Violation Line
Possible God class (WMC=101, ATFD=34, TCC=0.008333333333333333) 20763
This class has too many methods, consider refactoring it. 147763
The class 'DeltaStateHelper' has a Cyclomatic Complexity of 4 (Highest = 12). 147763
The class 'DeltaStateHelper' has a Standard Cyclomatic Complexity of 4 (Highest = 11). 147763
The class 'DeltaStateHelper' has a Modified Cyclomatic Complexity of 4 (Highest = 11). 147763
Private field 'target' could be made final; it is only initialized in the declaration or constructor. 155
Private field 'fullState' could be made final; it is only initialized in the declaration or constructor. 160
Avoid using redundant field initializer for 'transientBoolean' 173
Parameter 'target' is not assigned and could be declared final 175
Parameter 'value' is not assigned and could be declared final 203
Parameter 'key' is not assigned and could be declared final 203
Parameter 'key' is not assigned and could be declared final 225
Local variable 'returnValue' could be declared final 226
Local variable 'expression' could be declared final 230231
Parameter 'key' is not assigned and could be declared final 239
Parameter 'defaultValue' is not assigned and could be declared final 239
Local variable 'returnValue' could be declared final 240
Local variable 'expression' could be declared final 244245
Parameter 'key' is not assigned and could be declared final 253
Parameter 'value' is not assigned and could be declared final 257
Parameter 'key' is not assigned and could be declared final 257
Parameter 'mapKey' is not assigned and could be declared final 281
Parameter 'value' is not assigned and could be declared final 281
Parameter 'key' is not assigned and could be declared final 281
Parameter 'key' is not assigned and could be declared final 315
Parameter 'key' is not assigned and could be declared final 333
Parameter 'valueOrKey' is not assigned and could be declared final 333
Local variable 'collectionOrMap' could be declared final 340
Parameter 'stateMap' is not assigned and could be declared final 365
Parameter 'key' is not assigned and could be declared final 365
Parameter 'valueOrKey' is not assigned and could be declared final 366
Local variable 'c' could be declared final 368
Parameter 'stateMap' is not assigned and could be declared final 379
Parameter 'key' is not assigned and could be declared final 379
Parameter 'valueOrKey' is not assigned and could be declared final 380
Local variable 'c' could be declared final 382
Parameter 'key' is not assigned and could be declared final 395
Parameter 'stateMap' is not assigned and could be declared final 395
Parameter 'valueOrKey' is not assigned and could be declared final 396
Parameter 'delta' is not assigned and could be declared final 396
Local variable 'map' could be declared final 402
Parameter 'context' is not assigned and could be declared final 433
Local variable 'serializableMap' could be declared final 434
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 436
Local variable 'it' could be declared final 459
Local variable 'value' could be declared final 465
Local variable 'savedValue' could be declared final 471
The method 'restoreState' has a Standard Cyclomatic Complexity of 11. 515569
The method 'restoreState' has a Cyclomatic Complexity of 12. 515569
The method 'restoreState' has a Modified Cyclomatic Complexity of 11. 515569
Parameter 'state' is not assigned and could be declared final 515
Parameter 'context' is not assigned and could be declared final 515
Local variable 'serializedState' could be declared final 520
Local variable 'key' could be declared final 530
Local variable 'savedValue' could be declared final 531532
Local variable 'mapEntry' could be declared final 536
Local variable 'addOrRemove' could be declared final 538
Local variable 'mapEntry' could be declared final 548
Parameter 'transientValue' is not assigned and could be declared final 571
Parameter 'initialCapacity' is not assigned and could be declared final 582
Parameter 'loadFactor' is not assigned and could be declared final 582
Parameter 'm' is not assigned and could be declared final 586
Parameter 'initialSize' is not assigned and could be declared final 590
Parameter 'newTransientValue' is not assigned and could be declared final 598
Parameter 'context' is not assigned and could be declared final 602
Parameter 'state' is not assigned and could be declared final 602
Local variable 'listAsMap' could be declared final 603
Parameter 'context' is not assigned and could be declared final 609
Local variable 'entry' could be declared final 612
Local variable 'value' could be declared final 614
Parameter 'loadFactor' is not assigned and could be declared final 636
Parameter 'initialCapacity' is not assigned and could be declared final 636
Parameter 'initialSize' is not assigned and could be declared final 640
Parameter 'm' is not assigned and could be declared final 644
Parameter 'c' is not assigned and could be declared final 654
Parameter 'initialSize' is not assigned and could be declared final 658
Parameter 'newTransientValue' is not assigned and could be declared final 666
Document empty method 666667
Parameter 'context' is not assigned and could be declared final 669
Parameter 'state' is not assigned and could be declared final 669
Local variable 'listAsArr' could be declared final 670
Local variable 'elem' could be declared final 673
Parameter 'context' is not assigned and could be declared final 678
Local variable 'value' could be declared final 681
Parameter 'attachedObject' is not assigned and could be declared final 693
Parameter 'context' is not assigned and could be declared final 693
Local variable 'holder' could be declared final 704
Local variable 'lst' could be declared final 711
Local variable 'item' could be declared final 712
Parameter 'context' is not assigned and could be declared final 726
Parameter 'stateObj' is not assigned and could be declared final 726
Local variable 'lst' could be declared final 734
Local variable 'restoredList' could be declared final 735
Local variable 'item' could be declared final 736
Local variable 'clazz' could be declared final 741
Local variable 'wrapper' could be declared final 752
Local variable 'wrappedState' could be declared final 753
Local variable 'holder' could be declared final 755

Tobago Core - org/apache/myfaces/tobago/internal/behavior/EventBehavior.java

Violation Line
Possible God class (WMC=48, ATFD=8, TCC=0.03260869565217391) 20315
Avoid using redundant field initializer for 'stateHelper' 74
Parameter 'listener' is not assigned and could be declared final 83
Parameter 'listener' is not assigned and could be declared final 87
Parameter 'execute' is not assigned and could be declared final 98
Parameter 'onError' is not assigned and could be declared final 106
Parameter 'onEvent' is not assigned and could be declared final 114
Parameter 'render' is not assigned and could be declared final 125
Parameter 'name' is not assigned and could be declared final 130
Local variable 'bindings' could be declared final 136137
Avoid if (x != y) ..; else ..; 138142
Parameter 'name' is not assigned and could be declared final 145
Parameter 'expression' is not assigned and could be declared final 145
Parameter 'disabled' is not assigned and could be declared final 174
Parameter 'immediate' is not assigned and could be declared final 184
Parameter 'facesContext' is not assigned and could be declared final 203
Parameter 'o' is not assigned and could be declared final 203
Local variable 'values' could be declared final 207
Parameter 'create' is not assigned and could be declared final 225
Parameter 'facesContext' is not assigned and could be declared final 236
Local variable 'parentSaved' could be declared final 238
Local variable 'stateHelper' could be declared final 240
Local variable 'stateHelper' could be declared final 253
Parameter 'attributeName' is not assigned and could be declared final 274
Local variable 'value' could be declared final 275
Parameter 'stringValue' is not assigned and could be declared final 295
Local variable 'arrValue' could be declared final 308

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIBar.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2225

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIButton.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2224

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIButtons.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2223

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUICollapsiblePanel.java

Violation Line
Avoid unused private fields such as 'LOG'. 34
Parameter 'submittedCollapsed' is not assigned and could be declared final 85
Avoid if (x != y) ..; else ..; 9296

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIColumnNode.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2728

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIColumnSelector.java

Violation Line
An empty method in an abstract class should be abstract instead 3234

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUICommand.java

Violation Line
Avoid unused private fields such as 'LOG'. 38
Local variable 'child' could be declared final 50

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUICommandBase.java

Violation Line
Parameter 'event' is not assigned and could be declared final 44
Local variable 'operation' could be declared final 49
Avoid instantiating new objects inside loops 50
Local variable 'bool' could be declared final 105
Do not use if statements that are always true or always false 115
Parameter 'disabled' is not assigned and could be declared final 129

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIData.java

Violation Line
Possible God class (WMC=47, ATFD=11, TCC=0.11462450592885376) 20314
The String literal "Not a tree model" appears 4 times in this file; the first occurrence is on line 74 74
Avoid if (x != y) ..; else ..; 8387
Avoid if (x != y) ..; else ..; 150154
Avoid if (x != y) ..; else ..; 159
Avoid if (x != y) ..; else ..; 164
String.indexOf(char) is faster than String.indexOf(String). 205
Parameter 'callback' is not assigned and could be declared final 267
Parameter 'context' is not assigned and could be declared final 267
Local variable 'oldRowIndex' could be declared final 274
Local variable 'childCount' could be declared final 294
Local variable 'child' could be declared final 295
These nested if statements could be combined 297299

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIFlexLayout.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2932

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIFlowLayout.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2427

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIGridLayout.java

Violation Line
Parameter 'event' is not assigned and could be declared final 56
Avoid instantiating new objects inside loops 72
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 96
Avoid appending characters as strings in StringBuffer.append. 96
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 97
Avoid appending characters as strings in StringBuffer.append. 98
Avoid appending characters as strings in StringBuffer.append. 108
Avoid appending characters as strings in StringBuffer.append. 118

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIIn.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2224

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUILabel.java

Violation Line
Avoid if (x != y) ..; else ..; 3339
Avoid if (x != y) ..; else ..; 3539

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUILayoutBase.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2729

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUILinks.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2223

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIMessages.java

Violation Line
Avoid if (x != y) ..; else ..; 4246
Avoid declaring a variable if it is unreferenced before a possible exit point. 64
Avoid instantiating new objects inside loops 74

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIObject.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2627

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIOut.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2728

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIPage.java

Violation Line
The class 'AbstractUIPage' has a Cyclomatic Complexity of 3 (Highest = 11). 36160
Avoid if (x != y) ..; else ..; 7074
The method 'markSubmittedForm' has a Cyclomatic Complexity of 11. 103159
Avoid if (x != y) ..; else ..; 114121
Avoid if (x != y) ..; else ..; 145158

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIPanel.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2425

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIPanelBase.java

Violation Line
Avoid if (x != y) ..; else ..; 4650

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIPopup.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2426

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIProgress.java

Violation Line
Avoid unused private fields such as 'LOG'. 39
Parameter 'event' is not assigned and could be declared final 53
Local variable 'model' could be declared final 58
Local variable 'm' could be declared final 60
Do not add empty strings 72
Avoid if (x != y) ..; else ..; 7478

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIRow.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2425

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIScript.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2728

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISection.java

Violation Line
Parameter 'context' is not assigned and could be declared final 55
Avoid if (x != y) ..; else ..; 5963
Parameter 'level' is not assigned and could be declared final 73

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISegmentLayout.java

Violation Line
Local variable 'builder' could be declared final 35

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectBooleanCheckbox.java

Violation Line
These nested if statements could be combined 5360

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectManyCheckbox.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2223

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectOneBase.java

Violation Line
Avoid if (x != y) ..; else ..; 4148

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectOneRadio.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2223

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISeparator.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2627

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISheet.java

Violation Line
Possible God class (WMC=122, ATFD=39, TCC=0.014396456256921373) 20570
A high number of imports can indicate a high degree of coupling within an object. 20570
The class 'AbstractUISheet' has a Standard Cyclomatic Complexity of 3 (Highest = 17). 65570
The class 'AbstractUISheet' has a Cyclomatic Complexity of 3 (Highest = 19). 65570
The class 'AbstractUISheet' has a Modified Cyclomatic Complexity of 2 (Highest = 12). 65570
This class has too many methods, consider refactoring it. 67570
Avoid if (x != y) ..; else ..; 8791
Parameter 'event' is not assigned and could be declared final 128
Local variable 'layoutToken' could be declared final 140
Avoid if (x != y) ..; else ..; 266270
Avoid if (x != y) ..; else ..; 276284
Avoid if (x != y) ..; else ..; 297305
Avoid if (x != y) ..; else ..; 304
Avoid if (x != y) ..; else ..; 315
Local variable 'result' could be declared final 337
Parameter 'facesContext' is not assigned and could be declared final 393
Local variable 'columnSpan' could be declared final 417
Local variable 'rowSpan' could be declared final 418
Avoid instantiating new objects inside loops 419
Avoid reassigning parameters such as 'event' 425
Parameter 'facesContext' is not assigned and could be declared final 425
Avoid if (x != y) ..; else ..; 429442
Avoid reassigning parameters such as 'searchId' 467
The method 'performPaging' has a Cyclomatic Complexity of 19. 483544
The method 'performPaging' has a Modified Cyclomatic Complexity of 12. 483544
The method 'performPaging' has a Standard Cyclomatic Complexity of 17. 483544
A switch statement does not contain a break 491534
Avoid if (x != y) ..; else ..; 537541

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISuggest.java

Violation Line
Avoid if (x != y) ..; else ..; 5968
Parameter 'query' is not assigned and could be declared final 71
Avoid if (x != y) ..; else ..; 7381

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITabGroup.java

Violation Line
Possible God class (WMC=54, ATFD=20, TCC=0.0) 20277
The class 'AbstractUITabGroup' has a Modified Cyclomatic Complexity of 2 (Highest = 10). 47277
The class 'AbstractUITabGroup' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 47277
The class 'AbstractUITabGroup' has a Cyclomatic Complexity of 2 (Highest = 10). 47277
This class has too many methods, consider refactoring it. 48277
Document empty method 5354
An empty method in an abstract class should be abstract instead 5354
The method 'processDecodes' has a Cyclomatic Complexity of 10. 101136
The method 'processDecodes' has a Modified Cyclomatic Complexity of 10. 101136
The method 'processDecodes' has a Standard Cyclomatic Complexity of 10. 101136
Avoid if (x != y) ..; else ..; 102135
Use opposite operator instead of the logic complement operator. 102
These nested if statements could be combined 115117
Use opposite operator instead of the logic complement operator. 140
Avoid if (x != y) ..; else ..; 140151
Use opposite operator instead of the logic complement operator. 156
Avoid if (x != y) ..; else ..; 156168
Use opposite operator instead of the logic complement operator. 189
Avoid if (x != y) ..; else ..; 197201

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITextarea.java

Violation Line
An empty method in an abstract class should be abstract instead 2527

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITreeCommand.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2223

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITreeIndent.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2627

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITreeNode.java

Violation Line
An empty method in an abstract class should be abstract instead 2527

Tobago Core - org/apache/myfaces/tobago/internal/config/ContentSecurityPolicy.java

Violation Line
Avoid using redundant field initializer for 'unmodifiable' 31

Tobago Core - org/apache/myfaces/tobago/internal/config/RenderersConfigImpl.java

Violation Line
Avoid unused private fields such as 'LOG'. 37
Avoid using redundant field initializer for 'merged' 40
Avoid using redundant field initializer for 'unmodifiable' 42

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigBuilder.java

Violation Line
Private field 'list' could be made final; it is only initialized in the declaration or constructor. 44
Avoid unused local variables such as 'builder'. 68
Avoid instantiating new objects inside loops 99

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigEntityResolver.java

Violation Line
Position literals first in String comparisons 52
Position literals first in String comparisons 54
Position literals first in String comparisons 56
Position literals first in String comparisons 58
Avoid if (x != y) ..; else ..; 6369

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigFragment.java

Violation Line
Too many fields 33195
Avoid unused private fields such as 'LOG'. 35
Private field 'before' could be made final; it is only initialized in the declaration or constructor. 38
Private field 'after' could be made final; it is only initialized in the declaration or constructor. 39
Private field 'supportedThemeNames' could be made final; it is only initialized in the declaration or constructor. 41
Private field 'themeDefinitions' could be made final; it is only initialized in the declaration or constructor. 49
Private field 'mimeTypes' could be made final; it is only initialized in the declaration or constructor. 53
Parameter 'sanitizerClass' is not assigned and could be declared final 171
Parameter 'sanitizerProperties' is not assigned and could be declared final 179
Parameter 'extension' is not assigned and could be declared final 183
Parameter 'type' is not assigned and could be declared final 183
Avoid if (x != y) ..; else ..; 193

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigImpl.java

Violation Line
Possible God class (WMC=64, ATFD=24, TCC=0.09032258064516129) 20408
The class 'TobagoConfigImpl' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 53408
The class 'TobagoConfigImpl' has a Modified Cyclomatic Complexity of 2 (Highest = 10). 53408
The class 'TobagoConfigImpl' has a Cyclomatic Complexity of 2 (Highest = 10). 53408
Too many fields 53408
Private field 'contentSecurityPolicy' could be made final; it is only initialized in the declaration or constructor. 67
Avoid using redundant field initializer for 'unmodifiable' 73
Local variable 'theme' could be declared final 93
The method 'resolveThemes' has a Modified Cyclomatic Complexity of 10. 119161
The method 'resolveThemes' has a Standard Cyclomatic Complexity of 10. 119161
The method 'resolveThemes' has a Cyclomatic Complexity of 10. 119161
Avoid if (x != y) ..; else ..; 122149
Parameter 'availableTheme' is not assigned and could be declared final 206
The method 'initProjectState' has a Standard Cyclomatic Complexity of 10. 230269
The method 'initProjectState' has a Cyclomatic Complexity of 10. 230269
The method 'initProjectState' has a Modified Cyclomatic Complexity of 10. 230269
Use block level rather than method level synchronization 271290
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 280
Parameter 'sanitizer' is not assigned and could be declared final 351
StringBuffer constructor is initialized with size 16, but has at least 276 characters appended. 372
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 373
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 373
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 379
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 380
Avoid if (x != y) ..; else ..; 380
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 381
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 382
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 383
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 384
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 385
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 386
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 387
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 388
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 389
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 390
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 391
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 392
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 393
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 394
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 395
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 396
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 397
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 398
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 402
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 403
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 404

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigParser.java

Violation Line
Possible God class (WMC=102, ATFD=37, TCC=0.05454545454545454) 20452
This class has too many methods, consider refactoring it. 48452
The class 'TobagoConfigParser' has a Cyclomatic Complexity of 5 (Highest = 30). 48452
The class 'TobagoConfigParser' has a Standard Cyclomatic Complexity of 5 (Highest = 30). 48452
StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 93
Perhaps 'extension' could be replaced by a local variable. 96
Perhaps 'type' could be replaced by a local variable. 97
Document empty constructor 101102
Avoid really long methods. 153255
The method 'startElement' has a Cyclomatic Complexity of 16. 153255
The method 'startElement' has a Standard Cyclomatic Complexity of 16. 153255
A switch statement does not contain a break 162254
Avoid if (x != y) ..; else ..; 174178
The method 'endElement' has a Standard Cyclomatic Complexity of 30. 263410
Avoid really long methods. 263410
The method 'endElement' has a Cyclomatic Complexity of 30. 263410
The method endElement() has an NCSS line count of 110 263410
A switch statement does not contain a break 273302
Avoid if (x != y) ..; else ..; 289293

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigSorter.java

Violation Line
Possible God class (WMC=64, ATFD=62, TCC=0.20952380952380953) 20332
The class 'TobagoConfigSorter' has a Cyclomatic Complexity of 5 (Highest = 17). 36332
The class 'TobagoConfigSorter' has a Standard Cyclomatic Complexity of 5 (Highest = 17). 36332
This class has too many methods, consider refactoring it. 36332
The class 'TobagoConfigSorter' has a Modified Cyclomatic Complexity of 5 (Highest = 17). 36332
Private field 'list' could be made final; it is only initialized in the declaration or constructor. 40
Prefer StringBuffer over += for concatenating strings 66
The method 'merge' has a Standard Cyclomatic Complexity of 17. 73159
The method 'merge' has a Cyclomatic Complexity of 17. 73159
The method 'merge' has a Modified Cyclomatic Complexity of 17. 73159
The method merge() has an NPath complexity of 12291 73159
Local variable 'theme' could be declared final 130
Avoid instantiation through private constructors from outside of the constructors class. 170
Avoid instantiating new objects inside loops 170
Avoid instantiating new objects inside loops 181
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 182
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 183
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 184
The String literal "' < '" appears 4 times in this file; the first occurrence is on line 184 184
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 185
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 186
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 186
Avoid appending characters as strings in StringBuffer.append. 189
Avoid instantiating new objects inside loops 205
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 206
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 207
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 208
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 209
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 210
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 211
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 212
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 213
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 214
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 214
Avoid appending characters as strings in StringBuffer.append. 217
Avoid instantiating new objects inside loops 250
Avoid instantiation through private constructors from outside of the constructors class. 250
Avoid instantiation through private constructors from outside of the constructors class. 256
Avoid instantiating new objects inside loops 256
Parameter 'map' is not assigned and could be declared final 284
Parameter 'tobagoConfig' is not assigned and could be declared final 284

Tobago Core - org/apache/myfaces/tobago/internal/context/DateTimeI18n.java

Violation Line
A class which only has private constructors should be final 31106
Parameter 'locale' is not assigned and could be declared final 44
Unnecessary use of fully qualified name 'java.util.Calendar.MONTH' due to existing import 'java.util.Calendar' 56
Use block level rather than method level synchronization 7381
Parameter 'locale' is not assigned and could be declared final 73

Tobago Core - org/apache/myfaces/tobago/internal/layout/Grid.java

Violation Line
The class 'Grid' has a Cyclomatic Complexity of 6 (Highest = 55). 30447
The class 'Grid' has a Modified Cyclomatic Complexity of 6 (Highest = 51). 30447
The class 'Grid' has a Standard Cyclomatic Complexity of 6 (Highest = 51). 30447
Private field 'cells' could be made final; it is only initialized in the declaration or constructor. 38
Private field 'columns' could be made final; it is only initialized in the declaration or constructor. 40
Private field 'rows' could be made final; it is only initialized in the declaration or constructor. 41
Private field 'columnCount' could be made final; it is only initialized in the declaration or constructor. 43
Avoid reassigning parameters such as 'columnSpan' 68
Avoid reassigning parameters such as 'columnSpan' 68
Avoid instantiating new objects inside loops 100
The method gridAsString() has an NCSS line count of 175 203431
The method 'gridAsString' has a Standard Cyclomatic Complexity of 51. 203431
The method gridAsString() has an NPath complexity of 11503356 203431
Avoid really long methods. 203431
The method 'gridAsString' has a Modified Cyclomatic Complexity of 51. 203431
The method 'gridAsString' has a Cyclomatic Complexity of 55. 203431
StringBuffer constructor is initialized with size 16, but has at least 17 characters appended. 205
Avoid if (x != y) ..; else ..; 210214
Avoid appending characters as strings in StringBuffer.append. 211
Avoid appending characters as strings in StringBuffer.append. 213
Avoid appending characters as strings in StringBuffer.append. 219
Avoid appending characters as strings in StringBuffer.append. 222
Avoid appending characters as strings in StringBuffer.append. 225
Avoid appending characters as strings in StringBuffer.append. 227
Avoid appending characters as strings in StringBuffer.append. 229
Avoid if (x != y) ..; else ..; 234238
Avoid appending characters as strings in StringBuffer.append. 235
Avoid appending characters as strings in StringBuffer.append. 237
Avoid if (x != y) ..; else ..; 241245
Avoid appending characters as strings in StringBuffer.append. 242
Avoid appending characters as strings in StringBuffer.append. 244
Avoid appending characters as strings in StringBuffer.append. 246
Avoid appending characters as strings in StringBuffer.append. 257
Avoid appending characters as strings in StringBuffer.append. 260
Avoid appending characters as strings in StringBuffer.append. 263
Avoid appending characters as strings in StringBuffer.append. 265
Avoid appending characters as strings in StringBuffer.append. 267
Avoid appending characters as strings in StringBuffer.append. 282
Avoid appending characters as strings in StringBuffer.append. 284
Avoid appending characters as strings in StringBuffer.append. 287
Avoid appending characters as strings in StringBuffer.append. 292
Avoid appending characters as strings in StringBuffer.append. 294
Avoid appending characters as strings in StringBuffer.append. 296
Avoid appending characters as strings in StringBuffer.append. 301
Avoid appending characters as strings in StringBuffer.append. 303
Avoid appending characters as strings in StringBuffer.append. 307
Avoid appending characters as strings in StringBuffer.append. 309
Avoid appending characters as strings in StringBuffer.append. 318
Avoid appending characters as strings in StringBuffer.append. 320
Avoid appending characters as strings in StringBuffer.append. 326
Avoid appending characters as strings in StringBuffer.append. 329
Avoid appending characters as strings in StringBuffer.append. 332
Avoid appending characters as strings in StringBuffer.append. 334
Avoid appending characters as strings in StringBuffer.append. 336
Avoid appending characters as strings in StringBuffer.append. 340
Avoid if (x != y) ..; else ..; 346350
Avoid appending characters as strings in StringBuffer.append. 347
Avoid appending characters as strings in StringBuffer.append. 349
Avoid appending characters as strings in StringBuffer.append. 355
Avoid appending characters as strings in StringBuffer.append. 357
Avoid appending characters as strings in StringBuffer.append. 361
Avoid appending characters as strings in StringBuffer.append. 364
Avoid appending characters as strings in StringBuffer.append. 367
Avoid appending characters as strings in StringBuffer.append. 372
Avoid appending characters as strings in StringBuffer.append. 374
Avoid appending characters as strings in StringBuffer.append. 378
Avoid if (x != y) ..; else ..; 382386
Avoid appending characters as strings in StringBuffer.append. 383
Avoid appending characters as strings in StringBuffer.append. 385
Avoid appending characters as strings in StringBuffer.append. 387
Avoid if (x != y) ..; else ..; 393397
Avoid appending characters as strings in StringBuffer.append. 394
Avoid appending characters as strings in StringBuffer.append. 396
Avoid appending characters as strings in StringBuffer.append. 402
Avoid appending characters as strings in StringBuffer.append. 405
Avoid appending characters as strings in StringBuffer.append. 408
Avoid appending characters as strings in StringBuffer.append. 410
Avoid appending characters as strings in StringBuffer.append. 412
Avoid if (x != y) ..; else ..; 417421
Avoid appending characters as strings in StringBuffer.append. 418
Avoid appending characters as strings in StringBuffer.append. 420
Avoid if (x != y) ..; else ..; 423427
Avoid appending characters as strings in StringBuffer.append. 424
Avoid appending characters as strings in StringBuffer.append. 426
Avoid appending characters as strings in StringBuffer.append. 428

Tobago Core - org/apache/myfaces/tobago/internal/layout/LayoutUtils.java

Violation Line
Parameter 'component' is not assigned and could be declared final 85
Avoid if (x != y) ..; else ..; 8993
Avoid if (x != y) ..; else ..; 96100

Tobago Core - org/apache/myfaces/tobago/internal/layout/MathUtils.java

Violation Line
Avoid reassigning parameters such as 'bias' 36
Avoid unused local variables such as 'ignored'. 37
Consider using varargs for methods or constructors which take an array the last parameter. 53
Consider using varargs for methods or constructors which take an array the last parameter. 70

Tobago Core - org/apache/myfaces/tobago/internal/layout/OriginCell.java

Violation Line
Private field 'component' could be made final; it is only initialized in the declaration or constructor. 26

Tobago Core - org/apache/myfaces/tobago/internal/layout/SpanCell.java

Violation Line
Private field 'origin' could be made final; it is only initialized in the declaration or constructor. 26
Private field 'horizontalFirst' could be made final; it is only initialized in the declaration or constructor. 27
Private field 'verticalFirst' could be made final; it is only initialized in the declaration or constructor. 28

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/Collapse.java

Violation Line
Private field 'action' could be made final; it is only initialized in the declaration or constructor. 24
Private field 'forId' could be made final; it is only initialized in the declaration or constructor. 25
Parameter 'forId' is not assigned and could be declared final 27
Parameter 'action' is not assigned and could be declared final 27

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/Command.java

Violation Line
The class 'Command' has a Cyclomatic Complexity of 2 (Highest = 13). 39261
The class 'Command' has a Modified Cyclomatic Complexity of 2 (Highest = 13). 39261
The class 'Command' has a Standard Cyclomatic Complexity of 2 (Highest = 13). 39261
Document empty constructor 5758
Avoid long parameter lists. 6063
Avoid reassigning parameters such as 'facetComponent' 90
Do not add empty strings 126
Parameter 'execute' is not assigned and could be declared final 161
Parameter 'render' is not assigned and could be declared final 171
Parameter 'collapse' is not assigned and could be declared final 205
The method 'merge' has a Modified Cyclomatic Complexity of 13. 217260
The method 'merge' has a Cyclomatic Complexity of 13. 217260
Parameter 'c' is not assigned and could be declared final 217
The method 'merge' has a Standard Cyclomatic Complexity of 13. 217260
The method merge() has an NPath complexity of 2304 217260
Avoid if (x != y) ..; else ..; 231237
Avoid if (x != y) ..; else ..; 238244

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/CommandMap.java

Violation Line
Document empty constructor 4546
Avoid if (x != y) ..; else ..; 7680
Avoid if (x != y) ..; else ..; 99117
Local variable 'entry' could be declared final 107
Local variable 'key' could be declared final 108
Local variable 'value' could be declared final 109

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/BarRenderer.java

Violation Line
Parameter 'component' is not assigned and could be declared final 49
Parameter 'facesContext' is not assigned and could be declared final 49
Parameter 'component' is not assigned and could be declared final 79
Parameter 'facesContext' is not assigned and could be declared final 79
Local variable 'itemsToEncode' could be declared final 83
Local variable 'child' could be declared final 85
Parameter 'result' is not assigned and could be declared final 93
Local variable 'child' could be declared final 94
Parameter 'facesContext' is not assigned and could be declared final 106
Parameter 'component' is not assigned and could be declared final 106
Parameter 'navbarId' is not assigned and could be declared final 114
Parameter 'bar' is not assigned and could be declared final 114
Parameter 'writer' is not assigned and could be declared final 114
Parameter 'facesContext' is not assigned and could be declared final 114

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/BoxRenderer.java

Violation Line
The class 'BoxRenderer' has a Cyclomatic Complexity of 6 (Highest = 10). 38104
The method encodeBegin() has an NPath complexity of 220 4195
The method 'encodeBegin' has a Cyclomatic Complexity of 10. 4195

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/ButtonsRenderer.java

Violation Line
Parameter 'component' is not assigned and could be declared final 39
Parameter 'facesContext' is not assigned and could be declared final 39
Parameter 'component' is not assigned and could be declared final 58
Parameter 'facesContext' is not assigned and could be declared final 58

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/ColumnRenderer.java

Violation Line
Avoid unused private methods such as 'isPure(UIColumn)'. 39

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/CommandRendererBase.java

Violation Line
The class 'CommandRendererBase' has a Standard Cyclomatic Complexity of 5 (Highest = 13). 51207
The class 'CommandRendererBase' has a Modified Cyclomatic Complexity of 5 (Highest = 13). 51207
The class 'CommandRendererBase' has a Cyclomatic Complexity of 5 (Highest = 13). 51207
Avoid unused private fields such as 'LOG'. 53
The method encodeBegin() has an NPath complexity of 1728 56152
The method 'encodeBegin' has a Modified Cyclomatic Complexity of 13. 56152
The method 'encodeBegin' has a Standard Cyclomatic Complexity of 13. 56152
The method 'encodeBegin' has a Cyclomatic Complexity of 13. 56152
An empty method in an abstract class should be abstract instead 203205
Document empty method 204205

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/DateRenderer.java

Violation Line
Parameter 'component' is not assigned and could be declared final 61
Parameter 'facesContext' is not assigned and could be declared final 61
Parameter 'component' is not assigned and could be declared final 74
Parameter 'facesContext' is not assigned and could be declared final 74

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/DecodingInputRendererBase.java

Violation Line
Local variable 'textarea' could be declared final 64
Deeply nested if..then statements are hard to read 6569

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/FigureRenderer.java

Violation Line
Parameter 'facesContext' is not assigned and could be declared final 40
Parameter 'component' is not assigned and could be declared final 40
Parameter 'facesContext' is not assigned and could be declared final 56
Parameter 'component' is not assigned and could be declared final 56

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/FileRenderer.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20205
Parameter 'event' is not assigned and could be declared final 63
Local variable 'httpServletRequest' could be declared final 83
Local variable 'parts' could be declared final 85
Local variable 'part' could be declared final 86
Avoid instantiating new objects inside loops 90
Avoid instantiating new objects inside loops 92
Parameter 'component' is not assigned and could be declared final 114
Parameter 'facesContext' is not assigned and could be declared final 114
Local variable 'multiFormat' could be declared final 154
Local variable 'validator' could be declared final 184
Avoid appending characters as strings in StringBuffer.append. 188
Parameter 'facesContext' is not assigned and could be declared final 201
Parameter 'component' is not assigned and could be declared final 201

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/FlexLayoutRenderer.java

Violation Line
Local variable 'b' could be declared final 45
Local variable 'vertically' could be declared final 83

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/FooterRenderer.java

Violation Line
Parameter 'component' is not assigned and could be declared final 38
Parameter 'facesContext' is not assigned and could be declared final 38
Parameter 'component' is not assigned and could be declared final 53
Parameter 'facesContext' is not assigned and could be declared final 53

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/GridLayoutRenderer.java

Violation Line
The class 'GridLayoutRenderer' has a Cyclomatic Complexity of 4 (Highest = 10). 47153
The class 'GridLayoutRenderer' has a Modified Cyclomatic Complexity of 4 (Highest = 10). 47153
The class 'GridLayoutRenderer' has a Standard Cyclomatic Complexity of 4 (Highest = 10). 47153
Avoid unused private fields such as 'LOG'. 49
StringBuffer constructor is initialized with size 16, but has at least 24 characters appended. 62
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 66
Avoid appending characters as strings in StringBuffer.append. 66
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 66
Avoid appending characters as strings in StringBuffer.append. 70
Avoid unused local variables such as 'column'. 76
Local variable 'column' could be declared final 76
The method 'encodeChildren' has a Standard Cyclomatic Complexity of 10. 90144
The method 'encodeChildren' has a Modified Cyclomatic Complexity of 10. 90144
The method 'encodeChildren' has a Cyclomatic Complexity of 10. 90144
Avoid instantiating new objects inside loops 114
Local variable 'builder' could be declared final 114
Avoid appending characters as strings in StringBuffer.append. 115
Avoid appending characters as strings in StringBuffer.append. 120
Avoid appending characters as strings in StringBuffer.append. 126
Avoid appending characters as strings in StringBuffer.append. 132

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/HeaderRenderer.java

Violation Line
Parameter 'component' is not assigned and could be declared final 38
Parameter 'facesContext' is not assigned and could be declared final 38
Parameter 'component' is not assigned and could be declared final 57
Parameter 'facesContext' is not assigned and could be declared final 57

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/HiddenRenderer.java

Violation Line
Parameter 'component' is not assigned and could be declared final 39
Parameter 'facesContext' is not assigned and could be declared final 39
Avoid if (x != y) ..; else ..; 60
Parameter 'facesContext' is not assigned and could be declared final 64
Parameter 'component' is not assigned and could be declared final 64

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/ImageRenderer.java

Violation Line
Local variable 'fontAwesome' could be declared final 47
Avoid if (x != y) ..; else ..; 57

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/InRenderer.java

Violation Line
The class 'InRenderer' has a Standard Cyclomatic Complexity of 6 (Highest = 14). 51178
The class 'InRenderer' has a Cyclomatic Complexity of 6 (Highest = 18). 51178
The class 'InRenderer' has a Modified Cyclomatic Complexity of 6 (Highest = 14). 51178
Parameter 'component' is not assigned and could be declared final 56
The method 'encodeBeginField' has a Cyclomatic Complexity of 18. 56148
Parameter 'facesContext' is not assigned and could be declared final 56
The method 'encodeBeginField' has a Modified Cyclomatic Complexity of 14. 56148
The method 'encodeBeginField' has a Standard Cyclomatic Complexity of 14. 56148
The method encodeBeginField() has an NPath complexity of 46080 56148
Parameter 'writer' is not assigned and could be declared final 150
Parameter 'facesContext' is not assigned and could be declared final 150
Parameter 'addon' is not assigned and could be declared final 150
Local variable 'child' could be declared final 159
Parameter 'facesContext' is not assigned and could be declared final 171
Parameter 'component' is not assigned and could be declared final 171
Document empty method 171172
Document empty method 176177

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/LabelLayoutRendererBase.java

Violation Line
The class 'LabelLayoutRendererBase' has a Standard Cyclomatic Complexity of 4 (Highest = 11). 46219
The class 'LabelLayoutRendererBase' has a Cyclomatic Complexity of 4 (Highest = 11). 46219
The method 'encodeBeginSurrounding' has a Cyclomatic Complexity of 11. 96172
The method encodeBeginSurrounding() has an NPath complexity of 480 96172
The method 'encodeBeginSurrounding' has a Standard Cyclomatic Complexity of 11. 96172
Avoid declaring a variable if it is unreferenced before a possible exit point. 99
A switch statement does not contain a break 112122
A switch statement does not contain a break 154171
Parameter 'labelLayout' is not assigned and could be declared final 195
Parameter 'writer' is not assigned and could be declared final 195
Parameter 'component' is not assigned and could be declared final 195
Local variable 'labelWithAccessKey' could be declared final 204
Parameter 'component' is not assigned and could be declared final 213

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/LabelRenderer.java

Violation Line
Parameter 'event' is not assigned and could be declared final 49
Avoid if (x != y) ..; else ..; 63

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/LinksRenderer.java

Violation Line
Parameter 'facesContext' is not assigned and could be declared final 37
Parameter 'component' is not assigned and could be declared final 37
Parameter 'facesContext' is not assigned and could be declared final 51
Parameter 'component' is not assigned and could be declared final 51
Local variable 'child' could be declared final 54
Avoid unused local variables such as 'commands'. 60
Parameter 'component' is not assigned and could be declared final 71
Parameter 'facesContext' is not assigned and could be declared final 71

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/MessagesRenderer.java

Violation Line
The class 'MessagesRenderer' has a Cyclomatic Complexity of 10 (Highest = 10). 45177
The method 'encodeEnd' has a Cyclomatic Complexity of 10. 50145
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 65
Use equals() to compare object references. 90
Use equals() to compare object references. 94

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/PageRenderer.java

Violation Line
Possible God class (WMC=52, ATFD=135, TCC=0.0) 20403
A high number of imports can indicate a high degree of coupling within an object. 20403
The class 'PageRenderer' has a Modified Cyclomatic Complexity of 6 (Highest = 32). 73403
The class 'PageRenderer' has a Cyclomatic Complexity of 6 (Highest = 35). 73403
The class 'PageRenderer' has a Standard Cyclomatic Complexity of 6 (Highest = 32). 73403
The method 'encodeBegin' has a Standard Cyclomatic Complexity of 32. 96324
The method 'encodeBegin' has a Cyclomatic Complexity of 35. 96324
The method 'encodeBegin' has a Modified Cyclomatic Complexity of 32. 96324
The method encodeBegin() has an NCSS line count of 138 96324
Avoid really long methods. 96324
Deeply nested if..then statements are hard to read 164166
Avoid if (x != y) ..; else ..; 188
Local variable 'componentResources' could be declared final 219
Local variable 'childCount' could be declared final 221
Local variable 'child' could be declared final 222

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/PopupRenderer.java

Violation Line
Parameter 'facesContext' is not assigned and could be declared final 40
Parameter 'component' is not assigned and could be declared final 40
Parameter 'facesContext' is not assigned and could be declared final 78
Parameter 'component' is not assigned and could be declared final 78

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/ProgressRenderer.java

Violation Line
Avoid unused private fields such as 'LOG'. 41

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/RowRenderer.java

Violation Line
Parameter 'component' is not assigned and could be declared final 31
Local variable 'uiComponent' could be declared final 34
Avoid if (x != y) ..; else ..; 3943

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/ScriptRenderer.java

Violation Line
Parameter 'event' is not assigned and could be declared final 36

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SectionRenderer.java

Violation Line
Local variable 'label' could be declared final 55
A switch statement does not contain a break 5775

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SegmentLayoutRenderer.java

Violation Line
Avoid unused private fields such as 'LOG'. 45
Avoid declaring a variable if it is unreferenced before a possible exit point. 66
Local variable 'child' could be declared final 79
Parameter 'writer' is not assigned and could be declared final 111
Parameter 'generator' is not assigned and could be declared final 111
Parameter 'facesContext' is not assigned and could be declared final 111
Parameter 'child' is not assigned and could be declared final 111

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectBooleanCheckboxRenderer.java

Violation Line
The String literal "true" appears 4 times in this file; the first occurrence is on line 63 63
Parameter 'component' is not assigned and could be declared final 69
Parameter 'facesContext' is not assigned and could be declared final 69
Parameter 'component' is not assigned and could be declared final 122
Parameter 'facesContext' is not assigned and could be declared final 122

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyListboxRenderer.java

Violation Line
Avoid if (x != y) ..; else ..; 58

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyRendererBase.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20810
Possible God class (WMC=116, ATFD=71, TCC=0.0) 20810
The class 'SelectManyRendererBase' has a Cyclomatic Complexity of 6 (Highest = 31). 57810
The class 'SelectManyRendererBase' has a Modified Cyclomatic Complexity of 6 (Highest = 28). 57810
The class 'SelectManyRendererBase' has a Standard Cyclomatic Complexity of 6 (Highest = 28). 57810
Avoid if (x != y) ..; else ..; 74
Parameter 'input' is not assigned and could be declared final 90
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 122
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 123
Parameter 'facesContext' is not assigned and could be declared final 125
Parameter 'component' is not assigned and could be declared final 125
Parameter 'submittedValue' is not assigned and could be declared final 126
Consider using varargs for methods or constructors which take an array the last parameter. 126
The method getConvertedUISelectManyValue() has an NPath complexity of 2760 143320
The method 'getConvertedUISelectManyValue' has a Modified Cyclomatic Complexity of 28. 143320
Avoid really long methods. 143320
Parameter 'facesContext' is not assigned and could be declared final 143
The method 'getConvertedUISelectManyValue' has a Standard Cyclomatic Complexity of 28. 143320
The method 'getConvertedUISelectManyValue' has a Cyclomatic Complexity of 31. 143320
Parameter 'component' is not assigned and could be declared final 143
Parameter 'submittedValue' is not assigned and could be declared final 144
Parameter 'considerValueType' is not assigned and could be declared final 144
Local variable 'expression' could be declared final 154
Avoid if (x != y) ..; else ..; 165297
Local variable 'modelType' could be declared final 166167
Local variable 'componentType' could be declared final 173
Local variable 'iterator' could be declared final 203
Local variable 'collectionTypeAttr' could be declared final 207208
Avoid if (x != y) ..; else ..; 209289
Local variable 'collectionType' could be declared final 210
Local variable 'componentValue' could be declared final 238239
Local variable 'cloneMethod' could be declared final 244245
Local variable 'clone' could be declared final 246247
Avoid if (x != y) ..; else ..; 260262
Local variable 'isArray' could be declared final 301
Avoid if (x != y) ..; else ..; 305310
Parameter 'facesContext' is not assigned and could be declared final 333
Avoid reassigning parameters such as 'attribute' 334
Parameter 'component' is not assigned and could be declared final 374
Parameter 'facesContext' is not assigned and could be declared final 374
Local variable 'valueTypeAttr' could be declared final 377
Local variable 'valueType' could be declared final 380
Parameter 'facesContext' is not assigned and could be declared final 414
Parameter 'iterator' is not assigned and could be declared final 414
Local variable 'item' could be declared final 421
Local variable 'groupIterator' could be declared final 423424
Local variable 'selectItemsType' could be declared final 427
Parameter 'component' is not assigned and could be declared final 452
Local variable 'builder' could be declared final 453
The String literal "{Component-Path : " appears 4 times in this file; the first occurrence is on line 456 456
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 456
Avoid appending characters as strings in StringBuffer.append. 464
Parameter 'builder' is not assigned and could be declared final 469
Parameter 'component' is not assigned and could be declared final 469
Local variable 'intBuilder' could be declared final 474
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 476
Avoid appending characters as strings in StringBuffer.append. 485
The class 'SelectItemsIterator' has a Cyclomatic Complexity of 6 (Highest = 27). 500779
The class 'SelectItemsIterator' has a Modified Cyclomatic Complexity of 6 (Highest = 23). 500779
The class 'SelectItemsIterator' has a Standard Cyclomatic Complexity of 6 (Highest = 23). 500779
Private field 'facesContext' could be made final; it is only initialized in the declaration or constructor. 518
Parameter 'facesContext' is not assigned and could be declared final 520
Parameter 'selectItemsParent' is not assigned and could be declared final 520
Avoid really long methods. 529639
The method 'hasNext' has a Standard Cyclomatic Complexity of 23. 529639
The method 'hasNext' has a Modified Cyclomatic Complexity of 23. 529639
The method 'hasNext' has a Cyclomatic Complexity of 27. 529639
The method hasNext() has an NPath complexity of 1662 529639
Local variable 'uiSelectItem' could be declared final 560
Local variable 'itemValue' could be declared final 564
Local variable 'description' could be declared final 566
Local variable 'disabled' could be declared final 567
Local variable 'escape' could be declared final 568
Local variable 'noSelectionOption' could be declared final 569
Local variable 'expression' could be declared final 575
Local variable 'value' could be declared final 585
Local variable 'length' could be declared final 594
Local variable 'items' could be declared final 595
Local variable 'map' could be declared final 606
Local variable 'items' could be declared final 607
Local variable 'entry' could be declared final 608
Avoid instantiating new objects inside loops 609
Local variable 'expression' could be declared final 618
Local variable 'objects' could be declared final 619623
Local variable 'message' could be declared final 624626
The method 'next' has a Modified Cyclomatic Complexity of 11. 642715
The method 'next' has a Cyclomatic Complexity of 12. 642715
The method next() has an NPath complexity of 296 642715
The method 'next' has a Standard Cyclomatic Complexity of 11. 642715
Local variable 'value' could be declared final 647
Local variable 'attributeMap' could be declared final 658
Local variable 'var' could be declared final 663
Local variable 'itemDisabled' could be declared final 690
Local variable 'itemLabelEscaped' could be declared final 691
Local variable 'noSelectionValue' could be declared final 692
Avoid if (x != y) ..; else ..; 703709
Parameter 'defaultValue' is not assigned and could be declared final 726
Parameter 'attrName' is not assigned and could be declared final 726
Parameter 'component' is not assigned and could be declared final 726
Local variable 'value' could be declared final 727
Parameter 'component' is not assigned and could be declared final 740
Local variable 'builder' could be declared final 741
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 744
Avoid appending characters as strings in StringBuffer.append. 752
Parameter 'builder' is not assigned and could be declared final 757
Parameter 'component' is not assigned and could be declared final 757
Local variable 'intBuilder' could be declared final 762
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 764
Avoid appending characters as strings in StringBuffer.append. 773

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyShuttleRenderer.java

Violation Line
Avoid unused local variables such as 'hasLabel'. 59
Avoid if (x != y) ..; else ..; 72

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectOneChoiceRenderer.java

Violation Line
Parameter 'component' is not assigned and could be declared final 47
Parameter 'facesContext' is not assigned and could be declared final 47
Parameter 'facesContext' is not assigned and could be declared final 77
Parameter 'component' is not assigned and could be declared final 77

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectOneListboxRenderer.java

Violation Line
Avoid if (x != y) ..; else ..; 57
Parameter 'component' is not assigned and could be declared final 81
Parameter 'facesContext' is not assigned and could be declared final 81

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectOneRadioRenderer.java

Violation Line
Parameter 'component' is not assigned and could be declared final 44
Parameter 'facesContext' is not assigned and could be declared final 44
The method encodeBeginField() has an NPath complexity of 242 44118
Local variable 'tobagoItem' could be declared final 100
Parameter 'facesContext' is not assigned and could be declared final 121
Parameter 'component' is not assigned and could be declared final 121

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectReferenceRenderer.java

Violation Line
Avoid unused private fields such as 'LOG'. 35

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SeparatorRenderer.java

Violation Line
Avoid if (x != y) ..; else ..; 4556

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 201168
Possible God class (WMC=204, ATFD=491, TCC=0.005847953216374269) 201168
The class 'SheetRenderer' has a Standard Cyclomatic Complexity of 10 (Highest = 77). 921168
The class 'SheetRenderer' has a Modified Cyclomatic Complexity of 9 (Highest = 77). 921168
Avoid really long classes. 921168
This class has too many methods, consider refactoring it. 921168
The class 'SheetRenderer' has a Cyclomatic Complexity of 10 (Highest = 82). 921168
The method 'encodeBegin' has a Cyclomatic Complexity of 10. 149211
Avoid if (x != y) ..; else ..; 166170
Avoid if (x != y) ..; else ..; 172176
Avoid appending characters as strings in StringBuffer.append. 208
The method encodeEnd() has an NCSS line count of 333 219696
The method 'encodeEnd' has a Standard Cyclomatic Complexity of 77. 219696
The method 'encodeEnd' has a Modified Cyclomatic Complexity of 77. 219696
Avoid really long methods. 219696
The method 'encodeEnd' has a Cyclomatic Complexity of 82. 219696
Avoid if (x != y) ..; else ..; 234
Local variable 'sheetMarkup' could be declared final 234
Local variable 'column' could be declared final 254
Avoid if (x != y) ..; else ..; 307
Avoid if (x != y) ..; else ..; 334
Avoid appending characters as strings in StringBuffer.append. 381
Avoid instantiating new objects inside loops 402
These nested if statements could be combined 413419
These nested if statements could be combined 425460
Local variable 'normalColumn' could be declared final 426
Local variable 'selector' could be declared final 437
Avoid if (x != y) ..; else ..; 525574
Avoid if (x != y) ..; else ..; 622669
Local variable 'column' could be declared final 704
Avoid if (x != y) ..; else ..; 718
Parameter 'column' is not assigned and could be declared final 725
Avoid really long methods. 742917
The method 'encodeHeaderRows' has a Modified Cyclomatic Complexity of 22. 742917
The method encodeHeaderRows() has an NPath complexity of 23193 742917
The method 'encodeHeaderRows' has a Standard Cyclomatic Complexity of 24. 742917
The method encodeHeaderRows() has an NCSS line count of 132 742917
The method 'encodeHeaderRows' has a Cyclomatic Complexity of 28. 742917
Avoid if (x != y) ..; else ..; 778794
A switch statement does not contain a break 779791
String.indexOf(char) is faster than String.indexOf(String). 807
Prefer StringBuffer over += for concatenating strings 823
Prefer StringBuffer over += for concatenating strings 825
Prefer StringBuffer over += for concatenating strings 842
These nested if statements could be combined 900902
Parameter 'isHeader' is not assigned and could be declared final 933
Local variable 'column' could be declared final 937
The method encodeLink() has an NPath complexity of 200 9891026
Parameter 'target' is not assigned and could be declared final 991
Parameter 'icon' is not assigned and could be declared final 991
Parameter 'liClass' is not assigned and could be declared final 991
Avoid if (x != y) ..; else ..; 10191023
The method 'encodeDirectPagingLinks' has a Standard Cyclomatic Complexity of 20. 10411114
The method 'encodeDirectPagingLinks' has a Modified Cyclomatic Complexity of 20. 10411114
The method encodeDirectPagingLinks() has an NPath complexity of 648000 10411114
The method 'encodeDirectPagingLinks' has a Cyclomatic Complexity of 23. 10411114
Avoid unused local variables such as 'command'. 1045
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 1086
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 1105
Parameter 'sheet' is not assigned and could be declared final 1138
Local variable 'reloadBehavior' could be declared final 1139
Parameter 'holder' is not assigned and could be declared final 1160

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/StyleRenderer.java

Violation Line
Parameter 'event' is not assigned and could be declared final 44

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SubviewRenderer.java

Violation Line
Document empty method 4547

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SuggestRenderer.java

Violation Line
The class 'SuggestRenderer' has a Cyclomatic Complexity of 8 (Highest = 11). 49163
Parameter 'component' is not assigned and could be declared final 54
Parameter 'facesContext' is not assigned and could be declared final 54
Parameter 'facesContext' is not assigned and could be declared final 74
Parameter 'component' is not assigned and could be declared final 74
The method 'encodeBegin' has a Cyclomatic Complexity of 11. 74133
Avoid if (x != y) ..; else ..; 82106
Avoid if (x != y) ..; else ..; 116120
Avoid instantiating new objects inside loops 147

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TabGroupRenderer.java

Violation Line
Possible God class (WMC=53, ATFD=103, TCC=0.0) 20338
A high number of imports can indicate a high degree of coupling within an object. 20338
The class 'TabGroupRenderer' has a Modified Cyclomatic Complexity of 6 (Highest = 17). 69338
The class 'TabGroupRenderer' has a Cyclomatic Complexity of 8 (Highest = 20). 69338
The class 'TabGroupRenderer' has a Standard Cyclomatic Complexity of 7 (Highest = 17). 69338
Parameter 'event' is not assigned and could be declared final 76
A switch statement does not contain a break 86110
Avoid instantiating new objects inside loops 93
Avoid instantiating new objects inside loops 101
The method 'ensureRenderedActiveIndex' has a Cyclomatic Complexity of 10. 171205
The method 'ensureRenderedActiveIndex' has a Modified Cyclomatic Complexity of 10. 171205
The method 'ensureRenderedActiveIndex' has a Standard Cyclomatic Complexity of 10. 171205
Deeply nested if..then statements are hard to read 182184
Avoid if (x != y) ..; else ..; 199203
The method 'encodeHeader' has a Modified Cyclomatic Complexity of 17. 207301
The method 'encodeHeader' has a Standard Cyclomatic Complexity of 17. 207301
The method 'encodeHeader' has a Cyclomatic Complexity of 20. 207301
The method encodeHeader() has an NPath complexity of 38886 207301
Avoid instantiating new objects inside loops 222
Local variable 'image' could be declared final 270
Avoid if (x != y) ..; else ..; 278282
Parameter 'writer' is not assigned and could be declared final 304
Parameter 'tabGroup' is not assigned and could be declared final 304
Parameter 'facesContext' is not assigned and could be declared final 304
Parameter 'switchType' is not assigned and could be declared final 305
Parameter 'activeIndex' is not assigned and could be declared final 305
Parameter 'facesContext' is not assigned and could be declared final 335
Parameter 'tab' is not assigned and could be declared final 335

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TextareaRenderer.java

Violation Line
The class 'TextareaRenderer' has a Modified Cyclomatic Complexity of 7 (Highest = 12). 45132
The class 'TextareaRenderer' has a Standard Cyclomatic Complexity of 7 (Highest = 12). 45132
The class 'TextareaRenderer' has a Cyclomatic Complexity of 8 (Highest = 13). 45132
The method 'encodeBeginField' has a Modified Cyclomatic Complexity of 12. 50125
The method 'encodeBeginField' has a Standard Cyclomatic Complexity of 12. 50125
The method encodeBeginField() has an NPath complexity of 624 50125
The method 'encodeBeginField' has a Cyclomatic Complexity of 13. 50125
Prefer StringBuffer over += for concatenating strings 117
Prefer StringBuffer over += for concatenating strings 119
Prefer StringBuffer over += for concatenating strings 121
Parameter 'facesContext' is not assigned and could be declared final 128
Parameter 'component' is not assigned and could be declared final 128

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TobagoClientBehaviorRenderer.java

Violation Line
Parameter 'behaviorContext' is not assigned and could be declared final 53
Parameter 'behavior' is not assigned and could be declared final 53
Local variable 'ajaxBehavior' could be declared final 69
Avoid if (x != y) ..; else ..; 7680
Prefer StringBuffer over += for concatenating strings 77
Local variable 'command' could be declared final 82
Local variable 'event' could be declared final 91
Local variable 'child' could be declared final 121
Local variable 'event' could be declared final 123
Parameter 'component' is not assigned and could be declared final 133
Parameter 'behavior' is not assigned and could be declared final 133
Parameter 'context' is not assigned and could be declared final 133
Local variable 'ajaxBehavior' could be declared final 134
Parameter 'ajaxBehavior' is not assigned and could be declared final 142
Parameter 'component' is not assigned and could be declared final 142
Local variable 'event' could be declared final 144
Local variable 'isImmediate' could be declared final 145
Parameter 'component' is not assigned and could be declared final 150
Parameter 'ajaxBehavior' is not assigned and could be declared final 150
Parameter 'component' is not assigned and could be declared final 166
Parameter 'facesContext' is not assigned and could be declared final 166
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 174

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TreeIconRenderer.java

Violation Line
Local variable 'value' could be declared final 56
Local variable 'closed' could be declared final 57
Local variable 'open' could be declared final 58

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TreeIndentRenderer.java

Violation Line
Avoid unused method parameters such as 'facesContext'. 82
Avoid unused method parameters such as 'node'. 82
Avoid unused local variables such as 'junction'. 92
Avoid long parameter lists. 108111
Avoid unused method parameters such as 'facesContext'. 109
Avoid unused method parameters such as 'node'. 109
Avoid unused method parameters such as 'showLines'. 110
Avoid unused local variables such as 'hasNextSibling'. 116

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TreeLabelRenderer.java

Violation Line
Avoid unused private fields such as 'LOG'. 42

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TreeListboxRenderer.java

Violation Line
The method encodeEnd() has an NPath complexity of 250 53141
Avoid if (x != y) ..; else ..; 100
Avoid if (x != y) ..; else ..; 101103
Avoid if (x != y) ..; else ..; 164173
Avoid if (x != y) ..; else ..; 168172

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TreeNodeRenderer.java

Violation Line
The class 'TreeNodeRenderer' has a Cyclomatic Complexity of 6 (Highest = 11). 51222
Avoid unused local variables such as 'expanded'. 76
Deeply nested if..then statements are hard to read 8991
Avoid if (x != y) ..; else ..; 97107
Avoid unused local variables such as 'markedValue'. 99
The method 'encodeBegin' has a Cyclomatic Complexity of 11. 112169
The method encodeBegin() has an NPath complexity of 217 112169
Avoid unused method parameters such as 'expanded'. 196
Avoid unused method parameters such as 'facesContext'. 196
Avoid unused method parameters such as 'writer'. 196
Avoid unused method parameters such as 'node'. 197
Parameter 'level' is not assigned and could be declared final 214
Parameter 'data' is not assigned and could be declared final 214
Parameter 'showRoot' is not assigned and could be declared final 214

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TreeRenderer.java

Violation Line
The class 'TreeRenderer' has a Cyclomatic Complexity of 4 (Highest = 10). 46159
The method encodeEnd() has an NPath complexity of 500 74158
The method 'encodeEnd' has a Cyclomatic Complexity of 10. 74158
Avoid declaring a variable if it is unreferenced before a possible exit point. 78
Avoid appending characters as strings in StringBuffer.append. 117
Avoid appending characters as strings in StringBuffer.append. 122

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TreeSelectRenderer.java

Violation Line
The class 'TreeSelectRenderer' has a Cyclomatic Complexity of 5 (Highest = 10). 47158
Avoid declaring a variable if it is unreferenced before a possible exit point. 56
The method 'encodeBegin' has a Cyclomatic Complexity of 10. 83148
Do not add empty strings 152
Do not add empty strings 152
Document empty method 156157

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/VerbatimRenderer.java

Violation Line
Avoid declaring a variable if it is unreferenced before a possible exit point. 37

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/InTagDeclaration.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 2095

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/MessagesTagDeclaration.java

Violation Line
The String literal "boolean" appears 4 times in this file; the first occurrence is on line 54 54

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/SegmentLayoutTagDeclaration.java

Violation Line
The String literal "org.apache.myfaces.tobago.layout.ColumnPartition" appears 4 times in this file; the first occurrence is on line 51 51

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/SheetTagDeclaration.java

Violation Line
The String literal "boolean" appears 4 times in this file; the first occurrence is on line 82 82

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/StyleTagDeclaration.java

Violation Line
The String literal "org.apache.myfaces.tobago.layout.Measure" appears 18 times in this file; the first occurrence is on line 71 71

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/SuggestTagDeclaration.java

Violation Line
The String literal "java.lang.Integer" appears 4 times in this file; the first occurrence is on line 88 88

Tobago Core - org/apache/myfaces/tobago/internal/util/AccessKeyLogger.java

Violation Line
Parameter 'clientId' is not assigned and could be declared final 55
Local variable 'entry' could be declared final 76

Tobago Core - org/apache/myfaces/tobago/internal/util/ArrayUtils.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2234

Tobago Core - org/apache/myfaces/tobago/internal/util/AuthorizationHelper.java

Violation Line
The class 'AuthorizationHelper' has a Cyclomatic Complexity of 5 (Highest = 13). 47228
The class 'AuthorizationHelper' has a Modified Cyclomatic Complexity of 5 (Highest = 12). 47228
The class 'AuthorizationHelper' has a Standard Cyclomatic Complexity of 5 (Highest = 13). 47228
The method 'isAuthorized' has a Cyclomatic Complexity of 10. 97130
The method 'isAuthorized' has a Standard Cyclomatic Complexity of 10. 97130
The method 'isAuthorized' has a Modified Cyclomatic Complexity of 10. 97130
The method 'getSecurityAnnotation' has a Standard Cyclomatic Complexity of 13. 132192
Parameter 'expression' is not assigned and could be declared final 132
The method 'getSecurityAnnotation' has a Cyclomatic Complexity of 13. 132192
The method 'getSecurityAnnotation' has a Modified Cyclomatic Complexity of 12. 132192
Avoid if (x != y) ..; else ..; 148159
Local variable 'entry' could be declared final 149
A switch statement does not contain a break 164174
Parameter 'name' is not assigned and could be declared final 210
Parameter 'bean' is not assigned and could be declared final 210
Local variable 'method' could be declared final 220

Tobago Core - org/apache/myfaces/tobago/internal/util/CookieUtils.java

Violation Line
The class 'CookieUtils' has a Cyclomatic Complexity of 6 (Highest = 11). 29116
The class 'CookieUtils' has a Standard Cyclomatic Complexity of 6 (Highest = 11). 29116
The class 'CookieUtils' has a Modified Cyclomatic Complexity of 6 (Highest = 11). 29116
A class which only has private constructors should be final 29116
Parameter 'request' is not assigned and could be declared final 40
Local variable 'cookie' could be declared final 43
The method 'setThemeNameToCookie' has a Cyclomatic Complexity of 11. 6099
The method 'setThemeNameToCookie' has a Standard Cyclomatic Complexity of 11. 6099
The method 'setThemeNameToCookie' has a Modified Cyclomatic Complexity of 11. 6099
Parameter 'request' is not assigned and could be declared final 61
Parameter 'response' is not assigned and could be declared final 61
Parameter 'themeName' is not assigned and could be declared final 61
Prefer StringBuffer over += for concatenating strings 64
Local variable 'cookie' could be declared final 67
Deeply nested if..then statements are hard to read 7779
Deeply nested if..then statements are hard to read 8385
Local variable 'cookie' could be declared final 94

Tobago Core - org/apache/myfaces/tobago/internal/util/Deprecation.java

Violation Line
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 49

Tobago Core - org/apache/myfaces/tobago/internal/util/FastStringWriter.java

Violation Line
StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 27

Tobago Core - org/apache/myfaces/tobago/internal/util/HtmlRendererUtils.java

Violation Line
Possible God class (WMC=51, ATFD=49, TCC=0.0) 20272
The class 'HtmlRendererUtils' has a Modified Cyclomatic Complexity of 3 (Highest = 16). 51272
The class 'HtmlRendererUtils' has a Cyclomatic Complexity of 4 (Highest = 20). 51272
The class 'HtmlRendererUtils' has a Standard Cyclomatic Complexity of 3 (Highest = 16). 51272
Avoid unused private fields such as 'ERROR_FOCUS_KEY'. 54
Parameter 'writer' is not assigned and could be declared final 95
Parameter 'image' is not assigned and could be declared final 95
Parameter 'label' is not assigned and could be declared final 95
Parameter 'label' is not assigned and could be declared final 107
Parameter 'disabled' is not assigned and could be declared final 107
Parameter 'writer' is not assigned and could be declared final 107
Parameter 'image' is not assigned and could be declared final 107
Parameter 'facesContext' is not assigned and could be declared final 107
Avoid reassigning parameters such as 'title' 145
Avoid reassigning parameters such as 'title' 145
Avoid reassigning parameters such as 'title' 145
Avoid if (x != y) ..; else ..; 175
Avoid if (x != y) ..; else ..; 176
The method 'renderSelectItems' has a Standard Cyclomatic Complexity of 16. 179249
The method 'renderSelectItems' has a Modified Cyclomatic Complexity of 16. 179249
The method 'renderSelectItems' has a Cyclomatic Complexity of 20. 179249
The method renderSelectItems() has an NPath complexity of 9006 179249
Avoid instantiating new objects inside loops 229

Tobago Core - org/apache/myfaces/tobago/internal/util/HtmlWriterUtils.java

Violation Line
The class 'HtmlWriterUtils' has a Standard Cyclomatic Complexity of 7 (Highest = 10). 25124
The class 'HtmlWriterUtils' has a Modified Cyclomatic Complexity of 7 (Highest = 10). 25124
The class 'HtmlWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14). 25124
The method 'writeEncodedValue' has a Standard Cyclomatic Complexity of 10. 62123
The method 'writeEncodedValue' has a Cyclomatic Complexity of 14. 62123
The method 'writeEncodedValue' has a Modified Cyclomatic Complexity of 10. 62123
Avoid if (x != y) ..; else ..; 9599

Tobago Core - org/apache/myfaces/tobago/internal/util/HttpPartWrapper.java

Violation Line
Document empty constructor 3637
Parameter 'delegate' is not assigned and could be declared final 39
Parameter 'headerName' is not assigned and could be declared final 54
Parameter 'headerName' is not assigned and could be declared final 64
Parameter 'fileName' is not assigned and could be declared final 84
Local variable 'wrapped' could be declared final 89
Local variable 'm' could be declared final 91
Parameter 'context' is not assigned and could be declared final 107
Document empty method 112113
Parameter 'state' is not assigned and could be declared final 112
Parameter 'context' is not assigned and could be declared final 112
Parameter 'newTransientValue' is not assigned and could be declared final 121
Document empty method 121122

Tobago Core - org/apache/myfaces/tobago/internal/util/JQueryUtils.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2232
Parameter 'id' is not assigned and could be declared final 24
Parameter 'id' is not assigned and could be declared final 28

Tobago Core - org/apache/myfaces/tobago/internal/util/JavascriptWriterUtils.java

Violation Line
The class 'JavascriptWriterUtils' has a Standard Cyclomatic Complexity of 7 (Highest = 10). 25120
The class 'JavascriptWriterUtils' has a Modified Cyclomatic Complexity of 7 (Highest = 10). 25120
The class 'JavascriptWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14). 25120
The method 'writeEncodedValue' has a Cyclomatic Complexity of 14. 58119
The method 'writeEncodedValue' has a Modified Cyclomatic Complexity of 10. 58119
The method 'writeEncodedValue' has a Standard Cyclomatic Complexity of 10. 58119
Avoid if (x != y) ..; else ..; 9195

Tobago Core - org/apache/myfaces/tobago/internal/util/JndiUtils.java

Violation Line
Prefer StringBuffer over += for concatenating strings 57

Tobago Core - org/apache/myfaces/tobago/internal/util/JsonUtils.java

Violation Line
Possible God class (WMC=51, ATFD=26, TCC=0.0) 20297
This class has too many methods, consider refactoring it. 40297
A class which only has private constructors should be final 40297
The class 'JsonUtils' has a Standard Cyclomatic Complexity of 3 (Highest = 12). 40297
The class 'JsonUtils' has a Cyclomatic Complexity of 4 (Highest = 14). 40297
The class 'JsonUtils' has a Modified Cyclomatic Complexity of 3 (Highest = 12). 40297
Consider using varargs for methods or constructors which take an array the last parameter. 47
Avoid appending characters as strings in StringBuffer.append. 48
Avoid appending characters as strings in StringBuffer.append. 52
Parameter 'builder' is not assigned and could be declared final 55
Consider using varargs for methods or constructors which take an array the last parameter. 55
Parameter 'value' is not assigned and could be declared final 55
Avoid appending characters as strings in StringBuffer.append. 56
Avoid appending characters as strings in StringBuffer.append. 60
Avoid appending characters as strings in StringBuffer.append. 62
Avoid appending characters as strings in StringBuffer.append. 64
Avoid appending characters as strings in StringBuffer.append. 67
Parameter 'value' is not assigned and could be declared final 70
Parameter 'builder' is not assigned and could be declared final 70
Avoid appending characters as strings in StringBuffer.append. 71
Avoid appending characters as strings in StringBuffer.append. 75
Avoid appending characters as strings in StringBuffer.append. 80
Avoid appending characters as strings in StringBuffer.append. 84
Avoid appending characters as strings in StringBuffer.append. 88
Avoid appending characters as strings in StringBuffer.append. 92
Avoid appending characters as strings in StringBuffer.append. 96
Avoid reassigning parameters such as 'value' 99
Avoid appending characters as strings in StringBuffer.append. 101
Avoid appending characters as strings in StringBuffer.append. 115
Avoid appending characters as strings in StringBuffer.append. 135
The method encode() has an NPath complexity of 4608 139192
The method 'encode' has a Cyclomatic Complexity of 14. 139192
The method 'encode' has a Modified Cyclomatic Complexity of 12. 139192
The method 'encode' has a Standard Cyclomatic Complexity of 12. 139192
Avoid appending characters as strings in StringBuffer.append. 140
Avoid appending characters as strings in StringBuffer.append. 195
Avoid appending characters as strings in StringBuffer.append. 218
Avoid appending characters as strings in StringBuffer.append. 232
Consider using varargs for methods or constructors which take an array the last parameter. 236
Avoid appending characters as strings in StringBuffer.append. 255
Avoid appending characters as strings in StringBuffer.append. 274
Avoid reassigning parameters such as 'json' 277
Avoid reassigning parameters such as 'json' 277

Tobago Core - org/apache/myfaces/tobago/internal/util/JsonWriterUtils.java

Violation Line
The class 'JsonWriterUtils' has a Standard Cyclomatic Complexity of 7 (Highest = 10). 26125
The class 'JsonWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14). 26125
The class 'JsonWriterUtils' has a Modified Cyclomatic Complexity of 7 (Highest = 10). 26125
The method 'writeEncodedValue' has a Modified Cyclomatic Complexity of 10. 63124
The method 'writeEncodedValue' has a Standard Cyclomatic Complexity of 10. 63124
The method 'writeEncodedValue' has a Cyclomatic Complexity of 14. 63124
Avoid if (x != y) ..; else ..; 96100

Tobago Core - org/apache/myfaces/tobago/internal/util/MimeTypeUtils.java

Violation Line
The class 'MimeTypeUtils' has a Modified Cyclomatic Complexity of 8 (Highest = 21). 27106
The class 'MimeTypeUtils' has a Standard Cyclomatic Complexity of 8 (Highest = 21). 27106
The class 'MimeTypeUtils' has a Cyclomatic Complexity of 8 (Highest = 21). 27106
Avoid using redundant field initializer for 'additionalMimeTypes' 29
The method 'getMimeTypeForFile' has a Cyclomatic Complexity of 21. 3696
The method 'getMimeTypeForFile' has a Standard Cyclomatic Complexity of 21. 3696
The method 'getMimeTypeForFile' has a Modified Cyclomatic Complexity of 21. 3696
The method getMimeTypeForFile() has an NPath complexity of 290 3696
Local variable 'length' could be declared final 37
These nested if statements could be combined 8486
Local variable 'extension' could be declared final 91
Parameter 'servletContext' is not assigned and could be declared final 98
Singleton is not thread safe 99104

Tobago Core - org/apache/myfaces/tobago/internal/util/NumberUtils.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2234

Tobago Core - org/apache/myfaces/tobago/internal/util/ObjectUtils.java

Violation Line
A class which only has private constructors should be final 2232
Parameter 'o2' is not assigned and could be declared final 29
Parameter 'o1' is not assigned and could be declared final 29
Use equals() to compare object references. 30

Tobago Core - org/apache/myfaces/tobago/internal/util/PartUtils.java

Violation Line
Parameter 'part' is not assigned and could be declared final 45
Local variable 'cd' could be declared final 54
Local variable 'cdl' could be declared final 56
Local variable 'paramParser' could be declared final 58
Local variable 'params' could be declared final 6162
Deeply nested if..then statements are hard to read 6574
Avoid if (x != y) ..; else ..; 6574
The class 'ParameterParser' has a Cyclomatic Complexity of 4 (Highest = 10). 81330
Avoid using redundant field initializer for 'chars' 86
Avoid using redundant field initializer for 'pos' 91
Avoid using redundant field initializer for 'len' 96
Avoid using redundant field initializer for 'i1' 101
Avoid using redundant field initializer for 'i2' 106
Avoid using redundant field initializer for 'lowerCaseNames' 111
The method 'getToken' has a Cyclomatic Complexity of 10. 139161
Parameter 'quoted' is not assigned and could be declared final 139
Parameter 'ch' is not assigned and could be declared final 171
Consider using varargs for methods or constructors which take an array the last parameter. 171
Local variable 'element' could be declared final 173
Consider using varargs for methods or constructors which take an array the last parameter. 190
Consider using varargs for methods or constructors which take an array the last parameter. 214
Parameter 'b' is not assigned and could be declared final 244
Parameter 'separator' is not assigned and could be declared final 256
Parameter 'separator' is not assigned and could be declared final 272
The method 'parse' has a Cyclomatic Complexity of 10. 290329
Parameter 'offset' is not assigned and could be declared final 292
Parameter 'length' is not assigned and could be declared final 293
Parameter 'separator' is not assigned and could be declared final 294
Local variable 'params' could be declared final 299
Avoid instantiating new objects inside loops 307309
Avoid instantiating new objects inside loops 313315

Tobago Core - org/apache/myfaces/tobago/internal/util/RenderUtils.java

Violation Line
Possible God class (WMC=63, ATFD=48, TCC=0.0) 20304
The class 'RenderUtils' has a Modified Cyclomatic Complexity of 5 (Highest = 11). 52304
The class 'RenderUtils' has a Cyclomatic Complexity of 5 (Highest = 11). 52304
The class 'RenderUtils' has a Standard Cyclomatic Complexity of 5 (Highest = 11). 52304
The method 'decodedStateOfTreeData' has a Modified Cyclomatic Complexity of 11. 136187
The method 'decodedStateOfTreeData' has a Standard Cyclomatic Complexity of 11. 136187
The method 'decodedStateOfTreeData' has a Cyclomatic Complexity of 11. 136187
The method decodedStateOfTreeData() has an NPath complexity of 330 136187
This call to String.startsWith can be rewritten using String.charAt(0) 214
Avoid appending characters as strings in StringBuffer.append. 228
Avoid appending characters as strings in StringBuffer.append. 231
Avoid appending characters as strings in StringBuffer.append. 234
Local variable 'behaviorMap' could be declared final 255
Local variable 'clientBehavior' could be declared final 259
Avoid unused local variables such as 'dummy'. 263
Local variable 'clientBehavior' could be declared final 295

Tobago Core - org/apache/myfaces/tobago/internal/util/ResponseUtils.java

Violation Line
The class 'ResponseUtils' has a Cyclomatic Complexity of 3 (Highest = 10). 33145
Avoid if (x != y) ..; else ..; 7283
The method 'ensureContentSecurityPolicyHeader' has a Cyclomatic Complexity of 10. 97132
Avoid declaring a variable if it is unreferenced before a possible exit point. 101
Avoid appending characters as strings in StringBuffer.append. 120
These nested if statements could be combined 128130

Tobago Core - org/apache/myfaces/tobago/internal/util/ResponseWriterBuffer.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 62

Tobago Core - org/apache/myfaces/tobago/internal/util/SelectItemUtils.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 45282
Avoid instantiation through private constructors from outside of the constructors class. 61
Local variable 'selectItem' could be declared final 80
The class 'SelectItemsIterator' has a Cyclomatic Complexity of 9 (Highest = 21). 87280
The class 'SelectItemsIterator' has a Standard Cyclomatic Complexity of 8 (Highest = 19). 87280
The class 'SelectItemsIterator' has a Modified Cyclomatic Complexity of 8 (Highest = 19). 87280
The method 'hasNext' has a Cyclomatic Complexity of 21. 102194
The method hasNext() has an NPath complexity of 864 102194
The method 'hasNext' has a Modified Cyclomatic Complexity of 19. 102194
The method 'hasNext' has a Standard Cyclomatic Complexity of 19. 102194
Local variable 'tobagoSelectItem' could be declared final 148149
Local variable 'expression' could be declared final 155
Local variable 'entry' could be declared final 186
Avoid instantiating new objects inside loops 187
The method 'next' has a Modified Cyclomatic Complexity of 12. 197274
The method 'next' has a Cyclomatic Complexity of 13. 197274
The method next() has an NPath complexity of 584 197274
The method 'next' has a Standard Cyclomatic Complexity of 12. 197274
Avoid unused local variables such as 'attributeMap'. 213
Avoid if (x != y) ..; else ..; 264268

Tobago Core - org/apache/myfaces/tobago/internal/util/StringUtils.java

Violation Line
Possible God class (WMC=128, ATFD=12, TCC=0.0) 20581
This class has too many methods, consider refactoring it. 27581
The class 'StringUtils' has a Modified Cyclomatic Complexity of 4 (Highest = 18). 27581
The class 'StringUtils' has a Standard Cyclomatic Complexity of 4 (Highest = 18). 27581
The class 'StringUtils' has a Cyclomatic Complexity of 4 (Highest = 18). 27581
Avoid instantiating new objects inside loops 45
Avoid instantiating Integer objects. Call Integer.valueOf() instead. 45
Avoid appending characters as strings in StringBuffer.append. 57
The method 'equalsIgnoreCaseAndWhitespace' has a Standard Cyclomatic Complexity of 11. 125179
The method 'equalsIgnoreCaseAndWhitespace' has a Modified Cyclomatic Complexity of 11. 125179
The method 'equalsIgnoreCaseAndWhitespace' has a Cyclomatic Complexity of 14. 125179
The method equalsIgnoreCaseAndWhitespace() has an NPath complexity of 378 125179
Use equals() to compare object references. 128
The method 'split' has a Modified Cyclomatic Complexity of 18. 233308
The method 'split' has a Standard Cyclomatic Complexity of 18. 233308
The method 'split' has a Cyclomatic Complexity of 18. 233308
Avoid declaring a variable if it is unreferenced before a possible exit point. 234
The method replace() has an NPath complexity of 1080 369394
The method 'replace' has a Cyclomatic Complexity of 10. 369394
Avoid declaring a variable if it is unreferenced before a possible exit point. 370
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 383
No need to call String.valueOf to append to a string. 425
Parameter 'a' is not assigned and could be declared final 475
Parameter 'b' is not assigned and could be declared final 475
Local variable 'colon' could be declared final 486
Parameter 'string' is not assigned and could be declared final 498
Parameter 'prefix' is not assigned and could be declared final 498
Parameter 'searchChars' is not assigned and could be declared final 534
The method 'containsAny' has a Cyclomatic Complexity of 11. 534566
Parameter 'str' is not assigned and could be declared final 534
Local variable 'searchChars1' could be declared final 538
Local variable 'csLength' could be declared final 542
Local variable 'searchLength' could be declared final 543
Local variable 'csLast' could be declared final 544
Local variable 'searchLast' could be declared final 545
Local variable 'ch' could be declared final 547
Parameter 'ch' is not assigned and could be declared final 577

Tobago Core - org/apache/myfaces/tobago/internal/webapp/DebugContentTypeFilter.java

Violation Line
Document empty method 6163

Tobago Core - org/apache/myfaces/tobago/internal/webapp/DebugContentTypeResponse.java

Violation Line
These nested if statements could be combined 5557
These nested if statements could be combined 6567

Tobago Core - org/apache/myfaces/tobago/internal/webapp/DebugResponseWriterWrapper.java

Violation Line
This class has too many methods, consider refactoring it. 37228
Private field 'stack' could be made final; it is only initialized in the declaration or constructor. 39
Parameter 'string' is not assigned and could be declared final 100
Parameter 'name' is not assigned and could be declared final 100

Tobago Core - org/apache/myfaces/tobago/internal/webapp/HtmlResponseWriter.java

Violation Line
This class has too many methods, consider refactoring it. 35166
Private field 'javascriptWriter' could be made final; it is only initialized in the declaration or constructor. 40
Document empty method 164165

Tobago Core - org/apache/myfaces/tobago/internal/webapp/LoggingMdcFilter.java

Violation Line
Local variable 'httpRequest' could be declared final 52
Local variable 'session' could be declared final 53
Local variable 'remoteAddr' could be declared final 57
Local variable 'remoteUser' could be declared final 61
Document empty method 7577

Tobago Core - org/apache/myfaces/tobago/internal/webapp/TobagoResponseWriterBase.java

Violation Line
Possible God class (WMC=64, ATFD=16, TCC=0.1339031339031339) 20369
This class has too many methods, consider refactoring it. 36368
Avoid using redundant field initializer for 'i' 44
Avoid using redundant field initializer for 'inlineStack' 46
Avoid if (x != y) ..; else ..; 63
Avoid if (x != y) ..; else ..; 88111
Avoid if (x != y) ..; else ..; 90111
Avoid if (x != y) ..; else ..; 91104
Avoid if (x != y) ..; else ..; 9397
Consider using varargs for methods or constructors which take an array the last parameter. 137
An empty method in an abstract class should be abstract instead 173175
An empty method in an abstract class should be abstract instead 178180

Tobago Core - org/apache/myfaces/tobago/internal/webapp/TobagoResponseWriterWrapper.java

Violation Line
This class has too many methods, consider refactoring it. 32150
Private field 'responseWriter' could be made final; it is only initialized in the declaration or constructor. 34
Parameter 'name' is not assigned and could be declared final 46
Parameter 'name' is not assigned and could be declared final 56
Parameter 'name' is not assigned and could be declared final 132
Parameter 'string' is not assigned and could be declared final 132

Tobago Core - org/apache/myfaces/tobago/internal/webapp/XmlResponseWriter.java

Violation Line
Avoid unused private fields such as 'XHTML_DOCTYPE'. 31

Tobago Core - org/apache/myfaces/tobago/layout/ColumnPartition.java

Violation Line
Parameter 'parts' is not assigned and could be declared final 43
Parameter 'string' is not assigned and could be declared final 47
Parameter 'object' is not assigned and could be declared final 52
Avoid if (x != y) ..; else ..; 5761
Consider using varargs for methods or constructors which take an array the last parameter. 64
Local variable 'summand' could be declared final 69
Parameter 'summands' is not assigned and could be declared final 81
Consider using varargs for methods or constructors which take an array the last parameter. 81
Parameter 'summands' is not assigned and could be declared final 85
Local variable 'list' could be declared final 86
Avoid declaring a variable if it is unreferenced before a possible exit point. 86
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 87
Parameter 'parts' is not assigned and could be declared final 111
Consider using varargs for methods or constructors which take an array the last parameter. 111

Tobago Core - org/apache/myfaces/tobago/layout/LayoutTokens.java

Violation Line
Private field 'tokens' could be made final; it is only initialized in the declaration or constructor. 35
Document empty constructor 3738
Consider using varargs for methods or constructors which take an array the last parameter. 69
Avoid appending characters as strings in StringBuffer.append. 141

Tobago Core - org/apache/myfaces/tobago/layout/Measure.java

Violation Line
Parameter 'unit' is not assigned and could be declared final 45
Parameter 'i' is not assigned and could be declared final 45
Parameter 'd' is not assigned and could be declared final 51
Parameter 'unit' is not assigned and could be declared final 51
Parameter 'unit' is not assigned and could be declared final 57
Parameter 'string' is not assigned and could be declared final 57
Avoid if (x != y) ..; else ..; 130
Do not add empty strings 130
Avoid if (x != y) ..; else ..; 130
Parameter 'o' is not assigned and could be declared final 138
Local variable 'measure' could be declared final 146
Avoid if (x != y) ..; else ..; 148
Avoid if (x != y) ..; else ..; 151
Avoid if (x != y) ..; else ..; 160
Avoid if (x != y) ..; else ..; 161

Tobago Core - org/apache/myfaces/tobago/layout/PixelMeasure.java

Violation Line
Avoid instantiating new objects inside loops 35
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 39

Tobago Core - org/apache/myfaces/tobago/layout/RelativeLayoutToken.java

Violation Line
Private field 'factor' could be made final; it is only initialized in the declaration or constructor. 29

Tobago Core - org/apache/myfaces/tobago/lifecycle/SecretPhaseListener.java

Violation Line
Document empty method 5152

Tobago Core - org/apache/myfaces/tobago/model/CalendarModel.java

Violation Line
Private field 'calendarArray' could be made final; it is only initialized in the declaration or constructor. 28
Private field 'firstDayOffset' could be made final; it is only initialized in the declaration or constructor. 29
Avoid instantiating new objects inside loops 43
Avoid appending characters as strings in StringBuffer.append. 77
When instantiating a SimpleDateFormat object, specify a Locale 80
Avoid appending characters as strings in StringBuffer.append. 84
Avoid appending characters as strings in StringBuffer.append. 86
Avoid appending characters as strings in StringBuffer.append. 90
Avoid appending characters as strings in StringBuffer.append. 92

Tobago Core - org/apache/myfaces/tobago/model/DateModel.java

Violation Line
Avoid if (x != y) ..; else ..; 7273

Tobago Core - org/apache/myfaces/tobago/model/ExpandedState.java

Violation Line
This class has too many methods, consider refactoring it. 34251
Private field 'expandedSet' could be made final; it is only initialized in the declaration or constructor. 37
Private field 'collapsedSet' could be made final; it is only initialized in the declaration or constructor. 38
Avoid reassigning parameters such as 'level' 187

Tobago Core - org/apache/myfaces/tobago/model/ScrollPosition.java

Violation Line
Avoid if (x != y) ..; else ..; 36
Avoid if (x != y) ..; else ..; 36
String.indexOf(char) is faster than String.indexOf(String). 49
Parameter 'left' is not assigned and could be declared final 63
Parameter 'top' is not assigned and could be declared final 71

Tobago Core - org/apache/myfaces/tobago/model/SelectItem.java

Violation Line
Parameter 'tip' is not assigned and could be declared final 84
Parameter 'style' is not assigned and could be declared final 112
Parameter 'customClass' is not assigned and could be declared final 122

Tobago Core - org/apache/myfaces/tobago/model/SelectedState.java

Violation Line
Private field 'selected' could be made final; it is only initialized in the declaration or constructor. 32

Tobago Core - org/apache/myfaces/tobago/model/SheetState.java

Violation Line
Avoid unused private fields such as 'LOG'. 36
Overridable method 'reset' called during object construction 51
Avoid if (x != y) ..; else ..; 6771
Local variable 'columnWidth' could be declared final 118
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 123
Parameter 'toBeSorted' is not assigned and could be declared final 181

Tobago Core - org/apache/myfaces/tobago/model/SuggestFilter.java

Violation Line
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 40

Tobago Core - org/apache/myfaces/tobago/model/TreeNodeDataModel.java

Violation Line
Possible God class (WMC=57, ATFD=27, TCC=0.10666666666666667) 20305
Private field 'mapping' could be made final; it is only initialized in the declaration or constructor. 43
Private field 'back' could be made final; it is only initialized in the declaration or constructor. 44
Private field 'showRoot' could be made final; it is only initialized in the declaration or constructor. 45
Overridable method 'reset' called during object construction 59
Avoid instantiation through private constructors from outside of the constructors class. 69
Avoid instantiating new objects inside loops 69
Avoid instantiation through private constructors from outside of the constructors class. 89
Avoid instantiating new objects inside loops 89
Avoid reassigning parameters such as 'node' 103
Avoid instantiating new objects inside loops 209
Avoid if (x != y) ..; else ..; 239243
Private field 'node' could be made final; it is only initialized in the declaration or constructor. 286

Tobago Core - org/apache/myfaces/tobago/model/TreePath.java

Violation Line
Avoid reassigning parameters such as 'node' 69
Avoid if (x != y) ..; else ..; 125

Tobago Core - org/apache/myfaces/tobago/renderkit/RendererBase.java

Violation Line
Avoid if (x != y) ..; else ..; 6670
Document empty method 7475

Tobago Core - org/apache/myfaces/tobago/renderkit/TobagoRenderKit.java

Violation Line
Private field 'renderers' could be made final; it is only initialized in the declaration or constructor. 52
Local variable 'rkFactory' could be declared final 55
Avoid instantiation through private constructors from outside of the constructors class. 66
Avoid instantiation through private constructors from outside of the constructors class. 118
Parameter 'renderer' is not assigned and could be declared final 132
Parameter 'type' is not assigned and could be declared final 132
Parameter 'type' is not assigned and could be declared final 137

Tobago Core - org/apache/myfaces/tobago/renderkit/css/BootstrapClass.java

Violation Line
Avoid using redundant field initializer for 'index' 241
Local variable 'result' could be declared final 265
Consider using varargs for methods or constructors which take an array the last parameter. 274

Tobago Core - org/apache/myfaces/tobago/renderkit/css/Classes.java

Violation Line
Avoid unused private fields such as 'CACHE'. 67
Use block level rather than method level synchronization 89116
Avoid if (x != y) ..; else ..; 122
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 123
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 133

Tobago Core - org/apache/myfaces/tobago/renderkit/css/CustomClass.java

Violation Line
A class which only has private constructors should be final 3487
Parameter 'list' is not assigned and could be declared final 42
Parameter 'text' is not assigned and could be declared final 46
Avoid if (x != y) ..; else ..; 5458
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 63

Tobago Core - org/apache/myfaces/tobago/renderkit/css/FontAwesomeIconEncoder.java

Violation Line
Private field 'icons' could be made final; it is only initialized in the declaration or constructor. 40
Local variable 'icon' could be declared final 45
Avoid instantiating new objects inside loops 46
Local variable 'result' could be declared final 63
Private field 'name' could be made final; it is only initialized in the declaration or constructor. 90
Parameter 'name' is not assigned and could be declared final 92

Tobago Core - org/apache/myfaces/tobago/renderkit/css/Style.java

Violation Line
Possible God class (WMC=113, ATFD=23, TCC=0.2970356926799758) 20679
This class has a bunch of public methods and attributes 20679
The class 'Style' has a Standard Cyclomatic Complexity of 2 (Highest = 28). 34679
The class 'Style' has a Cyclomatic Complexity of 2 (Highest = 28). 34679
The class 'Style' has a Modified Cyclomatic Complexity of 2 (Highest = 28). 34679
Too many fields 34679
Document empty constructor 7374
Overridable method 'checkEmptiness' called during object construction 111
The method 'encode' has a Cyclomatic Complexity of 27. 166300
The method encode() has an NPath complexity of 67108864 166300
The method 'encode' has a Standard Cyclomatic Complexity of 27. 166300
Avoid really long methods. 166300
The method 'encode' has a Modified Cyclomatic Complexity of 27. 166300
The method encode() has an NCSS line count of 107 166300
StringBuffer constructor is initialized with size 16, but has at least 26 characters appended. 167
The method 'encodeJson' has a Cyclomatic Complexity of 28. 302441
The method encodeJson() has an NCSS line count of 110 302441
The method encodeJson() has an NPath complexity of 134217728 302441
The method 'encodeJson' has a Modified Cyclomatic Complexity of 28. 302441
Avoid really long methods. 302441
The method 'encodeJson' has a Standard Cyclomatic Complexity of 28. 302441
StringBuffer constructor is initialized with size 17, but has at least 78 characters appended. 303
The String literal "\"," appears 25 times in this file; the first occurrence is on line 307 307
Avoid appending characters as strings in StringBuffer.append. 427
Parameter 'minWidth' is not assigned and could be declared final 465
Parameter 'minHeight' is not assigned and could be declared final 474
Parameter 'maxWidth' is not assigned and could be declared final 483
Parameter 'maxHeight' is not assigned and could be declared final 492
Parameter 'right' is not assigned and could be declared final 510
Parameter 'bottom' is not assigned and could be declared final 528
Parameter 'backgroundImage' is not assigned and could be declared final 645
Parameter 'backgroundPosition' is not assigned and could be declared final 653

Tobago Core - org/apache/myfaces/tobago/renderkit/css/TobagoClass.java

Violation Line
Parameter 'alignItems' is not assigned and could be declared final 101
Parameter 'justifyContent' is not assigned and could be declared final 123

Tobago Core - org/apache/myfaces/tobago/renderkit/html/DataAttributes.java

Violation Line
Parameter 'value' is not assigned and could be declared final 206

Tobago Core - org/apache/myfaces/tobago/renderkit/html/HtmlAttributes.java

Violation Line
Parameter 'value' is not assigned and could be declared final 131

Tobago Core - org/apache/myfaces/tobago/renderkit/html/HtmlButtonTypes.java

Violation Line
Parameter 'value' is not assigned and could be declared final 30

Tobago Core - org/apache/myfaces/tobago/renderkit/html/HtmlInputTypes.java

Violation Line
Parameter 'value' is not assigned and could be declared final 37

Tobago Core - org/apache/myfaces/tobago/sanitizer/IgnoringSanitizer.java

Violation Line
Parameter 'html' is not assigned and could be declared final 35
Parameter 'configuration' is not assigned and could be declared final 40

Tobago Core - org/apache/myfaces/tobago/sanitizer/JsoupSanitizer.java

Violation Line
Avoid using redundant field initializer for 'unmodifiable' 39

Tobago Core - org/apache/myfaces/tobago/servlet/NonFacesRequestServlet.java

Violation Line
Avoid declaring a variable if it is unreferenced before a possible exit point. 61
An empty method in an abstract class should be abstract instead 9597

Tobago Core - org/apache/myfaces/tobago/servlet/ResourceServlet.java

Violation Line
Avoid instantiating Long objects.Call Long.valueOf() instead 88
Local variable 'resource' could be declared final 111
Avoid if (x != y) ..; else ..; 118128
Avoid if (x != y) ..; else ..; 142148
Avoid if (x != y) ..; else ..; 156160

Tobago Core - org/apache/myfaces/tobago/util/AjaxUtils.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3277
Local variable 'renderId' could be declared final 62
Parameter 'outcome' is not assigned and could be declared final 71
Parameter 'facesContext' is not assigned and could be declared final 71
Local variable 'navigationHandler' could be declared final 73

Tobago Core - org/apache/myfaces/tobago/util/BeanComparator.java

Violation Line
Private field 'property' could be made final; it is only initialized in the declaration or constructor. 35
Avoid if (x != y) ..; else ..; 69

Tobago Core - org/apache/myfaces/tobago/util/ComparatorBase.java

Violation Line
The class 'ComparatorBase' has a Cyclomatic Complexity of 3 (Highest = 14). 27126
The class 'ComparatorBase' has a Standard Cyclomatic Complexity of 3 (Highest = 12). 27126
The class 'ComparatorBase' has a Modified Cyclomatic Complexity of 3 (Highest = 12). 27126
Document empty constructor 3334
The method 'internalCompare' has a Modified Cyclomatic Complexity of 12. 4989
The method internalCompare() has an NPath complexity of 1600 4989
The method 'internalCompare' has a Standard Cyclomatic Complexity of 12. 4989
The method 'internalCompare' has a Cyclomatic Complexity of 14. 4989
Avoid if (x != y) ..; else ..; 7787
Avoid if (x != y) ..; else ..; 120

Tobago Core - org/apache/myfaces/tobago/util/ComponentUtils.java

Violation Line
Possible God class (WMC=189, ATFD=116, TCC=8.163265306122449E-4) 20859
This class has a bunch of public methods and attributes 20859
A high number of imports can indicate a high degree of coupling within an object. 20859
The class 'ComponentUtils' has a Standard Cyclomatic Complexity of 3 (Highest = 10). 68859
This class has too many methods, consider refactoring it. 68859
The class 'ComponentUtils' has a Cyclomatic Complexity of 3 (Highest = 10). 68859
The class 'ComponentUtils' has a Modified Cyclomatic Complexity of 3 (Highest = 10). 68859
Avoid reassigning parameters such as 'component' 120
Avoid if (x != y) ..; else ..; 143147
Avoid if (x != y) ..; else ..; 152162
Avoid reassigning parameters such as 'component' 165
Avoid reassigning parameters such as 'component' 199
Avoid reassigning parameters such as 'component' 209
Avoid if (x != y) ..; else ..; 267275
Avoid reassigning parameters such as 'component' 380
Local variable 'bool' could be declared final 436
Avoid if (x != y) ..; else ..; 453
Consider simply returning the value vs storing it in local variable 'myRenderer' 555
The method 'findComponent' has a Cyclomatic Complexity of 10. 594629
These nested if statements could be combined 599601
Position literals first in String comparisons 599
Consider using varargs for methods or constructors which take an array the last parameter. 635
The method 'getConvertedValue' has a Modified Cyclomatic Complexity of 10. 677708
The method 'getConvertedValue' has a Cyclomatic Complexity of 10. 677708
The method 'getConvertedValue' has a Standard Cyclomatic Complexity of 10. 677708
Avoid if (x != y) ..; else ..; 681703
Avoid reassigning parameters such as 'markup' 710
Avoid reassigning parameters such as 'markup' 710
Avoid reassigning parameters such as 'markup' 710
Avoid reassigning parameters such as 'markup' 710
Avoid reassigning parameters such as 'markup' 710
Local variable 'map' could be declared final 800
Avoid if (x != y) ..; else ..; 801
Avoid if (x != y) ..; else ..; 842846

Tobago Core - org/apache/myfaces/tobago/util/CreateComponentUtils.java

Violation Line
Class cannot be instantiated and does not provide any static methods or fields 2227

Tobago Core - org/apache/myfaces/tobago/util/DebugNavigationHandler.java

Violation Line
Private field 'navigationHandler' could be made final; it is only initialized in the declaration or constructor. 32

Tobago Core - org/apache/myfaces/tobago/util/DebugPhaseListener.java

Violation Line
The class 'DebugPhaseListener' has a Modified Cyclomatic Complexity of 8 (Highest = 13). 39157
The class 'DebugPhaseListener' has a Cyclomatic Complexity of 10 (Highest = 16). 39157
The class 'DebugPhaseListener' has a Standard Cyclomatic Complexity of 8 (Highest = 13). 39157
The method 'afterPhase' has a Modified Cyclomatic Complexity of 10. 4692
The method 'afterPhase' has a Cyclomatic Complexity of 11. 4692
The method 'afterPhase' has a Standard Cyclomatic Complexity of 10. 4692
Deeply nested if..then statements are hard to read 6873
Deeply nested if..then statements are hard to read 7678
The method 'beforePhase' has a Standard Cyclomatic Complexity of 13. 95151
The method beforePhase() has an NPath complexity of 572 95151
The method 'beforePhase' has a Modified Cyclomatic Complexity of 13. 95151
The method 'beforePhase' has a Cyclomatic Complexity of 16. 95151
Avoid declaring a variable if it is unreferenced before a possible exit point. 97
Deeply nested if..then statements are hard to read 113129
Deeply nested if..then statements are hard to read 135145
Deeply nested if..then statements are hard to read 146148

Tobago Core - org/apache/myfaces/tobago/util/DebugUtils.java

Violation Line
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 59
Avoid appending characters as strings in StringBuffer.append. 82
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 82
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 83
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 84
Avoid appending characters as strings in StringBuffer.append. 84
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 92
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 93

Tobago Core - org/apache/myfaces/tobago/util/MessageFormat.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2776
Parameter 'pattern' is not assigned and could be declared final 29
Parameter 'param0' is not assigned and could be declared final 29
Parameter 'param1' is not assigned and could be declared final 33
Parameter 'param0' is not assigned and could be declared final 33
Parameter 'pattern' is not assigned and could be declared final 33
Parameter 'param1' is not assigned and could be declared final 37
Parameter 'param2' is not assigned and could be declared final 37
Parameter 'pattern' is not assigned and could be declared final 37
Parameter 'param0' is not assigned and could be declared final 37
Parameter 'param2' is not assigned and could be declared final 41
Parameter 'param0' is not assigned and could be declared final 41
Parameter 'param1' is not assigned and could be declared final 41
Parameter 'pattern' is not assigned and could be declared final 41
Parameter 'param3' is not assigned and could be declared final 41
Parameter 'param1' is not assigned and could be declared final 45
Parameter 'param2' is not assigned and could be declared final 45
Parameter 'param0' is not assigned and could be declared final 45
Parameter 'pattern' is not assigned and could be declared final 45
Parameter 'param3' is not assigned and could be declared final 45
Parameter 'param4' is not assigned and could be declared final 46
Parameter 'pattern' is not assigned and could be declared final 50
Parameter 'param3' is not assigned and could be declared final 50
Parameter 'param0' is not assigned and could be declared final 50
Parameter 'param2' is not assigned and could be declared final 50
Parameter 'param1' is not assigned and could be declared final 50
Parameter 'param4' is not assigned and could be declared final 51
Parameter 'param5' is not assigned and could be declared final 51
Parameter 'param3' is not assigned and could be declared final 55
Parameter 'param0' is not assigned and could be declared final 55
Parameter 'param1' is not assigned and could be declared final 55
Parameter 'param2' is not assigned and could be declared final 55
Parameter 'pattern' is not assigned and could be declared final 55
Parameter 'param6' is not assigned and could be declared final 56
Parameter 'param4' is not assigned and could be declared final 56
Parameter 'param5' is not assigned and could be declared final 56
Parameter 'param2' is not assigned and could be declared final 60
Parameter 'param3' is not assigned and could be declared final 60
Parameter 'param1' is not assigned and could be declared final 60
Parameter 'param0' is not assigned and could be declared final 60
Parameter 'pattern' is not assigned and could be declared final 60
Parameter 'param5' is not assigned and could be declared final 61
Parameter 'param4' is not assigned and could be declared final 61
Parameter 'param7' is not assigned and could be declared final 61
Parameter 'param6' is not assigned and could be declared final 61
Parameter 'param2' is not assigned and could be declared final 66
Parameter 'param0' is not assigned and could be declared final 66
Parameter 'param3' is not assigned and could be declared final 66
Parameter 'param1' is not assigned and could be declared final 66
Parameter 'pattern' is not assigned and could be declared final 66
Avoid long parameter lists. 6667
Parameter 'param4' is not assigned and could be declared final 67
Parameter 'param6' is not assigned and could be declared final 67
Parameter 'param7' is not assigned and could be declared final 67
Parameter 'param5' is not assigned and could be declared final 67
Parameter 'param8' is not assigned and could be declared final 67
Parameter 'pattern' is not assigned and could be declared final 72

Tobago Core - org/apache/myfaces/tobago/util/MessageUtils.java

Violation Line
The class 'MessageUtils' has a Standard Cyclomatic Complexity of 3 (Highest = 11). 43148
The class 'MessageUtils' has a Cyclomatic Complexity of 4 (Highest = 15). 43148
The class 'MessageUtils' has a Modified Cyclomatic Complexity of 3 (Highest = 11). 43148
Consider using varargs for methods or constructors which take an array the last parameter. 52
The method 'getMessage' has a Modified Cyclomatic Complexity of 11. 57104
The method 'getMessage' has a Cyclomatic Complexity of 15. 57104
The method 'getMessage' has a Standard Cyclomatic Complexity of 11. 57104
The method getMessage() has an NPath complexity of 468 57104
Deeply nested if..then statements are hard to read 7678
Deeply nested if..then statements are hard to read 7981
Avoid if (x != y) ..; else ..; 116

Tobago Core - org/apache/myfaces/tobago/util/ValueBindingComparator.java

Violation Line
The class 'ValueBindingComparator' has a Modified Cyclomatic Complexity of 3 (Highest = 10). 34131
The class 'ValueBindingComparator' has a Standard Cyclomatic Complexity of 3 (Highest = 10). 34131
The class 'ValueBindingComparator' has a Cyclomatic Complexity of 3 (Highest = 11). 34131
Private field 'facesContext' could be made final; it is only initialized in the declaration or constructor. 38
Private field 'var' could be made final; it is only initialized in the declaration or constructor. 40
Private field 'valueBinding' could be made final; it is only initialized in the declaration or constructor. 42
The method 'equals' has a Cyclomatic Complexity of 11. 76100
The method 'equals' has a Standard Cyclomatic Complexity of 10. 76100
The method 'equals' has a Modified Cyclomatic Complexity of 10. 76100
Avoid declaring a variable if it is unreferenced before a possible exit point. 84
Avoid if (x != y) ..; else ..; 89
Avoid if (x != y) ..; else ..; 92
Avoid if (x != y) ..; else ..; 95
Avoid if (x != y) ..; else ..; 104
Avoid if (x != y) ..; else ..; 105
Avoid if (x != y) ..; else ..; 106

Tobago Core - org/apache/myfaces/tobago/util/ValueExpressionComparator.java

Violation Line
The class 'ValueExpressionComparator' has a Cyclomatic Complexity of 3 (Highest = 11). 30128
The class 'ValueExpressionComparator' has a Standard Cyclomatic Complexity of 3 (Highest = 10). 30128
The class 'ValueExpressionComparator' has a Modified Cyclomatic Complexity of 3 (Highest = 10). 30128
Private field 'facesContext' could be made final; it is only initialized in the declaration or constructor. 34
Private field 'var' could be made final; it is only initialized in the declaration or constructor. 36
Private field 'valueExpression' could be made final; it is only initialized in the declaration or constructor. 38
The method 'equals' has a Modified Cyclomatic Complexity of 10. 7498
The method 'equals' has a Cyclomatic Complexity of 11. 7498
The method 'equals' has a Standard Cyclomatic Complexity of 10. 7498
Avoid declaring a variable if it is unreferenced before a possible exit point. 82
Avoid if (x != y) ..; else ..; 87
Avoid if (x != y) ..; else ..; 90
Avoid if (x != y) ..; else ..; 93
Avoid if (x != y) ..; else ..; 102
Avoid if (x != y) ..; else ..; 103
Avoid if (x != y) ..; else ..; 104

Tobago Core - org/apache/myfaces/tobago/util/XmlUtils.java

Violation Line
A switch statement does not contain a break 74100

Tobago Core - org/apache/myfaces/tobago/validator/FileItemValidator.java

Violation Line
The class 'FileItemValidator' has a Cyclomatic Complexity of 2 (Highest = 12). 40132
Avoid using redundant field initializer for 'maxSize' 44
Document empty constructor 5152
The method 'validate' has a Cyclomatic Complexity of 12. 5588
Deeply nested if..then statements are hard to read 6972
Deeply nested if..then statements are hard to read 7680
Consider using varargs for methods or constructors which take an array the last parameter. 104

Tobago Core - org/apache/myfaces/tobago/validator/SubmittedValueLengthValidator.java

Violation Line
Document empty constructor 4445
Avoid if (x != y) ..; else ..; 58
Avoid if (x != y) ..; else ..; 70
Avoid if (x != y) ..; else ..; 128
Avoid if (x != y) ..; else ..; 131
Avoid if (x != y) ..; else ..; 140
Avoid if (x != y) ..; else ..; 141

Tobago Core - org/apache/myfaces/tobago/webapp/LogoutActionListener.java

Violation Line
New exception is thrown in catch block, original stack trace may be lost 59

Tobago Core - org/apache/myfaces/tobago/webapp/Secret.java

Violation Line
Private field 'secret' could be made final; it is only initialized in the declaration or constructor. 57
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 57
Local variable 'secret' could be declared final 85
Parameter 'session' is not assigned and could be declared final 89

Tobago Core - org/apache/myfaces/tobago/webapp/SecretSessionListener.java

Violation Line
Document empty method 3839

Tobago Core - org/apache/myfaces/tobago/webapp/TobagoResponseWriter.java

Violation Line
Possible God class (WMC=49, ATFD=18, TCC=0.0) 20317
This class has too many methods, consider refactoring it. 44317
Avoid unused private fields such as 'NO_CSS_ITEMS'. 46
Private field 'iconEncoder' could be made final; it is only initialized in the declaration or constructor. 48
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 157
Local variable 'other' could be declared final 211

Tobago Core - org/apache/myfaces/tobago/webapp/TobagoServletContextListener.java

Violation Line
StringBuffer constructor is initialized with size 16, but has at least 87 characters appended. 59
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 60
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 60
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 61
StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. 64

Tobago Example Blank - org/apache/myfaces/tobago/example/blank/Hello.java

Violation Line
Parameter 'name' is not assigned and could be declared final 47

Tobago Example Data - org/apache/myfaces/tobago/example/data/CantorInterval.java

Violation Line
Private field 'begin' could be made final; it is only initialized in the declaration or constructor. 33
Private field 'end' could be made final; it is only initialized in the declaration or constructor. 34
Avoid appending characters as strings in StringBuffer.append. 81
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 81
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 82
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 83
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 84
Avoid appending characters as strings in StringBuffer.append. 85
Avoid reassigning parameters such as 'numerator' 109
Avoid reassigning parameters such as 'denominator' 109
Avoid appending characters as strings in StringBuffer.append. 144

Tobago Example Data - org/apache/myfaces/tobago/example/data/CategoryTree.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2688
Avoid instantiating new objects inside loops 81

Tobago Example Data - org/apache/myfaces/tobago/example/data/CommandNode.java

Violation Line
Private field 'name' could be made final; it is only initialized in the declaration or constructor. 26
Parameter 'name' is not assigned and could be declared final 30
Parameter 'action' is not assigned and could be declared final 34
Parameter 'name' is not assigned and could be declared final 34
Parameter 'url' is not assigned and could be declared final 34

Tobago Example Data - org/apache/myfaces/tobago/example/data/CommandNodeFactory.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2240

Tobago Example Data - org/apache/myfaces/tobago/example/data/LocaleList.java

Violation Line
A class which only has private constructors should be final 3297
Avoid instantiating new objects inside loops 46

Tobago Example Data - org/apache/myfaces/tobago/example/data/MixedCommandTree.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2246

Tobago Example Data - org/apache/myfaces/tobago/example/data/NamedNode.java

Violation Line
Private field 'name' could be made final; it is only initialized in the declaration or constructor. 32

Tobago Example Data - org/apache/myfaces/tobago/example/data/SmallTree.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2434

Tobago Example Data - org/apache/myfaces/tobago/example/data/SolarObject.java

Violation Line
Overridable method 'getPopulation' called during object construction 85
Parameter 'event' is not assigned and could be declared final 93
The String literal "Sun" appears 13 times in this file; the first occurrence is on line 102 102
Position literals first in String comparisons 102
Position literals first in String comparisons 105
Avoid if (x != y) ..; else ..; 186
Position literals first in String comparisons 198
Avoid instantiating new objects inside loops 216
Position literals first in String comparisons 219
Parameter 'name' is not assigned and could be declared final 240
Local variable 'solarObject' could be declared final 241
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 250
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 251
The String literal "III" appears 5 times in this file; the first occurrence is on line 251 251
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 252
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 254343
The String literal "Jupiter" appears 28 times in this file; the first occurrence is on line 260 260
The String literal "Saturn" appears 19 times in this file; the first occurrence is on line 261 261
The String literal "Uranus" appears 22 times in this file; the first occurrence is on line 262 262
The String literal "Herschel" appears 5 times in this file; the first occurrence is on line 262 262
The String literal "VII" appears 5 times in this file; the first occurrence is on line 262 262
The String literal "Neptune" appears 9 times in this file; the first occurrence is on line 263 263
The String literal "VIII" appears 5 times in this file; the first occurrence is on line 263 263
The String literal "Galileo" appears 4 times in this file; the first occurrence is on line 272 272
The String literal "Sheppard" appears 11 times in this file; the first occurrence is on line 276 276
The String literal "Nicholson" appears 5 times in this file; the first occurrence is on line 279 279
The String literal "Cassini" appears 4 times in this file; the first occurrence is on line 303 303
The String literal "Voyager 2" appears 15 times in this file; the first occurrence is on line 313 313
Local variable 'sun' could be declared final 346349
Local variable 'earth' could be declared final 351355
Local variable 'moon' could be declared final 357361

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/CkeditorController.java

Violation Line
Private field 'contentSecurityPolicyMode' could be made final; it is only initialized in the declaration or constructor. 34
Parameter 'collapsed' is not assigned and could be declared final 74

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/CollapsibleBoxController.java

Violation Line
Avoid using redundant field initializer for 'collapsed' 30
Parameter 'collapsed' is not assigned and could be declared final 36

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/CollapsibleController.java

Violation Line
Parameter 'collapsed' is not assigned and could be declared final 57

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/CollapsiblePanelController.java

Violation Line
Avoid using redundant field initializer for 'panelCollapsed' 30
Parameter 'panelCollapsed' is not assigned and could be declared final 36

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/CollapsiblePopupController.java

Violation Line
Parameter 'collapsed' is not assigned and could be declared final 36

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/CollapsibleSectionController.java

Violation Line
Avoid using redundant field initializer for 'collapsed' 30
Parameter 'collapsed' is not assigned and could be declared final 36

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ConversionController.java

Violation Line
Parameter 'amount' is not assigned and could be declared final 36

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/CurrentValueController.java

Violation Line
Private field 'string' could be made final; it is only initialized in the declaration or constructor. 38
Private field 'currency' could be made final; it is only initialized in the declaration or constructor. 40
When instantiating a SimpleDateFormat object, specify a Locale 47
Avoid if (x != y) ..; else ..; 56
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 56
Parameter 'string' is not assigned and could be declared final 69

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/DateController.java

Violation Line
When instantiating a SimpleDateFormat object, specify a Locale 44
Local variable 'sdf' could be declared final 44
Parameter 'once' is not assigned and could be declared final 56
Parameter 'onchange' is not assigned and could be declared final 64
Parameter 'submitDate' is not assigned and could be declared final 76

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/DefaultCommandController.java

Violation Line
Parameter 'value1' is not assigned and could be declared final 40
Parameter 'value2' is not assigned and could be declared final 48
Parameter 'value3' is not assigned and could be declared final 56

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/DemoBundle.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2942

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/DemoController.java

Violation Line
Private field 'currencyItems' could be made final; it is only initialized in the declaration or constructor. 63
Local variable 'label' could be declared final 111
Do not add empty strings 113
Avoid instantiating new objects inside loops 115
Consider using varargs for methods or constructors which take an array the last parameter. 120
Local variable 'label' could be declared final 123
Do not add empty strings 125
Avoid instantiating new objects inside loops 127
Avoid if (x != y) ..; else ..; 139143
Consider using varargs for methods or constructors which take an array the last parameter. 210

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/EventController.java

Violation Line
Private field 'eventsOnComponents' could be made final; it is only initialized in the declaration or constructor. 49
Avoid using redundant field initializer for 'action' 51
Avoid using redundant field initializer for 'actionListener' 52
Avoid using redundant field initializer for 'ajaxListener' 53
Avoid using redundant field initializer for 'valueChangeListener' 54
Private field 'planets' could be made final; it is only initialized in the declaration or constructor. 55
The String literal "Sun" appears 8 times in this file; the first occurrence is on line 65 65
Parameter 'selectedComponent' is not assigned and could be declared final 91
Avoid if (x != y) ..; else ..; 97
Parameter 'selectedPlanet' is not assigned and could be declared final 144
Avoid if (x != y) ..; else ..; 150
Private field 'tagName' could be made final; it is only initialized in the declaration or constructor. 154
Private field 'eventNames' could be made final; it is only initialized in the declaration or constructor. 155
Parameter 'tagName' is not assigned and could be declared final 157
Parameter 'eventNames' is not assigned and could be declared final 157
Parameter 'commonEvents' is not assigned and could be declared final 197
Local variable 'commonEvent' could be declared final 201
Local variable 'specialEventNames' could be declared final 219
Local variable 'eventName' could be declared final 221
Local variable 'commonEvent' could be declared final 223
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 234
Parameter 'strings' is not assigned and could be declared final 237
Local variable 'stringBuilder' could be declared final 238
Local variable 'string' could be declared final 241

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ExceptionController.java

Violation Line
Local variable 'exception' could be declared final 3435
Local variable 'stringWriter' could be declared final 36
Local variable 'printWriter' could be declared final 37

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ExecuteController.java

Violation Line
Parameter 'value1' is not assigned and could be declared final 73
Parameter 'value2' is not assigned and could be declared final 81
Parameter 'value3' is not assigned and could be declared final 89
Parameter 'value4' is not assigned and could be declared final 97

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ForEachController.java

Violation Line
Overridable method 'reset' called during object construction 39
Parameter 'name' is not assigned and could be declared final 50
Parameter 'length' is not assigned and could be declared final 58
Parameter 'discharge' is not assigned and could be declared final 66
Private field 'name' could be made final; it is only initialized in the declaration or constructor. 92
Private field 'length' could be made final; it is only initialized in the declaration or constructor. 93
Private field 'discharge' could be made final; it is only initialized in the declaration or constructor. 94
Parameter 'length' is not assigned and could be declared final 96
Parameter 'name' is not assigned and could be declared final 96
Parameter 'discharge' is not assigned and could be declared final 96

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/FormAjaxController.java

Violation Line
Parameter 'outerValue' is not assigned and could be declared final 38
Parameter 'innerValue1' is not assigned and could be declared final 46
Parameter 'innerValue2' is not assigned and could be declared final 54

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/FormController.java

Violation Line
Avoid unused private fields such as 'LOG'. 33
Parameter 'value1' is not assigned and could be declared final 42
Parameter 'value2' is not assigned and could be declared final 50

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/FormRequiredController.java

Violation Line
Parameter 'outerValue' is not assigned and could be declared final 38
Parameter 'innerValue1' is not assigned and could be declared final 46
Parameter 'innerValue2' is not assigned and could be declared final 54

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/GroupController.java

Violation Line
Parameter 'newMessage' is not assigned and could be declared final 70
Parameter 'sendTo' is not assigned and could be declared final 83
Parameter 'event' is not assigned and could be declared final 87
Local variable 'command' could be declared final 92
Parameter 'event' is not assigned and could be declared final 98
Parameter 'value' is not assigned and could be declared final 122
Parameter 'currency' is not assigned and could be declared final 134

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/InController.java

Violation Line
Parameter 'event' is not assigned and could be declared final 37
Parameter 'changeValue' is not assigned and could be declared final 45

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/InputSuggestController.java

Violation Line
Private field 'suggestData' could be made final; it is only initialized in the declaration or constructor. 51
The String literal "Niedersachsen" appears 6 times in this file; the first occurrence is on line 52 52
Avoid instantiating new objects inside loops 158
Avoid instantiating new objects inside loops 161
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 170
Avoid instantiating new objects inside loops 171
Avoid instantiating new objects inside loops 174

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/Login.java

Violation Line
Parameter 'username' is not assigned and could be declared final 85
Parameter 'password' is not assigned and could be declared final 93

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ManifestReader.java

Violation Line
Avoid instantiating new objects inside loops 60
Avoid instantiating new objects inside loops 63
Avoid instantiating new objects inside loops 66

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/NavigationNode.java

Violation Line
Private field 'tree' could be made final; it is only initialized in the declaration or constructor. 40
Avoid unused local variables such as 'extension'. 55

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/NavigationState.java

Violation Line
Private field 'state' could be made final; it is only initialized in the declaration or constructor. 47
Avoid if (x != y) ..; else ..; 7782
Avoid if (x != y) ..; else ..; 9196
Parameter 'viewSource' is not assigned and could be declared final 140

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/NavigationTree.java

Violation Line
Avoid instantiating new objects inside loops 81
Position literals first in String comparisons 99
Parameter 'viewId' is not assigned and could be declared final 131
Avoid if (x != y) ..; else ..; 147151

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/PanelController.java

Violation Line
Parameter 'text' is not assigned and could be declared final 41

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/PartialReloadController.java

Violation Line
Parameter 'event' is not assigned and could be declared final 77
Do not add empty strings 117

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/PlanetExample.java

Violation Line
This abstract class does not have any abstract methods 2476
Private field 'planets' could be made final; it is only initialized in the declaration or constructor. 26
Private field 'earthMoons' could be made final; it is only initialized in the declaration or constructor. 27
Private field 'marsMoons' could be made final; it is only initialized in the declaration or constructor. 28
Private field 'jupiterMoons' could be made final; it is only initialized in the declaration or constructor. 29
Parameter 'planet' is not assigned and could be declared final 60

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/PopupController.java

Violation Line
Parameter 'popup1Collapsed' is not assigned and could be declared final 39
Parameter 'popup1Text' is not assigned and could be declared final 55
Parameter 'popup2Text' is not assigned and could be declared final 63

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/PrettyUrlForMenuNavigationHandler.java

Violation Line
Private field 'navigationHandler' could be made final; it is only initialized in the declaration or constructor. 35
Parameter 'outcome' is not assigned and could be declared final 42

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ProgressController.java

Violation Line
Avoid unused private fields such as 'LOG'. 37
Private field 'progress' could be made final; it is only initialized in the declaration or constructor. 39
Local variable 'value' could be declared final 46
Local variable 'sdf' could be declared final 64
When instantiating a SimpleDateFormat object, specify a Locale 64
When instantiating a SimpleDateFormat object, specify a Locale 69
Local variable 'sdf' could be declared final 69
When instantiating a SimpleDateFormat object, specify a Locale 74
Local variable 'sdf' could be declared final 74

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/RoleController.java

Violation Line
Parameter 'text' is not assigned and could be declared final 38

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SelectBooleanCheckboxController.java

Violation Line
Parameter 'a' is not assigned and could be declared final 41
Parameter 'b' is not assigned and could be declared final 49
Parameter 'c' is not assigned and could be declared final 57
Parameter 'd' is not assigned and could be declared final 65
Parameter 'e' is not assigned and could be declared final 73
Parameter 'f' is not assigned and could be declared final 81

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SelectController.java

Violation Line
Private field 'entries' could be made final; it is only initialized in the declaration or constructor. 32

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SelectItemModel.java

Violation Line
Avoid instantiating new objects inside loops 51
Parameter 'currency2' is not assigned and could be declared final 83

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SelectManyCheckboxController.java

Violation Line
Parameter 'animals' is not assigned and could be declared final 39
Local variable 's' could be declared final 45
Parameter 'numbers' is not assigned and could be declared final 55
Local variable 'number' could be declared final 61

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SelectManyListboxController.java

Violation Line
Private field 'deserts' could be made final; it is only initialized in the declaration or constructor. 35
Parameter 'celestials' is not assigned and could be declared final 52
Local variable 's' could be declared final 58
Parameter 'selectedDeserts' is not assigned and could be declared final 72

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SelectManyShuttleController.java

Violation Line
Private field 'planets' could be made final; it is only initialized in the declaration or constructor. 35
Private field 'stars' could be made final; it is only initialized in the declaration or constructor. 37
Parameter 'selectedPlanets' is not assigned and could be declared final 52
Consider using varargs for methods or constructors which take an array the last parameter. 52
Parameter 'selectedStars' is not assigned and could be declared final 68
Consider using varargs for methods or constructors which take an array the last parameter. 68

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SelectOneChoiceController.java

Violation Line
Parameter 'person' is not assigned and could be declared final 36

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SelectOneListboxController.java

Violation Line
Private field 'mountains' could be made final; it is only initialized in the declaration or constructor. 33
Parameter 'river' is not assigned and could be declared final 50
Parameter 'mountain' is not assigned and could be declared final 62

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SelectOneRadioController.java

Violation Line
Parameter 'numberOne' is not assigned and could be declared final 38
Parameter 'numberTwo' is not assigned and could be declared final 46

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ServerInfo.java

Violation Line
Private field 'version' could be made final; it is only initialized in the declaration or constructor. 54
Private field 'enabled' could be made final; it is only initialized in the declaration or constructor. 59
Local variable 'tokenizer' could be declared final 113
Local variable 'major' could be declared final 114
Local variable 'minor' could be declared final 115
Local variable 'fix' could be declared final 116

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SheetConfig.java

Violation Line
Private field 'sheetDirectLinkCountItems' could be made final; it is only initialized in the declaration or constructor. 39
Private field 'sheetPagingPositionItems' could be made final; it is only initialized in the declaration or constructor. 40
Local variable 'selectable' could be declared final 59
Consider using varargs for methods or constructors which take an array the last parameter. 75
Avoid instantiating new objects inside loops 79
Consider using varargs for methods or constructors which take an array the last parameter. 174
Parameter 'showDirectLinksArrows' is not assigned and could be declared final 190
Parameter 'showPageRangeArrows' is not assigned and could be declared final 198

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SheetController.java

Violation Line
Private field 'solarList' could be made final; it is only initialized in the declaration or constructor. 49
Private field 'hugeSolarList' could be made final; it is only initialized in the declaration or constructor. 50
Local variable 'solarObject' could be declared final 62
Local variable 'solarObjectClone' could be declared final 63
Avoid instantiating new objects inside loops 63
Parameter 'sheetState' is not assigned and could be declared final 82
Avoid if (x != y) ..; else ..; 8995
Parameter 'automaticLayout' is not assigned and could be declared final 118
Parameter 'markup' is not assigned and could be declared final 126
Parameter 'columnEventSample' is not assigned and could be declared final 130
Parameter 'facesContext' is not assigned and could be declared final 143
Parameter 'value' is not assigned and could be declared final 143
Parameter 'uiComponent' is not assigned and could be declared final 143
Parameter 'facesContext' is not assigned and could be declared final 151
Parameter 'uiComponent' is not assigned and could be declared final 151
Parameter 'value' is not assigned and could be declared final 151

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SheetFilterController.java

Violation Line
Possible God class (WMC=49, ATFD=28, TCC=0.04666666666666667) 20285
The class 'SheetFilterController' has a Cyclomatic Complexity of 2 (Highest = 16). 43285
The class 'SheetFilterController' has a Modified Cyclomatic Complexity of 2 (Highest = 10). 43285
The class 'SheetFilterController' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 43285
Private field 'filteredSolarList' could be made final; it is only initialized in the declaration or constructor. 47
Private field 'distanceItems' could be made final; it is only initialized in the declaration or constructor. 49
Private field 'minYearItems' could be made final; it is only initialized in the declaration or constructor. 50
Private field 'maxYearItems' could be made final; it is only initialized in the declaration or constructor. 51
Private field 'distanceRangeConverter' could be made final; it is only initialized in the declaration or constructor. 53
Local variable 'years' could be declared final 74
Local variable 'solarObject' could be declared final 75
Local variable 'year' could be declared final 85
Local variable 'selectItem' could be declared final 86
Avoid instantiating new objects inside loops 86
Overridable method 'filter' called during object construction 96
The method filter() has an NPath complexity of 1088 99133
The method 'filter' has a Cyclomatic Complexity of 16. 99133
The method 'filter' has a Modified Cyclomatic Complexity of 10. 99133
The method 'filter' has a Standard Cyclomatic Complexity of 10. 99133
Parameter 'event' is not assigned and could be declared final 135
Parameter 'name' is not assigned and could be declared final 163
Parameter 'orbit' is not assigned and could be declared final 171
Parameter 'distance' is not assigned and could be declared final 179
Parameter 'discoverer' is not assigned and could be declared final 187
Parameter 'minYear' is not assigned and could be declared final 195
Parameter 'maxYear' is not assigned and could be declared final 203
Private field 'min' could be made final; it is only initialized in the declaration or constructor. 209
Private field 'max' could be made final; it is only initialized in the declaration or constructor. 210
Parameter 'max' is not assigned and could be declared final 213
Parameter 'min' is not assigned and could be declared final 213
No need to call String.valueOf to append to a string. 216
No need to call String.valueOf to append to a string. 216
Parameter 'max' is not assigned and could be declared final 219
Parameter 'min' is not assigned and could be declared final 219
Parameter 'label' is not assigned and could be declared final 219
Local variable 'distanceItem' could be declared final 260
Local variable 'distanceItem' could be declared final 276

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SheetSortingController.java

Violation Line
The class 'SheetSortingController' has a Modified Cyclomatic Complexity of 6 (Highest = 10). 4093
The class 'SheetSortingController' has a Standard Cyclomatic Complexity of 6 (Highest = 10). 4093
The class 'SheetSortingController' has a Cyclomatic Complexity of 6 (Highest = 10). 4093
The method 'sheetSorter' has a Standard Cyclomatic Complexity of 10. 5492
The method 'sheetSorter' has a Cyclomatic Complexity of 10. 5492
The method 'sheetSorter' has a Modified Cyclomatic Complexity of 10. 5492
Local variable 'period1' could be declared final 72
Local variable 'period2' could be declared final 73
Local variable 'discoverYear1' could be declared final 81
Avoid if (x != y) ..; else ..; 81
Avoid if (x != y) ..; else ..; 82
Local variable 'discoverYear2' could be declared final 82

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SheetTreeController.java

Violation Line
Private field 'solarTree' could be made final; it is only initialized in the declaration or constructor. 33

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SourceFileReader.java

Violation Line
This abstract class does not have any abstract methods 3151
Parameter 'filename' is not assigned and could be declared final 35
String.indexOf(char) is faster than String.indexOf(String). 39

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SuggestController.java

Violation Line
Parameter 'query' is not assigned and could be declared final 45
Avoid if (x != y) ..; else ..; 50

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/TabController.java

Violation Line
Avoid unused private fields such as 'LOG'. 35
Private field 'open' could be made final; it is only initialized in the declaration or constructor. 37
Private field 'close' could be made final; it is only initialized in the declaration or constructor. 38
Parameter 'index' is not assigned and could be declared final 46
Avoid if (x != y) ..; else ..; 5155
Avoid if (x != y) ..; else ..; 5963
Avoid if (x != y) ..; else ..; 6771

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/TestExceptionHandler.java

Violation Line
Private field 'wrapped' could be made final; it is only initialized in the declaration or constructor. 35
Avoid instantiating new objects inside loops 59

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/TestExceptionHandlerFactory.java

Violation Line
Private field 'parent' could be made final; it is only initialized in the declaration or constructor. 27

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/TextareaController.java

Violation Line
Parameter 'longText' is not assigned and could be declared final 54

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ThemeController.java

Violation Line
Avoid instantiating new objects inside loops 49
Parameter 'theme' is not assigned and could be declared final 57
Parameter 'themeItems' is not assigned and could be declared final 65
Consider using varargs for methods or constructors which take an array the last parameter. 65

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/TreeCommandTypesController.java

Violation Line
Private field 'sample' could be made final; it is only initialized in the declaration or constructor. 33
Avoid using redundant field initializer for 'actionOneCount' 34
Avoid using redundant field initializer for 'actionTwoCount' 35
Parameter 'name' is not assigned and could be declared final 49

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/TreeController.java

Violation Line
Private field 'sample' could be made final; it is only initialized in the declaration or constructor. 33
Avoid using redundant field initializer for 'treeShowRoot' 34
Avoid using redundant field initializer for 'treeShowRootJunction' 35
Parameter 'treeShowRoot' is not assigned and could be declared final 51
Parameter 'treeShowRootJunction' is not assigned and could be declared final 59
Parameter 'treeIndentRendered' is not assigned and could be declared final 67
Parameter 'treeIndentShowJunction' is not assigned and could be declared final 75

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/TreeEditorController.java

Violation Line
This class has too many methods, consider refactoring it. 37217
Parameter 'name' is not assigned and could be declared final 59
Avoid if (x != y) ..; else ..; 6570
Avoid if (x != y) ..; else ..; 7685
Avoid if (x != y) ..; else ..; 7782
Parameter 'node' is not assigned and could be declared final 113
Local variable 'nodeName' could be declared final 114
Local variable 'resultNode' could be declared final 115
Local variable 'children' could be declared final 117
Avoid if (x != y) ..; else ..; 128140
Parameter 'base' is not assigned and could be declared final 144
Parameter 'selected' is not assigned and could be declared final 144
Local variable 'children' could be declared final 148
Parameter 'node' is not assigned and could be declared final 160
Local variable 'children' could be declared final 163
Local variable 'previousSibling' could be declared final 173
Avoid if (x != y) ..; else ..; 174180
Local variable 'parent' could be declared final 175
Local variable 'nextSibling' could be declared final 188
Avoid if (x != y) ..; else ..; 189195
Local variable 'parent' could be declared final 190

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/TreeSelectController.java

Violation Line
Private field 'sample' could be made final; it is only initialized in the declaration or constructor. 34
Parameter 'selectable' is not assigned and could be declared final 49
Local variable 'stringBuilder' could be declared final 54
Parameter 'stringBuilder' is not assigned and could be declared final 63
Parameter 'node' is not assigned and could be declared final 63
Local variable 'userObject' could be declared final 64
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 66
Local variable 'child' could be declared final 69

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/UniversalLoggingInfo.java

Violation Line
Private field 'jul' could be made final; it is only initialized in the declaration or constructor. 46
Private field 'slf4j' could be made final; it is only initialized in the declaration or constructor. 51
Private field 'log4j' could be made final; it is only initialized in the declaration or constructor. 53
Private field 'log4j2' could be made final; it is only initialized in the declaration or constructor. 55
Private field 'commonsLogging' could be made final; it is only initialized in the declaration or constructor. 57
The String literal "getLogger" appears 4 times in this file; the first occurrence is on line 62 62
The String literal "info" appears 5 times in this file; the first occurrence is on line 67 67
The String literal "trace" appears 4 times in this file; the first occurrence is on line 71 71
The String literal "debug" appears 4 times in this file; the first occurrence is on line 72 72
The String literal "warn" appears 4 times in this file; the first occurrence is on line 74 74
The String literal "error" appears 4 times in this file; the first occurrence is on line 75 75
Overridable method 'update' called during object construction 97
Parameter 'testCategory' is not assigned and could be declared final 133
Avoid if (x != y) ..; else ..; 134138
Private field 'id' could be made final; it is only initialized in the declaration or constructor. 143
Private field 'calls' could be made final; it is only initialized in the declaration or constructor. 145
Private field 'factoryClassName' could be made final; it is only initialized in the declaration or constructor. 147
Private field 'factoryMethod' could be made final; it is only initialized in the declaration or constructor. 148
Private field 'usesString' could be made final; it is only initialized in the declaration or constructor. 149
Parameter 'factoryMethod' is not assigned and could be declared final 151
Parameter 'factoryClassName' is not assigned and could be declared final 151
Parameter 'id' is not assigned and could be declared final 151
Parameter 'category' is not assigned and could be declared final 152
Parameter 'usesString' is not assigned and could be declared final 152
Parameter 'calls' is not assigned and could be declared final 152
Local variable 'call' could be declared final 162
A method/constructor shouldnt explicitly throw java.lang.Exception 171
Parameter 'id' is not assigned and could be declared final 171
Parameter 'logger' is not assigned and could be declared final 171
Parameter 'name' is not assigned and could be declared final 171
Parameter 'category' is not assigned and could be declared final 185
Avoid if (x != y) ..; else ..; 196213
Local variable 'call' could be declared final 198
Parameter 'category' is not assigned and could be declared final 216
Parameter 'level' is not assigned and could be declared final 216
Local variable 'methodName' could be declared final 235
Consider simply returning the value vs storing it in local variable 'hasLevel' 237
Parameter 'level' is not assigned and could be declared final 243
Parameter 'clazz' is not assigned and could be declared final 243
Parameter 'c' is not assigned and could be declared final 243
Parameter 'enabledMethod' is not assigned and could be declared final 243
Parameter 'levelMethod' is not assigned and could be declared final 243
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 248
Consider simply returning the value vs storing it in local variable 'hasLevel' 250

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/UploadController.java

Violation Line
Private field 'uploadItems' could be made final; it is only initialized in the declaration or constructor. 46
Local variable 'part' could be declared final 59
Parameter 'event' is not assigned and could be declared final 65
Parameter 'part' is not assigned and could be declared final 69
Parameter 'fileBasic' is not assigned and could be declared final 88
Parameter 'fileContentType' is not assigned and could be declared final 96
Parameter 'fileMulti' is not assigned and could be declared final 104
Consider using varargs for methods or constructors which take an array the last parameter. 104
Parameter 'fileAjax' is not assigned and could be declared final 112

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/UploadItem.java

Violation Line
Avoid unused private fields such as 'LOG'. 29

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ValidationController.java

Violation Line
Parameter 'value' is not assigned and could be declared final 46
Parameter 'component' is not assigned and could be declared final 46
Parameter 'context' is not assigned and could be declared final 46
Local variable 'password' could be declared final 47
Local variable 'confirmationField' could be declared final 49
Local variable 'confirmationFieldValue' could be declared final 50

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ValidationJsr303Controller.java

Violation Line
Parameter 'required' is not assigned and could be declared final 42
Parameter 'length' is not assigned and could be declared final 50

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/actionlistener/SimpleTabChangeListener.java

Violation Line
Avoid using redundant field initializer for 'count' 27
Parameter 'tabChangeEvent' is not assigned and could be declared final 33

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/bestpractice/ToolBarCustomizer.java

Violation Line
Overridable method 'resetList' called during object construction 39
Avoid instantiation through private constructors from outside of the constructors class. 44
Avoid instantiation through private constructors from outside of the constructors class. 45
Avoid instantiation through private constructors from outside of the constructors class. 46
Private field 'label' could be made final; it is only initialized in the declaration or constructor. 76
Private field 'name' could be made final; it is only initialized in the declaration or constructor. 77

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/clientConfig/ClientConfigController.java

Violation Line
Avoid instantiating new objects inside loops 58
Overridable method 'loadFromTobagoContext' called during object construction 67
Avoid if (x != y) ..; else ..; 140144
Consider using varargs for methods or constructors which take an array the last parameter. 175
Avoid if (x != y) ..; else ..; 184188

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/clientConfig/ClientConfigPhaseListener.java

Violation Line
Document empty method 3334

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/formatter/AbstractConverter.java

Violation Line
Private field 'matcher' could be made final; it is only initialized in the declaration or constructor. 38
Private field 'compiler' could be made final; it is only initialized in the declaration or constructor. 39
Private field 'util' could be made final; it is only initialized in the declaration or constructor. 40

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/formatter/JspTagConverter.java

Violation Line
Private field 'tagConverter' could be made final; it is only initialized in the declaration or constructor. 35
Private field 'tags' could be made final; it is only initialized in the declaration or constructor. 36
The String literal "</span>" appears 5 times in this file; the first occurrence is on line 65 65
Prefer StringBuffer over += for concatenating strings 65
Prefer StringBuffer over += for concatenating strings 67
Prefer StringBuffer over += for concatenating strings 72
Prefer StringBuffer over += for concatenating strings 75
Prefer StringBuffer over += for concatenating strings 80

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/formatter/SourceFormatter.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2869
Consider using varargs for methods or constructors which take an array the last parameter. 30
A method/constructor shouldnt explicitly throw java.lang.Exception 30
Avoid appending characters as strings in StringBuffer.append. 63

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/formatter/StringExpression.java

Violation Line
Private field 'string' could be made final; it is only initialized in the declaration or constructor. 36
Use ArrayList instead of Vector 57
Use ArrayList instead of Vector 58
Avoid using implementation types like 'Vector'; use the interface instead 82
Avoid using implementation types like 'Vector'; use the interface instead 82
String.indexOf(char) is faster than String.indexOf(String). 85
Avoid if (x != y) ..; else ..; 92104

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/info/ActivityList.java

Violation Line
Private field 'data' could be made final; it is only initialized in the declaration or constructor. 42
Avoid if (x != y) ..; else ..; 6367
Avoid if (x != y) ..; else ..; 7276

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/info/ActivityPhaseListener.java

Violation Line
Document empty constructor 3738
Document empty method 5354

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/nonfacesrequest/FishPond.java

Violation Line
Private field 'fishes' could be made final; it is only initialized in the declaration or constructor. 38
Avoid using redundant field initializer for 'selectedFishId' 40
Parameter 'selectedFishId' is not assigned and could be declared final 79

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/sudoku/Sudoku.java

Violation Line
This class has too many methods, consider refactoring it. 36263
Avoid instantiation through private constructors from outside of the constructors class. 62
Avoid instantiation through private constructors from outside of the constructors class. 82
Avoid instantiating new objects inside loops 132
Avoid instantiating new objects inside loops 149
Avoid instantiating new objects inside loops 166
Consider using varargs for methods or constructors which take an array the last parameter. 182
Avoid instantiation through private constructors from outside of the constructors class. 183
Do not add empty strings 183
Do not add empty strings 187
Do not add empty strings 189
Avoid if (x != y) ..; else ..; 201205
Private field 'n' could be made final; it is only initialized in the declaration or constructor. 215
Private field 'list' could be made final; it is only initialized in the declaration or constructor. 216

Tobago Sandbox - org/apache/myfaces/tobago/internal/component/AbstractUISplitLayout.java

Violation Line
Avoid unused local variables such as 'firstComponent'. 39
Avoid unused local variables such as 'secondComponent'. 40
Avoid unused local variables such as 'oldPosition'. 41
Avoid unused local variables such as 'currentSize1'. 43
Avoid unused local variables such as 'currentSize2'. 44
Avoid reassigning parameters such as 'b' 66
Avoid reassigning parameters such as 'a' 66
Avoid reassigning parameters such as 'a' 66
Avoid reassigning parameters such as 'b' 66
An empty method in an abstract class should be abstract instead 100101
Document empty method 100101
An empty method in an abstract class should be abstract instead 113114
Document empty method 113114
Avoid if (x != y) ..; else ..; 122

Tobago Sandbox - org/apache/myfaces/tobago/renderkit/html/sandbox/standard/tag/NumberSliderRenderer.java

Violation Line
Avoid really long methods. 44153

Tobago Sandbox - org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SplitLayoutRenderer.java

Violation Line
Avoid unused method parameters such as 'layout'. 112
Avoid unused private methods such as 'calculateHandleStyle(AbstractUISplitLayout)'. 141
Avoid unused method parameters such as 'layout'. 141

Tobago Tool Apt - org/apache/myfaces/tobago/apt/generate/ClassInfo.java

Violation Line
Private field 'className' could be made final; it is only initialized in the declaration or constructor. 27
Private field 'packageName' could be made final; it is only initialized in the declaration or constructor. 28
Private field 'imports' could be made final; it is only initialized in the declaration or constructor. 29
Private field 'interfaces' could be made final; it is only initialized in the declaration or constructor. 31
Private field 'sourceClass' could be made final; it is only initialized in the declaration or constructor. 32
Avoid if (x != y) ..; else ..; 5156
Avoid if (x != y) ..; else ..; 7782

Tobago Tool Apt - org/apache/myfaces/tobago/apt/generate/ClassUtils.java

Violation Line
A class which only has private constructors should be final 2571

Tobago Tool Apt - org/apache/myfaces/tobago/apt/generate/ComponentInfo.java

Violation Line
Private field 'nonTransientProperties' could be made final; it is only initialized in the declaration or constructor. 30
Private field 'transientProperties' could be made final; it is only initialized in the declaration or constructor. 31
Avoid using redundant field initializer for 'index' 35
Avoid using redundant field initializer for 'nonTransientIndex' 36
Private field 'behaviors' could be made final; it is only initialized in the declaration or constructor. 37
Avoid if (x != y) ..; else ..; 5763
Parameter 'defaultBehavior' is not assigned and could be declared final 124

Tobago Tool Apt - org/apache/myfaces/tobago/apt/generate/Imports.java

Violation Line
Private field 'imports' could be made final; it is only initialized in the declaration or constructor. 28
Document empty constructor 3233
Avoid reassigning parameters such as 'qualifiedName' 39
These nested if statements could be combined 4149
Deeply nested if..then statements are hard to read 4345
Deeply nested if..then statements are hard to read 4648

Tobago Tool Apt - org/apache/myfaces/tobago/apt/generate/PropertyInfo.java

Violation Line
Possible God class (WMC=54, ATFD=14, TCC=0.08478513356562137) 20262
Document empty constructor 4142
Position literals first in String comparisons 125
Consider using varargs for methods or constructors which take an array the last parameter. 135
Consider using varargs for methods or constructors which take an array the last parameter. 143

Tobago Tool Apt - org/apache/myfaces/tobago/apt/generate/TagInfo.java

Violation Line
Private field 'properties' could be made final; it is only initialized in the declaration or constructor. 27

Tobago Tool Apt - org/apache/myfaces/tobago/apt/processor/AbstractGenerator.java

Violation Line
The class 'AbstractGenerator' has a Standard Cyclomatic Complexity of 2 (Highest = 11). 40125
The class 'AbstractGenerator' has a Modified Cyclomatic Complexity of 2 (Highest = 11). 40125
The class 'AbstractGenerator' has a Cyclomatic Complexity of 2 (Highest = 11). 40125
The method 'process' has a Cyclomatic Complexity of 11. 4695
The method 'process' has a Modified Cyclomatic Complexity of 11. 4695
The method 'process' has a Standard Cyclomatic Complexity of 11. 4695
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 55
These nested if statements could be combined 6769
These nested if statements could be combined 7274
A method/constructor shouldnt explicitly throw java.lang.Exception 99

Tobago Tool Apt - org/apache/myfaces/tobago/apt/processor/CheckstyleConfigGenerator.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20350
Possible God class (WMC=49, ATFD=53, TCC=0.008333333333333333) 20350
The class 'CheckstyleConfigGenerator' has a Cyclomatic Complexity of 3 (Highest = 10). 69350
This class has too many methods, consider refactoring it. 69350
The String literal "name" appears 5 times in this file; the first occurrence is on line 95 95
Avoid if (x != y) ..; else ..; 151158
Avoid if (x != y) ..; else ..; 153158
The method 'addAttributesForTag' has a Cyclomatic Complexity of 10. 194234
Local variable 'attributes' could be declared final 199
Position literals first in String comparisons 228
Parameter 'taglib' is not assigned and could be declared final 330
Parameter 'tagName' is not assigned and could be declared final 330
Parameter 'attributes' is not assigned and could be declared final 330
StringBuffer constructor is initialized with size 16, but has at least 67 characters appended. 331
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 332
Avoid appending characters as strings in StringBuffer.append. 332
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 333
Avoid appending characters as strings in StringBuffer.append. 334
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 334
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 335
Local variable 'attribute' could be declared final 337
Local variable 'attribute' could be declared final 342

Tobago Tool Apt - org/apache/myfaces/tobago/apt/processor/ClassesGenerator.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20283
Possible God class (WMC=47, ATFD=48, TCC=0.0) 20283
The class 'ClassesGenerator' has a Cyclomatic Complexity of 5 (Highest = 13). 64283
The class 'ClassesGenerator' has a Modified Cyclomatic Complexity of 5 (Highest = 13). 64283
The class 'ClassesGenerator' has a Standard Cyclomatic Complexity of 5 (Highest = 13). 64283
A method/constructor shouldnt explicitly throw java.lang.Exception 86
The method 'createTagOrComponent' has a Cyclomatic Complexity of 13. 99161
The method 'createTagOrComponent' has a Standard Cyclomatic Complexity of 13. 99161
The method 'createTagOrComponent' has a Modified Cyclomatic Complexity of 13. 99161
The method createTagOrComponent() has an NPath complexity of 559 99161
Avoid declaring a variable if it is unreferenced before a possible exit point. 105
Local variable 'behavior' could be declared final 115
Deeply nested if..then statements are hard to read 120127
Deeply nested if..then statements are hard to read 129131
Position literals first in String comparisons 140
Position literals first in String comparisons 140
The method addProperty() has an NPath complexity of 1403 204253
The method 'addProperty' has a Cyclomatic Complexity of 13. 204253
The method 'addProperty' has a Modified Cyclomatic Complexity of 12. 204253
The method 'addProperty' has a Standard Cyclomatic Complexity of 12. 204253
Deeply nested if..then statements are hard to read 211213
Deeply nested if..then statements are hard to read 216219
Deeply nested if..then statements are hard to read 227229

Tobago Tool Apt - org/apache/myfaces/tobago/apt/processor/FacesConfigGenerator.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20648
Possible God class (WMC=82, ATFD=91, TCC=0.047619047619047616) 20648
The class 'FacesConfigGenerator' has a Standard Cyclomatic Complexity of 4 (Highest = 11). 74648
This class has too many methods, consider refactoring it. 74648
The class 'FacesConfigGenerator' has a Modified Cyclomatic Complexity of 4 (Highest = 11). 74648
The class 'FacesConfigGenerator' has a Cyclomatic Complexity of 4 (Highest = 11). 74648
Avoid unused private fields such as 'BEHAVIOR_ID'. 124
Avoid unused private fields such as 'BEHAVIOR_CLASS'. 125
The method 'generate' has a Cyclomatic Complexity of 11. 148255
Avoid really long methods. 148255
A method/constructor shouldnt explicitly throw java.lang.Exception 148
The method generate() has an NPath complexity of 241 148255
The method 'generate' has a Modified Cyclomatic Complexity of 11. 148255
The method 'generate' has a Standard Cyclomatic Complexity of 11. 148255
Avoid if (x != y) ..; else ..; 180186
Avoid if (x != y) ..; else ..; 182186
Avoid unused private methods such as 'getIndexAfter(org.jdom.Element,String)'. 327
These nested if statements could be combined 338342
These nested if statements could be combined 339341
Position literals first in String comparisons 372
Prefer StringBuffer over += for concatenating strings 401
Prefer StringBuffer over += for concatenating strings 527
Avoid instantiating new objects inside loops 572
Avoid instantiating new objects inside loops 575
Avoid instantiating new objects inside loops 579
Avoid instantiating new objects inside loops 582
Avoid instantiating new objects inside loops 583
Prefer StringBuffer over += for concatenating strings 587
A method/constructor shouldnt explicitly throw java.lang.Exception 598
Avoid if (x != y) ..; else ..; 605634

Tobago Tool Apt - org/apache/myfaces/tobago/apt/processor/TaglibGenerator.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20523
Possible God class (WMC=79, ATFD=45, TCC=0.003952569169960474) 20523
The class 'TaglibGenerator' has a Cyclomatic Complexity of 3 (Highest = 18). 73523
This class has too many methods, consider refactoring it. 73523
The class 'TaglibGenerator' has a Standard Cyclomatic Complexity of 3 (Highest = 16). 73523
The class 'TaglibGenerator' has a Modified Cyclomatic Complexity of 3 (Highest = 16). 73523
Prefer StringBuffer over += for concatenating strings 155
Parameter 'functionName' is not assigned and could be declared final 171
Parameter 'document' is not assigned and could be declared final 171
Parameter 'taglib' is not assigned and could be declared final 171
Parameter 'functionClass' is not assigned and could be declared final 171
Parameter 'functionSignature' is not assigned and could be declared final 172
The method 'addDescription' has a Standard Cyclomatic Complexity of 16. 238306
The method addDescription() has an NPath complexity of 20880 238306
The method 'addDescription' has a Cyclomatic Complexity of 18. 238306
The method 'addDescription' has a Modified Cyclomatic Complexity of 16. 238306
StringBuffer constructor is initialized with size 16, but has at least 106 characters appended. 241
Avoid reassigning parameters such as 'string' 308
Avoid reassigning parameters such as 'string' 308
String.indexOf(char) is faster than String.indexOf(String). 316
Avoid unused private methods such as 'getInterfaceDeclaration(String)'. 326
StringBuffer constructor is initialized with size 16, but has at least 65 characters appended. 336
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 337
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 338
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 339
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 339
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 340
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 341
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 345
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 350
Unnecessary use of fully qualified name 'org.w3c.dom.Element' due to existing import 'org.w3c.dom.Element' 422
Unnecessary use of fully qualified name 'org.w3c.dom.Element' due to existing import 'org.w3c.dom.Element' 428
Unnecessary use of fully qualified name 'org.w3c.dom.Element' due to existing import 'org.w3c.dom.Element' 429
Unnecessary use of fully qualified name 'org.w3c.dom.Element' due to existing import 'org.w3c.dom.Element' 435
Unnecessary use of fully qualified name 'org.w3c.dom.Element' due to existing import 'org.w3c.dom.Element' 436
Parameter 'taglibAnnotation' is not assigned and could be declared final 441
Avoid if (x != y) ..; else ..; 494520