PMD Results

The following document contains the results of PMD 5.5.1.

Files

Tobago Core - org/apache/myfaces/tobago/component/Attributes.java

Violation Line
Parameter 'explicit' is not assigned and could be declared final 316
Avoid if (x != y) ..; else ..; 321325
Parameter 'name' is not assigned and could be declared final 328

Tobago Core - org/apache/myfaces/tobago/component/LabelLayout.java

Violation Line
Parameter 'facesContext' is not assigned and could be declared final 89

Tobago Core - org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.java

Violation Line
Document empty constructor 4748

Tobago Core - org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.java

Violation Line
Avoid using redundant field initializer for 'isTransient' 38
Unnecessary use of fully qualified name 'javax.faces.el.MethodNotFoundException' due to existing import 'javax.faces.el.MethodNotFoundException' 63
Unnecessary use of fully qualified name 'javax.faces.el.MethodNotFoundException' due to existing import 'javax.faces.el.MethodNotFoundException' 76

Tobago Core - org/apache/myfaces/tobago/component/Sorter.java

Violation Line
Possible God class (WMC=51, ATFD=25, TCC=0.2) 20259
The class 'Sorter' has a Modified Cyclomatic Complexity of 6 (Highest = 28). 49258
The class 'Sorter' has a Standard Cyclomatic Complexity of 6 (Highest = 28). 49258
The class 'Sorter' has a Cyclomatic Complexity of 8 (Highest = 30). 49258
The method perform() has an NPath complexity of 139872 64201
The method 'perform' has a Cyclomatic Complexity of 30. 64201
Avoid really long methods. 64201
The method 'perform' has a Modified Cyclomatic Complexity of 28. 64201
The method 'perform' has a Standard Cyclomatic Complexity of 28. 64201
Avoid if (x != y) ..; else ..; 96137
Avoid if (x != y) ..; else ..; 99132
Avoid if (x != y) ..; else ..; 199
The method 'getFirstSortableChild' has a Cyclomatic Complexity of 13. 224249

Tobago Core - org/apache/myfaces/tobago/component/UIScript.java

Violation Line
Parameter 'file' is not assigned and could be declared final 51

Tobago Core - org/apache/myfaces/tobago/component/UIStyle.java

Violation Line
Possible God class (WMC=69, ATFD=50, TCC=0.0) 1355
This class has a bunch of public methods and attributes 1355
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 74
Local variable 'object' could be declared final 75
Parameter 'paddingRight' is not assigned and could be declared final 82
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 82
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 86
Local variable 'object' could be declared final 87
Parameter 'minHeight' is not assigned and could be declared final 94
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 94
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 98
Local variable 'object' could be declared final 99
Parameter 'marginRight' is not assigned and could be declared final 106
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 106
Parameter 'file' is not assigned and could be declared final 119
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 123
Local variable 'object' could be declared final 124
Parameter 'paddingBottom' is not assigned and could be declared final 131
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 131
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 135
Local variable 'object' could be declared final 136
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 143
Parameter 'top' is not assigned and could be declared final 143
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 147
Local variable 'object' could be declared final 148
Parameter 'maxHeight' is not assigned and could be declared final 155
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 155
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 159
Local variable 'object' could be declared final 160
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 167
Parameter 'paddingTop' is not assigned and could be declared final 167
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 171
Local variable 'object' could be declared final 172
Parameter 'height' is not assigned and could be declared final 179
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 179
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 183
Local variable 'object' could be declared final 184
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 191
Parameter 'maxWidth' is not assigned and could be declared final 191
Parameter 'textAlign' is not assigned and could be declared final 204
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 208
Local variable 'object' could be declared final 209
Parameter 'bottom' is not assigned and could be declared final 216
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 216
Parameter 'display' is not assigned and could be declared final 224
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 228
Local variable 'object' could be declared final 229
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 236
Parameter 'minWidth' is not assigned and could be declared final 236
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 240
Local variable 'object' could be declared final 241
Parameter 'right' is not assigned and could be declared final 248
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 248
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 252
Local variable 'object' could be declared final 253
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 260
Parameter 'marginLeft' is not assigned and could be declared final 260
Parameter 'overflowX' is not assigned and could be declared final 268
Parameter 'overflowY' is not assigned and could be declared final 276
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 280
Local variable 'object' could be declared final 281
Parameter 'left' is not assigned and could be declared final 288
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 288
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 292
Local variable 'object' could be declared final 293
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 300
Parameter 'width' is not assigned and could be declared final 300
Parameter 'customClass' is not assigned and could be declared final 308
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 312
Local variable 'object' could be declared final 313
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 320
Parameter 'marginBottom' is not assigned and could be declared final 320
Parameter 'position' is not assigned and could be declared final 328
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 332
Local variable 'object' could be declared final 333
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 340
Parameter 'paddingLeft' is not assigned and could be declared final 340
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 344
Local variable 'object' could be declared final 345
Unnecessary use of fully qualified name 'org.apache.myfaces.tobago.layout.Measure' due to existing import 'org.apache.myfaces.tobago.layout.Measure' 352
Parameter 'marginTop' is not assigned and could be declared final 352

Tobago Core - org/apache/myfaces/tobago/config/TobagoConfig.java

Violation Line
Class contains multiple getInstance methods. Please review. 4143

Tobago Core - org/apache/myfaces/tobago/context/Markup.java

Violation Line
This class has too many methods, consider refactoring it. 57376
The class 'Markup' has a Modified Cyclomatic Complexity of 5 (Highest = 10). 57376
The class 'Markup' has a Cyclomatic Complexity of 5 (Highest = 11). 57376
The class 'Markup' has a Standard Cyclomatic Complexity of 5 (Highest = 10). 57376
Consider using varargs for methods or constructors which take an array the last parameter. 122
Consider using varargs for methods or constructors which take an array the last parameter. 132
Avoid if (x != y) ..; else ..; 192
Avoid unnecessary if..then..else statements when returning booleans 195197
Avoid if (x != y) ..; else ..; 204
Avoid if (x != y) ..; else ..; 205
Use equals() to compare object references. 228
Avoid if (x != y) ..; else ..; 231242
Avoid if (x != y) ..; else ..; 272281
The method 'contains' has a Modified Cyclomatic Complexity of 10. 333363
The method 'contains' has a Standard Cyclomatic Complexity of 10. 333363
The method 'contains' has a Cyclomatic Complexity of 11. 333363
Use equals() to compare object references. 334
Avoid if (x != y) ..; else ..; 340362
Avoid if (x != y) ..; else ..; 341350
Avoid if (x != y) ..; else ..; 352361

Tobago Core - org/apache/myfaces/tobago/context/MarkupConfig.java

Violation Line
Private field 'markups' could be made final; it is only initialized in the declaration or constructor. 30

Tobago Core - org/apache/myfaces/tobago/context/ThemeImpl.java

Violation Line
Possible God class (WMC=56, ATFD=14, TCC=0.07142857142857142) 20301
The class 'ThemeImpl' has a Standard Cyclomatic Complexity of 2 (Highest = 12). 33301
The class 'ThemeImpl' has a Cyclomatic Complexity of 2 (Highest = 12). 33301
The class 'ThemeImpl' has a Modified Cyclomatic Complexity of 2 (Highest = 12). 33301
Private field 'productionResources' could be made final; it is only initialized in the declaration or constructor. 45
Private field 'resources' could be made final; it is only initialized in the declaration or constructor. 46
Avoid using redundant field initializer for 'unmodifiable' 54
Deeply nested if..then statements are hard to read 145148
The method 'toString' has a Modified Cyclomatic Complexity of 12. 260300
The method 'toString' has a Standard Cyclomatic Complexity of 12. 260300
The method 'toString' has a Cyclomatic Complexity of 12. 260300
StringBuffer constructor is initialized with size 16, but has at least 112 characters appended. 261
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 262
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 263
Avoid if (x != y) ..; else ..; 265271
Avoid appending characters as strings in StringBuffer.append. 266
Avoid appending characters as strings in StringBuffer.append. 268
Local variable 's' could be declared final 273
Avoid if (x != y) ..; else ..; 273
Avoid appending characters as strings in StringBuffer.append. 274
Avoid if (x != y) ..; else ..; 278
Local variable 's' could be declared final 278
Avoid appending characters as strings in StringBuffer.append. 279
Avoid if (x != y) ..; else ..; 283
Local variable 's' could be declared final 283
Avoid appending characters as strings in StringBuffer.append. 284
Avoid if (x != y) ..; else ..; 288
Local variable 's' could be declared final 288
Avoid appending characters as strings in StringBuffer.append. 289
Avoid appending characters as strings in StringBuffer.append. 293
Avoid appending characters as strings in StringBuffer.append. 296

Tobago Core - org/apache/myfaces/tobago/context/ThemeResource.java

Violation Line
Avoid if (x != y) ..; else ..; 50
Avoid if (x != y) ..; else ..; 56

Tobago Core - org/apache/myfaces/tobago/context/ThemeResources.java

Violation Line
Parameter 'production' is not assigned and could be declared final 39
Parameter 'exclude' is not assigned and could be declared final 67
Parameter 'exclude' is not assigned and could be declared final 71

Tobago Core - org/apache/myfaces/tobago/context/TobagoBundle.java

Violation Line
Private field 'bundleName' could be made final; it is only initialized in the declaration or constructor. 49
Private field 'bundle' could be made final; it is only initialized in the declaration or constructor. 50
Private field 'props' could be made final; it is only initialized in the declaration or constructor. 78
Parameter 'stream' is not assigned and could be declared final 80
Parameter 'key' is not assigned and could be declared final 85
Local variable 'handleKeys' could be declared final 90
The class 'XMLResourceBundleControl' has a Cyclomatic Complexity of 6 (Highest = 10). 94136
Parameter 'baseName' is not assigned and could be declared final 96
The method 'newBundle' has a Cyclomatic Complexity of 10. 100135
Parameter 'loader' is not assigned and could be declared final 101
Parameter 'format' is not assigned and could be declared final 101
Parameter 'locale' is not assigned and could be declared final 101
Parameter 'baseName' is not assigned and could be declared final 101
Parameter 'reload' is not assigned and could be declared final 101
Avoid declaring a variable if it is unreferenced before a possible exit point. 108
Local variable 'bundleName' could be declared final 113
Local variable 'resourceName' could be declared final 114
Local variable 'url' could be declared final 115
Local variable 'connection' could be declared final 119
Local variable 'stream' could be declared final 126
Local variable 'bis' could be declared final 130
Avoid instantiation through private constructors from outside of the constructors class. 131

Tobago Core - org/apache/myfaces/tobago/context/TobagoContext.java

Violation Line
Local variable 'request' could be declared final 67
Parameter 'theme' is not assigned and could be declared final 83
Parameter 'userAgent' is not assigned and could be declared final 103
Parameter 'facesContext' is not assigned and could be declared final 107

Tobago Core - org/apache/myfaces/tobago/context/TobagoMessageBundle.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3144

Tobago Core - org/apache/myfaces/tobago/context/TobagoResourceBundle.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2941

Tobago Core - org/apache/myfaces/tobago/context/TransientStateHolder.java

Violation Line
Document empty constructor 3334

Tobago Core - org/apache/myfaces/tobago/context/UserAgent.java

Violation Line
The class 'UserAgent' has a Modified Cyclomatic Complexity of 3 (Highest = 19). 33390
The class 'UserAgent' has a Standard Cyclomatic Complexity of 3 (Highest = 19). 33390
The class 'UserAgent' has a Cyclomatic Complexity of 3 (Highest = 20). 33390
The String literal "msie" appears 12 times in this file; the first occurrence is on line 39 39
The String literal "opera" appears 4 times in this file; the first occurrence is on line 103 103
The String literal "mozilla" appears 4 times in this file; the first occurrence is on line 127 127
The String literal "gecko" appears 5 times in this file; the first occurrence is on line 150 150
The method 'getInstance' has a Modified Cyclomatic Complexity of 19. 279334
The method 'getInstance' has a Standard Cyclomatic Complexity of 19. 279334
The method 'getInstance' has a Cyclomatic Complexity of 20. 279334
Avoid if (x != y) ..; else ..; 350352
Consider using varargs for methods or constructors which take an array the last parameter. 364
Consider using varargs for methods or constructors which take an array the last parameter. 382

Tobago Core - org/apache/myfaces/tobago/convert/DurationConverter.java

Violation Line
Unnecessary wrapper object creation 65
Avoid declaring a variable if it is unreferenced before a possible exit point. 89
The default label should be the last label in a switch statement 129145

Tobago Core - org/apache/myfaces/tobago/el/ConstantMethodExpression.java

Violation Line
Document empty constructor 3536
Parameter 'outcome' is not assigned and could be declared final 38
Parameter 'context' is not assigned and could be declared final 43
Parameter 'params' is not assigned and could be declared final 49
Parameter 'context' is not assigned and could be declared final 49
Parameter 'o' is not assigned and could be declared final 55
Local variable 'that' could be declared final 63
Avoid if (x != y) ..; else ..; 65
Parameter 'context' is not assigned and could be declared final 85
Parameter 'context' is not assigned and could be declared final 90
Parameter 'state' is not assigned and could be declared final 90

Tobago Core - org/apache/myfaces/tobago/el/UserWrapper.java

Violation Line
Private field 'roles' could be made final; it is only initialized in the declaration or constructor. 35

Tobago Core - org/apache/myfaces/tobago/event/CollapsibleActionListener.java

Violation Line
Parameter 'context' is not assigned and could be declared final 69
Parameter 'state' is not assigned and could be declared final 74
Parameter 'context' is not assigned and could be declared final 74
Parameter 'transientFlag' is not assigned and could be declared final 84

Tobago Core - org/apache/myfaces/tobago/event/FacesEventWrapper.java

Violation Line
Private field 'wrappedFacesEvent' could be made final; it is only initialized in the declaration or constructor. 31

Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionStateChangeListener.java

Violation Line
Avoid using redundant field initializer for 'isTransient' 33
Document empty constructor 3536

Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTabChangeListener.java

Violation Line
Avoid using redundant field initializer for 'isTransient' 33
Document empty constructor 3536

Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.java

Violation Line
Avoid using redundant field initializer for 'isTransient' 34
Document empty constructor 3637
Avoid unused private methods such as 'elContext()'. 48

Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.java

Violation Line
Avoid using redundant field initializer for 'isTransient' 33
Document empty constructor 3536
Avoid unused private methods such as 'elContext()'. 47

Tobago Core - org/apache/myfaces/tobago/event/PageActionEvent.java

Violation Line
Private field 'action' could be made final; it is only initialized in the declaration or constructor. 31

Tobago Core - org/apache/myfaces/tobago/event/ResetInputActionListener.java

Violation Line
Document empty constructor 3435
Consider using varargs for methods or constructors which take an array the last parameter. 37

Tobago Core - org/apache/myfaces/tobago/event/SortActionEvent.java

Violation Line
Private field 'column' could be made final; it is only initialized in the declaration or constructor. 31

Tobago Core - org/apache/myfaces/tobago/event/TabChangeEvent.java

Violation Line
Overridable method 'setOldState' called during object construction 45
Overridable method 'setNewState' called during object construction 46

Tobago Core - org/apache/myfaces/tobago/event/TreeExpansionEvent.java

Violation Line
Private field 'oldExpanded' could be made final; it is only initialized in the declaration or constructor. 30
Private field 'newExpanded' could be made final; it is only initialized in the declaration or constructor. 31

Tobago Core - org/apache/myfaces/tobago/event/TreeSelectedEvent.java

Violation Line
Private field 'oldSelected' could be made final; it is only initialized in the declaration or constructor. 30
Private field 'newSelected' could be made final; it is only initialized in the declaration or constructor. 31

Tobago Core - org/apache/myfaces/tobago/event/ValueExpressionResetInputActionListener.java

Violation Line
Document empty constructor 4445

Tobago Core - org/apache/myfaces/tobago/event/ValueExpressionSheetStateChangeListener.java

Violation Line
Document empty constructor 3738
Avoid if (x != y) ..; else ..; 4852
No need to check for null before an instanceof 85

Tobago Core - org/apache/myfaces/tobago/event/ValueExpressionTabChangeListener.java

Violation Line
Document empty constructor 3738
Avoid if (x != y) ..; else ..; 4852
No need to check for null before an instanceof 85

Tobago Core - org/apache/myfaces/tobago/facelets/AttributeHandler.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20356
Possible God class (WMC=77, ATFD=82, TCC=0.027777777777777776) 20356
The class 'AttributeHandler' has a Cyclomatic Complexity of 7 (Highest = 57). 56356
The class 'AttributeHandler' has a Standard Cyclomatic Complexity of 6 (Highest = 50). 56356
The class 'AttributeHandler' has a Modified Cyclomatic Complexity of 6 (Highest = 50). 56356
Avoid really long methods. 74273
The method apply() has an NCSS line count of 158 74273
The method 'apply' has a Standard Cyclomatic Complexity of 50. 74273
The method 'apply' has a Cyclomatic Complexity of 57. 74273
The method 'apply' has a Modified Cyclomatic Complexity of 50. 74273
Avoid if (x != y) ..; else ..; 81271
Avoid if (x != y) ..; else ..; 85103
Avoid if (x != y) ..; else ..; 108126
Avoid if (x != y) ..; else ..; 194201
Avoid if (x != y) ..; else ..; 262270
Consider using varargs for methods or constructors which take an array the last parameter. 297
Avoid if (x != y) ..; else ..; 303309

Tobago Core - org/apache/myfaces/tobago/facelets/ConverterHandler.java

Violation Line
Avoid declaring a variable if it is unreferenced before a possible exit point. 54
New exception is thrown in catch block, original stack trace may be lost 66
Deeply nested if..then statements are hard to read 6870

Tobago Core - org/apache/myfaces/tobago/facelets/EventHandler.java

Violation Line
Parameter 'config' is not assigned and could be declared final 81
Parameter 'parent' is not assigned and could be declared final 86
Parameter 'ctx' is not assigned and could be declared final 86
Parameter 'parent' is not assigned and could be declared final 136
Parameter 'context' is not assigned and could be declared final 136
Local variable 'faceletContext' could be declared final 138139
Avoid declaring a variable if it is unreferenced before a possible exit point. 138139
Avoid unused local variables such as 'faceletContext'. 138
Local variable 'cvh' could be declared final 142
Local variable 'clientBehaviors' could be declared final 154
Local variable 'clientBehaviorList' could be declared final 156
Local variable 'cb' could be declared final 158
Local variable 'ajaxBehavior' could be declared final 169
Parameter 'context' is not assigned and could be declared final 174
Parameter 'faceletContext' is not assigned and could be declared final 179
Parameter 'parent' is not assigned and could be declared final 179
Parameter 'component' is not assigned and could be declared final 179
Document empty constructor 207208
Parameter 'expr' is not assigned and could be declared final 210
Parameter 'event' is not assigned and could be declared final 214
Parameter 'context' is not assigned and could be declared final 224
Parameter 'state' is not assigned and could be declared final 224
Parameter 'context' is not assigned and could be declared final 231
Parameter 'newTransientValue' is not assigned and could be declared final 238

Tobago Core - org/apache/myfaces/tobago/facelets/FixCharacterEncodingFilter.java

Violation Line
Document empty method body 5758

Tobago Core - org/apache/myfaces/tobago/facelets/MetaInfResourcesClasspathResourceResolver.java

Violation Line
This call to String.startsWith can be rewritten using String.charAt(0) 67

Tobago Core - org/apache/myfaces/tobago/facelets/Resource.java

Violation Line
These nested if statements could be combined 7274
Document empty method body 114115
Avoid if (x != y) ..; else ..; 136

Tobago Core - org/apache/myfaces/tobago/facelets/ScriptHandler.java

Violation Line
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 42
These nested if statements could be combined 5055
Deeply nested if..then statements are hard to read 5254

Tobago Core - org/apache/myfaces/tobago/facelets/SegmentLayoutConstraintHandler.java

Violation Line
The class 'SegmentLayoutConstraintHandler' has a Cyclomatic Complexity of 10 (Highest = 17). 32131
The class 'SegmentLayoutConstraintHandler' has a Standard Cyclomatic Complexity of 10 (Highest = 17). 32131
The class 'SegmentLayoutConstraintHandler' has a Modified Cyclomatic Complexity of 10 (Highest = 17). 32131
Parameter 'config' is not assigned and could be declared final 43
Parameter 'faceletContext' is not assigned and could be declared final 56
The method 'apply' has a Cyclomatic Complexity of 17. 56130
The method apply() has an NPath complexity of 6561 56130
The method 'apply' has a Modified Cyclomatic Complexity of 17. 56130
The method 'apply' has a Standard Cyclomatic Complexity of 17. 56130
Parameter 'parent' is not assigned and could be declared final 56

Tobago Core - org/apache/myfaces/tobago/facelets/SegmentLayoutRule.java

Violation Line
These nested if statements could be combined 3953
Local variable 'a' could be declared final 40
Deeply nested if..then statements are hard to read 4143
Deeply nested if..then statements are hard to read 4446
Deeply nested if..then statements are hard to read 4749
Deeply nested if..then statements are hard to read 5052

Tobago Core - org/apache/myfaces/tobago/facelets/SheetStateChangeSourceRule.java

Violation Line
These nested if statements could be combined 4143

Tobago Core - org/apache/myfaces/tobago/facelets/SortActionSourceRule.java

Violation Line
These nested if statements could be combined 4244

Tobago Core - org/apache/myfaces/tobago/facelets/SpanHandler.java

Violation Line
Parameter 'parent' is not assigned and could be declared final 47

Tobago Core - org/apache/myfaces/tobago/facelets/StyleHandler.java

Violation Line
Possible God class (WMC=129, ATFD=125, TCC=0.0) 20562
The class 'StyleHandler' has a Standard Cyclomatic Complexity of 32 (Highest = 71). 44562
Too many fields 44562
The class 'StyleHandler' has a Cyclomatic Complexity of 32 (Highest = 71). 44562
The class 'StyleHandler' has a Modified Cyclomatic Complexity of 32 (Highest = 71). 44562
The method 'apply' has a Modified Cyclomatic Complexity of 10. 108158
The method 'apply' has a Cyclomatic Complexity of 11. 108158
The method 'apply' has a Standard Cyclomatic Complexity of 10. 108158
Local variable 'renderedSet' could be declared final 110
Local variable 'rendered' could be declared final 114
Deeply nested if..then statements are hard to read 121123
Avoid really long methods. 160402
The method 'applyAttributes1' has a Cyclomatic Complexity of 71. 160402
The method applyAttributes1() has an NCSS line count of 157 160402
The method applyAttributes1() has an NPath complexity of 1054752768 160402
The method 'applyAttributes1' has a Modified Cyclomatic Complexity of 71. 160402
The method 'applyAttributes1' has a Standard Cyclomatic Complexity of 71. 160402
The method applyAttributes2() has an NCSS line count of 102 404561
The method applyAttributes2() has an NPath complexity of 10077696 404561
Parameter 'parameter' is not assigned and could be declared final 404
Avoid really long methods. 404561
The method 'applyAttributes2' has a Modified Cyclomatic Complexity of 46. 404561
Parameter 'faceletContext' is not assigned and could be declared final 404
The method 'applyAttributes2' has a Standard Cyclomatic Complexity of 46. 404561
The method 'applyAttributes2' has a Cyclomatic Complexity of 46. 404561

Tobago Core - org/apache/myfaces/tobago/facelets/SuggestMethodRule.java

Violation Line
These nested if statements could be combined 4244
These nested if statements could be combined 4751
These nested if statements could be combined 4850
Deeply nested if..then statements are hard to read 4850

Tobago Core - org/apache/myfaces/tobago/facelets/SupportsMarkupRule.java

Violation Line
Local variable 'a' could be declared final 41

Tobago Core - org/apache/myfaces/tobago/facelets/TabChangeListenerHandler.java

Violation Line
New exception is thrown in catch block, original stack trace may be lost 77
Deeply nested if..then statements are hard to read 7981
Avoid if (x != y) ..; else ..; 8388

Tobago Core - org/apache/myfaces/tobago/facelets/TabChangeSourceRule.java

Violation Line
These nested if statements could be combined 3840

Tobago Core - org/apache/myfaces/tobago/facelets/TagMethodExpression.java

Violation Line
New exception is thrown in catch block, original stack trace may be lost 64
New exception is thrown in catch block, original stack trace may be lost 66
New exception is thrown in catch block, original stack trace may be lost 68
New exception is thrown in catch block, original stack trace may be lost 77
New exception is thrown in catch block, original stack trace may be lost 79
New exception is thrown in catch block, original stack trace may be lost 81

Tobago Core - org/apache/myfaces/tobago/facelets/TobagoComponentHandler.java

Violation Line
Local variable 'validator' could be declared final 94
Local variable 'entry' could be declared final 97
Local variable 'next' could be declared final 103

Tobago Core - org/apache/myfaces/tobago/internal/ajax/AjaxInternalUtils.java

Violation Line
Parameter 'facesContext' is not assigned and could be declared final 64

Tobago Core - org/apache/myfaces/tobago/internal/ajax/AjaxNavigationListener.java

Violation Line
Parameter 'facesContext' is not assigned and could be declared final 63

Tobago Core - org/apache/myfaces/tobago/internal/ajax/AjaxNavigationState.java

Violation Line
Private field 'viewRoot' could be made final; it is only initialized in the declaration or constructor. 52
Private field 'messages' could be made final; it is only initialized in the declaration or constructor. 54
Avoid if (x != y) ..; else ..; 113117
Avoid if (x != y) ..; else ..; 125132
Use equals() to compare object references. 136
Parameter 'facesContext' is not assigned and could be declared final 184
Local variable 'throwable' could be declared final 188
Parameter 'facesContext' is not assigned and could be declared final 196

Tobago Core - org/apache/myfaces/tobago/internal/behavior/AttachedListStateWrapper.java

Violation Line
Private field 'wrappedStateList' could be made final; it is only initialized in the declaration or constructor. 34
Parameter 'wrappedStateList' is not assigned and could be declared final 36

Tobago Core - org/apache/myfaces/tobago/internal/behavior/AttachedStateWrapper.java

Violation Line
Private field 'clazz' could be made final; it is only initialized in the declaration or constructor. 30
Private field 'wrappedStateObject' could be made final; it is only initialized in the declaration or constructor. 31
Parameter 'wrappedStateObject' is not assigned and could be declared final 36
Parameter 'clazz' is not assigned and could be declared final 36

Tobago Core - org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.java

Violation Line
Possible God class (WMC=101, ATFD=34, TCC=0.008333333333333333) 20763
This class has too many methods, consider refactoring it. 147763
The class 'DeltaStateHelper' has a Cyclomatic Complexity of 4 (Highest = 12). 147763
The class 'DeltaStateHelper' has a Modified Cyclomatic Complexity of 4 (Highest = 11). 147763
The class 'DeltaStateHelper' has a Standard Cyclomatic Complexity of 4 (Highest = 11). 147763
Private field 'target' could be made final; it is only initialized in the declaration or constructor. 155
Private field 'fullState' could be made final; it is only initialized in the declaration or constructor. 160
Avoid using redundant field initializer for 'transientBoolean' 173
Parameter 'target' is not assigned and could be declared final 175
Parameter 'value' is not assigned and could be declared final 203
Parameter 'key' is not assigned and could be declared final 203
Parameter 'key' is not assigned and could be declared final 225
Local variable 'returnValue' could be declared final 226
Local variable 'expression' could be declared final 230231
Parameter 'defaultValue' is not assigned and could be declared final 239
Parameter 'key' is not assigned and could be declared final 239
Local variable 'returnValue' could be declared final 240
Local variable 'expression' could be declared final 244245
Parameter 'key' is not assigned and could be declared final 253
Parameter 'value' is not assigned and could be declared final 257
Parameter 'key' is not assigned and could be declared final 257
Parameter 'value' is not assigned and could be declared final 281
Parameter 'key' is not assigned and could be declared final 281
Parameter 'mapKey' is not assigned and could be declared final 281
Parameter 'key' is not assigned and could be declared final 315
Parameter 'valueOrKey' is not assigned and could be declared final 333
Parameter 'key' is not assigned and could be declared final 333
Local variable 'collectionOrMap' could be declared final 340
Parameter 'stateMap' is not assigned and could be declared final 365
Parameter 'key' is not assigned and could be declared final 365
Parameter 'valueOrKey' is not assigned and could be declared final 366
Local variable 'c' could be declared final 368
Parameter 'stateMap' is not assigned and could be declared final 379
Parameter 'key' is not assigned and could be declared final 379
Parameter 'valueOrKey' is not assigned and could be declared final 380
Local variable 'c' could be declared final 382
Parameter 'stateMap' is not assigned and could be declared final 395
Parameter 'key' is not assigned and could be declared final 395
Parameter 'valueOrKey' is not assigned and could be declared final 396
Parameter 'delta' is not assigned and could be declared final 396
Local variable 'map' could be declared final 402
Parameter 'context' is not assigned and could be declared final 433
Local variable 'serializableMap' could be declared final 434
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 436
Local variable 'it' could be declared final 459
Local variable 'value' could be declared final 465
Local variable 'savedValue' could be declared final 471
The method 'restoreState' has a Standard Cyclomatic Complexity of 11. 515569
The method 'restoreState' has a Cyclomatic Complexity of 12. 515569
The method 'restoreState' has a Modified Cyclomatic Complexity of 11. 515569
Parameter 'state' is not assigned and could be declared final 515
Parameter 'context' is not assigned and could be declared final 515
Local variable 'serializedState' could be declared final 520
Local variable 'key' could be declared final 530
Local variable 'savedValue' could be declared final 531532
Local variable 'mapEntry' could be declared final 536
Local variable 'addOrRemove' could be declared final 538
Local variable 'mapEntry' could be declared final 548
Parameter 'transientValue' is not assigned and could be declared final 571
Parameter 'loadFactor' is not assigned and could be declared final 582
Parameter 'initialCapacity' is not assigned and could be declared final 582
Parameter 'm' is not assigned and could be declared final 586
Parameter 'initialSize' is not assigned and could be declared final 590
Parameter 'newTransientValue' is not assigned and could be declared final 598
Parameter 'state' is not assigned and could be declared final 602
Parameter 'context' is not assigned and could be declared final 602
Local variable 'listAsMap' could be declared final 603
Parameter 'context' is not assigned and could be declared final 609
Local variable 'entry' could be declared final 612
Local variable 'value' could be declared final 614
Parameter 'loadFactor' is not assigned and could be declared final 636
Parameter 'initialCapacity' is not assigned and could be declared final 636
Parameter 'initialSize' is not assigned and could be declared final 640
Parameter 'm' is not assigned and could be declared final 644
Parameter 'c' is not assigned and could be declared final 654
Parameter 'initialSize' is not assigned and could be declared final 658
Document empty method body 666667
Parameter 'newTransientValue' is not assigned and could be declared final 666
Parameter 'state' is not assigned and could be declared final 669
Parameter 'context' is not assigned and could be declared final 669
Local variable 'listAsArr' could be declared final 670
Local variable 'elem' could be declared final 673
Parameter 'context' is not assigned and could be declared final 678
Local variable 'value' could be declared final 681
Parameter 'context' is not assigned and could be declared final 693
Parameter 'attachedObject' is not assigned and could be declared final 693
Local variable 'holder' could be declared final 704
Local variable 'lst' could be declared final 711
Local variable 'item' could be declared final 712
Parameter 'context' is not assigned and could be declared final 726
Parameter 'stateObj' is not assigned and could be declared final 726
Local variable 'lst' could be declared final 734
Local variable 'restoredList' could be declared final 735
Local variable 'item' could be declared final 736
Local variable 'clazz' could be declared final 741
Local variable 'wrapper' could be declared final 752
Local variable 'wrappedState' could be declared final 753
Local variable 'holder' could be declared final 755

Tobago Core - org/apache/myfaces/tobago/internal/behavior/EventBehavior.java

Violation Line
Possible God class (WMC=48, ATFD=8, TCC=0.03260869565217391) 20315
Avoid using redundant field initializer for 'stateHelper' 74
Parameter 'listener' is not assigned and could be declared final 83
Parameter 'listener' is not assigned and could be declared final 87
Parameter 'execute' is not assigned and could be declared final 98
Parameter 'onError' is not assigned and could be declared final 106
Parameter 'onEvent' is not assigned and could be declared final 114
Parameter 'render' is not assigned and could be declared final 125
Parameter 'name' is not assigned and could be declared final 130
Local variable 'bindings' could be declared final 136137
Avoid if (x != y) ..; else ..; 138142
Parameter 'name' is not assigned and could be declared final 145
Parameter 'expression' is not assigned and could be declared final 145
Ternary operators that can be simplified with || or && 170
Parameter 'disabled' is not assigned and could be declared final 174
Ternary operators that can be simplified with || or && 180
Parameter 'immediate' is not assigned and could be declared final 184
Parameter 'facesContext' is not assigned and could be declared final 203
Parameter 'o' is not assigned and could be declared final 203
Local variable 'values' could be declared final 207
Parameter 'create' is not assigned and could be declared final 225
Parameter 'facesContext' is not assigned and could be declared final 236
Local variable 'parentSaved' could be declared final 238
Local variable 'stateHelper' could be declared final 240
Local variable 'stateHelper' could be declared final 253
Parameter 'attributeName' is not assigned and could be declared final 274
Local variable 'value' could be declared final 275
Parameter 'stringValue' is not assigned and could be declared final 295
Local variable 'arrValue' could be declared final 308

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIBar.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2526

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIButton.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2527

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIButtons.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2526

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUICollapsiblePanel.java

Violation Line
Parameter 'submittedCollapsed' is not assigned and could be declared final 84
Avoid if (x != y) ..; else ..; 9195

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIColumnNode.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2930

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIColumnSelector.java

Violation Line
An empty method in an abstract class should be abstract instead 3537

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUICommand.java

Violation Line
Avoid unused private fields such as 'LOG'. 42
Local variable 'child' could be declared final 54

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUICommandBase.java

Violation Line
Parameter 'event' is not assigned and could be declared final 49
Local variable 'operation' could be declared final 54
Avoid instantiating new objects inside loops 55
Parameter 'disabled' is not assigned and could be declared final 129

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIData.java

Violation Line
Possible God class (WMC=48, ATFD=11, TCC=0.11462450592885376) 20326
The String literal "Not a tree model" appears 4 times in this file; the first occurrence is on line 77 77
Avoid if (x != y) ..; else ..; 8690
Avoid if (x != y) ..; else ..; 162166
Avoid if (x != y) ..; else ..; 171
Avoid if (x != y) ..; else ..; 176
String.indexOf(char) is faster than String.indexOf(String). 217
Parameter 'callback' is not assigned and could be declared final 279
Parameter 'context' is not assigned and could be declared final 279
Local variable 'oldRowIndex' could be declared final 286
Local variable 'childCount' could be declared final 306
Local variable 'child' could be declared final 307
These nested if statements could be combined 309311

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIFlexLayout.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2932

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIFlowLayout.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2730

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIGridLayout.java

Violation Line
Parameter 'event' is not assigned and could be declared final 65
Avoid instantiating new objects inside loops 81
Avoid appending characters as strings in StringBuffer.append. 105
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 105
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 106
Avoid appending characters as strings in StringBuffer.append. 107
Avoid appending characters as strings in StringBuffer.append. 117
Avoid appending characters as strings in StringBuffer.append. 127

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIIn.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2527

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUILabel.java

Violation Line
Avoid if (x != y) ..; else ..; 3642
Avoid if (x != y) ..; else ..; 3842

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUILayoutBase.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2728

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUILinks.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2526

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIMessages.java

Violation Line
Avoid if (x != y) ..; else ..; 4549
Avoid declaring a variable if it is unreferenced before a possible exit point. 67
Avoid instantiating new objects inside loops 77

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIObject.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2930

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIPage.java

Violation Line
The class 'AbstractUIPage' has a Cyclomatic Complexity of 3 (Highest = 11). 38162
Avoid if (x != y) ..; else ..; 7276
The method 'markSubmittedForm' has a Cyclomatic Complexity of 11. 105161
Avoid if (x != y) ..; else ..; 116123
Avoid if (x != y) ..; else ..; 147160

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIPanel.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2728

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIPanelBase.java

Violation Line
Avoid if (x != y) ..; else ..; 4953

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIPopup.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2729

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIProgress.java

Violation Line
Avoid unused private fields such as 'LOG'. 42
Parameter 'event' is not assigned and could be declared final 56
Local variable 'model' could be declared final 61
Local variable 'm' could be declared final 63
Do not add empty strings 75
Avoid if (x != y) ..; else ..; 7781

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIRow.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2728

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIScript.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 3132

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISection.java

Violation Line
Parameter 'context' is not assigned and could be declared final 58
Avoid if (x != y) ..; else ..; 6266
Parameter 'level' is not assigned and could be declared final 76

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISegmentLayout.java

Violation Line
Local variable 'builder' could be declared final 36

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectBooleanCheckbox.java

Violation Line
These nested if statements could be combined 5764

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectOneBase.java

Violation Line
Avoid if (x != y) ..; else ..; 4451

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISeparator.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2930

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISheet.java

Violation Line
Possible God class (WMC=122, ATFD=39, TCC=0.014396456256921373) 20574
A high number of imports can indicate a high degree of coupling within an object. 20574
The class 'AbstractUISheet' has a Cyclomatic Complexity of 3 (Highest = 19). 68574
The class 'AbstractUISheet' has a Modified Cyclomatic Complexity of 2 (Highest = 12). 68574
The class 'AbstractUISheet' has a Standard Cyclomatic Complexity of 3 (Highest = 17). 68574
This class has too many methods, consider refactoring it. 70574
Avoid if (x != y) ..; else ..; 9094
Parameter 'event' is not assigned and could be declared final 131
Local variable 'layoutToken' could be declared final 143
Avoid if (x != y) ..; else ..; 269273
Avoid if (x != y) ..; else ..; 279287
Avoid if (x != y) ..; else ..; 300308
Avoid if (x != y) ..; else ..; 307
Avoid if (x != y) ..; else ..; 318
Local variable 'result' could be declared final 340
Parameter 'facesContext' is not assigned and could be declared final 396
Local variable 'columnSpan' could be declared final 420
Local variable 'rowSpan' could be declared final 421
Avoid instantiating new objects inside loops 422
Avoid if (x != y) ..; else ..; 432445
Avoid if (x != y) ..; else ..; 436439
The method 'performPaging' has a Cyclomatic Complexity of 19. 487548
The method 'performPaging' has a Standard Cyclomatic Complexity of 17. 487548
The method 'performPaging' has a Modified Cyclomatic Complexity of 12. 487548
A switch statement does not contain a break 495538
Avoid if (x != y) ..; else ..; 541545

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISuggest.java

Violation Line
Avoid if (x != y) ..; else ..; 6271
Parameter 'query' is not assigned and could be declared final 74
Avoid if (x != y) ..; else ..; 7684

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITabGroup.java

Violation Line
Possible God class (WMC=54, ATFD=20, TCC=0.0) 20280
The class 'AbstractUITabGroup' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 50280
The class 'AbstractUITabGroup' has a Modified Cyclomatic Complexity of 2 (Highest = 10). 50280
The class 'AbstractUITabGroup' has a Cyclomatic Complexity of 2 (Highest = 10). 50280
This class has too many methods, consider refactoring it. 51280
An empty method in an abstract class should be abstract instead 5657
Document empty method body 5657
The method 'processDecodes' has a Cyclomatic Complexity of 10. 104139
The method 'processDecodes' has a Standard Cyclomatic Complexity of 10. 104139
The method 'processDecodes' has a Modified Cyclomatic Complexity of 10. 104139
Use opposite operator instead of the logic complement operator. 105
Avoid if (x != y) ..; else ..; 105138
These nested if statements could be combined 118120
Use opposite operator instead of the logic complement operator. 143
Avoid if (x != y) ..; else ..; 143154
Avoid if (x != y) ..; else ..; 159171
Use opposite operator instead of the logic complement operator. 159
Use opposite operator instead of the logic complement operator. 192
Avoid if (x != y) ..; else ..; 200204

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITreeCommand.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2526

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITreeIndent.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2930

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITreeNode.java

Violation Line
An empty method in an abstract class should be abstract instead 2830

Tobago Core - org/apache/myfaces/tobago/internal/config/ContentSecurityPolicy.java

Violation Line
Avoid using redundant field initializer for 'unmodifiable' 31

Tobago Core - org/apache/myfaces/tobago/internal/config/RenderersConfigImpl.java

Violation Line
Avoid unused private fields such as 'LOG'. 37
Avoid using redundant field initializer for 'merged' 40
Avoid using redundant field initializer for 'unmodifiable' 42

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigBuilder.java

Violation Line
Parameter 'servletContext' is not assigned and could be declared final 52
Parameter 'configFragmentList' is not assigned and could be declared final 52
Avoid instantiating new objects inside loops 112

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigEntityResolver.java

Violation Line
Position literals first in String comparisons 53
Position literals first in String comparisons 55
Position literals first in String comparisons 57
Position literals first in String comparisons 59
Avoid if (x != y) ..; else ..; 6470

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigFragment.java

Violation Line
Too many fields 33213
Avoid unused private fields such as 'LOG'. 35
Private field 'before' could be made final; it is only initialized in the declaration or constructor. 38
Private field 'after' could be made final; it is only initialized in the declaration or constructor. 39
Private field 'supportedThemeNames' could be made final; it is only initialized in the declaration or constructor. 41
Private field 'themeDefinitions' could be made final; it is only initialized in the declaration or constructor. 50
Private field 'mimeTypes' could be made final; it is only initialized in the declaration or constructor. 55
Parameter 'sanitizerClass' is not assigned and could be declared final 181
Parameter 'sanitizerProperties' is not assigned and could be declared final 189
Parameter 'decodeLineFeed' is not assigned and could be declared final 197
Parameter 'extension' is not assigned and could be declared final 201
Parameter 'type' is not assigned and could be declared final 201
Avoid if (x != y) ..; else ..; 211

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigImpl.java

Violation Line
Possible God class (WMC=59, ATFD=17, TCC=0.0766488413547237) 20389
The class 'TobagoConfigImpl' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 48389
The class 'TobagoConfigImpl' has a Cyclomatic Complexity of 2 (Highest = 10). 48389
The class 'TobagoConfigImpl' has a Modified Cyclomatic Complexity of 2 (Highest = 10). 48389
Too many fields 48389
Private field 'contentSecurityPolicy' could be made final; it is only initialized in the declaration or constructor. 61
Avoid using redundant field initializer for 'unmodifiable' 69
Local variable 'theme' could be declared final 91
The method 'resolveThemes' has a Modified Cyclomatic Complexity of 10. 117159
The method 'resolveThemes' has a Cyclomatic Complexity of 10. 117159
The method 'resolveThemes' has a Standard Cyclomatic Complexity of 10. 117159
Avoid if (x != y) ..; else ..; 120147
Parameter 'availableTheme' is not assigned and could be declared final 204
Use block level rather than method level synchronization 232251
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 241
Parameter 'decodeLineFeed' is not assigned and could be declared final 332
StringBuffer constructor is initialized with size 16, but has at least 282 characters appended. 353
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 354
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 354
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 360
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 361
Avoid if (x != y) ..; else ..; 361
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 362
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 363
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 364
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 365
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 366
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 367
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 368
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 369
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 370
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 371
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 372
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 373
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 374
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 375
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 376
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 377
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 378
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 379
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 383
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 384
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 385

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigParser.java

Violation Line
Possible God class (WMC=106, ATFD=38, TCC=0.05454545454545454) 20465
The class 'TobagoConfigParser' has a Standard Cyclomatic Complexity of 6 (Highest = 32). 48465
The class 'TobagoConfigParser' has a Cyclomatic Complexity of 6 (Highest = 32). 48465
This class has too many methods, consider refactoring it. 48465
StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 95
Perhaps 'extension' could be replaced by a local variable. 98
Perhaps 'type' could be replaced by a local variable. 99
Document empty constructor 103104
The method 'startElement' has a Standard Cyclomatic Complexity of 16. 155258
The method 'startElement' has a Cyclomatic Complexity of 16. 155258
Avoid really long methods. 155258
A switch statement does not contain a break 164257
Avoid if (x != y) ..; else ..; 176180
The method endElement() has an NCSS line count of 116 266421
Avoid really long methods. 266421
The method 'endElement' has a Cyclomatic Complexity of 32. 266421
The method 'endElement' has a Standard Cyclomatic Complexity of 32. 266421
A switch statement does not contain a break 276305
Avoid if (x != y) ..; else ..; 292296

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigSorter.java

Violation Line
Possible God class (WMC=66, ATFD=66, TCC=0.20952380952380953) 20339
The class 'TobagoConfigSorter' has a Modified Cyclomatic Complexity of 5 (Highest = 19). 36339
The class 'TobagoConfigSorter' has a Standard Cyclomatic Complexity of 5 (Highest = 19). 36339
The class 'TobagoConfigSorter' has a Cyclomatic Complexity of 5 (Highest = 19). 36339
Private field 'list' could be made final; it is only initialized in the declaration or constructor. 40
Prefer StringBuffer over += for concatenating strings 66
The method 'merge' has a Cyclomatic Complexity of 19. 73166
The method 'merge' has a Modified Cyclomatic Complexity of 19. 73166
The method 'merge' has a Standard Cyclomatic Complexity of 19. 73166
The method merge() has an NPath complexity of 49155 73166
Local variable 'theme' could be declared final 137
Avoid instantiation through private constructors from outside of the constructors class. 177
Avoid instantiating new objects inside loops 177
Avoid instantiating new objects inside loops 188
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 189
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 190
The String literal "' < '" appears 4 times in this file; the first occurrence is on line 191 191
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 191
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 192
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 193
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 193
Avoid appending characters as strings in StringBuffer.append. 196
Avoid instantiating new objects inside loops 212
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 213
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 214
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 215
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 216
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 217
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 218
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 219
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 220
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 221
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 221
Avoid appending characters as strings in StringBuffer.append. 224
Avoid instantiation through private constructors from outside of the constructors class. 257
Avoid instantiating new objects inside loops 257
Avoid instantiating new objects inside loops 263
Avoid instantiation through private constructors from outside of the constructors class. 263
Parameter 'map' is not assigned and could be declared final 291
Parameter 'tobagoConfig' is not assigned and could be declared final 291

Tobago Core - org/apache/myfaces/tobago/internal/context/DateTimeI18n.java

Violation Line
A class which only has private constructors should be final 31106
Parameter 'locale' is not assigned and could be declared final 44
Unnecessary use of fully qualified name 'java.util.Calendar.MONTH' due to existing import 'java.util.Calendar' 56
Parameter 'locale' is not assigned and could be declared final 73
Use block level rather than method level synchronization 7381

Tobago Core - org/apache/myfaces/tobago/internal/layout/Grid.java

Violation Line
The class 'Grid' has a Standard Cyclomatic Complexity of 6 (Highest = 51). 30448
The class 'Grid' has a Cyclomatic Complexity of 6 (Highest = 55). 30448
The class 'Grid' has a Modified Cyclomatic Complexity of 6 (Highest = 51). 30448
Private field 'cells' could be made final; it is only initialized in the declaration or constructor. 38
Private field 'columns' could be made final; it is only initialized in the declaration or constructor. 40
Private field 'rows' could be made final; it is only initialized in the declaration or constructor. 41
Private field 'columnCount' could be made final; it is only initialized in the declaration or constructor. 43
Avoid instantiating new objects inside loops 101
The method 'gridAsString' has a Standard Cyclomatic Complexity of 51. 204432
The method 'gridAsString' has a Modified Cyclomatic Complexity of 51. 204432
The method gridAsString() has an NCSS line count of 175 204432
The method 'gridAsString' has a Cyclomatic Complexity of 55. 204432
Avoid really long methods. 204432
The method gridAsString() has an NPath complexity of 11503356 204432
StringBuffer constructor is initialized with size 16, but has at least 17 characters appended. 206
Avoid if (x != y) ..; else ..; 211215
Avoid appending characters as strings in StringBuffer.append. 212
Avoid appending characters as strings in StringBuffer.append. 214
Avoid appending characters as strings in StringBuffer.append. 220
Avoid appending characters as strings in StringBuffer.append. 223
Avoid appending characters as strings in StringBuffer.append. 226
Avoid appending characters as strings in StringBuffer.append. 228
Avoid appending characters as strings in StringBuffer.append. 230
Avoid if (x != y) ..; else ..; 235239
Avoid appending characters as strings in StringBuffer.append. 236
Avoid appending characters as strings in StringBuffer.append. 238
Avoid if (x != y) ..; else ..; 242246
Avoid appending characters as strings in StringBuffer.append. 243
Avoid appending characters as strings in StringBuffer.append. 245
Avoid appending characters as strings in StringBuffer.append. 247
Avoid appending characters as strings in StringBuffer.append. 258
Avoid appending characters as strings in StringBuffer.append. 261
Avoid appending characters as strings in StringBuffer.append. 264
Avoid appending characters as strings in StringBuffer.append. 266
Avoid appending characters as strings in StringBuffer.append. 268
Avoid appending characters as strings in StringBuffer.append. 283
Avoid appending characters as strings in StringBuffer.append. 285
Avoid appending characters as strings in StringBuffer.append. 288
Avoid appending characters as strings in StringBuffer.append. 293
Avoid appending characters as strings in StringBuffer.append. 295
Avoid appending characters as strings in StringBuffer.append. 297
Avoid appending characters as strings in StringBuffer.append. 302
Avoid appending characters as strings in StringBuffer.append. 304
Avoid appending characters as strings in StringBuffer.append. 308
Avoid appending characters as strings in StringBuffer.append. 310
Avoid appending characters as strings in StringBuffer.append. 319
Avoid appending characters as strings in StringBuffer.append. 321
Avoid appending characters as strings in StringBuffer.append. 327
Avoid appending characters as strings in StringBuffer.append. 330
Avoid appending characters as strings in StringBuffer.append. 333
Avoid appending characters as strings in StringBuffer.append. 335
Avoid appending characters as strings in StringBuffer.append. 337
Avoid appending characters as strings in StringBuffer.append. 341
Avoid if (x != y) ..; else ..; 347351
Avoid appending characters as strings in StringBuffer.append. 348
Avoid appending characters as strings in StringBuffer.append. 350
Avoid appending characters as strings in StringBuffer.append. 356
Avoid appending characters as strings in StringBuffer.append. 358
Avoid appending characters as strings in StringBuffer.append. 362
Avoid appending characters as strings in StringBuffer.append. 365
Avoid appending characters as strings in StringBuffer.append. 368
Avoid appending characters as strings in StringBuffer.append. 373
Avoid appending characters as strings in StringBuffer.append. 375
Avoid appending characters as strings in StringBuffer.append. 379
Avoid if (x != y) ..; else ..; 383387
Avoid appending characters as strings in StringBuffer.append. 384
Avoid appending characters as strings in StringBuffer.append. 386
Avoid appending characters as strings in StringBuffer.append. 388
Avoid if (x != y) ..; else ..; 394398
Avoid appending characters as strings in StringBuffer.append. 395
Avoid appending characters as strings in StringBuffer.append. 397
Avoid appending characters as strings in StringBuffer.append. 403
Avoid appending characters as strings in StringBuffer.append. 406
Avoid appending characters as strings in StringBuffer.append. 409
Avoid appending characters as strings in StringBuffer.append. 411
Avoid appending characters as strings in StringBuffer.append. 413
Avoid if (x != y) ..; else ..; 418422
Avoid appending characters as strings in StringBuffer.append. 419
Avoid appending characters as strings in StringBuffer.append. 421
Avoid if (x != y) ..; else ..; 424428
Avoid appending characters as strings in StringBuffer.append. 425
Avoid appending characters as strings in StringBuffer.append. 427
Avoid appending characters as strings in StringBuffer.append. 429

Tobago Core - org/apache/myfaces/tobago/internal/layout/LayoutUtils.java

Violation Line
Parameter 'component' is not assigned and could be declared final 85
Avoid if (x != y) ..; else ..; 8993
Avoid if (x != y) ..; else ..; 96100

Tobago Core - org/apache/myfaces/tobago/internal/layout/MathUtils.java

Violation Line
Avoid unused local variables such as 'ignored'. 42
Consider using varargs for methods or constructors which take an array the last parameter. 58
Consider using varargs for methods or constructors which take an array the last parameter. 75

Tobago Core - org/apache/myfaces/tobago/internal/layout/OriginCell.java

Violation Line
Private field 'component' could be made final; it is only initialized in the declaration or constructor. 26

Tobago Core - org/apache/myfaces/tobago/internal/layout/SpanCell.java

Violation Line
Private field 'origin' could be made final; it is only initialized in the declaration or constructor. 26
Private field 'horizontalFirst' could be made final; it is only initialized in the declaration or constructor. 27
Private field 'verticalFirst' could be made final; it is only initialized in the declaration or constructor. 28

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/Collapse.java

Violation Line
Private field 'action' could be made final; it is only initialized in the declaration or constructor. 24
Private field 'forId' could be made final; it is only initialized in the declaration or constructor. 25
Parameter 'action' is not assigned and could be declared final 27
Parameter 'forId' is not assigned and could be declared final 27

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/Command.java

Violation Line
The class 'Command' has a Cyclomatic Complexity of 2 (Highest = 13). 39264
The class 'Command' has a Standard Cyclomatic Complexity of 2 (Highest = 13). 39264
The class 'Command' has a Modified Cyclomatic Complexity of 2 (Highest = 13). 39264
Document empty constructor 5758
Avoid long parameter lists. 6063
Overridable method 'setExecute' called during object construction 67
Overridable method 'setRender' called during object construction 68
Parameter 'facetComponent' is not assigned and could be declared final 90
Do not add empty strings 129
Parameter 'execute' is not assigned and could be declared final 164
Parameter 'render' is not assigned and could be declared final 174
Parameter 'collapse' is not assigned and could be declared final 208
Parameter 'c' is not assigned and could be declared final 220
The method 'merge' has a Standard Cyclomatic Complexity of 13. 220263
The method merge() has an NPath complexity of 2304 220263
The method 'merge' has a Modified Cyclomatic Complexity of 13. 220263
The method 'merge' has a Cyclomatic Complexity of 13. 220263
Avoid if (x != y) ..; else ..; 234240
Avoid if (x != y) ..; else ..; 241247

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/CommandMap.java

Violation Line
Document empty constructor 4546
Avoid if (x != y) ..; else ..; 7680
Avoid if (x != y) ..; else ..; 99117
Local variable 'entry' could be declared final 107
Local variable 'key' could be declared final 108
Local variable 'value' could be declared final 109

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/BarRenderer.java

Violation Line
Parameter 'facesContext' is not assigned and could be declared final 49
Parameter 'component' is not assigned and could be declared final 49
Parameter 'component' is not assigned and could be declared final 79
Parameter 'facesContext' is not assigned and could be declared final 79
Local variable 'child' could be declared final 81
Parameter 'component' is not assigned and could be declared final 88
Local variable 'child' could be declared final 89
Parameter 'facesContext' is not assigned and could be declared final 101
Parameter 'component' is not assigned and could be declared final 101
Parameter 'facesContext' is not assigned and could be declared final 120
Parameter 'navbarId' is not assigned and could be declared final 120
Parameter 'bar' is not assigned and could be declared final 120
Parameter 'writer' is not assigned and could be declared final 120

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/BoxRenderer.java

Violation Line
The class 'BoxRenderer' has a Cyclomatic Complexity of 6 (Highest = 10). 41107
The method 'encodeBegin' has a Cyclomatic Complexity of 10. 4499
The method encodeBegin() has an NPath complexity of 220 4499

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/ButtonsRenderer.java

Violation Line
Parameter 'facesContext' is not assigned and could be declared final 46
Parameter 'component' is not assigned and could be declared final 46
Parameter 'facesContext' is not assigned and could be declared final 77
Parameter 'component' is not assigned and could be declared final 77
Local variable 'child' could be declared final 78
Parameter 'component' is not assigned and could be declared final 91
Parameter 'facesContext' is not assigned and could be declared final 91

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/ColumnRenderer.java

Violation Line
Avoid unused private methods such as 'isPure(UIColumn)'. 39

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/CommandRendererBase.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20251
The class 'CommandRendererBase' has a Modified Cyclomatic Complexity of 3 (Highest = 11). 57251
The class 'CommandRendererBase' has a Standard Cyclomatic Complexity of 3 (Highest = 11). 57251
The class 'CommandRendererBase' has a Cyclomatic Complexity of 3 (Highest = 11). 57251
Avoid unused private fields such as 'LOG'. 59
The method encodeBegin() has an NPath complexity of 864 62149
The method 'encodeBegin' has a Cyclomatic Complexity of 11. 62149
The method 'encodeBegin' has a Standard Cyclomatic Complexity of 11. 62149
The method 'encodeBegin' has a Modified Cyclomatic Complexity of 11. 62149
The method 'encodeChildren' has a Cyclomatic Complexity of 10. 157203
An empty method in an abstract class should be abstract instead 238240
Document empty method body 239240
An empty method in an abstract class should be abstract instead 244246
Document empty method body 245246
An empty method in an abstract class should be abstract instead 248250
Document empty method body 249250

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/DateRenderer.java

Violation Line
Parameter 'facesContext' is not assigned and could be declared final 61
Parameter 'component' is not assigned and could be declared final 61
Parameter 'component' is not assigned and could be declared final 78
Parameter 'facesContext' is not assigned and could be declared final 78

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/DecodingInputRendererBase.java

Violation Line
Local variable 'newValue' could be declared final 53

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/FigureRenderer.java

Violation Line
Parameter 'facesContext' is not assigned and could be declared final 44
Parameter 'component' is not assigned and could be declared final 44
Parameter 'facesContext' is not assigned and could be declared final 68
Parameter 'component' is not assigned and could be declared final 68

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/FileRenderer.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20208
Parameter 'event' is not assigned and could be declared final 63
Local variable 'httpServletRequest' could be declared final 83
Local variable 'parts' could be declared final 85
Local variable 'part' could be declared final 86
Avoid instantiating new objects inside loops 90
Avoid instantiating new objects inside loops 92
Parameter 'component' is not assigned and could be declared final 114
Parameter 'facesContext' is not assigned and could be declared final 114
Local variable 'multiFormat' could be declared final 157
Local variable 'validator' could be declared final 187
Avoid appending characters as strings in StringBuffer.append. 191
Parameter 'component' is not assigned and could be declared final 204
Parameter 'facesContext' is not assigned and could be declared final 204

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/FlexLayoutRenderer.java

Violation Line
Local variable 'b' could be declared final 45
Local variable 'vertically' could be declared final 83

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/FooterRenderer.java

Violation Line
Parameter 'component' is not assigned and could be declared final 43
Parameter 'facesContext' is not assigned and could be declared final 43
Parameter 'facesContext' is not assigned and could be declared final 63
Parameter 'component' is not assigned and could be declared final 63

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/GridLayoutRenderer.java

Violation Line
The class 'GridLayoutRenderer' has a Cyclomatic Complexity of 4 (Highest = 10). 47156
The class 'GridLayoutRenderer' has a Modified Cyclomatic Complexity of 4 (Highest = 10). 47156
The class 'GridLayoutRenderer' has a Standard Cyclomatic Complexity of 4 (Highest = 10). 47156
Avoid unused private fields such as 'LOG'. 49
StringBuffer constructor is initialized with size 16, but has at least 24 characters appended. 65
Avoid appending characters as strings in StringBuffer.append. 69
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 69
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 69
Avoid appending characters as strings in StringBuffer.append. 73
Local variable 'column' could be declared final 79
Avoid unused local variables such as 'column'. 79
The method 'encodeChildren' has a Modified Cyclomatic Complexity of 10. 93147
The method 'encodeChildren' has a Cyclomatic Complexity of 10. 93147
The method 'encodeChildren' has a Standard Cyclomatic Complexity of 10. 93147
Local variable 'builder' could be declared final 117
Avoid instantiating new objects inside loops 117
Avoid appending characters as strings in StringBuffer.append. 118
Avoid appending characters as strings in StringBuffer.append. 123
Avoid appending characters as strings in StringBuffer.append. 129
Avoid appending characters as strings in StringBuffer.append. 135

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/HeaderRenderer.java

Violation Line
Parameter 'component' is not assigned and could be declared final 43
Parameter 'facesContext' is not assigned and could be declared final 43
Parameter 'facesContext' is not assigned and could be declared final 66
Parameter 'component' is not assigned and could be declared final 66

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/HiddenRenderer.java

Violation Line
Parameter 'facesContext' is not assigned and could be declared final 39
Parameter 'component' is not assigned and could be declared final 39
Avoid if (x != y) ..; else ..; 60
Parameter 'facesContext' is not assigned and could be declared final 64
Parameter 'component' is not assigned and could be declared final 64

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/ImageRenderer.java

Violation Line
Local variable 'fontAwesome' could be declared final 52
Avoid if (x != y) ..; else ..; 62

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/InRenderer.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20216
The class 'InRenderer' has a Cyclomatic Complexity of 7 (Highest = 20). 56216
The class 'InRenderer' has a Modified Cyclomatic Complexity of 6 (Highest = 16). 56216
The class 'InRenderer' has a Standard Cyclomatic Complexity of 6 (Highest = 16). 56216
Parameter 'facesContext' is not assigned and could be declared final 61
The method 'encodeBeginField' has a Standard Cyclomatic Complexity of 16. 61164
The method encodeBeginField() has an NPath complexity of 122880 61164
Avoid really long methods. 61164
Parameter 'component' is not assigned and could be declared final 61
The method 'encodeBeginField' has a Cyclomatic Complexity of 20. 61164
The method 'encodeBeginField' has a Modified Cyclomatic Complexity of 16. 61164
Local variable 'regexValidator' could be declared final 119
Parameter 'writer' is not assigned and could be declared final 166
Parameter 'addon' is not assigned and could be declared final 166
Parameter 'facesContext' is not assigned and could be declared final 166
Parameter 'isAfterFacet' is not assigned and could be declared final 167
Local variable 'child' could be declared final 175
Parameter 'facesContext' is not assigned and could be declared final 205
Document empty method body 205206
Parameter 'component' is not assigned and could be declared final 205
Document empty method body 214215

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/LabelLayoutRendererBase.java

Violation Line
Possible God class (WMC=50, ATFD=39, TCC=0.0) 20229
The class 'LabelLayoutRendererBase' has a Standard Cyclomatic Complexity of 5 (Highest = 16). 46229
The class 'LabelLayoutRendererBase' has a Cyclomatic Complexity of 5 (Highest = 16). 46229
The method 'encodeBeginSurroundingLabel' has a Cyclomatic Complexity of 16. 96181
The method 'encodeBeginSurroundingLabel' has a Standard Cyclomatic Complexity of 16. 96181
The method encodeBeginSurroundingLabel() has an NPath complexity of 1440 96181
Avoid declaring a variable if it is unreferenced before a possible exit point. 99
A switch statement does not contain a break 114139
Prefer StringBuffer over += for concatenating strings 123
Prefer StringBuffer over += for concatenating strings 129
A switch statement does not contain a break 162180
Parameter 'labelLayout' is not assigned and could be declared final 205
Parameter 'component' is not assigned and could be declared final 205
Parameter 'writer' is not assigned and could be declared final 205
Local variable 'labelWithAccessKey' could be declared final 214
Parameter 'component' is not assigned and could be declared final 223

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/LabelRenderer.java

Violation Line
Parameter 'event' is not assigned and could be declared final 49
Avoid if (x != y) ..; else ..; 63

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/LinksRenderer.java

Violation Line
Parameter 'facesContext' is not assigned and could be declared final 39
Parameter 'component' is not assigned and could be declared final 39
Parameter 'facesContext' is not assigned and could be declared final 55
Parameter 'component' is not assigned and could be declared final 55
Local variable 'child' could be declared final 58
Parameter 'component' is not assigned and could be declared final 74
Parameter 'facesContext' is not assigned and could be declared final 74

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/MessageLayoutRendererBase.java

Violation Line
The class 'MessageLayoutRendererBase' has a Modified Cyclomatic Complexity of 4 (Highest = 20). 37194
The class 'MessageLayoutRendererBase' has a Cyclomatic Complexity of 4 (Highest = 20). 37194
The class 'MessageLayoutRendererBase' has a Standard Cyclomatic Complexity of 4 (Highest = 20). 37194
Local variable 'message' could be declared final 98
The method getTitle() has an NPath complexity of 930 114184
The method 'getTitle' has a Cyclomatic Complexity of 20. 114184
The method 'getTitle' has a Modified Cyclomatic Complexity of 20. 114184
The method 'getTitle' has a Standard Cyclomatic Complexity of 20. 114184
Local variable 'message' could be declared final 120
Local variable 'stringBuilder' could be declared final 132
Avoid appending characters as strings in StringBuffer.append. 148
Avoid appending characters as strings in StringBuffer.append. 160
Local variable 'stringBuilder' could be declared final 187
Local variable 'message' could be declared final 188

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/MessagesRenderer.java

Violation Line
The class 'MessagesRenderer' has a Cyclomatic Complexity of 10 (Highest = 10). 45178
The method 'encodeEnd' has a Cyclomatic Complexity of 10. 50146
Use equals() to compare object references. 92
Use equals() to compare object references. 96
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 120

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/PageRenderer.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20419
Possible God class (WMC=52, ATFD=142, TCC=0.0) 20419
The class 'PageRenderer' has a Standard Cyclomatic Complexity of 6 (Highest = 32). 76419
The class 'PageRenderer' has a Modified Cyclomatic Complexity of 6 (Highest = 32). 76419
The class 'PageRenderer' has a Cyclomatic Complexity of 6 (Highest = 35). 76419
The method 'encodeBegin' has a Modified Cyclomatic Complexity of 32. 99335
The method 'encodeBegin' has a Standard Cyclomatic Complexity of 32. 99335
Avoid really long methods. 99335
The method encodeBegin() has an NCSS line count of 146 99335
The method 'encodeBegin' has a Cyclomatic Complexity of 35. 99335
Deeply nested if..then statements are hard to read 167169
Avoid if (x != y) ..; else ..; 191
Local variable 'componentResources' could be declared final 222
Local variable 'childCount' could be declared final 224
Local variable 'child' could be declared final 225

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/PopupRenderer.java

Violation Line
Parameter 'component' is not assigned and could be declared final 45
The method encodeBegin() has an NPath complexity of 250 4591
Parameter 'facesContext' is not assigned and could be declared final 45
Avoid if (x != y) ..; else ..; 51
Local variable 'popupMarkup' could be declared final 51
Parameter 'facesContext' is not assigned and could be declared final 94
Parameter 'component' is not assigned and could be declared final 94

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/ProgressRenderer.java

Violation Line
Avoid unused private fields such as 'LOG'. 50
Local variable 'style' could be declared final 83

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/RowRenderer.java

Violation Line
Parameter 'component' is not assigned and could be declared final 31
Local variable 'uiComponent' could be declared final 34
Avoid if (x != y) ..; else ..; 3943

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/ScriptRenderer.java

Violation Line
Parameter 'event' is not assigned and could be declared final 40

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SectionRenderer.java

Violation Line
Local variable 'label' could be declared final 63
A switch statement does not contain a break 6583

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SegmentLayoutRenderer.java

Violation Line
Avoid unused private fields such as 'LOG'. 46
Avoid declaring a variable if it is unreferenced before a possible exit point. 70
Local variable 'child' could be declared final 83
Parameter 'child' is not assigned and could be declared final 115
Parameter 'generator' is not assigned and could be declared final 115
Parameter 'facesContext' is not assigned and could be declared final 115
Parameter 'writer' is not assigned and could be declared final 115

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectBooleanCheckboxInsideCommandRenderer.java

Violation Line
Document empty method body 4546

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectBooleanCheckboxRenderer.java

Violation Line
The String literal "true" appears 4 times in this file; the first occurrence is on line 67 67
Parameter 'component' is not assigned and could be declared final 73
Parameter 'facesContext' is not assigned and could be declared final 73
Parameter 'facesContext' is not assigned and could be declared final 141
Parameter 'component' is not assigned and could be declared final 141
Document empty method body 153154

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyCheckboxRenderer.java

Violation Line
The class 'SelectManyCheckboxRenderer' has a Standard Cyclomatic Complexity of 4 (Highest = 12). 44146
The class 'SelectManyCheckboxRenderer' has a Modified Cyclomatic Complexity of 4 (Highest = 12). 44146
The class 'SelectManyCheckboxRenderer' has a Cyclomatic Complexity of 4 (Highest = 12). 44146
The method 'encodeBeginField' has a Standard Cyclomatic Complexity of 12. 47131
The method 'encodeBeginField' has a Cyclomatic Complexity of 12. 47131
The method encodeBeginField() has an NPath complexity of 8340 47131
The method 'encodeBeginField' has a Modified Cyclomatic Complexity of 12. 47131
Avoid instantiating new objects inside loops 91
Avoid instantiating new objects inside loops 95
Document empty method body 144145

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyListboxRenderer.java

Violation Line
Avoid if (x != y) ..; else ..; 61

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyRendererBase.java

Violation Line
Possible God class (WMC=116, ATFD=71, TCC=0.0) 20806
A high number of imports can indicate a high degree of coupling within an object. 20806
The class 'SelectManyRendererBase' has a Standard Cyclomatic Complexity of 6 (Highest = 28). 57806
The class 'SelectManyRendererBase' has a Modified Cyclomatic Complexity of 6 (Highest = 28). 57806
The class 'SelectManyRendererBase' has a Cyclomatic Complexity of 6 (Highest = 31). 57806
Avoid if (x != y) ..; else ..; 74
Parameter 'input' is not assigned and could be declared final 90
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 122
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 123
Parameter 'facesContext' is not assigned and could be declared final 125
Parameter 'component' is not assigned and could be declared final 125
Consider using varargs for methods or constructors which take an array the last parameter. 126
Parameter 'submittedValue' is not assigned and could be declared final 126
Avoid really long methods. 143320
The method 'getConvertedUISelectManyValue' has a Standard Cyclomatic Complexity of 28. 143320
The method 'getConvertedUISelectManyValue' has a Cyclomatic Complexity of 31. 143320
Parameter 'component' is not assigned and could be declared final 143
The method getConvertedUISelectManyValue() has an NPath complexity of 2760 143320
The method 'getConvertedUISelectManyValue' has a Modified Cyclomatic Complexity of 28. 143320
Parameter 'facesContext' is not assigned and could be declared final 143
Parameter 'considerValueType' is not assigned and could be declared final 144
Parameter 'submittedValue' is not assigned and could be declared final 144
Local variable 'expression' could be declared final 154
Avoid if (x != y) ..; else ..; 165297
Local variable 'modelType' could be declared final 166167
Local variable 'componentType' could be declared final 173
Local variable 'iterator' could be declared final 203
Local variable 'collectionTypeAttr' could be declared final 207208
Avoid if (x != y) ..; else ..; 209289
Local variable 'collectionType' could be declared final 210
Local variable 'componentValue' could be declared final 238239
Local variable 'cloneMethod' could be declared final 244245
Local variable 'clone' could be declared final 246247
Avoid if (x != y) ..; else ..; 260262
Local variable 'isArray' could be declared final 301
Avoid if (x != y) ..; else ..; 305310
Parameter 'facesContext' is not assigned and could be declared final 370
Parameter 'component' is not assigned and could be declared final 370
Local variable 'valueTypeAttr' could be declared final 373
Local variable 'valueType' could be declared final 376
Parameter 'facesContext' is not assigned and could be declared final 410
Parameter 'iterator' is not assigned and could be declared final 410
Local variable 'item' could be declared final 417
Local variable 'groupIterator' could be declared final 419420
Local variable 'selectItemsType' could be declared final 423
Parameter 'component' is not assigned and could be declared final 448
Local variable 'builder' could be declared final 449
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 452
The String literal "{Component-Path : " appears 4 times in this file; the first occurrence is on line 452 452
Avoid appending characters as strings in StringBuffer.append. 460
Parameter 'component' is not assigned and could be declared final 465
Parameter 'builder' is not assigned and could be declared final 465
Local variable 'intBuilder' could be declared final 470
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 472
Avoid appending characters as strings in StringBuffer.append. 481
The class 'SelectItemsIterator' has a Standard Cyclomatic Complexity of 6 (Highest = 23). 496775
The class 'SelectItemsIterator' has a Cyclomatic Complexity of 6 (Highest = 27). 496775
The class 'SelectItemsIterator' has a Modified Cyclomatic Complexity of 6 (Highest = 23). 496775
Private field 'facesContext' could be made final; it is only initialized in the declaration or constructor. 514
Parameter 'facesContext' is not assigned and could be declared final 516
Parameter 'selectItemsParent' is not assigned and could be declared final 516
The method 'hasNext' has a Cyclomatic Complexity of 27. 525635
Avoid really long methods. 525635
The method 'hasNext' has a Standard Cyclomatic Complexity of 23. 525635
The method 'hasNext' has a Modified Cyclomatic Complexity of 23. 525635
The method hasNext() has an NPath complexity of 1662 525635
Local variable 'uiSelectItem' could be declared final 556
Local variable 'itemValue' could be declared final 560
Local variable 'description' could be declared final 562
Local variable 'disabled' could be declared final 563
Local variable 'escape' could be declared final 564
Local variable 'noSelectionOption' could be declared final 565
Local variable 'expression' could be declared final 571
Local variable 'value' could be declared final 581
Local variable 'length' could be declared final 590
Local variable 'items' could be declared final 591
Local variable 'map' could be declared final 602
Local variable 'items' could be declared final 603
Local variable 'entry' could be declared final 604
Avoid instantiating new objects inside loops 605
Local variable 'expression' could be declared final 614
Local variable 'objects' could be declared final 615619
Local variable 'message' could be declared final 620622
The method next() has an NPath complexity of 296 638711
The method 'next' has a Cyclomatic Complexity of 12. 638711
The method 'next' has a Standard Cyclomatic Complexity of 11. 638711
The method 'next' has a Modified Cyclomatic Complexity of 11. 638711
Local variable 'value' could be declared final 643
Local variable 'attributeMap' could be declared final 654
Local variable 'var' could be declared final 659
Local variable 'itemDisabled' could be declared final 686
Local variable 'itemLabelEscaped' could be declared final 687
Local variable 'noSelectionValue' could be declared final 688
Avoid if (x != y) ..; else ..; 699705
Parameter 'defaultValue' is not assigned and could be declared final 722
Parameter 'component' is not assigned and could be declared final 722
Parameter 'attrName' is not assigned and could be declared final 722
Local variable 'value' could be declared final 723
Parameter 'component' is not assigned and could be declared final 736
Local variable 'builder' could be declared final 737
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 740
Avoid appending characters as strings in StringBuffer.append. 748
Parameter 'component' is not assigned and could be declared final 753
Parameter 'builder' is not assigned and could be declared final 753
Local variable 'intBuilder' could be declared final 758
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 760
Avoid appending characters as strings in StringBuffer.append. 769

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyShuttleRenderer.java

Violation Line
Avoid unused local variables such as 'hasLabel'. 62
Avoid if (x != y) ..; else ..; 75

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectOneChoiceInsideInRenderer.java

Violation Line
Parameter 'facesContext' is not assigned and could be declared final 29
Parameter 'component' is not assigned and could be declared final 29
Parameter 'facesContext' is not assigned and could be declared final 34
Parameter 'component' is not assigned and could be declared final 34

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectOneChoiceRenderer.java

Violation Line
Parameter 'facesContext' is not assigned and could be declared final 51
Parameter 'component' is not assigned and could be declared final 51
Parameter 'facesContext' is not assigned and could be declared final 89
Parameter 'component' is not assigned and could be declared final 89

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectOneListboxRenderer.java

Violation Line
Avoid if (x != y) ..; else ..; 60
Parameter 'facesContext' is not assigned and could be declared final 92
Parameter 'component' is not assigned and could be declared final 92

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectOneRadioRenderer.java

Violation Line
The class 'SelectOneRadioRenderer' has a Cyclomatic Complexity of 4 (Highest = 14). 45159
The class 'SelectOneRadioRenderer' has a Modified Cyclomatic Complexity of 4 (Highest = 14). 45159
The class 'SelectOneRadioRenderer' has a Standard Cyclomatic Complexity of 4 (Highest = 14). 45159
The method 'encodeBeginField' has a Modified Cyclomatic Complexity of 14. 48144
The method 'encodeBeginField' has a Cyclomatic Complexity of 14. 48144
Parameter 'facesContext' is not assigned and could be declared final 48
Parameter 'component' is not assigned and could be declared final 48
The method 'encodeBeginField' has a Standard Cyclomatic Complexity of 14. 48144
The method encodeBeginField() has an NPath complexity of 24980 48144
Avoid instantiating new objects inside loops 93
Avoid instantiating new objects inside loops 97
Local variable 'tobagoItem' could be declared final 124
Parameter 'component' is not assigned and could be declared final 147
Parameter 'facesContext' is not assigned and could be declared final 147
Document empty method body 157158

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectReferenceRenderer.java

Violation Line
Avoid unused private fields such as 'LOG'. 35

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SeparatorRenderer.java

Violation Line
Avoid if (x != y) ..; else ..; 4562

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java

Violation Line
Possible God class (WMC=208, ATFD=457, TCC=0.004761904761904762) 201151
A high number of imports can indicate a high degree of coupling within an object. 201151
Avoid really long classes. 911151
The class 'SheetRenderer' has a Cyclomatic Complexity of 10 (Highest = 51). 911151
This class has too many methods, consider refactoring it. 911151
The class 'SheetRenderer' has a Standard Cyclomatic Complexity of 9 (Highest = 46). 911151
The class 'SheetRenderer' has a Modified Cyclomatic Complexity of 9 (Highest = 46). 911151
The method 'encodeBegin' has a Cyclomatic Complexity of 10. 147212
Avoid if (x != y) ..; else ..; 164168
Avoid if (x != y) ..; else ..; 170174
Avoid appending characters as strings in StringBuffer.append. 209
The method 'encodeEnd' has a Standard Cyclomatic Complexity of 33. 220463
Avoid really long methods. 220463
The method 'encodeEnd' has a Cyclomatic Complexity of 33. 220463
The method encodeEnd() has an NCSS line count of 174 220463
The method 'encodeEnd' has a Modified Cyclomatic Complexity of 33. 220463
The method encodeEnd() has an NPath complexity of 1158342528 220463
Local variable 'column' could be declared final 243
Avoid if (x != y) ..; else ..; 292341
Avoid if (x != y) ..; else ..; 389436
The method 'encodeTableBody' has a Standard Cyclomatic Complexity of 46. 465695
The method encodeTableBody() has an NCSS line count of 142 465695
Avoid really long methods. 465695
Avoid long parameter lists. 465467
Parameter 'sheet' is not assigned and could be declared final 465
The method 'encodeTableBody' has a Cyclomatic Complexity of 51. 465695
The method encodeTableBody() has an NPath complexity of 225665952 465695
Parameter 'facesContext' is not assigned and could be declared final 465
The method 'encodeTableBody' has a Modified Cyclomatic Complexity of 46. 465695
Parameter 'sheetId' is not assigned and could be declared final 465
Parameter 'writer' is not assigned and could be declared final 465
Parameter 'columnWidths' is not assigned and could be declared final 466
Parameter 'selectable' is not assigned and could be declared final 466
Parameter 'selectedRows' is not assigned and could be declared final 466
Parameter 'autoLayout' is not assigned and could be declared final 467
Parameter 'columns' is not assigned and could be declared final 467
Parameter 'expandedValue' is not assigned and could be declared final 467
Local variable 'sheetMarkup' could be declared final 471
Avoid if (x != y) ..; else ..; 471
Avoid if (x != y) ..; else ..; 489
Avoid if (x != y) ..; else ..; 516
Avoid appending characters as strings in StringBuffer.append. 564
Avoid instantiating new objects inside loops 584
These nested if statements could be combined 597604
These nested if statements could be combined 614650
Local variable 'normalColumn' could be declared final 615
Local variable 'selector' could be declared final 626
Parameter 'idWithSuffix' is not assigned and could be declared final 697
Parameter 'writer' is not assigned and could be declared final 697
Parameter 'value' is not assigned and could be declared final 697
Local variable 'column' could be declared final 712
Avoid if (x != y) ..; else ..; 726
Parameter 'column' is not assigned and could be declared final 733
The method encodeHeaderRows() has an NPath complexity of 46385 750900
The method encodeHeaderRows() has an NCSS line count of 106 750900
The method 'encodeHeaderRows' has a Modified Cyclomatic Complexity of 23. 750900
Avoid really long methods. 750900
The method 'encodeHeaderRows' has a Standard Cyclomatic Complexity of 25. 750900
The method 'encodeHeaderRows' has a Cyclomatic Complexity of 29. 750900
Avoid if (x != y) ..; else ..; 789805
A switch statement does not contain a break 790802
String.indexOf(char) is faster than String.indexOf(String). 819
Prefer StringBuffer over += for concatenating strings 835
Prefer StringBuffer over += for concatenating strings 837
Prefer StringBuffer over += for concatenating strings 854
These nested if statements could be combined 883885
Parameter 'isHeader' is not assigned and could be declared final 916
Local variable 'column' could be declared final 920
The method encodeLink() has an NPath complexity of 200 9721009
Parameter 'icon' is not assigned and could be declared final 974
Parameter 'target' is not assigned and could be declared final 974
Parameter 'liClass' is not assigned and could be declared final 974
Avoid if (x != y) ..; else ..; 10021006
Avoid unused method parameters such as 'sheet'. 1015
The method encodeDirectPagingLinks() has an NPath complexity of 648000 10241097
The method 'encodeDirectPagingLinks' has a Cyclomatic Complexity of 23. 10241097
The method 'encodeDirectPagingLinks' has a Standard Cyclomatic Complexity of 20. 10241097
The method 'encodeDirectPagingLinks' has a Modified Cyclomatic Complexity of 20. 10241097
Avoid unused local variables such as 'command'. 1028
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 1069
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 1088
Parameter 'sheet' is not assigned and could be declared final 1121
Local variable 'reloadBehavior' could be declared final 1122
Parameter 'holder' is not assigned and could be declared final 1143

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/StyleRenderer.java

Violation Line
Parameter 'event' is not assigned and could be declared final 48

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SubviewRenderer.java

Violation Line
Document empty method body 4547

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SuggestRenderer.java

Violation Line
The class 'SuggestRenderer' has a Cyclomatic Complexity of 8 (Highest = 11). 49163
Parameter 'facesContext' is not assigned and could be declared final 54
Parameter 'component' is not assigned and could be declared final 54
The method 'encodeBegin' has a Cyclomatic Complexity of 11. 74133
Parameter 'facesContext' is not assigned and could be declared final 74
Parameter 'component' is not assigned and could be declared final 74
Avoid if (x != y) ..; else ..; 82106
Avoid if (x != y) ..; else ..; 116120
Avoid instantiating new objects inside loops 147

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TabGroupRenderer.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20339
Possible God class (WMC=53, ATFD=107, TCC=0.0) 20339
The class 'TabGroupRenderer' has a Standard Cyclomatic Complexity of 7 (Highest = 16). 70339
The class 'TabGroupRenderer' has a Modified Cyclomatic Complexity of 6 (Highest = 16). 70339
The class 'TabGroupRenderer' has a Cyclomatic Complexity of 8 (Highest = 19). 70339
Parameter 'event' is not assigned and could be declared final 77
A switch statement does not contain a break 87111
Avoid instantiating new objects inside loops 94
Avoid instantiating new objects inside loops 102
The method 'ensureRenderedActiveIndex' has a Cyclomatic Complexity of 10. 177211
The method 'ensureRenderedActiveIndex' has a Modified Cyclomatic Complexity of 10. 177211
The method 'ensureRenderedActiveIndex' has a Standard Cyclomatic Complexity of 10. 177211
Deeply nested if..then statements are hard to read 188190
Avoid if (x != y) ..; else ..; 205209
The method 'encodeHeader' has a Modified Cyclomatic Complexity of 16. 213302
The method 'encodeHeader' has a Cyclomatic Complexity of 19. 213302
The method 'encodeHeader' has a Standard Cyclomatic Complexity of 16. 213302
The method encodeHeader() has an NPath complexity of 19443 213302
Avoid instantiating new objects inside loops 228
Local variable 'image' could be declared final 276
Avoid if (x != y) ..; else ..; 284288
Parameter 'tabGroup' is not assigned and could be declared final 305
Parameter 'writer' is not assigned and could be declared final 305
Parameter 'facesContext' is not assigned and could be declared final 305
Parameter 'switchType' is not assigned and could be declared final 306
Parameter 'activeIndex' is not assigned and could be declared final 306
Parameter 'tab' is not assigned and could be declared final 336
Parameter 'facesContext' is not assigned and could be declared final 336

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TextareaRenderer.java

Violation Line
The class 'TextareaRenderer' has a Standard Cyclomatic Complexity of 7 (Highest = 15). 53174
The class 'TextareaRenderer' has a Modified Cyclomatic Complexity of 7 (Highest = 15). 53174
The class 'TextareaRenderer' has a Cyclomatic Complexity of 8 (Highest = 18). 53174
The method 'encodeBeginField' has a Cyclomatic Complexity of 18. 79167
The method 'encodeBeginField' has a Standard Cyclomatic Complexity of 15. 79167
The method 'encodeBeginField' has a Modified Cyclomatic Complexity of 15. 79167
The method encodeBeginField() has an NPath complexity of 6656 79167
Local variable 'regexValidator' could be declared final 128
Local variable 'placeholder' could be declared final 146
Prefer StringBuffer over += for concatenating strings 159
Prefer StringBuffer over += for concatenating strings 161
Prefer StringBuffer over += for concatenating strings 163
Parameter 'facesContext' is not assigned and could be declared final 170
Parameter 'component' is not assigned and could be declared final 170

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TobagoClientBehaviorRenderer.java

Violation Line
Parameter 'behavior' is not assigned and could be declared final 59
Parameter 'behaviorContext' is not assigned and could be declared final 59
Avoid declaring a variable if it is unreferenced before a possible exit point. 66
Local variable 'ajaxBehavior' could be declared final 75
Avoid if (x != y) ..; else ..; 8589
Prefer StringBuffer over += for concatenating strings 86
Local variable 'command' could be declared final 91
Local variable 'event' could be declared final 100
Avoid if (x != y) ..; else ..; 102109
Local variable 'child' could be declared final 136
Local variable 'event' could be declared final 138
Parameter 'component' is not assigned and could be declared final 148
Parameter 'behavior' is not assigned and could be declared final 148
Parameter 'context' is not assigned and could be declared final 148
Local variable 'ajaxBehavior' could be declared final 149
Parameter 'ajaxBehavior' is not assigned and could be declared final 157
Parameter 'component' is not assigned and could be declared final 157
Local variable 'event' could be declared final 159
Local variable 'isImmediate' could be declared final 160
Parameter 'component' is not assigned and could be declared final 165
Parameter 'ajaxBehavior' is not assigned and could be declared final 165
Parameter 'component' is not assigned and could be declared final 181
Parameter 'facesContext' is not assigned and could be declared final 181
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 194

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TreeIndentRenderer.java

Violation Line
Avoid declaring a variable if it is unreferenced before a possible exit point. 58

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TreeLabelRenderer.java

Violation Line
Avoid unused private fields such as 'LOG'. 42

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TreeListboxRenderer.java

Violation Line
The method encodeEnd() has an NPath complexity of 250 53144
Avoid if (x != y) ..; else ..; 103
Avoid if (x != y) ..; else ..; 104106
Avoid if (x != y) ..; else ..; 167176
Avoid if (x != y) ..; else ..; 171175

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TreeNodeRenderer.java

Violation Line
The class 'TreeNodeRenderer' has a Cyclomatic Complexity of 6 (Highest = 11). 51222
Avoid unused local variables such as 'expanded'. 76
Deeply nested if..then statements are hard to read 8991
Avoid if (x != y) ..; else ..; 97107
Avoid unused local variables such as 'markedValue'. 99
The method encodeBegin() has an NPath complexity of 217 112169
The method 'encodeBegin' has a Cyclomatic Complexity of 11. 112169
Avoid unused method parameters such as 'writer'. 196
Avoid unused method parameters such as 'expanded'. 196
Avoid unused method parameters such as 'facesContext'. 196
Avoid unused method parameters such as 'node'. 197
Parameter 'level' is not assigned and could be declared final 214
Parameter 'data' is not assigned and could be declared final 214
Parameter 'showRoot' is not assigned and could be declared final 214

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TreeRenderer.java

Violation Line
The class 'TreeRenderer' has a Cyclomatic Complexity of 4 (Highest = 10). 46162
The method 'encodeEnd' has a Cyclomatic Complexity of 10. 74161
The method encodeEnd() has an NPath complexity of 500 74161
Avoid declaring a variable if it is unreferenced before a possible exit point. 78
Avoid appending characters as strings in StringBuffer.append. 120
Avoid appending characters as strings in StringBuffer.append. 125

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TreeSelectRenderer.java

Violation Line
The class 'TreeSelectRenderer' has a Cyclomatic Complexity of 5 (Highest = 10). 47161
Avoid declaring a variable if it is unreferenced before a possible exit point. 56
The method 'encodeBegin' has a Cyclomatic Complexity of 10. 83151
Do not add empty strings 155
Document empty method body 159160

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/VerbatimRenderer.java

Violation Line
Avoid declaring a variable if it is unreferenced before a possible exit point. 37

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/InTagDeclaration.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 2095

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/MessagesTagDeclaration.java

Violation Line
The String literal "boolean" appears 4 times in this file; the first occurrence is on line 58 58

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/SegmentLayoutConstraintTagDeclaration.java

Violation Line
The String literal "java.lang.Integer" appears 8 times in this file; the first occurrence is on line 38 38

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/SegmentLayoutTagDeclaration.java

Violation Line
The String literal "org.apache.myfaces.tobago.layout.ColumnPartition" appears 4 times in this file; the first occurrence is on line 55 55

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/SheetTagDeclaration.java

Violation Line
The String literal "boolean" appears 4 times in this file; the first occurrence is on line 82 82

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/StyleTagDeclaration.java

Violation Line
The String literal "org.apache.myfaces.tobago.layout.Measure" appears 18 times in this file; the first occurrence is on line 75 75

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/SuggestTagDeclaration.java

Violation Line
The String literal "java.lang.Integer" appears 4 times in this file; the first occurrence is on line 88 88

Tobago Core - org/apache/myfaces/tobago/internal/util/AccessKeyLogger.java

Violation Line
getInstance method always creates a new object and hence does not comply to Singleton Design Pattern behaviour. Please review 4553
Parameter 'clientId' is not assigned and could be declared final 55
Local variable 'entry' could be declared final 76

Tobago Core - org/apache/myfaces/tobago/internal/util/ArrayUtils.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2234

Tobago Core - org/apache/myfaces/tobago/internal/util/AuthorizationHelper.java

Violation Line
The class 'AuthorizationHelper' has a Standard Cyclomatic Complexity of 5 (Highest = 13). 47227
The class 'AuthorizationHelper' has a Modified Cyclomatic Complexity of 5 (Highest = 12). 47227
The class 'AuthorizationHelper' has a Cyclomatic Complexity of 5 (Highest = 13). 47227
The method 'isAuthorized' has a Modified Cyclomatic Complexity of 10. 96129
The method 'isAuthorized' has a Standard Cyclomatic Complexity of 10. 96129
The method 'isAuthorized' has a Cyclomatic Complexity of 10. 96129
The method 'getSecurityAnnotation' has a Modified Cyclomatic Complexity of 12. 131191
The method 'getSecurityAnnotation' has a Standard Cyclomatic Complexity of 13. 131191
The method 'getSecurityAnnotation' has a Cyclomatic Complexity of 13. 131191
Parameter 'expression' is not assigned and could be declared final 131
Avoid if (x != y) ..; else ..; 147158
Local variable 'entry' could be declared final 148
A switch statement does not contain a break 163173
Parameter 'name' is not assigned and could be declared final 209
Parameter 'bean' is not assigned and could be declared final 209
Local variable 'method' could be declared final 219

Tobago Core - org/apache/myfaces/tobago/internal/util/CookieUtils.java

Violation Line
The class 'CookieUtils' has a Modified Cyclomatic Complexity of 7 (Highest = 12). 29120
A class which only has private constructors should be final 29120
The class 'CookieUtils' has a Cyclomatic Complexity of 7 (Highest = 12). 29120
The class 'CookieUtils' has a Standard Cyclomatic Complexity of 7 (Highest = 12). 29120
Parameter 'request' is not assigned and could be declared final 40
Local variable 'cookie' could be declared final 44
Deeply nested if..then statements are hard to read 5254
The method 'setThemeNameToCookie' has a Standard Cyclomatic Complexity of 12. 62103
The method 'setThemeNameToCookie' has a Modified Cyclomatic Complexity of 12. 62103
The method 'setThemeNameToCookie' has a Cyclomatic Complexity of 12. 62103
Parameter 'response' is not assigned and could be declared final 63
Parameter 'themeName' is not assigned and could be declared final 63
Parameter 'request' is not assigned and could be declared final 63
Local variable 'cookie' could be declared final 70
Deeply nested if..then statements are hard to read 7375
Deeply nested if..then statements are hard to read 7984
Deeply nested if..then statements are hard to read 8590
Local variable 'cookie' could be declared final 98

Tobago Core - org/apache/myfaces/tobago/internal/util/Deprecation.java

Violation Line
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 49

Tobago Core - org/apache/myfaces/tobago/internal/util/FastStringWriter.java

Violation Line
StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 27

Tobago Core - org/apache/myfaces/tobago/internal/util/HtmlRendererUtils.java

Violation Line
Possible God class (WMC=51, ATFD=49, TCC=0.0) 20273
The class 'HtmlRendererUtils' has a Standard Cyclomatic Complexity of 3 (Highest = 16). 51273
The class 'HtmlRendererUtils' has a Cyclomatic Complexity of 4 (Highest = 20). 51273
The class 'HtmlRendererUtils' has a Modified Cyclomatic Complexity of 3 (Highest = 16). 51273
Avoid unused private fields such as 'ERROR_FOCUS_KEY'. 54
Parameter 'image' is not assigned and could be declared final 95
Parameter 'label' is not assigned and could be declared final 95
Parameter 'writer' is not assigned and could be declared final 95
Parameter 'facesContext' is not assigned and could be declared final 107
Parameter 'disabled' is not assigned and could be declared final 107
Parameter 'writer' is not assigned and could be declared final 107
Parameter 'image' is not assigned and could be declared final 107
Parameter 'label' is not assigned and could be declared final 107
Prefer StringBuffer over += for concatenating strings 149
Prefer StringBuffer over += for concatenating strings 153
Avoid if (x != y) ..; else ..; 176
Avoid if (x != y) ..; else ..; 177
The method 'renderSelectItems' has a Modified Cyclomatic Complexity of 16. 180250
The method 'renderSelectItems' has a Cyclomatic Complexity of 20. 180250
The method 'renderSelectItems' has a Standard Cyclomatic Complexity of 16. 180250
The method renderSelectItems() has an NPath complexity of 9006 180250
Avoid instantiating new objects inside loops 230

Tobago Core - org/apache/myfaces/tobago/internal/util/HtmlWriterUtils.java

Violation Line
The class 'HtmlWriterUtils' has a Standard Cyclomatic Complexity of 7 (Highest = 10). 25124
The class 'HtmlWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14). 25124
The class 'HtmlWriterUtils' has a Modified Cyclomatic Complexity of 7 (Highest = 10). 25124
The method 'writeEncodedValue' has a Modified Cyclomatic Complexity of 10. 62123
The method 'writeEncodedValue' has a Cyclomatic Complexity of 14. 62123
The method 'writeEncodedValue' has a Standard Cyclomatic Complexity of 10. 62123
Avoid if (x != y) ..; else ..; 9599

Tobago Core - org/apache/myfaces/tobago/internal/util/HttpPartWrapper.java

Violation Line
Document empty constructor 3637
Parameter 'delegate' is not assigned and could be declared final 39
Parameter 'headerName' is not assigned and could be declared final 54
Parameter 'headerName' is not assigned and could be declared final 64
Parameter 'fileName' is not assigned and could be declared final 84
Local variable 'wrapped' could be declared final 89
Local variable 'm' could be declared final 91
Parameter 'context' is not assigned and could be declared final 107
Document empty method body 112113
Parameter 'context' is not assigned and could be declared final 112
Parameter 'state' is not assigned and could be declared final 112
Parameter 'newTransientValue' is not assigned and could be declared final 121
Document empty method body 121122

Tobago Core - org/apache/myfaces/tobago/internal/util/JQueryUtils.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2232
Parameter 'id' is not assigned and could be declared final 24
Parameter 'id' is not assigned and could be declared final 28

Tobago Core - org/apache/myfaces/tobago/internal/util/JavascriptWriterUtils.java

Violation Line
The class 'JavascriptWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14). 25120
The class 'JavascriptWriterUtils' has a Modified Cyclomatic Complexity of 7 (Highest = 10). 25120
The class 'JavascriptWriterUtils' has a Standard Cyclomatic Complexity of 7 (Highest = 10). 25120
The method 'writeEncodedValue' has a Modified Cyclomatic Complexity of 10. 58119
The method 'writeEncodedValue' has a Cyclomatic Complexity of 14. 58119
The method 'writeEncodedValue' has a Standard Cyclomatic Complexity of 10. 58119
Avoid if (x != y) ..; else ..; 9195

Tobago Core - org/apache/myfaces/tobago/internal/util/JndiUtils.java

Violation Line
Prefer StringBuffer over += for concatenating strings 57

Tobago Core - org/apache/myfaces/tobago/internal/util/JsonUtils.java

Violation Line
Possible God class (WMC=51, ATFD=26, TCC=0.0) 20296
The class 'JsonUtils' has a Modified Cyclomatic Complexity of 3 (Highest = 12). 40296
A class which only has private constructors should be final 40296
The class 'JsonUtils' has a Cyclomatic Complexity of 4 (Highest = 14). 40296
The class 'JsonUtils' has a Standard Cyclomatic Complexity of 3 (Highest = 12). 40296
This class has too many methods, consider refactoring it. 40296
Consider using varargs for methods or constructors which take an array the last parameter. 47
Avoid appending characters as strings in StringBuffer.append. 48
Avoid appending characters as strings in StringBuffer.append. 52
Parameter 'value' is not assigned and could be declared final 55
Consider using varargs for methods or constructors which take an array the last parameter. 55
Parameter 'builder' is not assigned and could be declared final 55
Avoid appending characters as strings in StringBuffer.append. 56
Avoid appending characters as strings in StringBuffer.append. 60
Avoid appending characters as strings in StringBuffer.append. 62
Avoid appending characters as strings in StringBuffer.append. 64
Avoid appending characters as strings in StringBuffer.append. 67
Parameter 'value' is not assigned and could be declared final 70
Parameter 'builder' is not assigned and could be declared final 70
Avoid appending characters as strings in StringBuffer.append. 71
Avoid appending characters as strings in StringBuffer.append. 75
Avoid appending characters as strings in StringBuffer.append. 80
Avoid appending characters as strings in StringBuffer.append. 84
Avoid appending characters as strings in StringBuffer.append. 88
Avoid appending characters as strings in StringBuffer.append. 92
Avoid appending characters as strings in StringBuffer.append. 96
Avoid appending characters as strings in StringBuffer.append. 100
Avoid appending characters as strings in StringBuffer.append. 114
Avoid appending characters as strings in StringBuffer.append. 134
The method 'encode' has a Cyclomatic Complexity of 14. 138191
The method 'encode' has a Modified Cyclomatic Complexity of 12. 138191
The method encode() has an NPath complexity of 4608 138191
The method 'encode' has a Standard Cyclomatic Complexity of 12. 138191
Avoid appending characters as strings in StringBuffer.append. 139
Avoid appending characters as strings in StringBuffer.append. 194
Avoid appending characters as strings in StringBuffer.append. 217
Avoid appending characters as strings in StringBuffer.append. 231
Consider using varargs for methods or constructors which take an array the last parameter. 235
Avoid appending characters as strings in StringBuffer.append. 254
Avoid appending characters as strings in StringBuffer.append. 273

Tobago Core - org/apache/myfaces/tobago/internal/util/JsonWriterUtils.java

Violation Line
The class 'JsonWriterUtils' has a Modified Cyclomatic Complexity of 7 (Highest = 10). 26125
The class 'JsonWriterUtils' has a Standard Cyclomatic Complexity of 7 (Highest = 10). 26125
The class 'JsonWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14). 26125
The method 'writeEncodedValue' has a Standard Cyclomatic Complexity of 10. 63124
The method 'writeEncodedValue' has a Modified Cyclomatic Complexity of 10. 63124
The method 'writeEncodedValue' has a Cyclomatic Complexity of 14. 63124
Avoid if (x != y) ..; else ..; 96100

Tobago Core - org/apache/myfaces/tobago/internal/util/MimeTypeUtils.java

Violation Line
The class 'MimeTypeUtils' has a Modified Cyclomatic Complexity of 8 (Highest = 21). 27106
The class 'MimeTypeUtils' has a Cyclomatic Complexity of 8 (Highest = 21). 27106
The class 'MimeTypeUtils' has a Standard Cyclomatic Complexity of 8 (Highest = 21). 27106
Avoid using redundant field initializer for 'additionalMimeTypes' 29
The method 'getMimeTypeForFile' has a Standard Cyclomatic Complexity of 21. 3696
The method 'getMimeTypeForFile' has a Cyclomatic Complexity of 21. 3696
The method getMimeTypeForFile() has an NPath complexity of 290 3696
The method 'getMimeTypeForFile' has a Modified Cyclomatic Complexity of 21. 3696
Local variable 'length' could be declared final 37
These nested if statements could be combined 8486
Local variable 'extension' could be declared final 91
Parameter 'servletContext' is not assigned and could be declared final 98
Singleton is not thread safe 99104

Tobago Core - org/apache/myfaces/tobago/internal/util/NumberUtils.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2234

Tobago Core - org/apache/myfaces/tobago/internal/util/ObjectUtils.java

Violation Line
A class which only has private constructors should be final 2232
Parameter 'o1' is not assigned and could be declared final 29
Parameter 'o2' is not assigned and could be declared final 29
Use equals() to compare object references. 30

Tobago Core - org/apache/myfaces/tobago/internal/util/PartUtils.java

Violation Line
Parameter 'part' is not assigned and could be declared final 45
Local variable 'cd' could be declared final 54
Local variable 'cdl' could be declared final 56
Local variable 'paramParser' could be declared final 58
Local variable 'params' could be declared final 6162
Avoid if (x != y) ..; else ..; 6574
Deeply nested if..then statements are hard to read 6574
The class 'ParameterParser' has a Cyclomatic Complexity of 4 (Highest = 10). 81330
Avoid using redundant field initializer for 'chars' 86
Avoid using redundant field initializer for 'pos' 91
Avoid using redundant field initializer for 'len' 96
Avoid using redundant field initializer for 'i1' 101
Avoid using redundant field initializer for 'i2' 106
Avoid using redundant field initializer for 'lowerCaseNames' 111
Parameter 'quoted' is not assigned and could be declared final 139
The method 'getToken' has a Cyclomatic Complexity of 10. 139161
Parameter 'ch' is not assigned and could be declared final 171
Consider using varargs for methods or constructors which take an array the last parameter. 171
Local variable 'element' could be declared final 173
Consider using varargs for methods or constructors which take an array the last parameter. 190
Consider using varargs for methods or constructors which take an array the last parameter. 214
Parameter 'b' is not assigned and could be declared final 244
Parameter 'separator' is not assigned and could be declared final 256
Parameter 'separator' is not assigned and could be declared final 272
The method 'parse' has a Cyclomatic Complexity of 10. 290329
Parameter 'offset' is not assigned and could be declared final 292
Parameter 'length' is not assigned and could be declared final 293
Parameter 'separator' is not assigned and could be declared final 294
Local variable 'params' could be declared final 299
Avoid instantiating new objects inside loops 307309
Avoid instantiating new objects inside loops 313315

Tobago Core - org/apache/myfaces/tobago/internal/util/RenderUtils.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20315
Possible God class (WMC=65, ATFD=49, TCC=0.0) 20315
The class 'RenderUtils' has a Cyclomatic Complexity of 6 (Highest = 11). 54315
The class 'RenderUtils' has a Modified Cyclomatic Complexity of 5 (Highest = 11). 54315
The class 'RenderUtils' has a Standard Cyclomatic Complexity of 5 (Highest = 11). 54315
The method 'decodedStateOfTreeData' has a Modified Cyclomatic Complexity of 11. 138189
The method 'decodedStateOfTreeData' has a Standard Cyclomatic Complexity of 11. 138189
The method decodedStateOfTreeData() has an NPath complexity of 330 138189
The method 'decodedStateOfTreeData' has a Cyclomatic Complexity of 11. 138189
This call to String.startsWith can be rewritten using String.charAt(0) 214
Avoid appending characters as strings in StringBuffer.append. 233
Avoid appending characters as strings in StringBuffer.append. 236
Avoid appending characters as strings in StringBuffer.append. 239
The method 'getBehaviorCommands' has a Cyclomatic Complexity of 10. 257292
Local variable 'behaviorMap' could be declared final 260
Local variable 'clientBehavior' could be declared final 264
Local variable 'clientBehavior' could be declared final 306

Tobago Core - org/apache/myfaces/tobago/internal/util/ResponseUtils.java

Violation Line
The class 'ResponseUtils' has a Cyclomatic Complexity of 3 (Highest = 10). 33145
Avoid if (x != y) ..; else ..; 7283
The method 'ensureContentSecurityPolicyHeader' has a Cyclomatic Complexity of 10. 97132
Avoid declaring a variable if it is unreferenced before a possible exit point. 101
Avoid appending characters as strings in StringBuffer.append. 120
These nested if statements could be combined 128130

Tobago Core - org/apache/myfaces/tobago/internal/util/ResponseWriterBuffer.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 62

Tobago Core - org/apache/myfaces/tobago/internal/util/SelectItemUtils.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 45282
Avoid instantiation through private constructors from outside of the constructors class. 61
Local variable 'selectItem' could be declared final 80
The class 'SelectItemsIterator' has a Modified Cyclomatic Complexity of 8 (Highest = 19). 87280
The class 'SelectItemsIterator' has a Cyclomatic Complexity of 9 (Highest = 21). 87280
The class 'SelectItemsIterator' has a Standard Cyclomatic Complexity of 8 (Highest = 19). 87280
The method hasNext() has an NPath complexity of 864 102194
The method 'hasNext' has a Standard Cyclomatic Complexity of 19. 102194
The method 'hasNext' has a Modified Cyclomatic Complexity of 19. 102194
The method 'hasNext' has a Cyclomatic Complexity of 21. 102194
Local variable 'tobagoSelectItem' could be declared final 148149
Local variable 'expression' could be declared final 155
Local variable 'entry' could be declared final 186
Avoid instantiating new objects inside loops 187
The method 'next' has a Cyclomatic Complexity of 13. 197274
The method 'next' has a Modified Cyclomatic Complexity of 12. 197274
The method next() has an NPath complexity of 584 197274
The method 'next' has a Standard Cyclomatic Complexity of 12. 197274
Avoid unused local variables such as 'attributeMap'. 213
Avoid if (x != y) ..; else ..; 264268

Tobago Core - org/apache/myfaces/tobago/internal/util/StringUtils.java

Violation Line
Possible God class (WMC=125, ATFD=12, TCC=0.0) 20573
The class 'StringUtils' has a Standard Cyclomatic Complexity of 4 (Highest = 18). 27573
This class has too many methods, consider refactoring it. 27573
The class 'StringUtils' has a Cyclomatic Complexity of 4 (Highest = 18). 27573
The class 'StringUtils' has a Modified Cyclomatic Complexity of 4 (Highest = 18). 27573
Avoid instantiating Integer objects. Call Integer.valueOf() instead. 45
Avoid instantiating new objects inside loops 45
Avoid appending characters as strings in StringBuffer.append. 57
The method equalsIgnoreCaseAndWhitespace() has an NPath complexity of 378 125179
The method 'equalsIgnoreCaseAndWhitespace' has a Standard Cyclomatic Complexity of 11. 125179
The method 'equalsIgnoreCaseAndWhitespace' has a Modified Cyclomatic Complexity of 11. 125179
The method 'equalsIgnoreCaseAndWhitespace' has a Cyclomatic Complexity of 14. 125179
Use equals() to compare object references. 128
The method 'split' has a Modified Cyclomatic Complexity of 18. 233308
The method 'split' has a Cyclomatic Complexity of 18. 233308
The method 'split' has a Standard Cyclomatic Complexity of 18. 233308
Avoid declaring a variable if it is unreferenced before a possible exit point. 234
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 381
No need to call String.valueOf to append to a string. 420
Parameter 'b' is not assigned and could be declared final 470
Parameter 'a' is not assigned and could be declared final 470
Local variable 'colon' could be declared final 481
Parameter 'string' is not assigned and could be declared final 493
Parameter 'prefix' is not assigned and could be declared final 493
The method 'containsAny' has a Cyclomatic Complexity of 11. 526558
Parameter 'str' is not assigned and could be declared final 526
Parameter 'searchChars' is not assigned and could be declared final 526
Local variable 'searchChars1' could be declared final 530
Local variable 'csLength' could be declared final 534
Local variable 'searchLength' could be declared final 535
Local variable 'csLast' could be declared final 536
Local variable 'searchLast' could be declared final 537
Local variable 'ch' could be declared final 539
Parameter 'ch' is not assigned and could be declared final 569

Tobago Core - org/apache/myfaces/tobago/internal/webapp/DebugContentTypeFilter.java

Violation Line
Document empty method body 6163

Tobago Core - org/apache/myfaces/tobago/internal/webapp/DebugContentTypeResponse.java

Violation Line
These nested if statements could be combined 5557
These nested if statements could be combined 6567

Tobago Core - org/apache/myfaces/tobago/internal/webapp/DebugResponseWriterWrapper.java

Violation Line
This class has too many methods, consider refactoring it. 39250
Private field 'stack' could be made final; it is only initialized in the declaration or constructor. 41
Private field 'usedAttributes' could be made final; it is only initialized in the declaration or constructor. 42
Parameter 'string' is not assigned and could be declared final 113
Parameter 'name' is not assigned and could be declared final 113

Tobago Core - org/apache/myfaces/tobago/internal/webapp/HtmlResponseWriter.java

Violation Line
This class has too many methods, consider refactoring it. 35166
Private field 'javascriptWriter' could be made final; it is only initialized in the declaration or constructor. 40
Document empty method body 164165

Tobago Core - org/apache/myfaces/tobago/internal/webapp/LoggingMdcFilter.java

Violation Line
Local variable 'httpRequest' could be declared final 52
Local variable 'session' could be declared final 53
Local variable 'remoteAddr' could be declared final 57
Local variable 'remoteUser' could be declared final 61
Document empty method body 7577

Tobago Core - org/apache/myfaces/tobago/internal/webapp/TobagoResponseWriterBase.java

Violation Line
Possible God class (WMC=64, ATFD=16, TCC=0.1339031339031339) 20369
This class has too many methods, consider refactoring it. 36368
Avoid using redundant field initializer for 'i' 44
Avoid using redundant field initializer for 'inlineStack' 46
Avoid if (x != y) ..; else ..; 63
Avoid if (x != y) ..; else ..; 88111
Avoid if (x != y) ..; else ..; 90111
Avoid if (x != y) ..; else ..; 91104
Avoid if (x != y) ..; else ..; 9397
An empty method in an abstract class should be abstract instead 173175
An empty method in an abstract class should be abstract instead 178180

Tobago Core - org/apache/myfaces/tobago/internal/webapp/TobagoResponseWriterWrapper.java

Violation Line
This class has too many methods, consider refactoring it. 32150
Private field 'responseWriter' could be made final; it is only initialized in the declaration or constructor. 34
Parameter 'name' is not assigned and could be declared final 46
Parameter 'name' is not assigned and could be declared final 56
Parameter 'name' is not assigned and could be declared final 132
Parameter 'string' is not assigned and could be declared final 132

Tobago Core - org/apache/myfaces/tobago/internal/webapp/XmlResponseWriter.java

Violation Line
Avoid unused private fields such as 'XHTML_DOCTYPE'. 31

Tobago Core - org/apache/myfaces/tobago/layout/ColumnPartition.java

Violation Line
Parameter 'parts' is not assigned and could be declared final 43
Parameter 'string' is not assigned and could be declared final 47
Parameter 'object' is not assigned and could be declared final 52
Avoid if (x != y) ..; else ..; 5761
Consider using varargs for methods or constructors which take an array the last parameter. 64
Local variable 'summand' could be declared final 69
Parameter 'summands' is not assigned and could be declared final 81
Consider using varargs for methods or constructors which take an array the last parameter. 81
Parameter 'summands' is not assigned and could be declared final 85
Local variable 'list' could be declared final 86
Avoid declaring a variable if it is unreferenced before a possible exit point. 86
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 87
Consider using varargs for methods or constructors which take an array the last parameter. 111
Parameter 'parts' is not assigned and could be declared final 111

Tobago Core - org/apache/myfaces/tobago/layout/LayoutTokens.java

Violation Line
Private field 'tokens' could be made final; it is only initialized in the declaration or constructor. 35
Document empty constructor 3738
Consider using varargs for methods or constructors which take an array the last parameter. 69
Avoid appending characters as strings in StringBuffer.append. 141

Tobago Core - org/apache/myfaces/tobago/layout/Measure.java

Violation Line
Parameter 'i' is not assigned and could be declared final 45
Parameter 'unit' is not assigned and could be declared final 45
Parameter 'd' is not assigned and could be declared final 51
Parameter 'unit' is not assigned and could be declared final 51
Parameter 'string' is not assigned and could be declared final 57
Parameter 'unit' is not assigned and could be declared final 57
Avoid if (x != y) ..; else ..; 130
Avoid if (x != y) ..; else ..; 130
Do not add empty strings 130
Parameter 'o' is not assigned and could be declared final 138
Local variable 'measure' could be declared final 146
Avoid if (x != y) ..; else ..; 148
Avoid if (x != y) ..; else ..; 151
Avoid if (x != y) ..; else ..; 160
Avoid if (x != y) ..; else ..; 161

Tobago Core - org/apache/myfaces/tobago/layout/PixelMeasure.java

Violation Line
Avoid instantiating new objects inside loops 35
Avoid unnecessary if..then..else statements when returning booleans 6769

Tobago Core - org/apache/myfaces/tobago/layout/RelativeLayoutToken.java

Violation Line
Private field 'factor' could be made final; it is only initialized in the declaration or constructor. 29
Avoid unnecessary if..then..else statements when returning booleans 5355

Tobago Core - org/apache/myfaces/tobago/lifecycle/SecretPhaseListener.java

Violation Line
Document empty method body 5152

Tobago Core - org/apache/myfaces/tobago/model/CalendarModel.java

Violation Line
Private field 'calendarArray' could be made final; it is only initialized in the declaration or constructor. 28
Private field 'firstDayOffset' could be made final; it is only initialized in the declaration or constructor. 29
Avoid instantiating new objects inside loops 43
Avoid appending characters as strings in StringBuffer.append. 77
When instantiating a SimpleDateFormat object, specify a Locale 80
Avoid appending characters as strings in StringBuffer.append. 84
Avoid appending characters as strings in StringBuffer.append. 86
Avoid appending characters as strings in StringBuffer.append. 90
Avoid appending characters as strings in StringBuffer.append. 92

Tobago Core - org/apache/myfaces/tobago/model/DateModel.java

Violation Line
Avoid if (x != y) ..; else ..; 7273

Tobago Core - org/apache/myfaces/tobago/model/ExpandedState.java

Violation Line
This class has too many methods, consider refactoring it. 34252
Private field 'expandedSet' could be made final; it is only initialized in the declaration or constructor. 37
Private field 'collapsedSet' could be made final; it is only initialized in the declaration or constructor. 38

Tobago Core - org/apache/myfaces/tobago/model/ScrollPosition.java

Violation Line
Avoid if (x != y) ..; else ..; 36
Avoid if (x != y) ..; else ..; 36
String.indexOf(char) is faster than String.indexOf(String). 49
Parameter 'left' is not assigned and could be declared final 63
Parameter 'top' is not assigned and could be declared final 71

Tobago Core - org/apache/myfaces/tobago/model/SelectItem.java

Violation Line
Parameter 'tip' is not assigned and could be declared final 84
Parameter 'style' is not assigned and could be declared final 112
Parameter 'customClass' is not assigned and could be declared final 122

Tobago Core - org/apache/myfaces/tobago/model/SelectedState.java

Violation Line
Private field 'selected' could be made final; it is only initialized in the declaration or constructor. 32

Tobago Core - org/apache/myfaces/tobago/model/SheetState.java

Violation Line
Avoid unused private fields such as 'LOG'. 36
Overridable method 'reset' called during object construction 51
Avoid if (x != y) ..; else ..; 6771
Local variable 'columnWidth' could be declared final 118
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 123
Parameter 'toBeSorted' is not assigned and could be declared final 181

Tobago Core - org/apache/myfaces/tobago/model/SuggestFilter.java

Violation Line
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 40

Tobago Core - org/apache/myfaces/tobago/model/TreeNodeDataModel.java

Violation Line
Possible God class (WMC=57, ATFD=27, TCC=0.10666666666666667) 20306
Private field 'mapping' could be made final; it is only initialized in the declaration or constructor. 43
Private field 'back' could be made final; it is only initialized in the declaration or constructor. 44
Private field 'showRoot' could be made final; it is only initialized in the declaration or constructor. 45
Overridable method 'reset' called during object construction 59
Avoid instantiating new objects inside loops 69
Avoid instantiation through private constructors from outside of the constructors class. 69
Avoid instantiation through private constructors from outside of the constructors class. 89
Avoid instantiating new objects inside loops 89
Avoid instantiating new objects inside loops 210
Avoid if (x != y) ..; else ..; 240244
Private field 'node' could be made final; it is only initialized in the declaration or constructor. 287

Tobago Core - org/apache/myfaces/tobago/model/TreePath.java

Violation Line
Avoid if (x != y) ..; else ..; 126

Tobago Core - org/apache/myfaces/tobago/renderkit/RendererBase.java

Violation Line
Avoid if (x != y) ..; else ..; 6670
Document empty method body 7475

Tobago Core - org/apache/myfaces/tobago/renderkit/TobagoRenderKit.java

Violation Line
Private field 'renderers' could be made final; it is only initialized in the declaration or constructor. 53
Local variable 'rkFactory' could be declared final 56
Avoid instantiation through private constructors from outside of the constructors class. 66
Avoid instantiation through private constructors from outside of the constructors class. 102
Parameter 'type' is not assigned and could be declared final 116
Parameter 'renderer' is not assigned and could be declared final 116
Parameter 'type' is not assigned and could be declared final 121
Avoid unnecessary if..then..else statements when returning booleans 152154

Tobago Core - org/apache/myfaces/tobago/renderkit/css/BootstrapClass.java

Violation Line
Avoid using redundant field initializer for 'index' 383
Local variable 'result' could be declared final 407
Avoid if (x != y) ..; else ..; 423430
Consider using varargs for methods or constructors which take an array the last parameter. 433

Tobago Core - org/apache/myfaces/tobago/renderkit/css/Classes.java

Violation Line
Avoid unused private fields such as 'CACHE'. 67
Use block level rather than method level synchronization 81108
Avoid if (x != y) ..; else ..; 114
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 115
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 125

Tobago Core - org/apache/myfaces/tobago/renderkit/css/CustomClass.java

Violation Line
Avoid if (x != y) ..; else ..; 5568
Avoid if (x != y) ..; else ..; 5768
Avoid if (x != y) ..; else ..; 6165
Parameter 'text' is not assigned and could be declared final 93

Tobago Core - org/apache/myfaces/tobago/renderkit/css/FontAwesomeIconEncoder.java

Violation Line
Local variable 'icon' could be declared final 48
Avoid instantiating new objects inside loops 49
Local variable 'result' could be declared final 66
Private field 'name' could be made final; it is only initialized in the declaration or constructor. 91
Parameter 'name' is not assigned and could be declared final 93

Tobago Core - org/apache/myfaces/tobago/renderkit/css/Style.java

Violation Line
Possible God class (WMC=204, ATFD=26, TCC=0.3278886872353297) 201094
This class has a bunch of public methods and attributes 201094
The class 'Style' has a Cyclomatic Complexity of 2 (Highest = 28). 371094
Avoid really long classes. 371094
The class 'Style' has a Standard Cyclomatic Complexity of 2 (Highest = 28). 371094
Too many fields 371094
The class 'Style' has a Modified Cyclomatic Complexity of 2 (Highest = 28). 371094
Document empty constructor 108109
Overridable method 'checkEmptiness' called during object construction 150
Avoid really long methods. 205346
The method encode() has an NPath complexity of 100663296 205346
The method 'encode' has a Modified Cyclomatic Complexity of 28. 205346
The method 'encode' has a Standard Cyclomatic Complexity of 28. 205346
The method 'encode' has a Cyclomatic Complexity of 28. 205346
The method encode() has an NCSS line count of 114 205346
StringBuffer constructor is initialized with size 16, but has at least 26 characters appended. 208
Avoid if (x != y) ..; else ..; 210218
Avoid really long methods. 348517
The method encodeJson() has an NPath complexity of 134217728 348517
The method 'encodeJson' has a Modified Cyclomatic Complexity of 28. 348517
The method encodeJson() has an NCSS line count of 136 348517
The method 'encodeJson' has a Cyclomatic Complexity of 28. 348517
The method 'encodeJson' has a Standard Cyclomatic Complexity of 28. 348517
StringBuffer constructor is initialized with size 17, but has at least 78 characters appended. 349
The String literal "\"," appears 25 times in this file; the first occurrence is on line 355 355
Avoid appending characters as strings in StringBuffer.append. 502
Avoid if (x != y) ..; else ..; 520526
Avoid if (x != y) ..; else ..; 522526
Avoid if (x != y) ..; else ..; 540546
Avoid if (x != y) ..; else ..; 542546
Avoid if (x != y) ..; else ..; 560566
Avoid if (x != y) ..; else ..; 562566
Avoid if (x != y) ..; else ..; 580586
Avoid if (x != y) ..; else ..; 582586
Avoid if (x != y) ..; else ..; 600606
Avoid if (x != y) ..; else ..; 602606
Avoid if (x != y) ..; else ..; 620626
Avoid if (x != y) ..; else ..; 622626
Avoid if (x != y) ..; else ..; 640646
Avoid if (x != y) ..; else ..; 642646
Avoid if (x != y) ..; else ..; 660666
Avoid if (x != y) ..; else ..; 662666
Avoid if (x != y) ..; else ..; 680686
Avoid if (x != y) ..; else ..; 682686
Avoid if (x != y) ..; else ..; 700706
Avoid if (x != y) ..; else ..; 702706
Avoid if (x != y) ..; else ..; 720726
Avoid if (x != y) ..; else ..; 722726
Avoid if (x != y) ..; else ..; 740746
Avoid if (x != y) ..; else ..; 742746
Avoid if (x != y) ..; else ..; 760766
Avoid if (x != y) ..; else ..; 762766
Avoid if (x != y) ..; else ..; 780786
Avoid if (x != y) ..; else ..; 782786
Avoid if (x != y) ..; else ..; 800806
Avoid if (x != y) ..; else ..; 802806
Avoid if (x != y) ..; else ..; 820826
Avoid if (x != y) ..; else ..; 822826
Avoid if (x != y) ..; else ..; 840846
Avoid if (x != y) ..; else ..; 842846
Avoid if (x != y) ..; else ..; 860866
Avoid if (x != y) ..; else ..; 862866
Avoid if (x != y) ..; else ..; 880893
Avoid if (x != y) ..; else ..; 884888
Avoid if (x != y) ..; else ..; 889893
Avoid if (x != y) ..; else ..; 907920
Avoid if (x != y) ..; else ..; 911915
Avoid if (x != y) ..; else ..; 916920
Avoid if (x != y) ..; else ..; 934947
Avoid if (x != y) ..; else ..; 938942
Avoid if (x != y) ..; else ..; 943947
Avoid if (x != y) ..; else ..; 961974
Avoid if (x != y) ..; else ..; 965969
Avoid if (x != y) ..; else ..; 970974
Avoid if (x != y) ..; else ..; 989995
Avoid if (x != y) ..; else ..; 991995
Avoid if (x != y) ..; else ..; 10121018
Avoid if (x != y) ..; else ..; 10141018
Avoid if (x != y) ..; else ..; 10351048
Avoid if (x != y) ..; else ..; 10391043
Avoid if (x != y) ..; else ..; 10441048
Avoid if (x != y) ..; else ..; 10641077
Avoid if (x != y) ..; else ..; 10681072
Avoid if (x != y) ..; else ..; 10731077

Tobago Core - org/apache/myfaces/tobago/renderkit/css/TobagoClass.java

Violation Line
Parameter 'alignItems' is not assigned and could be declared final 179
Parameter 'justifyContent' is not assigned and could be declared final 201
Avoid if (x != y) ..; else ..; 225233
Avoid instantiating new objects inside loops 228

Tobago Core - org/apache/myfaces/tobago/renderkit/html/DataAttributes.java

Violation Line
Parameter 'value' is not assigned and could be declared final 210

Tobago Core - org/apache/myfaces/tobago/renderkit/html/HtmlAttributes.java

Violation Line
Parameter 'value' is not assigned and could be declared final 132

Tobago Core - org/apache/myfaces/tobago/renderkit/html/HtmlButtonTypes.java

Violation Line
Parameter 'value' is not assigned and could be declared final 30

Tobago Core - org/apache/myfaces/tobago/renderkit/html/HtmlInputTypes.java

Violation Line
Parameter 'value' is not assigned and could be declared final 37

Tobago Core - org/apache/myfaces/tobago/sanitizer/IgnoringSanitizer.java

Violation Line
Parameter 'html' is not assigned and could be declared final 35
Parameter 'configuration' is not assigned and could be declared final 40

Tobago Core - org/apache/myfaces/tobago/sanitizer/JsoupSanitizer.java

Violation Line
Avoid using redundant field initializer for 'unmodifiable' 39

Tobago Core - org/apache/myfaces/tobago/servlet/NonFacesRequestServlet.java

Violation Line
Avoid declaring a variable if it is unreferenced before a possible exit point. 61
An empty method in an abstract class should be abstract instead 9597

Tobago Core - org/apache/myfaces/tobago/servlet/ResourceServlet.java

Violation Line
Avoid instantiating Long objects.Call Long.valueOf() instead 88
Local variable 'resource' could be declared final 111
Avoid if (x != y) ..; else ..; 118128
Avoid if (x != y) ..; else ..; 142148
Avoid if (x != y) ..; else ..; 156160

Tobago Core - org/apache/myfaces/tobago/util/AjaxUtils.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3277
Local variable 'renderId' could be declared final 62
Parameter 'facesContext' is not assigned and could be declared final 71
Parameter 'outcome' is not assigned and could be declared final 71
Local variable 'navigationHandler' could be declared final 73

Tobago Core - org/apache/myfaces/tobago/util/BeanComparator.java

Violation Line
Private field 'property' could be made final; it is only initialized in the declaration or constructor. 35
Avoid if (x != y) ..; else ..; 69

Tobago Core - org/apache/myfaces/tobago/util/ComparatorBase.java

Violation Line
The class 'ComparatorBase' has a Modified Cyclomatic Complexity of 3 (Highest = 12). 27126
The class 'ComparatorBase' has a Cyclomatic Complexity of 3 (Highest = 14). 27126
The class 'ComparatorBase' has a Standard Cyclomatic Complexity of 3 (Highest = 12). 27126
Document empty constructor 3334
The method 'internalCompare' has a Cyclomatic Complexity of 14. 4989
The method 'internalCompare' has a Standard Cyclomatic Complexity of 12. 4989
The method 'internalCompare' has a Modified Cyclomatic Complexity of 12. 4989
The method internalCompare() has an NPath complexity of 1600 4989
Avoid if (x != y) ..; else ..; 7787
Avoid if (x != y) ..; else ..; 120

Tobago Core - org/apache/myfaces/tobago/util/ComponentUtils.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20884
Possible God class (WMC=191, ATFD=118, TCC=8.163265306122449E-4) 20884
This class has a bunch of public methods and attributes 20884
The class 'ComponentUtils' has a Modified Cyclomatic Complexity of 3 (Highest = 10). 68884
This class has too many methods, consider refactoring it. 68884
The class 'ComponentUtils' has a Cyclomatic Complexity of 3 (Highest = 10). 68884
The class 'ComponentUtils' has a Standard Cyclomatic Complexity of 3 (Highest = 10). 68884
Avoid if (x != y) ..; else ..; 152156
Avoid if (x != y) ..; else ..; 161171
Parameter 'component' is not assigned and could be declared final 219
Avoid if (x != y) ..; else ..; 277285
Local variable 'bool' could be declared final 451
Avoid if (x != y) ..; else ..; 468
Consider simply returning the value vs storing it in local variable 'myRenderer' 570
The method 'findComponent' has a Cyclomatic Complexity of 10. 609644
Consider using varargs for methods or constructors which take an array the last parameter. 650
Avoid if (x != y) ..; else ..; 684
The method 'getConvertedValue' has a Cyclomatic Complexity of 10. 692723
The method 'getConvertedValue' has a Standard Cyclomatic Complexity of 10. 692723
The method 'getConvertedValue' has a Modified Cyclomatic Complexity of 10. 692723
Avoid if (x != y) ..; else ..; 696718
Local variable 'map' could be declared final 820
Avoid if (x != y) ..; else ..; 821
These nested if statements could be combined 845847
Avoid if (x != y) ..; else ..; 867871

Tobago Core - org/apache/myfaces/tobago/util/CreateComponentUtils.java

Violation Line
Class cannot be instantiated and does not provide any static methods or fields 2227

Tobago Core - org/apache/myfaces/tobago/util/DebugNavigationHandler.java

Violation Line
Private field 'navigationHandler' could be made final; it is only initialized in the declaration or constructor. 32

Tobago Core - org/apache/myfaces/tobago/util/DebugPhaseListener.java

Violation Line
The class 'DebugPhaseListener' has a Cyclomatic Complexity of 10 (Highest = 16). 38156
The class 'DebugPhaseListener' has a Standard Cyclomatic Complexity of 8 (Highest = 13). 38156
The class 'DebugPhaseListener' has a Modified Cyclomatic Complexity of 8 (Highest = 13). 38156
The method 'afterPhase' has a Cyclomatic Complexity of 11. 4591
The method 'afterPhase' has a Standard Cyclomatic Complexity of 10. 4591
The method 'afterPhase' has a Modified Cyclomatic Complexity of 10. 4591
Deeply nested if..then statements are hard to read 6772
Deeply nested if..then statements are hard to read 7577
The method beforePhase() has an NPath complexity of 572 94150
The method 'beforePhase' has a Modified Cyclomatic Complexity of 13. 94150
The method 'beforePhase' has a Cyclomatic Complexity of 16. 94150
The method 'beforePhase' has a Standard Cyclomatic Complexity of 13. 94150
Avoid declaring a variable if it is unreferenced before a possible exit point. 96
Deeply nested if..then statements are hard to read 112128
Deeply nested if..then statements are hard to read 134144
Deeply nested if..then statements are hard to read 145147

Tobago Core - org/apache/myfaces/tobago/util/DebugUtils.java

Violation Line
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 57
Avoid appending characters as strings in StringBuffer.append. 80
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 80
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 81
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 82
Avoid appending characters as strings in StringBuffer.append. 82
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 90
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 91

Tobago Core - org/apache/myfaces/tobago/util/MessageFormat.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2776
Parameter 'param0' is not assigned and could be declared final 29
Parameter 'pattern' is not assigned and could be declared final 29
Parameter 'param1' is not assigned and could be declared final 33
Parameter 'pattern' is not assigned and could be declared final 33
Parameter 'param0' is not assigned and could be declared final 33
Parameter 'param1' is not assigned and could be declared final 37
Parameter 'param0' is not assigned and could be declared final 37
Parameter 'pattern' is not assigned and could be declared final 37
Parameter 'param2' is not assigned and could be declared final 37
Parameter 'pattern' is not assigned and could be declared final 41
Parameter 'param0' is not assigned and could be declared final 41
Parameter 'param3' is not assigned and could be declared final 41
Parameter 'param1' is not assigned and could be declared final 41
Parameter 'param2' is not assigned and could be declared final 41
Parameter 'pattern' is not assigned and could be declared final 45
Parameter 'param2' is not assigned and could be declared final 45
Parameter 'param3' is not assigned and could be declared final 45
Parameter 'param1' is not assigned and could be declared final 45
Parameter 'param0' is not assigned and could be declared final 45
Parameter 'param4' is not assigned and could be declared final 46
Parameter 'param1' is not assigned and could be declared final 50
Parameter 'param3' is not assigned and could be declared final 50
Parameter 'pattern' is not assigned and could be declared final 50
Parameter 'param0' is not assigned and could be declared final 50
Parameter 'param2' is not assigned and could be declared final 50
Parameter 'param5' is not assigned and could be declared final 51
Parameter 'param4' is not assigned and could be declared final 51
Parameter 'param2' is not assigned and could be declared final 55
Parameter 'param1' is not assigned and could be declared final 55
Parameter 'param3' is not assigned and could be declared final 55
Parameter 'param0' is not assigned and could be declared final 55
Parameter 'pattern' is not assigned and could be declared final 55
Parameter 'param5' is not assigned and could be declared final 56
Parameter 'param6' is not assigned and could be declared final 56
Parameter 'param4' is not assigned and could be declared final 56
Parameter 'param2' is not assigned and could be declared final 60
Parameter 'pattern' is not assigned and could be declared final 60
Parameter 'param3' is not assigned and could be declared final 60
Parameter 'param1' is not assigned and could be declared final 60
Parameter 'param0' is not assigned and could be declared final 60
Parameter 'param6' is not assigned and could be declared final 61
Parameter 'param4' is not assigned and could be declared final 61
Parameter 'param7' is not assigned and could be declared final 61
Parameter 'param5' is not assigned and could be declared final 61
Parameter 'param2' is not assigned and could be declared final 66
Avoid long parameter lists. 6667
Parameter 'param0' is not assigned and could be declared final 66
Parameter 'pattern' is not assigned and could be declared final 66
Parameter 'param3' is not assigned and could be declared final 66
Parameter 'param1' is not assigned and could be declared final 66
Parameter 'param5' is not assigned and could be declared final 67
Parameter 'param6' is not assigned and could be declared final 67
Parameter 'param7' is not assigned and could be declared final 67
Parameter 'param8' is not assigned and could be declared final 67
Parameter 'param4' is not assigned and could be declared final 67
Parameter 'pattern' is not assigned and could be declared final 72

Tobago Core - org/apache/myfaces/tobago/util/MessageUtils.java

Violation Line
The class 'MessageUtils' has a Modified Cyclomatic Complexity of 3 (Highest = 11). 43148
The class 'MessageUtils' has a Standard Cyclomatic Complexity of 3 (Highest = 11). 43148
The class 'MessageUtils' has a Cyclomatic Complexity of 4 (Highest = 15). 43148
Consider using varargs for methods or constructors which take an array the last parameter. 52
The method 'getMessage' has a Modified Cyclomatic Complexity of 11. 57104
The method getMessage() has an NPath complexity of 468 57104
The method 'getMessage' has a Standard Cyclomatic Complexity of 11. 57104
The method 'getMessage' has a Cyclomatic Complexity of 15. 57104
Deeply nested if..then statements are hard to read 7678
Deeply nested if..then statements are hard to read 7981
Avoid if (x != y) ..; else ..; 116

Tobago Core - org/apache/myfaces/tobago/util/ValueBindingComparator.java

Violation Line
The class 'ValueBindingComparator' has a Modified Cyclomatic Complexity of 3 (Highest = 10). 34131
The class 'ValueBindingComparator' has a Standard Cyclomatic Complexity of 3 (Highest = 10). 34131
The class 'ValueBindingComparator' has a Cyclomatic Complexity of 3 (Highest = 11). 34131
Private field 'facesContext' could be made final; it is only initialized in the declaration or constructor. 38
Private field 'var' could be made final; it is only initialized in the declaration or constructor. 40
Private field 'valueBinding' could be made final; it is only initialized in the declaration or constructor. 42
The method 'equals' has a Modified Cyclomatic Complexity of 10. 76100
The method 'equals' has a Standard Cyclomatic Complexity of 10. 76100
The method 'equals' has a Cyclomatic Complexity of 11. 76100
Avoid declaring a variable if it is unreferenced before a possible exit point. 84
Avoid if (x != y) ..; else ..; 89
Avoid if (x != y) ..; else ..; 92
Avoid unnecessary if..then..else statements when returning booleans 9597
Avoid if (x != y) ..; else ..; 95
Avoid if (x != y) ..; else ..; 104
Avoid if (x != y) ..; else ..; 105
Avoid if (x != y) ..; else ..; 106

Tobago Core - org/apache/myfaces/tobago/util/ValueExpressionComparator.java

Violation Line
The class 'ValueExpressionComparator' has a Cyclomatic Complexity of 3 (Highest = 11). 30128
The class 'ValueExpressionComparator' has a Modified Cyclomatic Complexity of 3 (Highest = 10). 30128
The class 'ValueExpressionComparator' has a Standard Cyclomatic Complexity of 3 (Highest = 10). 30128
Private field 'facesContext' could be made final; it is only initialized in the declaration or constructor. 34
Private field 'var' could be made final; it is only initialized in the declaration or constructor. 36
Private field 'valueExpression' could be made final; it is only initialized in the declaration or constructor. 38
The method 'equals' has a Cyclomatic Complexity of 11. 7498
The method 'equals' has a Modified Cyclomatic Complexity of 10. 7498
The method 'equals' has a Standard Cyclomatic Complexity of 10. 7498
Avoid declaring a variable if it is unreferenced before a possible exit point. 82
Avoid if (x != y) ..; else ..; 87
Avoid if (x != y) ..; else ..; 90
Avoid if (x != y) ..; else ..; 93
Avoid unnecessary if..then..else statements when returning booleans 9395
Avoid if (x != y) ..; else ..; 102
Avoid if (x != y) ..; else ..; 103
Avoid if (x != y) ..; else ..; 104

Tobago Core - org/apache/myfaces/tobago/util/XmlUtils.java

Violation Line
A switch statement does not contain a break 74100

Tobago Core - org/apache/myfaces/tobago/validator/FileItemValidator.java

Violation Line
The class 'FileItemValidator' has a Cyclomatic Complexity of 2 (Highest = 12). 40132
Avoid using redundant field initializer for 'maxSize' 44
Document empty constructor 5152
The method 'validate' has a Cyclomatic Complexity of 12. 5588
Deeply nested if..then statements are hard to read 6972
Deeply nested if..then statements are hard to read 7680
Consider using varargs for methods or constructors which take an array the last parameter. 104

Tobago Core - org/apache/myfaces/tobago/validator/SubmittedValueLengthValidator.java

Violation Line
Document empty constructor 4445
Avoid if (x != y) ..; else ..; 58
Avoid if (x != y) ..; else ..; 70
Avoid if (x != y) ..; else ..; 128
Avoid if (x != y) ..; else ..; 131
Avoid unnecessary if..then..else statements when returning booleans 131133
Avoid if (x != y) ..; else ..; 140
Avoid if (x != y) ..; else ..; 141

Tobago Core - org/apache/myfaces/tobago/webapp/LogoutActionListener.java

Violation Line
New exception is thrown in catch block, original stack trace may be lost 59

Tobago Core - org/apache/myfaces/tobago/webapp/Secret.java

Violation Line
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 57
Private field 'secret' could be made final; it is only initialized in the declaration or constructor. 57
Local variable 'secret' could be declared final 85
Parameter 'session' is not assigned and could be declared final 89

Tobago Core - org/apache/myfaces/tobago/webapp/SecretSessionListener.java

Violation Line
Document empty method body 3839

Tobago Core - org/apache/myfaces/tobago/webapp/TobagoResponseWriter.java

Violation Line
Possible God class (WMC=50, ATFD=18, TCC=0.0) 20319
This class has too many methods, consider refactoring it. 44319
Avoid unused private fields such as 'NO_CSS_ITEMS'. 46
Private field 'iconEncoder' could be made final; it is only initialized in the declaration or constructor. 48
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 157
Local variable 'other' could be declared final 212

Tobago Core - org/apache/myfaces/tobago/webapp/TobagoServletContextListener.java

Violation Line
Avoid if (x != y) ..; else ..; 4650
StringBuffer constructor is initialized with size 16, but has at least 87 characters appended. 59
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 60
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 60
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 61
StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. 64

Tobago Example Blank - org/apache/myfaces/tobago/example/blank/Hello.java

Violation Line
Parameter 'name' is not assigned and could be declared final 47

Tobago Example Data - org/apache/myfaces/tobago/example/data/CantorInterval.java

Violation Line
Private field 'begin' could be made final; it is only initialized in the declaration or constructor. 33
Private field 'end' could be made final; it is only initialized in the declaration or constructor. 34
Avoid appending characters as strings in StringBuffer.append. 81
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 81
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 82
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 83
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 84
Avoid appending characters as strings in StringBuffer.append. 85
Avoid appending characters as strings in StringBuffer.append. 146

Tobago Example Data - org/apache/myfaces/tobago/example/data/CategoryTree.java

Violation Line
A class which only has private constructors should be final 2691
Avoid instantiating new objects inside loops 84

Tobago Example Data - org/apache/myfaces/tobago/example/data/CommandNode.java

Violation Line
Private field 'name' could be made final; it is only initialized in the declaration or constructor. 26
Parameter 'name' is not assigned and could be declared final 30
Parameter 'action' is not assigned and could be declared final 34
Parameter 'name' is not assigned and could be declared final 34
Parameter 'url' is not assigned and could be declared final 34

Tobago Example Data - org/apache/myfaces/tobago/example/data/CommandNodeFactory.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2240

Tobago Example Data - org/apache/myfaces/tobago/example/data/LocaleList.java

Violation Line
A class which only has private constructors should be final 3297
Avoid instantiating new objects inside loops 46

Tobago Example Data - org/apache/myfaces/tobago/example/data/MixedCommandTree.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2246

Tobago Example Data - org/apache/myfaces/tobago/example/data/NamedNode.java

Violation Line
Private field 'name' could be made final; it is only initialized in the declaration or constructor. 32

Tobago Example Data - org/apache/myfaces/tobago/example/data/SmallTree.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2434

Tobago Example Data - org/apache/myfaces/tobago/example/data/SolarObject.java

Violation Line
Overridable method 'getPopulation' called during object construction 85
Parameter 'event' is not assigned and could be declared final 93
Position literals first in String comparisons 102
The String literal "Sun" appears 13 times in this file; the first occurrence is on line 102 102
Position literals first in String comparisons 105
Avoid if (x != y) ..; else ..; 186
Position literals first in String comparisons 198
Avoid instantiating new objects inside loops 216
Position literals first in String comparisons 219
Parameter 'name' is not assigned and could be declared final 240
Local variable 'solarObject' could be declared final 241
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 250
The String literal "III" appears 5 times in this file; the first occurrence is on line 251 251
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 251
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 252
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 254343
The String literal "Jupiter" appears 28 times in this file; the first occurrence is on line 260 260
The String literal "Saturn" appears 19 times in this file; the first occurrence is on line 261 261
The String literal "Herschel" appears 5 times in this file; the first occurrence is on line 262 262
The String literal "VII" appears 5 times in this file; the first occurrence is on line 262 262
The String literal "Uranus" appears 22 times in this file; the first occurrence is on line 262 262
The String literal "VIII" appears 5 times in this file; the first occurrence is on line 263 263
The String literal "Neptune" appears 9 times in this file; the first occurrence is on line 263 263
The String literal "Galileo" appears 4 times in this file; the first occurrence is on line 272 272
The String literal "Sheppard" appears 11 times in this file; the first occurrence is on line 276 276
The String literal "Nicholson" appears 5 times in this file; the first occurrence is on line 279 279
The String literal "Cassini" appears 4 times in this file; the first occurrence is on line 303 303
The String literal "Voyager 2" appears 15 times in this file; the first occurrence is on line 313 313
Local variable 'sun' could be declared final 346349
Local variable 'earth' could be declared final 351355
Local variable 'moon' could be declared final 357361

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/BehaviorController.java

Violation Line
Parameter 'ajax' is not assigned and could be declared final 37
Parameter 'event' is not assigned and could be declared final 45

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/BootstrapUtils.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 513
Parameter 'name' is not assigned and could be declared final 10

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/CkeditorController.java

Violation Line
Private field 'contentSecurityPolicyMode' could be made final; it is only initialized in the declaration or constructor. 33

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/CollapsibleBoxController.java

Violation Line
Avoid using redundant field initializer for 'collapsed' 30
Parameter 'collapsed' is not assigned and could be declared final 36

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/CollapsibleController.java

Violation Line
Parameter 'collapsed' is not assigned and could be declared final 57

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/CollapsiblePanelController.java

Violation Line
Avoid using redundant field initializer for 'panelCollapsed' 30
Parameter 'panelCollapsed' is not assigned and could be declared final 36

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/CollapsiblePopupController.java

Violation Line
Parameter 'collapsed' is not assigned and could be declared final 36

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/CollapsibleSectionController.java

Violation Line
Avoid using redundant field initializer for 'collapsed' 30
Parameter 'collapsed' is not assigned and could be declared final 36

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ConversationController.java

Violation Line
Avoid unused private fields such as 'LOG'. 35
Avoid using redundant field initializer for 'count' 39
Avoid if (x != y) ..; else ..; 42

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ConversionController.java

Violation Line
Parameter 'amount' is not assigned and could be declared final 36

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/CurrentValueController.java

Violation Line
Private field 'string' could be made final; it is only initialized in the declaration or constructor. 38
Private field 'currency' could be made final; it is only initialized in the declaration or constructor. 40
When instantiating a SimpleDateFormat object, specify a Locale 47
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 56
Avoid if (x != y) ..; else ..; 56
Parameter 'string' is not assigned and could be declared final 69

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/DateController.java

Violation Line
When instantiating a SimpleDateFormat object, specify a Locale 44
Local variable 'sdf' could be declared final 44
Parameter 'once' is not assigned and could be declared final 56
Parameter 'onchange' is not assigned and could be declared final 64
Parameter 'submitDate' is not assigned and could be declared final 76

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/DefaultCommandController.java

Violation Line
Parameter 'value1' is not assigned and could be declared final 40
Parameter 'value2' is not assigned and could be declared final 48
Parameter 'value3' is not assigned and could be declared final 56

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/DeltaSpikeClientWindowConfig.java

Violation Line
Parameter 'facesContext' is not assigned and could be declared final 31

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/DemoBundle.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2942

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/DemoController.java

Violation Line
Private field 'currencyItems' could be made final; it is only initialized in the declaration or constructor. 63
Local variable 'label' could be declared final 111
Do not add empty strings 113
Avoid instantiating new objects inside loops 115
Consider using varargs for methods or constructors which take an array the last parameter. 120
Local variable 'label' could be declared final 123
Do not add empty strings 125
Avoid instantiating new objects inside loops 127
Avoid if (x != y) ..; else ..; 139143
Consider using varargs for methods or constructors which take an array the last parameter. 210

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/EventController.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20355
Private field 'eventsOnComponents' could be made final; it is only initialized in the declaration or constructor. 99
Avoid using redundant field initializer for 'action' 102
Avoid using redundant field initializer for 'actionListener' 103
Avoid using redundant field initializer for 'ajaxListener' 104
Avoid using redundant field initializer for 'valueChangeListener' 105
Private field 'planets' could be made final; it is only initialized in the declaration or constructor. 106
The String literal "Sun" appears 8 times in this file; the first occurrence is on line 166 166
Avoid if (x != y) ..; else ..; 197
This class has too many methods, consider refactoring it. 241345
Parameter 'component' is not assigned and could be declared final 245
Local variable 'specialEventNames' could be declared final 314
Local variable 'eventName' could be declared final 316
Local variable 'commonEvent' could be declared final 318
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 329
Parameter 'strings' is not assigned and could be declared final 332
Local variable 'stringBuilder' could be declared final 333
Local variable 'string' could be declared final 336

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ExceptionController.java

Violation Line
Local variable 'exception' could be declared final 3435
Local variable 'stringWriter' could be declared final 36
Local variable 'printWriter' could be declared final 37

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ExecuteController.java

Violation Line
Parameter 'value1' is not assigned and could be declared final 73
Parameter 'value2' is not assigned and could be declared final 81
Parameter 'value3' is not assigned and could be declared final 89
Parameter 'value4' is not assigned and could be declared final 97

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ForEachController.java

Violation Line
Overridable method 'reset' called during object construction 39
Parameter 'name' is not assigned and could be declared final 50
Parameter 'length' is not assigned and could be declared final 58
Parameter 'discharge' is not assigned and could be declared final 66
Private field 'name' could be made final; it is only initialized in the declaration or constructor. 92
Private field 'length' could be made final; it is only initialized in the declaration or constructor. 93
Private field 'discharge' could be made final; it is only initialized in the declaration or constructor. 94
Parameter 'name' is not assigned and could be declared final 96
Parameter 'discharge' is not assigned and could be declared final 96
Parameter 'length' is not assigned and could be declared final 96

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/FormAjaxController.java

Violation Line
Parameter 'outerValue' is not assigned and could be declared final 38
Parameter 'innerValue1' is not assigned and could be declared final 46
Parameter 'innerValue2' is not assigned and could be declared final 54

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/FormController.java

Violation Line
Avoid unused private fields such as 'LOG'. 33
Parameter 'value1' is not assigned and could be declared final 42
Parameter 'value2' is not assigned and could be declared final 50

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/FormRequiredController.java

Violation Line
Parameter 'outerValue' is not assigned and could be declared final 38
Parameter 'innerValue1' is not assigned and could be declared final 46
Parameter 'innerValue2' is not assigned and could be declared final 54

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/GroupController.java

Violation Line
Parameter 'newMessage' is not assigned and could be declared final 70
Parameter 'sendTo' is not assigned and could be declared final 83
Parameter 'event' is not assigned and could be declared final 87
Local variable 'command' could be declared final 92
Parameter 'event' is not assigned and could be declared final 98
Parameter 'value' is not assigned and could be declared final 122
Parameter 'currency' is not assigned and could be declared final 134

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/InController.java

Violation Line
Parameter 'event' is not assigned and could be declared final 37
Parameter 'changeValue' is not assigned and could be declared final 45

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/InputSuggestController.java

Violation Line
Private field 'suggestData' could be made final; it is only initialized in the declaration or constructor. 51
The String literal "Niedersachsen" appears 6 times in this file; the first occurrence is on line 52 52
Avoid instantiating new objects inside loops 158
Avoid instantiating new objects inside loops 161
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 170
Avoid instantiating new objects inside loops 171
Avoid instantiating new objects inside loops 174

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/Login.java

Violation Line
Parameter 'username' is not assigned and could be declared final 85
Parameter 'password' is not assigned and could be declared final 93

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ManifestReader.java

Violation Line
Avoid instantiating new objects inside loops 60
Avoid instantiating new objects inside loops 63
Avoid instantiating new objects inside loops 66

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/MessageLayoutController.java

Violation Line
Parameter 'component' is not assigned and could be declared final 39

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/NavigationNode.java

Violation Line
Private field 'tree' could be made final; it is only initialized in the declaration or constructor. 40
Avoid unused local variables such as 'extension'. 55

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/NavigationState.java

Violation Line
Private field 'state' could be made final; it is only initialized in the declaration or constructor. 47
Avoid if (x != y) ..; else ..; 7782
Avoid if (x != y) ..; else ..; 9196
Parameter 'viewSource' is not assigned and could be declared final 140

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/NavigationTree.java

Violation Line
Avoid instantiating new objects inside loops 81
Position literals first in String comparisons 99
Parameter 'viewId' is not assigned and could be declared final 131
Avoid if (x != y) ..; else ..; 149153

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/OldLinksServlet.java

Violation Line
Parameter 'request' is not assigned and could be declared final 36
Parameter 'response' is not assigned and could be declared final 37
Parameter 'request' is not assigned and could be declared final 42
Parameter 'response' is not assigned and could be declared final 42

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/PanelController.java

Violation Line
Parameter 'text' is not assigned and could be declared final 41

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/PartialReloadController.java

Violation Line
Parameter 'event' is not assigned and could be declared final 77
Do not add empty strings 117

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/PlanetExample.java

Violation Line
This abstract class does not have any abstract methods 2476
Private field 'planets' could be made final; it is only initialized in the declaration or constructor. 26
Private field 'earthMoons' could be made final; it is only initialized in the declaration or constructor. 27
Private field 'marsMoons' could be made final; it is only initialized in the declaration or constructor. 28
Private field 'jupiterMoons' could be made final; it is only initialized in the declaration or constructor. 29
Parameter 'planet' is not assigned and could be declared final 60

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/PopupController.java

Violation Line
Parameter 'popup1Collapsed' is not assigned and could be declared final 39
Parameter 'popup1Text' is not assigned and could be declared final 55
Parameter 'popup2Text' is not assigned and could be declared final 63

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/PrettyUrlForMenuNavigationHandler.java

Violation Line
Private field 'navigationHandler' could be made final; it is only initialized in the declaration or constructor. 35
Parameter 'outcome' is not assigned and could be declared final 42

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ProgressController.java

Violation Line
Avoid unused private fields such as 'LOG'. 37
Private field 'progress' could be made final; it is only initialized in the declaration or constructor. 39
Local variable 'value' could be declared final 46
When instantiating a SimpleDateFormat object, specify a Locale 64
Local variable 'sdf' could be declared final 64
When instantiating a SimpleDateFormat object, specify a Locale 69
Local variable 'sdf' could be declared final 69
When instantiating a SimpleDateFormat object, specify a Locale 74
Local variable 'sdf' could be declared final 74

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/RoleController.java

Violation Line
Parameter 'text' is not assigned and could be declared final 38

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SelectBooleanCheckboxController.java

Violation Line
Parameter 'a' is not assigned and could be declared final 41
Parameter 'b' is not assigned and could be declared final 49
Parameter 'c' is not assigned and could be declared final 57
Parameter 'd' is not assigned and could be declared final 65
Parameter 'e' is not assigned and could be declared final 73
Parameter 'f' is not assigned and could be declared final 81

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SelectController.java

Violation Line
Private field 'entries' could be made final; it is only initialized in the declaration or constructor. 32

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SelectItemModel.java

Violation Line
Avoid instantiating new objects inside loops 51
Parameter 'currency2' is not assigned and could be declared final 83

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SelectManyCheckboxController.java

Violation Line
Parameter 'animals' is not assigned and could be declared final 39
Local variable 's' could be declared final 45
Parameter 'numbers' is not assigned and could be declared final 55
Local variable 'number' could be declared final 61

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SelectManyListboxController.java

Violation Line
Private field 'deserts' could be made final; it is only initialized in the declaration or constructor. 35
Parameter 'celestials' is not assigned and could be declared final 52
Local variable 's' could be declared final 58
Parameter 'selectedDeserts' is not assigned and could be declared final 72

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SelectManyShuttleController.java

Violation Line
Private field 'planets' could be made final; it is only initialized in the declaration or constructor. 35
Private field 'stars' could be made final; it is only initialized in the declaration or constructor. 37
Consider using varargs for methods or constructors which take an array the last parameter. 52
Parameter 'selectedPlanets' is not assigned and could be declared final 52
Parameter 'selectedStars' is not assigned and could be declared final 68
Consider using varargs for methods or constructors which take an array the last parameter. 68

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SelectOneChoiceController.java

Violation Line
Parameter 'person' is not assigned and could be declared final 36

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SelectOneListboxController.java

Violation Line
Private field 'mountains' could be made final; it is only initialized in the declaration or constructor. 33
Parameter 'river' is not assigned and could be declared final 50
Parameter 'mountain' is not assigned and could be declared final 62

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SelectOneRadioController.java

Violation Line
Parameter 'numberOne' is not assigned and could be declared final 38
Parameter 'numberTwo' is not assigned and could be declared final 46

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ServerInfo.java

Violation Line
Private field 'version' could be made final; it is only initialized in the declaration or constructor. 54
Private field 'enabled' could be made final; it is only initialized in the declaration or constructor. 59
Local variable 'tokenizer' could be declared final 113
Local variable 'major' could be declared final 114
Local variable 'minor' could be declared final 115
Local variable 'fix' could be declared final 116

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SheetConfig.java

Violation Line
Private field 'sheetDirectLinkCountItems' could be made final; it is only initialized in the declaration or constructor. 39
Private field 'sheetPagingPositionItems' could be made final; it is only initialized in the declaration or constructor. 40
Local variable 'selectable' could be declared final 59
Consider using varargs for methods or constructors which take an array the last parameter. 75
Avoid instantiating new objects inside loops 79
Consider using varargs for methods or constructors which take an array the last parameter. 174
Parameter 'showDirectLinksArrows' is not assigned and could be declared final 190
Parameter 'showPageRangeArrows' is not assigned and could be declared final 198

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SheetController.java

Violation Line
Local variable 'collect' could be declared final 54
Local variable 'selectable' could be declared final 55
Local variable 'selectable' could be declared final 62
Avoid instantiating new objects inside loops 63
Private field 'solarList' could be made final; it is only initialized in the declaration or constructor. 67
Private field 'hugeSolarList' could be made final; it is only initialized in the declaration or constructor. 68
Local variable 'solarObject' could be declared final 81
Local variable 'solarObjectClone' could be declared final 82
Avoid instantiating new objects inside loops 82
Parameter 'sheetState' is not assigned and could be declared final 101
Avoid if (x != y) ..; else ..; 108114
Parameter 'automaticLayout' is not assigned and could be declared final 125
Parameter 'markup' is not assigned and could be declared final 133
Parameter 'columnEventSample' is not assigned and could be declared final 137
Parameter 'facesContext' is not assigned and could be declared final 150
Parameter 'uiComponent' is not assigned and could be declared final 150
Parameter 'value' is not assigned and could be declared final 150
Parameter 'uiComponent' is not assigned and could be declared final 158
Parameter 'facesContext' is not assigned and could be declared final 158
Parameter 'value' is not assigned and could be declared final 158
Parameter 'selectable' is not assigned and could be declared final 174

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SheetFilterController.java

Violation Line
Possible God class (WMC=55, ATFD=29, TCC=0.05026455026455026) 20308
The class 'SheetFilterController' has a Modified Cyclomatic Complexity of 2 (Highest = 10). 43308
The class 'SheetFilterController' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 43308
The class 'SheetFilterController' has a Cyclomatic Complexity of 2 (Highest = 16). 43308
Private field 'filteredSolarList' could be made final; it is only initialized in the declaration or constructor. 47
Private field 'distanceItems' could be made final; it is only initialized in the declaration or constructor. 49
Private field 'minYearItems' could be made final; it is only initialized in the declaration or constructor. 50
Private field 'maxYearItems' could be made final; it is only initialized in the declaration or constructor. 51
Private field 'distanceRangeConverter' could be made final; it is only initialized in the declaration or constructor. 53
Local variable 'years' could be declared final 76
Local variable 'solarObject' could be declared final 77
Local variable 'year' could be declared final 87
Local variable 'selectItem' could be declared final 88
Avoid instantiating new objects inside loops 88
Overridable method 'filter' called during object construction 98
The method 'filter' has a Cyclomatic Complexity of 16. 101135
The method 'filter' has a Modified Cyclomatic Complexity of 10. 101135
The method filter() has an NPath complexity of 1088 101135
The method 'filter' has a Standard Cyclomatic Complexity of 10. 101135
Parameter 'event' is not assigned and could be declared final 137
Parameter 'name' is not assigned and could be declared final 165
Parameter 'orbit' is not assigned and could be declared final 173
Parameter 'distance' is not assigned and could be declared final 181
Parameter 'discoverer' is not assigned and could be declared final 189
Parameter 'minYear' is not assigned and could be declared final 197
Parameter 'maxYear' is not assigned and could be declared final 205
Parameter 'nameSuggestionQuery' is not assigned and could be declared final 213
Avoid if (x != y) ..; else ..; 218
Local variable 'name' could be declared final 222
Private field 'min' could be made final; it is only initialized in the declaration or constructor. 232
Private field 'max' could be made final; it is only initialized in the declaration or constructor. 233
Parameter 'max' is not assigned and could be declared final 236
Parameter 'min' is not assigned and could be declared final 236
No need to call String.valueOf to append to a string. 239
No need to call String.valueOf to append to a string. 239
Parameter 'label' is not assigned and could be declared final 242
Parameter 'max' is not assigned and could be declared final 242
Parameter 'min' is not assigned and could be declared final 242
Local variable 'distanceItem' could be declared final 283
Local variable 'distanceItem' could be declared final 299

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SheetSortingController.java

Violation Line
The class 'SheetSortingController' has a Cyclomatic Complexity of 6 (Highest = 10). 4093
The class 'SheetSortingController' has a Standard Cyclomatic Complexity of 6 (Highest = 10). 4093
The class 'SheetSortingController' has a Modified Cyclomatic Complexity of 6 (Highest = 10). 4093
The method 'sheetSorter' has a Cyclomatic Complexity of 10. 5492
The method 'sheetSorter' has a Standard Cyclomatic Complexity of 10. 5492
The method 'sheetSorter' has a Modified Cyclomatic Complexity of 10. 5492
Local variable 'period1' could be declared final 72
Local variable 'period2' could be declared final 73
Local variable 'discoverYear1' could be declared final 81
Avoid if (x != y) ..; else ..; 81
Local variable 'discoverYear2' could be declared final 82
Avoid if (x != y) ..; else ..; 82

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SheetTreeController.java

Violation Line
Private field 'solarTree' could be made final; it is only initialized in the declaration or constructor. 33

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SourceFileReader.java

Violation Line
This abstract class does not have any abstract methods 3050
Parameter 'filename' is not assigned and could be declared final 34
String.indexOf(char) is faster than String.indexOf(String). 38

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SuggestController.java

Violation Line
Parameter 'query' is not assigned and could be declared final 47
Avoid if (x != y) ..; else ..; 52
Parameter 'selection1' is not assigned and could be declared final 93
Parameter 'selection2' is not assigned and could be declared final 102

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/TabController.java

Violation Line
Avoid unused private fields such as 'LOG'. 35
Private field 'open' could be made final; it is only initialized in the declaration or constructor. 37
Private field 'close' could be made final; it is only initialized in the declaration or constructor. 38
Parameter 'index' is not assigned and could be declared final 46
Avoid if (x != y) ..; else ..; 5155
Avoid if (x != y) ..; else ..; 5963
Avoid if (x != y) ..; else ..; 6771

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/TestController.java

Violation Line
Local variable 'pages' could be declared final 59
Local variable 'page' could be declared final 63
Parameter 'dir' is not assigned and could be declared final 70
Local variable 'xhtmls' could be declared final 71
Local variable 'file' could be declared final 72
Local variable 'testPages' could be declared final 83
Local variable 'testJs' could be declared final 88
Avoid instantiating new objects inside loops 90
Parameter 'dir' is not assigned and could be declared final 96
Local variable 'testJsFiles' could be declared final 97
Local variable 'file' could be declared final 98
Parameter 'id' is not assigned and could be declared final 112
Parameter 'base' is not assigned and could be declared final 112

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/TestExceptionHandler.java

Violation Line
Private field 'wrapped' could be made final; it is only initialized in the declaration or constructor. 37
Avoid instantiating new objects inside loops 61

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/TestExceptionHandlerFactory.java

Violation Line
Private field 'parent' could be made final; it is only initialized in the declaration or constructor. 27

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/TextareaController.java

Violation Line
Parameter 'longText' is not assigned and could be declared final 54

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ThemeController.java

Violation Line
Avoid instantiating new objects inside loops 49
Parameter 'theme' is not assigned and could be declared final 57
Parameter 'themeItems' is not assigned and could be declared final 65
Consider using varargs for methods or constructors which take an array the last parameter. 65

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/TinyMceController.java

Violation Line
Parameter 'text' is not assigned and could be declared final 41

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/TreeCommandTypesController.java

Violation Line
Private field 'sample' could be made final; it is only initialized in the declaration or constructor. 33
Avoid using redundant field initializer for 'actionOneCount' 34
Avoid using redundant field initializer for 'actionTwoCount' 35
Parameter 'name' is not assigned and could be declared final 49

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/TreeController.java

Violation Line
Private field 'sample' could be made final; it is only initialized in the declaration or constructor. 33
Avoid using redundant field initializer for 'treeShowRoot' 34
Avoid using redundant field initializer for 'treeShowRootJunction' 35
Parameter 'treeShowRoot' is not assigned and could be declared final 51
Parameter 'treeShowRootJunction' is not assigned and could be declared final 59
Parameter 'treeIndentRendered' is not assigned and could be declared final 67
Parameter 'treeIndentShowJunction' is not assigned and could be declared final 75

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/TreeEditorController.java

Violation Line
This class has too many methods, consider refactoring it. 37217
Parameter 'name' is not assigned and could be declared final 59
Avoid if (x != y) ..; else ..; 6570
Avoid if (x != y) ..; else ..; 7685
Avoid if (x != y) ..; else ..; 7782
Parameter 'node' is not assigned and could be declared final 113
Local variable 'nodeName' could be declared final 114
Local variable 'resultNode' could be declared final 115
Local variable 'children' could be declared final 117
Avoid if (x != y) ..; else ..; 128140
Parameter 'selected' is not assigned and could be declared final 144
Parameter 'base' is not assigned and could be declared final 144
Local variable 'children' could be declared final 148
Parameter 'node' is not assigned and could be declared final 160
Local variable 'children' could be declared final 163
Local variable 'previousSibling' could be declared final 173
Avoid if (x != y) ..; else ..; 174180
Local variable 'parent' could be declared final 175
Local variable 'nextSibling' could be declared final 188
Avoid if (x != y) ..; else ..; 189195
Local variable 'parent' could be declared final 190

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/TreeSelectController.java

Violation Line
Private field 'sample' could be made final; it is only initialized in the declaration or constructor. 34
Parameter 'selectable' is not assigned and could be declared final 49
Parameter 'node' is not assigned and could be declared final 54
Local variable 'userObject' could be declared final 55
Local variable 'child' could be declared final 58
Local variable 'stringBuilder' could be declared final 64
Parameter 'stringBuilder' is not assigned and could be declared final 73
Parameter 'node' is not assigned and could be declared final 73
Local variable 'userObject' could be declared final 74
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 76
Local variable 'child' could be declared final 79

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/UniversalLoggingInfo.java

Violation Line
Private field 'jul' could be made final; it is only initialized in the declaration or constructor. 46
Private field 'slf4j' could be made final; it is only initialized in the declaration or constructor. 51
Private field 'log4j' could be made final; it is only initialized in the declaration or constructor. 53
Private field 'log4j2' could be made final; it is only initialized in the declaration or constructor. 55
Private field 'commonsLogging' could be made final; it is only initialized in the declaration or constructor. 57
The String literal "getLogger" appears 4 times in this file; the first occurrence is on line 62 62
The String literal "info" appears 5 times in this file; the first occurrence is on line 67 67
The String literal "trace" appears 4 times in this file; the first occurrence is on line 71 71
The String literal "debug" appears 4 times in this file; the first occurrence is on line 72 72
The String literal "warn" appears 4 times in this file; the first occurrence is on line 74 74
The String literal "error" appears 4 times in this file; the first occurrence is on line 75 75
Overridable method 'update' called during object construction 97
Parameter 'testCategory' is not assigned and could be declared final 133
Avoid if (x != y) ..; else ..; 134138
Private field 'id' could be made final; it is only initialized in the declaration or constructor. 143
Private field 'calls' could be made final; it is only initialized in the declaration or constructor. 145
Private field 'factoryClassName' could be made final; it is only initialized in the declaration or constructor. 147
Private field 'factoryMethod' could be made final; it is only initialized in the declaration or constructor. 148
Private field 'usesString' could be made final; it is only initialized in the declaration or constructor. 149
Parameter 'id' is not assigned and could be declared final 151
Parameter 'factoryClassName' is not assigned and could be declared final 151
Parameter 'factoryMethod' is not assigned and could be declared final 151
Parameter 'category' is not assigned and could be declared final 152
Parameter 'calls' is not assigned and could be declared final 152
Parameter 'usesString' is not assigned and could be declared final 152
Overridable method 'reset' called during object construction 158
Local variable 'call' could be declared final 162
A method/constructor shouldnt explicitly throw java.lang.Exception 171
Parameter 'name' is not assigned and could be declared final 171
Parameter 'id' is not assigned and could be declared final 171
Parameter 'logger' is not assigned and could be declared final 171
Parameter 'category' is not assigned and could be declared final 185
Avoid if (x != y) ..; else ..; 196213
Local variable 'call' could be declared final 198
Parameter 'category' is not assigned and could be declared final 216
Parameter 'level' is not assigned and could be declared final 216
Local variable 'methodName' could be declared final 235
Consider simply returning the value vs storing it in local variable 'hasLevel' 237
Parameter 'clazz' is not assigned and could be declared final 243
Parameter 'c' is not assigned and could be declared final 243
Parameter 'level' is not assigned and could be declared final 243
Parameter 'levelMethod' is not assigned and could be declared final 243
Parameter 'enabledMethod' is not assigned and could be declared final 243
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 248
Consider simply returning the value vs storing it in local variable 'hasLevel' 250

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/UploadController.java

Violation Line
Private field 'uploadItems' could be made final; it is only initialized in the declaration or constructor. 46
Local variable 'part' could be declared final 59
Parameter 'event' is not assigned and could be declared final 65
Parameter 'part' is not assigned and could be declared final 69
Parameter 'fileBasic' is not assigned and could be declared final 88
Parameter 'fileContentType' is not assigned and could be declared final 96
Parameter 'fileMulti' is not assigned and could be declared final 104
Consider using varargs for methods or constructors which take an array the last parameter. 104
Parameter 'fileAjax' is not assigned and could be declared final 112

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/UploadItem.java

Violation Line
Avoid unused private fields such as 'LOG'. 29

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ValidationController.java

Violation Line
Parameter 'letter' is not assigned and could be declared final 40
Parameter 'value' is not assigned and could be declared final 55
Parameter 'component' is not assigned and could be declared final 55
Parameter 'context' is not assigned and could be declared final 55
Local variable 'password' could be declared final 56
Local variable 'confirmationField' could be declared final 58
Local variable 'confirmationFieldValue' could be declared final 59

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ValidationJsr303Controller.java

Violation Line
Parameter 'required' is not assigned and could be declared final 42
Parameter 'length' is not assigned and could be declared final 50

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/actionlistener/SimpleTabChangeListener.java

Violation Line
Avoid using redundant field initializer for 'count' 27
Parameter 'tabChangeEvent' is not assigned and could be declared final 33

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/bestpractice/BestPracticeController.java

Violation Line
The method viewFile() has an NPath complexity of 306 5378

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/bestpractice/ToolBarCustomizer.java

Violation Line
Overridable method 'resetList' called during object construction 39
Avoid instantiation through private constructors from outside of the constructors class. 44
Avoid instantiation through private constructors from outside of the constructors class. 45
Avoid instantiation through private constructors from outside of the constructors class. 46
Private field 'label' could be made final; it is only initialized in the declaration or constructor. 76
Private field 'name' could be made final; it is only initialized in the declaration or constructor. 77

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/clientConfig/ClientConfigController.java

Violation Line
Avoid instantiating new objects inside loops 59
Avoid if (x != y) ..; else ..; 6569
Overridable method 'loadFromTobagoContext' called during object construction 73
Avoid if (x != y) ..; else ..; 146150
Consider using varargs for methods or constructors which take an array the last parameter. 181
Avoid if (x != y) ..; else ..; 190194

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/clientConfig/ClientConfigPhaseListener.java

Violation Line
Document empty method body 3334

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/formatter/AbstractConverter.java

Violation Line
Private field 'matcher' could be made final; it is only initialized in the declaration or constructor. 38
Private field 'compiler' could be made final; it is only initialized in the declaration or constructor. 39
Private field 'util' could be made final; it is only initialized in the declaration or constructor. 40

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/formatter/JspTagConverter.java

Violation Line
Private field 'tagConverter' could be made final; it is only initialized in the declaration or constructor. 35
Private field 'tags' could be made final; it is only initialized in the declaration or constructor. 36
Prefer StringBuffer over += for concatenating strings 65
The String literal "</span>" appears 5 times in this file; the first occurrence is on line 65 65
Prefer StringBuffer over += for concatenating strings 67
Prefer StringBuffer over += for concatenating strings 72
Prefer StringBuffer over += for concatenating strings 75
Prefer StringBuffer over += for concatenating strings 80

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/formatter/SourceFormatter.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2869
A method/constructor shouldnt explicitly throw java.lang.Exception 30
Avoid appending characters as strings in StringBuffer.append. 63

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/formatter/StringExpression.java

Violation Line
Private field 'string' could be made final; it is only initialized in the declaration or constructor. 36
Use ArrayList instead of Vector 57
Use ArrayList instead of Vector 58
Avoid using implementation types like 'Vector'; use the interface instead 82
Avoid using implementation types like 'Vector'; use the interface instead 82
String.indexOf(char) is faster than String.indexOf(String). 85
Avoid if (x != y) ..; else ..; 92104

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/info/ActivityList.java

Violation Line
Private field 'data' could be made final; it is only initialized in the declaration or constructor. 42
Avoid if (x != y) ..; else ..; 6367
Avoid if (x != y) ..; else ..; 7276

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/info/ActivityPhaseListener.java

Violation Line
Document empty constructor 3738
Document empty method body 5354

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/nonfacesrequest/FishPond.java

Violation Line
Private field 'fishes' could be made final; it is only initialized in the declaration or constructor. 38
Avoid using redundant field initializer for 'selectedFishId' 40
Parameter 'selectedFishId' is not assigned and could be declared final 79

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/sudoku/Sudoku.java

Violation Line
Avoid instantiation through private constructors from outside of the constructors class. 62
Avoid instantiation through private constructors from outside of the constructors class. 82
Avoid instantiating new objects inside loops 132
Avoid instantiating new objects inside loops 149
Avoid instantiating new objects inside loops 166
Do not add empty strings 183
Avoid instantiation through private constructors from outside of the constructors class. 183
Do not add empty strings 187
Do not add empty strings 189
Avoid if (x != y) ..; else ..; 201205
Private field 'n' could be made final; it is only initialized in the declaration or constructor. 215
Private field 'list' could be made final; it is only initialized in the declaration or constructor. 216

Tobago Sandbox - org/apache/myfaces/tobago/internal/component/AbstractUISplitLayout.java

Violation Line
Avoid unused local variables such as 'firstComponent'. 48
Avoid unused local variables such as 'secondComponent'. 49
Avoid unused local variables such as 'oldPosition'. 50
Avoid unused local variables such as 'currentSize1'. 52
Avoid unused local variables such as 'currentSize2'. 53
An empty method in an abstract class should be abstract instead 111112
Document empty method body 111112
An empty method in an abstract class should be abstract instead 124125
Document empty method body 124125
Avoid if (x != y) ..; else ..; 133

Tobago Sandbox - org/apache/myfaces/tobago/renderkit/html/sandbox/standard/tag/NumberSliderRenderer.java

Violation Line
Avoid really long methods. 50159

Tobago Sandbox - org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SplitLayoutRenderer.java

Violation Line
Avoid unused method parameters such as 'layout'. 119
Avoid unused private methods such as 'calculateHandleStyle(AbstractUISplitLayout)'. 148
Avoid unused method parameters such as 'layout'. 148

Tobago Tool Apt - org/apache/myfaces/tobago/apt/generate/ClassInfo.java

Violation Line
Private field 'className' could be made final; it is only initialized in the declaration or constructor. 27
Private field 'packageName' could be made final; it is only initialized in the declaration or constructor. 28
Private field 'imports' could be made final; it is only initialized in the declaration or constructor. 29
Private field 'interfaces' could be made final; it is only initialized in the declaration or constructor. 31
Private field 'sourceClass' could be made final; it is only initialized in the declaration or constructor. 32
Avoid if (x != y) ..; else ..; 5156
Avoid if (x != y) ..; else ..; 7782

Tobago Tool Apt - org/apache/myfaces/tobago/apt/generate/ClassUtils.java

Violation Line
A class which only has private constructors should be final 2571

Tobago Tool Apt - org/apache/myfaces/tobago/apt/generate/ComponentInfo.java

Violation Line
Private field 'nonTransientProperties' could be made final; it is only initialized in the declaration or constructor. 30
Private field 'transientProperties' could be made final; it is only initialized in the declaration or constructor. 31
Avoid using redundant field initializer for 'index' 35
Avoid using redundant field initializer for 'nonTransientIndex' 36
Private field 'behaviors' could be made final; it is only initialized in the declaration or constructor. 37
Avoid if (x != y) ..; else ..; 5763
Parameter 'defaultBehavior' is not assigned and could be declared final 124

Tobago Tool Apt - org/apache/myfaces/tobago/apt/generate/Imports.java

Violation Line
Private field 'imports' could be made final; it is only initialized in the declaration or constructor. 28
Document empty constructor 3233
These nested if statements could be combined 4147
Avoid if (x != y) ..; else ..; 43
Deeply nested if..then statements are hard to read 4446

Tobago Tool Apt - org/apache/myfaces/tobago/apt/generate/PropertyInfo.java

Violation Line
Possible God class (WMC=54, ATFD=14, TCC=0.08478513356562137) 20262
Document empty constructor 4142
Position literals first in String comparisons 125
Consider using varargs for methods or constructors which take an array the last parameter. 135
Consider using varargs for methods or constructors which take an array the last parameter. 143

Tobago Tool Apt - org/apache/myfaces/tobago/apt/generate/RendererInfo.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 29

Tobago Tool Apt - org/apache/myfaces/tobago/apt/generate/TagInfo.java

Violation Line
Private field 'properties' could be made final; it is only initialized in the declaration or constructor. 27
Consider using varargs for methods or constructors which take an array the last parameter. 34

Tobago Tool Apt - org/apache/myfaces/tobago/apt/processor/AbstractGenerator.java

Violation Line
The class 'AbstractGenerator' has a Modified Cyclomatic Complexity of 2 (Highest = 11). 40125
The class 'AbstractGenerator' has a Cyclomatic Complexity of 2 (Highest = 11). 40125
The class 'AbstractGenerator' has a Standard Cyclomatic Complexity of 2 (Highest = 11). 40125
The method 'process' has a Modified Cyclomatic Complexity of 11. 4695
The method 'process' has a Standard Cyclomatic Complexity of 11. 4695
The method 'process' has a Cyclomatic Complexity of 11. 4695
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 55
These nested if statements could be combined 6769
These nested if statements could be combined 7274
A method/constructor shouldnt explicitly throw java.lang.Exception 99

Tobago Tool Apt - org/apache/myfaces/tobago/apt/processor/CheckstyleConfigGenerator.java

Violation Line
Possible God class (WMC=49, ATFD=53, TCC=0.008333333333333333) 20350
A high number of imports can indicate a high degree of coupling within an object. 20350
This class has too many methods, consider refactoring it. 69350
The class 'CheckstyleConfigGenerator' has a Cyclomatic Complexity of 3 (Highest = 10). 69350
The String literal "name" appears 5 times in this file; the first occurrence is on line 95 95
Avoid if (x != y) ..; else ..; 151158
Avoid if (x != y) ..; else ..; 153158
The method 'addAttributesForTag' has a Cyclomatic Complexity of 10. 194234
Local variable 'attributes' could be declared final 199
Position literals first in String comparisons 228
Parameter 'taglib' is not assigned and could be declared final 330
Parameter 'tagName' is not assigned and could be declared final 330
Parameter 'attributes' is not assigned and could be declared final 330
StringBuffer constructor is initialized with size 16, but has at least 67 characters appended. 331
Avoid appending characters as strings in StringBuffer.append. 332
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 332
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 333
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 334
Avoid appending characters as strings in StringBuffer.append. 334
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 335
Local variable 'attribute' could be declared final 337
Local variable 'attribute' could be declared final 342

Tobago Tool Apt - org/apache/myfaces/tobago/apt/processor/ClassesGenerator.java

Violation Line
Possible God class (WMC=47, ATFD=48, TCC=0.0) 20283
A high number of imports can indicate a high degree of coupling within an object. 20283
The class 'ClassesGenerator' has a Standard Cyclomatic Complexity of 5 (Highest = 13). 64283
The class 'ClassesGenerator' has a Modified Cyclomatic Complexity of 5 (Highest = 13). 64283
The class 'ClassesGenerator' has a Cyclomatic Complexity of 5 (Highest = 13). 64283
A method/constructor shouldnt explicitly throw java.lang.Exception 86
The method createTagOrComponent() has an NPath complexity of 559 99161
The method 'createTagOrComponent' has a Standard Cyclomatic Complexity of 13. 99161
The method 'createTagOrComponent' has a Modified Cyclomatic Complexity of 13. 99161
The method 'createTagOrComponent' has a Cyclomatic Complexity of 13. 99161
Avoid declaring a variable if it is unreferenced before a possible exit point. 105
Local variable 'behavior' could be declared final 115
Deeply nested if..then statements are hard to read 120127
Deeply nested if..then statements are hard to read 129131
Position literals first in String comparisons 140
Position literals first in String comparisons 140
The method 'addProperty' has a Cyclomatic Complexity of 13. 204253
The method addProperty() has an NPath complexity of 1403 204253
The method 'addProperty' has a Modified Cyclomatic Complexity of 12. 204253
The method 'addProperty' has a Standard Cyclomatic Complexity of 12. 204253
Deeply nested if..then statements are hard to read 211213
Deeply nested if..then statements are hard to read 216219
Deeply nested if..then statements are hard to read 227229

Tobago Tool Apt - org/apache/myfaces/tobago/apt/processor/FacesConfigGenerator.java

Violation Line
Possible God class (WMC=83, ATFD=87, TCC=0.04329004329004329) 20645
A high number of imports can indicate a high degree of coupling within an object. 20645
This class has too many methods, consider refactoring it. 73645
The class 'FacesConfigGenerator' has a Modified Cyclomatic Complexity of 4 (Highest = 12). 73645
The class 'FacesConfigGenerator' has a Cyclomatic Complexity of 4 (Highest = 12). 73645
The class 'FacesConfigGenerator' has a Standard Cyclomatic Complexity of 4 (Highest = 12). 73645
The method 'generate' has a Standard Cyclomatic Complexity of 12. 149240
A method/constructor shouldnt explicitly throw java.lang.Exception 149
The method 'generate' has a Modified Cyclomatic Complexity of 12. 149240
The method generate() has an NPath complexity of 361 149240
The method 'generate' has a Cyclomatic Complexity of 12. 149240
Avoid if (x != y) ..; else ..; 181187
Avoid if (x != y) ..; else ..; 183187
These nested if statements could be combined 334338
These nested if statements could be combined 335337
Avoid instantiating new objects inside loops 365
Position literals first in String comparisons 367
Avoid instantiating new objects inside loops 370
Avoid instantiating new objects inside loops 373
Avoid instantiating new objects inside loops 376
Avoid instantiating new objects inside loops 379
Avoid appending characters as strings in StringBuffer.append. 396
Avoid appending characters as strings in StringBuffer.append. 522
Avoid instantiating new objects inside loops 568
Avoid instantiating new objects inside loops 571
Avoid instantiating new objects inside loops 575
Avoid instantiating new objects inside loops 578
Avoid instantiating new objects inside loops 580
Avoid instantiating new objects inside loops 582
Avoid appending characters as strings in StringBuffer.append. 584
A method/constructor shouldnt explicitly throw java.lang.Exception 595
Avoid if (x != y) ..; else ..; 602631

Tobago Tool Apt - org/apache/myfaces/tobago/apt/processor/TaglibGenerator.java

Violation Line
Possible God class (WMC=81, ATFD=45, TCC=0.003952569169960474) 20535
A high number of imports can indicate a high degree of coupling within an object. 20535
This class has too many methods, consider refactoring it. 73535
The class 'TaglibGenerator' has a Cyclomatic Complexity of 4 (Highest = 18). 73535
The class 'TaglibGenerator' has a Standard Cyclomatic Complexity of 3 (Highest = 16). 73535
The class 'TaglibGenerator' has a Modified Cyclomatic Complexity of 3 (Highest = 16). 73535
Prefer StringBuffer over += for concatenating strings 155
Parameter 'functionName' is not assigned and could be declared final 171
Parameter 'functionClass' is not assigned and could be declared final 171
Parameter 'document' is not assigned and could be declared final 171
Parameter 'taglib' is not assigned and could be declared final 171
Parameter 'functionSignature' is not assigned and could be declared final 172
The method 'addDescription' has a Modified Cyclomatic Complexity of 16. 238306
The method 'addDescription' has a Standard Cyclomatic Complexity of 16. 238306
The method addDescription() has an NPath complexity of 20880 238306
The method 'addDescription' has a Cyclomatic Complexity of 18. 238306
StringBuffer constructor is initialized with size 16, but has at least 106 characters appended. 241
String.indexOf(char) is faster than String.indexOf(String). 317
Avoid unused private methods such as 'getInterfaceDeclaration(String)'. 327
StringBuffer constructor is initialized with size 16, but has at least 93 characters appended. 337
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 338
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 339
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 340
StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. 340
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 341
Local variable 'rendererType' could be declared final 344
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 353
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 353
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 357
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 362
Unnecessary use of fully qualified name 'org.w3c.dom.Element' due to existing import 'org.w3c.dom.Element' 434
Unnecessary use of fully qualified name 'org.w3c.dom.Element' due to existing import 'org.w3c.dom.Element' 440
Unnecessary use of fully qualified name 'org.w3c.dom.Element' due to existing import 'org.w3c.dom.Element' 441
Unnecessary use of fully qualified name 'org.w3c.dom.Element' due to existing import 'org.w3c.dom.Element' 447
Unnecessary use of fully qualified name 'org.w3c.dom.Element' due to existing import 'org.w3c.dom.Element' 448
Parameter 'taglibAnnotation' is not assigned and could be declared final 453
Avoid if (x != y) ..; else ..; 506532