PMD Results
The following document contains the results of PMD 4.2.5.
Files
Tobago Core - org/apache/myfaces/tobago/ajax/AjaxUtils.java
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 43 - 151 |
| The class 'AjaxUtils' has a Cyclomatic Complexity of 2 (Highest = 6). | 43 - 151 |
| Parameter 'facesContext' is not assigned and could be declared final | 47 |
| Local variable 'parameterMap' could be declared final | 48 |
| Local variable 'ajaxComponentIds' could be declared final | 49 |
| Parameter 'facesContext' is not assigned and could be declared final | 53 |
| Parameter 'clientId' is not assigned and could be declared final | 53 |
| Local variable 'ajaxComponents' could be declared final | 54 |
| Parameter 'facesContext' is not assigned and could be declared final | 60 |
| Parameter 'clientId' is not assigned and could be declared final | 60 |
| Parameter 'component' is not assigned and could be declared final | 64 |
| Parameter 'facesContext' is not assigned and could be declared final | 64 |
| Local variable 'ajaxComponents' could be declared final | 69 |
| Parameter 'facesContext' is not assigned and could be declared final | 75 |
| Local variable 'parameterMap' could be declared final | 76 |
| Local variable 'ajaxComponentIds' could be declared final | 77 |
| Local variable 'tokenizer' could be declared final | 79 |
| Local variable 'ajaxComponents' could be declared final | 80 |
| Local variable 'ajaxId' could be declared final | 82 |
| Parameter 'context' is not assigned and could be declared final | 95 |
| The method 'addUIMessagesToRenderedPartially' has a Cyclomatic Complexity of 6. | 95 - 116 |
| Local variable 'list' could be declared final | 99 |
| Local variable 'clientIds' could be declared final | 100 |
| Parameter 'facesContext' is not assigned and could be declared final | 118 |
| Parameter 'url' is not assigned and could be declared final | 118 |
| Local variable 'httpServletResponse' could be declared final | 122 - 123 |
| Local variable 'writer' could be declared final | 124 |
| Local variable 'contentType' could be declared final | 125 |
| Parameter 'writer' is not assigned and could be declared final | 134 |
| Parameter 'url' is not assigned and could be declared final | 134 |
| Parameter 'response' is not assigned and could be declared final | 144 |
| Parameter 'url' is not assigned and could be declared final | 144 |
| Local variable 'writer' could be declared final | 145 |
| Local variable 'contentType' could be declared final | 146 |
Tobago Core - org/apache/myfaces/tobago/application/ActionListenerImpl.java
| Violation | Line |
|---|---|
| The class 'ActionListenerImpl' has a Cyclomatic Complexity of 3 (Highest = 7). | 37 - 89 |
| Private field 'base' could be made final; it is only initialized in the declaration or constructor. | 41 |
| Parameter 'base' is not assigned and could be declared final | 45 |
| Parameter 'event' is not assigned and could be declared final | 49 |
| The method 'processAction' has a Cyclomatic Complexity of 7. | 49 - 80 |
| An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 53 |
| Local variable 'facesContext' could be declared final | 63 |
| Local variable 'facesMessage' could be declared final | 65 |
| Local variable 'source' could be declared final | 68 |
| Local variable 'actionSource' could be declared final | 69 |
| Local variable 'application' could be declared final | 70 |
| Local variable 'expression' could be declared final | 71 |
| Local variable 'navHandler' could be declared final | 73 |
| Avoid if (x != y) ..; else ..; | 75 |
| Local variable 'navBinding' could be declared final | 75 |
| Assigning an Object to null is a code smell. Consider refactoring. | 75 |
| Parameter 'errorOutcome' is not assigned and could be declared final | 86 |
Tobago Core - org/apache/myfaces/tobago/application/LabelValueBindingFacesMessage.java
| Violation | Line |
|---|---|
| The class 'LabelValueBindingFacesMessage' has a Cyclomatic Complexity of 2 (Highest = 5). | 34 - 85 |
| Parameter 'summary' is not assigned and could be declared final | 42 |
| Parameter 'detail' is not assigned and could be declared final | 42 |
| Parameter 'severity' is not assigned and could be declared final | 42 |
| Parameter 'args' is not assigned and could be declared final | 43 |
| Parameter 'locale' is not assigned and could be declared final | 43 |
| Parameter 'summary' is not assigned and could be declared final | 49 |
| Parameter 'detail' is not assigned and could be declared final | 49 |
| Parameter 'summary' is not assigned and could be declared final | 53 |
| The method 'getDetail' has a Cyclomatic Complexity of 5. | 58 - 69 |
| Local variable 'detail' could be declared final | 59 |
| Local variable 'facesContext' could be declared final | 62 |
| Local variable 'value' could be declared final | 63 |
| The method 'getSummary' has a Cyclomatic Complexity of 5. | 72 - 83 |
| Local variable 'summary' could be declared final | 73 |
| Local variable 'facesContext' could be declared final | 76 |
| Local variable 'value' could be declared final | 77 |
Tobago Core - org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.java
| Violation | Line |
|---|---|
| Parameter 'summary' is not assigned and could be declared final | 31 |
| Parameter 'detail' is not assigned and could be declared final | 31 |
| Parameter 'severity' is not assigned and could be declared final | 31 |
| Parameter 'summary' is not assigned and could be declared final | 35 |
| Parameter 'detail' is not assigned and could be declared final | 35 |
| Parameter 'summary' is not assigned and could be declared final | 39 |
| Local variable 'facesContext' could be declared final | 45 |
| Local variable 'value' could be declared final | 46 - 47 |
| Local variable 'facesContext' could be declared final | 53 |
| Local variable 'value' could be declared final | 54 - 55 |
Tobago Core - org/apache/myfaces/tobago/compat/FacesInvokeOnComponent12.java
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 31 - 78 |
| The class 'FacesInvokeOnComponent12' has a Cyclomatic Complexity of 6 (Highest = 7). | 31 - 78 |
| The method 'invokeOnComponent' has a Cyclomatic Complexity of 7. | 37 - 62 |
| Parameter 'component' is not assigned and could be declared final | 38 |
| Parameter 'context' is not assigned and could be declared final | 38 |
| Parameter 'callback' is not assigned and could be declared final | 38 |
| Parameter 'clientId' is not assigned and could be declared final | 38 |
| Local variable 'thisClientId' could be declared final | 39 |
| These nested if statements could be combined | 51 - 53 |
| These nested if statements could be combined | 51 - 53 |
| Parameter 'component' is not assigned and could be declared final | 69 |
| Parameter 'context' is not assigned and could be declared final | 69 |
| Parameter 'callback' is not assigned and could be declared final | 69 |
| Parameter 'clientId' is not assigned and could be declared final | 69 |
| Local variable 'it' could be declared final | 70 |
| Local variable 'child' could be declared final | 71 |
Tobago Core - org/apache/myfaces/tobago/compat/FacesUtils.java
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 41 - 233 |
| The class 'FacesUtils' has a Cyclomatic Complexity of 1 (Highest = 5). | 41 - 233 |
| Avoid unused private fields such as 'LOG'. | 43 |
| Avoid unused private fields such as 'LOG'. | 43 |
| Parameter 'component' is not assigned and could be declared final | 56 |
| Parameter 'context' is not assigned and could be declared final | 56 |
| Parameter 'callback' is not assigned and could be declared final | 56 |
| Parameter 'clientId' is not assigned and could be declared final | 56 |
| Parameter 'facesContext' is not assigned and could be declared final | 60 |
| Parameter 'event' is not assigned and could be declared final | 60 |
| Parameter 'methodBinding' is not assigned and could be declared final | 60 |
| The method 'invokeMethodBinding' has a Cyclomatic Complexity of 5. | 60 - 73 |
| Local variable 'cause' could be declared final | 65 |
| Parameter 'component' is not assigned and could be declared final | 80 |
| Parameter 'name' is not assigned and could be declared final | 80 |
| Parameter 'context' is not assigned and could be declared final | 80 |
| Parameter 'component' is not assigned and could be declared final | 88 |
| Parameter 'name' is not assigned and could be declared final | 88 |
| Parameter 'component' is not assigned and could be declared final | 97 |
| Parameter 'name' is not assigned and could be declared final | 97 |
| Parameter 'context' is not assigned and could be declared final | 97 |
| Parameter 'component' is not assigned and could be declared final | 105 |
| Parameter 'name' is not assigned and could be declared final | 105 |
| Parameter 'component' is not assigned and could be declared final | 114 |
| Parameter 'context' is not assigned and could be declared final | 114 |
| Parameter 'value' is not assigned and could be declared final | 114 |
| Parameter 'bindingName' is not assigned and could be declared final | 114 |
| Parameter 'bindingOrExpression' is not assigned and could be declared final | 123 |
| Parameter 'context' is not assigned and could be declared final | 123 |
| Parameter 'value' is not assigned and could be declared final | 123 |
| Parameter 'fromComponent' is not assigned and could be declared final | 132 |
| Parameter 'toName' is not assigned and could be declared final | 132 |
| Parameter 'fromName' is not assigned and could be declared final | 132 |
| Parameter 'toComponent' is not assigned and could be declared final | 132 |
| Parameter 'obj' is not assigned and could be declared final | 140 |
| Parameter 'string' is not assigned and could be declared final | 148 |
| Parameter 'editableValueHolder' is not assigned and could be declared final | 156 |
| Parameter 'validator' is not assigned and could be declared final | 156 |
| Parameter 'valueHolder' is not assigned and could be declared final | 164 |
| Parameter 'converterExpression' is not assigned and could be declared final | 164 |
| Parameter 'component' is not assigned and could be declared final | 172 |
| Parameter 'valueBindingOrExpression' is not assigned and could be declared final | 172 |
| Parameter 'name' is not assigned and could be declared final | 172 |
| Parameter 'component' is not assigned and could be declared final | 180 |
| Parameter 'valueBindingOrExpression' is not assigned and could be declared final | 180 |
| Parameter 'name' is not assigned and could be declared final | 180 |
| Parameter 'source' is not assigned and could be declared final | 188 |
| Parameter 'type' is not assigned and could be declared final | 188 |
| Parameter 'bindingOrExpression' is not assigned and could be declared final | 189 |
| Parameter 'child' is not assigned and could be declared final | 198 |
| Parameter 'facesContext' is not assigned and could be declared final | 198 |
| Parameter 'var' is not assigned and could be declared final | 198 |
| Parameter 'comparator' is not assigned and could be declared final | 198 |
| Parameter 'descending' is not assigned and could be declared final | 198 |
| Parameter 'bindingOrExpression' is not assigned and could be declared final | 206 |
| Parameter 'actionSource' is not assigned and could be declared final | 206 |
| Parameter 'bindingOrExpression' is not assigned and could be declared final | 214 |
| Parameter 'actionSource' is not assigned and could be declared final | 214 |
| Parameter 'context' is not assigned and could be declared final | 218 |
Tobago Core - org/apache/myfaces/tobago/compat/FacesUtilsEL.java
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 47 - 235 |
| The class 'FacesUtilsEL' has a Cyclomatic Complexity of 2 (Highest = 7). | 47 - 235 |
| This class has too many methods, consider refactoring it. | 47 - 235 |
| The method 'invokeOnComponent' has a Cyclomatic Complexity of 7. | 51 - 76 |
| Parameter 'component' is not assigned and could be declared final | 52 |
| Parameter 'context' is not assigned and could be declared final | 52 |
| Parameter 'callback' is not assigned and could be declared final | 52 |
| Parameter 'clientId' is not assigned and could be declared final | 52 |
| Local variable 'thisClientId' could be declared final | 53 |
| These nested if statements could be combined | 65 - 67 |
| These nested if statements could be combined | 65 - 67 |
| Parameter 'component' is not assigned and could be declared final | 79 |
| Parameter 'context' is not assigned and could be declared final | 79 |
| Parameter 'callback' is not assigned and could be declared final | 79 |
| Parameter 'clientId' is not assigned and could be declared final | 79 |
| Local variable 'it' could be declared final | 80 |
| Local variable 'child' could be declared final | 81 |
| Parameter 'facesContext' is not assigned and could be declared final | 94 |
| Parameter 'event' is not assigned and could be declared final | 94 |
| Parameter 'methodBinding' is not assigned and could be declared final | 94 |
| The method 'invokeMethodBinding' has a Cyclomatic Complexity of 5. | 94 - 107 |
| Local variable 'cause' could be declared final | 99 |
| Parameter 'facesContext' is not assigned and could be declared final | 110 |
| Parameter 'event' is not assigned and could be declared final | 110 |
| Parameter 'methodExpression' is not assigned and could be declared final | 110 |
| Parameter 'component' is not assigned and could be declared final | 126 |
| Parameter 'name' is not assigned and could be declared final | 126 |
| Parameter 'context' is not assigned and could be declared final | 126 |
| Parameter 'component' is not assigned and could be declared final | 131 |
| Parameter 'name' is not assigned and could be declared final | 131 |
| Parameter 'component' is not assigned and could be declared final | 136 |
| Parameter 'name' is not assigned and could be declared final | 136 |
| Parameter 'context' is not assigned and could be declared final | 136 |
| Parameter 'component' is not assigned and could be declared final | 141 |
| Parameter 'name' is not assigned and could be declared final | 141 |
| Parameter 'component' is not assigned and could be declared final | 146 |
| Parameter 'context' is not assigned and could be declared final | 146 |
| Parameter 'value' is not assigned and could be declared final | 146 |
| Parameter 'bindingName' is not assigned and could be declared final | 146 |
| Local variable 've' could be declared final | 147 |
| Parameter 'bindingOrExpression' is not assigned and could be declared final | 154 |
| Parameter 'context' is not assigned and could be declared final | 154 |
| Parameter 'value' is not assigned and could be declared final | 154 |
| Local variable 've' could be declared final | 156 |
| Parameter 'fromComponent' is not assigned and could be declared final | 162 |
| Parameter 'toName' is not assigned and could be declared final | 162 |
| Parameter 'fromName' is not assigned and could be declared final | 162 |
| Parameter 'toComponent' is not assigned and could be declared final | 162 |
| Local variable 've' could be declared final | 163 |
| Parameter 'obj' is not assigned and could be declared final | 169 |
| Local variable 'expression' could be declared final | 171 |
| Parameter 'string' is not assigned and could be declared final | 181 |
| Parameter 'string' is not assigned and could be declared final | 185 |
| Local variable 'facesContext' could be declared final | 186 |
| Local variable 'expressionFactory' could be declared final | 187 |
| Parameter 'editableValueHolder' is not assigned and could be declared final | 191 |
| Parameter 'validator' is not assigned and could be declared final | 191 |
| Avoid if (x != y) ..; else ..; | 195 |
| Parameter 'valueHolder' is not assigned and could be declared final | 199 |
| Parameter 'converterExpression' is not assigned and could be declared final | 199 |
| Local variable 'expression' could be declared final | 201 |
| Avoid if (x != y) ..; else ..; | 202 - 207 |
| Parameter 'component' is not assigned and could be declared final | 211 |
| Parameter 'valueBindingOrExpression' is not assigned and could be declared final | 211 |
| Parameter 'name' is not assigned and could be declared final | 211 |
| Parameter 'source' is not assigned and could be declared final | 216 |
| Parameter 'bindingOrExpression' is not assigned and could be declared final | 216 |
| Parameter 'type' is not assigned and could be declared final | 216 |
| Parameter 'child' is not assigned and could be declared final | 223 |
| Parameter 'facesContext' is not assigned and could be declared final | 223 |
| Parameter 'var' is not assigned and could be declared final | 223 |
| Parameter 'comparator' is not assigned and could be declared final | 223 |
| Parameter 'descending' is not assigned and could be declared final | 223 |
| Local variable 'valueBinding' could be declared final | 224 |
| Parameter 'bindingOrExpression' is not assigned and could be declared final | 228 |
| Parameter 'actionSource' is not assigned and could be declared final | 228 |
| Parameter 'bindingOrExpression' is not assigned and could be declared final | 232 |
| Parameter 'actionSource' is not assigned and could be declared final | 232 |
Tobago Core - org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.java
| Violation | Line |
|---|---|
| The class 'MethodBindingToMethodExpression' has a Cyclomatic Complexity of 3 (Highest = 7). | 37 - 231 |
| This class has too many methods, consider refactoring it. | 37 - 231 |
| Document empty constructor | 47 - 48 |
| Parameter 'methodBinding' is not assigned and could be declared final | 54 |
| Parameter 'methodBinding' is not assigned and could be declared final | 67 |
| Parameter 'context' is not assigned and could be declared final | 76 |
| Parameter 'context' is not assigned and could be declared final | 93 |
| Local variable 'expr' could be declared final | 111 |
| Parameter 'context' is not assigned and could be declared final | 119 |
| Parameter 'context' is not assigned and could be declared final | 133 |
| Parameter 'state' is not assigned and could be declared final | 133 |
| Assigning an Object to null is a code smell. Consider refactoring. | 136 |
| Local variable 'values' could be declared final | 138 |
| Assigning an Object to null is a code smell. Consider refactoring. | 141 |
| Parameter 'transientFlag' is not assigned and could be declared final | 145 |
| Parameter 'obj' is not assigned and could be declared final | 162 |
| The method 'equals' has a Cyclomatic Complexity of 7. | 162 - 181 |
| Parameter 'instanceName' is not assigned and could be declared final | 183 |
| Parameter 'notNullInstance' is not assigned and could be declared final | 183 |
| Parameter 'instanceName' is not assigned and could be declared final | 189 |
| Parameter 'notNullInstance' is not assigned and could be declared final | 189 |
| Parameter 'invoker' is not assigned and could be declared final | 195 |
| Parameter 'type' is not assigned and could be declared final | 209 |
| The method 'newInstance' has a Cyclomatic Complexity of 7. | 209 - 229 |
Tobago Core - org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.java
| Violation | Line |
|---|---|
| Assigning an Object to null is a code smell. Consider refactoring. | 41 |
| Parameter 'methodExpression' is not assigned and could be declared final | 47 |
| Parameter 'facesContext' is not assigned and could be declared final | 56 |
| Parameter 'facesContext' is not assigned and could be declared final | 68 |
| Parameter 'params' is not assigned and could be declared final | 68 |
| Parameter 'context' is not assigned and could be declared final | 81 |
| Parameter 'state' is not assigned and could be declared final | 81 |
| Parameter 'context' is not assigned and could be declared final | 87 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 94 |
Tobago Core - org/apache/myfaces/tobago/component/Sorter.java
| Violation | Line |
|---|---|
| The class 'Sorter' has a Cyclomatic Complexity of 8 (Highest = 28). | 49 - 238 |
| The class 'Sorter' has a Cyclomatic Complexity of 8 (Highest = 28). | 49 - 238 |
| Parameter 'sortEvent' is not assigned and could be declared final | 55 |
| The method 'perform' has a Cyclomatic Complexity of 28. | 55 - 181 |
| The method perform() has an NPath complexity of 34968 | 55 - 181 |
| Avoid really long methods. | 55 - 181 |
| The method 'perform' has a Cyclomatic Complexity of 28. | 55 - 181 |
| Local variable 'column' could be declared final | 59 |
| Local variable 'data' could be declared final | 60 |
| Local variable 'facesContext' could be declared final | 66 |
| Local variable 'sheetState' could be declared final | 67 |
| Local variable 'child' could be declared final | 75 |
| Avoid if (x != y) ..; else ..; | 76 - 117 |
| Local variable 'attributeName' could be declared final | 78 |
| Avoid if (x != y) ..; else ..; | 79 - 112 |
| Local variable 'var' could be declared final | 80 |
| Local variable 'descending' could be declared final | 104 |
| Local variable 'expression' could be declared final | 105 |
| Avoid if (x != y) ..; else ..; | 179 |
| Parameter 'expressionString' is not assigned and could be declared final | 185 |
| The method 'isSimpleProperty' has a Cyclomatic Complexity of 5. | 185 - 197 |
| Local variable 'inner' could be declared final | 187 |
| Local variable 'parts' could be declared final | 188 |
| Parameter 'uiColumn' is not assigned and could be declared final | 199 |
| Parameter 'children' is not assigned and could be declared final | 204 |
| The method 'getFirstSortableChild' has a Cyclomatic Complexity of 13. | 204 - 229 |
| The method 'getFirstSortableChild' has a Cyclomatic Complexity of 13. | 204 - 229 |
| Parameter 'comparator' is not assigned and could be declared final | 235 |
Tobago Core - org/apache/myfaces/tobago/component/UIViewRoot.java
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 20 - 344 |
| The class 'UIViewRoot' has a Cyclomatic Complexity of 4 (Highest = 12). | 54 - 344 |
| This class has too many methods, consider refactoring it. | 54 - 344 |
| The class 'UIViewRoot' has a Cyclomatic Complexity of 4 (Highest = 12). | 54 - 344 |
| Parameter 'locale' is not assigned and could be declared final | 68 |
| Local variable 'clientProperties' could be declared final | 70 |
| Parameter 'context' is not assigned and could be declared final | 114 |
| Parameter 'phaseId' is not assigned and could be declared final | 114 |
| Parameter 'event' is not assigned and could be declared final | 133 |
| Parameter 'phaseId' is not assigned and could be declared final | 144 |
| The method 'broadcastForPhase' has a Cyclomatic Complexity of 12. | 144 - 196 |
| The method 'broadcastForPhase' has a Cyclomatic Complexity of 12. | 144 - 196 |
| Local variable 'phaseIdOrdinal' could be declared final | 151 |
| Local variable 'listiterator' could be declared final | 152 |
| Local variable 'event' could be declared final | 153 |
| Local variable 'ordinal' could be declared final | 154 |
| Local variable 'source' could be declared final | 156 |
| Deeply nested if..then statements are hard to read | 163 - 165 |
| Avoid if (x != y) ..; else ..; | 174 - 178 |
| Local variable 'eventIndex' could be declared final | 184 |
| Assigning an Object to null is a code smell. Consider refactoring. | 200 |
| Parameter 'context' is not assigned and could be declared final | 205 |
| The method 'processDecodes' has a Cyclomatic Complexity of 6. | 205 - 233 |
| The String literal "context" appears 4 times in this file; the first occurrence is on line 207 | 207 |
| Local variable 'ajaxComponents' could be declared final | 209 |
| Avoid if (x != y) ..; else ..; | 210 - 228 |
| Local variable 'page' could be declared final | 212 |
| Parameter 'page' is not assigned and could be declared final | 235 |
| Parameter 'facesContext' is not assigned and could be declared final | 235 |
| Parameter 'ajaxComponents' is not assigned and could be declared final | 235 - 236 |
| The method 'decodeActionComponent' has a Cyclomatic Complexity of 10. | 235 - 264 |
| The method 'decodeActionComponent' has a Cyclomatic Complexity of 10. | 235 - 264 |
| Local variable 'actionId' could be declared final | 237 |
| Local variable 'bugActionId' could be declared final | 242 |
| Avoid empty catch blocks | 246 - 248 |
| Avoid empty catch blocks | 246 - 248 |
| Parameter 'context' is not assigned and could be declared final | 268 |
| The method 'processValidators' has a Cyclomatic Complexity of 6. | 268 - 286 |
| Local variable 'ajaxComponents' could be declared final | 273 |
| Avoid if (x != y) ..; else ..; | 274 - 281 |
| Parameter 'context' is not assigned and could be declared final | 289 |
| The method 'processUpdates' has a Cyclomatic Complexity of 6. | 289 - 305 |
| Local variable 'ajaxComponents' could be declared final | 293 |
| Avoid if (x != y) ..; else ..; | 294 - 300 |
| Parameter 'context' is not assigned and could be declared final | 308 |
| Parameter 'context' is not assigned and could be declared final | 330 |
| Parameter 'context' is not assigned and could be declared final | 340 |
| Parameter 'callback' is not assigned and could be declared final | 340 |
| Parameter 'clientId' is not assigned and could be declared final | 340 |
Tobago Core - org/apache/myfaces/tobago/config/ThemeConfig.java
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 29 - 50 |
| Parameter 'component' is not assigned and could be declared final | 35 |
| Parameter 'facesContext' is not assigned and could be declared final | 35 |
| Parameter 'name' is not assigned and could be declared final | 35 |
| Parameter 'component' is not assigned and could be declared final | 45 |
| Parameter 'facesContext' is not assigned and could be declared final | 45 |
| Parameter 'name' is not assigned and could be declared final | 45 |
Tobago Core - org/apache/myfaces/tobago/config/TobagoConfig.java
| Violation | Line |
|---|---|
| Parameter 'facesContext' is not assigned and could be declared final | 33 |
| Parameter 'servletContext' is not assigned and could be declared final | 37 |
Tobago Core - org/apache/myfaces/tobago/context/ClientProperties.java
| Violation | Line |
|---|---|
| The class 'ClientProperties' has a Cyclomatic Complexity of 1 (Highest = 6). | 48 - 248 |
| Parameter 'tobagoConfig' is not assigned and could be declared final | 79 |
| Parameter 'facesContext' is not assigned and could be declared final | 84 |
| The constructor 'ClientProperties' has a Cyclomatic Complexity of 6. | 84 - 116 |
| Local variable 'externalContext' could be declared final | 86 |
| Local variable 'accept' could be declared final | 89 |
| These nested if statements could be combined | 91 - 93 |
| These nested if statements could be combined | 91 - 93 |
| Local variable 'requestUserAgent' could be declared final | 100 |
| Local variable 'requestTheme' could be declared final | 107 |
| Local variable 'config' could be declared final | 108 |
| Parameter 'facesContext' is not assigned and could be declared final | 122 |
| Parameter 'viewRoot' is not assigned and could be declared final | 132 |
| Parameter 'facesContext' is not assigned and could be declared final | 142 |
| Parameter 'propertyPathMode' is not assigned and could be declared final | 151 |
| Parameter 'locale' is not assigned and could be declared final | 151 |
| Local variable 'prefix' could be declared final | 153 |
| Local variable 'locales' could be declared final | 154 |
| Parameter 'contentType' is not assigned and could be declared final | 175 |
| Parameter 'theme' is not assigned and could be declared final | 184 |
| Parameter 'userAgent' is not assigned and could be declared final | 193 |
| Parameter 'debugMode' is not assigned and could be declared final | 202 |
| Parameter 'locale' is not assigned and could be declared final | 215 |
| Parameter 'verticalScrollbarWeight' is not assigned and could be declared final | 227 |
| Parameter 'horizontalScrollbarWeight' is not assigned and could be declared final | 235 |
| Parameter 'facesContext' is not assigned and could be declared final | 239 |
| Local variable 'externalContext' could be declared final | 240 |
| Local variable 'requestUserAgent' could be declared final | 241 |
| Use equals() to compare object references. | 243 |
Tobago Core - org/apache/myfaces/tobago/context/FacesContextFactoryWrapper.java
| Violation | Line |
|---|---|
| Private field 'facesContextFactory' could be made final; it is only initialized in the declaration or constructor. | 28 |
| Parameter 'facesContextFactory' is not assigned and could be declared final | 30 |
| Parameter 'response' is not assigned and could be declared final | 34 |
| Parameter 'lifecycle' is not assigned and could be declared final | 34 |
| Parameter 'request' is not assigned and could be declared final | 34 |
| Parameter 'context' is not assigned and could be declared final | 34 |
Tobago Core - org/apache/myfaces/tobago/context/FacesContextWrapper.java
| Violation | Line |
|---|---|
| Private field 'context' could be made final; it is only initialized in the declaration or constructor. | 33 |
| Parameter 'context' is not assigned and could be declared final | 35 |
| Parameter 'clientId' is not assigned and could be declared final | 63 |
| Parameter 'responseStream' is not assigned and could be declared final | 83 |
| Parameter 'responseWriter' is not assigned and could be declared final | 91 |
| Parameter 'root' is not assigned and could be declared final | 99 |
| Parameter 'message' is not assigned and could be declared final | 103 |
| Parameter 'clientId' is not assigned and could be declared final | 103 |
Tobago Core - org/apache/myfaces/tobago/context/Markup.java
| Violation | Line |
|---|---|
| The class 'Markup' has a Cyclomatic Complexity of 4 (Highest = 8). | 48 - 313 |
| This class has too many methods, consider refactoring it. | 48 - 313 |
| Parameter 'values' is not assigned and could be declared final | 93 |
| Assigning an Object to null is a code smell. Consider refactoring. | 95 |
| Parameter 'value' is not assigned and could be declared final | 98 |
| Assigning an Object to null is a code smell. Consider refactoring. | 99 |
| Parameter 'values' is not assigned and could be declared final | 103 |
| The method 'valueOf' has a Cyclomatic Complexity of 5. | 103 - 115 |
| Local variable 'markup' could be declared final | 109 |
| Parameter 'value' is not assigned and could be declared final | 117 |
| Local variable 'strings' could be declared final | 122 |
| Parameter 'value' is not assigned and could be declared final | 129 |
| The method 'valueOf' has a Cyclomatic Complexity of 7. | 129 - 150 |
| Local variable 'list' could be declared final | 143 |
| Parameter 'o' is not assigned and could be declared final | 153 |
| The method 'equals' has a Cyclomatic Complexity of 7. | 153 - 171 |
| Local variable 'markup' could be declared final | 161 |
| Avoid if (x != y) ..; else ..; | 163 |
| Avoid if (x != y) ..; else ..; | 175 |
| Avoid if (x != y) ..; else ..; | 176 |
| Parameter 'markup' is not assigned and could be declared final | 194 |
| The method 'add' has a Cyclomatic Complexity of 6. | 194 - 213 |
| Use equals() to compare object references. | 198 |
| Avoid if (x != y) ..; else ..; | 201 - 212 |
| Parameter 'summand' is not assigned and could be declared final | 215 |
| The method 'add' has a Cyclomatic Complexity of 6. | 215 - 239 |
| Parameter 'markup' is not assigned and could be declared final | 241 |
| Avoid if (x != y) ..; else ..; | 242 - 251 |
| Parameter 'summand' is not assigned and could be declared final | 254 |
| The method 'remove' has a Cyclomatic Complexity of 8. | 254 - 283 |
| Parameter 'markup' is not assigned and could be declared final | 285 |
| The method 'contains' has a Cyclomatic Complexity of 6. | 285 - 301 |
Tobago Core - org/apache/myfaces/tobago/context/MarkupConfig.java
| Violation | Line |
|---|---|
| Private field 'markups' could be made final; it is only initialized in the declaration or constructor. | 30 |
| Parameter 'markup' is not assigned and could be declared final | 32 |
| Parameter 'markup' is not assigned and could be declared final | 36 |
Tobago Core - org/apache/myfaces/tobago/context/MarkupEditor.java
| Violation | Line |
|---|---|
| Parameter 'text' is not assigned and could be declared final | 27 |
Tobago Core - org/apache/myfaces/tobago/context/ResourceManagerFactory.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 32 - 75 |
| Parameter 'facesContext' is not assigned and could be declared final | 48 |
| Parameter 'servletContext' is not assigned and could be declared final | 56 |
| Parameter 'servletContext' is not assigned and could be declared final | 64 |
| Parameter 'tobagoConfig' is not assigned and could be declared final | 64 |
| Parameter 'servletContext' is not assigned and could be declared final | 72 |
Tobago Core - org/apache/myfaces/tobago/context/ResourceManagerUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 30 - 177 |
| Parameter 'facesContext' is not assigned and could be declared final | 36 |
| Parameter 'bundle' is not assigned and could be declared final | 36 |
| Parameter 'key' is not assigned and could be declared final | 36 |
| Parameter 'facesContext' is not assigned and could be declared final | 41 |
| Parameter 'bundle' is not assigned and could be declared final | 41 |
| Parameter 'key' is not assigned and could be declared final | 41 |
| Local variable 'result' could be declared final | 42 - 43 |
| Parameter 'facesContext' is not assigned and could be declared final | 54 |
| Parameter 'name' is not assigned and could be declared final | 54 |
| Parameter 'facesContext' is not assigned and could be declared final | 63 |
| Parameter 'name' is not assigned and could be declared final | 63 |
| Parameter 'ignoreMissing' is not assigned and could be declared final | 63 |
| Local variable 'image' could be declared final | 64 - 65 |
| Parameter 'facesContext' is not assigned and could be declared final | 73 |
| Parameter 'name' is not assigned and could be declared final | 73 |
| Local variable 'contextPath' could be declared final | 74 |
| Local variable 'styles' could be declared final | 75 - 76 |
| Parameter 'strings' is not assigned and could be declared final | 80 |
| Parameter 'contextPath' is not assigned and could be declared final | 80 |
| Local variable 'withContext' could be declared final | 81 |
| Parameter 'facesContext' is not assigned and could be declared final | 88 |
| Parameter 'name' is not assigned and could be declared final | 88 |
| Local variable 'contextPath' could be declared final | 89 |
| Local variable 'scripts' could be declared final | 90 - 91 |
| Parameter 'facesContext' is not assigned and could be declared final | 95 |
| Parameter 'names' is not assigned and could be declared final | 95 |
| Local variable 'fileNames' could be declared final | 96 |
| Parameter 'facesContext' is not assigned and could be declared final | 103 |
| Parameter 'names' is not assigned and could be declared final | 103 |
| Local variable 'fileNames' could be declared final | 104 |
| Parameter 'list' is not assigned and could be declared final | 111 |
| Local variable 'sb' could be declared final | 112 |
| Parameter 'facesContext' is not assigned and could be declared final | 124 |
| Parameter 'image' is not assigned and could be declared final | 124 |
| Local variable 'filename' could be declared final | 125 |
| Parameter 'facesContext' is not assigned and could be declared final | 132 |
| Parameter 'facesContext' is not assigned and could be declared final | 137 |
| Parameter 'name' is not assigned and could be declared final | 137 |
| Parameter 'configurable' is not assigned and could be declared final | 142 |
| Parameter 'facesContext' is not assigned and could be declared final | 142 |
| Parameter 'name' is not assigned and could be declared final | 142 |
| Parameter 'value' is not assigned and could be declared final | 156 |
| Local variable 'upper' could be declared final | 160 |
| This call to String.startsWith can be rewritten using String.charAt(0) | 161 |
| Parameter 'facesContext' is not assigned and could be declared final | 167 |
| Parameter 'image' is not assigned and could be declared final | 167 |
| Parameter 'disabled' is not assigned and could be declared final | 167 |
Tobago Core - org/apache/myfaces/tobago/context/ResourceUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 22 - 70 |
| Parameter 'folder' is not assigned and could be declared final | 30 |
| Parameter 'extension' is not assigned and could be declared final | 30 |
| Parameter 'postfix' is not assigned and could be declared final | 30 |
| Parameter 'component' is not assigned and could be declared final | 30 |
| Parameter 'name' is not assigned and could be declared final | 30 |
| Parameter 'folder' is not assigned and could be declared final | 44 |
| Parameter 'extension' is not assigned and could be declared final | 44 |
| Parameter 'component' is not assigned and could be declared final | 44 |
| Parameter 'name' is not assigned and could be declared final | 44 |
| Parameter 'postfix' is not assigned and could be declared final | 56 |
| Parameter 'filename' is not assigned and could be declared final | 56 |
| Local variable 'dotIndex' could be declared final | 57 |
| Local variable 'name' could be declared final | 58 |
| Local variable 'extension' could be declared final | 59 |
Tobago Core - org/apache/myfaces/tobago/context/ThemeImpl.java
| Violation | Line |
|---|---|
| The class 'ThemeImpl' has a Cyclomatic Complexity of 2 (Highest = 8). | 33 - 293 |
| Too many fields | 33 - 293 |
| Parameter 'name' is not assigned and could be declared final | 75 |
| Parameter 'displayName' is not assigned and could be declared final | 83 |
| Parameter 'deprecatedName' is not assigned and could be declared final | 91 |
| Parameter 'resourcePath' is not assigned and could be declared final | 99 |
| Parameter 'fallback' is not assigned and could be declared final | 107 |
| Parameter 'fallbackName' is not assigned and could be declared final | 115 |
| Parameter 'rendererConfigFromTobagoConfig' is not assigned and could be declared final | 138 |
| The method 'resolveRendererConfig' has a Cyclomatic Complexity of 8. | 138 - 162 |
| Local variable 'fallback' could be declared final | 143 |
| Local variable 'fallbackRenderersConfig' could be declared final | 146 |
| Deeply nested if..then statements are hard to read | 147 - 152 |
| Local variable 'fallback' could be declared final | 165 |
| Local variable 'builder' could be declared final | 174 |
| Parameter 'renderersConfig' is not assigned and could be declared final | 187 |
| Parameter 'resources' is not assigned and could be declared final | 207 |
| Avoid if (x != y) ..; else ..; | 209 - 213 |
| Avoid if (x != y) ..; else ..; | 215 - 219 |
| The method 'init' has a Cyclomatic Complexity of 7. | 223 - 246 |
| Parameter 'resources' is not assigned and could be declared final | 248 |
| Parameter 'toAddResources' is not assigned and could be declared final | 248 |
| Use equals() to compare object references. | 249 |
| Local variable 'script' could be declared final | 253 |
| Local variable 'style' could be declared final | 258 |
| Parameter 'production' is not assigned and could be declared final | 264 |
| Parameter 'production' is not assigned and could be declared final | 271 |
| Parameter 'versioned' is not assigned and could be declared final | 282 |
| Parameter 'version' is not assigned and could be declared final | 290 |
Tobago Core - org/apache/myfaces/tobago/context/ThemeResource.java
| Violation | Line |
|---|---|
| Parameter 'name' is not assigned and could be declared final | 35 |
| Parameter 'o' is not assigned and could be declared final | 40 |
| Local variable 'that' could be declared final | 48 |
| Avoid if (x != y) ..; else ..; | 50 |
| Avoid if (x != y) ..; else ..; | 56 |
Tobago Core - org/apache/myfaces/tobago/context/ThemeResources.java
| Violation | Line |
|---|---|
| Private field 'scriptList' could be made final; it is only initialized in the declaration or constructor. | 34 |
| Private field 'styleList' could be made final; it is only initialized in the declaration or constructor. | 35 |
| Local variable 'resources' could be declared final | 38 |
| Parameter 'production' is not assigned and could be declared final | 49 |
| Parameter 'script' is not assigned and could be declared final | 53 |
| Parameter 'style' is not assigned and could be declared final | 57 |
Tobago Core - org/apache/myfaces/tobago/context/TobagoBundle.java
| Violation | Line |
|---|---|
| Private field 'bundleName' could be made final; it is only initialized in the declaration or constructor. | 41 |
| Parameter 'bundleName' is not assigned and could be declared final | 43 |
| Parameter 'key' is not assigned and could be declared final | 47 |
| Local variable 'facesContext' could be declared final | 51 |
Tobago Core - org/apache/myfaces/tobago/context/TobagoContext.java
| Violation | Line |
|---|---|
| Local variable 'facesContext' could be declared final | 34 |
| Local variable 'page' could be declared final | 35 |
Tobago Core - org/apache/myfaces/tobago/context/TobagoFacesContext.java
| Violation | Line |
|---|---|
| Private field 'scriptFiles' could be made final; it is only initialized in the declaration or constructor. | 39 |
| Private field 'scriptBlocks' could be made final; it is only initialized in the declaration or constructor. | 41 |
| Private field 'styleFiles' could be made final; it is only initialized in the declaration or constructor. | 43 |
| Private field 'styleBlocks' could be made final; it is only initialized in the declaration or constructor. | 45 |
| Private field 'onloadScripts' could be made final; it is only initialized in the declaration or constructor. | 47 |
| Private field 'onunloadScripts' could be made final; it is only initialized in the declaration or constructor. | 49 |
| Private field 'onexitScripts' could be made final; it is only initialized in the declaration or constructor. | 51 |
| Private field 'onsubmitScripts' could be made final; it is only initialized in the declaration or constructor. | 53 |
| Private field 'popups' could be made final; it is only initialized in the declaration or constructor. | 55 |
| Parameter 'context' is not assigned and could be declared final | 65 |
| Parameter 'ajax' is not assigned and could be declared final | 98 |
| Parameter 'ajaxComponentId' is not assigned and could be declared final | 106 |
| Parameter 'enctype' is not assigned and could be declared final | 114 |
Tobago Core - org/apache/myfaces/tobago/context/TransientStateHolder.java
| Violation | Line |
|---|---|
| Document empty constructor | 33 - 34 |
| Parameter 'object' is not assigned and could be declared final | 36 |
| Parameter 'context' is not assigned and could be declared final | 40 |
| Parameter 'object' is not assigned and could be declared final | 45 |
| Parameter 'context' is not assigned and could be declared final | 57 |
| Parameter 'state' is not assigned and could be declared final | 57 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 65 |
Tobago Core - org/apache/myfaces/tobago/context/UserAgent.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 30 - 323 |
| The class 'UserAgent' has a Cyclomatic Complexity of 3 (Highest = 16). | 30 - 323 |
| The class 'UserAgent' has a Cyclomatic Complexity of 3 (Highest = 16). | 30 - 323 |
| The String literal "msie" appears 11 times in this file; the first occurrence is on line 38 | 38 |
| The String literal "5_0" appears 4 times in this file; the first occurrence is on line 44 | 44 |
| The String literal "opera" appears 4 times in this file; the first occurrence is on line 93 | 93 |
| The String literal "mozilla" appears 4 times in this file; the first occurrence is on line 117 | 117 |
| The String literal "gecko" appears 5 times in this file; the first occurrence is on line 141 | 141 |
| Parameter 'name' is not assigned and could be declared final | 182 |
| Parameter 'version' is not assigned and could be declared final | 182 |
| Parameter 'name' is not assigned and could be declared final | 186 |
| Parameter 'capabilities' is not assigned and could be declared final | 186 |
| Parameter 'version' is not assigned and could be declared final | 186 |
| Parameter 'name' is not assigned and could be declared final | 190 |
| Parameter 'cspHeader' is not assigned and could be declared final | 190 |
| Parameter 'capabilities' is not assigned and could be declared final | 190 |
| Parameter 'version' is not assigned and could be declared final | 190 |
| Parameter 'capability' is not assigned and could be declared final | 197 |
| Parameter 'reverseOrder' is not assigned and could be declared final | 221 |
| Local variable 'list' could be declared final | 222 |
| Parameter 'header' is not assigned and could be declared final | 243 |
| The method 'getInstance' has a Cyclomatic Complexity of 16. | 243 - 285 |
| The method 'getInstance' has a Cyclomatic Complexity of 16. | 243 - 285 |
| Parameter 'id' is not assigned and could be declared final | 291 |
| Avoid if (x != y) ..; else ..; | 301 - 303 |
| Parameter 'name' is not assigned and could be declared final | 315 |
Tobago Core - org/apache/myfaces/tobago/convert/CurrencyConverter.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 36 |
| Parameter 'facesContext' is not assigned and could be declared final | 36 |
| Parameter 'string' is not assigned and could be declared final | 36 |
| Parameter 'component' is not assigned and could be declared final | 45 |
| Parameter 'facesContext' is not assigned and could be declared final | 45 |
| Parameter 'object' is not assigned and could be declared final | 45 |
Tobago Core - org/apache/myfaces/tobago/convert/DurationConverter.java
| Violation | Line |
|---|---|
| The class 'DurationConverter' has a Cyclomatic Complexity of 8 (Highest = 10). | 37 - 150 |
| The class 'DurationConverter' has a Cyclomatic Complexity of 8 (Highest = 10). | 37 - 150 |
| The method 'getAsString' has a Cyclomatic Complexity of 8. | 51 - 85 |
| Parameter 'component' is not assigned and could be declared final | 52 |
| Parameter 'facesContext' is not assigned and could be declared final | 52 |
| Parameter 'object' is not assigned and could be declared final | 52 |
| Local variable 'factor' could be declared final | 63 |
| Local variable 'format' could be declared final | 66 |
| Unnecessary wrapper object creation | 67 |
| Local variable 'seconds' could be declared final | 68 |
| Local variable 'minutes' could be declared final | 70 |
| The method 'getAsObject' has a Cyclomatic Complexity of 5. | 87 - 119 |
| Parameter 'component' is not assigned and could be declared final | 88 |
| Parameter 'facesContext' is not assigned and could be declared final | 88 |
| Parameter 'string' is not assigned and could be declared final | 88 |
| Local variable 'negative' could be declared final | 90 |
| Local variable 'tokenizer' could be declared final | 91 |
| Local variable 'elements' could be declared final | 92 |
| Local variable 'factor' could be declared final | 112 |
| Local variable 'value' could be declared final | 113 |
| Parameter 'component' is not assigned and could be declared final | 121 |
| The method 'getUnitFactor' has a Cyclomatic Complexity of 10. | 121 - 148 |
| The method 'getUnitFactor' has a Cyclomatic Complexity of 10. | 121 - 148 |
Tobago Core - org/apache/myfaces/tobago/convert/LocaleConverter.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 35 |
| Parameter 'facesContext' is not assigned and could be declared final | 35 |
| Parameter 'value' is not assigned and could be declared final | 35 |
| Local variable 'locale' could be declared final | 36 |
| Parameter 'component' is not assigned and could be declared final | 44 |
| Parameter 'facesContext' is not assigned and could be declared final | 44 |
| Parameter 'value' is not assigned and could be declared final | 44 |
Tobago Core - org/apache/myfaces/tobago/convert/ThemeConverter.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 40 |
| Parameter 'facesContext' is not assigned and could be declared final | 40 |
| Parameter 'object' is not assigned and could be declared final | 40 |
| Parameter 'component' is not assigned and could be declared final | 50 |
| Parameter 'facesContext' is not assigned and could be declared final | 50 |
| Parameter 'string' is not assigned and could be declared final | 50 |
Tobago Core - org/apache/myfaces/tobago/el/ConstantMethodBinding.java
| Violation | Line |
|---|---|
| Parameter 'outcome' is not assigned and could be declared final | 33 |
| Document empty constructor | 38 - 39 |
| Parameter 'facesContext' is not assigned and could be declared final | 41 |
| Parameter 'parameters' is not assigned and could be declared final | 41 |
| Parameter 'facesContext' is not assigned and could be declared final | 45 |
Tobago Core - org/apache/myfaces/tobago/el/UserWrapper.java
| Violation | Line |
|---|---|
| This class has too many methods, consider refactoring it. | 31 - 110 |
| Private field 'roles' could be made final; it is only initialized in the declaration or constructor. | 35 |
| Local variable 'facesContext' could be declared final | 42 |
| Local variable 'principal' could be declared final | 43 |
| This class has too many methods, consider refactoring it. | 54 - 109 |
| Parameter 'key' is not assigned and could be declared final | 56 |
| Local variable 'role' could be declared final | 57 |
| Local variable 'facesContext' could be declared final | 58 |
| Local variable 'inRole' could be declared final | 59 |
| Parameter 'key' is not assigned and could be declared final | 78 |
| Parameter 'value' is not assigned and could be declared final | 82 |
| Parameter 't' is not assigned and could be declared final | 90 |
| Parameter 'key' is not assigned and could be declared final | 102 |
| Parameter 'value' is not assigned and could be declared final | 106 |
| Parameter 'key' is not assigned and could be declared final | 106 |
Tobago Core - org/apache/myfaces/tobago/event/AbstractPopupActionListener.java
| Violation | Line |
|---|---|
| The class 'AbstractPopupActionListener' has a Cyclomatic Complexity of 4 (Highest = 5). | 33 - 56 |
| Parameter 'actionEvent' is not assigned and could be declared final | 37 |
| The method 'processAction' has a Cyclomatic Complexity of 5. | 37 - 53 |
| Local variable 'popup' could be declared final | 38 |
Tobago Core - org/apache/myfaces/tobago/event/AbstractResetInputActionListener.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 29 |
| Local variable 'it' could be declared final | 30 |
| Local variable 'child' could be declared final | 32 |
| Parameter 'editableValueHolder' is not assigned and could be declared final | 40 |
Tobago Core - org/apache/myfaces/tobago/event/FacesEventWrapper.java
| Violation | Line |
|---|---|
| Private field 'wrappedFacesEvent' could be made final; it is only initialized in the declaration or constructor. | 31 |
| Parameter 'facesEvent' is not assigned and could be declared final | 33 |
| Parameter 'redirectComponent' is not assigned and could be declared final | 33 |
| Parameter 'phaseId' is not assigned and could be declared final | 44 |
| Parameter 'faceslistener' is not assigned and could be declared final | 60 |
| Parameter 'faceslistener' is not assigned and could be declared final | 65 |
Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionStateChangeListener.java
| Violation | Line |
|---|---|
| Document empty constructor | 35 - 36 |
| Parameter 'methodExpression' is not assigned and could be declared final | 38 |
| Parameter 'actionEvent' is not assigned and could be declared final | 42 |
| Parameter 'context' is not assigned and could be declared final | 46 |
| Parameter 'state' is not assigned and could be declared final | 46 |
| Parameter 'context' is not assigned and could be declared final | 50 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 54 |
Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTabChangeListener.java
| Violation | Line |
|---|---|
| Document empty constructor | 35 - 36 |
| Parameter 'methodExpression' is not assigned and could be declared final | 38 |
| Parameter 'actionEvent' is not assigned and could be declared final | 42 |
| Parameter 'context' is not assigned and could be declared final | 46 |
| Parameter 'state' is not assigned and could be declared final | 46 |
| Parameter 'context' is not assigned and could be declared final | 50 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 54 |
Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.java
| Violation | Line |
|---|---|
| Document empty constructor | 36 - 37 |
| Parameter 'methodExpression' is not assigned and could be declared final | 39 |
| Parameter 'event' is not assigned and could be declared final | 43 |
| Avoid unused private methods such as 'elContext()'. | 47 |
| Avoid unused private methods such as 'elContext()'. | 47 |
| Parameter 'context' is not assigned and could be declared final | 51 |
| Parameter 'state' is not assigned and could be declared final | 51 |
| Parameter 'context' is not assigned and could be declared final | 55 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 59 |
Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTreeMarkedListener.java
| Violation | Line |
|---|---|
| Document empty constructor | 36 - 37 |
| Parameter 'methodExpression' is not assigned and could be declared final | 39 |
| Parameter 'event' is not assigned and could be declared final | 43 |
| Avoid unused private methods such as 'elContext()'. | 47 |
| Avoid unused private methods such as 'elContext()'. | 47 |
| Parameter 'context' is not assigned and could be declared final | 51 |
| Parameter 'state' is not assigned and could be declared final | 51 |
| Parameter 'context' is not assigned and could be declared final | 55 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 59 |
Tobago Core - org/apache/myfaces/tobago/event/PageAction.java
| Violation | Line |
|---|---|
| Parameter 'token' is not assigned and could be declared final | 59 |
| Parameter 'name' is not assigned and could be declared final | 83 |
| Local variable 'value' could be declared final | 84 |
| Avoid if (x != y) ..; else ..; | 85 - 89 |
Tobago Core - org/apache/myfaces/tobago/event/PageActionEvent.java
| Violation | Line |
|---|---|
| Private field 'action' could be made final; it is only initialized in the declaration or constructor. | 31 |
| Parameter 'component' is not assigned and could be declared final | 34 |
| Parameter 'action' is not assigned and could be declared final | 34 |
| Parameter 'value' is not assigned and could be declared final | 46 |
Tobago Core - org/apache/myfaces/tobago/event/PopupActionListener.java
| Violation | Line |
|---|---|
| Document empty constructor | 37 - 38 |
| Parameter 'popupId' is not assigned and could be declared final | 40 |
| Parameter 'actionEvent' is not assigned and could be declared final | 48 |
| Local variable 'facesContext' could be declared final | 49 |
| Local variable 'popup' could be declared final | 50 |
| Parameter 'context' is not assigned and could be declared final | 62 |
| Parameter 'state' is not assigned and could be declared final | 62 |
| Local variable 'values' could be declared final | 63 |
| Parameter 'context' is not assigned and could be declared final | 67 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 73 |
Tobago Core - org/apache/myfaces/tobago/event/PopupFacetActionListener.java
| Violation | Line |
|---|---|
| Parameter 'actionEvent' is not assigned and could be declared final | 36 |
| Local variable 'component' could be declared final | 37 |
Tobago Core - org/apache/myfaces/tobago/event/ResetFormActionListener.java
| Violation | Line |
|---|---|
| Parameter 'actionEvent' is not assigned and could be declared final | 30 |
Tobago Core - org/apache/myfaces/tobago/event/ResetInputActionListener.java
| Violation | Line |
|---|---|
| Document empty constructor | 34 - 35 |
| Parameter 'clientIds' is not assigned and could be declared final | 37 |
| Parameter 'clientIds' is not assigned and could be declared final | 41 |
| Parameter 'event' is not assigned and could be declared final | 45 |
| Local variable 'component' could be declared final | 47 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 58 |
| Parameter 'context' is not assigned and could be declared final | 62 |
| Parameter 'state' is not assigned and could be declared final | 62 |
| Local variable 'values' could be declared final | 63 |
| Parameter 'context' is not assigned and could be declared final | 67 |
Tobago Core - org/apache/myfaces/tobago/event/SheetStateChangeEvent.java
| Violation | Line |
|---|---|
| Parameter 'uiComponent' is not assigned and could be declared final | 30 |
| Parameter 'facesListener' is not assigned and could be declared final | 34 |
| Parameter 'facesListener' is not assigned and could be declared final | 38 |
Tobago Core - org/apache/myfaces/tobago/event/SortActionEvent.java
| Violation | Line |
|---|---|
| Private field 'column' could be made final; it is only initialized in the declaration or constructor. | 31 |
| Parameter 'column' is not assigned and could be declared final | 33 |
| Parameter 'sheet' is not assigned and could be declared final | 33 |
Tobago Core - org/apache/myfaces/tobago/event/TabChangeEvent.java
| Violation | Line |
|---|---|
| Parameter 'oldTabIndex' is not assigned and could be declared final | 33 |
| Parameter 'uiComponent' is not assigned and could be declared final | 33 |
| Parameter 'newTabIndex' is not assigned and could be declared final | 33 |
| Parameter 'oldState' is not assigned and could be declared final | 43 |
| Parameter 'newState' is not assigned and could be declared final | 43 |
| Parameter 'uiComponent' is not assigned and could be declared final | 43 |
| Overridable method 'setOldState' called during object construction | 45 |
| Overridable method 'setNewState' called during object construction | 46 |
| Parameter 'facesListener' is not assigned and could be declared final | 49 |
| Parameter 'facesListener' is not assigned and could be declared final | 53 |
| Parameter 'oldTabIndex' is not assigned and could be declared final | 79 |
| Parameter 'newTabIndex' is not assigned and could be declared final | 95 |
Tobago Core - org/apache/myfaces/tobago/event/TreeExpansionEvent.java
| Violation | Line |
|---|---|
| The class 'TreeExpansionEvent' has a Cyclomatic Complexity of 2 (Highest = 6). | 26 - 72 |
| Private field 'oldExpanded' could be made final; it is only initialized in the declaration or constructor. | 30 |
| Private field 'newExpanded' could be made final; it is only initialized in the declaration or constructor. | 31 |
| Parameter 'oldExpanded' is not assigned and could be declared final | 33 |
| Parameter 'node' is not assigned and could be declared final | 33 |
| Parameter 'newExpanded' is not assigned and could be declared final | 33 |
| Parameter 'facesListener' is not assigned and could be declared final | 39 |
| Parameter 'facesListener' is not assigned and could be declared final | 43 |
| The method 'processListener' has a Cyclomatic Complexity of 6. | 43 - 54 |
| Avoid empty if statements | 50 - 52 |
| Avoid empty if statements | 50 - 52 |
Tobago Core - org/apache/myfaces/tobago/event/TreeMarkedEvent.java
| Violation | Line |
|---|---|
| The class 'TreeMarkedEvent' has a Cyclomatic Complexity of 2 (Highest = 6). | 26 - 67 |
| Private field 'oldMarked' could be made final; it is only initialized in the declaration or constructor. | 30 |
| Private field 'newMarked' could be made final; it is only initialized in the declaration or constructor. | 31 |
| Parameter 'node' is not assigned and could be declared final | 33 |
| Parameter 'oldMarked' is not assigned and could be declared final | 33 |
| Parameter 'newMarked' is not assigned and could be declared final | 33 |
| Parameter 'facesListener' is not assigned and could be declared final | 39 |
| Parameter 'facesListener' is not assigned and could be declared final | 43 |
| The method 'processListener' has a Cyclomatic Complexity of 6. | 43 - 53 |
| Avoid empty if statements | 49 - 51 |
| Avoid empty if statements | 49 - 51 |
Tobago Core - org/apache/myfaces/tobago/event/ValueBindingPopupActionListener.java
| Violation | Line |
|---|---|
| Document empty constructor | 46 - 47 |
| Parameter 'binding' is not assigned and could be declared final | 49 |
| Parameter 'actionEvent' is not assigned and could be declared final | 54 |
| Local variable 'id' could be declared final | 55 |
| Local variable 'popup' could be declared final | 56 |
| Parameter 'context' is not assigned and could be declared final | 70 |
| Parameter 'state' is not assigned and could be declared final | 70 |
| Local variable 'values' could be declared final | 71 |
| Parameter 'context' is not assigned and could be declared final | 75 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 82 |
Tobago Core - org/apache/myfaces/tobago/event/ValueBindingResetInputActionListener.java
| Violation | Line |
|---|---|
| The class 'ValueBindingResetInputActionListener' has a Cyclomatic Complexity of 2 (Highest = 5). | 40 - 93 |
| Document empty constructor | 48 - 49 |
| Parameter 'binding' is not assigned and could be declared final | 51 |
| Parameter 'event' is not assigned and could be declared final | 55 |
| The method 'processAction' has a Cyclomatic Complexity of 5. | 55 - 72 |
| Local variable 'obj' could be declared final | 56 |
| Local variable 'component' could be declared final | 67 |
| Parameter 'context' is not assigned and could be declared final | 78 |
| Parameter 'state' is not assigned and could be declared final | 78 |
| Local variable 'values' could be declared final | 79 |
| Parameter 'context' is not assigned and could be declared final | 83 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 89 |
Tobago Core - org/apache/myfaces/tobago/event/ValueBindingTabChangeListener.java
| Violation | Line |
|---|---|
| The class 'ValueBindingTabChangeListener' has a Cyclomatic Complexity of 2 (Highest = 8). | 34 - 105 |
| Document empty constructor | 39 - 40 |
| Parameter 'type' is not assigned and could be declared final | 42 |
| Parameter 'valueBinding' is not assigned and could be declared final | 42 |
| Parameter 'tabChangeEvent' is not assigned and could be declared final | 47 |
| Local variable 'handler' could be declared final | 48 |
| Avoid if (x != y) ..; else ..; | 49 - 53 |
| Parameter 'context' is not assigned and could be declared final | 56 |
| Parameter 'context' is not assigned and could be declared final | 63 |
| Parameter 'state' is not assigned and could be declared final | 63 |
| Local variable 'values' could be declared final | 64 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 74 |
| The method 'getTabChangeListener' has a Cyclomatic Complexity of 8. | 78 - 93 |
| Local variable 'obj' could be declared final | 81 |
| No need to check for null before an instanceof | 82 |
| Parameter 'className' is not assigned and could be declared final | 95 |
| Local variable 'clazz' could be declared final | 97 |
Tobago Core - org/apache/myfaces/tobago/event/ValueExpressionPopupActionListener.java
| Violation | Line |
|---|---|
| Parameter 'expression' is not assigned and could be declared final | 40 |
| Parameter 'expression' is not assigned and could be declared final | 48 |
| Document empty constructor | 55 - 56 |
| Parameter 'actionEvent' is not assigned and could be declared final | 59 |
| Local variable 'id' could be declared final | 60 |
| Local variable 'popup' could be declared final | 61 |
| Parameter 'context' is not assigned and could be declared final | 75 |
| Parameter 'state' is not assigned and could be declared final | 75 |
| Local variable 'values' could be declared final | 76 |
| Parameter 'context' is not assigned and could be declared final | 80 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 87 |
Tobago Core - org/apache/myfaces/tobago/event/ValueExpressionResetInputActionListener.java
| Violation | Line |
|---|---|
| The class 'ValueExpressionResetInputActionListener' has a Cyclomatic Complexity of 2 (Highest = 5). | 35 - 90 |
| Document empty constructor | 44 - 45 |
| Parameter 'clientIdsExpression' is not assigned and could be declared final | 47 |
| Parameter 'event' is not assigned and could be declared final | 51 |
| The method 'processAction' has a Cyclomatic Complexity of 5. | 51 - 68 |
| Local variable 'obj' could be declared final | 52 |
| Local variable 'component' could be declared final | 63 |
| Parameter 'context' is not assigned and could be declared final | 74 |
| Parameter 'state' is not assigned and could be declared final | 74 |
| Local variable 'values' could be declared final | 75 |
| Parameter 'context' is not assigned and could be declared final | 79 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 86 |
Tobago Core - org/apache/myfaces/tobago/event/ValueExpressionSheetStateChangeListener.java
| Violation | Line |
|---|---|
| The class 'ValueExpressionSheetStateChangeListener' has a Cyclomatic Complexity of 2 (Highest = 8). | 30 - 102 |
| Document empty constructor | 37 - 38 |
| Parameter 'valueExpression' is not assigned and could be declared final | 40 |
| Parameter 'type' is not assigned and could be declared final | 40 |
| Parameter 'sheetStateChangeEvent' is not assigned and could be declared final | 45 |
| Local variable 'handler' could be declared final | 46 |
| Avoid if (x != y) ..; else ..; | 47 - 51 |
| Parameter 'context' is not assigned and could be declared final | 54 |
| Parameter 'context' is not assigned and could be declared final | 61 |
| Parameter 'state' is not assigned and could be declared final | 61 |
| Local variable 'values' could be declared final | 62 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 72 |
| The method 'getSheetStateChangeListener' has a Cyclomatic Complexity of 8. | 76 - 91 |
| Local variable 'obj' could be declared final | 79 |
| No need to check for null before an instanceof | 80 |
| Parameter 'className' is not assigned and could be declared final | 93 |
| Local variable 'clazz' could be declared final | 95 |
Tobago Core - org/apache/myfaces/tobago/event/ValueExpressionTabChangeListener.java
| Violation | Line |
|---|---|
| The class 'ValueExpressionTabChangeListener' has a Cyclomatic Complexity of 2 (Highest = 8). | 30 - 102 |
| Document empty constructor | 37 - 38 |
| Parameter 'valueExpression' is not assigned and could be declared final | 40 |
| Parameter 'type' is not assigned and could be declared final | 40 |
| Parameter 'tabChangeEvent' is not assigned and could be declared final | 45 |
| Local variable 'handler' could be declared final | 46 |
| Avoid if (x != y) ..; else ..; | 47 - 51 |
| Parameter 'context' is not assigned and could be declared final | 54 |
| Parameter 'context' is not assigned and could be declared final | 61 |
| Parameter 'state' is not assigned and could be declared final | 61 |
| Local variable 'values' could be declared final | 62 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 72 |
| The method 'getTabChangeListener' has a Cyclomatic Complexity of 8. | 76 - 91 |
| Local variable 'obj' could be declared final | 79 |
| No need to check for null before an instanceof | 80 |
| Parameter 'className' is not assigned and could be declared final | 93 |
| Local variable 'clazz' could be declared final | 95 |
Tobago Core - org/apache/myfaces/tobago/internal/ajax/AjaxInternalUtils.java
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 42 - 215 |
| The class 'AjaxInternalUtils' has a Cyclomatic Complexity of 3 (Highest = 6). | 42 - 215 |
| Parameter 'facesContext' is not assigned and could be declared final | 51 |
| Parameter 'compClass' is not assigned and could be declared final | 51 |
| Parameter 'uiComponent' is not assigned and could be declared final | 51 |
| The method 'checkParamValidity' has a Cyclomatic Complexity of 5. | 51 - 65 |
| Parameter 'component' is not assigned and could be declared final | 67 |
| Parameter 'facesContext' is not assigned and could be declared final | 67 |
| The method 'encodeAjaxComponent' has a Cyclomatic Complexity of 5. | 67 - 78 |
| Local variable 'renderer' could be declared final | 74 |
| No need to check for null before an instanceof | 75 |
| Parameter 'facesContext' is not assigned and could be declared final | 80 |
| Local variable 'ajaxComponents' could be declared final | 81 |
| Local variable 'viewRoot' could be declared final | 83 |
| Local variable 'page' could be declared final | 84 |
| Parameter 'facesContext' is not assigned and could be declared final | 88 |
| Parameter 'messages' is not assigned and could be declared final | 88 |
| Local variable 'attributes' could be declared final | 89 |
| Parameter 'facesContext' is not assigned and could be declared final | 100 |
| Parameter 'facesContext' is not assigned and could be declared final | 104 |
| Local variable 'parameterMap' could be declared final | 105 |
| Local variable 'component' could be declared final | 106 |
| Local variable 'clientId' could be declared final | 107 |
| Local variable 'ids' could be declared final | 108 |
| Local variable 'list' could be declared final | 109 |
| Local variable 'tokenizer' could be declared final | 111 |
| Local variable 'id' could be declared final | 113 |
| Parameter 'facesContext' is not assigned and could be declared final | 121 |
| The method 'parseAndStoreComponents' has a Cyclomatic Complexity of 6. | 121 - 146 |
| Local variable 'parameterMap' could be declared final | 122 |
| Local variable 'ajaxComponentIds' could be declared final | 123 |
| Local variable 'tokenizer' could be declared final | 128 |
| Local variable 'ajaxComponents' could be declared final | 129 |
| Local variable 'viewRoot' could be declared final | 132 |
| Local variable 'ajaxId' could be declared final | 134 |
| Local variable 'ajaxComponent' could be declared final | 135 |
| Parameter 'facesContext' is not assigned and could be declared final | 148 |
| Parameter 'component' is not assigned and could be declared final | 154 |
| Parameter 'facesContext' is not assigned and could be declared final | 154 |
| Local variable 'ajaxComponents' could be declared final | 155 - 156 |
| These nested if statements could be combined | 158 - 160 |
| These nested if statements could be combined | 158 - 160 |
| Parameter 'value' is not assigned and could be declared final | 164 |
| Parameter 'component' is not assigned and could be declared final | 171 |
| Parameter 'ajaxComponents' is not assigned and could be declared final | 171 |
| Parameter 'context' is not assigned and could be declared final | 186 |
| Parameter 'componentClientId' is not assigned and could be declared final | 186 |
| Parameter 'facesContext' is not assigned and could be declared final | 199 |
| Parameter 'clientId' is not assigned and could be declared final | 199 |
| Parameter 'component' is not assigned and could be declared final | 203 |
| Parameter 'facesContext' is not assigned and could be declared final | 203 |
| Local variable 'ajaxComponents' could be declared final | 208 |
| These nested if statements could be combined | 210 - 212 |
| These nested if statements could be combined | 210 - 212 |
Tobago Core - org/apache/myfaces/tobago/internal/ajax/AjaxResponseRenderer.java
| Violation | Line |
|---|---|
| The class 'AjaxResponseRenderer' has a Cyclomatic Complexity of 2 (Highest = 6). | 47 - 224 |
| Private field 'callback' could be made final; it is only initialized in the declaration or constructor. | 60 |
| Parameter 'facesContext' is not assigned and could be declared final | 66 |
| Local variable 'renderFactory' could be declared final | 68 - 69 |
| Local variable 'renderKit' could be declared final | 70 - 71 |
| Avoid unused local variables such as 'incomingViewRoot'. | 73 |
| Local variable 'incomingViewRoot' could be declared final | 73 - 74 |
| Avoid unused local variables such as 'incomingViewRoot'. | 73 |
| Parameter 'renderKit' is not assigned and could be declared final | 108 |
| Parameter 'component' is not assigned and could be declared final | 108 |
| Parameter 'facesContext' is not assigned and could be declared final | 108 |
| Parameter 'clientId' is not assigned and could be declared final | 108 |
| Parameter 'renderKit' is not assigned and could be declared final | 137 |
| Parameter 'facesContext' is not assigned and could be declared final | 137 |
| Local variable 'stateWriter' could be declared final | 139 |
| Local variable 'stateManager' could be declared final | 142 |
| Local variable 'serializedView' could be declared final | 143 |
| Avoid reassigning parameters such as 'charset' | 147 |
| Parameter 'facesContext' is not assigned and could be declared final | 147 |
| Parameter 'contentType' is not assigned and could be declared final | 147 |
| Local variable 'sb' could be declared final | 148 |
| Parameter 'renderKit' is not assigned and could be declared final | 157 |
| Parameter 'facesContext' is not assigned and could be declared final | 157 |
| Parameter 'reloadRequired' is not assigned and could be declared final | 157 |
| The method 'writeResponse' has a Cyclomatic Complexity of 6. | 157 - 201 |
| Local variable 'page' could be declared final | 162 |
| Avoid if (x != y) ..; else ..; | 164 - 168 |
| Local variable 'writer' could be declared final | 171 |
| Local variable 'ajaxComponents' could be declared final | 176 |
| Local variable 'component' could be declared final | 185 |
| Parameter 'facesContext' is not assigned and could be declared final | 203 |
| Local variable 'externalContext' could be declared final | 204 |
| Parameter 'renderKit' is not assigned and could be declared final | 214 |
| Parameter 'writer' is not assigned and could be declared final | 214 |
| Local variable 'newWriter' could be declared final | 216 |
Tobago Core - org/apache/myfaces/tobago/internal/application/ViewHandlerImpl.java
| Violation | Line |
|---|---|
| Private field 'base' could be made final; it is only initialized in the declaration or constructor. | 45 |
| Parameter 'base' is not assigned and could be declared final | 47 |
| Parameter 'facesContext' is not assigned and could be declared final | 54 |
| Parameter 'facesContext' is not assigned and could be declared final | 58 |
| Parameter 'facesContext' is not assigned and could be declared final | 62 |
| Parameter 'viewId' is not assigned and could be declared final | 62 |
| Parameter 'facesContext' is not assigned and could be declared final | 83 |
| Parameter 'viewId' is not assigned and could be declared final | 83 |
| Parameter 'facesContext' is not assigned and could be declared final | 92 |
| Parameter 'path' is not assigned and could be declared final | 92 |
| Parameter 'facesContext' is not assigned and could be declared final | 96 |
| Parameter 'viewRoot' is not assigned and could be declared final | 96 |
| Parameter 'facesContext' is not assigned and could be declared final | 107 |
| Parameter 'viewId' is not assigned and could be declared final | 107 |
| Local variable 'viewRoot' could be declared final | 114 |
| Consider simply returning the value vs storing it in local variable 'viewRoot' | 115 |
| Parameter 'facesContext' is not assigned and could be declared final | 118 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIBox.java
| Violation | Line |
|---|---|
| Parameter 'context' is not assigned and could be declared final | 27 |
| Parameter 'context' is not assigned and could be declared final | 36 |
| Parameter 'context' is not assigned and could be declared final | 43 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIButton.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 24 - 26 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUICell.java
| Violation | Line |
|---|---|
| Parameter 'spanX' is not assigned and could be declared final | 40 |
| Parameter 'spanY' is not assigned and could be declared final | 48 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIColumn.java
| Violation | Line |
|---|---|
| An empty method in an abstract class should be abstract instead | 31 - 33 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIColumnNode.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 27 - 28 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIColumnSelector.java
| Violation | Line |
|---|---|
| An empty method in an abstract class should be abstract instead | 27 - 29 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUICommand.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 24 - 27 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUICommandBase.java
| Violation | Line |
|---|---|
| The class 'AbstractUICommandBase' has a Cyclomatic Complexity of 2 (Highest = 5). | 34 - 96 |
| Parameter 'facesContext' is not assigned and could be declared final | 37 |
| Parameter 'parent' is not assigned and could be declared final | 37 |
| Local variable 'popup' could be declared final | 38 |
| These nested if statements could be combined | 40 - 42 |
| These nested if statements could be combined | 40 - 42 |
| Parameter 'context' is not assigned and could be declared final | 46 |
| The method 'processDecodes' has a Cyclomatic Complexity of 5. | 46 - 69 |
| Local variable 'kids' could be declared final | 64 |
| Local variable 'kid' could be declared final | 66 |
| Parameter 'facesEvent' is not assigned and could be declared final | 71 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIData.java
| Violation | Line |
|---|---|
| The class 'AbstractUIData' has a Cyclomatic Complexity of 2 (Highest = 7). | 41 - 249 |
| This class has too many methods, consider refactoring it. | 41 - 249 |
| The String literal "Not a tree model" appears 4 times in this file; the first occurrence is on line 67 | 67 |
| Avoid if (x != y) ..; else ..; | 76 - 80 |
| Local variable 'value' could be declared final | 85 |
| Local variable 'showRoot' could be declared final | 86 |
| Avoid if (x != y) ..; else ..; | 98 |
| Parameter 'showRoot' is not assigned and could be declared final | 109 |
| Parameter 'value' is not assigned and could be declared final | 109 |
| Parameter 'context' is not assigned and could be declared final | 117 |
| Avoid if (x != y) ..; else ..; | 138 - 142 |
| Avoid if (x != y) ..; else ..; | 147 |
| Avoid if (x != y) ..; else ..; | 152 |
| An empty method in an abstract class should be abstract instead | 157 - 159 |
| An empty method in an abstract class should be abstract instead | 174 - 176 |
| Parameter 'facesContext' is not assigned and could be declared final | 179 |
| Parameter 'callback' is not assigned and could be declared final | 179 |
| Parameter 'clientId' is not assigned and could be declared final | 179 |
| The method 'invokeOnComponent' has a Cyclomatic Complexity of 7. | 179 - 215 |
| Local variable 'oldRowIndex' could be declared final | 182 |
| Local variable 'sheetId' could be declared final | 184 |
| Local variable 'idx' could be declared final | 192 |
| String.indexOf(char) is faster than String.indexOf(String). | 192 |
| Local variable 'rowIndex' could be declared final | 194 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIDatePicker.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'LOG'. | 37 |
| Avoid unused private fields such as 'LOG'. | 37 |
| Parameter 'facesEvent' is not assigned and could be declared final | 48 |
| Local variable 'facesContext' could be declared final | 49 |
| Local variable 'popup' could be declared final | 50 |
| Local variable 'clientId' could be declared final | 51 |
| Local variable 'box' could be declared final | 52 |
| Local variable 'calendar' could be declared final | 53 |
| Local variable 'time' could be declared final | 55 |
| Parameter 'context' is not assigned and could be declared final | 62 |
| Parameter 'parent' is not assigned and could be declared final | 62 |
| Local variable 'renderer' could be declared final | 63 |
| An empty method in an abstract class should be abstract instead | 69 - 71 |
| An empty method in an abstract class should be abstract instead | 73 - 75 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIFile.java
| Violation | Line |
|---|---|
| The class 'AbstractUIFile' has a Cyclomatic Complexity of 2 (Highest = 5). | 31 - 59 |
| Parameter 'facesContext' is not assigned and could be declared final | 33 |
| The method 'validate' has a Cyclomatic Complexity of 5. | 33 - 47 |
| Local variable 'file' could be declared final | 36 |
| Parameter 'facesContext' is not assigned and could be declared final | 49 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIFlowLayout.java
| Violation | Line |
|---|---|
| Document empty method | 30 - 31 |
| An empty method in an abstract class should be abstract instead | 30 - 31 |
| Document empty method | 33 - 34 |
| An empty method in an abstract class should be abstract instead | 33 - 34 |
| Parameter 'orientation' is not assigned and could be declared final | 33 |
| Parameter 'auto' is not assigned and could be declared final | 33 |
| Document empty method | 36 - 37 |
| An empty method in an abstract class should be abstract instead | 36 - 37 |
| Parameter 'orientation' is not assigned and could be declared final | 36 |
| Document empty method | 39 - 41 |
| An empty method in an abstract class should be abstract instead | 39 - 41 |
| Parameter 'orientation' is not assigned and could be declared final | 39 |
| Document empty method | 43 - 44 |
| An empty method in an abstract class should be abstract instead | 43 - 44 |
| Parameter 'orientation' is not assigned and could be declared final | 43 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIForm.java
| Violation | Line |
|---|---|
| The class 'AbstractUIForm' has a Cyclomatic Complexity of 4 (Highest = 5). | 37 - 121 |
| Parameter 'facesContext' is not assigned and could be declared final | 45 |
| Local variable 'kids' could be declared final | 52 |
| Local variable 'kid' could be declared final | 54 |
| Parameter 'b' is not assigned and could be declared final | 60 |
| Parameter 'facesContext' is not assigned and could be declared final | 70 |
| The method 'processValidators' has a Cyclomatic Complexity of 5. | 70 - 87 |
| Avoid if (x != y) ..; else ..; | 75 - 86 |
| Local variable 'kids' could be declared final | 81 |
| Local variable 'kid' could be declared final | 83 |
| Parameter 'facesContext' is not assigned and could be declared final | 90 |
| The method 'processUpdates' has a Cyclomatic Complexity of 5. | 90 - 107 |
| Avoid if (x != y) ..; else ..; | 95 - 106 |
| Local variable 'kids' could be declared final | 101 |
| Local variable 'kid' could be declared final | 103 |
| Parameter 'context' is not assigned and could be declared final | 110 |
| Parameter 'callback' is not assigned and could be declared final | 110 |
| Parameter 'clientId' is not assigned and could be declared final | 110 |
| These nested if statements could be combined | 114 - 116 |
| These nested if statements could be combined | 114 - 116 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIGridLayout.java
| Violation | Line |
|---|---|
| The class 'AbstractUIGridLayout' has a Cyclomatic Complexity of 4 (Highest = 21). | 51 - 496 |
| The class 'AbstractUIGridLayout' has a Cyclomatic Complexity of 4 (Highest = 21). | 51 - 496 |
| The method 'init' has a Cyclomatic Complexity of 5. | 62 - 85 |
| Local variable 'components' could be declared final | 70 |
| Avoid instantiating new objects inside loops | 74 |
| Parameter 'orientation' is not assigned and could be declared final | 87 |
| Parameter 'auto' is not assigned and could be declared final | 87 |
| The method 'fixRelativeInsideAuto' has a Cyclomatic Complexity of 13. | 87 - 132 |
| The method fixRelativeInsideAuto() has an NPath complexity of 210 | 87 - 132 |
| The method 'fixRelativeInsideAuto' has a Cyclomatic Complexity of 13. | 87 - 132 |
| Local variable 'heads' could be declared final | 93 |
| Local variable 'heads2' could be declared final | 94 |
| Deeply nested if..then statements are hard to read | 99 - 102 |
| Local variable 'cell' could be declared final | 111 |
| Local variable 'origin' could be declared final | 118 |
| Local variable 'component' could be declared final | 119 |
| Local variable 'layoutManager' could be declared final | 121 |
| Local variable 'childAuto' could be declared final | 123 |
| Parameter 'orientation' is not assigned and could be declared final | 134 |
| The method 'preProcessing' has a Cyclomatic Complexity of 20. | 134 - 231 |
| The method preProcessing() has an NPath complexity of 5060 | 134 - 231 |
| The method 'preProcessing' has a Cyclomatic Complexity of 20. | 134 - 231 |
| Local variable 'token' could be declared final | 147 |
| Local variable 'pixel' could be declared final | 150 |
| Local variable 'intervalList' could be declared final | 154 |
| Avoid instantiating new objects inside loops | 154 |
| Local variable 'cell' could be declared final | 156 |
| Local variable 'origin' could be declared final | 158 |
| Local variable 'component' could be declared final | 159 |
| Avoid instantiating new objects inside loops | 167 |
| Deeply nested if..then statements are hard to read | 169 - 172 |
| Avoid empty if statements | 207 - 210 |
| Avoid empty if statements | 207 - 210 |
| Assigning an Object to null is a code smell. Consider refactoring. | 214 |
| Parameter 'orientation' is not assigned and could be declared final | 233 |
| The method 'mainProcessing' has a Cyclomatic Complexity of 21. | 233 - 332 |
| The method mainProcessing() has an NPath complexity of 17600 | 233 - 332 |
| The method 'mainProcessing' has a Cyclomatic Complexity of 21. | 233 - 332 |
| Local variable 'factorList' could be declared final | 243 |
| Local variable 'container' could be declared final | 251 |
| Avoid if (x != y) ..; else ..; | 253 - 287 |
| Local variable 'client' could be declared final | 266 |
| Local variable 'partition' could be declared final | 272 |
| Local variable 'cell' could be declared final | 293 |
| Local variable 'component' could be declared final | 295 |
| Local variable 'span' could be declared final | 299 |
| Local variable 'current' could be declared final | 307 |
| Parameter 'orientation' is not assigned and could be declared final | 334 |
| The method 'postProcessing' has a Cyclomatic Complexity of 13. | 334 - 388 |
| The method 'postProcessing' has a Cyclomatic Complexity of 13. | 334 - 388 |
| Local variable 'cell' could be declared final | 346 |
| Local variable 'component' could be declared final | 348 |
| Parameter 'orientation' is not assigned and could be declared final | 395 |
| Parameter 'orientation' is not assigned and could be declared final | 399 |
| Parameter 'orientation' is not assigned and could be declared final | 403 |
| Parameter 'orientation' is not assigned and could be declared final | 411 |
| Parameter 'startIndex' is not assigned and could be declared final | 411 |
| Parameter 'length' is not assigned and could be declared final | 411 |
| The method 'computeSpacing' has a Cyclomatic Complexity of 6. | 411 - 427 |
| An empty method in an abstract class should be abstract instead | 457 - 459 |
| Parameter 'depth' is not assigned and could be declared final | 461 |
| The method 'toString' has a Cyclomatic Complexity of 6. | 461 - 490 |
| Local variable 'builder' could be declared final | 462 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIInput.java
| Violation | Line |
|---|---|
| Parameter 'facesContext' is not assigned and could be declared final | 32 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUILabel.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 24 - 26 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUILayoutBase.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 24 - 25 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIMediator.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'LOG'. | 34 |
| Avoid unused private fields such as 'LOG'. | 34 |
| Parameter 'facesContext' is not assigned and could be declared final | 39 |
| Parameter 'facesContext' is not assigned and could be declared final | 47 |
| Parameter 'event' is not assigned and could be declared final | 55 |
| Local variable 'requestMap' could be declared final | 56 |
| Parameter 'context' is not assigned and could be declared final | 66 |
| Parameter 'context' is not assigned and could be declared final | 74 |
| Parameter 'state' is not assigned and could be declared final | 74 |
| Local variable 'values' could be declared final | 75 |
| Parameter 'var' is not assigned and could be declared final | 84 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIMenu.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 24 - 25 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIMenuBar.java
| Violation | Line |
|---|---|
| Parameter 'context' is not assigned and could be declared final | 33 |
| Parameter 'parent' is not assigned and could be declared final | 33 |
| Local variable 'renderer' could be declared final | 34 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIMessages.java
| Violation | Line |
|---|---|
| The class 'AbstractUIMessages' has a Cyclomatic Complexity of 3 (Highest = 7). | 33 - 136 |
| Parameter 'facesContext' is not assigned and could be declared final | 36 |
| Avoid if (x != y) ..; else ..; | 41 - 45 |
| Local variable 'messages' could be declared final | 47 |
| Parameter 'facesContext' is not assigned and could be declared final | 57 |
| Parameter 'clientIds' is not assigned and could be declared final | 57 |
| The method 'collectMessageList' has a Cyclomatic Complexity of 7. | 57 - 77 |
| Local variable 'messages' could be declared final | 58 |
| Local variable 'clientId' could be declared final | 60 |
| Local variable 'i' could be declared final | 61 |
| Local variable 'facesMessage' could be declared final | 63 |
| Avoid instantiating new objects inside loops | 73 |
| Parameter 'facesMessage' is not assigned and could be declared final | 84 |
| Parameter 'clientId' is not assigned and could be declared final | 84 |
| Parameter 'clientId' is not assigned and could be declared final | 93 |
| Parameter 'facesMessage' is not assigned and could be declared final | 101 |
| Parameter 'item2' is not assigned and could be declared final | 107 |
| Parameter 'item1' is not assigned and could be declared final | 107 |
| Parameter 'key' is not assigned and could be declared final | 132 |
| When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 133 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIOut.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 26 - 27 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIPage.java
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 20 - 299 |
| The class 'AbstractUIPage' has a Cyclomatic Complexity of 2 (Highest = 11). | 57 - 299 |
| The class 'AbstractUIPage' has a Cyclomatic Complexity of 2 (Highest = 11). | 57 - 299 |
| An empty method in an abstract class should be abstract instead | 75 - 77 |
| Parameter 'facesContext' is not assigned and could be declared final | 79 |
| Parameter 'facesContext' is not assigned and could be declared final | 87 |
| Parameter 'facesContext' is not assigned and could be declared final | 94 |
| Parameter 'facesContext' is not assigned and could be declared final | 100 |
| Parameter 'facesContext' is not assigned and could be declared final | 107 |
| Local variable 'kids' could be declared final | 116 |
| Local variable 'kid' could be declared final | 117 |
| Parameter 'facesContext' is not assigned and could be declared final | 122 |
| The method 'markSubmittedForm' has a Cyclomatic Complexity of 11. | 122 - 177 |
| The method 'markSubmittedForm' has a Cyclomatic Complexity of 11. | 122 - 177 |
| Avoid empty catch blocks | 152 - 154 |
| Avoid empty catch blocks | 152 - 154 |
| Avoid if (x != y) ..; else ..; | 163 - 176 |
| Local variable 'form' could be declared final | 164 |
| Parameter 'facesContext' is not assigned and could be declared final | 179 |
| The method 'checkTobagoRequest' has a Cyclomatic Complexity of 7. | 179 - 203 |
| Local variable 'contentType' could be declared final | 181 - 182 |
| Local variable 'request' could be declared final | 184 |
| Local variable 'wrappedRequest' could be declared final | 189 - 190 |
| Parameter 'context' is not assigned and could be declared final | 213 |
| Document empty method | 223 - 224 |
| An empty method in an abstract class should be abstract instead | 223 - 224 |
| Parameter 'facesContext' is not assigned and could be declared final | 223 |
| Parameter 'facesContext' is not assigned and could be declared final | 231 |
| Avoid if (x != y) ..; else ..; | 233 - 243 |
| Parameter 'actionId' is not assigned and could be declared final | 250 |
| Parameter 'actionPosition' is not assigned and could be declared final | 258 |
| Parameter 'defaultActionId' is not assigned and could be declared final | 269 |
| Parameter 'facesContext' is not assigned and could be declared final | 273 |
| Parameter 'parent' is not assigned and could be declared final | 273 |
| Parameter 'layoutManager' is not assigned and could be declared final | 288 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIPanel.java
| Violation | Line |
|---|---|
| Parameter 'facesContext' is not assigned and could be declared final | 41 |
| Parameter 'facesContext' is not assigned and could be declared final | 48 |
| Parameter 'facesContext' is not assigned and could be declared final | 54 |
| Parameter 'facesContext' is not assigned and could be declared final | 60 |
| Parameter 'parent' is not assigned and could be declared final | 60 |
| Parameter 'layoutManager' is not assigned and could be declared final | 75 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIPanelBase.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 22 - 25 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIPopup.java
| Violation | Line |
|---|---|
| The class 'AbstractUIPopup' has a Cyclomatic Complexity of 2 (Highest = 5). | 49 - 213 |
| This class has too many methods, consider refactoring it. | 51 - 213 |
| Avoid unused private fields such as 'LOG'. | 53 |
| Avoid unused private fields such as 'LOG'. | 53 |
| Parameter 'facesContext' is not assigned and could be declared final | 59 |
| Parameter 'parent' is not assigned and could be declared final | 59 |
| Parameter 'facesContext' is not assigned and could be declared final | 70 |
| Parameter 'parent' is not assigned and could be declared final | 70 |
| Parameter 'activated' is not assigned and could be declared final | 82 |
| Parameter 'facesContext' is not assigned and could be declared final | 87 |
| The method 'processDecodes' has a Cyclomatic Complexity of 5. | 87 - 103 |
| Local variable 'it' could be declared final | 89 |
| Local variable 'childOrFacet' could be declared final | 90 |
| Avoid if (x != y) ..; else ..; | 108 - 113 |
| Local variable 'context' could be declared final | 109 |
| Local variable 'action' could be declared final | 117 |
| The method 'isRedisplay' has a Cyclomatic Complexity of 5. | 121 - 132 |
| Local variable 'action' could be declared final | 123 |
| Local variable 'command' could be declared final | 125 |
| No need to check for null before an instanceof | 126 |
| Parameter 'context' is not assigned and could be declared final | 140 |
| Local variable 'it' could be declared final | 142 |
| Local variable 'childOrFacet' could be declared final | 143 |
| Parameter 'context' is not assigned and could be declared final | 154 |
| Local variable 'it' could be declared final | 156 |
| Local variable 'childOrFacet' could be declared final | 157 |
| Parameter 'context' is not assigned and could be declared final | 164 |
| Parameter 'savedState' is not assigned and could be declared final | 172 |
| Parameter 'context' is not assigned and could be declared final | 172 |
| Local variable 'values' could be declared final | 173 |
| Parameter 'context' is not assigned and could be declared final | 179 |
| Parameter 'layoutManager' is not assigned and could be declared final | 188 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectBooleanCheckbox.java
| Violation | Line |
|---|---|
| The class 'AbstractUISelectBooleanCheckbox' has a Cyclomatic Complexity of 5 (Highest = 6). | 30 - 58 |
| Parameter 'facesContext' is not assigned and could be declared final | 45 |
| Parameter 'convertedValue' is not assigned and could be declared final | 45 |
| The method 'validateValue' has a Cyclomatic Complexity of 6. | 45 - 57 |
| These nested if statements could be combined | 47 - 54 |
| These nested if statements could be combined | 47 - 54 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectItem.java
| Violation | Line |
|---|---|
| Parameter 'facesContext' is not assigned and could be declared final | 37 |
| Parameter 'parent' is not assigned and could be declared final | 37 |
| Local variable 'converted' could be declared final | 39 - 40 |
| Parameter 'itemValue' is not assigned and could be declared final | 46 |
| Avoid empty if statements | 49 - 51 |
| Avoid empty if statements | 49 - 51 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectMany.java
| Violation | Line |
|---|---|
| Local variable 'value' could be declared final | 32 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectOneBase.java
| Violation | Line |
|---|---|
| The class 'AbstractUISelectOneBase' has a Cyclomatic Complexity of 4 (Highest = 6). | 30 - 54 |
| Parameter 'facesContext' is not assigned and could be declared final | 35 |
| The method 'validate' has a Cyclomatic Complexity of 6. | 35 - 51 |
| Local variable 'submittedValue' could be declared final | 37 |
| Avoid if (x != y) ..; else ..; | 39 - 46 |
| Local variable 'requiredMessage' could be declared final | 40 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectOneChoice.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 22 - 23 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectOneListbox.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 22 - 23 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectOneRadio.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 22 - 23 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISeparator.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 26 - 27 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISheet.java
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 20 - 653 |
| This class has a bunch of public methods and attributes | 20 - 653 |
| The class 'AbstractUISheet' has a Cyclomatic Complexity of 3 (Highest = 19). | 65 - 653 |
| The class 'AbstractUISheet' has a Cyclomatic Complexity of 3 (Highest = 19). | 65 - 653 |
| This class has too many methods, consider refactoring it. | 67 - 653 |
| Avoid unused private fields such as 'ajaxResponseCode'. | 93 |
| Avoid unused private fields such as 'ajaxResponseCode'. | 93 |
| Parameter 'context' is not assigned and could be declared final | 101 |
| Parameter 'facesContext' is not assigned and could be declared final | 106 |
| The method 'encodeBegin' has a Cyclomatic Complexity of 5. | 106 - 118 |
| Local variable 'state' could be declared final | 107 |
| Avoid if (x != y) ..; else ..; | 111 - 115 |
| Parameter 'state' is not assigned and could be declared final | 120 |
| Parameter 'facesContext' is not assigned and could be declared final | 128 |
| Local variable 'columns' could be declared final | 152 |
| Local variable 'state' could be declared final | 165 |
| Local variable 'last' could be declared final | 177 |
| Local variable 'last' could be declared final | 194 |
| Local variable 'rows' could be declared final | 202 |
| Local variable 'first' could be declared final | 207 |
| Parameter 'column' is not assigned and could be declared final | 240 |
| Local variable 'children' could be declared final | 241 |
| Avoid if (x != y) ..; else ..; | 278 - 282 |
| Avoid if (x != y) ..; else ..; | 288 - 296 |
| Avoid if (x != y) ..; else ..; | 322 - 330 |
| Local variable 'rows' could be declared final | 326 |
| Local variable 'rowCount' could be declared final | 327 |
| Local variable 'tail' could be declared final | 328 |
| Avoid if (x != y) ..; else ..; | 329 |
| Parameter 'context' is not assigned and could be declared final | 334 |
| Parameter 'facesContext' is not assigned and could be declared final | 339 |
| Local variable 'state' could be declared final | 340 |
| Local variable 'attributes' could be declared final | 346 |
| Avoid if (x != y) ..; else ..; | 349 |
| Parameter 'context' is not assigned and could be declared final | 359 |
| Parameter 'savedState' is not assigned and could be declared final | 367 |
| Parameter 'context' is not assigned and could be declared final | 367 |
| Local variable 'values' could be declared final | 368 |
| Local variable 'columns' could be declared final | 374 |
| Local variable 'columns' could be declared final | 382 |
| Parameter 'facesEvent' is not assigned and could be declared final | 400 |
| The method 'queueEvent' has a Cyclomatic Complexity of 8. | 400 - 422 |
| Local variable 'parent' could be declared final | 401 |
| Local variable 'source' could be declared final | 412 |
| Local variable 'sourceParent' could be declared final | 413 |
| Parameter 'facesEvent' is not assigned and could be declared final | 425 |
| The method 'broadcast' has a Cyclomatic Complexity of 6. | 425 - 446 |
| Local variable 'methodBinding' could be declared final | 436 |
| Avoid if (x != y) ..; else ..; | 437 - 444 |
| Parameter 'listener' is not assigned and could be declared final | 448 |
| Parameter 'listener' is not assigned and could be declared final | 456 |
| Parameter 'widthList' is not assigned and could be declared final | 464 |
| Parameter 'searchId' is not assigned and could be declared final | 480 |
| Avoid reassigning parameters such as 'searchId' | 484 |
| The method 'stripRowIndex' has a Cyclomatic Complexity of 6. | 484 - 498 |
| Local variable 'c' could be declared final | 487 |
| Parameter 'pageEvent' is not assigned and could be declared final | 500 |
| The method 'performPaging' has a Cyclomatic Complexity of 19. | 500 - 562 |
| The method 'performPaging' has a Cyclomatic Complexity of 19. | 500 - 562 |
| Local variable 'pageIndex' could be declared final | 540 |
| Avoid if (x != y) ..; else ..; | 554 - 558 |
| The method 'getComponents' has a Cyclomatic Complexity of 11. | 564 - 606 |
| The method 'getComponents' has a Cyclomatic Complexity of 11. | 564 - 606 |
| Avoid empty if statements | 572 - 574 |
| Avoid empty if statements | 572 - 574 |
| Avoid if (x != y) ..; else ..; | 590 - 602 |
| Parameter 'facesContext' is not assigned and could be declared final | 608 |
| Parameter 'parent' is not assigned and could be declared final | 608 |
| Parameter 'layoutManager' is not assigned and could be declared final | 619 |
| An empty method in an abstract class should be abstract instead | 627 - 629 |
| Parameter 'needVerticalScrollbar' is not assigned and could be declared final | 637 |
| Parameter 'headerGrid' is not assigned and could be declared final | 650 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISheetLayout.java
| Violation | Line |
|---|---|
| The class 'AbstractUISheetLayout' has a Cyclomatic Complexity of 6 (Highest = 16). | 54 - 406 |
| The class 'AbstractUISheetLayout' has a Cyclomatic Complexity of 6 (Highest = 16). | 54 - 406 |
| Parameter 'orientation' is not assigned and could be declared final | 72 |
| Parameter 'auto' is not assigned and could be declared final | 72 |
| Parameter 'orientation' is not assigned and could be declared final | 87 |
| Avoid unused local variables such as 'intervals'. | 90 |
| Local variable 'intervals' could be declared final | 90 |
| Avoid unused local variables such as 'intervals'. | 90 |
| These nested if statements could be combined | 94 - 96 |
| These nested if statements could be combined | 94 - 96 |
| Parameter 'orientation' is not assigned and could be declared final | 118 |
| The method 'mainProcessing' has a Cyclomatic Complexity of 12. | 118 - 168 |
| The method 'mainProcessing' has a Cyclomatic Complexity of 12. | 118 - 168 |
| Local variable 'box' could be declared final | 149 |
| Deeply nested if..then statements are hard to read | 160 - 162 |
| Parameter 'orientation' is not assigned and could be declared final | 170 |
| The method 'postProcessing' has a Cyclomatic Complexity of 5. | 170 - 195 |
| Local variable 'position' could be declared final | 180 |
| An empty method in an abstract class should be abstract instead | 203 - 205 |
| Parameter 'facesContext' is not assigned and could be declared final | 207 |
| Parameter 'data' is not assigned and could be declared final | 207 |
| The method 'ensureColumnWidthList' has a Cyclomatic Complexity of 16. | 207 - 284 |
| The method ensureColumnWidthList() has an NPath complexity of 1080 | 207 - 284 |
| The method 'ensureColumnWidthList' has a Cyclomatic Complexity of 16. | 207 - 284 |
| Local variable 'renderedColumns' could be declared final | 210 |
| Local variable 'state' could be declared final | 214 |
| Assigning an Object to null is a code smell. Consider refactoring. | 230 |
| Local variable 'tokens' could be declared final | 234 |
| Local variable 'allColumns' could be declared final | 235 |
| Local variable 'newTokens' could be declared final | 236 |
| Local variable 'column' could be declared final | 238 |
| Local variable 'layoutInfo' could be declared final | 267 - 268 |
| Avoid if (x != y) ..; else ..; | 277 - 283 |
| Parameter 'facesContext' is not assigned and could be declared final | 286 |
| Parameter 'sheet' is not assigned and could be declared final | 286 |
| The method 'needVerticalScrollbar' has a Cyclomatic Complexity of 13. | 286 - 331 |
| The method needVerticalScrollbar() has an NPath complexity of 660 | 286 - 331 |
| The method 'needVerticalScrollbar' has a Cyclomatic Complexity of 13. | 286 - 331 |
| Avoid if (x != y) ..; else ..; | 312 - 327 |
| Local variable 'first' could be declared final | 313 |
| Local variable 'rows' could be declared final | 314 - 316 |
| The method 'parseFixedWidth' has a Cyclomatic Complexity of 9. | 333 - 364 |
| Parameter 'columnSelectorWidth' is not assigned and could be declared final | 334 |
| Parameter 'layoutInfo' is not assigned and could be declared final | 334 |
| Parameter 'renderedColumns' is not assigned and could be declared final | 334 |
| Local variable 'tokens' could be declared final | 335 |
| Local variable 'token' could be declared final | 337 |
| Local variable 'column' could be declared final | 342 |
| Parameter 'facesContext' is not assigned and could be declared final | 366 |
| Parameter 'sheet' is not assigned and could be declared final | 366 |
| Parameter 'facesContext' is not assigned and could be declared final | 372 |
| Parameter 'sheet' is not assigned and could be declared final | 372 |
| Parameter 'facesContext' is not assigned and could be declared final | 376 |
| Parameter 'sheet' is not assigned and could be declared final | 376 |
| The method 'layoutHeader' has a Cyclomatic Complexity of 5. | 382 - 405 |
| Avoid instantiating new objects inside loops | 397 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITabGroup.java
| Violation | Line |
|---|---|
| A high number of imports can indicate a high degree of coupling within an object. | 20 - 336 |
| The class 'AbstractUITabGroup' has a Cyclomatic Complexity of 2 (Highest = 6). | 56 - 336 |
| This class has too many methods, consider refactoring it. | 58 - 336 |
| Parameter 'facesContext' is not assigned and could be declared final | 72 |
| An empty method in an abstract class should be abstract instead | 80 - 83 |
| Parameter 'facesContext' is not assigned and could be declared final | 80 |
| Parameter 'facesContext' is not assigned and could be declared final | 86 |
| An empty method in an abstract class should be abstract instead | 97 - 99 |
| Parameter 'event' is not assigned and could be declared final | 101 |
| Local variable 'tabs' could be declared final | 121 |
| Parameter 'context' is not assigned and could be declared final | 140 |
| The method 'processDecodes' has a Cyclomatic Complexity of 6. | 140 - 163 |
| Avoid if (x != y) ..; else ..; | 141 - 162 |
| Local variable 'renderedTab' could be declared final | 149 |
| Parameter 'context' is not assigned and could be declared final | 166 |
| The method 'processValidators' has a Cyclomatic Complexity of 5. | 166 - 182 |
| Avoid if (x != y) ..; else ..; | 167 - 181 |
| Local variable 'renderedTab' could be declared final | 174 |
| Parameter 'context' is not assigned and could be declared final | 185 |
| The method 'processUpdates' has a Cyclomatic Complexity of 5. | 185 - 202 |
| Avoid if (x != y) ..; else ..; | 186 - 201 |
| Local variable 'renderedTab' could be declared final | 193 |
| Parameter 'facesEvent' is not assigned and could be declared final | 204 |
| The method 'broadcast' has a Cyclomatic Complexity of 6. | 204 - 224 |
| Local variable 'defaultActionListener' could be declared final | 211 |
| Local variable 'index' could be declared final | 216 |
| Local variable 'expression' could be declared final | 217 |
| Avoid if (x != y) ..; else ..; | 218 - 222 |
| Parameter 'listener' is not assigned and could be declared final | 226 |
| Local variable 'switchType' could be declared final | 234 |
| Parameter 'listener' is not assigned and could be declared final | 238 |
| Parameter 'index' is not assigned and could be declared final | 256 |
| Parameter 'listener' is not assigned and could be declared final | 280 |
| Parameter 'listener' is not assigned and could be declared final | 294 |
| Parameter 'facesContext' is not assigned and could be declared final | 302 |
| Parameter 'parent' is not assigned and could be declared final | 302 |
| Parameter 'layoutManager' is not assigned and could be declared final | 313 |
| Parameter 'context' is not assigned and could be declared final | 321 |
| Parameter 'componentState' is not assigned and could be declared final | 321 |
| Local variable 'values' could be declared final | 322 |
| Parameter 'context' is not assigned and could be declared final | 328 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITabGroupLayout.java
| Violation | Line |
|---|---|
| The class 'AbstractUITabGroupLayout' has a Cyclomatic Complexity of 4 (Highest = 9). | 33 - 137 |
| Parameter 'orientation' is not assigned and could be declared final | 48 |
| Parameter 'auto' is not assigned and could be declared final | 48 |
| Parameter 'orientation' is not assigned and could be declared final | 63 |
| The method 'preProcessing' has a Cyclomatic Complexity of 8. | 63 - 88 |
| Local variable 'intervals' could be declared final | 66 |
| Avoid instantiating new objects inside loops | 75 |
| Local variable 'size' could be declared final | 81 |
| Parameter 'orientation' is not assigned and could be declared final | 90 |
| The method 'mainProcessing' has a Cyclomatic Complexity of 9. | 90 - 113 |
| Local variable 'container' could be declared final | 96 |
| Local variable 'available' could be declared final | 97 |
| Avoid if (x != y) ..; else ..; | 98 - 104 |
| Parameter 'orientation' is not assigned and could be declared final | 115 |
| An empty method in an abstract class should be abstract instead | 134 - 136 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITime.java
| Violation | Line |
|---|---|
| Local variable 'converter' could be declared final | 32 |
| Local variable 'application' could be declared final | 35 - 36 |
| Local variable 'dateTimeConverter' could be declared final | 37 - 38 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIToolBar.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 24 - 38 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIToolBarCommand.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 24 - 27 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITree.java
| Violation | Line |
|---|---|
| The class 'AbstractUITree' has a Cyclomatic Complexity of 3 (Highest = 6). | 38 - 250 |
| Avoid unused private fields such as 'LOG'. | 42 |
| Avoid unused private fields such as 'LOG'. | 42 |
| Parameter 'facesContext' is not assigned and could be declared final | 67 |
| The method 'processValidators' has a Cyclomatic Complexity of 5. | 67 - 79 |
| Parameter 'facesContext' is not assigned and could be declared final | 82 |
| The method 'processUpdates' has a Cyclomatic Complexity of 5. | 82 - 94 |
| An empty method in an abstract class should be abstract instead | 123 - 125 |
| Parameter 'facesContext' is not assigned and could be declared final | 128 |
| The method 'processDecodes' has a Cyclomatic Complexity of 6. | 128 - 147 |
| Parameter 'state' is not assigned and could be declared final | 204 |
| Parameter 'context' is not assigned and could be declared final | 238 |
| Parameter 'componentState' is not assigned and could be declared final | 238 |
| Local variable 'values' could be declared final | 239 |
| Parameter 'context' is not assigned and could be declared final | 244 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITreeData.java
| Violation | Line |
|---|---|
| The class 'AbstractUITreeData' has a Cyclomatic Complexity of 2 (Highest = 5). | 36 - 111 |
| Parameter 'facesContext' is not assigned and could be declared final | 46 |
| Parameter 'parent' is not assigned and could be declared final | 46 |
| The method 'onComponentCreated' has a Cyclomatic Complexity of 5. | 46 - 65 |
| Local variable 've' could be declared final | 49 |
| Avoid if (x != y) ..; else ..; | 50 - 54 |
| Local variable 've' could be declared final | 58 |
| Avoid if (x != y) ..; else ..; | 59 - 63 |
| Parameter 'var' is not assigned and could be declared final | 71 |
| Parameter 'context' is not assigned and could be declared final | 75 |
| Parameter 'componentState' is not assigned and could be declared final | 75 |
| Local variable 'values' could be declared final | 76 |
| Parameter 'context' is not assigned and could be declared final | 81 |
| Parameter 'model' is not assigned and could be declared final | 92 |
| Parameter 'facesContext' is not assigned and could be declared final | 92 |
| Parameter 'model' is not assigned and could be declared final | 100 |
| Parameter 'facesContext' is not assigned and could be declared final | 100 |
| Parameter 'model' is not assigned and could be declared final | 108 |
| Parameter 'facesContext' is not assigned and could be declared final | 108 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITreeIndent.java
| Violation | Line |
|---|---|
| No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead. | 26 - 27 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITreeListbox.java
| Violation | Line |
|---|---|
| An empty method in an abstract class should be abstract instead | 25 - 27 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITreeNode.java
| Violation | Line |
|---|---|
| This class has too many methods, consider refactoring it. | 41 - 311 |
| Parameter 'facesContext' is not assigned and could be declared final | 44 |
| Parameter 'facesContext' is not assigned and could be declared final | 75 |
| Local variable 'dataId' could be declared final | 78 |
| Consider simply returning the value vs storing it in local variable 'rowData' | 92 |
| Parameter 'model' is not assigned and could be declared final | 99 |
| Parameter 'facesContext' is not assigned and could be declared final | 99 |
| The String literal "Doesn't work anymore." appears 10 times in this file; the first occurrence is on line 100 | 100 |
| Parameter 'model' is not assigned and could be declared final | 107 |
| Parameter 'facesContext' is not assigned and could be declared final | 107 |
| Parameter 'model' is not assigned and could be declared final | 115 |
| Parameter 'facesContext' is not assigned and could be declared final | 115 |
| Parameter 'depth' is not assigned and could be declared final | 132 |
| Parameter 'folder' is not assigned and could be declared final | 140 |
| Parameter 'path' is not assigned and could be declared final | 148 |
| Parameter 'junctions' is not assigned and could be declared final | 156 |
| Parameter 'hasNextSibling' is not assigned and could be declared final | 173 |
| The String literal "treeExpansionListener!" appears 5 times in this file; the first occurrence is on line 182 | 182 |
| Parameter 'treeExpansionListener' is not assigned and could be declared final | 190 |
| Parameter 'listener' is not assigned and could be declared final | 198 |
| Return an empty array rather than null. | 206 - 209 |
| Parameter 'listener' is not assigned and could be declared final | 215 |
| The String literal "treeMarkedListener!" appears 5 times in this file; the first occurrence is on line 224 | 224 |
| Parameter 'treeMarkedListener' is not assigned and could be declared final | 232 |
| Parameter 'listener' is not assigned and could be declared final | 240 |
| Return an empty array rather than null. | 248 - 251 |
| Parameter 'listener' is not assigned and could be declared final | 257 |
| Parameter 'b' is not assigned and could be declared final | 274 |
| Parameter 'expanded' is not assigned and could be declared final | 291 |
| Parameter 'selected' is not assigned and could be declared final | 308 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITreeSelect.java
| Violation | Line |
|---|---|
| Overriding method merely calls super | 30 - 32 |
| Parameter 'context' is not assigned and could be declared final | 30 |
| Overriding method merely calls super | 30 - 32 |
Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIWizard.java
| Violation | Line |
|---|---|
| Parameter 'facesContext' is not assigned and could be declared final | 47 |
| Parameter 'facesContext' is not assigned and could be declared final | 55 |
| Parameter 'event' is not assigned and could be declared final | 63 |
| Parameter 'event' is not assigned and could be declared final | 68 |
| Local variable 'facesContext' could be declared final | 70 |
| Local variable 'originalEvent' could be declared final | 74 |
| Parameter 'facesContext' is not assigned and could be declared final | 85 |
| Parameter 'facesContext' is not assigned and could be declared final | 93 |
| Parameter 'context' is not assigned and could be declared final | 100 |
| Parameter 'parent' is not assigned and could be declared final | 100 |
| Local variable 'wizard' could be declared final | 101 |
| Parameter 'facesContext' is not assigned and could be declared final | 112 |
| Parameter 'facesContext' is not assigned and could be declared final | 121 |
| Parameter 'state' is not assigned and could be declared final | 121 |
| Local variable 'values' could be declared final | 122 |
| Local variable 'vb' could be declared final | 132 |
| Avoid if (x != y) ..; else ..; | 133 - 137 |
| Parameter 'controller' is not assigned and could be declared final | 140 |
| Parameter 'var' is not assigned and could be declared final | 148 |
| Local variable 'vb' could be declared final | 156 |
| Parameter 'outcome' is not assigned and could be declared final | 164 |
| Local variable 'vb' could be declared final | 172 |
| Parameter 'title' is not assigned and could be declared final | 180 |
| Local variable 'vb' could be declared final | 188 |
| Local variable 'bool' could be declared final | 190 |
| Parameter 'allowJumpForward' is not assigned and could be declared final | 198 |
Tobago Core - org/apache/myfaces/tobago/internal/config/RendererConfig.java
| Violation | Line |
|---|---|
| Parameter 'name' is not assigned and could be declared final | 38 |
| Parameter 'o' is not assigned and could be declared final | 42 |
| Parameter 'markup' is not assigned and could be declared final | 55 |
| Parameter 'markup' is not assigned and could be declared final | 63 |
| Parameter 'rendererConfig' is not assigned and could be declared final | 67 |
Tobago Core - org/apache/myfaces/tobago/internal/config/RenderersConfigImpl.java
| Violation | Line |
|---|---|
| Private field 'rendererMap' could be made final; it is only initialized in the declaration or constructor. | 36 |
| Parameter 'merged' is not assigned and could be declared final | 44 |
| Parameter 'rendererConfig' is not assigned and could be declared final | 52 |
| Parameter 'markup' is not assigned and could be declared final | 61 |
| Parameter 'rendererName' is not assigned and could be declared final | 61 |
| Local variable 'rendererConfig' could be declared final | 65 |
| Avoid if (x != y) ..; else ..; | 66 - 71 |
| Parameter 'renderersConfig' is not assigned and could be declared final | 74 |
| Parameter 'override' is not assigned and could be declared final | 74 |
| Local variable 'renderers' could be declared final | 75 |
Tobago Core - org/apache/myfaces/tobago/internal/config/ThemeParser.java
| Violation | Line |
|---|---|
| Local variable 'theme' could be declared final | 86 |
Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigBuilder.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 37 - 187 |
| The class 'TobagoConfigBuilder' has a Cyclomatic Complexity of 5 (Highest = 8). | 37 - 187 |
| Avoid unused private fields such as 'WEB_INF_TOBAGO_CONFIG_XML'. | 41 |
| Avoid unused private fields such as 'WEB_INF_TOBAGO_CONFIG_XML'. | 41 |
| Private field 'list' could be made final; it is only initialized in the declaration or constructor. | 48 |
| Parameter 'servletContext' is not assigned and could be declared final | 50 |
| Parameter 'servletContext' is not assigned and could be declared final | 68 |
| Avoid unused local variables such as 'builder'. | 70 |
| Avoid unused local variables such as 'builder'. | 70 |
| Local variable 'error' could be declared final | 73 |
| Parameter 'servletContext' is not assigned and could be declared final | 80 |
| The method 'mergeList' has a Cyclomatic Complexity of 8. | 88 - 144 |
| Local variable 'sorter' could be declared final | 92 |
| Local variable 'result' could be declared final | 94 |
| The method 'configFromClasspath' has a Cyclomatic Complexity of 8. | 146 - 184 |
| Local variable 'parser' could be declared final | 148 |
| Local variable 'classLoader' could be declared final | 153 |
| Local variable 'urls' could be declared final | 154 |
| Avoid instantiating new objects inside loops | 161 |
| Avoid instantiating new objects inside loops | 164 |
| Local variable 'protocol' could be declared final | 169 |
| Local variable 'msg' could be declared final | 180 |
Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigFragment.java
| Violation | Line |
|---|---|
| Private field 'before' could be made final; it is only initialized in the declaration or constructor. | 36 |
| Private field 'after' could be made final; it is only initialized in the declaration or constructor. | 37 |
| Private field 'supportedThemeNames' could be made final; it is only initialized in the declaration or constructor. | 39 |
| Private field 'resourceDirs' could be made final; it is only initialized in the declaration or constructor. | 41 |
| Private field 'contentSecurityPolicy' could be made final; it is only initialized in the declaration or constructor. | 46 |
| Private field 'themeDefinitions' could be made final; it is only initialized in the declaration or constructor. | 48 |
| Parameter 'name' is not assigned and could be declared final | 60 |
| Parameter 'defaultThemeName' is not assigned and could be declared final | 72 |
| Parameter 'resourceDir' is not assigned and could be declared final | 76 |
| Parameter 'value' is not assigned and could be declared final | 91 |
| Parameter 'renderersConfig' is not assigned and could be declared final | 99 |
| Parameter 'name' is not assigned and could be declared final | 107 |
| Parameter 'name' is not assigned and could be declared final | 115 |
| Parameter 'name' is not assigned and could be declared final | 123 |
| Parameter 'theme' is not assigned and could be declared final | 127 |
| Parameter 'createSessionSecret' is not assigned and could be declared final | 139 |
| Parameter 'checkSessionSecret' is not assigned and could be declared final | 147 |
| Parameter 'preventFrameAttacks' is not assigned and could be declared final | 155 |
| Parameter 'directive' is not assigned and could be declared final | 163 |
| Parameter 'value' is not assigned and could be declared final | 169 |
| Parameter 'value' is not assigned and could be declared final | 175 |
| Parameter 'url' is not assigned and could be declared final | 183 |
| Avoid if (x != y) ..; else ..; | 189 |
Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigImpl.java
| Violation | Line |
|---|---|
| The class 'TobagoConfigImpl' has a Cyclomatic Complexity of 2 (Highest = 10). | 46 - 336 |
| This class has too many methods, consider refactoring it. | 46 - 336 |
| The class 'TobagoConfigImpl' has a Cyclomatic Complexity of 2 (Highest = 10). | 46 - 336 |
| Private field 'supportedThemes' could be made final; it is only initialized in the declaration or constructor. | 52 |
| Private field 'supportedThemeNames' could be made final; it is only initialized in the declaration or constructor. | 53 |
| Private field 'resourceDirs' could be made final; it is only initialized in the declaration or constructor. | 56 |
| Private field 'contentSecurityPolicy' could be made final; it is only initialized in the declaration or constructor. | 63 |
| Parameter 'name' is not assigned and could be declared final | 76 |
| The method 'resolveThemes' has a Cyclomatic Complexity of 10. | 80 - 120 |
| The method 'resolveThemes' has a Cyclomatic Complexity of 10. | 80 - 120 |
| Avoid if (x != y) ..; else ..; | 81 - 108 |
| Local variable 'theme' could be declared final | 91 |
| Local variable 'error' could be declared final | 98 - 100 |
| Local variable 'theme' could be declared final | 111 |
| Parameter 'name' is not assigned and could be declared final | 122 |
| Parameter 'theme' is not assigned and could be declared final | 122 |
| Local variable 'error' could be declared final | 124 - 126 |
| Parameter 'name' is not assigned and could be declared final | 132 |
| The method 'getTheme' has a Cyclomatic Complexity of 5. | 132 - 147 |
| Parameter 'defaultThemeName' is not assigned and could be declared final | 149 |
| Parameter 'resourceDir' is not assigned and could be declared final | 157 |
| Parameter 'availableThemes' is not assigned and could be declared final | 181 |
| Parameter 'renderersConfig' is not assigned and could be declared final | 192 |
| Parameter 'servletContext' is not assigned and could be declared final | 200 |
| The method 'initProjectState' has a Cyclomatic Complexity of 10. | 200 - 238 |
| The method 'initProjectState' has a Cyclomatic Complexity of 10. | 200 - 238 |
| Local variable 'ctx' could be declared final | 203 |
| Local variable 'obj' could be declared final | 204 |
| Avoid empty catch blocks | 213 - 215 |
| Avoid empty catch blocks | 213 - 215 |
| Use block level rather than method level synchronization | 240 - 262 |
| The method 'initDefaultValidatorInfo' has a Cyclomatic Complexity of 6. | 240 - 262 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 248 |
| Parameter 'createSessionSecret' is not assigned and could be declared final | 268 |
| Parameter 'checkSessionSecret' is not assigned and could be declared final | 276 |
| Parameter 'preventFrameAttacks' is not assigned and could be declared final | 285 |
| Parameter 'directive' is not assigned and could be declared final | 293 |
| Local variable 'all' could be declared final | 331 |
Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigParser.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'TOBAGO_CONFIG_XSD_1_5'. | 45 |
| Avoid unused private fields such as 'TOBAGO_CONFIG_XSD_1_5'. | 45 |
| Avoid unused private fields such as 'TOBAGO_CONFIG_XSD_1_6'. | 46 |
| Avoid unused private fields such as 'TOBAGO_CONFIG_XSD_1_6'. | 46 |
| Private field 'digester' could be made final; it is only initialized in the declaration or constructor. | 48 |
| Parameter 'url' is not assigned and could be declared final | 57 |
| Local variable 'tobagoConfig' could be declared final | 63 |
| Parameter 'url' is not assigned and could be declared final | 76 |
| The String literal "setName" appears 4 times in this file; the first occurrence is on line 93 | 93 |
| Parameter 'publicId' is not assigned and could be declared final | 174 |
| Parameter 'entityUrl' is not assigned and could be declared final | 174 |
| Local variable 'url' could be declared final | 175 |
| Avoid if (x != y) ..; else ..; | 179 - 183 |
Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigSorter.java
| Violation | Line |
|---|---|
| The class 'TobagoConfigSorter' has a Cyclomatic Complexity of 4 (Highest = 6). | 30 - 218 |
| Private field 'list' could be made final; it is only initialized in the declaration or constructor. | 34 |
| Parameter 'list' is not assigned and could be declared final | 37 |
| Prefer StringBuffer over += for concatenating strings | 60 |
| The method 'makeTransitive' has a Cyclomatic Complexity of 6. | 68 - 83 |
| Avoid instantiation through private constructors from outside of the constructor's class. | 77 |
| Avoid instantiating new objects inside loops | 77 |
| Local variable 'buffer' could be declared final | 88 |
| Avoid instantiating new objects inside loops | 88 |
| The String literal "' < '" appears 4 times in this file; the first occurrence is on line 91 | 91 |
| StringBuffer.append is called 2 consecutive times with literal Strings. Use a single append with a single String. | 93 |
| Avoid appending characters as strings in StringBuffer.append. | 96 |
| The method 'ensureAntiSymmetric' has a Cyclomatic Complexity of 6. | 108 - 135 |
| Local variable 'buffer' could be declared final | 112 |
| Avoid instantiating new objects inside loops | 112 |
| StringBuffer.append is called 2 consecutive times with literal Strings. Use a single append with a single String. | 121 |
| Avoid appending characters as strings in StringBuffer.append. | 124 |
| Parameter 'b' is not assigned and could be declared final | 137 |
| Parameter 'a' is not assigned and could be declared final | 137 |
| The method 'createRelevantPairs' has a Cyclomatic Complexity of 6. | 147 - 166 |
| Local variable 'before' could be declared final | 154 |
| Avoid instantiation through private constructors from outside of the constructor's class. | 156 |
| Avoid instantiating new objects inside loops | 156 |
| Local variable 'after' could be declared final | 160 |
| Avoid instantiation through private constructors from outside of the constructor's class. | 162 |
| Avoid instantiating new objects inside loops | 162 |
| Parameter 'lower' is not assigned and could be declared final | 172 |
| Parameter 'higher' is not assigned and could be declared final | 172 |
| Parameter 'name' is not assigned and could be declared final | 181 |
| Parameter 'lower' is not assigned and could be declared final | 199 |
| Parameter 'higher' is not assigned and could be declared final | 199 |
Tobago Core - org/apache/myfaces/tobago/internal/context/ClientPropertiesKey.java
| Violation | Line |
|---|---|
| The class 'ClientPropertiesKey' has a Cyclomatic Complexity of 2 (Highest = 8). | 32 - 129 |
| Parameter 'facesContext' is not assigned and could be declared final | 43 |
| Local variable 'requestMap' could be declared final | 45 |
| Local variable 'clientProperties' could be declared final | 48 |
| Parameter 'facesContext' is not assigned and could be declared final | 56 |
| Local variable 'requestMap' could be declared final | 57 |
| Parameter 'clientProperties' is not assigned and could be declared final | 61 |
| Parameter 'o' is not assigned and could be declared final | 70 |
| The method 'equals' has a Cyclomatic Complexity of 8. | 70 - 94 |
| Local variable 'that' could be declared final | 78 |
Tobago Core - org/apache/myfaces/tobago/internal/context/ImageCacheKey.java
| Violation | Line |
|---|---|
| Parameter 'clientPropertiesKey' is not assigned and could be declared final | 27 |
| Parameter 'name' is not assigned and could be declared final | 27 |
| Parameter 'o' is not assigned and could be declared final | 34 |
| Local variable 'that' could be declared final | 42 |
Tobago Core - org/apache/myfaces/tobago/internal/context/JspCacheKey.java
| Violation | Line |
|---|---|
| Parameter 'cacheKey' is not assigned and could be declared final | 27 |
| Parameter 'name' is not assigned and could be declared final | 27 |
| Parameter 'o' is not assigned and could be declared final | 34 |
| Local variable 'that' could be declared final | 42 |
Tobago Core - org/apache/myfaces/tobago/internal/context/MeasureValue.java
| Violation | Line |
|---|---|
| The class 'MeasureValue' has a Cyclomatic Complexity of 2 (Highest = 6). | 27 - 68 |
| Private field 'value' could be made final; it is only initialized in the declaration or constructor. | 31 |
| Parameter 'value' is not assigned and could be declared final | 33 |
| Parameter 'o' is not assigned and could be declared final | 42 |
| The method 'equals' has a Cyclomatic Complexity of 6. | 42 - 57 |
| Local variable 'that' could be declared final | 50 |
| Avoid if (x != y) ..; else ..; | 52 |
| Avoid if (x != y) ..; else ..; | 61 |
| Do not add empty strings | 66 |
Tobago Core - org/apache/myfaces/tobago/internal/context/MiscCacheKey.java
| Violation | Line |
|---|---|
| Parameter 'cacheKey' is not assigned and could be declared final | 27 |
| Parameter 'name' is not assigned and could be declared final | 27 |
| Parameter 'o' is not assigned and could be declared final | 34 |
| Local variable 'that' could be declared final | 42 |
Tobago Core - org/apache/myfaces/tobago/internal/context/PropertyCacheKey.java
| Violation | Line |
|---|---|
| Parameter 'cacheKey' is not assigned and could be declared final | 28 |
| Parameter 'name' is not assigned and could be declared final | 28 |
| Parameter 'key' is not assigned and could be declared final | 28 |
| Parameter 'o' is not assigned and could be declared final | 36 |
| Local variable 'that' could be declared final | 44 |
Tobago Core - org/apache/myfaces/tobago/internal/context/RendererCacheKey.java
| Violation | Line |
|---|---|
| Parameter 'cacheKey' is not assigned and could be declared final | 27 |
| Parameter 'name' is not assigned and could be declared final | 27 |
| Parameter 'o' is not assigned and could be declared final | 34 |
| Local variable 'that' could be declared final | 42 |
Tobago Core - org/apache/myfaces/tobago/internal/context/ResourceLocator.java
| Violation | Line |
|---|---|
| The class 'ResourceLocator' has a Cyclomatic Complexity of 7 (Highest = 17). | 57 - 431 |
| The class 'ResourceLocator' has a Cyclomatic Complexity of 7 (Highest = 17). | 57 - 431 |
| Private field 'servletContext' could be made final; it is only initialized in the declaration or constructor. | 65 |
| Private field 'resourceManager' could be made final; it is only initialized in the declaration or constructor. | 66 |
| Private field 'themeBuilder' could be made final; it is only initialized in the declaration or constructor. | 67 |
| Parameter 'servletContext' is not assigned and could be declared final | 70 |
| Parameter 'resourceManager' is not assigned and could be declared final | 70 |
| Parameter 'themeBuilder' is not assigned and could be declared final | 70 |
| The method 'locateResourcesInWar' has a Cyclomatic Complexity of 14. | 84 - 135 |
| The method locateResourcesInWar() has an NPath complexity of 240 | 84 - 135 |
| The method 'locateResourcesInWar' has a Cyclomatic Complexity of 14. | 84 - 135 |
| Avoid reassigning parameters such as 'path' | 85 |
| Parameter 'resources' is not assigned and could be declared final | 85 |
| Parameter 'servletContext' is not assigned and could be declared final | 85 |
| Local variable 'resourcePaths' could be declared final | 95 |
| Local variable 'inputStream' could be declared final | 114 |
| Local variable 'inputStream' could be declared final | 121 |
| Parameter 'resources' is not assigned and could be declared final | 137 |
| The method 'locateResourcesFromClasspath' has a Cyclomatic Complexity of 10. | 137 - 196 |
| The method 'locateResourcesFromClasspath' has a Cyclomatic Complexity of 10. | 137 - 196 |
| Local variable 'parser' could be declared final | 140 |
| Local variable 'classLoader' could be declared final | 145 |
| Local variable 'urls' could be declared final | 146 |
| Local variable 'tobagoConfig' could be declared final | 152 |
| Avoid instantiating new objects inside loops | 152 |
| Local variable 'themeUrlStr' could be declared final | 155 |
| Local variable 'index' could be declared final | 156 |
| Local variable 'metaInf' could be declared final | 157 |
| Local variable 'properties' could be declared final | 158 |
| Avoid instantiating new objects inside loops | 158 |
| Avoid instantiating new objects inside loops | 159 |
| Avoid if (x != y) ..; else ..; | 172 - 178 |
| Local variable 'msg' could be declared final | 188 |
| The String literal "while loading " appears 4 times in this file; the first occurrence is on line 188 | 188 |
| Local variable 'msg' could be declared final | 192 |
| Parameter 'resources' is not assigned and could be declared final | 198 |
| Parameter 'themeUrl' is not assigned and could be declared final | 198 |
| Parameter 'theme' is not assigned and could be declared final | 198 |
| Local variable 'prefix' could be declared final | 201 |
| Local variable 'protocol' could be declared final | 203 |
| Parameter 'resources' is not assigned and could be declared final | 220 |
| The method 'locateResourcesServlet30Alike' has a Cyclomatic Complexity of 8. | 220 - 254 |
| Local variable 'classLoader' could be declared final | 226 |
| Local variable 'urls' could be declared final | 227 |
| Local variable 'resourcesUrl' could be declared final | 230 |
| Local variable 'protocol' could be declared final | 240 |
| Local variable 'msg' could be declared final | 250 |
| Parameter 'skipPrefix' is not assigned and could be declared final | 256 |
| Parameter 'resources' is not assigned and could be declared final | 256 |
| Parameter 'themeUrl' is not assigned and could be declared final | 256 |
| Parameter 'prefix' is not assigned and could be declared final | 256 |
| The method 'addResources' has a Cyclomatic Complexity of 17. | 256 - 322 |
| The method addResources() has an NPath complexity of 416 | 256 - 322 |
| The method 'addResources' has a Cyclomatic Complexity of 17. | 256 - 322 |
| Local variable 'index' could be declared final | 263 |
| String.indexOf(char) is faster than String.indexOf(String). | 263 |
| Local variable 'protocol' could be declared final | 264 |
| Do not add empty strings | 269 |
| Position literals first in String comparisons | 273 |
| Local variable 'uri' could be declared final | 276 |
| Local variable 'tobagoThemeXml' could be declared final | 277 |
| Local variable 'directoryFile' could be declared final | 278 |
| Local variable 'resourcePath' could be declared final | 279 |
| Position literals first in String comparisons | 288 |
| Local variable 'nextEntry' could be declared final | 308 |
| Local variable 'name' could be declared final | 312 |
| Parameter 'resources' is not assigned and could be declared final | 324 |
| Parameter 'directoryFile' is not assigned and could be declared final | 324 |
| The method 'resolveTheme' has a Cyclomatic Complexity of 7. | 324 - 343 |
| Avoid reassigning parameters such as 'inResourcePath' | 325 |
| Parameter 'resourcePath' is not assigned and could be declared final | 325 |
| Parameter 'prefix' is not assigned and could be declared final | 325 |
| Local variable 'files' could be declared final | 326 |
| Local variable 'currentResourcePath' could be declared final | 329 |
| Parameter 'skipPrefix' is not assigned and could be declared final | 345 |
| Parameter 'resources' is not assigned and could be declared final | 345 |
| Parameter 'name' is not assigned and could be declared final | 345 |
| The method 'addResource' has a Cyclomatic Complexity of 6. | 345 - 373 |
| Avoid empty if statements | 348 - 350 |
| Avoid empty if statements | 348 - 350 |
| Local variable 'inputStream' could be declared final | 354 |
| Local variable 'inputStream' could be declared final | 364 |
| Avoid reassigning parameters such as 'resourcePath' | 375 |
| Avoid reassigning parameters such as 'resourcePath' | 375 |
| This call to String.startsWith can be rewritten using String.charAt(0) | 376 |
| The method 'addProperties' has a Cyclomatic Complexity of 8. | 385 - 430 |
| Parameter 'skipPrefix' is not assigned and could be declared final | 386 |
| Parameter 'resources' is not assigned and could be declared final | 386 |
| Parameter 'stream' is not assigned and could be declared final | 386 |
| Parameter 'xml' is not assigned and could be declared final | 386 |
| Parameter 'childPath' is not assigned and could be declared final | 386 |
| Local variable 'directory' could be declared final | 389 |
| Local variable 'filename' could be declared final | 390 |
| Local variable 'locale' could be declared final | 397 |
| Local variable 'temp' could be declared final | 400 |
| Local variable 'msg' could be declared final | 416 |
| Local variable 'e' could be declared final | 423 |
| Local variable 'key' could be declared final | 424 |
Tobago Core - org/apache/myfaces/tobago/internal/context/ResourceManagerFactory.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 29 - 71 |
| Parameter 'facesContext' is not assigned and could be declared final | 39 |
| Parameter 'servletContext' is not assigned and could be declared final | 45 |
| Parameter 'servletContext' is not assigned and could be declared final | 51 |
| Parameter 'tobagoConfig' is not assigned and could be declared final | 51 |
| Local variable 'resourceManager' could be declared final | 54 |
| Local variable 'themeBuilder' could be declared final | 56 |
| Local variable 'resourceLocator' could be declared final | 57 |
| Parameter 'servletContext' is not assigned and could be declared final | 66 |
Tobago Core - org/apache/myfaces/tobago/internal/context/ResourceManagerImpl.java
| Violation | Line |
|---|---|
| The class 'ResourceManagerImpl' has a Cyclomatic Complexity of 5 (Highest = 30). | 43 - 582 |
| The class 'ResourceManagerImpl' has a Cyclomatic Complexity of 5 (Highest = 30). | 43 - 582 |
| Private field 'production' could be made final; it is only initialized in the declaration or constructor. | 50 |
| Private field 'tobagoConfig' could be made final; it is only initialized in the declaration or constructor. | 68 |
| Parameter 'tobagoConfig' is not assigned and could be declared final | 70 |
| Parameter 'resourceKey' is not assigned and could be declared final | 75 |
| Parameter 'resourceKey' is not assigned and could be declared final | 82 |
| Parameter 'value' is not assigned and could be declared final | 82 |
| Parameter 'name' is not assigned and could be declared final | 90 |
| Parameter 'viewRoot' is not assigned and could be declared final | 90 |
| Local variable 'clientKey' could be declared final | 94 |
| Local variable 'cacheKey' could be declared final | 95 |
| The String literal "name = '" appears 4 times in this file; the first occurrence is on line 106 | 106 |
| The String literal "' clientProperties = '" appears 4 times in this file; the first occurrence is on line 106 | 106 |
| Parameter 'bundle' is not assigned and could be declared final | 113 |
| Parameter 'propertyKey' is not assigned and could be declared final | 113 |
| Parameter 'viewRoot' is not assigned and could be declared final | 113 |
| Parameter 'facesContext' is not assigned and could be declared final | 117 |
| Parameter 'bundle' is not assigned and could be declared final | 117 |
| Parameter 'propertyKey' is not assigned and could be declared final | 117 |
| The method 'getProperty' has a Cyclomatic Complexity of 5. | 117 - 136 |
| Local variable 'clientKey' could be declared final | 120 |
| Local variable 'cacheKey' could be declared final | 121 |
| Local variable 'properties' could be declared final | 125 |
| Avoid if (x != y) ..; else ..; | 126 - 130 |
| Parameter 'rendererType' is not assigned and could be declared final | 139 |
| Parameter 'viewRoot' is not assigned and could be declared final | 139 |
| Parameter 'rendererType' is not assigned and could be declared final | 143 |
| Parameter 'facesContext' is not assigned and could be declared final | 143 |
| The method 'getRenderer' has a Cyclomatic Complexity of 7. | 143 - 172 |
| Local variable 'clientKey' could be declared final | 147 |
| Local variable 'cacheKey' could be declared final | 148 |
| Local variable 'classes' could be declared final | 157 |
| Avoid if (x != y) ..; else ..; | 158 - 164 |
| Local variable 'clazz' could be declared final | 159 |
| Parameter 'name' is not assigned and could be declared final | 175 |
| Parameter 'viewRoot' is not assigned and could be declared final | 175 |
| Parameter 'facesContext' is not assigned and could be declared final | 179 |
| Parameter 'name' is not assigned and could be declared final | 179 |
| Parameter 'name' is not assigned and could be declared final | 184 |
| Parameter 'viewRoot' is not assigned and could be declared final | 184 |
| Parameter 'facesContext' is not assigned and could be declared final | 188 |
| Parameter 'name' is not assigned and could be declared final | 188 |
| Parameter 'bundle' is not assigned and could be declared final | 193 |
| Parameter 'propertyKey' is not assigned and could be declared final | 193 |
| Parameter 'viewRoot' is not assigned and could be declared final | 193 |
| The method 'getThemeProperty' has a Cyclomatic Complexity of 5. | 193 - 212 |
| Local variable 'clientKey' could be declared final | 196 |
| Local variable 'cacheKey' could be declared final | 197 |
| Local variable 'properties' could be declared final | 201 |
| Avoid if (x != y) ..; else ..; | 202 - 206 |
| Parameter 'configurable' is not assigned and could be declared final | 214 |
| Parameter 'facesContext' is not assigned and could be declared final | 214 |
| Parameter 'name' is not assigned and could be declared final | 214 |
| Parameter 'rendererType' is not assigned and could be declared final | 218 |
| Parameter 'markup' is not assigned and could be declared final | 218 |
| Parameter 'facesContext' is not assigned and could be declared final | 218 |
| Parameter 'name' is not assigned and could be declared final | 218 |
| The method 'getThemeMeasure' has a Cyclomatic Complexity of 7. | 218 - 253 |
| Local variable 'clientKey' could be declared final | 220 |
| Local variable 'cacheKey' could be declared final | 221 |
| Local variable 'properties' could be declared final | 226 - 227 |
| Local variable 'mProperties' could be declared final | 236 - 237 |
| Avoid if (x != y) ..; else ..; | 245 - 249 |
| Parameter 'name' is not assigned and could be declared final | 256 |
| Parameter 'viewRoot' is not assigned and could be declared final | 256 |
| Parameter 'facesContext' is not assigned and could be declared final | 260 |
| Parameter 'name' is not assigned and could be declared final | 260 |
| Parameter 'name' is not assigned and could be declared final | 265 |
| Parameter 'ignoreMissing' is not assigned and could be declared final | 265 |
| Parameter 'viewRoot' is not assigned and could be declared final | 265 |
| Parameter 'facesContext' is not assigned and could be declared final | 269 |
| Parameter 'name' is not assigned and could be declared final | 269 |
| Parameter 'ignoreMissing' is not assigned and could be declared final | 269 |
| The method 'getImage' has a Cyclomatic Complexity of 7. | 269 - 300 |
| Local variable 'clientKey' could be declared final | 276 |
| Local variable 'cacheKey' could be declared final | 277 |
| Local variable 'paths' could be declared final | 281 - 282 |
| Avoid if (x != y) ..; else ..; | 283 - 287 |
| These nested if statements could be combined | 291 - 293 |
| These nested if statements could be combined | 291 - 293 |
| The method 'getPaths' has a Cyclomatic Complexity of 30. | 302 - 387 |
| The method getPaths() has an NPath complexity of 2100 | 302 - 387 |
| Avoid really long parameter lists. | 302 - 305 |
| The method 'getPaths' has a Cyclomatic Complexity of 30. | 302 - 387 |
| Parameter 'prefix' is not assigned and could be declared final | 303 |
| Parameter 'subDir' is not assigned and could be declared final | 303 |
| Parameter 'name' is not assigned and could be declared final | 303 |
| Parameter 'suffix' is not assigned and could be declared final | 303 |
| Parameter 'clientkey' is not assigned and could be declared final | 303 |
| Parameter 'reverseOrder' is not assigned and could be declared final | 304 |
| Parameter 'single' is not assigned and could be declared final | 304 |
| Parameter 'returnKey' is not assigned and could be declared final | 304 |
| Parameter 'returnStrings' is not assigned and could be declared final | 304 |
| Parameter 'key' is not assigned and could be declared final | 304 |
| Parameter 'ignoreMissing' is not assigned and could be declared final | 305 |
| Local variable 'matches' could be declared final | 306 |
| Local variable 'contentType' could be declared final | 307 |
| Local variable 'theme' could be declared final | 308 |
| Local variable 'browser' could be declared final | 309 |
| Local variable 'locales' could be declared final | 310 |
| Local variable 'found' could be declared final | 328 - 329 |
| Local variable 'found' could be declared final | 358 - 360 |
| The method 'checkPath' has a Cyclomatic Complexity of 11. | 389 - 430 |
| Avoid really long parameter lists. | 389 - 391 |
| The method 'checkPath' has a Cyclomatic Complexity of 11. | 389 - 430 |
| Parameter 'reverseOrder' is not assigned and could be declared final | 390 |
| Parameter 'returnKey' is not assigned and could be declared final | 390 |
| Parameter 'prefix' is not assigned and could be declared final | 390 |
| Parameter 'returnStrings' is not assigned and could be declared final | 390 |
| Parameter 'extension' is not assigned and could be declared final | 391 |
| Parameter 'matches' is not assigned and could be declared final | 391 |
| Parameter 'localeSuffix' is not assigned and could be declared final | 391 |
| Parameter 'name' is not assigned and could be declared final | 391 |
| Parameter 'minimizeSuffix' is not assigned and could be declared final | 391 |
| Parameter 'key' is not assigned and could be declared final | 391 |
| Local variable 'result' could be declared final | 394 - 397 |
| Avoid if (x != y) ..; else ..; | 409 - 428 |
| Local variable 'clazz' could be declared final | 412 |
| The String literal "testing path: " appears 6 times in this file; the first occurrence is on line 414 | 414 |
| The method 'checkPath' has a Cyclomatic Complexity of 14. | 432 - 478 |
| Avoid really long parameter lists. | 432 - 435 |
| The method 'checkPath' has a Cyclomatic Complexity of 14. | 432 - 478 |
| Parameter 'reverseOrder' is not assigned and could be declared final | 433 |
| Parameter 'returnKey' is not assigned and could be declared final | 433 |
| Parameter 'prefix' is not assigned and could be declared final | 433 |
| Parameter 'returnStrings' is not assigned and could be declared final | 433 |
| Parameter 'browserType' is not assigned and could be declared final | 434 |
| Parameter 'contentType' is not assigned and could be declared final | 434 |
| Parameter 'currentTheme' is not assigned and could be declared final | 434 |
| Parameter 'matches' is not assigned and could be declared final | 434 |
| Parameter 'resourceDirectory' is not assigned and could be declared final | 434 |
| Parameter 'localeSuffix' is not assigned and could be declared final | 435 |
| Parameter 'subDir' is not assigned and could be declared final | 435 |
| Parameter 'minimizeSuffix' is not assigned and could be declared final | 435 |
| Parameter 'suffix' is not assigned and could be declared final | 435 |
| Parameter 'name' is not assigned and could be declared final | 435 |
| Parameter 'key' is not assigned and could be declared final | 435 |
| Avoid if (x != y) ..; else ..; | 457 - 476 |
| Local variable 'clazz' could be declared final | 460 |
| The method 'makePath' has a Cyclomatic Complexity of 5. | 480 - 514 |
| Avoid really long parameter lists. | 480 - 482 |
| Parameter 'project' is not assigned and could be declared final | 481 |
| Parameter 'theme' is not assigned and could be declared final | 481 |
| Parameter 'subDir' is not assigned and could be declared final | 481 |
| Parameter 'browser' is not assigned and could be declared final | 481 |
| Parameter 'language' is not assigned and could be declared final | 481 |
| Parameter 'extension' is not assigned and could be declared final | 482 |
| Parameter 'localeSuffix' is not assigned and could be declared final | 482 |
| Parameter 'name' is not assigned and could be declared final | 482 |
| Parameter 'minimizeSuffix' is not assigned and could be declared final | 482 |
| Parameter 'key' is not assigned and could be declared final | 482 |
| Parameter 'version' is not assigned and could be declared final | 482 |
| Local variable 'searchtext' could be declared final | 483 |
| Parameter 'extension' is not assigned and could be declared final | 517 |
| Parameter 'localeSuffix' is not assigned and could be declared final | 517 |
| Parameter 'name' is not assigned and could be declared final | 517 |
| Parameter 'minimizeSuffix' is not assigned and could be declared final | 517 |
| Parameter 'key' is not assigned and could be declared final | 517 |
| Local variable 'searchtext' could be declared final | 518 |
| Parameter 'rendererType' is not assigned and could be declared final | 535 |
| Prefer StringBuffer over += for concatenating strings | 545 |
| Parameter 'facesContext' is not assigned and could be declared final | 554 |
| Parameter 'name' is not assigned and could be declared final | 554 |
| Parameter 'type' is not assigned and could be declared final | 554 |
| The method 'getStrings' has a Cyclomatic Complexity of 6. | 554 - 580 |
| Local variable 'key' could be declared final | 562 |
| Local variable 'miscKey' could be declared final | 563 |
| Local variable 'cacheResult' could be declared final | 564 |
| Local variable 'matches' could be declared final | 569 - 570 |
Tobago Core - org/apache/myfaces/tobago/internal/context/ResponseWriterDivider.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 37 - 155 |
| Private field 'writers' could be made final; it is only initialized in the declaration or constructor. | 41 |
| Private field 'buffers' could be made final; it is only initialized in the declaration or constructor. | 42 |
| Private field 'original' could be made final; it is only initialized in the declaration or constructor. | 44 |
| Parameter 'facesContext' is not assigned and could be declared final | 50 |
| Parameter 'nameInRequest' is not assigned and could be declared final | 50 |
| Parameter 'facesContext' is not assigned and could be declared final | 62 |
| Parameter 'facesContext' is not assigned and could be declared final | 76 |
| Local variable 'buffer' could be declared final | 83 |
| Local variable 'newWriter' could be declared final | 85 |
| Parameter 'facesContext' is not assigned and could be declared final | 103 |
| Parameter 'facesContext' is not assigned and could be declared final | 127 |
| Local variable 'builder' could be declared final | 139 |
Tobago Core - org/apache/myfaces/tobago/internal/context/StringValue.java
| Violation | Line |
|---|---|
| The class 'StringValue' has a Cyclomatic Complexity of 3 (Highest = 6). | 25 - 61 |
| Private field 'value' could be made final; it is only initialized in the declaration or constructor. | 29 |
| Parameter 'value' is not assigned and could be declared final | 31 |
| Parameter 'o' is not assigned and could be declared final | 40 |
| The method 'equals' has a Cyclomatic Complexity of 6. | 40 - 55 |
| Local variable 'that' could be declared final | 48 |
| Avoid if (x != y) ..; else ..; | 50 |
| Avoid if (x != y) ..; else ..; | 59 |
Tobago Core - org/apache/myfaces/tobago/internal/context/ThemeBuilder.java
| Violation | Line |
|---|---|
| The class 'ThemeBuilder' has a Cyclomatic Complexity of 4 (Highest = 10). | 34 - 83 |
| The class 'ThemeBuilder' has a Cyclomatic Complexity of 4 (Highest = 10). | 34 - 83 |
| Private field 'availableThemes' could be made final; it is only initialized in the declaration or constructor. | 38 |
| Private field 'tobagoConfig' could be made final; it is only initialized in the declaration or constructor. | 39 |
| Parameter 'tobagoConfig' is not assigned and could be declared final | 41 |
| The method 'resolveThemes' has a Cyclomatic Complexity of 10. | 45 - 78 |
| The method resolveThemes() has an NPath complexity of 384 | 45 - 78 |
| The method 'resolveThemes' has a Cyclomatic Complexity of 10. | 45 - 78 |
| Local variable 'map' could be declared final | 46 |
| Local variable 'fallbackName' could be declared final | 52 |
| Local variable 'fallback' could be declared final | 53 |
| Local variable 'result' could be declared final | 62 |
| Parameter 'theme' is not assigned and could be declared final | 80 |
Tobago Core - org/apache/myfaces/tobago/internal/context/ThemeConfigCacheKey.java
| Violation | Line |
|---|---|
| The class 'ThemeConfigCacheKey' has a Cyclomatic Complexity of 3 (Highest = 9). | 24 - 89 |
| Parameter 'rendererType' is not assigned and could be declared final | 33 |
| Parameter 'markup' is not assigned and could be declared final | 33 |
| Parameter 'clientPropertiesKey' is not assigned and could be declared final | 33 |
| Parameter 'name' is not assigned and could be declared final | 33 |
| Parameter 'o' is not assigned and could be declared final | 42 |
| The method 'equals' has a Cyclomatic Complexity of 9. | 42 - 66 |
| Local variable 'cacheKey' could be declared final | 50 |
| Avoid if (x != y) ..; else ..; | 58 |
| Avoid if (x != y) ..; else ..; | 72 |
Tobago Core - org/apache/myfaces/tobago/internal/layout/BankHead.java
| Violation | Line |
|---|---|
| Parameter 'token' is not assigned and could be declared final | 39 |
| Parameter 'token' is not assigned and could be declared final | 48 |
| Parameter 'intervalList' is not assigned and could be declared final | 56 |
| Parameter 'current' is not assigned and could be declared final | 64 |
| Parameter 'rendered' is not assigned and could be declared final | 72 |
Tobago Core - org/apache/myfaces/tobago/internal/layout/FactorList.java
| Violation | Line |
|---|---|
| The class 'FactorList' has a Cyclomatic Complexity of 5 (Highest = 4). | 29 - 56 |
| Avoid unused private fields such as 'LOG'. | 31 |
| Avoid unused private fields such as 'LOG'. | 31 |
| Parameter 'size' is not assigned and could be declared final | 33 |
| Local variable 'result' could be declared final | 35 |
Tobago Core - org/apache/myfaces/tobago/internal/layout/Grid.java
| Violation | Line |
|---|---|
| The class 'Grid' has a Cyclomatic Complexity of 5 (Highest = 55). | 32 - 498 |
| This class has too many methods, consider refactoring it. | 32 - 498 |
| The class 'Grid' has a Cyclomatic Complexity of 5 (Highest = 55). | 32 - 498 |
| Private field 'cells' could be made final; it is only initialized in the declaration or constructor. | 40 |
| Private field 'columnHeads' could be made final; it is only initialized in the declaration or constructor. | 42 |
| Private field 'columnCount' could be made final; it is only initialized in the declaration or constructor. | 45 |
| Parameter 'columns' is not assigned and could be declared final | 56 |
| Parameter 'rows' is not assigned and could be declared final | 56 |
| Avoid instantiating new objects inside loops | 65 |
| Avoid instantiating new objects inside loops | 69 |
| Local variable 'size' could be declared final | 71 |
| Avoid reassigning parameters such as 'columnSpan' | 78 |
| Avoid reassigning parameters such as 'columnSpan' | 78 |
| Parameter 'cell' is not assigned and could be declared final | 78 |
| Parameter 'rowSpan' is not assigned and could be declared final | 78 |
| The method 'add' has a Cyclomatic Complexity of 9. | 78 - 121 |
| Avoid instantiating new objects inside loops | 110 |
| Parameter 'orientation' is not assigned and could be declared final | 123 |
| Parameter 'j' is not assigned and could be declared final | 123 |
| Parameter 'i' is not assigned and could be declared final | 123 |
| Parameter 'column' is not assigned and could be declared final | 127 |
| Parameter 'row' is not assigned and could be declared final | 127 |
| Parameter 'cell' is not assigned and could be declared final | 138 |
| Parameter 'column' is not assigned and could be declared final | 138 |
| Parameter 'row' is not assigned and could be declared final | 138 |
| Parameter 'orientation' is not assigned and could be declared final | 156 |
| Parameter 'newRows' is not assigned and could be declared final | 160 |
| Local variable 'newRowHeads' could be declared final | 170 |
| Avoid instantiating new objects inside loops | 176 |
| Parameter 'orientation' is not assigned and could be declared final | 182 |
| Parameter 'orientation' is not assigned and could be declared final | 186 |
| Parameter 'overflow' is not assigned and could be declared final | 186 |
| Parameter 'columnOverflow' is not assigned and could be declared final | 198 |
| Parameter 'rowOverflow' is not assigned and could be declared final | 206 |
| Parameter 'j' is not assigned and could be declared final | 210 |
| Parameter 'i' is not assigned and could be declared final | 210 |
| Parameter 'j' is not assigned and could be declared final | 217 |
| Parameter 'i' is not assigned and could be declared final | 217 |
| The method 'gridAsString' has a Cyclomatic Complexity of 55. | 246 - 474 |
| The method gridAsString() has an NPath complexity of 11503356 | 246 - 474 |
| Avoid really long methods. | 246 - 474 |
| The method 'gridAsString' has a Cyclomatic Complexity of 55. | 246 - 474 |
| The method gridAsString() has an NCSS line count of 175 | 246 - 474 |
| Local variable 'builder' could be declared final | 248 |
| Avoid if (x != y) ..; else ..; | 253 - 257 |
| Local variable 'c' could be declared final | 259 |
| Local variable 'd' could be declared final | 260 |
| Avoid if (x != y) ..; else ..; | 277 - 281 |
| Avoid if (x != y) ..; else ..; | 284 - 288 |
| Local variable 'b' could be declared final | 297 |
| Local variable 'd' could be declared final | 298 |
| Local variable 'a' could be declared final | 315 |
| Local variable 'b' could be declared final | 316 |
| Local variable 'c' could be declared final | 317 |
| Local variable 'd' could be declared final | 318 |
| Local variable 'a' could be declared final | 358 |
| Local variable 'c' could be declared final | 359 |
| Local variable 'a' could be declared final | 366 |
| Local variable 'c' could be declared final | 367 |
| Avoid if (x != y) ..; else ..; | 389 - 393 |
| Local variable 'c' could be declared final | 395 |
| Local variable 'd' could be declared final | 396 |
| Local variable 'a' could be declared final | 412 |
| Local variable 'c' could be declared final | 413 |
| Avoid if (x != y) ..; else ..; | 425 - 429 |
| Avoid if (x != y) ..; else ..; | 436 - 440 |
| Local variable 'a' could be declared final | 442 |
| Local variable 'b' could be declared final | 443 |
| Avoid if (x != y) ..; else ..; | 460 - 464 |
| Avoid if (x != y) ..; else ..; | 466 - 470 |
| Local variable 'builder' could be declared final | 478 |
| Parameter 'b' is not assigned and could be declared final | 489 |
| Parameter 'a' is not assigned and could be declared final | 489 |
| The method 'connected' has a Cyclomatic Complexity of 5. | 489 - 497 |
Tobago Core - org/apache/myfaces/tobago/internal/layout/Interval.java
| Violation | Line |
|---|---|
| The class 'Interval' has a Cyclomatic Complexity of 3 (Highest = 6). | 29 - 103 |
| Parameter 'orientation' is not assigned and could be declared final | 41 |
| Parameter 'component' is not assigned and could be declared final | 41 |
| The constructor 'Interval' has a Cyclomatic Complexity of 5. | 41 - 47 |
| Parameter 'minimum' is not assigned and could be declared final | 49 |
| Parameter 'maximum' is not assigned and could be declared final | 49 |
| Parameter 'current' is not assigned and could be declared final | 49 |
| Parameter 'preferred' is not assigned and could be declared final | 49 |
| The constructor 'Interval' has a Cyclomatic Complexity of 6. | 49 - 62 |
| Parameter 'interval' is not assigned and could be declared final | 65 |
| Parameter 'divider' is not assigned and could be declared final | 65 |
| The constructor 'Interval' has a Cyclomatic Complexity of 5. | 65 - 71 |
| Avoid if (x != y) ..; else ..; | 66 - 67 |
| Avoid if (x != y) ..; else ..; | 68 |
| Avoid if (x != y) ..; else ..; | 69 |
| Avoid if (x != y) ..; else ..; | 70 |
| Local variable 'builder' could be declared final | 91 |
Tobago Core - org/apache/myfaces/tobago/internal/layout/IntervalList.java
| Violation | Line |
|---|---|
| The class 'IntervalList' has a Cyclomatic Complexity of 3 (Highest = 6). | 29 - 101 |
| Local variable 'minimumList' could be declared final | 37 |
| Local variable 'maximumList' could be declared final | 38 |
| Local variable 'maximum' could be declared final | 40 |
| Local variable 'preferred' could be declared final | 48 |
| Avoid if (x != y) ..; else ..; | 49 - 53 |
| Local variable 'result' could be declared final | 58 |
| Local variable 'result' could be declared final | 71 |
| Parameter 'min' is not assigned and could be declared final | 80 |
| Parameter 'max' is not assigned and could be declared final | 80 |
| The method 'findPreferredInInterval' has a Cyclomatic Complexity of 6. | 80 - 92 |
| Local variable 'result' could be declared final | 81 |
Tobago Core - org/apache/myfaces/tobago/internal/layout/LayoutContext.java
| Violation | Line |
|---|---|
| The class 'LayoutContext' has a Cyclomatic Complexity of 5 (Highest = 12). | 59 - 159 |
| The class 'LayoutContext' has a Cyclomatic Complexity of 5 (Highest = 12). | 59 - 159 |
| Private field 'container' could be made final; it is only initialized in the declaration or constructor. | 63 |
| Parameter 'container' is not assigned and could be declared final | 65 |
| The method 'layout' has a Cyclomatic Complexity of 12. | 69 - 120 |
| The method layout() has an NPath complexity of 2048 | 69 - 120 |
| The method 'layout' has a Cyclomatic Complexity of 12. | 69 - 120 |
| Local variable 'layoutManager' could be declared final | 78 |
| Parameter 'message' is not assigned and could be declared final | 122 |
| Parameter 'trace' is not assigned and could be declared final | 122 |
| Local variable 'buffer' could be declared final | 123 |
| Avoid concatenating nonliterals in a StringBuffer constructor or append(). | 123 |
| Parameter 'buffer' is not assigned and could be declared final | 132 |
| Parameter 'component' is not assigned and could be declared final | 132 |
| Parameter 'depth' is not assigned and could be declared final | 132 |
| The method 'log' has a Cyclomatic Complexity of 5. | 132 - 158 |
| Local variable 'facesContext' could be declared final | 133 |
| Avoid appending characters as strings in StringBuffer.append. | 136 |
| Avoid appending characters as strings in StringBuffer.append. | 139 |
| Avoid appending characters as strings in StringBuffer.append. | 143 |
| Local variable 'layoutManager' could be declared final | 146 |
| Avoid appending characters as strings in StringBuffer.append. | 148 |
| Avoid appending characters as strings in StringBuffer.append. | 154 |
Tobago Core - org/apache/myfaces/tobago/internal/layout/LayoutUtils.java
| Violation | Line |
|---|---|
| The class 'LayoutUtils' has a Cyclomatic Complexity of 3 (Highest = 8). | 37 - 129 |
| Avoid unused private fields such as 'LOG'. | 39 |
| Avoid unused private fields such as 'LOG'. | 39 |
| Parameter 'columns' is not assigned and could be declared final | 47 |
| Local variable 'st' could be declared final | 48 |
| Local variable 'token' could be declared final | 50 |
| Parameter 'container' is not assigned and could be declared final | 58 |
| Local variable 'result' could be declared final | 59 |
| Parameter 'result' is not assigned and could be declared final | 64 |
| Parameter 'component' is not assigned and could be declared final | 64 |
| Parameter 'orientation' is not assigned and could be declared final | 76 |
| Parameter 'container' is not assigned and could be declared final | 76 |
| Parameter 'orientation' is not assigned and could be declared final | 80 |
| Parameter 'container' is not assigned and could be declared final | 80 |
| Parameter 'orientation' is not assigned and could be declared final | 84 |
| Parameter 'container' is not assigned and could be declared final | 84 |
| Parameter 'orientation' is not assigned and could be declared final | 88 |
| Parameter 'container' is not assigned and could be declared final | 88 |
| Parameter 'orientation' is not assigned and could be declared final | 92 |
| Parameter 'component' is not assigned and could be declared final | 92 |
| Avoid reassigning parameters such as 'size' | 96 |
| Avoid reassigning parameters such as 'size' | 96 |
| Avoid reassigning parameters such as 'size' | 96 |
| Avoid reassigning parameters such as 'size' | 96 |
| Avoid reassigning parameters such as 'size' | 96 |
| Avoid reassigning parameters such as 'size' | 96 |
| Parameter 'orientation' is not assigned and could be declared final | 96 |
| Parameter 'component' is not assigned and could be declared final | 96 |
| The method 'setCurrentSize' has a Cyclomatic Complexity of 8. | 96 - 128 |
| Avoid if (x != y) ..; else ..; | 99 - 110 |
| Avoid if (x != y) ..; else ..; | 114 - 125 |
Tobago Core - org/apache/myfaces/tobago/internal/layout/MathUtils.java
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 22 - 108 |
| The class 'MathUtils' has a Cyclomatic Complexity of 2 (Highest = 5). | 22 - 108 |
| Avoid reassigning parameters such as 'bias' | 35 |
| Parameter 'list' is not assigned and could be declared final | 35 |
| Local variable 'remainder' could be declared final | 56 |
| The method 'findAndAdjustMinRemainder' has a Cyclomatic Complexity of 5. | 69 - 87 |
| Local variable 'remainder' could be declared final | 73 |
| Parameter 'v' is not assigned and could be declared final | 89 |
| Parameter 'factor' is not assigned and could be declared final | 93 |
| Parameter 'factor' is not assigned and could be declared final | 97 |
| Parameter 'value' is not assigned and could be declared final | 101 |
| Parameter 'value' is not assigned and could be declared final | 105 |
Tobago Core - org/apache/myfaces/tobago/internal/layout/OriginCell.java
| Violation | Line |
|---|---|
| Private field 'component' could be made final; it is only initialized in the declaration or constructor. | 27 |
| Parameter 'component' is not assigned and could be declared final | 31 |
| Parameter 'orientation' is not assigned and could be declared final | 51 |
| Parameter 'columnSpan' is not assigned and could be declared final | 59 |
| Parameter 'rowSpan' is not assigned and could be declared final | 67 |
Tobago Core - org/apache/myfaces/tobago/internal/layout/SpanCell.java
| Violation | Line |
|---|---|
| Private field 'origin' could be made final; it is only initialized in the declaration or constructor. | 26 |
| Private field 'horizontalFirst' could be made final; it is only initialized in the declaration or constructor. | 27 |
| Private field 'verticalFirst' could be made final; it is only initialized in the declaration or constructor. | 28 |
| Parameter 'verticalFirst' is not assigned and could be declared final | 30 |
| Parameter 'horizontalFirst' is not assigned and could be declared final | 30 |
| Parameter 'origin' is not assigned and could be declared final | 30 |
Tobago Core - org/apache/myfaces/tobago/internal/lifecycle/ApplyRequestValuesExecutor.java
| Violation | Line |
|---|---|
| Parameter 'facesContext' is not assigned and could be declared final | 32 |
Tobago Core - org/apache/myfaces/tobago/internal/lifecycle/InvokeApplicationExecutor.java
| Violation | Line |
|---|---|
| Parameter 'facesContext' is not assigned and could be declared final | 31 |
Tobago Core - org/apache/myfaces/tobago/internal/lifecycle/PhaseListenerManager.java
| Violation | Line |
|---|---|
| The class 'PhaseListenerManager' has a Cyclomatic Complexity of 4 (Highest = 6). | 38 - 111 |
| Private field 'lifecycle' could be made final; it is only initialized in the declaration or constructor. | 42 |
| Private field 'facesContext' could be made final; it is only initialized in the declaration or constructor. | 43 |
| Private field 'phaseListeners' could be made final; it is only initialized in the declaration or constructor. | 44 |
| Private field 'listenerSuccessMap' could be made final; it is only initialized in the declaration or constructor. | 49 |
| Parameter 'phaseListeners' is not assigned and could be declared final | 54 |
| Parameter 'lifecycle' is not assigned and could be declared final | 54 |
| Parameter 'facesContext' is not assigned and could be declared final | 54 |
| Parameter 'phaseListener' is not assigned and could be declared final | 60 |
| Parameter 'phaseId' is not assigned and could be declared final | 60 |
| Local variable 'listenerPhaseId' could be declared final | 61 |
| Parameter 'phaseId' is not assigned and could be declared final | 66 |
| The method 'informPhaseListenersBefore' has a Cyclomatic Complexity of 5. | 66 - 88 |
| Local variable 'phaseListener' could be declared final | 76 |
| Parameter 'phaseId' is not assigned and could be declared final | 90 |
| The method 'informPhaseListenersAfter' has a Cyclomatic Complexity of 6. | 90 - 110 |
| Local variable 'beforePhaseSuccess' could be declared final | 91 |
| Local variable 'phaseListener' could be declared final | 99 |
Tobago Core - org/apache/myfaces/tobago/internal/lifecycle/ProcessValidationsExecutor.java
| Violation | Line |
|---|---|
| Parameter 'facesContext' is not assigned and could be declared final | 31 |
Tobago Core - org/apache/myfaces/tobago/internal/lifecycle/RenderResponseExecutor.java
| Violation | Line |
|---|---|
| Parameter 'facesContext' is not assigned and could be declared final | 38 |
| Local variable 'application' could be declared final | 39 |
| Local variable 'viewHandler' could be declared final | 40 |
| Avoid if (x != y) ..; else ..; | 44 - 53 |
| Local variable 'respObj' could be declared final | 47 |
| Local variable 'respHttp' could be declared final | 49 |
Tobago Core - org/apache/myfaces/tobago/internal/lifecycle/RestoreViewExecutor.java
| Violation | Line |
|---|---|
| The class 'RestoreViewExecutor' has a Cyclomatic Complexity of 6 (Highest = 16). | 53 - 251 |
| The class 'RestoreViewExecutor' has a Cyclomatic Complexity of 6 (Highest = 16). | 53 - 251 |
| Parameter 'facesContext' is not assigned and could be declared final | 57 |
| The method 'execute' has a Cyclomatic Complexity of 16. | 57 - 139 |
| The method execute() has an NPath complexity of 3360 | 57 - 139 |
| The method 'execute' has a Cyclomatic Complexity of 16. | 57 - 139 |
| Local variable 'externalContext' could be declared final | 58 |
| Local variable 'sessionMap' could be declared final | 60 |
| Local variable 'messageHolders' could be declared final | 66 |
| Local variable 'viewId' could be declared final | 88 |
| Local variable 'application' could be declared final | 107 |
| Local variable 'viewHandler' could be declared final | 108 |
| Local variable 'postBack' could be declared final | 110 |
| Parameter 'facesContext' is not assigned and could be declared final | 141 |
| Local variable 'requestParameterMap' could be declared final | 142 |
| Parameter 'facesContext' is not assigned and could be declared final | 146 |
| Parameter 'facesContext' is not assigned and could be declared final | 158 |
| The method 'deriveViewId' has a Cyclomatic Complexity of 7. | 158 - 195 |
| Local variable 'externalContext' could be declared final | 159 |
| Local variable 'msg' could be declared final | 170 |
| Local variable 'defaultSuffix' could be declared final | 177 |
| Avoid if (x != y) ..; else ..; | 178 |
| Local variable 'suffix' could be declared final | 178 |
| Local variable 'msg' could be declared final | 180 |
| Local variable 'dot' could be declared final | 185 |
| Assigning an Object to null is a code smell. Consider refactoring. | 188 |
| Parameter 'facesContext' is not assigned and could be declared final | 199 |
| The method 'recursivelyHandleComponentReferencesAndSetValid' has a Cyclomatic Complexity of 8. | 199 - 228 |
| Parameter 'parent' is not assigned and could be declared final | 200 |
| Local variable 'forceHandle' could be declared final | 201 |
| Local variable 'handleBindingsMethod' could be declared final | 203 |
| Avoid if (x != y) ..; else ..; | 205 - 227 |
| Local variable 'it' could be declared final | 213 |
| Local variable 'component' could be declared final | 214 |
| Local variable 'binding' could be declared final | 216 |
| Parameter 'parent' is not assigned and could be declared final | 235 |
| Local variable 'interfaces' could be declared final | 236 |
| Avoid instantiating new objects inside loops | 241 |
| Avoid empty catch blocks | 242 - 244 |
| Avoid empty catch blocks | 242 - 244 |
Tobago Core - org/apache/myfaces/tobago/internal/lifecycle/TobagoLifecycle.java
| Violation | Line |
|---|---|
| The class 'TobagoLifecycle' has a Cyclomatic Complexity of 4 (Highest = 9). | 38 - 207 |
| Private field 'lifecycleExecutors' could be made final; it is only initialized in the declaration or constructor. | 45 |
| Private field 'renderExecutor' could be made final; it is only initialized in the declaration or constructor. | 46 |
| Parameter 'context' is not assigned and could be declared final | 68 |
| Local variable 'phaseListenerMgr' could be declared final | 70 |
| Parameter 'phaseListenerMgr' is not assigned and could be declared final | 83 |
| Parameter 'facesContext' is not assigned and could be declared final | 83 |
| Parameter 'executor' is not assigned and could be declared final | 83 |
| The method 'executePhase' has a Cyclomatic Complexity of 9. | 83 - 121 |
| The String literal " in " appears 4 times in this file; the first occurrence is on line 88 | 88 |
| Parameter 'facesContext' is not assigned and could be declared final | 123 |
| The method 'render' has a Cyclomatic Complexity of 5. | 123 - 150 |
| Local variable 'phaseListenerMgr' could be declared final | 132 |
| Parameter 'facesContext' is not assigned and could be declared final | 152 |
| Parameter 'before' is not assigned and could be declared final | 152 |
| Parameter 'phase' is not assigned and could be declared final | 152 |
| Parameter 'facesContext' is not assigned and could be declared final | 165 |
| Parameter 'before' is not assigned and could be declared final | 165 |
| Parameter 'phase' is not assigned and could be declared final | 165 |
| Parameter 'phaseListener' is not assigned and could be declared final | 178 |
| Assigning an Object to null is a code smell. Consider refactoring. | 184 |
| Parameter 'phaseListener' is not assigned and could be declared final | 188 |
| Assigning an Object to null is a code smell. Consider refactoring. | 194 |
Tobago Core - org/apache/myfaces/tobago/internal/lifecycle/TobagoLifecycleFactory.java
| Violation | Line |
|---|---|
| Private field 'factory' could be made final; it is only initialized in the declaration or constructor. | 33 |
| Private field 'defaultLifecycle' could be made final; it is only initialized in the declaration or constructor. | 34 |
| Parameter 'factory' is not assigned and could be declared final | 36 |
| Parameter 'lifecycle' is not assigned and could be declared final | 44 |
| Parameter 'lifecycleId' is not assigned and could be declared final | 44 |
| Do not add empty strings | 47 |
| Parameter 'lifecycleId' is not assigned and could be declared final | 51 |
Tobago Core - org/apache/myfaces/tobago/internal/lifecycle/UpdateModelValuesExecutor.java
| Violation | Line |
|---|---|
| Parameter 'facesContext' is not assigned and could be declared final | 32 |
Tobago Core - org/apache/myfaces/tobago/internal/taglib/TagUtils.java
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 52 - 307 |
| The class 'TagUtils' has a Cyclomatic Complexity of 3 (Highest = 9). | 52 - 307 |
| Avoid reassigning parameters such as 'value' | 59 |
| Parameter 'component' is not assigned and could be declared final | 59 |
| Parameter 'name' is not assigned and could be declared final | 59 |
| The method 'setIntegerProperty' has a Cyclomatic Complexity of 9. | 59 - 75 |
| These nested if statements could be combined | 68 - 70 |
| Deeply nested if..then statements are hard to read | 68 - 70 |
| These nested if statements could be combined | 68 - 70 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 72 |
| Parameter 'component' is not assigned and could be declared final | 81 |
| Parameter 'name' is not assigned and could be declared final | 81 |
| Parameter 'value' is not assigned and could be declared final | 81 |
| Parameter 'component' is not assigned and could be declared final | 95 |
| Parameter 'name' is not assigned and could be declared final | 95 |
| Parameter 'value' is not assigned and could be declared final | 95 |
| Parameter 'component' is not assigned and could be declared final | 109 |
| Parameter 'name' is not assigned and could be declared final | 109 |
| Parameter 'value' is not assigned and could be declared final | 109 |
| Local variable 'valueBinding' could be declared final | 114 |
| Local variable 'converter' could be declared final | 117 |
| Parameter 'component' is not assigned and could be declared final | 127 |
| Parameter 'name' is not assigned and could be declared final | 127 |
| Parameter 'value' is not assigned and could be declared final | 127 |
| Parameter 'component' is not assigned and could be declared final | 135 |
| Parameter 'name' is not assigned and could be declared final | 135 |
| Parameter 'value' is not assigned and could be declared final | 135 |
| Parameter 'component' is not assigned and could be declared final | 143 |
| Parameter 'name' is not assigned and could be declared final | 143 |
| Parameter 'value' is not assigned and could be declared final | 143 |
| Parameter 'value' is not assigned and could be declared final | 151 |
| Parameter 'component' is not assigned and could be declared final | 159 |
| Parameter 'args' is not assigned and could be declared final | 159 |
| Parameter 'value' is not assigned and could be declared final | 159 |
| Local variable 'methodBinding' could be declared final | 161 |
| Parameter 'component' is not assigned and could be declared final | 170 |
| Parameter 'args' is not assigned and could be declared final | 170 |
| Parameter 'value' is not assigned and could be declared final | 170 |
| Local variable 'methodBinding' could be declared final | 172 |
| Parameter 'component' is not assigned and could be declared final | 181 |
| Parameter 'args' is not assigned and could be declared final | 181 |
| Parameter 'value' is not assigned and could be declared final | 181 |
| Local variable 'methodBinding' could be declared final | 183 |
| Parameter 'component' is not assigned and could be declared final | 192 |
| Parameter 'args' is not assigned and could be declared final | 192 |
| Parameter 'value' is not assigned and could be declared final | 192 |
| Local variable 'methodBinding' could be declared final | 194 |
| Parameter 'component' is not assigned and could be declared final | 203 |
| Parameter 'args' is not assigned and could be declared final | 203 |
| Parameter 'value' is not assigned and could be declared final | 203 |
| Local variable 'methodBinding' could be declared final | 205 |
| Parameter 'component' is not assigned and could be declared final | 214 |
| Parameter 'args' is not assigned and could be declared final | 214 |
| Parameter 'value' is not assigned and could be declared final | 214 |
| Local variable 'methodBinding' could be declared final | 216 |
| Parameter 'component' is not assigned and could be declared final | 225 |
| Parameter 'args' is not assigned and could be declared final | 225 |
| Parameter 'value' is not assigned and could be declared final | 225 |
| Local variable 'methodBinding' could be declared final | 228 - 229 |
| Parameter 'component' is not assigned and could be declared final | 241 |
| Parameter 'args' is not assigned and could be declared final | 241 |
| Parameter 'value' is not assigned and could be declared final | 241 |
| Local variable 'methodBinding' could be declared final | 243 |
| Parameter 'component' is not assigned and could be declared final | 252 |
| Parameter 'name' is not assigned and could be declared final | 252 |
| Parameter 'value' is not assigned and could be declared final | 252 |
| The method 'setStringArrayProperty' has a Cyclomatic Complexity of 6. | 252 - 269 |
| Local variable 'components' could be declared final | 257 |
| Parameter 'component' is not assigned and could be declared final | 275 |
| Parameter 'name' is not assigned and could be declared final | 275 |
| Parameter 'value' is not assigned and could be declared final | 275 |
| Local variable 'valueBinding' could be declared final | 277 |
| Parameter 'component' is not assigned and could be declared final | 286 |
| Parameter 'name' is not assigned and could be declared final | 286 |
| Parameter 'value' is not assigned and could be declared final | 286 |
| Avoid reassigning parameters such as 'script' | 300 |
| Local variable 'valueBinding' could be declared final | 302 |
Tobago Core - org/apache/myfaces/tobago/internal/taglib/TobagoBodyTag.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'LOG'. | 31 |
| Avoid unused private fields such as 'LOG'. | 31 |
| Document empty method | 39 - 40 |
| An empty method in an abstract class should be abstract instead | 39 - 40 |
| Local variable 'content' could be declared final | 43 |
| Local variable 'content' could be declared final | 50 |
| Local variable 'tmp' could be declared final | 51 |
| String.trim().length()==0 is an inefficient way to validate an empty String. | 52 |
| Assigning an Object to null is a code smell. Consider refactoring. | 69 |
| Parameter 'bodyContent' is not assigned and could be declared final | 72 |
Tobago Core - org/apache/myfaces/tobago/internal/taglib/TobagoELTag.java
| Violation | Line |
|---|---|
| Local variable 'result' could be declared final | 35 |
| Local variable 'component' could be declared final | 36 |
| Local variable 'component' could be declared final | 47 |
| Local variable 'result' could be declared final | 48 |
| Parameter 'renderers' is not assigned and could be declared final | 57 |
| Local variable 'content' could be declared final | 67 |
| Local variable 'content' could be declared final | 79 |
| Local variable 'tmp' could be declared final | 80 |
| String.trim().length()==0 is an inefficient way to validate an empty String. | 81 |
Tobago Core - org/apache/myfaces/tobago/internal/taglib/TobagoTag.java
| Violation | Line |
|---|---|
| Local variable 'result' could be declared final | 32 |
| Local variable 'component' could be declared final | 34 |
| Parameter 'renderers' is not assigned and could be declared final | 43 |
Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/AttributeTag.java
| Violation | Line |
|---|---|
| The class 'AttributeTag' has a Cyclomatic Complexity of 3 (Highest = 8). | 47 - 141 |
| The method 'doStartTag' has a Cyclomatic Complexity of 8. | 59 - 95 |
| Local variable 'tag' could be declared final | 62 - 63 |
| Local variable 'component' could be declared final | 73 |
| Avoid if (x != y) ..; else ..; | 83 - 93 |
| Local variable 'components' could be declared final | 89 |
| Assigning an Object to null is a code smell. Consider refactoring. | 100 |
| Assigning an Object to null is a code smell. Consider refactoring. | 101 |
| Parameter 'name' is not assigned and could be declared final | 108 |
| Parameter 'value' is not assigned and could be declared final | 116 |
| Parameter 'mode' is not assigned and could be declared final | 137 |
Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/CellTagDeclaration.java
| Violation | Line |
|---|---|
| The String literal "java.lang.Integer" appears 4 times in this file; the first occurrence is on line 52 | 52 |
Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/CommandTagExtraInfo.java
| Violation | Line |
|---|---|
| Parameter 'data' is not assigned and could be declared final | 29 |
| Local variable 'action' could be declared final | 30 |
| Local variable 'onclick' could be declared final | 31 |
| Local variable 'link' could be declared final | 32 |
| Parameter 'data' is not assigned and could be declared final | 40 |
Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/ConverterTag.java
| Violation | Line |
|---|---|
| The class 'ConverterTag' has a Cyclomatic Complexity of 4 (Highest = 12). | 45 - 137 |
| The class 'ConverterTag' has a Cyclomatic Complexity of 4 (Highest = 12). | 45 - 137 |
| The method 'doStartTag' has a Cyclomatic Complexity of 12. | 61 - 113 |
| The method doStartTag() has an NPath complexity of 576 | 61 - 113 |
| The method 'doStartTag' has a Cyclomatic Complexity of 12. | 61 - 113 |
| Local variable 'tag' could be declared final | 64 - 65 |
| Local variable 'component' could be declared final | 75 |
| Local variable 'valueHolder' could be declared final | 84 |
| Local variable 'localConverterId' could be declared final | 96 |
| Avoid if (x != y) ..; else ..; | 102 - 109 |
| Local variable 've' could be declared final | 103 |
| Assigning an Object to null is a code smell. Consider refactoring. | 118 |
| Assigning an Object to null is a code smell. Consider refactoring. | 119 |
| Parameter 'converterId' is not assigned and could be declared final | 126 |
| Parameter 'binding' is not assigned and could be declared final | 134 |
Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/DataAttributeTag.java
| Violation | Line |
|---|---|
| Assigning an Object to null is a code smell. Consider refactoring. | 57 |
| Assigning an Object to null is a code smell. Consider refactoring. | 58 |
| Local variable 'tag' could be declared final | 67 - 68 |
| Parameter 'name' is not assigned and could be declared final | 100 |
| Parameter 'value' is not assigned and could be declared final | 110 |
Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/FileItemValidatorTag.java
| Violation | Line |
|---|---|
| Assigning an Object to null is a code smell. Consider refactoring. | 77 |
| Assigning an Object to null is a code smell. Consider refactoring. | 78 |
| Parameter 'maxSize' is not assigned and could be declared final | 82 |
| Parameter 'contentType' is not assigned and could be declared final | 87 |
Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/GridLayoutConstraintTag.java
| Violation | Line |
|---|---|
| The class 'GridLayoutConstraintTag' has a Cyclomatic Complexity of 3 (Highest = 39). | 46 - 460 |
| The class 'GridLayoutConstraintTag' has a Cyclomatic Complexity of 3 (Highest = 39). | 46 - 460 |
| Too many fields | 46 - 460 |
| The method 'doStartTag' has a Cyclomatic Complexity of 39. | 76 - 236 |
| Avoid really long methods. | 76 - 236 |
| The method 'doStartTag' has a Cyclomatic Complexity of 39. | 76 - 236 |
| Local variable 'tag' could be declared final | 79 - 80 |
| The String literal "Ignoring '" appears 10 times in this file; the first occurrence is on line 113 | 113 |
| The String literal "', because the parent is not a LayoutContainer!" appears 8 times in this file; the first occurrence is on line 177 | 177 |
| Assigning an Object to null is a code smell. Consider refactoring. | 241 |
| Assigning an Object to null is a code smell. Consider refactoring. | 242 |
| Assigning an Object to null is a code smell. Consider refactoring. | 243 |
| Assigning an Object to null is a code smell. Consider refactoring. | 244 |
| Assigning an Object to null is a code smell. Consider refactoring. | 245 |
| Assigning an Object to null is a code smell. Consider refactoring. | 246 |
| Assigning an Object to null is a code smell. Consider refactoring. | 247 |
| Assigning an Object to null is a code smell. Consider refactoring. | 248 |
| Assigning an Object to null is a code smell. Consider refactoring. | 249 |
| Assigning an Object to null is a code smell. Consider refactoring. | 250 |
| Assigning an Object to null is a code smell. Consider refactoring. | 251 |
| Assigning an Object to null is a code smell. Consider refactoring. | 252 |
| Assigning an Object to null is a code smell. Consider refactoring. | 253 |
| Assigning an Object to null is a code smell. Consider refactoring. | 254 |
| Assigning an Object to null is a code smell. Consider refactoring. | 255 |
| Assigning an Object to null is a code smell. Consider refactoring. | 256 |
| Assigning an Object to null is a code smell. Consider refactoring. | 257 |
| Assigning an Object to null is a code smell. Consider refactoring. | 258 |
| Assigning an Object to null is a code smell. Consider refactoring. | 259 |
| Assigning an Object to null is a code smell. Consider refactoring. | 260 |
| Assigning an Object to null is a code smell. Consider refactoring. | 261 |
| Assigning an Object to null is a code smell. Consider refactoring. | 262 |
| Parameter 'columnSpan' is not assigned and could be declared final | 269 |
| Parameter 'rowSpan' is not assigned and could be declared final | 277 |
| The String literal "org.apache.myfaces.tobago.layout.Measure" appears 40 times in this file; the first occurrence is on line 284 | 284 |
| Parameter 'width' is not assigned and could be declared final | 286 |
| Parameter 'height' is not assigned and could be declared final | 295 |
| Parameter 'minimumWidth' is not assigned and could be declared final | 304 |
| Parameter 'minimumHeight' is not assigned and could be declared final | 313 |
| Parameter 'preferredWidth' is not assigned and could be declared final | 322 |
| Parameter 'preferredHeight' is not assigned and could be declared final | 331 |
| Parameter 'maximumWidth' is not assigned and could be declared final | 340 |
| Parameter 'maximumHeight' is not assigned and could be declared final | 349 |
| Parameter 'marginLeft' is not assigned and could be declared final | 358 |
| Parameter 'marginRight' is not assigned and could be declared final | 367 |
| Parameter 'marginTop' is not assigned and could be declared final | 376 |
| Parameter 'marginBottom' is not assigned and could be declared final | 385 |
| Parameter 'borderLeft' is not assigned and could be declared final | 394 |
| Parameter 'borderRight' is not assigned and could be declared final | 403 |
| Parameter 'borderTop' is not assigned and could be declared final | 412 |
| Parameter 'borderBottom' is not assigned and could be declared final | 421 |
| Parameter 'paddingLeft' is not assigned and could be declared final | 430 |
| Parameter 'paddingRight' is not assigned and could be declared final | 439 |
| Parameter 'paddingTop' is not assigned and could be declared final | 448 |
| Parameter 'paddingBottom' is not assigned and could be declared final | 457 |
Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/LoadBundleTag.java
| Violation | Line |
|---|---|
| Local variable 'facesContext' could be declared final | 59 |
| Local variable 'toStore' could be declared final | 62 |
| Assigning an Object to null is a code smell. Consider refactoring. | 72 |
| Assigning an Object to null is a code smell. Consider refactoring. | 73 |
| Parameter 'basename' is not assigned and could be declared final | 80 |
| Parameter 'var' is not assigned and could be declared final | 90 |
Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/PopupReferenceTag.java
| Violation | Line |
|---|---|
| The class 'PopupReferenceTag' has a Cyclomatic Complexity of 4 (Highest = 6). | 44 - 94 |
| The method 'doStartTag' has a Cyclomatic Complexity of 6. | 50 - 84 |
| Local variable 'tag' could be declared final | 53 - 54 |
| Local variable 'component' could be declared final | 64 |
| Local variable 'actionSource' could be declared final | 73 |
| Parameter 'forValue' is not assigned and could be declared final | 90 |
Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/ResetInputActionListenerTag.java
| Violation | Line |
|---|---|
| The class 'ResetInputActionListenerTag' has a Cyclomatic Complexity of 3 (Highest = 7). | 48 - 107 |
| The method 'doStartTag' has a Cyclomatic Complexity of 7. | 54 - 90 |
| Local variable 'tag' could be declared final | 57 - 58 |
| Local variable 'component' could be declared final | 68 |
| Local variable 'actionSource' could be declared final | 80 |
| Assigning an Object to null is a code smell. Consider refactoring. | 95 |
| Parameter 'execute' is not assigned and could be declared final | 103 |
Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/SheetTagDeclaration.java
| Violation | Line |
|---|---|
| The String literal "center" appears 4 times in this file; the first occurrence is on line 152 | 152 |
| The String literal "left" appears 4 times in this file; the first occurrence is on line 153 | 153 |
| The String literal "none" appears 4 times in this file; the first occurrence is on line 153 | 153 |
| The String literal "right" appears 4 times in this file; the first occurrence is on line 153 | 153 |
Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/SubmittedValueLengthValidatorTag.java
| Violation | Line |
|---|---|
| The class 'SubmittedValueLengthValidatorTag' has a Cyclomatic Complexity of 3 (Highest = 5). | 43 - 84 |
| The method 'createValidator' has a Cyclomatic Complexity of 5. | 50 - 72 |
| Avoid empty catch blocks | 60 - 62 |
| Avoid empty catch blocks | 60 - 62 |
| Avoid empty catch blocks | 67 - 69 |
| Avoid empty catch blocks | 67 - 69 |
| Parameter 'minimum' is not assigned and could be declared final | 75 |
| Parameter 'maximum' is not assigned and could be declared final | 80 |
Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/TabChangeListenerTag.java
| Violation | Line |
|---|---|
| The class 'TabChangeListenerTag' has a Cyclomatic Complexity of 5 (Highest = 14). | 45 - 146 |
| The class 'TabChangeListenerTag' has a Cyclomatic Complexity of 5 (Highest = 14). | 45 - 146 |
| Parameter 'type' is not assigned and could be declared final | 57 |
| Parameter 'binding' is not assigned and could be declared final | 65 |
| The method 'doStartTag' has a Cyclomatic Complexity of 14. | 78 - 130 |
| The method doStartTag() has an NPath complexity of 960 | 78 - 130 |
| The method 'doStartTag' has a Cyclomatic Complexity of 14. | 78 - 130 |
| Local variable 'tag' could be declared final | 81 - 82 |
| Local variable 'component' could be declared final | 92 |
| Local variable 'changeSource' could be declared final | 101 |
| Local variable 'value' could be declared final | 107 |
| Avoid if (x != y) ..; else ..; | 121 - 126 |
| Parameter 'className' is not assigned and could be declared final | 138 |
| Local variable 'clazz' could be declared final | 140 |
Tobago Core - org/apache/myfaces/tobago/internal/taglib/declaration/HasMargins.java
| Violation | Line |
|---|---|
| The String literal "org.apache.myfaces.tobago.layout.Measure" appears 4 times in this file; the first occurrence is on line 32 | 32 |
| The String literal "getMargin() != null\n" appears 4 times in this file; the first occurrence is on line 33 | 33 |
| The String literal " ? getMargin()\n" appears 4 times in this file; the first occurrence is on line 34 | 34 |
Tobago Core - org/apache/myfaces/tobago/internal/taglib/declaration/IsGridLayoutComponentBase.java
| Violation | Line |
|---|---|
| The String literal "org.apache.myfaces.tobago.layout.Measure" appears 14 times in this file; the first occurrence is on line 35 | 35 |
| The String literal "java.lang.Integer" appears 4 times in this file; the first occurrence is on line 51 | 51 |
| The String literal "((LayoutComponentRenderer) " appears 9 times in this file; the first occurrence is on line 72 | 72 |
Tobago Core - org/apache/myfaces/tobago/internal/taglib/declaration/IsGridLayoutContainer.java
| Violation | Line |
|---|---|
| The String literal "org.apache.myfaces.tobago.layout.Measure" appears 8 times in this file; the first occurrence is on line 32 | 32 |
| The String literal "((org.apache.myfaces.tobago.renderkit.LayoutComponentRenderer)\n" appears 8 times in this file; the first occurrence is on line 33 | 33 |
Tobago Core - org/apache/myfaces/tobago/internal/util/AccessKeyMap.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 27 - 91 |
| Private field 'set' could be made final; it is only initialized in the declaration or constructor. | 35 |
| Avoid using implementation types like 'HashSet'; use the interface instead | 35 |
| Avoid using implementation types like 'HashSet'; use the interface instead | 35 |
| Parameter 'facesContext' is not assigned and could be declared final | 39 |
| Avoid using implementation types like 'HashSet'; use the interface instead | 53 |
| Avoid using implementation types like 'HashSet'; use the interface instead | 53 |
| Parameter 'key' is not assigned and could be declared final | 61 |
| Avoid reassigning parameters such as 'key' | 65 |
| Parameter 'facesContext' is not assigned and could be declared final | 65 |
| Parameter 'facesContext' is not assigned and could be declared final | 77 |
| Parameter 'facesContext' is not assigned and could be declared final | 81 |
| Local variable 'set' could be declared final | 82 |
| Local variable 'sb' could be declared final | 83 |
Tobago Core - org/apache/myfaces/tobago/internal/util/ComponentAttributeUtils.java
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 30 - 68 |
| Avoid unused private fields such as 'LOG'. | 32 |
| Avoid unused private fields such as 'LOG'. | 32 |
| Parameter 'component' is not assigned and could be declared final | 34 |
| Parameter 'name' is not assigned and could be declared final | 34 |
| Parameter 'value' is not assigned and could be declared final | 34 |
| Parameter 'component' is not assigned and could be declared final | 44 |
| Parameter 'name' is not assigned and could be declared final | 44 |
| Parameter 'value' is not assigned and could be declared final | 44 |
| Parameter 'value' is not assigned and could be declared final | 54 |
| Local variable 'start' could be declared final | 56 |
| Local variable 'end' could be declared final | 60 |
| Parameter 'value' is not assigned and could be declared final | 64 |
Tobago Core - org/apache/myfaces/tobago/internal/util/ContentType.java
| Violation | Line |
|---|---|
| Parameter 'contentType' is not assigned and could be declared final | 28 |
| Parameter 'contentType' is not assigned and could be declared final | 32 |
| Local variable 'values' could be declared final | 34 |
| Parameter 'contentType' is not assigned and could be declared final | 51 |
| Parameter 's' is not assigned and could be declared final | 60 |
Tobago Core - org/apache/myfaces/tobago/internal/util/DateFormatUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 33 - 109 |
| The class 'DateFormatUtils' has a Cyclomatic Complexity of 4 (Highest = 6). | 33 - 109 |
| Parameter 'converter' is not assigned and could be declared final | 54 |
| Local variable 'dateFormat' could be declared final | 58 - 60 |
| Local variable 'format' could be declared final | 62 |
| Parameter 'dateStyle' is not assigned and could be declared final | 70 |
| Parameter 'locale' is not assigned and could be declared final | 70 |
| Parameter 'timeStyle' is not assigned and could be declared final | 70 |
| Parameter 'type' is not assigned and could be declared final | 70 |
| Parameter 'name' is not assigned and could be declared final | 89 |
| The method 'calcStyle' has a Cyclomatic Complexity of 6. | 89 - 107 |
Tobago Core - org/apache/myfaces/tobago/internal/util/FacesContextUtils.java
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 34 - 278 |
| This class has too many methods, consider refactoring it. | 34 - 278 |
| Parameter 'context' is not assigned and could be declared final | 51 |
| Parameter 'ajax' is not assigned and could be declared final | 55 |
| Parameter 'context' is not assigned and could be declared final | 55 |
| Parameter 'context' is not assigned and could be declared final | 59 |
| Parameter 'focusId' is not assigned and could be declared final | 59 |
| Parameter 'context' is not assigned and could be declared final | 63 |
| Parameter 'context' is not assigned and could be declared final | 67 |
| Parameter 'actionId' is not assigned and could be declared final | 67 |
| Parameter 'context' is not assigned and could be declared final | 71 |
| Parameter 'context' is not assigned and could be declared final | 76 |
| Parameter 'context' is not assigned and could be declared final | 80 |
| Parameter 'ajaxComponentId' is not assigned and could be declared final | 80 |
| Parameter 'context' is not assigned and could be declared final | 84 |
| Parameter 'enctype' is not assigned and could be declared final | 88 |
| Parameter 'context' is not assigned and could be declared final | 88 |
| Parameter 'context' is not assigned and could be declared final | 92 |
| Local variable 'list' could be declared final | 93 |
| Parameter 'file' is not assigned and could be declared final | 100 |
| Parameter 'context' is not assigned and could be declared final | 100 |
| Parameter 'context' is not assigned and could be declared final | 110 |
| Local variable 'set' could be declared final | 111 |
| Parameter 'context' is not assigned and could be declared final | 118 |
| Parameter 'script' is not assigned and could be declared final | 118 |
| Parameter 'context' is not assigned and could be declared final | 128 |
| Local variable 'set' could be declared final | 129 |
| Parameter 'context' is not assigned and could be declared final | 136 |
| Parameter 'script' is not assigned and could be declared final | 136 |
| Parameter 'context' is not assigned and could be declared final | 145 |
| Local variable 'set' could be declared final | 146 |
| Parameter 'context' is not assigned and could be declared final | 153 |
| Parameter 'script' is not assigned and could be declared final | 153 |
| Parameter 'context' is not assigned and could be declared final | 162 |
| Local variable 'list' could be declared final | 163 |
| Parameter 'file' is not assigned and could be declared final | 171 |
| Parameter 'context' is not assigned and could be declared final | 171 |
| Parameter 'position' is not assigned and could be declared final | 180 |
| Parameter 'file' is not assigned and could be declared final | 180 |
| Parameter 'context' is not assigned and could be declared final | 180 |
| Parameter 'context' is not assigned and could be declared final | 189 |
| Local variable 'set' could be declared final | 190 |
| Parameter 'context' is not assigned and could be declared final | 197 |
| Parameter 'script' is not assigned and could be declared final | 197 |
| Parameter 'context' is not assigned and could be declared final | 206 |
| Local variable 'set' could be declared final | 207 |
| Parameter 'context' is not assigned and could be declared final | 214 |
| Parameter 'script' is not assigned and could be declared final | 214 |
| Parameter 'context' is not assigned and could be declared final | 223 |
| Local variable 'set' could be declared final | 224 |
| Parameter 'context' is not assigned and could be declared final | 231 |
| Parameter 'script' is not assigned and could be declared final | 231 |
| Parameter 'context' is not assigned and could be declared final | 240 |
| Local variable 'set' could be declared final | 241 |
| Parameter 'context' is not assigned and could be declared final | 245 |
| Local variable 'set' could be declared final | 246 |
| Parameter 'context' is not assigned and could be declared final | 253 |
| Parameter 'script' is not assigned and could be declared final | 253 |
| Parameter 'context' is not assigned and could be declared final | 262 |
| Local variable 'set' could be declared final | 263 |
| Parameter 'popup' is not assigned and could be declared final | 270 |
| Parameter 'context' is not assigned and could be declared final | 270 |
Tobago Core - org/apache/myfaces/tobago/internal/util/FastStringWriter.java
| Violation | Line |
|---|---|
| Parameter 'initialSize' is not assigned and could be declared final | 33 |
| Parameter 'c' is not assigned and could be declared final | 37 |
| Parameter 'cbuf' is not assigned and could be declared final | 41 |
| Parameter 'off' is not assigned and could be declared final | 41 |
| Parameter 'len' is not assigned and could be declared final | 41 |
| Parameter 'str' is not assigned and could be declared final | 45 |
| Parameter 'str' is not assigned and could be declared final | 49 |
| Parameter 'off' is not assigned and could be declared final | 49 |
| Parameter 'len' is not assigned and could be declared final | 49 |
Tobago Core - org/apache/myfaces/tobago/internal/util/FindComponentUtils.java
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 26 - 62 |
| The class 'FindComponentUtils' has a Cyclomatic Complexity of 11 (Highest = 10). | 26 - 62 |
| The class 'FindComponentUtils' has a Cyclomatic Complexity of 11 (Highest = 10). | 26 - 62 |
| Avoid reassigning parameters such as 'relativeId' | 28 |
| Avoid reassigning parameters such as 'from' | 28 |
| The method 'findComponent' has a Cyclomatic Complexity of 10. | 28 - 61 |
| The method 'findComponent' has a Cyclomatic Complexity of 10. | 28 - 61 |
| Local variable 'idLength' could be declared final | 29 |
| These nested if statements could be combined | 31 - 33 |
| Position literals first in String comparisons | 31 |
| These nested if statements could be combined | 31 - 33 |
Tobago Core - org/apache/myfaces/tobago/internal/util/HtmlWriterUtils.java
| Violation | Line |
|---|---|
| The class 'HtmlWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14). | 25 - 122 |
| The class 'HtmlWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14). | 25 - 122 |
| The method 'writeEncodedValue' has a Cyclomatic Complexity of 14. | 60 - 121 |
| The method 'writeEncodedValue' has a Cyclomatic Complexity of 14. | 60 - 121 |
| Local variable 'ch' could be declared final | 67 |
| Avoid if (x != y) ..; else ..; | 93 - 97 |
| Local variable 'chars' could be declared final | 105 |
Tobago Core - org/apache/myfaces/tobago/internal/util/JavascriptWriterUtils.java
| Violation | Line |
|---|---|
| The class 'JavascriptWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14). | 25 - 120 |
| The class 'JavascriptWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14). | 25 - 120 |
| The method 'writeEncodedValue' has a Cyclomatic Complexity of 14. | 58 - 119 |
| The method 'writeEncodedValue' has a Cyclomatic Complexity of 14. | 58 - 119 |
| Local variable 'ch' could be declared final | 65 |
| Avoid if (x != y) ..; else ..; | 91 - 95 |
| Local variable 'chars' could be declared final | 103 |
Tobago Core - org/apache/myfaces/tobago/internal/util/JndiUtils.java
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 30 - 74 |
| The class 'JndiUtils' has a Cyclomatic Complexity of 4 (Highest = 5). | 30 - 74 |
| Parameter 'ctx' is not assigned and could be declared final | 34 |
| Parameter 'path' is not assigned and could be declared final | 34 |
| Parameter 'ctx' is not assigned and could be declared final | 38 |
| Parameter 'path' is not assigned and could be declared final | 38 |
| Parameter 'defaultValue' is not assigned and could be declared final | 38 |
| The method 'getJndiProperty' has a Cyclomatic Complexity of 5. | 38 - 57 |
| Local variable 'b' could be declared final | 42 |
| Local variable 'obj' could be declared final | 47 |
| Prefer StringBuffer over += for concatenating strings | 53 |
| Parameter 'name' is not assigned and could be declared final | 59 |
| Parameter 'ctx' is not assigned and could be declared final | 59 |
| Parameter 'path' is not assigned and could be declared final | 59 |
| Local variable 'ne' could be declared final | 61 |
| Local variable 'b' could be declared final | 63 |
Tobago Core - org/apache/myfaces/tobago/internal/util/JsonWriterUtils.java
| Violation | Line |
|---|---|
| The class 'JsonWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14). | 26 - 124 |
| The class 'JsonWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14). | 26 - 124 |
| The method 'writeEncodedValue' has a Cyclomatic Complexity of 14. | 62 - 123 |
| The method 'writeEncodedValue' has a Cyclomatic Complexity of 14. | 62 - 123 |
| Local variable 'ch' could be declared final | 69 |
| Avoid if (x != y) ..; else ..; | 95 - 99 |
| Local variable 'chars' could be declared final | 107 |
Tobago Core - org/apache/myfaces/tobago/internal/util/MimeTypeUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 22 - 47 |
| The class 'MimeTypeUtils' has a Cyclomatic Complexity of 6 (Highest = 9). | 22 - 47 |
| Parameter 'file' is not assigned and could be declared final | 29 |
| The method 'getMimeTypeForFile' has a Cyclomatic Complexity of 9. | 29 - 46 |
Tobago Core - org/apache/myfaces/tobago/internal/util/ResponseUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 32 - 99 |
| The class 'ResponseUtils' has a Cyclomatic Complexity of 3 (Highest = 5). | 32 - 99 |
| Parameter 'facesContext' is not assigned and could be declared final | 40 |
| Local variable 'externalContext' could be declared final | 42 |
| Local variable 'response' could be declared final | 44 |
| Parameter 'response' is not assigned and could be declared final | 49 |
| Parameter 'facesContext' is not assigned and could be declared final | 56 |
| Parameter 'contentType' is not assigned and could be declared final | 56 |
| Local variable 'response' could be declared final | 59 |
| Parameter 'response' is not assigned and could be declared final | 64 |
| Parameter 'contentType' is not assigned and could be declared final | 64 |
| The method 'ensureContentTypeHeader' has a Cyclomatic Complexity of 5. | 64 - 81 |
| Avoid if (x != y) ..; else ..; | 65 - 80 |
| Local variable 'responseContentType' could be declared final | 69 |
| Parameter 'contentSecurityPolicy' is not assigned and could be declared final | 83 |
| Parameter 'facesContext' is not assigned and could be declared final | 83 |
Tobago Core - org/apache/myfaces/tobago/internal/util/StringUtils.java
| Violation | Line |
|---|---|
| The class 'StringUtils' has a Cyclomatic Complexity of 3 (Highest = 7). | 27 - 104 |
| Parameter 'integerList' is not assigned and could be declared final | 33 |
| Parameter 'delimiters' is not assigned and could be declared final | 37 |
| Parameter 'integerList' is not assigned and could be declared final | 37 |
| Local variable 'list' could be declared final | 38 |
| Local variable 'tokenizer' could be declared final | 40 |
| Local variable 'token' could be declared final | 42 |
| Avoid instantiating new objects inside loops | 44 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 44 |
| Parameter 'list' is not assigned and could be declared final | 51 |
| Local variable 'buffer' could be declared final | 52 |
| Parameter 'list' is not assigned and could be declared final | 60 |
| The method 'getIndices' has a Cyclomatic Complexity of 7. | 60 - 88 |
| Local variable 'indexList' could be declared final | 61 |
| Local variable 'st' could be declared final | 62 |
| Local variable 'token' could be declared final | 64 |
| Local variable 'idx' could be declared final | 65 |
| Local variable 'start' could be declared final | 69 |
| Local variable 'end' could be declared final | 70 |
| Parameter 'constant' is not assigned and could be declared final | 90 |
Tobago Core - org/apache/myfaces/tobago/internal/webapp/DebugContentTypeFilter.java
| Violation | Line |
|---|---|
| Parameter 'filterConfig' is not assigned and could be declared final | 37 |
| Parameter 'response' is not assigned and could be declared final | 43 |
| Parameter 'chain' is not assigned and could be declared final | 43 |
| Parameter 'request' is not assigned and could be declared final | 43 |
| Document empty method | 58 - 60 |
Tobago Core - org/apache/myfaces/tobago/internal/webapp/DebugContentTypeResponse.java
| Violation | Line |
|---|---|
| Parameter 'response' is not assigned and could be declared final | 31 |
| Parameter 'type' is not assigned and could be declared final | 36 |
| Local variable 'type' could be declared final | 45 |
| Parameter 'name' is not assigned and could be declared final | 53 |
| Parameter 'value' is not assigned and could be declared final | 53 |
| These nested if statements could be combined | 55 - 57 |
| These nested if statements could be combined | 55 - 57 |
| Parameter 'name' is not assigned and could be declared final | 63 |
| Parameter 'value' is not assigned and could be declared final | 63 |
| These nested if statements could be combined | 65 - 67 |
| These nested if statements could be combined | 65 - 67 |
Tobago Core - org/apache/myfaces/tobago/internal/webapp/DebugResponseWriterWrapper.java
| Violation | Line |
|---|---|
| This class has too many methods, consider refactoring it. | 37 - 176 |
| Private field 'stack' could be made final; it is only initialized in the declaration or constructor. | 39 |
| Parameter 'responseWriter' is not assigned and could be declared final | 45 |
| Parameter 'string' is not assigned and could be declared final | 49 |
| Parameter 'comment' is not assigned and could be declared final | 53 |
| Parameter 'writer' is not assigned and could be declared final | 64 |
| Parameter 'name' is not assigned and could be declared final | 69 |
| Parameter 'value' is not assigned and could be declared final | 69 |
| Parameter 'property' is not assigned and could be declared final | 69 |
| Parameter 'text' is not assigned and could be declared final | 74 |
| Parameter 'property' is not assigned and could be declared final | 74 |
| Parameter 'name' is not assigned and could be declared final | 82 |
| Parameter 'value' is not assigned and could be declared final | 82 |
| Parameter 'escape' is not assigned and could be declared final | 82 |
| Parameter 'script' is not assigned and could be declared final | 118 |
| Parameter 'name' is not assigned and could be declared final | 132 |
| Parameter 'value' is not assigned and could be declared final | 132 |
| Parameter 'property' is not assigned and could be declared final | 132 |
| Parameter 'text' is not assigned and could be declared final | 136 |
| Parameter 'off' is not assigned and could be declared final | 136 |
| Parameter 'len' is not assigned and could be declared final | 136 |
| Parameter 'chars' is not assigned and could be declared final | 140 |
| Parameter 'i' is not assigned and could be declared final | 140 |
| Parameter 'i1' is not assigned and could be declared final | 140 |
| Parameter 'name' is not assigned and could be declared final | 149 |
| Parameter 'currentComponent' is not assigned and could be declared final | 149 |
| Parameter 'name' is not assigned and could be declared final | 159 |
Tobago Core - org/apache/myfaces/tobago/internal/webapp/HtmlResponseWriter.java
| Violation | Line |
|---|---|
| This class has too many methods, consider refactoring it. | 39 - 171 |
| Private field 'javascriptWriter' could be made final; it is only initialized in the declaration or constructor. | 45 |
| Parameter 'contentType' is not assigned and could be declared final | 49 |
| Parameter 'writer' is not assigned and could be declared final | 49 |
| Parameter 'characterEncoding' is not assigned and could be declared final | 49 |
| Parameter 'string' is not assigned and could be declared final | 70 |
| Parameter 'script' is not assigned and could be declared final | 79 |
| Avoid empty if statements | 107 - 109 |
| Avoid empty if statements | 107 - 109 |
| Parameter 'value' is not assigned and could be declared final | 120 |
| Parameter 'escape' is not assigned and could be declared final | 120 |
| Avoid reassigning parameters such as 'styles' | 137 |
| Parameter 'component' is not assigned and could be declared final | 137 |
| Parameter 'name' is not assigned and could be declared final | 153 |
| Local variable 'javascript' could be declared final | 155 |
Tobago Core - org/apache/myfaces/tobago/internal/webapp/JsonResponseWriter.java
| Violation | Line |
|---|---|
| This class has too many methods, consider refactoring it. | 34 - 186 |
| Private field 'javascriptWriter' could be made final; it is only initialized in the declaration or constructor. | 38 |
| Private field 'encodeInJavascriptBlock' could be made final; it is only initialized in the declaration or constructor. | 40 |
| Private field 'encodeOutsideJavascriptBlock' could be made final; it is only initialized in the declaration or constructor. | 41 |
| Parameter 'contentType' is not assigned and could be declared final | 43 |
| Parameter 'writer' is not assigned and could be declared final | 43 |
| Parameter 'characterEncoding' is not assigned and could be declared final | 43 |
| Parameter 'string' is not assigned and could be declared final | 61 |
| Parameter 'chars' is not assigned and could be declared final | 71 |
| Local variable 'stackTraceElements' could be declared final | 77 |
| Parameter 'script' is not assigned and could be declared final | 87 |
| Parameter 'name' is not assigned and could be declared final | 97 |
| Parameter 'writer' is not assigned and could be declared final | 97 |
| Parameter 'currentComponent' is not assigned and could be declared final | 97 |
| Parameter 'name' is not assigned and could be declared final | 109 |
| Parameter 'writer' is not assigned and could be declared final | 109 |
| Parameter 'name' is not assigned and could be declared final | 132 |
| Parameter 'value' is not assigned and could be declared final | 132 |
| Parameter 'writer' is not assigned and could be declared final | 132 |
| Parameter 'escape' is not assigned and could be declared final | 132 |
| Local variable 'trace' could be declared final | 135 |
| Local variable 'error' could be declared final | 136 - 139 |
| Local variable 'value' could be declared final | 161 |
| Document empty method | 180 - 181 |
| Document empty method | 184 - 185 |
Tobago Core - org/apache/myfaces/tobago/internal/webapp/TobagoMultipartFormdataRequest.java
| Violation | Line |
|---|---|
| The class 'TobagoMultipartFormdataRequest' has a Cyclomatic Complexity of 3 (Highest = 13). | 43 - 199 |
| The class 'TobagoMultipartFormdataRequest' has a Cyclomatic Complexity of 3 (Highest = 13). | 43 - 199 |
| Parameter 'request' is not assigned and could be declared final | 55 |
| Parameter 'request' is not assigned and could be declared final | 59 |
| Parameter 'repositoryPath' is not assigned and could be declared final | 59 |
| Parameter 'maxSize' is not assigned and could be declared final | 59 |
| Parameter 'request' is not assigned and could be declared final | 64 |
| Parameter 'repositoryPath' is not assigned and could be declared final | 64 |
| Parameter 'maxSize' is not assigned and could be declared final | 64 |
| The method 'init' has a Cyclomatic Complexity of 13. | 64 - 133 |
| The method init() has an NPath complexity of 401 | 64 - 133 |
| The method 'init' has a Cyclomatic Complexity of 13. | 64 - 133 |
| Avoid if (x != y) ..; else ..; | 65 - 132 |
| Local variable 'errorText' could be declared final | 66 |
| Local variable 'factory' could be declared final | 72 |
| Local variable 'upload' could be declared final | 76 |
| Local variable 'key' could be declared final | 95 |
| Local variable 'e' could be declared final | 121 |
| Parameter 'newValue' is not assigned and could be declared final | 135 |
| Parameter 'key' is not assigned and could be declared final | 135 |
| Parameter 'key' is not assigned and could be declared final | 148 |
| Parameter 'key' is not assigned and could be declared final | 155 |
| Local variable 'values' could be declared final | 157 |
| Parameter 'key' is not assigned and could be declared final | 168 |
| Parameter 'param' is not assigned and could be declared final | 176 |
| The method 'getMaxSize' has a Cyclomatic Complexity of 6. | 176 - 198 |
Tobago Core - org/apache/myfaces/tobago/internal/webapp/TobagoResponseWriterBase.java
| Violation | Line |
|---|---|
| The class 'TobagoResponseWriterBase' has a Cyclomatic Complexity of 2 (Highest = 7). | 38 - 331 |
| This class has too many methods, consider refactoring it. | 38 - 331 |
| Parameter 'contentType' is not assigned and could be declared final | 74 |
| Parameter 'writer' is not assigned and could be declared final | 74 |
| Parameter 'characterEncoding' is not assigned and could be declared final | 74 |
| Avoid if (x != y) ..; else ..; | 77 |
| Parameter 'component' is not assigned and could be declared final | 88 |
| Parameter 'startStillOpen' is not assigned and could be declared final | 96 |
| The method 'findValue' has a Cyclomatic Complexity of 7. | 100 - 129 |
| Avoid if (x != y) ..; else ..; | 101 - 128 |
| Avoid if (x != y) ..; else ..; | 103 - 128 |
| Avoid if (x != y) ..; else ..; | 104 - 119 |
| Avoid if (x != y) ..; else ..; | 106 - 110 |
| Parameter 'string' is not assigned and could be declared final | 137 |
| Parameter 'string' is not assigned and could be declared final | 141 |
| Parameter 'writer' is not assigned and could be declared final | 141 |
| Parameter 'i' is not assigned and could be declared final | 147 |
| Parameter 'chars' is not assigned and could be declared final | 153 |
| Parameter 'string' is not assigned and could be declared final | 159 |
| Parameter 'i' is not assigned and could be declared final | 159 |
| Parameter 'i1' is not assigned and could be declared final | 159 |
| An empty method in an abstract class should be abstract instead | 191 - 193 |
| An empty method in an abstract class should be abstract instead | 195 - 197 |
| Parameter 'name' is not assigned and could be declared final | 212 |
| Parameter 'writer' is not assigned and could be declared final | 212 |
| Parameter 'currentComponent' is not assigned and could be declared final | 212 |
| Local variable 'comment' could be declared final | 230 |
| Local variable 'clazz' could be declared final | 272 |
| Local variable 'clazz' could be declared final | 285 |
| Parameter 'name' is not assigned and could be declared final | 292 |
| Parameter 'writer' is not assigned and could be declared final | 292 |
| Parameter 'name' is not assigned and could be declared final | 308 |
| Parameter 'value' is not assigned and could be declared final | 308 |
| Parameter 'writer' is not assigned and could be declared final | 308 |
| Parameter 'escape' is not assigned and could be declared final | 308 |
| Local variable 'trace' could be declared final | 311 |
| Local variable 'error' could be declared final | 312 - 315 |
Tobago Core - org/apache/myfaces/tobago/internal/webapp/TobagoResponseWriterWrapper.java
| Violation | Line |
|---|---|
| This class has too many methods, consider refactoring it. | 32 - 125 |
| Private field 'responseWriter' could be made final; it is only initialized in the declaration or constructor. | 34 |
| Parameter 'responseWriter' is not assigned and could be declared final | 36 |
| Parameter 'component' is not assigned and could be declared final | 40 |
| Parameter 'name' is not assigned and could be declared final | 40 |
| Parameter 'name' is not assigned and could be declared final | 44 |
| Parameter 'string' is not assigned and could be declared final | 49 |
| Parameter 'comment' is not assigned and could be declared final | 53 |
| Parameter 'writer' is not assigned and could be declared final | 57 |
| Parameter 'name' is not assigned and could be declared final | 62 |
| Parameter 'value' is not assigned and could be declared final | 62 |
| Parameter 'property' is not assigned and could be declared final | 62 |
| Parameter 'text' is not assigned and could be declared final | 67 |
| Parameter 'property' is not assigned and could be declared final | 67 |
| Parameter 'name' is not assigned and could be declared final | 75 |
| Parameter 'value' is not assigned and could be declared final | 75 |
| Parameter 'escape' is not assigned and could be declared final | 75 |
| Parameter 'name' is not assigned and could be declared final | 110 |
| Parameter 'value' is not assigned and could be declared final | 110 |
| Parameter 'property' is not assigned and could be declared final | 110 |
| Parameter 'text' is not assigned and could be declared final | 114 |
| Parameter 'off' is not assigned and could be declared final | 114 |
| Parameter 'len' is not assigned and could be declared final | 114 |
| Parameter 'chars' is not assigned and could be declared final | 118 |
| Parameter 'i' is not assigned and could be declared final | 118 |
| Parameter 'i1' is not assigned and could be declared final | 118 |
Tobago Core - org/apache/myfaces/tobago/internal/webapp/XmlResponseWriter.java
| Violation | Line |
|---|---|
| Parameter 'contentType' is not assigned and could be declared final | 38 |
| Parameter 'writer' is not assigned and could be declared final | 38 |
| Parameter 'characterEncoding' is not assigned and could be declared final | 38 |
| Avoid empty if statements | 58 - 60 |
| Avoid empty if statements | 58 - 60 |
| Parameter 'value' is not assigned and could be declared final | 76 |
| Parameter 'escape' is not assigned and could be declared final | 76 |
Tobago Core - org/apache/myfaces/tobago/layout/Box.java
| Violation | Line |
|---|---|
| Parameter 'position' is not assigned and could be declared final | 27 |
| Parameter 'dimension' is not assigned and could be declared final | 27 |
| Parameter 'string' is not assigned and could be declared final | 32 |
| Parameter 'left' is not assigned and could be declared final | 63 |
| Parameter 'top' is not assigned and could be declared final | 71 |
| Parameter 'width' is not assigned and could be declared final | 79 |
| Parameter 'height' is not assigned and could be declared final | 87 |
Tobago Core - org/apache/myfaces/tobago/layout/Dimension.java
| Violation | Line |
|---|---|
| Parameter 'height' is not assigned and could be declared final | 27 |
| Parameter 'width' is not assigned and could be declared final | 27 |
| Parameter 'string' is not assigned and could be declared final | 32 |
| Local variable 'comma' could be declared final | 33 |
| Parameter 'width' is not assigned and could be declared final | 46 |
| Parameter 'height' is not assigned and could be declared final | 54 |
Tobago Core - org/apache/myfaces/tobago/layout/Display.java
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 30 |
Tobago Core - org/apache/myfaces/tobago/layout/LayoutTokens.java
| Violation | Line |
|---|---|
| The class 'LayoutTokens' has a Cyclomatic Complexity of 2 (Highest = 10). | 31 - 171 |
| This class has too many methods, consider refactoring it. | 31 - 171 |
| The class 'LayoutTokens' has a Cyclomatic Complexity of 2 (Highest = 10). | 31 - 171 |
| Private field 'tokens' could be made final; it is only initialized in the declaration or constructor. | 35 |
| Document empty constructor | 37 - 38 |
| Avoid unnecessary constructors - the compiler will generate these for you | 37 - 38 |
| Parameter 'index' is not assigned and could be declared final | 44 |
| Parameter 'token' is not assigned and could be declared final | 44 |
| Parameter 'index' is not assigned and could be declared final | 52 |
| Parameter 'size' is not assigned and could be declared final | 56 |
| Parameter 'token' is not assigned and could be declared final | 62 |
| Parameter 'size' is not assigned and could be declared final | 62 |
| Parameter 'token' is not assigned and could be declared final | 68 |
| Parameter 'tokens' is not assigned and could be declared final | 80 |
| Local variable 'layoutTokens' could be declared final | 81 |
| Parameter 'tokens' is not assigned and could be declared final | 88 |
| Parameter 'defaultToken' is not assigned and could be declared final | 92 |
| Parameter 'tokens' is not assigned and could be declared final | 92 |
| Local variable 'layoutTokens' could be declared final | 93 |
| Local variable 'tokenizer' could be declared final | 98 |
| Local variable 'token' could be declared final | 101 |
| Parameter 'layoutTokens' is not assigned and could be declared final | 107 |
| Parameter 'token' is not assigned and could be declared final | 107 |
| Local variable 'layoutToken' could be declared final | 108 |
| Parameter 'token' is not assigned and could be declared final | 114 |
| The method 'parseToken' has a Cyclomatic Complexity of 10. | 114 - 139 |
| The method 'parseToken' has a Cyclomatic Complexity of 10. | 114 - 139 |
| Parameter 'token' is not assigned and could be declared final | 141 |
| Parameter 'token' is not assigned and could be declared final | 145 |
| Parameter 'token' is not assigned and could be declared final | 149 |
| Parameter 'token' is not assigned and could be declared final | 153 |
| Parameter 'suffix' is not assigned and could be declared final | 153 |
| Parameter 'token' is not assigned and could be declared final | 158 |
| Parameter 'suffix' is not assigned and could be declared final | 158 |
| Local variable 'str' could be declared final | 163 |
Tobago Core - org/apache/myfaces/tobago/layout/Measure.java
| Violation | Line |
|---|---|
| The class 'Measure' has a Cyclomatic Complexity of 2 (Highest = 5). | 29 - 193 |
| This class has too many methods, consider refactoring it. | 29 - 193 |
| Avoid unused private fields such as 'LOG'. | 33 |
| Avoid unused private fields such as 'LOG'. | 33 |
| Parameter 'value' is not assigned and could be declared final | 40 |
| Parameter 'value' is not assigned and could be declared final | 47 |
| Parameter 'value' is not assigned and could be declared final | 51 |
| Parameter 'value' is not assigned and could be declared final | 58 |
| Parameter 'value' is not assigned and could be declared final | 65 |
| Parameter 'object' is not assigned and could be declared final | 80 |
| The method 'valueOf' has a Cyclomatic Complexity of 5. | 80 - 94 |
| Parameter 'value' is not assigned and could be declared final | 100 |
| Parameter 'm' is not assigned and could be declared final | 116 |
| Parameter 'measure' is not assigned and could be declared final | 126 |
| Parameter 'measure' is not assigned and could be declared final | 130 |
| Parameter 'measure' is not assigned and could be declared final | 134 |
| Parameter 'measure' is not assigned and could be declared final | 138 |
| Parameter 'list' is not assigned and could be declared final | 149 |
| Parameter 'list' is not assigned and could be declared final | 162 |
| Parameter 'm1' is not assigned and could be declared final | 175 |
| Parameter 'm2' is not assigned and could be declared final | 175 |
| Avoid if (x != y) ..; else ..; | 176 - 180 |
| Avoid if (x != y) ..; else ..; | 179 |
| Parameter 'm1' is not assigned and could be declared final | 186 |
| Parameter 'm2' is not assigned and could be declared final | 186 |
| Avoid if (x != y) ..; else ..; | 187 - 191 |
| Avoid if (x != y) ..; else ..; | 190 |
Tobago Core - org/apache/myfaces/tobago/layout/MeasureEditor.java
| Violation | Line |
|---|---|
| Parameter 'text' is not assigned and could be declared final | 27 |
Tobago Core - org/apache/myfaces/tobago/layout/PercentLayoutToken.java
| Violation | Line |
|---|---|
| The class 'PercentLayoutToken' has a Cyclomatic Complexity of 2 (Highest = 5). | 22 - 60 |
| Private field 'percent' could be made final; it is only initialized in the declaration or constructor. | 26 |
| Parameter 'percent' is not assigned and could be declared final | 28 |
| Parameter 'o' is not assigned and could be declared final | 40 |
| The method 'equals' has a Cyclomatic Complexity of 5. | 40 - 55 |
| Local variable 'that' could be declared final | 48 |
Tobago Core - org/apache/myfaces/tobago/layout/PixelLayoutToken.java
| Violation | Line |
|---|---|
| The class 'PixelLayoutToken' has a Cyclomatic Complexity of 2 (Highest = 5). | 23 - 61 |
| Private field 'pixel' could be made final; it is only initialized in the declaration or constructor. | 27 |
| Parameter 'pixel' is not assigned and could be declared final | 29 |
| Parameter 'o' is not assigned and could be declared final | 41 |
| The method 'equals' has a Cyclomatic Complexity of 5. | 41 - 56 |
| Local variable 'that' could be declared final | 49 |
Tobago Core - org/apache/myfaces/tobago/layout/PixelMeasure.java
| Violation | Line |
|---|---|
| The class 'PixelMeasure' has a Cyclomatic Complexity of 2 (Highest = 5). | 25 - 131 |
| This class has too many methods, consider refactoring it. | 25 - 131 |
| Avoid instantiating new objects inside loops | 35 |
| Parameter 'pixel' is not assigned and could be declared final | 41 |
| Parameter 'value' is not assigned and could be declared final | 45 |
| Parameter 'm' is not assigned and could be declared final | 52 |
| Parameter 'm' is not assigned and could be declared final | 60 |
| Parameter 'times' is not assigned and could be declared final | 64 |
| Parameter 'times' is not assigned and could be declared final | 68 |
| Parameter 'm' is not assigned and could be declared final | 72 |
| Parameter 'm' is not assigned and could be declared final | 83 |
| Parameter 'm' is not assigned and could be declared final | 91 |
| Parameter 'o' is not assigned and could be declared final | 110 |
| The method 'equals' has a Cyclomatic Complexity of 5. | 110 - 125 |
| Local variable 'that' could be declared final | 118 |
Tobago Core - org/apache/myfaces/tobago/layout/Position.java
| Violation | Line |
|---|---|
| Parameter 'left' is not assigned and could be declared final | 27 |
| Parameter 'top' is not assigned and could be declared final | 27 |
| Parameter 'string' is not assigned and could be declared final | 32 |
| Local variable 'comma' could be declared final | 33 |
| Parameter 'left' is not assigned and could be declared final | 46 |
| Parameter 'top' is not assigned and could be declared final | 54 |
Tobago Core - org/apache/myfaces/tobago/layout/RelativeLayoutToken.java
| Violation | Line |
|---|---|
| The class 'RelativeLayoutToken' has a Cyclomatic Complexity of 2 (Highest = 5). | 22 - 63 |
| Private field 'factor' could be made final; it is only initialized in the declaration or constructor. | 29 |
| Parameter 'factor' is not assigned and could be declared final | 31 |
| Parameter 'o' is not assigned and could be declared final | 43 |
| The method 'equals' has a Cyclomatic Complexity of 5. | 43 - 58 |
| Local variable 'that' could be declared final | 51 |
Tobago Core - org/apache/myfaces/tobago/layout/TextAlign.java
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 41 |
| Parameter 'string' is not assigned and could be declared final | 59 |
| Local variable 'value' could be declared final | 63 |
| Avoid if (x != y) ..; else ..; | 64 - 68 |
Tobago Core - org/apache/myfaces/tobago/model/AutoSuggestExtensionItem.java
| Violation | Line |
|---|---|
| Parameter 'id' is not assigned and could be declared final | 31 |
| Parameter 'value' is not assigned and could be declared final | 39 |
Tobago Core - org/apache/myfaces/tobago/model/AutoSuggestItem.java
| Violation | Line |
|---|---|
| Parameter 'label' is not assigned and could be declared final | 36 |
| Parameter 'nextFocusId' is not assigned and could be declared final | 44 |
| Parameter 'extensionItems' is not assigned and could be declared final | 52 |
Tobago Core - org/apache/myfaces/tobago/model/AutoSuggestItems.java
| Violation | Line |
|---|---|
| Parameter 'items' is not assigned and could be declared final | 37 |
| Parameter 'nextFocusId' is not assigned and could be declared final | 45 |
| Parameter 'maxSuggestedCount' is not assigned and could be declared final | 53 |
Tobago Core - org/apache/myfaces/tobago/model/CalendarModel.java
| Violation | Line |
|---|---|
| Private field 'calendarArray' could be made final; it is only initialized in the declaration or constructor. | 28 |
| Private field 'firstDayOffset' could be made final; it is only initialized in the declaration or constructor. | 29 |
| Parameter 'calendar' is not assigned and could be declared final | 31 |
| Local variable 'weekCount' could be declared final | 33 |
| Local variable 'c' could be declared final | 35 |
| Avoid instantiating new objects inside loops | 43 |
| Parameter 'day' is not assigned and could be declared final | 61 |
| Parameter 'week' is not assigned and could be declared final | 61 |
| Parameter 'calendar' is not assigned and could be declared final | 65 |
| Local variable 'c' could be declared final | 66 |
| Local variable 'day' could be declared final | 69 |
| Local variable 'firstDayOfWeek' could be declared final | 70 |
| Local variable 'buffer' could be declared final | 76 |
| Local variable 'weekCount' could be declared final | 78 |
| Local variable 'format' could be declared final | 79 |
| When instantiating a SimpleDateFormat object, specify a Locale | 80 |
| Local variable 'dateFormat' could be declared final | 80 |
| Local variable 'date' could be declared final | 82 |
| Local variable 'dayName' could be declared final | 83 |
| Local variable 'date' could be declared final | 89 |
Tobago Core - org/apache/myfaces/tobago/model/DateModel.java
| Violation | Line |
|---|---|
| Parameter 'month' is not assigned and could be declared final | 31 |
| Parameter 'year' is not assigned and could be declared final | 31 |
| Parameter 'day' is not assigned and could be declared final | 31 |
| Parameter 'calendar' is not assigned and could be declared final | 37 |
| Parameter 'year' is not assigned and could be declared final | 47 |
| Parameter 'month' is not assigned and could be declared final | 55 |
| Parameter 'day' is not assigned and could be declared final | 63 |
| Parameter 'locale' is not assigned and could be declared final | 71 |
| Avoid if (x != y) ..; else ..; | 72 - 73 |
| Local variable 'calendar' could be declared final | 72 - 73 |
Tobago Core - org/apache/myfaces/tobago/model/ExpandedState.java
| Violation | Line |
|---|---|
| The class 'ExpandedState' has a Cyclomatic Complexity of 2 (Highest = 6). | 34 - 228 |
| This class has too many methods, consider refactoring it. | 34 - 228 |
| Private field 'expandedSet' could be made final; it is only initialized in the declaration or constructor. | 37 |
| Private field 'collapsedSet' could be made final; it is only initialized in the declaration or constructor. | 38 |
| Parameter 'defaultExpandedLevels' is not assigned and could be declared final | 45 |
| Parameter 'node' is not assigned and could be declared final | 57 |
| Parameter 'path' is not assigned and could be declared final | 68 |
| Parameter 'node' is not assigned and could be declared final | 83 |
| Parameter 'path' is not assigned and could be declared final | 93 |
| Parameter 'level' is not assigned and could be declared final | 106 |
| The method 'expand' has a Cyclomatic Complexity of 6. | 106 - 125 |
| Local variable 'toRemove' could be declared final | 107 |
| Parameter 'node' is not assigned and could be declared final | 141 |
| Parameter 'path' is not assigned and could be declared final | 151 |
| Avoid reassigning parameters such as 'level' | 164 |
| The method 'collapse' has a Cyclomatic Complexity of 6. | 164 - 186 |
| Local variable 'toRemove' could be declared final | 168 |
Tobago Core - org/apache/myfaces/tobago/model/MarkedState.java
| Violation | Line |
|---|---|
| Parameter 'path' is not assigned and could be declared final | 29 |
| Avoid if (x != y) ..; else ..; | 30 - 34 |
| Use equals() to compare object references. | 33 |
| Parameter 'marked' is not assigned and could be declared final | 41 |
| Parameter 'marked' is not assigned and could be declared final | 45 |
| Assigning an Object to null is a code smell. Consider refactoring. | 53 |
Tobago Core - org/apache/myfaces/tobago/model/MixedTreeModel.java
| Violation | Line |
|---|---|
| The class 'MixedTreeModel' has a Cyclomatic Complexity of 2 (Highest = 6). | 33 - 98 |
| Private field 'junctions' could be made final; it is only initialized in the declaration or constructor. | 39 |
| Local variable 'newNode' could be declared final | 42 |
| The method 'onEncodeBegin' has a Cyclomatic Complexity of 6. | 56 - 82 |
| Local variable 'nextSibling' could be declared final | 71 |
| Assigning an Object to null is a code smell. Consider refactoring. | 79 |
| Local variable 'top' could be declared final | 89 |
| Local variable 'result' could be declared final | 90 |
Tobago Core - org/apache/myfaces/tobago/model/Node.java
| Violation | Line |
|---|---|
| Parameter 'node' is not assigned and could be declared final | 36 |
| Parameter 'index' is not assigned and could be declared final | 53 |
| Parameter 'node' is not assigned and could be declared final | 62 |
| Local variable 'child' could be declared final | 64 |
| Assigning an Object to null is a code smell. Consider refactoring. | 85 |
| Local variable 'result' could be declared final | 89 |
| Local variable 'index' could be declared final | 93 |
| Parameter 'parent' is not assigned and could be declared final | 107 |
Tobago Core - org/apache/myfaces/tobago/model/PageStateImpl.java
| Violation | Line |
|---|---|
| Parameter 'clientWidth' is not assigned and could be declared final | 36 |
| Parameter 'clientHeight' is not assigned and could be declared final | 44 |
Tobago Core - org/apache/myfaces/tobago/model/SelectItem.java
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 37 |
| Parameter 'value' is not assigned and could be declared final | 41 |
| Parameter 'label' is not assigned and could be declared final | 41 |
| Parameter 'description' is not assigned and could be declared final | 45 |
| Parameter 'value' is not assigned and could be declared final | 45 |
| Parameter 'label' is not assigned and could be declared final | 45 |
| Parameter 'description' is not assigned and could be declared final | 49 |
| Parameter 'value' is not assigned and could be declared final | 49 |
| Parameter 'image' is not assigned and could be declared final | 49 |
| Parameter 'label' is not assigned and could be declared final | 49 |
| Parameter 'markup' is not assigned and could be declared final | 55 |
| Parameter 'description' is not assigned and could be declared final | 55 |
| Parameter 'value' is not assigned and could be declared final | 55 |
| Parameter 'image' is not assigned and could be declared final | 55 |
| Parameter 'label' is not assigned and could be declared final | 55 |
| Parameter 'markup' is not assigned and could be declared final | 59 |
| Parameter 'description' is not assigned and could be declared final | 59 |
| Parameter 'value' is not assigned and could be declared final | 59 |
| Parameter 'image' is not assigned and could be declared final | 59 |
| Parameter 'label' is not assigned and could be declared final | 59 |
| Parameter 'description' is not assigned and could be declared final | 63 |
| Parameter 'value' is not assigned and could be declared final | 63 |
| Parameter 'image' is not assigned and could be declared final | 63 |
| Parameter 'label' is not assigned and could be declared final | 63 |
| Parameter 'disabled' is not assigned and could be declared final | 63 |
| Parameter 'markup' is not assigned and could be declared final | 68 |
| Parameter 'description' is not assigned and could be declared final | 68 |
| Parameter 'value' is not assigned and could be declared final | 68 |
| Parameter 'image' is not assigned and could be declared final | 68 |
| Parameter 'label' is not assigned and could be declared final | 68 |
| Parameter 'disabled' is not assigned and could be declared final | 68 |
| Parameter 'markup' is not assigned and could be declared final | 72 |
| Parameter 'description' is not assigned and could be declared final | 72 |
| Parameter 'value' is not assigned and could be declared final | 72 |
| Parameter 'image' is not assigned and could be declared final | 72 |
| Parameter 'label' is not assigned and could be declared final | 72 |
| Parameter 'disabled' is not assigned and could be declared final | 72 |
| Parameter 'image' is not assigned and could be declared final | 82 |
| Parameter 'markup' is not assigned and could be declared final | 90 |
| Parameter 'currentMarkup' is not assigned and could be declared final | 98 |
Tobago Core - org/apache/myfaces/tobago/model/Selectable.java
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 98 |
| Parameter 'name' is not assigned and could be declared final | 119 |
| Local variable 'value' could be declared final | 126 |
| Avoid if (x != y) ..; else ..; | 127 - 131 |
Tobago Core - org/apache/myfaces/tobago/model/SheetState.java
| Violation | Line |
|---|---|
| Overridable method 'resetSelected' called during object construction | 49 |
| Parameter 'selectedRows' is not assigned and could be declared final | 60 |
| Parameter 'sortedColumnId' is not assigned and could be declared final | 69 |
| Parameter 'ascending' is not assigned and could be declared final | 77 |
| Parameter 'columnWidths' is not assigned and could be declared final | 85 |
| Parameter 'first' is not assigned and could be declared final | 93 |
| Parameter 'sortEvent' is not assigned and could be declared final | 97 |
| Local variable 'actualColumn' could be declared final | 99 |
| Parameter 'scrollPosition' is not assigned and could be declared final | 113 |
| Parameter 'expandedState' is not assigned and could be declared final | 124 |
| Parameter 'value' is not assigned and could be declared final | 128 |
| Local variable 'sep' could be declared final | 131 |
| String.indexOf(char) is faster than String.indexOf(String). | 131 |
| Do not add empty strings | 133 |
| Local variable 'left' could be declared final | 138 |
| Local variable 'top' could be declared final | 139 |
Tobago Core - org/apache/myfaces/tobago/model/TreeNodeDataModel.java
| Violation | Line |
|---|---|
| The class 'TreeNodeDataModel' has a Cyclomatic Complexity of 2 (Highest = 7). | 36 - 291 |
| Private field 'mapping' could be made final; it is only initialized in the declaration or constructor. | 42 |
| Private field 'back' could be made final; it is only initialized in the declaration or constructor. | 43 |
| Private field 'showRoot' could be made final; it is only initialized in the declaration or constructor. | 44 |
| Parameter 'expandedState' is not assigned and could be declared final | 52 |
| Parameter 'showRoot' is not assigned and could be declared final | 52 |
| Parameter 'data' is not assigned and could be declared final | 52 |
| Overridable method 'reset' called during object construction | 58 |
| Avoid instantiation through private constructors from outside of the constructor's class. | 68 |
| Avoid instantiating new objects inside loops | 68 |
| Parameter 'expandedState' is not assigned and could be declared final | 81 |
| The method 'update' has a Cyclomatic Complexity of 5. | 81 - 100 |
| Avoid instantiation through private constructors from outside of the constructor's class. | 88 |
| Avoid instantiating new objects inside loops | 88 |
| Avoid reassigning parameters such as 'node' | 102 |
| Parameter 'node' is not assigned and could be declared final | 118 |
| Local variable 'parent' could be declared final | 119 |
| Parameter 'rowIndex' is not assigned and could be declared final | 175 |
| Parameter 'data' is not assigned and could be declared final | 180 |
| The method 'isRowVisible' has a Cyclomatic Complexity of 7. | 185 - 205 |
| Avoid instantiating new objects inside loops | 199 |
| Parameter 'clientId' is not assigned and could be declared final | 215 |
| Avoid if (x != y) ..; else ..; | 226 - 230 |
| Parameter 'node' is not assigned and could be declared final | 261 |
| Private field 'node' could be made final; it is only initialized in the declaration or constructor. | 272 |
| Parameter 'node' is not assigned and could be declared final | 275 |
| Parameter 'clientId' is not assigned and could be declared final | 287 |
Tobago Core - org/apache/myfaces/tobago/model/TreePath.java
| Violation | Line |
|---|---|
| The class 'TreePath' has a Cyclomatic Complexity of 2 (Highest = 6). | 57 - 192 |
| Parameter 'path' is not assigned and could be declared final | 61 |
| Parameter 'pathList' is not assigned and could be declared final | 65 |
| Parameter 'position' is not assigned and could be declared final | 76 |
| Parameter 'addendum' is not assigned and could be declared final | 76 |
| Parameter 'string' is not assigned and could be declared final | 86 |
| Avoid reassigning parameters such as 'node' | 90 |
| The constructor 'TreePath' has a Cyclomatic Complexity of 6. | 90 - 113 |
| Local variable 'parent' could be declared final | 104 |
| Local variable 'child' could be declared final | 105 |
| Local variable 'builder' could be declared final | 127 |
| Local variable 'builder' could be declared final | 140 |
| Avoid reassigning parameters such as 'tree' | 156 |
| Local variable 'pos' could be declared final | 161 |
| Parameter 'o' is not assigned and could be declared final | 171 |
| Local variable 'nodeIndex' could be declared final | 178 |
| Avoid if (x != y) ..; else ..; | 185 |
Tobago Core - org/apache/myfaces/tobago/model/TreeSelectable.java
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 45 |
| Parameter 'name' is not assigned and could be declared final | 68 |
| Local variable 'value' could be declared final | 69 |
| Avoid if (x != y) ..; else ..; | 70 - 74 |
Tobago Core - org/apache/myfaces/tobago/model/TreeState.java
| Violation | Line |
|---|---|
| Private field 'expandedState' could be made final; it is only initialized in the declaration or constructor. | 26 |
| Private field 'markedState' could be made final; it is only initialized in the declaration or constructor. | 27 |
| Parameter 'expandedState' is not assigned and could be declared final | 29 |
| Parameter 'markedState' is not assigned and could be declared final | 29 |
Tobago Core - org/apache/myfaces/tobago/model/Wizard.java
| Violation | Line |
|---|---|
| Overridable method 'reset' called during object construction | 38 |
| Parameter 'event' is not assigned and could be declared final | 41 |
| Parameter 'event' is not assigned and could be declared final | 47 |
| Local variable 'step' could be declared final | 48 |
| Local variable 'outcome' could be declared final | 59 |
| Parameter 'event' is not assigned and could be declared final | 74 |
| Parameter 'event' is not assigned and could be declared final | 82 |
Tobago Core - org/apache/myfaces/tobago/model/WizardStep.java
| Violation | Line |
|---|---|
| Parameter 'index' is not assigned and could be declared final | 28 |
| Parameter 'outcome' is not assigned and could be declared final | 36 |
| Parameter 'title' is not assigned and could be declared final | 44 |
| Parameter 'index' is not assigned and could be declared final | 52 |
| Local variable 'builder' could be declared final | 57 |
Tobago Core - org/apache/myfaces/tobago/portlet/PortletUtils.java
| Violation | Line |
|---|---|
| Parameter 'facesContext' is not assigned and could be declared final | 64 |
| Parameter 'facesContext' is not assigned and could be declared final | 78 |
| Parameter 'facesContext' is not assigned and could be declared final | 82 |
| Local variable 'request' could be declared final | 83 |
| Parameter 'facesContext' is not assigned and could be declared final | 90 |
| Parameter 'viewId' is not assigned and could be declared final | 90 |
| Local variable 'response' could be declared final | 91 |
| Local variable 'url' could be declared final | 92 |
| Parameter 'facesContext' is not assigned and could be declared final | 97 |
| Local variable 'request' could be declared final | 98 |
Tobago Core - org/apache/myfaces/tobago/renderkit/AbstractAjaxRendererBaseWrapper.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 31 |
| Parameter 'context' is not assigned and could be declared final | 31 |
Tobago Core - org/apache/myfaces/tobago/renderkit/AbstractLayoutRendererWrapper.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 31 |
| Parameter 'facesContext' is not assigned and could be declared final | 31 |
| Parameter 'component' is not assigned and could be declared final | 35 |
| Parameter 'facesContext' is not assigned and could be declared final | 35 |
| Parameter 'component' is not assigned and could be declared final | 39 |
| Parameter 'facesContext' is not assigned and could be declared final | 39 |
| Parameter 'component' is not assigned and could be declared final | 43 |
| Parameter 'facesContext' is not assigned and could be declared final | 43 |
| Parameter 'component' is not assigned and could be declared final | 47 |
| Parameter 'facesContext' is not assigned and could be declared final | 47 |
| Parameter 'component' is not assigned and could be declared final | 51 |
| Parameter 'facesContext' is not assigned and could be declared final | 51 |
Tobago Core - org/apache/myfaces/tobago/renderkit/AbstractLayoutableRendererBaseWrapper.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 31 |
| Parameter 'facesContext' is not assigned and could be declared final | 31 |
| Parameter 'name' is not assigned and could be declared final | 31 |
| Parameter 'component' is not assigned and could be declared final | 35 |
| Parameter 'facesContext' is not assigned and could be declared final | 35 |
| Parameter 'component' is not assigned and could be declared final | 39 |
| Parameter 'facesContext' is not assigned and could be declared final | 39 |
| Parameter 'component' is not assigned and could be declared final | 43 |
| Parameter 'facesContext' is not assigned and could be declared final | 43 |
| Parameter 'component' is not assigned and could be declared final | 47 |
| Parameter 'facesContext' is not assigned and could be declared final | 47 |
| Parameter 'component' is not assigned and could be declared final | 51 |
| Parameter 'facesContext' is not assigned and could be declared final | 51 |
| Parameter 'component' is not assigned and could be declared final | 55 |
| Parameter 'facesContext' is not assigned and could be declared final | 55 |
| Parameter 'component' is not assigned and could be declared final | 59 |
| Parameter 'facesContext' is not assigned and could be declared final | 59 |
| Parameter 'component' is not assigned and could be declared final | 63 |
| Parameter 'facesContext' is not assigned and could be declared final | 63 |
| Parameter 'component' is not assigned and could be declared final | 67 |
| Parameter 'facesContext' is not assigned and could be declared final | 67 |
| Parameter 'component' is not assigned and could be declared final | 71 |
| Parameter 'facesContext' is not assigned and could be declared final | 71 |
| Parameter 'component' is not assigned and could be declared final | 75 |
| Parameter 'facesContext' is not assigned and could be declared final | 75 |
| Parameter 'component' is not assigned and could be declared final | 79 |
| Parameter 'facesContext' is not assigned and could be declared final | 79 |
| Parameter 'component' is not assigned and could be declared final | 83 |
| Parameter 'facesContext' is not assigned and could be declared final | 83 |
| Parameter 'component' is not assigned and could be declared final | 87 |
| Parameter 'facesContext' is not assigned and could be declared final | 87 |
| Parameter 'component' is not assigned and could be declared final | 91 |
| Parameter 'facesContext' is not assigned and could be declared final | 91 |
| Parameter 'component' is not assigned and could be declared final | 95 |
| Parameter 'facesContext' is not assigned and could be declared final | 95 |
| Parameter 'component' is not assigned and could be declared final | 99 |
| Parameter 'facesContext' is not assigned and could be declared final | 99 |
| Parameter 'component' is not assigned and could be declared final | 103 |
| Parameter 'facesContext' is not assigned and could be declared final | 103 |
| Parameter 'component' is not assigned and could be declared final | 107 |
| Parameter 'facesContext' is not assigned and could be declared final | 107 |
| Parameter 'component' is not assigned and could be declared final | 111 |
| Parameter 'facesContext' is not assigned and could be declared final | 111 |
| Parameter 'component' is not assigned and could be declared final | 115 |
| Parameter 'facesContext' is not assigned and could be declared final | 115 |
Tobago Core - org/apache/myfaces/tobago/renderkit/AbstractRendererBaseWrapper.java
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'LOG'. | 35 |
| Avoid unused private fields such as 'LOG'. | 35 |
| Parameter 'component' is not assigned and could be declared final | 38 |
| Parameter 'facesContext' is not assigned and could be declared final | 38 |
| Parameter 'parent' is not assigned and could be declared final | 38 |
| Parameter 'component' is not assigned and could be declared final | 43 |
| Parameter 'facesContext' is not assigned and could be declared final | 43 |
| Parameter 'component' is not assigned and could be declared final | 51 |
| Parameter 'context' is not assigned and could be declared final | 51 |
| Parameter 'component' is not assigned and could be declared final | 61 |
| Parameter 'facesContext' is not assigned and could be declared final | 61 |
| Parameter 'input' is not assigned and could be declared final | 66 |
| Parameter 'component' is not assigned and could be declared final | 71 |
| Parameter 'facesContext' is not assigned and could be declared final | 71 |
| Parameter 'component' is not assigned and could be declared final | 76 |
| Parameter 'component' is not assigned and could be declared final | 81 |
| Parameter 'facesContext' is not assigned and could be declared final | 81 |
| Parameter 'component' is not assigned and could be declared final | 86 |
| Parameter 'facesContext' is not assigned and could be declared final | 86 |
| Parameter 'submittedValue' is not assigned and could be declared final | 86 |
| Parameter 'component' is not assigned and could be declared final | 92 |
| Parameter 'facesContext' is not assigned and could be declared final | 92 |
| Parameter 'component' is not assigned and could be declared final | 97 |
| Parameter 'facesContext' is not assigned and could be declared final | 97 |
| Parameter 'component' is not assigned and could be declared final | 102 |
| Parameter 'facesContext' is not assigned and could be declared final | 102 |
| Parameter 'facesContext' is not assigned and could be declared final | 107 |
| Parameter 'clientId' is not assigned and could be declared final | 107 |
| Parameter 'facesContext' is not assigned and could be declared final | 111 |
| Local variable 'renderer' could be declared final | 112 - 113 |
Tobago Core - org/apache/myfaces/tobago/renderkit/HtmlUtils.java
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 28 - 81 |
| The class 'HtmlUtils' has a Cyclomatic Complexity of 3 (Highest = 5). | 28 - 81 |
| Parameter 'name' is not assigned and could be declared final | 33 |
| Parameter 'value' is not assigned and could be declared final | 33 |
| The method 'generateAttribute' has a Cyclomatic Complexity of 5. | 33 - 45 |
| Assigning an Object to null is a code smell. Consider refactoring. | 36 |
| Parameter 'component' is not assigned and could be declared final | 47 |
| Parameter 'name' is not assigned and could be declared final | 47 |
| Parameter 'appendValue' is not assigned and could be declared final | 48 |
| Local variable 'attribute' could be declared final | 49 |
| Avoid if (x != y) ..; else ..; | 50 - 51 |
| Parameter 'component' is not assigned and could be declared final | 54 |
| Parameter 'facesContext' is not assigned and could be declared final | 55 |
| Local variable 'onchange' could be declared final | 74 |
Tobago Core - org/apache/myfaces/tobago/renderkit/InputRendererBase.java
| Violation | Line |
|---|---|
| The class 'InputRendererBase' has a Cyclomatic Complexity of 6 (Highest = 5). | 31 - 63 |
| Parameter 'component' is not assigned and could be declared final | 35 |
| Parameter 'context' is not assigned and could be declared final | 35 |
| The method 'decode' has a Cyclomatic Complexity of 5. | 35 - 62 |
| Local variable 'clientId' could be declared final | 47 |
| Local variable 'requestParameterMap' could be declared final | 49 - 50 |
| Local variable 'newValue' could be declared final | 59 |
Tobago Core - org/apache/myfaces/tobago/renderkit/LabelWithAccessKey.java
| Violation | Line |
|---|---|
| Parameter 'label' is not assigned and could be declared final | 41 |
| Parameter 'component' is not assigned and could be declared final | 46 |
| Assigning an Object to null is a code smell. Consider refactoring. | 53 |
| Avoid reassigning parameters such as 'index' | 57 |
| Avoid reassigning parameters such as 'escapedIndicatorCount' | 57 |
| Parameter 'label' is not assigned and could be declared final | 57 |
| Parameter 'label' is not assigned and could be declared final | 77 |
| Avoid if (x != y) ..; else ..; | 78 - 86 |
| Assigning an Object to null is a code smell. Consider refactoring. | 90 |
| Assigning an Object to null is a code smell. Consider refactoring. | 91 |
| Parameter 'text' is not assigned and could be declared final | 107 |
| Parameter 'accessKey' is not assigned and could be declared final | 111 |
| Parameter 'accessKey' is not assigned and could be declared final | 122 |
Tobago Core - org/apache/myfaces/tobago/renderkit/LayoutComponentRendererBase.java
| Violation | Line |
|---|---|
| Parameter 'component' is not assigned and could be declared final | 32 |
| Parameter 'facesContext' is not assigned and could be declared final | 32 |
| Parameter 'name' is not assigned and could be declared final | 32 |
| Parameter 'component' is not assigned and could be declared final | 36 |
| Parameter 'facesContext' is not assigned and could be declared final | 36 |
| Parameter 'component' is not assigned and could be declared final | 40 |
| Parameter 'facesContext' is not assigned and could be declared final | 40 |
| Parameter 'component' is not assigned and could be declared final | 44 |
| Parameter 'facesContext' is not assigned and could be declared final | 44 |
| Parameter 'component' is not assigned and could be declared final | 48 |
| Parameter 'facesContext' is not assigned and could be declared final | 48 |
| Parameter 'component' is not assigned and could be declared final | 52 |
| Parameter 'facesContext' is not assigned and could be declared final | 52 |
| Parameter 'component' is not assigned and could be declared final | 56 |
| Parameter 'facesContext' is not assigned and could be declared final | 56 |
| Parameter 'component' is not assigned and could be declared final | 60 |
| Parameter 'facesContext' is not assigned and could be declared final | 60 |
| Parameter 'component' is not assigned and could be declared final | 64 |
| Parameter 'facesContext' is not assigned and could be declared final | 64 |
| Parameter 'component' is not assigned and could be declared final | 68 |
| Parameter 'facesContext' is not assigned and could be declared final | 68 |
| Parameter 'component' is not assigned and could be declared final | 72 |
| Parameter 'facesContext' is not assigned and could be declared final | 72 |
| Parameter 'component' is not assigned and could be declared final | 76 |
| Parameter 'facesContext' is not assigned and could be declared final | 76 |
| Parameter 'component' is not assigned and could be declared final | 80 |
| Parameter 'facesContext' is not assigned and could be declared final | 80 |
| Parameter 'component' is not assigned and could be declared final | 84 |
| Parameter 'facesContext' is not assigned and could be declared final | 84 |
| Parameter 'component' is not assigned and could be declared final | 88 |
| Parameter 'facesContext' is not assigned and could be declared final | 88 |
| Parameter 'component' is not assigned and could be declared final | 92 |
| Parameter 'facesContext' is not assigned and could be declared final | 92 |
| Parameter 'component' is not assigned and could be declared final | 96 |
| Parameter 'facesContext' is not assigned and could be declared final | 96 |
| Parameter 'component' is not assigned and could be declared final | 100 |
| Parameter 'facesContext' is not assigned and could be declared final | 100 |
| Parameter 'component' is not assigned and could be declared final | 104 |
| Parameter 'facesContext' is not assigned and could be declared final | 104 |
| Parameter 'component' is not assigned and could be declared final | 108 |
| Parameter 'facesContext' is not assigned and could be declared final | 108 |
| Parameter 'component' is not assigned and could be declared final | 112 |
| Parameter 'facesContext' is not assigned and could be declared final | 112 |
| Parameter 'component' is not assigned and could be declared final | 116 |
| Parameter 'facesContext' is not assigned and could be declared final | 116 |
| Avoid if (x != y) ..; else ..; | 119 - 123 |
Tobago Core - org/apache/myfaces/tobago/renderkit/PageRendererBase.java
| Violation | Line |
|---|---|
| The class 'PageRendererBase' has a Cyclomatic Complexity of 4 (Highest = 5). | 36 - 99 |
| Parameter 'component' is not assigned and could be declared final | 40 |
| Parameter 'facesContext' is not assigned and could be declared final | 40 |
| Local variable 'page' could be declared final | 42 |
| Parameter 'page' is not assigned and could be declared final | 49 |
| Parameter 'facesContext' is not assigned and could be declared final | 49 |
| The method 'decodeActionPosition' has a Cyclomatic Complexity of 5. | 49 - 73 |
| Local variable 'actionIdName' could be declared final | 50 |
| Local variable 'newActionId' could be declared final | 51 |
| Local variable 'actionPositionName' could be declared final | 58 |
| Local variable 'actionPositionString' could be declared final | 59 - 60 |
| Local variable 'actionPosition' could be declared final | 65 |
| Parameter 'page' is not assigned and could be declared final | 76 |
| Parameter 'facesContext' is not assigned and could be declared final | 76 |
| Local variable 'tokenizer' could be declared final | 83 |
| Local variable 'width' could be declared final | 84 |
| Local variable 'height' could be declared final | 85 |
| Local variable 'pageState' could be declared final | 87 |
Tobago Core - org/apache/myfaces/tobago/renderkit/RendererBase.java
| Violation | Line |
|---|---|
| The class 'RendererBase' has a Cyclomatic Complexity of 3 (Highest = 8). | 45 - 200 |
| Parameter 'component' is not assigned and could be declared final | 54 |
| Parameter 'facesContext' is not assigned and could be declared final | 54 |
| Local variable 'markup' could be declared final | 58 |
| Document empty method | 67 - 68 |
| Parameter 'component' is not assigned and could be declared final | 67 |
| Parameter 'context' is not assigned and could be declared final | 67 |
| Parameter 'rendererType' is not assigned and could be declared final | 74 |
| Parameter 'component' is not assigned and could be declared final | 82 |
| Parameter 'facesContext' is not assigned and could be declared final | 82 |
| Parameter 'key' is not assigned and could be declared final | 82 |
| Parameter 'input' is not assigned and could be declared final | 86 |
| Local variable 'submittedValue' could be declared final | 87 |
| Parameter 'component' is not assigned and could be declared final | 94 |
| Parameter 'facesContext' is not assigned and could be declared final | 94 |
| The method 'getCurrentValue' has a Cyclomatic Complexity of 5. | 94 - 109 |
| Local variable 'editableValueHolder' could be declared final | 97 |
| Local variable 'submittedValue' could be declared final | 98 |
| Local variable 'currentObj' could be declared final | 104 |
| Parameter 'component' is not assigned and could be declared final | 111 |
| Parameter 'context' is not assigned and could be declared final | 111 |
| Parameter 'currentValue' is not assigned and could be declared final | 111 |
| The method 'getFormattedValue' has a Cyclomatic Complexity of 7. | 111 - 140 |
| Local variable 'converterType' could be declared final | 131 |
| Parameter 'component' is not assigned and could be declared final | 142 |
| Local variable 'value' could be declared final | 144 |
| Parameter 'component' is not assigned and could be declared final | 154 |
| Parameter 'context' is not assigned and could be declared final | 154 |
| The method 'getConverter' has a Cyclomatic Complexity of 8. | 154 - 175 |
| Local variable 'valueBinding' could be declared final | 160 |
| Local variable 'converterType' could be declared final | 162 |
| Parameter 'component' is not assigned and could be declared final | 178 |
| Parameter 'submittedValue' is not assigned and could be declared final | 178 |
| Parameter 'context' is not assigned and could be declared final | 178 |
| Local variable 'converter' could be declared final | 183 |
| Avoid if (x != y) ..; else ..; | 184 - 188 |
| Document empty method | 191 - 192 |
| Parameter 'component' is not assigned and could be declared final | 191 |
| Parameter 'facesContext' is not assigned and could be declared final | 191 |
| Parameter 'parent' is not assigned and could be declared final | 191 |
| Use block level rather than method level synchronization | 194 - 199 |
Tobago Core - org/apache/myfaces/tobago/renderkit/RendererBaseWrapper.java
| Violation | Line |
|---|---|
| Private field 'renderer' could be made final; it is only initialized in the declaration or constructor. | 29 |
| Parameter 'renderer' is not assigned and could be declared final | 31 |
| Document empty method | 35 - 36 |
| Parameter 'component' is not assigned and could be declared final | 35 |
| Parameter 'facesContext' is not assigned and could be declared final | 35 |
| Parameter 'component' is not assigned and could be declared final | 38 |
| Parameter 'submittedValue' is not assigned and could be declared final | 38 |
| Parameter 'context' is not assigned and could be declared final | 38 |
| Parameter 'component' is not assigned and could be declared final | 43 |
| Parameter 'facesContext' is not assigned and could be declared final | 43 |
| Parameter 'component' is not assigned and could be declared final | 47 |
| Parameter 'context' is not assigned and could be declared final | 47 |
| Parameter 'component' is not assigned and could be declared final | 51 |
| Parameter 'context' is not assigned and could be declared final | 51 |
| Parameter 'component' is not assigned and could be declared final | 55 |
| Parameter 'context' is not assigned and could be declared final | 55 |
| Parameter 'context' is not assigned and could be declared final | 59 |
| Parameter 'clientId' is not assigned and could be declared final | 59 |
Tobago Core - org/apache/myfaces/tobago/renderkit/SelectManyRendererBase.java
| Violation | Line |
|---|---|
| The class 'SelectManyRendererBase' has a Cyclomatic Complexity of 13 (Highest = 26). | 39 - 199 |
| The class 'SelectManyRendererBase' has a Cyclomatic Complexity of 13 (Highest = 26). | 39 - 199 |
| Parameter 'component' is not assigned and could be declared final | 43 |
| Parameter 'facesContext' is not assigned and could be declared final | 43 |
| The method 'decode' has a Cyclomatic Complexity of 8. | 43 - 68 |
| Local variable 'uiSelectMany' could be declared final | 48 |
| Avoid if (x != y) ..; else ..; | 55 |
| Deeply nested if..then statements are hard to read | 56 - 60 |
| Parameter 'component' is not assigned and could be declared final | 71 |
| Parameter 'facesContext' is not assigned and could be declared final | 71 |
| Parameter 'submittedValue' is not assigned and could be declared final | 71 |
| Parameter 'facesContext' is not assigned and could be declared final | 85 |
| The method 'getConvertedUISelectManyValue' has a Cyclomatic Complexity of 26. | 85 - 197 |
| The method getConvertedUISelectManyValue() has an NPath complexity of 823680 | 85 - 197 |
| Avoid really long methods. | 85 - 197 |
| The method 'getConvertedUISelectManyValue' has a Cyclomatic Complexity of 26. | 85 - 197 |
| Parameter 'component' is not assigned and could be declared final | 86 |
| Parameter 'submittedValue' is not assigned and could be declared final | 87 |
| Local variable 'vb' could be declared final | 97 |
| These nested if statements could be combined | 145 - 147 |
| These nested if statements could be combined | 145 - 147 |
| Local variable 'len' could be declared final | 153 |
| Local variable 'length' could be declared final | 167 |
| Local variable 'list' could be declared final | 168 |
| Local variable 'len' could be declared final | 181 |
| Local variable 'convertedValues' could be declared final | 182 |
| Local variable 'length' could be declared final | 190 |
| Local variable 'convertedValues' could be declared final | 191 |
Tobago Core - org/apache/myfaces/tobago/renderkit/SelectOneRendererBase.java
| Violation | Line |
|---|---|
| The class 'SelectOneRendererBase' has a Cyclomatic Complexity of 5 (Highest = 4). | 30 - 51 |
| Parameter 'component' is not assigned and could be declared final | 34 |
| Parameter 'facesContext' is not assigned and could be declared final | 34 |
| Local variable 'uiSelectOne' could be declared final | 39 |
| Local variable 'clientId' could be declared final | 41 |
| Local variable 'newValue' could be declared final | 42 - 43 |
Tobago Core - org/apache/myfaces/tobago/renderkit/TobagoRenderKit.java
| Violation | Line |
|---|---|
| The class 'TobagoRenderKit' has a Cyclomatic Complexity of 4 (Highest = 13). | 49 - 203 |
| The class 'TobagoRenderKit' has a Cyclomatic Complexity of 4 (Highest = 13). | 49 - 203 |
| Private field 'responseStateManager' could be made final; it is only initialized in the declaration or constructor. | 55 |
| Private field 'renderers' could be made final; it is only initialized in the declaration or constructor. | 59 |
| Parameter 'rendererType' is not assigned and could be declared final | 68 |
| Parameter 'family' is not assigned and could be declared final | 68 |
| Avoid instantiation through private constructors from outside of the constructor's class. | 69 |
| Local variable 'renderKit' could be declared final | 71 |
| Local variable 'rkFactory' could be declared final | 88 |
| The method 'createResponseWriter' has a Cyclomatic Complexity of 13. | 96 - 145 |
| The method createResponseWriter() has an NPath complexity of 400 | 96 - 145 |
| The method 'createResponseWriter' has a Cyclomatic Complexity of 13. | 96 - 145 |
| Parameter 'writer' is not assigned and could be declared final | 97 |
| Parameter 'contentTypeList' is not assigned and could be declared final | 97 |
| Parameter 'characterEncoding' is not assigned and could be declared final | 97 |
| Local variable 'facesContext' could be declared final | 99 |
| The String literal "text/html" appears 5 times in this file; the first occurrence is on line 104 | 104 |
| Parameter 'rendererType' is not assigned and could be declared final | 148 |
| Parameter 'family' is not assigned and could be declared final | 148 |
| Parameter 'renderer' is not assigned and could be declared final | 148 |
| Avoid instantiation through private constructors from outside of the constructor's class. | 149 |
| The method 'getResponseStateManager' has a Cyclomatic Complexity of 5. | 153 - 160 |
| Parameter 'outputStream' is not assigned and could be declared final | 163 |
| The class 'Key' has a Cyclomatic Complexity of 3 (Highest = 6). | 167 - 202 |
| Parameter 'rendererType' is not assigned and could be declared final | 171 |
| Parameter 'family' is not assigned and could be declared final | 171 |
| Parameter 'o' is not assigned and could be declared final | 176 |
| The method 'equals' has a Cyclomatic Complexity of 6. | 176 - 194 |
| Local variable 'key' could be declared final | 184 |
Tobago Core - org/apache/myfaces/tobago/renderkit/TobagoResponseStateManager.java
| Violation | Line |
|---|---|
| The class 'TobagoResponseStateManager' has a Cyclomatic Complexity of 4 (Highest = 7). | 35 - 115 |
| Parameter 'context' is not assigned and could be declared final | 42 |
| Parameter 'viewId' is not assigned and could be declared final | 42 |
| Local variable 'treeStructure' could be declared final | 43 |
| Local variable 'componentStateToRestore' could be declared final | 44 |
| Parameter 'facescontext' is not assigned and could be declared final | 51 |
| Parameter 'viewId' is not assigned and could be declared final | 51 |
| Local variable 'requestMap' could be declared final | 52 |
| Local variable 'requestViewId' could be declared final | 53 |
| Parameter 'facesContext' is not assigned and could be declared final | 63 |
| Local variable 'requestMap' could be declared final | 64 |
| Parameter 'facesContext' is not assigned and could be declared final | 68 |
| The method 'writeState' has a Cyclomatic Complexity of 7. | 68 - 113 |
| Parameter 'serializedview' is not assigned and could be declared final | 69 |
| Local variable 'responseWriter' could be declared final | 70 |
| Local variable 'treeStruct' could be declared final | 71 |
| Local variable 'compStates' could be declared final | 72 |
| Avoid if (x != y) ..; else ..; | 74 - 87 |
| Avoid if (x != y) ..; else ..; | 93 - 104 |
Tobago Core - org/apache/myfaces/tobago/renderkit/css/Classes.java
| Violation | Line |
|---|---|
| The class 'Classes' has a Cyclomatic Complexity of 2 (Highest = 9). | 61 - 164 |
| Parameter 'component' is not assigned and could be declared final | 69 |
| Parameter 'sub' is not assigned and could be declared final | 73 |
| Parameter 'component' is not assigned and could be declared final | 73 |
| Parameter 'component' is not assigned and could be declared final | 77 |
| Parameter 'explicit' is not assigned and could be declared final | 77 |
| Parameter 'sub' is not assigned and could be declared final | 81 |
| Parameter 'component' is not assigned and could be declared final | 81 |
| Parameter 'explicit' is not assigned and could be declared final | 81 |
| Use block level rather than method level synchronization | 86 - 100 |
| Parameter 'sub' is not assigned and could be declared final | 87 |
| Parameter 'component' is not assigned and could be declared final | 87 |
| Parameter 'explicit' is not assigned and could be declared final | 87 |
| Parameter 'markupFromComponent' is not assigned and could be declared final | 87 |
| Parameter 'ignoreCheck' is not assigned and could be declared final | 87 |
| Parameter 'markup' is not assigned and could be declared final | 102 |
| Parameter 'sub' is not assigned and could be declared final | 102 |
| Parameter 'ignoreMarkupCheck' is not assigned and could be declared final | 102 |
| Parameter 'rendererName' is not assigned and could be declared final | 102 |
| The constructor 'Classes' has a Cyclomatic Complexity of 9. | 102 - 135 |
| Avoid if (x != y) ..; else ..; | 107 |
| Local variable 'builder' could be declared final | 107 |
| Local variable 'theme' could be declared final | 115 |
| Parameter 'component' is not assigned and could be declared final | 143 |
| Parameter 'sub' is not assigned and could be declared final | 152 |
| Parameter 'explicit' is not assigned and could be declared final | 152 |
| Parameter 'rendererName' is not assigned and could be declared final | 152 |
| Parameter 'explicit' is not assigned and could be declared final | 160 |
| Parameter 'rendererName' is not assigned and could be declared final | 160 |
Tobago Core - org/apache/myfaces/tobago/renderkit/css/Overflow.java
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 30 |
Tobago Core - org/apache/myfaces/tobago/renderkit/css/Position.java
| Violation | Line |
|---|---|
| Parameter 'value' is not assigned and could be declared final | 31 |
Tobago Core - org/apache/myfaces/tobago/renderkit/css/Style.java
| Violation | Line |
|---|---|
| This class has a bunch of public methods and attributes | 20 - 536 |
| The class 'Style' has a Cyclomatic Complexity of 2 (Highest = 23). | 33 - 536 |
| The class 'Style' has a Cyclomatic Complexity of 2 (Highest = 23). | 33 - 536 |
| Too many fields | 33 - 536 |
| Document empty constructor | 59 - 60 |
| Parameter 'map' is not assigned and could be declared final | 62 |
| Parameter 'facesContext' is not assigned and could be declared final | 86 |
| Parameter 'layout' is not assigned and could be declared final | 86 |
| The constructor 'Style' has a Cyclomatic Complexity of 10. | 86 - 131 |
| The constructor 'Style' has a Cyclomatic Complexity of 10. | 86 - 131 |
| Local variable 'rendererType' could be declared final | 88 |
| Overridable method 'getDisplay' called during object construction | 124 |
| Assigning an Object to null is a code smell. Consider refactoring. | 128 |
| Assigning an Object to null is a code smell. Consider refactoring. | 129 |
| The method 'encode' has a Cyclomatic Complexity of 22. | 142 - 251 |
| The method encode() has an NPath complexity of 2097152 | 142 - 251 |
| Avoid really long methods. | 142 - 251 |
| The method 'encode' has a Cyclomatic Complexity of 22. | 142 - 251 |
| Local variable 'buf' could be declared final | 143 |
| The method 'encodeJson' has a Cyclomatic Complexity of 23. | 253 - 367 |
| The method encodeJson() has an NPath complexity of 4194304 | 253 - 367 |
| Avoid really long methods. | 253 - 367 |
| The method 'encodeJson' has a Cyclomatic Complexity of 23. | 253 - 367 |
| Local variable 'buf' could be declared final | 254 |
| The String literal "\"," appears 20 times in this file; the first occurrence is on line 258 | 258 |
| Parameter 'width' is not assigned and could be declared final | 373 |
| Parameter 'height' is not assigned and could be declared final | 381 |
| Parameter 'left' is not assigned and could be declared final | 389 |
| Parameter 'top' is not assigned and could be declared final | 397 |
| Parameter 'display' is not assigned and could be declared final | 405 |
| Parameter 'position' is not assigned and could be declared final | 413 |
| Parameter 'overflowX' is not assigned and could be declared final | 421 |
| Parameter 'overflowY' is not assigned and could be declared final | 429 |
| Parameter 'marginLeft' is not assigned and could be declared final | 437 |
| Parameter 'marginRight' is not assigned and could be declared final | 445 |
| Parameter 'marginTop' is not assigned and could be declared final | 453 |
| Parameter 'marginBottom' is not assigned and could be declared final | 461 |
| Parameter 'margin' is not assigned and could be declared final | 469 |
| Parameter 'paddingLeft' is not assigned and could be declared final | 477 |
| Parameter 'paddingRight' is not assigned and could be declared final | 485 |
| Parameter 'paddingTop' is not assigned and could be declared final | 493 |
| Parameter 'paddingBottom' is not assigned and could be declared final | 501 |
| Parameter 'padding' is not assigned and could be declared final | 509 |
| Parameter 'backgroundImage' is not assigned and could be declared final | 517 |
| Parameter 'zIndex' is not assigned and could be declared final | 525 |
| Parameter 'textAlign' is not assigned and could be declared final | 533 |
Tobago Core - org/apache/myfaces/tobago/renderkit/html/StyleClasses.java
| Violation | Line |
|---|---|
| The class 'StyleClasses' has a Cyclomatic Complexity of 2 (Highest = 7). | 46 - 296 |
| This class has too many methods, consider refactoring it. | 46 - 296 |
| Parameter 'sub' is not assigned and could be declared final | 66 |
| Parameter 'component' is not assigned and could be declared final | 66 |
| Overridable method 'addClass' called during object construction | 68 |
| Parameter 'base' is not assigned and could be declared final | 71 |
| Parameter 'component' is not assigned and could be declared final | 76 |
| Local variable 'attributes' could be declared final | 77 |
| Parameter 'component' is not assigned and could be declared final | 86 |
| Parameter 'clazz' is not assigned and could be declared final | 94 |
| Parameter 'clazz' is not assigned and could be declared final | 101 |
| Parameter 'sub' is not assigned and could be declared final | 105 |
| Parameter 'renderer' is not assigned and could be declared final | 105 |
| Parameter 'sub' is not assigned and could be declared final | 109 |
| Parameter 'renderer' is not assigned and could be declared final | 109 |
| Parameter 'sub' is not assigned and could be declared final | 117 |
| Parameter 'renderer' is not assigned and could be declared final | 117 |
| Local variable 'builder' could be declared final | 118 |
| Parameter 'markup' is not assigned and could be declared final | 125 |
| Parameter 'renderer' is not assigned and could be declared final | 125 |
| Parameter 'markup' is not assigned and could be declared final | 129 |
| Parameter 'renderer' is not assigned and could be declared final | 129 |
| Parameter 'sub' is not assigned and could be declared final | 133 |
| Parameter 'markup' is not assigned and could be declared final | 133 |
| Parameter 'renderer' is not assigned and could be declared final | 133 |
| Parameter 'sub' is not assigned and could be declared final | 137 |
| Parameter 'markup' is not assigned and could be declared final | 137 |
| Parameter 'renderer' is not assigned and could be declared final | 137 |
| Parameter 'sub' is not assigned and could be declared final | 141 |
| Parameter 'markup' is not assigned and could be declared final | 141 |
| Parameter 'renderer' is not assigned and could be declared final | 141 |
| Local variable 'builder' could be declared final | 142 |
| Parameter 'component' is not assigned and could be declared final | 153 |
| Parameter 'rendererName' is not assigned and could be declared final | 153 |
| Parameter 'sub' is not assigned and could be declared final | 159 |
| Parameter 'supportsMarkup' is not assigned and could be declared final | 159 |
| Parameter 'rendererName' is not assigned and could be declared final | 159 |
| The method 'addMarkupClass' has a Cyclomatic Complexity of 5. | 159 - 173 |
| Local variable 'm' could be declared final | 160 |
| Local variable 'theme' could be declared final | 163 |
| Parameter 'aspect' is not assigned and could be declared final | 175 |
| Parameter 'renderer' is not assigned and could be declared final | 175 |
| Parameter 'aspect' is not assigned and could be declared final | 179 |
| Parameter 'renderer' is not assigned and could be declared final | 179 |
| Parameter 'aspect' is not assigned and could be declared final | 183 |
| Parameter 'renderer' is not assigned and could be declared final | 183 |
| Local variable 'builder' could be declared final | 184 |
| Parameter 'sub' is not assigned and could be declared final | 190 |
| Parameter 'aspect' is not assigned and could be declared final | 190 |
| Parameter 'renderer' is not assigned and could be declared final | 190 |
| Parameter 'sub' is not assigned and could be declared final | 194 |
| Parameter 'aspect' is not assigned and could be declared final | 194 |
| Parameter 'renderer' is not assigned and could be declared final | 194 |
| Parameter 'sub' is not assigned and could be declared final | 198 |
| Parameter 'aspect' is not assigned and could be declared final | 198 |
| Parameter 'renderer' is not assigned and could be declared final | 198 |
| Local variable 'builder' could be declared final | 199 |
| Parameter 'styleClasses' is not assigned and could be declared final | 207 |
| Parameter 'clazz' is not assigned and could be declared final | 213 |
| Parameter 'rendererName' is not assigned and could be declared final | 217 |
| Local variable 'i' could be declared final | 218 |
| Local variable 'clazz' could be declared final | 219 |
| Parameter 'component' is not assigned and could be declared final | 226 |
| Parameter 'rendererName' is not assigned and could be declared final | 226 |
| Parameter 'component' is not assigned and could be declared final | 231 |
| Parameter 'rendererName' is not assigned and could be declared final | 231 |
| The method 'updateClassAttribute' has a Cyclomatic Complexity of 7. | 231 - 254 |
| Local variable 'input' could be declared final | 246 |
| Local variable 'buffer' could be declared final | 261 |
| Local variable 'i' could be declared final | 262 |
| Local variable 'clazz' could be declared final | 263 |
Tobago Core - org/apache/myfaces/tobago/servlet/NonFacesRequestServlet.java
| Violation | Line |
|---|---|
| Parameter 'response' is not assigned and could be declared final | 47 |
| Parameter 'request' is not assigned and could be declared final | 47 |
| Local variable 'lFactory' could be declared final | 50 |
| Local variable 'lifecycle' could be declared final | 51 |
| Local variable 'fcFactory' could be declared final | 52 |
| Local variable 'facesContext' could be declared final | 53 |
| Local variable 'outcome' could be declared final | 57 |
| Local variable 'application' could be declared final | 66 |
| Local variable 'viewHandler' could be declared final | 68 |
| Local variable 'viewId' could be declared final | 69 |
| Local variable 'view' could be declared final | 70 |
| Local variable 'navigationHandler' could be declared final | 74 |
| An empty method in an abstract class should be abstract instead | 90 - 92 |
Tobago Core - org/apache/myfaces/tobago/servlet/ResourceServlet.java
| Violation | Line |
|---|---|
| The class 'ResourceServlet' has a Cyclomatic Complexity of 4 (Highest = 8). | 68 - 193 |
| Private field 'resourceDirs' could be made final; it is only initialized in the declaration or constructor. | 76 |
| Parameter 'servletConfig' is not assigned and could be declared final | 79 |
| The method 'init' has a Cyclomatic Complexity of 7. | 79 - 106 |
| Local variable 'tobagoConfig' could be declared final | 81 |
| Local variable 'defaultTheme' could be declared final | 85 |
| Local variable 'expiresString' could be declared final | 89 |
| Avoid instantiating Long objects.Call Long.valueOf() instead | 92 |
| Local variable 'bufferSizeString' could be declared final | 97 |
| Parameter 'themes' is not assigned and could be declared final | 108 |
| Parameter 'theme' is not assigned and could be declared final | 114 |
| Local variable 'dir' could be declared final | 115 |
| This call to String.startsWith can be rewritten using String.charAt(0) | 116 |
| The method 'doGet' has a Cyclomatic Complexity of 8. | 124 - 175 |
| Parameter 'response' is not assigned and could be declared final | 125 |
| Parameter 'request' is not assigned and could be declared final | 125 |
| Local variable 'requestURI' could be declared final | 128 |
| Local variable 'contentType' could be declared final | 143 |
| Avoid if (x != y) ..; else ..; | 144 - 151 |
| Local variable 'message' could be declared final | 147 |
| Local variable 'classLoader' could be declared final | 155 |
| Avoid if (x != y) ..; else ..; | 165 - 171 |
| Local variable 'message' could be declared final | 168 |
| Parameter 'request' is not assigned and could be declared final | 178 |
| Avoid if (x != y) ..; else ..; | 179 - 183 |
| Parameter 'inputStream' is not assigned and could be declared final | 186 |
| Parameter 'outputStream' is not assigned and could be declared final | 186 |
| Local variable 'buffer' could be declared final | 187 |
Tobago Core - org/apache/myfaces/tobago/util/ApplyRequestValuesCallback.java
| Violation | Line |
|---|---|
| The class 'ApplyRequestValuesCallback' has a Cyclomatic Complexity of 7 (Highest = 12). | 34 - 65 |
| The class 'ApplyRequestValuesCallback' has a Cyclomatic Complexity of 7 (Highest = 12). | 34 - 65 |
| Avoid unused private fields such as 'LOG'. | 37 |
| Avoid unused private fields such as 'LOG'. | 37 |
| Parameter 'component' is not assigned and could be declared final | 39 |
| Parameter 'context' is not assigned and could be declared final | 39 |
| The method 'invokeContextCallback' has a Cyclomatic Complexity of 12. | 39 - 60 |
| The method 'invokeContextCallback' has a Cyclomatic Complexity of 12. | 39 - 60 |
| Local variable 'reload' could be declared final | 42 |
| Local variable 'immediate' could be declared final | 45 |
| Deeply nested if..then statements are hard to read | 46 - 56 |
| Local variable 'update' could be declared final | 47 |
Tobago Core - org/apache/myfaces/tobago/util/BeanComparator.java
| Violation | Line |
|---|---|
| Private field 'property' could be made final; it is only initialized in the declaration or constructor. | 35 |
| Parameter 'property' is not assigned and could be declared final | 37 |
| Parameter 'reverse' is not assigned and could be declared final | 41 |
| Parameter 'property' is not assigned and could be declared final | 41 |
| Parameter 'property' is not assigned and could be declared final | 46 |
| Parameter 'comparator' is not assigned and could be declared final | 46 |
| Parameter 'reverse' is not assigned and could be declared final | 51 |
| Parameter 'property' is not assigned and could be declared final | 51 |
| Parameter 'comparator' is not assigned and could be declared final | 51 |
| Parameter 'param1' is not assigned and could be declared final | 60 |
| Avoid if (x != y) ..; else ..; | 73 |
| Parameter 'param1' is not assigned and could be declared final | 85 |
| Parameter 'param2' is not assigned and could be declared final | 85 |
Tobago Core - org/apache/myfaces/tobago/util/BundleMapWrapper.java
| Violation | Line |
|---|---|
| This class has too many methods, consider refactoring it. | 30 - 109 |
| Private field 'basename' could be made final; it is only initialized in the declaration or constructor. | 32 |
| Parameter 'basename' is not assigned and could be declared final | 34 |
| Parameter 'key' is not assigned and could be declared final | 42 |
| Local variable 'value' could be declared final | 46 - 47 |
| Parameter 'value' is not assigned and could be declared final | 51 |
| Parameter 'key' is not assigned and could be declared final | 59 |
| Parameter 'o' is not assigned and could be declared final | 71 |
| Local variable 'that' could be declared final | 78 |
| Parameter 'v' is not assigned and could be declared final | 90 |
| Parameter 'k' is not assigned and could be declared final | 90 |
| Parameter 't' is not assigned and could be declared final | 94 |
| Parameter 'k' is not assigned and could be declared final | 98 |
Tobago Core - org/apache/myfaces/tobago/util/ComparatorBase.java
| Violation | Line |
|---|---|
| The class 'ComparatorBase' has a Cyclomatic Complexity of 3 (Highest = 14). | 27 - 126 |
| The class 'ComparatorBase' has a Cyclomatic Complexity of 3 (Highest = 14). | 27 - 126 |
| Document empty constructor | 33 - 34 |
| Parameter 'reverse' is not assigned and could be declared final | 36 |
| Parameter 'comparator' is not assigned and could be declared final | 36 |
| Parameter 'reverse' is not assigned and could be declared final | 41 |
| Parameter 'comparator' is not assigned and could be declared final | 45 |
| Parameter 'obj1' is not assigned and could be declared final | 49 |
| Parameter 'obj2' is not assigned and could be declared final | 49 |
| The method 'internalCompare' has a Cyclomatic Complexity of 14. | 49 - 89 |
| The method 'internalCompare' has a Cyclomatic Complexity of 14. | 49 - 89 |
| Local variable 'collationKey1' could be declared final | 71 - 72 |
| Local variable 'collationKey2' could be declared final | 73 - 74 |
| Avoid if (x != y) ..; else ..; | 77 - 87 |
| Parameter 'o' is not assigned and could be declared final | 112 |
| Avoid if (x != y) ..; else ..; | 120 |
Tobago Core - org/apache/myfaces/tobago/util/ComponentUtils.java
| Violation | Line |
|---|---|
| High amount of different objects as members denotes a high coupling | 20 - 1111 |
| A high number of imports can indicate a high degree of coupling within an object. | 20 - 1111 |
| This class has a bunch of public methods and attributes | 20 - 1111 |
| A class which only has private constructors should be final | 77 - 1111 |
| The class 'ComponentUtils' has a Cyclomatic Complexity of 3 (Highest = 10). | 77 - 1111 |
| This class has too many methods, consider refactoring it. | 77 - 1111 |
| Avoid really long classes. | 77 - 1111 |
| The class 'ComponentUtils' has a Cyclomatic Complexity of 3 (Highest = 10). | 77 - 1111 |
| Parameter 'context' is not assigned and could be declared final | 103 |
| Local variable 'iter' could be declared final | 104 |
| Local variable 'message' could be declared final | 105 |
| Parameter 'command' is not assigned and could be declared final | 113 |
| Local variable 'actionListeners' could be declared final | 114 |
| Parameter 'component' is not assigned and could be declared final | 123 |
| Parameter 'facesContext' is not assigned and could be declared final | 123 |
| Local variable 'messages' could be declared final | 124 - 125 |
| Local variable 'stringBuffer' could be declared final | 126 |
| Local variable 'message' could be declared final | 128 |
| Avoid reassigning parameters such as 'component' | 138 |
| Parameter 'context' is not assigned and could be declared final | 148 |
| Local variable 'view' could be declared final | 149 |
| Parameter 'component' is not assigned and could be declared final | 159 |
| Parameter 'faceletContext' is not assigned and could be declared final | 159 |
| Local variable 'viewRoot' could be declared final | 160 |
| Avoid if (x != y) ..; else ..; | 161 - 165 |
| Parameter 'component' is not assigned and could be declared final | 168 |
| Parameter 'context' is not assigned and could be declared final | 168 |
| Local variable 'view' could be declared final | 169 |
| Avoid if (x != y) ..; else ..; | 170 - 180 |
| Local variable 'page' could be declared final | 173 |
| Avoid reassigning parameters such as 'component' | 183 |
| Parameter 'facesContext' is not assigned and could be declared final | 193 |
| Parameter 'component' is not assigned and could be declared final | 197 |
| The method 'findPageBreadthFirst' has a Cyclomatic Complexity of 5. | 197 - 210 |
| Local variable 'result' could be declared final | 204 |
| Avoid reassigning parameters such as 'component' | 213 |
| Avoid reassigning parameters such as 'component' | 223 |
| Parameter 'type' is not assigned and could be declared final | 223 |
| Parameter 'component' is not assigned and could be declared final | 238 |
| Local variable 'collect' could be declared final | 239 |
| Parameter 'component' is not assigned and could be declared final | 245 |
| Parameter 'collect' is not assigned and could be declared final | 245 |
| Local variable 'kids' could be declared final | 246 |
| Local variable 'child' could be declared final | 248 |
| Parameter 'component' is not assigned and could be declared final | 260 |
| Parameter 'type' is not assigned and could be declared final | 260 |
| Parameter 'component' is not assigned and could be declared final | 277 |
| Parameter 'type' is not assigned and could be declared final | 277 |
| Local variable 'result' could be declared final | 279 |
| Parameter 'component' is not assigned and could be declared final | 297 |
| Parameter 'facesContext' is not assigned and could be declared final | 297 |
| Local variable 'forComponent' could be declared final | 298 |
| Local variable 'clientId' could be declared final | 300 |
| Parameter 'component' is not assigned and could be declared final | 312 |
| Local variable 'forValue' could be declared final | 313 |
| Parameter 'component' is not assigned and could be declared final | 328 |
| The method 'evaluateAutoFor' has a Cyclomatic Complexity of 5. | 328 - 340 |
| Local variable 'forComponent' could be declared final | 329 |
| Parameter 'component' is not assigned and could be declared final | 348 |
| Parameter 'clazz' is not assigned and could be declared final | 348 |
| The method 'evaluateAutoFor' has a Cyclomatic Complexity of 7. | 348 - 367 |
| Local variable 'forComponent' could be declared final | 349 |
| Parameter 'child' is not assigned and could be declared final | 370 |
| Parameter 'namingContainer' is not assigned and could be declared final | 370 |
| Parameter 'component' is not assigned and could be declared final | 370 |
| Parameter 'clazz' is not assigned and could be declared final | 370 |
| Avoid reassigning parameters such as 'component' | 384 |
| Local variable 'form' could be declared final | 387 |
| Parameter 'component' is not assigned and could be declared final | 397 |
| The method 'getMaximumSeverity' has a Cyclomatic Complexity of 5. | 397 - 409 |
| Assigning an Object to null is a code smell. Consider refactoring. | 399 |
| Local variable 'facesContext' could be declared final | 400 |
| Local variable 'message' could be declared final | 403 |
| Parameter 'uiInput' is not assigned and could be declared final | 411 |
| Local variable 'facesContext' could be declared final | 412 |
| Parameter 'component' is not assigned and could be declared final | 417 |
| Parameter 'component' is not assigned and could be declared final | 424 |
| Parameter 'component' is not assigned and could be declared final | 429 |
| Parameter 'component' is not assigned and could be declared final | 434 |
| Parameter 'component' is not assigned and could be declared final | 438 |
| Parameter 'name' is not assigned and could be declared final | 438 |
| The method 'getBooleanAttribute' has a Cyclomatic Complexity of 5. | 438 - 460 |
| Parameter 'value' is not assigned and could be declared final | 464 |
| Parameter 'styleClasses' is not assigned and could be declared final | 473 |
| Parameter 'component' is not assigned and could be declared final | 473 |
| The method 'setStyleClasses' has a Cyclomatic Complexity of 5. | 473 - 487 |
| Local variable 'classes' could be declared final | 478 |
| Local variable 'styles' could be declared final | 480 |
| Parameter 'markup' is not assigned and could be declared final | 493 |
| Parameter 'markupComponent' is not assigned and could be declared final | 493 |
| Parameter 'component' is not assigned and could be declared final | 507 |
| Parameter 'name' is not assigned and could be declared final | 507 |
| Parameter 'component' is not assigned and could be declared final | 515 |
| Parameter 'name' is not assigned and could be declared final | 515 |
| Parameter 'component' is not assigned and could be declared final | 519 |
| Parameter 'name' is not assigned and could be declared final | 519 |
| Parameter 'component' is not assigned and could be declared final | 523 |
| Parameter 'name' is not assigned and could be declared final | 523 |
| Parameter 'component' is not assigned and could be declared final | 527 |
| Parameter 'name' is not assigned and could be declared final | 527 |
| The method 'getIntAttribute' has a Cyclomatic Complexity of 5. | 527 - 546 |
| Parameter 'defaultValue' is not assigned and could be declared final | 528 |
| Local variable 'integer' could be declared final | 529 |
| Parameter 'component' is not assigned and could be declared final | 548 |
| Parameter 'name' is not assigned and could be declared final | 548 |
| The method 'getCharacterAttribute' has a Cyclomatic Complexity of 5. | 548 - 562 |
| Local variable 'character' could be declared final | 549 |
| Local variable 'asString' could be declared final | 555 |
| Assigning an Object to null is a code smell. Consider refactoring. | 556 |
| Parameter 'component' is not assigned and could be declared final | 564 |
| Parameter 'parent' is not assigned and could be declared final | 564 |
| Local variable 'facet' could be declared final | 566 |
| Parameter 'component' is not assigned and could be declared final | 574 |
| Parameter 'facesContext' is not assigned and could be declared final | 574 |
| Parameter 'rendererType' is not assigned and could be declared final | 578 |
| Parameter 'facesContext' is not assigned and could be declared final | 578 |
| Parameter 'family' is not assigned and could be declared final | 578 |
| Local variable 'requestMap' could be declared final | 583 |
| Local variable 'key' could be declared final | 584 |
| Local variable 'myRenderer' could be declared final | 589 |
| Parameter 'rendererType' is not assigned and could be declared final | 601 |
| Parameter 'facesContext' is not assigned and could be declared final | 601 |
| Parameter 'family' is not assigned and could be declared final | 601 |
| Local variable 'rkFactory' could be declared final | 602 |
| Local variable 'renderKit' could be declared final | 603 |
| Local variable 'myRenderer' could be declared final | 604 |
| Consider simply returning the value vs storing it in local variable 'myRenderer' | 605 |
| Parameter 'component' is not assigned and could be declared final | 608 |
| Parameter 'name' is not assigned and could be declared final | 608 |
| The method 'findParameter' has a Cyclomatic Complexity of 5. | 608 - 622 |
| Local variable 'parameter' could be declared final | 611 |
| Parameter 'type' is not assigned and could be declared final | 624 |
| Local variable 'clazz' could be declared final | 631 |
| Parameter 'component' is not assigned and could be declared final | 641 |
| Parameter 'component' is not assigned and could be declared final | 652 |
| Parameter 'component' is not assigned and could be declared final | 656 |
| Avoid reassigning parameters such as 'value' | 669 |
| Parameter 'component' is not assigned and could be declared final | 669 |
| Parameter 'name' is not assigned and could be declared final | 669 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 675 |
| Avoid reassigning parameters such as 'value' | 680 |
| Parameter 'name' is not assigned and could be declared final | 687 |
| Parameter 'value' is not assigned and could be declared final | 687 |
| Local variable 'context' could be declared final | 688 |
| Local variable 'valueBinding' could be declared final | 689 |
| Parameter 'items' is not assigned and could be declared final | 694 |
| Parameter 'value' is not assigned and could be declared final | 694 |
| Parameter 'valueBinding' is not assigned and could be declared final | 703 |
| Parameter 'value' is not assigned and could be declared final | 707 |
| Parameter 'postfix' is not assigned and could be declared final | 720 |
| Parameter 'component' is not assigned and could be declared final | 720 |
| Parameter 'facesContext' is not assigned and could be declared final | 720 |
| Local variable 'id' could be declared final | 722 |
| Parameter 'component' is not assigned and could be declared final | 726 |
| Parameter 'facesContext' is not assigned and could be declared final | 726 |
| Local variable 'id' could be declared final | 727 |
| Parameter 'component' is not assigned and could be declared final | 740 |
| Parameter 'facesContext' is not assigned and could be declared final | 740 |
| The method 'provideLabel' has a Cyclomatic Complexity of 5. | 740 - 769 |
| Local variable 'application' could be declared final | 752 |
| Local variable 'idprefix' could be declared final | 755 |
| Parameter 'editableValueHolder' is not assigned and could be declared final | 775 |
| Parameter 'validator' is not assigned and could be declared final | 775 |
| These nested if statements could be combined | 777 - 781 |
| These nested if statements could be combined | 777 - 781 |
| Local variable 'methodBinding' could be declared final | 778 - 779 |
| Parameter 'converterId' is not assigned and could be declared final | 789 |
| Parameter 'valueHolder' is not assigned and could be declared final | 789 |
| The method 'setConverter' has a Cyclomatic Complexity of 5. | 789 - 803 |
| Local variable 'valueBinding' could be declared final | 794 |
| Local variable 'converter' could be declared final | 799 |
| Parameter 'component' is not assigned and could be declared final | 809 |
| Parameter 'action' is not assigned and could be declared final | 809 |
| Local variable 'binding' could be declared final | 814 |
| Parameter 'actionListener' is not assigned and could be declared final | 826 |
| Parameter 'command' is not assigned and could be declared final | 826 |
| Local variable 'binding' could be declared final | 831 - 832 |
| Parameter 'valueChangeListener' is not assigned and could be declared final | 845 |
| Parameter 'valueHolder' is not assigned and could be declared final | 845 |
| Local variable 'binding' could be declared final | 850 - 851 |
| Parameter 'component' is not assigned and could be declared final | 864 |
| Parameter 'name' is not assigned and could be declared final | 864 |
| Parameter 'state' is not assigned and could be declared final | 864 |
| Local variable 'valueBinding' could be declared final | 867 |
| Parameter 'component' is not assigned and could be declared final | 876 |
| Parameter 'facesContext' is not assigned and could be declared final | 876 |
| The method 'getMarkupBinding' has a Cyclomatic Complexity of 7. | 876 - 899 |
| Local variable 'vb' could be declared final | 877 |
| Local variable 'markups' could be declared final | 879 |
| Local variable 'strings' could be declared final | 883 |
| Local variable 'result' could be declared final | 884 |
| Parameter 'relativeId' is not assigned and could be declared final | 913 |
| Parameter 'from' is not assigned and could be declared final | 913 |
| Parameter 'renderers' is not assigned and could be declared final | 917 |
| The method 'getConvertedValue' has a Cyclomatic Complexity of 10. | 921 - 952 |
| The method 'getConvertedValue' has a Cyclomatic Complexity of 10. | 921 - 952 |
| Parameter 'component' is not assigned and could be declared final | 922 |
| Parameter 'facesContext' is not assigned and could be declared final | 922 |
| Parameter 'stringValue' is not assigned and could be declared final | 922 |
| Local variable 'renderer' could be declared final | 924 |
| Avoid if (x != y) ..; else ..; | 925 - 947 |
| Local variable 'vb' could be declared final | 936 |
| Local variable 'valueType' could be declared final | 938 |
| Avoid reassigning parameters such as 'markup' | 954 |
| Avoid reassigning parameters such as 'markup' | 954 |
| Avoid reassigning parameters such as 'markup' | 954 |
| Avoid reassigning parameters such as 'markup' | 954 |
| Avoid reassigning parameters such as 'markup' | 954 |
| Parameter 'component' is not assigned and could be declared final | 954 |
| The method 'updateMarkup' has a Cyclomatic Complexity of 6. | 954 - 975 |
| Local variable 'input' could be declared final | 965 |
| Parameter 'maximumSeverity' is not assigned and could be declared final | 977 |
| The method 'markupOfSeverity' has a Cyclomatic Complexity of 5. | 977 - 988 |
| Parameter 'markup' is not assigned and could be declared final | 990 |
| Parameter 'component' is not assigned and could be declared final | 990 |
| Parameter 'facesContext' is not assigned and could be declared final | 994 |
| Parameter 'container' is not assigned and could be declared final | 994 |
| Local variable 'clientId' could be declared final | 996 |
| Local variable 'ids' could be declared final | 997 |
| Local variable 'id' could be declared final | 998 |
| The method 'getMaximumSeverityOfChildrenMessages' has a Cyclomatic Complexity of 8. | 1007 - 1027 |
| Parameter 'facesContext' is not assigned and could be declared final | 1008 |
| Parameter 'container' is not assigned and could be declared final | 1008 |
| Local variable 'clientId' could be declared final | 1010 |
| Local variable 'ids' could be declared final | 1012 |
| Local variable 'id' could be declared final | 1013 |
| Local variable 'message' could be declared final | 1017 |
| Parameter 'facesContext' is not assigned and could be declared final | 1029 |
| Parameter 'container' is not assigned and could be declared final | 1029 |
| Local variable 'clientIds' could be declared final | 1031 |
| Local variable 'clientId' could be declared final | 1032 |
| Local variable 'ids' could be declared final | 1033 |
| Local variable 'id' could be declared final | 1034 |
| Parameter 'component' is not assigned and could be declared final | 1048 |
| Parameter 'name' is not assigned and could be declared final | 1048 |
| Parameter 'value' is not assigned and could be declared final | 1048 |
| Parameter 'component' is not assigned and could be declared final | 1060 |
| Parameter 'name' is not assigned and could be declared final | 1060 |
| Parameter 'value' is not assigned and could be declared final | 1060 |
| Parameter 'component' is not assigned and could be declared final | 1069 |
| The method 'invokeOnComponent' has a Cyclomatic Complexity of 7. | 1073 - 1098 |
| Parameter 'component' is not assigned and could be declared final | 1074 |
| Parameter 'context' is not assigned and could be declared final | 1074 |
| Parameter 'callback' is not assigned and could be declared final | 1074 |
| Parameter 'clientId' is not assigned and could be declared final | 1074 |
| Local variable 'thisClientId' could be declared final | 1075 |
| These nested if statements could be combined | 1087 - 1089 |
| These nested if statements could be combined | 1087 - 1089 |
| Parameter 'component' is not assigned and could be declared final | 1101 |
| Parameter 'context' is not assigned and could be declared final | 1101 |
| Parameter 'callback' is not assigned and could be declared final | 1101 |
| Parameter 'clientId' is not assigned and could be declared final | 1101 |
| Local variable 'it' could be declared final | 1102 |
| Local variable 'child' could be declared final | 1103 |
Tobago Core - org/apache/myfaces/tobago/util/CreateComponentUtils.java
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 41 - 168 |
| This class has too many methods, consider refactoring it. | 41 - 168 |
| Parameter 'rendererType' is not assigned and could be declared final | 44 |
| Parameter 'componentType' is not assigned and could be declared final | 44 |
| Parameter 'rendererType' is not assigned and could be declared final | 48 |
| Parameter 'componentType' is not assigned and could be declared final | 48 |
| Parameter 'clientId' is not assigned and could be declared final | 48 |
| Parameter 'rendererType' is not assigned and could be declared final | 54 |
| Parameter 'facesContext' is not assigned and could be declared final | 54 |
| Parameter 'componentType' is not assigned and could be declared final | 54 |
| Parameter 'rendererType' is not assigned and could be declared final | 59 |
| Parameter 'facesContext' is not assigned and could be declared final | 59 |
| Parameter 'componentType' is not assigned and could be declared final | 59 |
| Parameter 'clientId' is not assigned and could be declared final | 59 |
| Local variable 'component' could be declared final | 60 |
| Parameter 'sortable' is not assigned and could be declared final | 67 |
| Parameter 'align' is not assigned and could be declared final | 67 |
| Parameter 'value' is not assigned and could be declared final | 67 |
| Parameter 'label' is not assigned and could be declared final | 67 |
| Parameter 'sortable' is not assigned and could be declared final | 72 |
| Parameter 'align' is not assigned and could be declared final | 72 |
| Parameter 'value' is not assigned and could be declared final | 72 |
| Parameter 'label' is not assigned and could be declared final | 72 |
| Parameter 'clientId' is not assigned and could be declared final | 72 |
| Local variable 'text' could be declared final | 73 |
| Parameter 'child' is not assigned and could be declared final | 82 |
| Parameter 'sortable' is not assigned and could be declared final | 82 |
| Parameter 'align' is not assigned and could be declared final | 82 |
| Parameter 'label' is not assigned and could be declared final | 82 |
| Parameter 'child' is not assigned and could be declared final | 87 |
| Parameter 'sortable' is not assigned and could be declared final | 87 |
| Parameter 'align' is not assigned and could be declared final | 87 |
| Parameter 'label' is not assigned and could be declared final | 87 |
| Parameter 'clientId' is not assigned and could be declared final | 87 |
| Local variable 'column' could be declared final | 88 |
| Parameter 'sortable' is not assigned and could be declared final | 95 |
| Parameter 'align' is not assigned and could be declared final | 95 |
| Parameter 'label' is not assigned and could be declared final | 95 |
| Parameter 'sortable' is not assigned and could be declared final | 99 |
| Parameter 'align' is not assigned and could be declared final | 99 |
| Parameter 'label' is not assigned and could be declared final | 99 |
| Parameter 'clientId' is not assigned and could be declared final | 99 |
| Local variable 'column' could be declared final | 100 |
| Parameter 'facesContext' is not assigned and could be declared final | 108 |
| Parameter 'command' is not assigned and could be declared final | 109 |
| Parameter 'facesContext' is not assigned and could be declared final | 114 |
| Parameter 'command' is not assigned and could be declared final | 114 |
| Parameter 'clientId' is not assigned and could be declared final | 114 |
| Local variable 'radio' could be declared final | 116 - 117 |
| Avoid if (x != y) ..; else ..; | 121 - 125 |
| Parameter 'facesContext' is not assigned and could be declared final | 130 |
| Parameter 'command' is not assigned and could be declared final | 130 |
| Parameter 'facesContext' is not assigned and could be declared final | 134 |
| Parameter 'command' is not assigned and could be declared final | 135 |
| Parameter 'facesContext' is not assigned and could be declared final | 139 |
| Parameter 'command' is not assigned and could be declared final | 139 |
| Parameter 'clientId' is not assigned and could be declared final | 140 |
| Local variable 'checkbox' could be declared final | 141 - 142 |
| Local variable 'valueBinding' could be declared final | 145 |
| Avoid if (x != y) ..; else ..; | 146 - 151 |
| Parameter 'rendererType' is not assigned and could be declared final | 156 |
| Parameter 'facesContext' is not assigned and could be declared final | 156 |
| Parameter 'parent' is not assigned and could be declared final | 156 |
| Parameter 'componentType' is not assigned and could be declared final | 156 |
| Local variable 'layoutManager' could be declared final | 158 - 159 |
Tobago Core - org/apache/myfaces/tobago/util/DebugActionListener.java
| Violation | Line |
|---|---|
| Private field 'actionListener' could be made final; it is only initialized in the declaration or constructor. | 33 |
| Parameter 'actionListener' is not assigned and could be declared final | 36 |
| Parameter 'actionEvent' is not assigned and could be declared final | 40 |
Tobago Core - org/apache/myfaces/tobago/util/DebugNavigationHandler.java
| Violation | Line |
|---|---|
| The class 'DebugNavigationHandler' has a Cyclomatic Complexity of 4 (Highest = 5). | 29 - 57 |
| Private field 'navigationHandler' could be made final; it is only initialized in the declaration or constructor. | 33 |
| Parameter 'navigationHandler' is not assigned and could be declared final | 35 |
| Parameter 'fromAction' is not assigned and could be declared final | 39 |
| Parameter 'facesContext' is not assigned and could be declared final | 39 |
| Parameter 'outcome' is not assigned and could be declared final | 39 |
| The method 'handleNavigation' has a Cyclomatic Complexity of 5. | 39 - 56 |
Tobago Core - org/apache/myfaces/tobago/util/DebugPhaseListener.java
| Violation | Line |
|---|---|
| The class 'DebugPhaseListener' has a Cyclomatic Complexity of 8 (Highest = 14). | 38 - 144 |
| The class 'DebugPhaseListener' has a Cyclomatic Complexity of 8 (Highest = 14). | 38 - 144 |
| Parameter 'phaseEvent' is not assigned and could be declared final | 43 |
| The method 'afterPhase' has a Cyclomatic Complexity of 9. | 43 - 88 |
| Local variable 'end' could be declared final | 45 |
| Local variable 'facesContext' could be declared final | 46 |
| Local variable 'map' could be declared final | 47 |
| Local variable 'start' could be declared final | 56 - 57 |
| Deeply nested if..then statements are hard to read | 63 - 68 |
| Local variable 'response' could be declared final | 64 |
| Local variable 'start' could be declared final | 70 |
| Deeply nested if..then statements are hard to read | 71 - 74 |
| Local variable 'iter' could be declared final | 76 |
| Local variable 'clientId' could be declared final | 77 |
| Local variable 'msgIter' could be declared final | 79 |
| Local variable 'msg' could be declared final | 80 |
| Avoid instantiating new objects inside loops | 84 |
| Parameter 'phaseEvent' is not assigned and could be declared final | 91 |
| The method 'beforePhase' has a Cyclomatic Complexity of 14. | 91 - 139 |
| The method 'beforePhase' has a Cyclomatic Complexity of 14. | 91 - 139 |
| Local variable 'phaseId' could be declared final | 95 |
| Local variable 'externalContext' could be declared final | 98 |
| Deeply nested if..then statements are hard to read | 100 - 116 |
| Local variable 'request' could be declared final | 103 |
| Local variable 'servletRequest' could be declared final | 105 |
| Local variable 'headerMap' could be declared final | 108 |
| Local variable 'parameterMap' could be declared final | 112 |
| Deeply nested if..then statements are hard to read | 129 - 132 |
Tobago Core - org/apache/myfaces/tobago/util/DebugUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 32 - 103 |
| The class 'DebugUtils' has a Cyclomatic Complexity of 2 (Highest = 6). | 32 - 103 |
| Parameter 'component' is not assigned and could be declared final | 38 |
| Parameter 'offset' is not assigned and could be declared final | 38 |
| Parameter 'asFacet' is not assigned and could be declared final | 42 |
| Parameter 'component' is not assigned and could be declared final | 42 |
| Parameter 'offset' is not assigned and could be declared final | 42 |
| The method 'toString' has a Cyclomatic Complexity of 6. | 42 - 70 |
| Local variable 'result' could be declared final | 43 |
| Local variable 'facets' could be declared final | 52 |
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() | 53 |
| Local variable 'facet' could be declared final | 55 |
| Parameter 'component' is not assigned and could be declared final | 72 |
| Local variable 'buf' could be declared final | 73 |
| Parameter 'n' is not assigned and could be declared final | 89 |
| Local variable 'buffer' could be declared final | 90 |
| Parameter 'message' is not assigned and could be declared final | 97 |
| Parameter 'facesContext' is not assigned and could be declared final | 97 |
Tobago Core - org/apache/myfaces/tobago/util/EncodeAjaxCallback.java
| Violation | Line |
|---|---|
| The class 'EncodeAjaxCallback' has a Cyclomatic Complexity of 5 (Highest = 9). | 37 - 111 |
| Parameter 'component' is not assigned and could be declared final | 39 |
| Parameter 'facesContext' is not assigned and could be declared final | 39 |
| The method 'invokeContextCallback' has a Cyclomatic Complexity of 9. | 39 - 68 |
| Local variable 'reload' could be declared final | 41 |
| Local variable 'immediate' could be declared final | 43 |
| Local variable 'update' could be declared final | 45 |
| Deeply nested if..then statements are hard to read | 46 - 48 |
| Local variable 'layoutContainer' could be declared final | 53 |
| Local variable 'width' could be declared final | 54 |
| Local variable 'height' could be declared final | 55 |
| Local variable 'oldWidth' could be declared final | 56 |
| Local variable 'oldHeight' could be declared final | 57 |
| Parameter 'component' is not assigned and could be declared final | 76 |
| Parameter 'facesContext' is not assigned and could be declared final | 76 |
| Parameter 'component' is not assigned and could be declared final | 91 |
| Parameter 'facesContext' is not assigned and could be declared final | 91 |
| The method 'prepareRendererAll' has a Cyclomatic Complexity of 5. | 91 - 110 |
| Local variable 'renderer' could be declared final | 95 |
| Local variable 'it' could be declared final | 104 |
| Local variable 'child' could be declared final | 106 |
Tobago Core - org/apache/myfaces/tobago/util/FacesVersion.java
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 44 - 46 |
| Avoid empty catch blocks | 44 - 46 |
| Parameter 'className' is not assigned and could be declared final | 53 |
| Avoid empty catch blocks | 63 - 65 |
| Avoid empty catch blocks | 63 - 65 |
| Avoid empty catch blocks | 67 - 69 |
| Avoid empty catch blocks | 67 - 69 |
Tobago Core - org/apache/myfaces/tobago/util/FacetUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 30 - 56 |
| Parameter 'component' is not assigned and could be declared final | 38 |
| Parameter 'component' is not assigned and could be declared final | 42 |
| Parameter 'menu' is not assigned and could be declared final | 42 |
| Parameter 'component' is not assigned and could be declared final | 49 |
| Parameter 'component' is not assigned and could be declared final | 53 |
| Parameter 'menu' is not assigned and could be declared final | 53 |
Tobago Core - org/apache/myfaces/tobago/util/LayoutInfo.java
| Violation | Line |
|---|---|
| The class 'LayoutInfo' has a Cyclomatic Complexity of 4 (Highest = 13). | 39 - 388 |
| This class has too many methods, consider refactoring it. | 39 - 388 |
| The class 'LayoutInfo' has a Cyclomatic Complexity of 4 (Highest = 13). | 39 - 388 |
| Parameter 'layoutTokens' is not assigned and could be declared final | 52 |
| Parameter 'space' is not assigned and could be declared final | 52 |
| Parameter 'cellCount' is not assigned and could be declared final | 52 |
| Parameter 'clientIdForLogging' is not assigned and could be declared final | 52 |
| Parameter 'layoutTokens' is not assigned and could be declared final | 56 |
| Parameter 'space' is not assigned and could be declared final | 56 |
| Parameter 'cellCount' is not assigned and could be declared final | 56 |
| The constructor 'LayoutInfo' has a Cyclomatic Complexity of 6. | 56 - 94 |
| Parameter 'ignoreMismatch' is not assigned and could be declared final | 57 |
| Parameter 'clientIdForLogging' is not assigned and could be declared final | 57 |
| The String literal " clientId='" appears 17 times in this file; the first occurrence is on line 72 | 72 |
| Parameter 'initValue' is not assigned and could be declared final | 96 |
| Parameter 'columns' is not assigned and could be declared final | 96 |
| Parameter 'index' is not assigned and could be declared final | 103 |
| Parameter 'space' is not assigned and could be declared final | 103 |
| Avoid reassigning parameters such as 'space' | 107 |
| Avoid reassigning parameters such as 'space' | 107 |
| Parameter 'index' is not assigned and could be declared final | 107 |
| Parameter 'force' is not assigned and could be declared final | 107 |
| The method 'update' has a Cyclomatic Complexity of 10. | 107 - 142 |
| The method 'update' has a Cyclomatic Complexity of 10. | 107 - 142 |
| These nested if statements could be combined | 130 - 136 |
| These nested if statements could be combined | 130 - 136 |
| Parameter 'list' is not assigned and could be declared final | 162 |
| Parameter 'tokens' is not assigned and could be declared final | 170 |
| Parameter 'tokens' is not assigned and could be declared final | 178 |
| Local variable 'sb' could be declared final | 179 |
| Parameter 'column' is not assigned and could be declared final | 191 |
| Local variable 'list' could be declared final | 208 |
| The method 'handleSpaceLeft' has a Cyclomatic Complexity of 13. | 215 - 249 |
| The method handleSpaceLeft() has an NPath complexity of 330 | 215 - 249 |
| The method 'handleSpaceLeft' has a Cyclomatic Complexity of 13. | 215 - 249 |
| Parameter 'currentSpaces' is not assigned and could be declared final | 252 |
| Local variable 'sb' could be declared final | 253 |
| Parameter 'space' is not assigned and could be declared final | 262 |
| Parameter 'i' is not assigned and could be declared final | 262 |
| Parameter 'portions' is not assigned and could be declared final | 274 |
| The method 'parsePortions' has a Cyclomatic Complexity of 9. | 274 - 302 |
| These nested if statements could be combined | 278 - 300 |
| These nested if statements could be combined | 278 - 300 |
| Local variable 'widthForPortions' could be declared final | 279 |
| Local variable 'token' could be declared final | 281 |
| Local variable 'portion' could be declared final | 283 |
| Local variable 'w' could be declared final | 284 |
| The String literal " from " appears 5 times in this file; the first occurrence is on line 288 | 288 |
| The String literal "set column " appears 5 times in this file; the first occurrence is on line 288 | 288 |
| The String literal " to with " appears 4 times in this file; the first occurrence is on line 289 | 289 |
| Parameter 'space' is not assigned and could be declared final | 334 |
| Parameter 'space' is not assigned and could be declared final | 338 |
| Parameter 'padding' is not assigned and could be declared final | 338 |
| The method 'parseColumnLayout' has a Cyclomatic Complexity of 12. | 338 - 378 |
| The method 'parseColumnLayout' has a Cyclomatic Complexity of 12. | 338 - 378 |
| Local variable 'token' could be declared final | 343 |
| Local variable 'w' could be declared final | 352 |
| Local variable 'percent' could be declared final | 361 |
| Local variable 'w' could be declared final | 362 |
Tobago Core - org/apache/myfaces/tobago/util/LocaleUtils.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 29 - 97 |
| Parameter 'value' is not assigned and could be declared final | 34 |
| Local variable 'strings' could be declared final | 36 |
| Parameter 'locale' is not assigned and could be declared final | 57 |
| Local variable 'locales' could be declared final | 60 |
| Parameter 'locale' is not assigned and could be declared final | 76 |
| Local variable 'prefix' could be declared final | 83 |
| Local variable 'locales' could be declared final | 84 |
Tobago Core - org/apache/myfaces/tobago/util/MessageUtils.java
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 45 - 179 |
| The class 'MessageUtils' has a Cyclomatic Complexity of 4 (Highest = 15). | 45 - 179 |
| The class 'MessageUtils' has a Cyclomatic Complexity of 4 (Highest = 15). | 45 - 179 |
| Parameter 'component' is not assigned and could be declared final | 52 |
| Parameter 'facesContext' is not assigned and could be declared final | 52 |
| Parameter 'severity' is not assigned and could be declared final | 52 |
| Parameter 'args' is not assigned and could be declared final | 53 |
| Parameter 'messageId' is not assigned and could be declared final | 53 |
| The method 'getMessage' has a Cyclomatic Complexity of 15. | 58 - 105 |
| The method getMessage() has an NPath complexity of 468 | 58 - 105 |
| The method 'getMessage' has a Cyclomatic Complexity of 15. | 58 - 105 |
| Parameter 'facesContext' is not assigned and could be declared final | 59 |
| Parameter 'locale' is not assigned and could be declared final | 59 |
| Parameter 'args' is not assigned and could be declared final | 60 |
| Parameter 'severity' is not assigned and could be declared final | 60 |
| Parameter 'messageId' is not assigned and could be declared final | 60 |
| Local variable 'appBundle' could be declared final | 62 |
| Local variable 'tobagoBundle' could be declared final | 67 |
| Local variable 'defBundle' could be declared final | 76 |
| Deeply nested if..then statements are hard to read | 77 - 79 |
| Deeply nested if..then statements are hard to read | 80 - 82 |
| Parameter 'bundle' is not assigned and could be declared final | 107 |
| Parameter 'key' is not assigned and could be declared final | 107 |
| Parameter 'facesContext' is not assigned and could be declared final | 115 |
| Parameter 'locale' is not assigned and could be declared final | 115 |
| Local variable 'bundleName' could be declared final | 116 |
| Avoid if (x != y) ..; else ..; | 117 |
| Local variable 'clazz' could be declared final | 123 |
| Local variable 'bundle' could be declared final | 124 |
| The String literal "*********************************************************************************************" appears 6 times in this file; the first occurrence is on line 125 | 125 |
| Parameter 'facesContext' is not assigned and could be declared final | 139 |
| Parameter 'locale' is not assigned and could be declared final | 139 |
| Parameter 'facesContext' is not assigned and could be declared final | 143 |
| Parameter 'locale' is not assigned and could be declared final | 143 |
| Parameter 'bundleName' is not assigned and could be declared final | 143 |
| Parameter 'component' is not assigned and could be declared final | 156 |
| Parameter 'facesContext' is not assigned and could be declared final | 156 |
| Local variable 'label' could be declared final | 157 |
| Parameter 'message' is not assigned and could be declared final | 172 |
| Parameter 'args' is not assigned and could be declared final | 172 |
| Parameter 'locale' is not assigned and could be declared final | 172 |
| Local variable 'format' could be declared final | 174 |
Tobago Core - org/apache/myfaces/tobago/util/ProcessValidationsCallback.java
| Violation | Line |
|---|---|
| The class 'ProcessValidationsCallback' has a Cyclomatic Complexity of 5 (Highest = 4). | 28 - 41 |
| Parameter 'component' is not assigned and could be declared final | 30 |
| Parameter 'facesContext' is not assigned and could be declared final | 30 |
Tobago Core - org/apache/myfaces/tobago/util/RequestUtils.java
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 30 - 50 |
| The class 'RequestUtils' has a Cyclomatic Complexity of 6 (Highest = 5). | 30 - 50 |
| Parameter 'facesContext' is not assigned and could be declared final | 34 |
| The method 'ensureEncoding' has a Cyclomatic Complexity of 5. | 34 - 49 |
| Local variable 'requestObject' could be declared final | 35 |
| Local variable 'request' could be declared final | 38 |
| Do not add empty strings | 47 |
Tobago Core - org/apache/myfaces/tobago/util/UpdateModelValuesCallback.java
| Violation | Line |
|---|---|
| The class 'UpdateModelValuesCallback' has a Cyclomatic Complexity of 5 (Highest = 4). | 28 - 41 |
| Parameter 'component' is not assigned and could be declared final | 30 |
| Parameter 'facesContext' is not assigned and could be declared final | 30 |
Tobago Core - org/apache/myfaces/tobago/util/ValueBindingComparator.java
| Violation | Line |
|---|---|
| The class 'ValueBindingComparator' has a Cyclomatic Complexity of 3 (Highest = 11). | 34 - 132 |
| The class 'ValueBindingComparator' has a Cyclomatic Complexity of 3 (Highest = 11). | 34 - 132 |
| Private field 'facesContext' could be made final; it is only initialized in the declaration or constructor. | 38 |
| Private field 'var' could be made final; it is only initialized in the declaration or constructor. | 40 |
| Private field 'valueBinding' could be made final; it is only initialized in the declaration or constructor. | 42 |
| Parameter 'facesContext' is not assigned and could be declared final | 44 |
| Parameter 'var' is not assigned and could be declared final | 44 |
| Parameter 'valueBinding' is not assigned and could be declared final | 44 |
| Parameter 'reverse' is not assigned and could be declared final | 50 |
| Parameter 'facesContext' is not assigned and could be declared final | 50 |
| Parameter 'var' is not assigned and could be declared final | 50 |
| Parameter 'valueBinding' is not assigned and could be declared final | 50 |
| Parameter 'facesContext' is not assigned and could be declared final | 57 |
| Parameter 'var' is not assigned and could be declared final | 57 |
| Parameter 'comparator' is not assigned and could be declared final | 58 |
| Parameter 'valueBinding' is not assigned and could be declared final | 58 |
| Parameter 'facesContext' is not assigned and could be declared final | 65 |
| Parameter 'var' is not assigned and could be declared final | 65 |
| Parameter 'reverse' is not assigned and could be declared final | 66 |
| Parameter 'comparator' is not assigned and could be declared final | 66 |
| Parameter 'valueBinding' is not assigned and could be declared final | 66 |
| Parameter 'o' is not assigned and could be declared final | 73 |
| The method 'equals' has a Cyclomatic Complexity of 11. | 73 - 97 |
| The method 'equals' has a Cyclomatic Complexity of 11. | 73 - 97 |
| Avoid if (x != y) ..; else ..; | 86 |
| Avoid if (x != y) ..; else ..; | 89 |
| Avoid if (x != y) ..; else ..; | 92 |
| Avoid if (x != y) ..; else ..; | 101 |
| Avoid if (x != y) ..; else ..; | 102 |
| Avoid if (x != y) ..; else ..; | 103 |
| Parameter 'param1' is not assigned and could be declared final | 115 |
| Parameter 'param2' is not assigned and could be declared final | 115 |
Tobago Core - org/apache/myfaces/tobago/util/ValueExpressionComparator.java
| Violation | Line |
|---|---|
| The class 'ValueExpressionComparator' has a Cyclomatic Complexity of 3 (Highest = 11). | 30 - 128 |
| The class 'ValueExpressionComparator' has a Cyclomatic Complexity of 3 (Highest = 11). | 30 - 128 |
| Private field 'facesContext' could be made final; it is only initialized in the declaration or constructor. | 34 |
| Private field 'var' could be made final; it is only initialized in the declaration or constructor. | 36 |
| Private field 'valueExpression' could be made final; it is only initialized in the declaration or constructor. | 38 |
| Parameter 'valueExpression' is not assigned and could be declared final | 40 |
| Parameter 'facesContext' is not assigned and could be declared final | 40 |
| Parameter 'var' is not assigned and could be declared final | 40 |
| Parameter 'valueExpression' is not assigned and could be declared final | 46 |
| Parameter 'facesContext' is not assigned and could be declared final | 46 |
| Parameter 'var' is not assigned and could be declared final | 46 |
| Parameter 'reverse' is not assigned and could be declared final | 47 |
| Parameter 'facesContext' is not assigned and could be declared final | 54 |
| Parameter 'var' is not assigned and could be declared final | 54 |
| Parameter 'valueExpression' is not assigned and could be declared final | 55 |
| Parameter 'comparator' is not assigned and could be declared final | 55 |
| Parameter 'facesContext' is not assigned and could be declared final | 62 |
| Parameter 'var' is not assigned and could be declared final | 62 |
| Parameter 'reverse' is not assigned and could be declared final | 63 |
| Parameter 'valueExpression' is not assigned and could be declared final | 63 |
| Parameter 'comparator' is not assigned and could be declared final | 63 |
| Parameter 'o' is not assigned and could be declared final | 70 |
| The method 'equals' has a Cyclomatic Complexity of 11. | 70 - 94 |
| The method 'equals' has a Cyclomatic Complexity of 11. | 70 - 94 |
| Avoid if (x != y) ..; else ..; | 83 |
| Avoid if (x != y) ..; else ..; | 86 |
| Avoid if (x != y) ..; else ..; | 89 |
| Avoid if (x != y) ..; else ..; | 98 |
| Avoid if (x != y) ..; else ..; | 99 |
| Avoid if (x != y) ..; else ..; | 100 |
| Parameter 'param1' is not assigned and could be declared final | 112 |
| Parameter 'param2' is not assigned and could be declared final | 112 |
Tobago Core - org/apache/myfaces/tobago/util/VariableResolverUtils.java
| Violation | Line |
|---|---|
| Parameter 'context' is not assigned and could be declared final | 36 |
| Parameter 'variable' is not assigned and could be declared final | 36 |
| Parameter 'facesContext' is not assigned and could be declared final | 44 |
| Parameter 'context' is not assigned and could be declared final | 54 |
| Parameter 'variable' is not assigned and could be declared final | 54 |
Tobago Core - org/apache/myfaces/tobago/util/XmlUtils.java
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 38 - 165 |
| The class 'XmlUtils' has a Cyclomatic Complexity of 4 (Highest = 8). | 38 - 165 |
| Local variable 'len' could be declared final | 48 |
| Local variable 'buffer' could be declared final | 49 |
| Local variable 'buffer' could be declared final | 60 |
| The method 'appendEntityRef' has a Cyclomatic Complexity of 8. | 67 - 98 |
| Local variable 'propertiesElement' could be declared final | 110 - 111 |
| Local variable 'factory' could be declared final | 117 |
| Local variable 'builder' could be declared final | 123 |
| Local variable 'source' could be declared final | 125 |
| The method 'importProperties' has a Cyclomatic Complexity of 6. | 132 - 148 |
| Local variable 'entries' could be declared final | 133 |
| Local variable 'numEntries' could be declared final | 134 |
| Local variable 'start' could be declared final | 135 - 136 |
| Local variable 'child' could be declared final | 138 |
| Local variable 'entry' could be declared final | 140 |
| Local variable 'node' could be declared final | 142 |
| Local variable 'value' could be declared final | 143 |
| Local variable 'dtd' could be declared final | 154 - 158 |
| Local variable 'inputSource' could be declared final | 159 |
Tobago Core - org/apache/myfaces/tobago/validator/ClearValidatorsActionListener.java
| Violation | Line |
|---|---|
| The class 'ClearValidatorsActionListener' has a Cyclomatic Complexity of 5 (Highest = 8). | 34 - 83 |
| Parameter 'actionEvent' is not assigned and could be declared final | 42 |
| The method 'processAction' has a Cyclomatic Complexity of 8. | 42 - 81 |
| Local variable 'source' could be declared final | 46 |
| Local variable 'clearValidatorsFieldIds' could be declared final | 47 - 48 |
| Local variable 'tokenizer' could be declared final | 56 - 57 |
| Local variable 'clearValidatorsFieldId' could be declared final | 59 |
| Local variable 'facesContext' could be declared final | 70 |
Tobago Core - org/apache/myfaces/tobago/validator/FileItemValidator.java
| Violation | Line |
|---|---|
| The class 'FileItemValidator' has a Cyclomatic Complexity of 2 (Highest = 12). | 40 - 126 |
| The class 'FileItemValidator' has a Cyclomatic Complexity of 2 (Highest = 12). | 40 - 126 |
| Document empty constructor | 51 - 52 |
| Avoid unnecessary constructors - the compiler will generate these for you | 51 - 52 |
| Parameter 'component' is not assigned and could be declared final | 54 |
| Parameter 'facesContext' is not assigned and could be declared final | 54 |
| Parameter 'value' is not assigned and could be declared final | 54 |
| The method 'validate' has a Cyclomatic Complexity of 12. | 54 - 86 |
| The method 'validate' has a Cyclomatic Complexity of 12. | 54 - 86 |
| Local variable 'file' could be declared final | 56 |
| Local variable 'facesMessage' could be declared final | 58 - 60 |
| Deeply nested if..then statements are hard to read | 67 - 70 |
| Deeply nested if..then statements are hard to read | 74 - 78 |
| Local variable 'facesMessage' could be declared final | 79 - 81 |
| Parameter 'maxSize' is not assigned and could be declared final | 92 |
| Parameter 'contentType' is not assigned and could be declared final | 102 |
| Parameter 'context' is not assigned and could be declared final | 106 |
| Parameter 'context' is not assigned and could be declared final | 113 |
| Parameter 'state' is not assigned and could be declared final | 113 |
| Local variable 'values' could be declared final | 114 |
| Parameter 'newTransientValue' is not assigned and could be declared final | 123 |
Tobago Core - org/apache/myfaces/tobago/validator/SubmittedValueLengthValidator.java
| Violation | Line |
|---|---|
| The class 'SubmittedValueLengthValidator' has a Cyclomatic Complexity of 3 (Highest = 9). | 38 - 136 |
| Document empty constructor | 44 - 45 |
| Parameter 'maximum' is not assigned and could be declared final | 47 |
| Overridable method 'setMaximum' called during object construction | 48 |
| Parameter 'minimum' is not assigned and could be declared final | 51 |
| Parameter 'maximum' is not assigned and could be declared final | 51 |
| Overridable method 'setMaximum' called during object construction | 52 |
| Overridable method 'setMinimum' called during object construction | 53 |
| Avoid if (x != y) ..; else ..; | 57 |
| Parameter 'minimum' is not assigned and could be declared final | 60 |
| Avoid if (x != y) ..; else ..; | 67 |
| Parameter 'maximum' is not assigned and could be declared final | 70 |
| Parameter 'facesContext' is not assigned and could be declared final | 76 |
| Parameter 'value' is not assigned and could be declared final | 76 |
| Parameter 'uiComponent' is not assigned and could be declared final | 76 |
| The method 'validate' has a Cyclomatic Complexity of 7. | 76 - 92 |
| Local variable 'submittedValue' could be declared final | 78 |
| Local variable 'args' could be declared final | 80 |
| Local variable 'facesMessage' could be declared final | 81 - 82 |
| Local variable 'args' could be declared final | 86 |
| Local variable 'facesMessage' could be declared final | 87 - 88 |
| Parameter 'context' is not assigned and could be declared final | 94 |
| Parameter 'context' is not assigned and could be declared final | 101 |
| Parameter 'state' is not assigned and could be declared final | 101 |
| Local variable 'values' could be declared final | 102 |
| Parameter 'o' is not assigned and could be declared final | 107 |
| The method 'equals' has a Cyclomatic Complexity of 9. | 107 - 128 |
| Local variable 'validator' could be declared final | 118 |
| Avoid if (x != y) ..; else ..; | 120 |
| Avoid if (x != y) ..; else ..; | 123 |
| Avoid if (x != y) ..; else ..; | 132 |
| Avoid if (x != y) ..; else ..; | 133 |
Tobago Core - org/apache/myfaces/tobago/webapp/LogoutActionListener.java
| Violation | Line |
|---|---|
| The class 'LogoutActionListener' has a Cyclomatic Complexity of 5 (Highest = 4). | 34 - 59 |
| Parameter 'event' is not assigned and could be declared final | 38 |
| Local variable 'facesContext' could be declared final | 39 |
| Local variable 'externalContext' could be declared final | 40 |
| Local variable 'session' could be declared final | 41 |
| These nested if statements could be combined | 43 - 45 |
| These nested if statements could be combined | 43 - 45 |
| Local variable 'forward' could be declared final | 48 |
| New exception is thrown in catch block, original stack trace may be lost | 54 |
Tobago Core - org/apache/myfaces/tobago/webapp/Secret.java
| Violation | Line |
|---|---|
| A class which only has private constructors should be final | 34 - 108 |
| Private field 'secret' could be made final; it is only initialized in the declaration or constructor. | 55 |
| Local variable 'bytes' could be declared final | 58 |
| Parameter 'bytes' is not assigned and could be declared final | 63 |
| Parameter 'bytes' is not assigned and could be declared final | 67 |
| Local variable 'builder' could be declared final | 68 |
| Parameter 'facesContext' is not assigned and could be declared final | 79 |
| Local variable 'requestParameterMap' could be declared final | 80 |
| Local variable 'fromRequest' could be declared final | 81 |
| Local variable 'sessionMap' could be declared final | 82 |
| Local variable 'secret' could be declared final | 83 |
| Parameter 'facesContext' is not assigned and could be declared final | 90 |
| Parameter 'writer' is not assigned and could be declared final | 90 |
| Local variable 'sessionMap' could be declared final | 95 |
| Local variable 'secret' could be declared final | 96 |
| Parameter 'session' is not assigned and could be declared final | 105 |
Tobago Core - org/apache/myfaces/tobago/webapp/SecretSessionListener.java
| Violation | Line |
|---|---|
| Parameter 'sessionEvent' is not assigned and could be declared final | 29 |
| Document empty method | 36 - 37 |
| Parameter 'se' is not assigned and could be declared final | 36 |
Tobago Core - org/apache/myfaces/tobago/webapp/TobagoMultipartFormdataFilter.java
| Violation | Line |
|---|---|
| The class 'TobagoMultipartFormdataFilter' has a Cyclomatic Complexity of 4 (Highest = 6). | 69 - 130 |
| Parameter 'filterConfig' is not assigned and could be declared final | 76 |
| The method 'init' has a Cyclomatic Complexity of 5. | 76 - 96 |
| Local variable 'repositoryPath' could be declared final | 77 |
| Local variable 'file' could be declared final | 79 |
| Avoid if (x != y) ..; else ..; | 80 - 86 |
| Avoid if (x != y) ..; else ..; | 82 - 86 |
| Parameter 'response' is not assigned and could be declared final | 98 |
| Parameter 'chain' is not assigned and could be declared final | 98 |
| Parameter 'request' is not assigned and could be declared final | 98 |
| The method 'doFilter' has a Cyclomatic Complexity of 6. | 98 - 125 |
| Local variable 'contentType' could be declared final | 105 |
| Document empty method | 127 - 128 |
Tobago Core - org/apache/myfaces/tobago/webapp/TobagoResponseWriter.java
| Violation | Line |
|---|---|
| The class 'TobagoResponseWriter' has a Cyclomatic Complexity of 1 (Highest = 5). | 41 - 281 |
| This class has too many methods, consider refactoring it. | 41 - 281 |
| Parameter 'name' is not assigned and could be declared final | 52 |
| Parameter 'name' is not assigned and could be declared final | 93 |
| Parameter 'on' is not assigned and could be declared final | 93 |
| Parameter 'name' is not assigned and could be declared final | 102 |
| Parameter 'number' is not assigned and could be declared final | 102 |
| Parameter 'name' is not assigned and could be declared final | 109 |
| Parameter 'property' is not assigned and could be declared final | 109 |
| Parameter 'id' is not assigned and could be declared final | 116 |
| Parameter 'name' is not assigned and could be declared final | 123 |
| Parameter 'cssClass' is not assigned and could be declared final | 132 |
| Parameter 'styleClasses' is not assigned and could be declared final | 141 |
| Parameter 'classes' is not assigned and could be declared final | 153 |
| Local variable 'styleClasses' could be declared final | 154 |
| Prefer StringBuffer over += for concatenating strings | 157 |
| Parameter 'style' is not assigned and could be declared final | 189 |
| The method 'writeStyleAttribute' has a Cyclomatic Complexity of 5. | 189 - 222 |
| Parameter 'style' is not assigned and could be declared final | 229 |
| Parameter 'script' is not assigned and could be declared final | 233 |
| Parameter 'text' is not assigned and could be declared final | 254 |
| Parameter 'property' is not assigned and could be declared final | 261 |
| Local variable 'builder' could be declared final | 275 |
Tobago Core - org/apache/myfaces/tobago/webapp/TobagoServletContextListener.java
| Violation | Line |
|---|---|
| Parameter 'event' is not assigned and could be declared final | 36 |
| Local variable 'servletContext' could be declared final | 42 |
| Parameter 'event' is not assigned and could be declared final | 55 |
| Local variable 'servletContext' could be declared final | 61 |
Tobago Core - org/apache/myfaces/tobago/webapp/WeblogicWorkaroundServlet.java
| Violation | Line |
|---|---|
| The class 'WeblogicWorkaroundServlet' has a Cyclomatic Complexity of 6 (Highest = 8). | 41 - 94 |
| The method 'init' has a Cyclomatic Complexity of 8. | 47 - 79 |
| Local variable 'factory' could be declared final | 51 - 52 |
| Local variable 'tobagoConfig' could be declared final | 65 - 66 |
| Parameter 'className' is not assigned and could be declared final | 81 |
| Local variable 'aClass' could be declared final | 83 |
| Local variable 'listener' could be declared final | 84 |
Tobago Deprecation - org/apache/myfaces/tobago/ajax/api/AjaxUtils.java
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 36 - 155 |
| This class has too many methods, consider refactoring it. | 36 - 155 |
| Parameter 'facesContext' is not assigned and could be declared final | 48 |
| Parameter 'compClass' is not assigned and could be declared final | 48 |
| Parameter 'uiComponent' is not assigned and could be declared final | 48 |
| Parameter 'component' is not assigned and could be declared final | 56 |
| Parameter 'facesContext' is not assigned and could be declared final | 56 |
| Parameter 'facesContext' is not assigned and could be declared final | 64 |
| Parameter 'facesContext' is not assigned and could be declared final | 72 |
| Parameter 'facesContext' is not assigned and could be declared final | 80 |
| Parameter 'facesContext' is not assigned and could be declared final | 88 |
| Parameter 'clientId' is not assigned and could be declared final | 88 |
| Parameter 'facesContext' is not assigned and could be declared final | 96 |
| Parameter 'clientId' is not assigned and could be declared final | 96 |
| Parameter 'component' is not assigned and could be declared final | 104 |
| Parameter 'facesContext' is not assigned and could be declared final | 104 |
| Parameter 'facesContext' is not assigned and could be declared final | 112 |
| Parameter 'clientId' is not assigned and could be declared final | 112 |
| Parameter 'component' is not assigned and could be declared final | 120 |
| Parameter 'facesContext' is not assigned and could be declared final | 120 |
| Parameter 'value' is not assigned and could be declared final | 128 |
| Parameter 'facesContext' is not assigned and could be declared final | 136 |
| Parameter 'url' is not assigned and could be declared final | 136 |
| Parameter 'response' is not assigned and could be declared final | 144 |
| Parameter 'url' is not assigned and could be declared final | 144 |
| Parameter 'context' is not assigned and could be declared final | 152 |
Tobago Deprecation - org/apache/myfaces/tobago/bean/ResourceMap.java
| Violation | Line |
|---|---|
| The class 'ResourceMap' has a Cyclomatic Complexity of 4 (Highest = 6). | 33 - 90 |
| Parameter 'filename' is not assigned and could be declared final | 44 |
| The method 'setFilename' has a Cyclomatic Complexity of 6. | 44 - 63 |
| Local variable 'is' could be declared final | 49 |
| Parameter 'value' is not assigned and could be declared final | 69 |
| Parameter 'key' is not assigned and could be declared final | 69 |
| Parameter 'key' is not assigned and could be declared final | 80 |
| Local variable 'value' could be declared final | 81 |
Tobago Deprecation - org/apache/myfaces/tobago/component/ComponentUtil.java
| Violation | Line |
|---|---|
| This class has a bunch of public methods and attributes | 20 - 421 |
| A class which only has private constructors should be final | 56 - 421 |
| This class has too many methods, consider refactoring it. | 56 - 421 |
| Parameter 'context' is not assigned and could be declared final | 66 |
| Parameter 'command' is not assigned and could be declared final | 70 |
| Parameter 'component' is not assigned and could be declared final | 74 |
| Parameter 'facesContext' is not assigned and could be declared final | 74 |
| Parameter 'component' is not assigned and could be declared final | 78 |
| Parameter 'context' is not assigned and could be declared final | 82 |
| Parameter 'component' is not assigned and could be declared final | 86 |
| Parameter 'context' is not assigned and could be declared final | 86 |
| Parameter 'component' is not assigned and could be declared final | 90 |
| Parameter 'component' is not assigned and could be declared final | 94 |
| Parameter 'styles' is not assigned and could be declared final | 94 |
| Parameter 'scripts' is not assigned and could be declared final | 98 |
| Parameter 'component' is not assigned and could be declared final | 98 |
| Parameter 'cmds' is not assigned and could be declared final | 102 |
| Parameter 'component' is not assigned and could be declared final | 102 |
| Parameter 'facesContext' is not assigned and could be declared final | 106 |
| Parameter 'component' is not assigned and could be declared final | 110 |
| Parameter 'component' is not assigned and could be declared final | 114 |
| Parameter 'component' is not assigned and could be declared final | 118 |
| Parameter 'type' is not assigned and could be declared final | 118 |
| Parameter 'component' is not assigned and could be declared final | 122 |
| Parameter 'facesContext' is not assigned and could be declared final | 122 |
| Parameter 'component' is not assigned and could be declared final | 126 |
| Parameter 'component' is not assigned and could be declared final | 130 |
| Parameter 'uiInput' is not assigned and could be declared final | 134 |
| Parameter 'component' is not assigned and could be declared final | 138 |
| Parameter 'component' is not assigned and could be declared final | 142 |
| Parameter 'component' is not assigned and could be declared final | 146 |
| Parameter 'component' is not assigned and could be declared final | 150 |
| Parameter 'component' is not assigned and could be declared final | 154 |
| Parameter 'name' is not assigned and could be declared final | 154 |
| Parameter 'renderers' is not assigned and could be declared final | 158 |
| Parameter 'command' is not assigned and could be declared final | 158 |
| Parameter 'styleClasses' is not assigned and could be declared final | 162 |
| Parameter 'component' is not assigned and could be declared final | 162 |
| Parameter 'markup' is not assigned and could be declared final | 166 |
| Parameter 'markupComponent' is not assigned and could be declared final | 166 |
| Parameter 'component' is not assigned and could be declared final | 170 |
| Parameter 'name' is not assigned and could be declared final | 170 |
| Parameter 'component' is not assigned and could be declared final | 174 |
| Parameter 'name' is not assigned and could be declared final | 174 |
| Parameter 'component' is not assigned and could be dec |