PMD Results

The following document contains the results of PMD 5.2.3.

Files

Tobago Core - org/apache/myfaces/tobago/application/ActionListenerImpl.java

Violation Line
Private field 'base' could be made final; it is only initialized in the declaration or constructor. 45
An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 57
Local variable 'errorLogMsg' could be declared final 67
Avoid if (x != y) ..; else ..; 6874
Avoid if (x != y) ..; else ..; 82

Tobago Core - org/apache/myfaces/tobago/compat/FacesUtilsEL.java

Violation Line
This class has too many methods, consider refactoring it. 48268
These nested if statements could be combined 7274
Avoid if (x != y) ..; else ..; 206
Avoid if (x != y) ..; else ..; 216221

Tobago Core - org/apache/myfaces/tobago/component/Facets.java

Violation Line
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 55

Tobago Core - org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.java

Violation Line
This class has too many methods, consider refactoring it. 37231
Document empty constructor 4748
Consider using varargs for methods or constructors which take an array the last parameter. 93

Tobago Core - org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.java

Violation Line
Avoid using redundant field initializer for 'isTransient' 38
Unnecessary use of fully qualified name 'javax.faces.el.MethodNotFoundException' due to existing import 'javax.faces.el.MethodNotFoundException' 62
Consider using varargs for methods or constructors which take an array the last parameter. 68
Unnecessary use of fully qualified name 'javax.faces.el.MethodNotFoundException' due to existing import 'javax.faces.el.MethodNotFoundException' 74

Tobago Core - org/apache/myfaces/tobago/component/Sorter.java

Violation Line
Possible God class (WMC=51, ATFD=25, TCC=0.2) 20259
The class 'Sorter' has a Modified Cyclomatic Complexity of 6 (Highest = 28). 49258
The class 'Sorter' has a Cyclomatic Complexity of 8 (Highest = 30). 49258
The class 'Sorter' has a Standard Cyclomatic Complexity of 6 (Highest = 28). 49258
The method 'perform' has a Standard Cyclomatic Complexity of 28. 64201
The method 'perform' has a Cyclomatic Complexity of 30. 64201
Avoid really long methods. 64201
The method perform() has an NPath complexity of 139872 64201
The method 'perform' has a Modified Cyclomatic Complexity of 28. 64201
Avoid if (x != y) ..; else ..; 96137
Avoid if (x != y) ..; else ..; 99132
Avoid if (x != y) ..; else ..; 199
The method 'getFirstSortableChild' has a Cyclomatic Complexity of 13. 224249

Tobago Core - org/apache/myfaces/tobago/component/SupportsRenderedPartially.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 27

Tobago Core - org/apache/myfaces/tobago/context/ClientProperties.java

Violation Line
Use equals() to compare object references. 204

Tobago Core - org/apache/myfaces/tobago/context/Markup.java

Violation Line
This class has too many methods, consider refactoring it. 50317
Consider using varargs for methods or constructors which take an array the last parameter. 96
Consider using varargs for methods or constructors which take an array the last parameter. 106
Avoid if (x != y) ..; else ..; 166
Avoid if (x != y) ..; else ..; 178
Avoid if (x != y) ..; else ..; 179
Use equals() to compare object references. 201
Avoid if (x != y) ..; else ..; 204215
Avoid if (x != y) ..; else ..; 245254

Tobago Core - org/apache/myfaces/tobago/context/MarkupConfig.java

Violation Line
Private field 'markups' could be made final; it is only initialized in the declaration or constructor. 30

Tobago Core - org/apache/myfaces/tobago/context/ResourceManagerUtils.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 154
Consider using varargs for methods or constructors which take an array the last parameter. 166
This call to String.startsWith can be rewritten using String.charAt(0) 233
Local variable 'dot' could be declared final 243
Local variable 'slash' could be declared final 247

Tobago Core - org/apache/myfaces/tobago/context/ThemeImpl.java

Violation Line
Possible God class (WMC=51, ATFD=16, TCC=0.06436781609195402) 20276
Too many fields 33276
Private field 'productionResources' could be made final; it is only initialized in the declaration or constructor. 46
Private field 'resources' could be made final; it is only initialized in the declaration or constructor. 47
Avoid using redundant field initializer for 'unmodifiable' 55
Deeply nested if..then statements are hard to read 151156
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 180
Avoid appending characters as strings in StringBuffer.append. 183
Avoid appending characters as strings in StringBuffer.append. 186

Tobago Core - org/apache/myfaces/tobago/context/ThemeResource.java

Violation Line
Avoid if (x != y) ..; else ..; 50
Avoid if (x != y) ..; else ..; 56

Tobago Core - org/apache/myfaces/tobago/context/ThemeResources.java

Violation Line
Private field 'scriptList' could be made final; it is only initialized in the declaration or constructor. 34
Private field 'styleList' could be made final; it is only initialized in the declaration or constructor. 35

Tobago Core - org/apache/myfaces/tobago/context/TobagoBundle.java

Violation Line
Private field 'bundleName' could be made final; it is only initialized in the declaration or constructor. 41

Tobago Core - org/apache/myfaces/tobago/context/TransientStateHolder.java

Violation Line
Document empty constructor 3334

Tobago Core - org/apache/myfaces/tobago/context/UserAgent.java

Violation Line
The class 'UserAgent' has a Standard Cyclomatic Complexity of 3 (Highest = 19). 33386
The class 'UserAgent' has a Cyclomatic Complexity of 3 (Highest = 20). 33386
The class 'UserAgent' has a Modified Cyclomatic Complexity of 3 (Highest = 19). 33386
The String literal "msie" appears 12 times in this file; the first occurrence is on line 43 43
The String literal "opera" appears 4 times in this file; the first occurrence is on line 107 107
The String literal "mozilla" appears 4 times in this file; the first occurrence is on line 131 131
The String literal "gecko" appears 5 times in this file; the first occurrence is on line 154 154
The method 'getInstance' has a Standard Cyclomatic Complexity of 19. 275330
The method 'getInstance' has a Modified Cyclomatic Complexity of 19. 275330
The method 'getInstance' has a Cyclomatic Complexity of 20. 275330
Avoid if (x != y) ..; else ..; 346348
Consider using varargs for methods or constructors which take an array the last parameter. 360
Consider using varargs for methods or constructors which take an array the last parameter. 378

Tobago Core - org/apache/myfaces/tobago/convert/DurationConverter.java

Violation Line
The class 'DurationConverter' has a Cyclomatic Complexity of 8 (Highest = 10). 37150
The class 'DurationConverter' has a Standard Cyclomatic Complexity of 8 (Highest = 10). 37150
The class 'DurationConverter' has a Modified Cyclomatic Complexity of 7 (Highest = 10). 37150
Unnecessary wrapper object creation 67
Avoid declaring a variable if it is unreferenced before a possible exit point. 90
The method 'getUnitFactor' has a Standard Cyclomatic Complexity of 10. 121148
The method 'getUnitFactor' has a Modified Cyclomatic Complexity of 10. 121148
The method 'getUnitFactor' has a Cyclomatic Complexity of 10. 121148

Tobago Core - org/apache/myfaces/tobago/el/ConstantMethodBinding.java

Violation Line
Document empty constructor 3839
Consider using varargs for methods or constructors which take an array the last parameter. 41

Tobago Core - org/apache/myfaces/tobago/el/UserWrapper.java

Violation Line
Private field 'roles' could be made final; it is only initialized in the declaration or constructor. 35

Tobago Core - org/apache/myfaces/tobago/event/FacesEventWrapper.java

Violation Line
Private field 'wrappedFacesEvent' could be made final; it is only initialized in the declaration or constructor. 31

Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionStateChangeListener.java

Violation Line
Avoid using redundant field initializer for 'isTransient' 33
Document empty constructor 3536

Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTabChangeListener.java

Violation Line
Avoid using redundant field initializer for 'isTransient' 33
Document empty constructor 3536

Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.java

Violation Line
Avoid using redundant field initializer for 'isTransient' 34
Document empty constructor 3637
Avoid unused private methods such as 'elContext()'. 47

Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTreeMarkedListener.java

Violation Line
Avoid using redundant field initializer for 'isTransient' 37
Document empty constructor 3940
Avoid unused private methods such as 'elContext()'. 50

Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.java

Violation Line
Avoid using redundant field initializer for 'isTransient' 33
Document empty constructor 3536
Avoid unused private methods such as 'elContext()'. 46

Tobago Core - org/apache/myfaces/tobago/event/PageAction.java

Violation Line
Avoid if (x != y) ..; else ..; 8589

Tobago Core - org/apache/myfaces/tobago/event/PageActionEvent.java

Violation Line
Private field 'action' could be made final; it is only initialized in the declaration or constructor. 31

Tobago Core - org/apache/myfaces/tobago/event/PopupActionListener.java

Violation Line
Document empty constructor 3738

Tobago Core - org/apache/myfaces/tobago/event/PopupFacetActionListener.java

Violation Line
Avoid if (x != y) ..; else ..; 4046

Tobago Core - org/apache/myfaces/tobago/event/ResetInputActionListener.java

Violation Line
Document empty constructor 3435
Consider using varargs for methods or constructors which take an array the last parameter. 37

Tobago Core - org/apache/myfaces/tobago/event/SortActionEvent.java

Violation Line
Private field 'column' could be made final; it is only initialized in the declaration or constructor. 31

Tobago Core - org/apache/myfaces/tobago/event/TreeExpansionEvent.java

Violation Line
Private field 'oldExpanded' could be made final; it is only initialized in the declaration or constructor. 30
Private field 'newExpanded' could be made final; it is only initialized in the declaration or constructor. 31

Tobago Core - org/apache/myfaces/tobago/event/TreeMarkedEvent.java

Violation Line
Private field 'oldMarked' could be made final; it is only initialized in the declaration or constructor. 34
Private field 'newMarked' could be made final; it is only initialized in the declaration or constructor. 35

Tobago Core - org/apache/myfaces/tobago/event/TreeSelectedEvent.java

Violation Line
Private field 'oldSelected' could be made final; it is only initialized in the declaration or constructor. 30
Private field 'newSelected' could be made final; it is only initialized in the declaration or constructor. 31

Tobago Core - org/apache/myfaces/tobago/event/ValueExpressionPopupActionListener.java

Violation Line
Document empty constructor 5657

Tobago Core - org/apache/myfaces/tobago/event/ValueExpressionResetInputActionListener.java

Violation Line
Document empty constructor 4445

Tobago Core - org/apache/myfaces/tobago/event/ValueExpressionSheetStateChangeListener.java

Violation Line
Document empty constructor 3738
Avoid if (x != y) ..; else ..; 4751
No need to check for null before an instanceof 80

Tobago Core - org/apache/myfaces/tobago/event/ValueExpressionTabChangeListener.java

Violation Line
Document empty constructor 3738
Avoid if (x != y) ..; else ..; 4751
No need to check for null before an instanceof 80

Tobago Core - org/apache/myfaces/tobago/facelets/AttributeHandler.java

Violation Line
Possible God class (WMC=79, ATFD=79, TCC=0.027777777777777776) 20366
A high number of imports can indicate a high degree of coupling within an object. 20366
The class 'AttributeHandler' has a Modified Cyclomatic Complexity of 6 (Highest = 52). 56366
The class 'AttributeHandler' has a Standard Cyclomatic Complexity of 6 (Highest = 52). 56366
The class 'AttributeHandler' has a Cyclomatic Complexity of 7 (Highest = 59). 56366
The method 'apply' has a Cyclomatic Complexity of 59. 73283
The method apply() has an NCSS line count of 165 73283
The method 'apply' has a Standard Cyclomatic Complexity of 52. 73283
Avoid really long methods. 73283
The method 'apply' has a Modified Cyclomatic Complexity of 52. 73283
Avoid if (x != y) ..; else ..; 80281
Avoid if (x != y) ..; else ..; 84102
Avoid if (x != y) ..; else ..; 107125
Avoid if (x != y) ..; else ..; 193200
Consider using varargs for methods or constructors which take an array the last parameter. 307
Avoid if (x != y) ..; else ..; 313319

Tobago Core - org/apache/myfaces/tobago/facelets/ConverterHandler.java

Violation Line
Avoid declaring a variable if it is unreferenced before a possible exit point. 53
New exception is thrown in catch block, original stack trace may be lost 65
Deeply nested if..then statements are hard to read 6769

Tobago Core - org/apache/myfaces/tobago/facelets/FixCharacterEncodingFilter.java

Violation Line
Document empty method 3133
Document empty method 4445

Tobago Core - org/apache/myfaces/tobago/facelets/FlowLayoutRule.java

Violation Line
The class 'FlowLayoutRule' has a Modified Cyclomatic Complexity of 10 (Highest = 9). 33140
The class 'FlowLayoutRule' has a Cyclomatic Complexity of 10 (Highest = 9). 33140
The class 'FlowLayoutRule' has a Standard Cyclomatic Complexity of 10 (Highest = 9). 33140
These nested if statements could be combined 3958
Deeply nested if..then statements are hard to read 4042
Deeply nested if..then statements are hard to read 4345
Deeply nested if..then statements are hard to read 4648
Deeply nested if..then statements are hard to read 4951
Deeply nested if..then statements are hard to read 5254
Deeply nested if..then statements are hard to read 5557

Tobago Core - org/apache/myfaces/tobago/facelets/GridLayoutConstraintHandler.java

Violation Line
Possible God class (WMC=62, ATFD=138, TCC=0.0) 20342
The class 'GridLayoutConstraintHandler' has a Standard Cyclomatic Complexity of 30 (Highest = 58). 38342
The class 'GridLayoutConstraintHandler' has a Modified Cyclomatic Complexity of 30 (Highest = 58). 38342
The class 'GridLayoutConstraintHandler' has a Cyclomatic Complexity of 32 (Highest = 62). 38342
Too many fields 38342
The method apply() has an NCSS line count of 140 98341
The method apply() has an NPath complexity of 2106404298 98341
The method 'apply' has a Modified Cyclomatic Complexity of 58. 98341
Avoid really long methods. 98341
Avoid reassigning parameters such as 'parent' 98
The method 'apply' has a Cyclomatic Complexity of 62. 98341
The method 'apply' has a Standard Cyclomatic Complexity of 58. 98341
Avoid reassigning parameters such as 'parent' 98

Tobago Core - org/apache/myfaces/tobago/facelets/GridLayoutRule.java

Violation Line
The class 'GridLayoutRule' has a Modified Cyclomatic Complexity of 12 (Highest = 11). 32171
The class 'GridLayoutRule' has a Cyclomatic Complexity of 12 (Highest = 11). 32171
The class 'GridLayoutRule' has a Standard Cyclomatic Complexity of 12 (Highest = 11). 32171
The method 'applyRule' has a Standard Cyclomatic Complexity of 11. 3666
The method 'applyRule' has a Modified Cyclomatic Complexity of 11. 3666
The method 'applyRule' has a Cyclomatic Complexity of 11. 3666
The method applyRule() has an NPath complexity of 258 3666
These nested if statements could be combined 3863
Deeply nested if..then statements are hard to read 3941
Deeply nested if..then statements are hard to read 4244
Deeply nested if..then statements are hard to read 4547
Deeply nested if..then statements are hard to read 4850
Deeply nested if..then statements are hard to read 5153
Deeply nested if..then statements are hard to read 5456
Deeply nested if..then statements are hard to read 5759
Deeply nested if..then statements are hard to read 6062

Tobago Core - org/apache/myfaces/tobago/facelets/MetaInfResourcesClasspathResourceResolver.java

Violation Line
Avoid reassigning parameters such as 'path' 52
Avoid reassigning parameters such as 'path' 52
This call to String.startsWith can be rewritten using String.charAt(0) 58

Tobago Core - org/apache/myfaces/tobago/facelets/Resource.java

Violation Line
These nested if statements could be combined 7375
Document empty method 113114
Avoid if (x != y) ..; else ..; 134

Tobago Core - org/apache/myfaces/tobago/facelets/ScriptHandler.java

Violation Line
Document empty method 4849

Tobago Core - org/apache/myfaces/tobago/facelets/SheetStateChangeSourceRule.java

Violation Line
These nested if statements could be combined 4042

Tobago Core - org/apache/myfaces/tobago/facelets/SortActionSourceRule.java

Violation Line
These nested if statements could be combined 4143

Tobago Core - org/apache/myfaces/tobago/facelets/StyleHandler.java

Violation Line
Document empty method 4950

Tobago Core - org/apache/myfaces/tobago/facelets/SuggestMethodRule.java

Violation Line
These nested if statements could be combined 4143
These nested if statements could be combined 4650
These nested if statements could be combined 4749
Deeply nested if..then statements are hard to read 4749

Tobago Core - org/apache/myfaces/tobago/facelets/SupportsMarkupRule.java

Violation Line
These nested if statements could be combined 4042

Tobago Core - org/apache/myfaces/tobago/facelets/SupportsRenderedPartiallyRule.java

Violation Line
These nested if statements could be combined 4042

Tobago Core - org/apache/myfaces/tobago/facelets/TabChangeListenerHandler.java

Violation Line
New exception is thrown in catch block, original stack trace may be lost 76
Deeply nested if..then statements are hard to read 7880
Avoid if (x != y) ..; else ..; 8287

Tobago Core - org/apache/myfaces/tobago/facelets/TabChangeSourceRule.java

Violation Line
These nested if statements could be combined 3739

Tobago Core - org/apache/myfaces/tobago/facelets/TagMethodExpression.java

Violation Line
New exception is thrown in catch block, original stack trace may be lost 63
New exception is thrown in catch block, original stack trace may be lost 65
New exception is thrown in catch block, original stack trace may be lost 67
Consider using varargs for methods or constructors which take an array the last parameter. 71
New exception is thrown in catch block, original stack trace may be lost 75
New exception is thrown in catch block, original stack trace may be lost 77
New exception is thrown in catch block, original stack trace may be lost 79

Tobago Core - org/apache/myfaces/tobago/facelets/TobagoComponentHandler.java

Violation Line
The class 'TobagoComponentHandler' has a Cyclomatic Complexity of 5 (Highest = 11). 50139
The class 'TobagoComponentHandler' has a Modified Cyclomatic Complexity of 5 (Highest = 11). 50139
The class 'TobagoComponentHandler' has a Standard Cyclomatic Complexity of 5 (Highest = 11). 50139
The method 'createMetaRuleset' has a Standard Cyclomatic Complexity of 11. 5689
The method createMetaRuleset() has an NPath complexity of 1024 5689
The method 'createMetaRuleset' has a Cyclomatic Complexity of 11. 5689
The method 'createMetaRuleset' has a Modified Cyclomatic Complexity of 11. 5689

Tobago Core - org/apache/myfaces/tobago/facelets/WizardComponentHandler.java

Violation Line
Private field 'outcomeAttribute' could be made final; it is only initialized in the declaration or constructor. 30

Tobago Core - org/apache/myfaces/tobago/facelets/extension/DateExtensionHandler.java

Violation Line
Private field 'pickerIdAttribute' could be made final; it is only initialized in the declaration or constructor. 41
Private field 'formIdAttribute' could be made final; it is only initialized in the declaration or constructor. 42
Private field 'markupAttribute' could be made final; it is only initialized in the declaration or constructor. 43
The method onComponentPopulated() has an NPath complexity of 302 6099
Avoid if (x != y) ..; else ..; 7274
Avoid if (x != y) ..; else ..; 8183

Tobago Core - org/apache/myfaces/tobago/facelets/extension/SelectBooleanCheckboxExtensionHandler.java

Violation Line
Private field 'itemLabelAttribute' could be made final; it is only initialized in the declaration or constructor. 34
Avoid if (x != y) ..; else ..; 4453

Tobago Core - org/apache/myfaces/tobago/facelets/extension/SeparatorExtensionHandler.java

Violation Line
Private field 'labelAttribute' could be made final; it is only initialized in the declaration or constructor. 40

Tobago Core - org/apache/myfaces/tobago/facelets/extension/TobagoLabelExtensionHandler.java

Violation Line
The class 'TobagoLabelExtensionHandler' has a Cyclomatic Complexity of 3 (Highest = 10). 53277
The class 'TobagoLabelExtensionHandler' has a Standard Cyclomatic Complexity of 3 (Highest = 10). 53277
The class 'TobagoLabelExtensionHandler' has a Modified Cyclomatic Complexity of 3 (Highest = 10). 53277
Private field 'labelWidthAttribute' could be made final; it is only initialized in the declaration or constructor. 59
Private field 'tipAttribute' could be made final; it is only initialized in the declaration or constructor. 60
Private field 'labelAttribute' could be made final; it is only initialized in the declaration or constructor. 61
Private field 'accessKeyAttribute' could be made final; it is only initialized in the declaration or constructor. 62
Private field 'markupAttribute' could be made final; it is only initialized in the declaration or constructor. 63
Private field 'fieldIdAttribute' could be made final; it is only initialized in the declaration or constructor. 64
Avoid if (x != y) ..; else ..; 124128
Document empty method 143144
An empty method in an abstract class should be abstract instead 143144
The method 'addLabel' has a Standard Cyclomatic Complexity of 10. 146188
The method 'addLabel' has a Cyclomatic Complexity of 10. 146188
The method 'addLabel' has a Modified Cyclomatic Complexity of 10. 146188
Avoid if (x != y) ..; else ..; 220229

Tobago Core - org/apache/myfaces/tobago/facelets/extension/TobagoMenuExtensionHandler.java

Violation Line
Private field 'fieldIdAttribute' could be made final; it is only initialized in the declaration or constructor. 42
Avoid if (x != y) ..; else ..; 7072

Tobago Core - org/apache/myfaces/tobago/internal/ajax/AjaxInternalUtils.java

Violation Line
This class has too many methods, consider refactoring it. 45268
No need to check for null before an instanceof 83
These nested if statements could be combined 166168
Use equals() to compare object references. 184
These nested if statements could be combined 218220
Parameter 'facesContext' is not assigned and could be declared final 251
Parameter 'navigationState' is not assigned and could be declared final 251

Tobago Core - org/apache/myfaces/tobago/internal/ajax/AjaxNavigationListener.java

Violation Line
Parameter 'facesContext' is not assigned and could be declared final 56

Tobago Core - org/apache/myfaces/tobago/internal/ajax/AjaxNavigationState.java

Violation Line
Private field 'viewRoot' could be made final; it is only initialized in the declaration or constructor. 49
Private field 'messages' could be made final; it is only initialized in the declaration or constructor. 51
Private field 'sessionKey' could be made final; it is only initialized in the declaration or constructor. 53
Avoid if (x != y) ..; else ..; 116120
Avoid if (x != y) ..; else ..; 128135
Use equals() to compare object references. 139
Local variable 'token' could be declared final 150
Local variable 'token' could be declared final 178
Parameter 'facesContext' is not assigned and could be declared final 187
Local variable 'throwable' could be declared final 191
Parameter 'facesContext' is not assigned and could be declared final 199

Tobago Core - org/apache/myfaces/tobago/internal/ajax/AjaxResponseRenderer.java

Violation Line
Private field 'callback' could be made final; it is only initialized in the declaration or constructor. 62
Avoid reassigning parameters such as 'charset' 119
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 124
Avoid if (x != y) ..; else ..; 139143

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIButton.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2224

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIColumnNode.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2728

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIColumnSelector.java

Violation Line
An empty method in an abstract class should be abstract instead 2729

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUICommand.java

Violation Line
These nested if statements could be combined 4244

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUICommandBase.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2628

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIData.java

Violation Line
The String literal "Not a tree model" appears 4 times in this file; the first occurrence is on line 72 72
Avoid if (x != y) ..; else ..; 8185
Avoid if (x != y) ..; else ..; 103
Avoid if (x != y) ..; else ..; 146150
Avoid if (x != y) ..; else ..; 155
Avoid if (x != y) ..; else ..; 160
String.indexOf(char) is faster than String.indexOf(String). 201

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIDate.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2223

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIDatePicker.java

Violation Line
An empty method in an abstract class should be abstract instead 8183
An empty method in an abstract class should be abstract instead 8587
An empty method in an abstract class should be abstract instead 8991

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIFlowLayout.java

Violation Line
An empty method in an abstract class should be abstract instead 3031
Document empty method 3031
Document empty method 3334
An empty method in an abstract class should be abstract instead 3334
Document empty method 3637
An empty method in an abstract class should be abstract instead 3637
Document empty method 3941
An empty method in an abstract class should be abstract instead 3941
An empty method in an abstract class should be abstract instead 4344
Document empty method 4344

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIForm.java

Violation Line
Avoid if (x != y) ..; else ..; 7485
Avoid if (x != y) ..; else ..; 94105
These nested if statements could be combined 113115

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIGridLayout.java

Violation Line
Possible God class (WMC=121, ATFD=94, TCC=0.003076923076923077) 20509
The class 'AbstractUIGridLayout' has a Modified Cyclomatic Complexity of 4 (Highest = 21). 50509
The class 'AbstractUIGridLayout' has a Standard Cyclomatic Complexity of 4 (Highest = 21). 50509
The class 'AbstractUIGridLayout' has a Cyclomatic Complexity of 5 (Highest = 27). 50509
Avoid instantiating new objects inside loops 73
The method fixRelativeInsideAuto() has an NPath complexity of 400 86132
The method 'fixRelativeInsideAuto' has a Standard Cyclomatic Complexity of 12. 86132
The method 'fixRelativeInsideAuto' has a Modified Cyclomatic Complexity of 12. 86132
The method 'fixRelativeInsideAuto' has a Cyclomatic Complexity of 15. 86132
Deeply nested if..then statements are hard to read 98101
Avoid really long methods. 134247
The method 'preProcessing' has a Standard Cyclomatic Complexity of 21. 134247
The method 'preProcessing' has a Cyclomatic Complexity of 27. 134247
The method 'preProcessing' has a Modified Cyclomatic Complexity of 21. 134247
The method preProcessing() has an NPath complexity of 57620 134247
Avoid instantiating new objects inside loops 157
These nested if statements could be combined 169177
Avoid instantiating new objects inside loops 171
Deeply nested if..then statements are hard to read 173175
The method 'mainProcessing' has a Cyclomatic Complexity of 23. 249346
The method 'mainProcessing' has a Standard Cyclomatic Complexity of 19. 249346
The method 'mainProcessing' has a Modified Cyclomatic Complexity of 19. 249346
The method mainProcessing() has an NPath complexity of 30400 249346
Avoid if (x != y) ..; else ..; 269303
The method 'postProcessing' has a Modified Cyclomatic Complexity of 10. 348400
The method 'postProcessing' has a Cyclomatic Complexity of 15. 348400
The method 'postProcessing' has a Standard Cyclomatic Complexity of 10. 348400
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 476
Avoid appending characters as strings in StringBuffer.append. 476
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 477
Avoid appending characters as strings in StringBuffer.append. 478
Avoid appending characters as strings in StringBuffer.append. 488
Avoid appending characters as strings in StringBuffer.append. 498

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIIn.java

Violation Line
These nested if statements could be combined 3542

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUILabel.java

Violation Line
Avoid if (x != y) ..; else ..; 3238
Avoid if (x != y) ..; else ..; 3438

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUILayoutBase.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2425

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIMediator.java

Violation Line
Avoid unused private fields such as 'LOG'. 34

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIMessages.java

Violation Line
Avoid if (x != y) ..; else ..; 4145
Avoid declaring a variable if it is unreferenced before a possible exit point. 63
Avoid instantiating new objects inside loops 73
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 133

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIOut.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2627

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIPage.java

Violation Line
Possible God class (WMC=69, ATFD=34, TCC=0.014245014245014245) 20400
A high number of imports can indicate a high degree of coupling within an object. 20400
The class 'AbstractUIPage' has a Cyclomatic Complexity of 3 (Highest = 10). 67400
This class has too many methods, consider refactoring it. 68400
Avoid if (x != y) ..; else ..; 147165
The method 'decodeActionComponent' has a Cyclomatic Complexity of 10. 168198
Use equals() to compare object references. 191
Avoid if (x != y) ..; else ..; 208215
Avoid if (x != y) ..; else ..; 224230
The method 'markSubmittedForm' has a Cyclomatic Complexity of 10. 233284
Avoid if (x != y) ..; else ..; 270283
An empty method in an abstract class should be abstract instead 314315
Document empty method 314315
Avoid if (x != y) ..; else ..; 323333

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIPanel.java

Violation Line
An empty method in an abstract class should be abstract instead 6162
Document empty method 6162
Avoid if (x != y) ..; else ..; 7377
Avoid if (x != y) ..; else ..; 8091

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIPanelBase.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2627

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIPopup.java

Violation Line
Avoid unused private fields such as 'LOG'. 54
Avoid if (x != y) ..; else ..; 109114
No need to check for null before an instanceof 130

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectBooleanCheckbox.java

Violation Line
These nested if statements could be combined 4754

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectOneBase.java

Violation Line
Avoid if (x != y) ..; else ..; 3946

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectOneChoice.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2223

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectOneListbox.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2223

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectOneRadio.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2223

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISeparator.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2627

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISheet.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20699
Possible God class (WMC=144, ATFD=61, TCC=0.012121212121212121) 20699
This class has a bunch of public methods and attributes 20699
The class 'AbstractUISheet' has a Cyclomatic Complexity of 3 (Highest = 19). 69699
The class 'AbstractUISheet' has a Standard Cyclomatic Complexity of 2 (Highest = 17). 69699
The class 'AbstractUISheet' has a Modified Cyclomatic Complexity of 2 (Highest = 12). 69699
This class has too many methods, consider refactoring it. 71699
Avoid if (x != y) ..; else ..; 113117
Avoid if (x != y) ..; else ..; 281285
Avoid if (x != y) ..; else ..; 291299
Avoid if (x != y) ..; else ..; 325333
Avoid if (x != y) ..; else ..; 332
Avoid if (x != y) ..; else ..; 352
Local variable 'result' could be declared final 377
Local variable 'result' could be declared final 383
Parameter 'event' is not assigned and could be declared final 455
Parameter 'facesContext' is not assigned and could be declared final 462
Avoid reassigning parameters such as 'event' 462
Avoid if (x != y) ..; else ..; 466478
Avoid reassigning parameters such as 'searchId' 519
The method 'performPaging' has a Modified Cyclomatic Complexity of 12. 535597
The method 'performPaging' has a Standard Cyclomatic Complexity of 17. 535597
The method 'performPaging' has a Cyclomatic Complexity of 19. 535597
A switch statement does not contain a break 543586
Avoid if (x != y) ..; else ..; 589593
The method 'getComponents' has a Cyclomatic Complexity of 11. 599641
The method 'getComponents' has a Modified Cyclomatic Complexity of 11. 599641
The method 'getComponents' has a Standard Cyclomatic Complexity of 11. 599641
Avoid if (x != y) ..; else ..; 625637

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISheetLayout.java

Violation Line
Possible God class (WMC=88, ATFD=93, TCC=0.01098901098901099) 20429
The class 'AbstractUISheetLayout' has a Standard Cyclomatic Complexity of 6 (Highest = 17). 53429
The class 'AbstractUISheetLayout' has a Cyclomatic Complexity of 6 (Highest = 19). 53429
The class 'AbstractUISheetLayout' has a Modified Cyclomatic Complexity of 6 (Highest = 17). 53429
Avoid unused local variables such as 'intervals'. 89
These nested if statements could be combined 9395
The method 'mainProcessing' has a Modified Cyclomatic Complexity of 10. 117168
The method 'mainProcessing' has a Standard Cyclomatic Complexity of 10. 117168
The method 'mainProcessing' has a Cyclomatic Complexity of 13. 117168
Deeply nested if..then statements are hard to read 136138
Deeply nested if..then statements are hard to read 160162
The method ensureColumnWidthList() has an NPath complexity of 6192 207301
The method 'ensureColumnWidthList' has a Modified Cyclomatic Complexity of 17. 207301
The method 'ensureColumnWidthList' has a Standard Cyclomatic Complexity of 17. 207301
The method 'ensureColumnWidthList' has a Cyclomatic Complexity of 19. 207301
Local variable 'verticalScrollbarWeight' could be declared final 237
Local variable 'needVerticalScrollbar' could be declared final 238
Local variable 'width' could be declared final 279
Avoid if (x != y) ..; else ..; 294300
The method needVerticalScrollbar() has an NPath complexity of 660 303348
The method 'needVerticalScrollbar' has a Standard Cyclomatic Complexity of 12. 303348
The method 'needVerticalScrollbar' has a Modified Cyclomatic Complexity of 12. 303348
The method 'needVerticalScrollbar' has a Cyclomatic Complexity of 13. 303348
Avoid if (x != y) ..; else ..; 329344
Avoid unused local variables such as 'component'. 363
Avoid unused local variables such as 'ignored'. 408
Avoid instantiating new objects inside loops 419

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITabGroup.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20344
Possible God class (WMC=68, ATFD=23, TCC=0.0) 20344
The class 'AbstractUITabGroup' has a Modified Cyclomatic Complexity of 2 (Highest = 11). 54344
The class 'AbstractUITabGroup' has a Cyclomatic Complexity of 2 (Highest = 11). 54344
The class 'AbstractUITabGroup' has a Standard Cyclomatic Complexity of 2 (Highest = 11). 54344
This class has too many methods, consider refactoring it. 56344
An empty method in an abstract class should be abstract instead 7578
The method 'processDecodes' has a Modified Cyclomatic Complexity of 11. 135175
The method 'processDecodes' has a Standard Cyclomatic Complexity of 11. 135175
The method 'processDecodes' has a Cyclomatic Complexity of 11. 135175
Avoid if (x != y) ..; else ..; 136174
Local variable 'facet' could be declared final 152
Avoid if (x != y) ..; else ..; 179193
Avoid if (x != y) ..; else ..; 198213
Avoid if (x != y) ..; else ..; 241245

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITabGroupLayout.java

Violation Line
The class 'AbstractUITabGroupLayout' has a Cyclomatic Complexity of 5 (Highest = 10). 33137
Avoid instantiating new objects inside loops 75
The method 'mainProcessing' has a Cyclomatic Complexity of 10. 90113
Avoid if (x != y) ..; else ..; 98104

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITextarea.java

Violation Line
An empty method in an abstract class should be abstract instead 2527

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITime.java

Violation Line
An empty method in an abstract class should be abstract instead 5052

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIToolBar.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2438

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIToolBarCommand.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2224

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIToolBarSelectOne.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2425

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITreeCommand.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2223

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITreeData.java

Violation Line
Avoid if (x != y) ..; else ..; 5054
Avoid if (x != y) ..; else ..; 5963

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITreeIndent.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2627

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITreeNode.java

Violation Line
Consider simply returning the value vs storing it in local variable 'rowData' 92
The String literal "Doesn't work anymore." appears 10 times in this file; the first occurrence is on line 100 100
The String literal "treeExpansionListener!" appears 5 times in this file; the first occurrence is on line 182 182
Return an empty array rather than null. 206209
The String literal "treeMarkedListener!" appears 5 times in this file; the first occurrence is on line 224 224
Return an empty array rather than null. 248251

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIWizard.java

Violation Line
Avoid if (x != y) ..; else ..; 133137
Unnecessary use of fully qualified name 'javax.faces.el.ValueBinding' due to existing import 'javax.faces.el.ValueBinding' 156
Unnecessary use of fully qualified name 'javax.faces.el.ValueBinding' due to existing import 'javax.faces.el.ValueBinding' 172
Unnecessary use of fully qualified name 'javax.faces.el.ValueBinding' due to existing import 'javax.faces.el.ValueBinding' 188

Tobago Core - org/apache/myfaces/tobago/internal/config/ContentSecurityPolicy.java

Violation Line
Avoid using redundant field initializer for 'unmodifiable' 31

Tobago Core - org/apache/myfaces/tobago/internal/config/RenderersConfigImpl.java

Violation Line
Avoid using redundant field initializer for 'merged' 40
Avoid using redundant field initializer for 'unmodifiable' 42
Avoid if (x != y) ..; else ..; 8590

Tobago Core - org/apache/myfaces/tobago/internal/config/ThemeBuilder.java

Violation Line
Private field 'availableThemes' could be made final; it is only initialized in the declaration or constructor. 37
Private field 'tobagoConfig' could be made final; it is only initialized in the declaration or constructor. 38

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigBuilder.java

Violation Line
Private field 'list' could be made final; it is only initialized in the declaration or constructor. 45
Avoid unused local variables such as 'builder'. 72
Avoid instantiating new objects inside loops 103

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigEntityResolver.java

Violation Line
Position literals first in String comparisons 51
Position literals first in String comparisons 53
Position literals first in String comparisons 55
Position literals first in String comparisons 57
Avoid if (x != y) ..; else ..; 6268

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigFragment.java

Violation Line
Too many fields 33228
Private field 'before' could be made final; it is only initialized in the declaration or constructor. 38
Private field 'after' could be made final; it is only initialized in the declaration or constructor. 39
Private field 'supportedThemeNames' could be made final; it is only initialized in the declaration or constructor. 41
Private field 'resourceDirs' could be made final; it is only initialized in the declaration or constructor. 43
Private field 'themeDefinitions' could be made final; it is only initialized in the declaration or constructor. 50
Private field 'mimeTypes' could be made final; it is only initialized in the declaration or constructor. 56
Parameter 'sanitizerClass' is not assigned and could be declared final 188
Parameter 'sanitizerProperties' is not assigned and could be declared final 196
Parameter 'autoAccessKeyFromLabel' is not assigned and could be declared final 204
Parameter 'classicDateTimePicker' is not assigned and could be declared final 212
Parameter 'extension' is not assigned and could be declared final 216
Parameter 'type' is not assigned and could be declared final 216
Avoid if (x != y) ..; else ..; 226

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigImpl.java

Violation Line
Possible God class (WMC=70, ATFD=25, TCC=0.08067226890756303) 20428
The class 'TobagoConfigImpl' has a Modified Cyclomatic Complexity of 2 (Highest = 10). 50428
The class 'TobagoConfigImpl' has a Cyclomatic Complexity of 2 (Highest = 10). 50428
The class 'TobagoConfigImpl' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 50428
Too many fields 50428
Private field 'contentSecurityPolicy' could be made final; it is only initialized in the declaration or constructor. 65
Avoid using redundant field initializer for 'unmodifiable' 73
Local variable 'theme' could be declared final 95
The method 'resolveThemes' has a Modified Cyclomatic Complexity of 10. 122163
The method 'resolveThemes' has a Standard Cyclomatic Complexity of 10. 122163
The method 'resolveThemes' has a Cyclomatic Complexity of 10. 122163
Avoid if (x != y) ..; else ..; 124151
The method 'initProjectState' has a Modified Cyclomatic Complexity of 10. 241280
The method 'initProjectState' has a Standard Cyclomatic Complexity of 10. 241280
The method 'initProjectState' has a Cyclomatic Complexity of 10. 241280
Use block level rather than method level synchronization 282301
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 291
Parameter 'sanitizer' is not assigned and could be declared final 356
Parameter 'autoAccessKeyFromLabel' is not assigned and could be declared final 365
Parameter 'classicDateTimePicker' is not assigned and could be declared final 380
StringBuffer constructor is initialized with size 16, but has at least 346 characters appended. 386
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 387
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 387
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 393
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 394
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 395
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 396
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 397
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 398
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 399
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 400
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 401
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 402
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 403
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 404
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 405
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 406
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 407
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 408
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 409
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 410
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 411
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 412
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 413
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 414
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 415
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 416
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 417
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 418
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 422
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 423
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 424

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigParser.java

Violation Line
Possible God class (WMC=107, ATFD=38, TCC=0.05454545454545454) 20464
This class has too many methods, consider refactoring it. 48464
The class 'TobagoConfigParser' has a Cyclomatic Complexity of 6 (Highest = 33). 48464
The class 'TobagoConfigParser' has a Standard Cyclomatic Complexity of 6 (Highest = 33). 48464
StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 95
Perhaps 'extension' could be replaced by a local variable. 98
Perhaps 'type' could be replaced by a local variable. 99
Document empty constructor 103104
The method 'startElement' has a Standard Cyclomatic Complexity of 15. 155257
The method 'startElement' has a Cyclomatic Complexity of 15. 155257
Avoid really long methods. 155257
A switch statement does not contain a break 164256
Avoid if (x != y) ..; else ..; 176180
The method endElement() has an NCSS line count of 119 265424
The method 'endElement' has a Cyclomatic Complexity of 33. 265424
Avoid really long methods. 265424
The method 'endElement' has a Standard Cyclomatic Complexity of 33. 265424
A switch statement does not contain a break 275304
Avoid if (x != y) ..; else ..; 291295

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigSorter.java

Violation Line
Possible God class (WMC=60, ATFD=61, TCC=0.24175824175824176) 20323
The class 'TobagoConfigSorter' has a Cyclomatic Complexity of 5 (Highest = 19). 35323
The class 'TobagoConfigSorter' has a Modified Cyclomatic Complexity of 5 (Highest = 19). 35323
The class 'TobagoConfigSorter' has a Standard Cyclomatic Complexity of 5 (Highest = 19). 35323
Private field 'list' could be made final; it is only initialized in the declaration or constructor. 39
Prefer StringBuffer over += for concatenating strings 65
The method 'merge' has a Modified Cyclomatic Complexity of 19. 72171
The method 'merge' has a Standard Cyclomatic Complexity of 19. 72171
The method merge() has an NPath complexity of 49155 72171
The method 'merge' has a Cyclomatic Complexity of 19. 72171
Avoid instantiation through private constructors from outside of the constructors class. 182
Avoid instantiating new objects inside loops 182
Avoid instantiating new objects inside loops 193
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 194
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 195
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 196
The String literal "' < '" appears 4 times in this file; the first occurrence is on line 196 196
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 197
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 198
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 198
Avoid appending characters as strings in StringBuffer.append. 201
Avoid instantiating new objects inside loops 217
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 218
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 219
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 220
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 221
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 222
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 223
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 224
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 225
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 226
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 226
Avoid appending characters as strings in StringBuffer.append. 229
Avoid instantiating new objects inside loops 261
Avoid instantiation through private constructors from outside of the constructors class. 261
Avoid instantiating new objects inside loops 267
Avoid instantiation through private constructors from outside of the constructors class. 267

Tobago Core - org/apache/myfaces/tobago/internal/context/ClientPropertiesKey.java

Violation Line
The class 'ClientPropertiesKey' has a Cyclomatic Complexity of 2 (Highest = 10). 32135
The method 'equals' has a Cyclomatic Complexity of 10. 6898

Tobago Core - org/apache/myfaces/tobago/internal/context/DateTimeI18n.java

Violation Line
A class which only has private constructors should be final 31106
Parameter 'locale' is not assigned and could be declared final 44
Unnecessary use of fully qualified name 'java.util.Calendar.MONTH' due to existing import 'java.util.Calendar' 56
Parameter 'locale' is not assigned and could be declared final 73
Use block level rather than method level synchronization 7381

Tobago Core - org/apache/myfaces/tobago/internal/context/ImageCacheKey.java

Violation Line
Parameter 'o' is not assigned and could be declared final 36
Local variable 'that' could be declared final 44
Avoid if (x != y) ..; else ..; 49

Tobago Core - org/apache/myfaces/tobago/internal/context/MeasureValue.java

Violation Line
Private field 'value' could be made final; it is only initialized in the declaration or constructor. 31
Avoid if (x != y) ..; else ..; 52
Avoid if (x != y) ..; else ..; 61
Do not add empty strings 66

Tobago Core - org/apache/myfaces/tobago/internal/context/ResourceLocator.java

Violation Line
Possible God class (WMC=71, ATFD=41, TCC=0.07575757575757576) 20455
The class 'ResourceLocator' has a Standard Cyclomatic Complexity of 5 (Highest = 12). 62455
The class 'ResourceLocator' has a Modified Cyclomatic Complexity of 5 (Highest = 12). 62455
The class 'ResourceLocator' has a Cyclomatic Complexity of 6 (Highest = 14). 62455
This class has too many methods, consider refactoring it. 62455
Private field 'servletContext' could be made final; it is only initialized in the declaration or constructor. 70
Private field 'resourceManager' could be made final; it is only initialized in the declaration or constructor. 71
Private field 'themeBuilder' could be made final; it is only initialized in the declaration or constructor. 72
The method 'locateResourcesInWar' has a Standard Cyclomatic Complexity of 12. 89140
The method 'locateResourcesInWar' has a Cyclomatic Complexity of 14. 89140
The method 'locateResourcesInWar' has a Modified Cyclomatic Complexity of 12. 89140
The method locateResourcesInWar() has an NPath complexity of 240 89140
Avoid reassigning parameters such as 'path' 90
Avoid instantiating new objects inside loops 154
An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 168
Avoid if (x != y) ..; else ..; 241245
The method addResourcesFromZip() has an NPath complexity of 288 280335
The method 'addResourcesFromZip' has a Standard Cyclomatic Complexity of 11. 280335
The method 'addResourcesFromZip' has a Cyclomatic Complexity of 12. 280335
The method 'addResourcesFromZip' has a Modified Cyclomatic Complexity of 11. 280335
Avoid reassigning parameters such as 'fileName' 281
Avoid reassigning parameters such as 'fileName' 281
Avoid reassigning parameters such as 'fileName' 281
String.indexOf(char) is faster than String.indexOf(String). 285
Do not add empty strings 290
Position literals first in String comparisons 294
Position literals first in String comparisons 303
Avoid reassigning parameters such as 'resourcePath' 369
Avoid reassigning parameters such as 'resourcePath' 369
This call to String.startsWith can be rewritten using String.charAt(0) 370
Avoid declaring a variable if it is unreferenced before a possible exit point. 384
Avoid declaring a variable if it is unreferenced before a possible exit point. 391
Avoid if (x != y) ..; else ..; 445451

Tobago Core - org/apache/myfaces/tobago/internal/context/ResourceManagerFactory.java

Violation Line
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 38

Tobago Core - org/apache/myfaces/tobago/internal/context/ResourceManagerImpl.java

Violation Line
Possible God class (WMC=133, ATFD=75, TCC=0.13333333333333333) 20688
The class 'ResourceManagerImpl' has a Standard Cyclomatic Complexity of 4 (Highest = 21). 44688
The class 'ResourceManagerImpl' has a Cyclomatic Complexity of 5 (Highest = 35). 44688
The class 'ResourceManagerImpl' has a Modified Cyclomatic Complexity of 4 (Highest = 21). 44688
Private field 'production' could be made final; it is only initialized in the declaration or constructor. 64
Private field 'tobagoConfig' could be made final; it is only initialized in the declaration or constructor. 84
The String literal "name = '" appears 4 times in this file; the first occurrence is on line 133 133
The String literal "' clientProperties = '" appears 4 times in this file; the first occurrence is on line 133 133
Avoid if (x != y) ..; else ..; 154158
Avoid if (x != y) ..; else ..; 187193
Avoid if (x != y) ..; else ..; 232236
Avoid if (x != y) ..; else ..; 276280
Avoid if (x != y) ..; else ..; 338342
These nested if statements could be combined 346348
The method 'getPaths' has a Modified Cyclomatic Complexity of 21. 357453
The method 'getPaths' has a Cyclomatic Complexity of 35. 357453
The method getPaths() has an NPath complexity of 7540 357453
The method 'getPaths' has a Standard Cyclomatic Complexity of 21. 357453
Avoid long parameter lists. 357360
Avoid reassigning parameters such as 'ignoreMissing' 360
Avoid declaring a variable if it is unreferenced before a possible exit point. 362
Avoid declaring a variable if it is unreferenced before a possible exit point. 363
Avoid declaring a variable if it is unreferenced before a possible exit point. 364
The method 'checkPath' has a Cyclomatic Complexity of 11. 455497
The method 'checkPath' has a Standard Cyclomatic Complexity of 10. 455497
The method 'checkPath' has a Modified Cyclomatic Complexity of 10. 455497
Avoid long parameter lists. 455458
Avoid if (x != y) ..; else ..; 476495
The String literal "testing path: " appears 6 times in this file; the first occurrence is on line 481 481
The method 'checkPath' has a Modified Cyclomatic Complexity of 11. 499546
The method 'checkPath' has a Cyclomatic Complexity of 14. 499546
The method 'checkPath' has a Standard Cyclomatic Complexity of 11. 499546
Avoid long parameter lists. 499503
Avoid if (x != y) ..; else ..; 525544
Avoid long parameter lists. 548551
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 554
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 560
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 561
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 562
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 563
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 564
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 570
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 575
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 590
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 595
Prefer StringBuffer over += for concatenating strings 615
Avoid if (x != y) ..; else ..; 662670

Tobago Core - org/apache/myfaces/tobago/internal/context/ResponseWriterDivider.java

Violation Line
Private field 'writers' could be made final; it is only initialized in the declaration or constructor. 41
Private field 'buffers' could be made final; it is only initialized in the declaration or constructor. 42
Private field 'original' could be made final; it is only initialized in the declaration or constructor. 44
StringBuffer constructor is initialized with size 16, but has at least 175 characters appended. 139
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 140
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 141
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 142
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 143
Avoid appending characters as strings in StringBuffer.append. 144

Tobago Core - org/apache/myfaces/tobago/internal/context/StringValue.java

Violation Line
Private field 'value' could be made final; it is only initialized in the declaration or constructor. 29
Avoid if (x != y) ..; else ..; 50
Avoid if (x != y) ..; else ..; 59

Tobago Core - org/apache/myfaces/tobago/internal/context/ThemeConfigCacheKey.java

Violation Line
Avoid if (x != y) ..; else ..; 59
Avoid if (x != y) ..; else ..; 73

Tobago Core - org/apache/myfaces/tobago/internal/layout/Grid.java

Violation Line
Possible God class (WMC=104, ATFD=22, TCC=0.3006535947712418) 20498
The class 'Grid' has a Standard Cyclomatic Complexity of 5 (Highest = 51). 32498
The class 'Grid' has a Cyclomatic Complexity of 5 (Highest = 55). 32498
The class 'Grid' has a Modified Cyclomatic Complexity of 5 (Highest = 51). 32498
Private field 'cells' could be made final; it is only initialized in the declaration or constructor. 40
Private field 'columnHeads' could be made final; it is only initialized in the declaration or constructor. 42
Private field 'columnCount' could be made final; it is only initialized in the declaration or constructor. 45
Avoid instantiating new objects inside loops 65
Avoid instantiating new objects inside loops 69
Avoid reassigning parameters such as 'columnSpan' 78
Avoid reassigning parameters such as 'columnSpan' 78
Avoid instantiating new objects inside loops 110
Avoid instantiating new objects inside loops 176
The method gridAsString() has an NCSS line count of 175 246474
The method 'gridAsString' has a Cyclomatic Complexity of 55. 246474
The method gridAsString() has an NPath complexity of 11503356 246474
Avoid really long methods. 246474
The method 'gridAsString' has a Standard Cyclomatic Complexity of 51. 246474
The method 'gridAsString' has a Modified Cyclomatic Complexity of 51. 246474
StringBuffer constructor is initialized with size 16, but has at least 17 characters appended. 248
Avoid if (x != y) ..; else ..; 253257
Avoid appending characters as strings in StringBuffer.append. 254
Avoid appending characters as strings in StringBuffer.append. 256
Avoid appending characters as strings in StringBuffer.append. 262
Avoid appending characters as strings in StringBuffer.append. 265
Avoid appending characters as strings in StringBuffer.append. 268
Avoid appending characters as strings in StringBuffer.append. 270
Avoid appending characters as strings in StringBuffer.append. 272
Avoid if (x != y) ..; else ..; 277281
Avoid appending characters as strings in StringBuffer.append. 278
Avoid appending characters as strings in StringBuffer.append. 280
Avoid if (x != y) ..; else ..; 284288
Avoid appending characters as strings in StringBuffer.append. 285
Avoid appending characters as strings in StringBuffer.append. 287
Avoid appending characters as strings in StringBuffer.append. 289
Avoid appending characters as strings in StringBuffer.append. 300
Avoid appending characters as strings in StringBuffer.append. 303
Avoid appending characters as strings in StringBuffer.append. 306
Avoid appending characters as strings in StringBuffer.append. 308
Avoid appending characters as strings in StringBuffer.append. 310
Avoid appending characters as strings in StringBuffer.append. 325
Avoid appending characters as strings in StringBuffer.append. 327
Avoid appending characters as strings in StringBuffer.append. 330
Avoid appending characters as strings in StringBuffer.append. 335
Avoid appending characters as strings in StringBuffer.append. 337
Avoid appending characters as strings in StringBuffer.append. 339
Avoid appending characters as strings in StringBuffer.append. 344
Avoid appending characters as strings in StringBuffer.append. 346
Avoid appending characters as strings in StringBuffer.append. 350
Avoid appending characters as strings in StringBuffer.append. 352
Avoid appending characters as strings in StringBuffer.append. 361
Avoid appending characters as strings in StringBuffer.append. 363
Avoid appending characters as strings in StringBuffer.append. 369
Avoid appending characters as strings in StringBuffer.append. 372
Avoid appending characters as strings in StringBuffer.append. 375
Avoid appending characters as strings in StringBuffer.append. 377
Avoid appending characters as strings in StringBuffer.append. 379
Avoid appending characters as strings in StringBuffer.append. 383
Avoid if (x != y) ..; else ..; 389393
Avoid appending characters as strings in StringBuffer.append. 390
Avoid appending characters as strings in StringBuffer.append. 392
Avoid appending characters as strings in StringBuffer.append. 398
Avoid appending characters as strings in StringBuffer.append. 400
Avoid appending characters as strings in StringBuffer.append. 404
Avoid appending characters as strings in StringBuffer.append. 407
Avoid appending characters as strings in StringBuffer.append. 410
Avoid appending characters as strings in StringBuffer.append. 415
Avoid appending characters as strings in StringBuffer.append. 417
Avoid appending characters as strings in StringBuffer.append. 421
Avoid if (x != y) ..; else ..; 425429
Avoid appending characters as strings in StringBuffer.append. 426
Avoid appending characters as strings in StringBuffer.append. 428
Avoid appending characters as strings in StringBuffer.append. 430
Avoid if (x != y) ..; else ..; 436440
Avoid appending characters as strings in StringBuffer.append. 437
Avoid appending characters as strings in StringBuffer.append. 439
Avoid appending characters as strings in StringBuffer.append. 445
Avoid appending characters as strings in StringBuffer.append. 448
Avoid appending characters as strings in StringBuffer.append. 451
Avoid appending characters as strings in StringBuffer.append. 453
Avoid appending characters as strings in StringBuffer.append. 455
Avoid if (x != y) ..; else ..; 460464
Avoid appending characters as strings in StringBuffer.append. 461
Avoid appending characters as strings in StringBuffer.append. 463
Avoid if (x != y) ..; else ..; 466470
Avoid appending characters as strings in StringBuffer.append. 467
Avoid appending characters as strings in StringBuffer.append. 469
Avoid appending characters as strings in StringBuffer.append. 471
StringBuffer constructor is initialized with size 16, but has at least 25 characters appended. 478
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 479
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 480
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 481
Avoid appending characters as strings in StringBuffer.append. 482
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 482
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 482
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 483
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 484
Avoid appending characters as strings in StringBuffer.append. 485

Tobago Core - org/apache/myfaces/tobago/internal/layout/Interval.java

Violation Line
Avoid if (x != y) ..; else ..; 6667
Avoid if (x != y) ..; else ..; 68
Avoid if (x != y) ..; else ..; 69
Avoid if (x != y) ..; else ..; 70
Avoid appending characters as strings in StringBuffer.append. 92
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 92
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 93
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 94
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 95
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 96
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 97
Avoid appending characters as strings in StringBuffer.append. 98
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 98
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 99
Avoid appending characters as strings in StringBuffer.append. 100

Tobago Core - org/apache/myfaces/tobago/internal/layout/IntervalList.java

Violation Line
Avoid if (x != y) ..; else ..; 4953

Tobago Core - org/apache/myfaces/tobago/internal/layout/LayoutContext.java

Violation Line
The class 'LayoutContext' has a Cyclomatic Complexity of 5 (Highest = 12). 59159
The class 'LayoutContext' has a Standard Cyclomatic Complexity of 5 (Highest = 12). 59159
The class 'LayoutContext' has a Modified Cyclomatic Complexity of 5 (Highest = 12). 59159
Private field 'container' could be made final; it is only initialized in the declaration or constructor. 63
The method 'layout' has a Cyclomatic Complexity of 12. 69120
The method layout() has an NPath complexity of 2048 69120
The method 'layout' has a Standard Cyclomatic Complexity of 12. 69120
The method 'layout' has a Modified Cyclomatic Complexity of 12. 69120
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 123
Avoid appending characters as strings in StringBuffer.append. 136
Avoid appending characters as strings in StringBuffer.append. 139
Avoid appending characters as strings in StringBuffer.append. 143
Avoid appending characters as strings in StringBuffer.append. 148
Avoid appending characters as strings in StringBuffer.append. 154

Tobago Core - org/apache/myfaces/tobago/internal/layout/LayoutUtils.java

Violation Line
Avoid unused private fields such as 'LOG'. 39
Avoid reassigning parameters such as 'size' 105
Avoid reassigning parameters such as 'size' 105
Avoid reassigning parameters such as 'size' 105
Avoid reassigning parameters such as 'size' 105
Avoid reassigning parameters such as 'size' 105
Avoid reassigning parameters such as 'size' 105
Avoid if (x != y) ..; else ..; 108119
Avoid if (x != y) ..; else ..; 123134

Tobago Core - org/apache/myfaces/tobago/internal/layout/MathUtils.java

Violation Line
Avoid reassigning parameters such as 'bias' 36
Avoid unused local variables such as 'ignored'. 37
Consider using varargs for methods or constructors which take an array the last parameter. 53
Consider using varargs for methods or constructors which take an array the last parameter. 70

Tobago Core - org/apache/myfaces/tobago/internal/layout/OriginCell.java

Violation Line
Private field 'component' could be made final; it is only initialized in the declaration or constructor. 27

Tobago Core - org/apache/myfaces/tobago/internal/layout/SpanCell.java

Violation Line
Private field 'origin' could be made final; it is only initialized in the declaration or constructor. 26
Private field 'horizontalFirst' could be made final; it is only initialized in the declaration or constructor. 27
Private field 'verticalFirst' could be made final; it is only initialized in the declaration or constructor. 28

Tobago Core - org/apache/myfaces/tobago/internal/taglib/TobagoBodyTag.java

Violation Line
Avoid unused private fields such as 'LOG'. 31
Document empty method 3940
An empty method in an abstract class should be abstract instead 3940
String.trim().length()==0 is an inefficient way to validate an empty String. 52

Tobago Core - org/apache/myfaces/tobago/internal/taglib/TobagoELTag.java

Violation Line
String.trim().length()==0 is an inefficient way to validate an empty String. 81

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/AttributeTag.java

Violation Line
Avoid if (x != y) ..; else ..; 8393

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/CellTagDeclaration.java

Violation Line
The String literal "java.lang.Integer" appears 4 times in this file; the first occurrence is on line 52 52

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/ConverterTag.java

Violation Line
The class 'ConverterTag' has a Standard Cyclomatic Complexity of 4 (Highest = 10). 45137
The class 'ConverterTag' has a Modified Cyclomatic Complexity of 4 (Highest = 10). 45137
The class 'ConverterTag' has a Cyclomatic Complexity of 4 (Highest = 12). 45137
The method 'doStartTag' has a Cyclomatic Complexity of 12. 61113
The method 'doStartTag' has a Modified Cyclomatic Complexity of 10. 61113
The method 'doStartTag' has a Standard Cyclomatic Complexity of 10. 61113
The method doStartTag() has an NPath complexity of 576 61113
Avoid if (x != y) ..; else ..; 102109

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/DataAttributeTag.java

Violation Line
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 51
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 52

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/GridLayoutConstraintTag.java

Violation Line
Possible God class (WMC=82, ATFD=101, TCC=0.16304347826086957) 20542
The class 'GridLayoutConstraintTag' has a Cyclomatic Complexity of 3 (Highest = 59). 49542
The class 'GridLayoutConstraintTag' has a Standard Cyclomatic Complexity of 3 (Highest = 58). 49542
The class 'GridLayoutConstraintTag' has a Modified Cyclomatic Complexity of 3 (Highest = 58). 49542
Too many fields 49542
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 55
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 56
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 57
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 58
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 59
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 60
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 61
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 62
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 63
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 64
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 65
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 66
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 67
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 68
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 69
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 70
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 71
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 72
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 73
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 74
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 75
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 76
The method doStartTag() has an NCSS line count of 151 79318
The method 'doStartTag' has a Modified Cyclomatic Complexity of 58. 79318
Avoid really long methods. 79318
The method 'doStartTag' has a Cyclomatic Complexity of 59. 79318
The method 'doStartTag' has a Standard Cyclomatic Complexity of 58. 79318
The String literal "Ignoring '" appears 10 times in this file; the first occurrence is on line 114 114
The String literal "', because the parent is not a LayoutContainer!" appears 8 times in this file; the first occurrence is on line 230 230
The String literal "java.lang.Object" appears 40 times in this file; the first occurrence is on line 366 366

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/PopupReferenceTag.java

Violation Line
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 48

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/ResetInputActionListenerTag.java

Violation Line
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 103

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/SheetTagDeclaration.java

Violation Line
The String literal "boolean" appears 4 times in this file; the first occurrence is on line 75 75
The String literal "center" appears 4 times in this file; the first occurrence is on line 152 152
The String literal "right" appears 4 times in this file; the first occurrence is on line 153 153
The String literal "none" appears 4 times in this file; the first occurrence is on line 153 153
The String literal "left" appears 4 times in this file; the first occurrence is on line 153 153

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/SuggestTagDeclaration.java

Violation Line
The String literal "java.lang.Integer" appears 4 times in this file; the first occurrence is on line 84 84

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/TabChangeListenerTag.java

Violation Line
The class 'TabChangeListenerTag' has a Standard Cyclomatic Complexity of 4 (Highest = 11). 45146
The class 'TabChangeListenerTag' has a Cyclomatic Complexity of 5 (Highest = 14). 45146
The class 'TabChangeListenerTag' has a Modified Cyclomatic Complexity of 4 (Highest = 11). 45146
The method doStartTag() has an NPath complexity of 960 78130
The method 'doStartTag' has a Modified Cyclomatic Complexity of 11. 78130
The method 'doStartTag' has a Cyclomatic Complexity of 14. 78130
The method 'doStartTag' has a Standard Cyclomatic Complexity of 11. 78130
Avoid if (x != y) ..; else ..; 121126

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/ValidateFileItemTag.java

Violation Line
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 52
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 53

Tobago Core - org/apache/myfaces/tobago/internal/taglib/declaration/HasMargins.java

Violation Line
The String literal "org.apache.myfaces.tobago.layout.Measure" appears 4 times in this file; the first occurrence is on line 32 32
The String literal "getMargin() != null\n" appears 4 times in this file; the first occurrence is on line 33 33
The String literal " ? getMargin()\n : getRendererType() != null" appears 4 times in this file; the first occurrence is on line 34 34

Tobago Core - org/apache/myfaces/tobago/internal/taglib/declaration/IsGridLayoutComponentBase.java

Violation Line
The String literal "org.apache.myfaces.tobago.layout.Measure" appears 14 times in this file; the first occurrence is on line 35 35
The String literal "java.lang.Integer" appears 4 times in this file; the first occurrence is on line 51 51
The String literal "getRendererType() != null ? ((LayoutComponentRenderer) " appears 10 times in this file; the first occurrence is on line 64 64

Tobago Core - org/apache/myfaces/tobago/internal/taglib/declaration/IsGridLayoutContainer.java

Violation Line
The String literal "org.apache.myfaces.tobago.layout.Measure" appears 8 times in this file; the first occurrence is on line 32 32
The String literal "getRendererType() != null ? ((org.apache.myfaces.tobago.renderkit.LayoutComponentRenderer)\n" appears 8 times in this file; the first occurrence is on line 33 33

Tobago Core - org/apache/myfaces/tobago/internal/taglib/extension/DateExtensionTag.java

Violation Line
Possible God class (WMC=57, ATFD=40, TCC=0.1402116402116402) 20503
The class 'DateExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 26). 56503
Too many fields 56503
The class 'DateExtensionTag' has a Modified Cyclomatic Complexity of 2 (Highest = 26). 56503
The class 'DateExtensionTag' has a Standard Cyclomatic Complexity of 2 (Highest = 26). 56503
The method doStartTag() has an NPath complexity of 33554432 89182
The method 'doStartTag' has a Standard Cyclomatic Complexity of 26. 89182
The method 'doStartTag' has a Modified Cyclomatic Complexity of 26. 89182
The method 'doStartTag' has a Cyclomatic Complexity of 26. 89182
Avoid if (x != y) ..; else ..; 102106
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 288
The String literal "false" appears 4 times in this file; the first occurrence is on line 305 305
The String literal "boolean" appears 5 times in this file; the first occurrence is on line 305 305

Tobago Core - org/apache/myfaces/tobago/internal/taglib/extension/ExtensionPanelTag.java

Violation Line
Avoid unused private fields such as 'LOG'. 33
Avoid unused local variables such as 'application'. 51
Avoid if (x != y) ..; else ..; 5357

Tobago Core - org/apache/myfaces/tobago/internal/taglib/extension/FileExtensionTag.java

Violation Line
The class 'FileExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 21). 55379
Too many fields 55379
The class 'FileExtensionTag' has a Standard Cyclomatic Complexity of 2 (Highest = 21). 55379
The class 'FileExtensionTag' has a Modified Cyclomatic Complexity of 2 (Highest = 21). 55379
The method 'doStartTag' has a Modified Cyclomatic Complexity of 21. 80155
The method 'doStartTag' has a Cyclomatic Complexity of 21. 80155
The method doStartTag() has an NPath complexity of 1048576 80155
The method 'doStartTag' has a Standard Cyclomatic Complexity of 21. 80155
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 204
The String literal "boolean" appears 4 times in this file; the first occurrence is on line 258 258

Tobago Core - org/apache/myfaces/tobago/internal/taglib/extension/InExtensionTag.java

Violation Line
Possible God class (WMC=59, ATFD=38, TCC=0.12183908045977011) 20529
The class 'InExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 30). 57529
The class 'InExtensionTag' has a Modified Cyclomatic Complexity of 2 (Highest = 30). 57529
Too many fields 57529
The class 'InExtensionTag' has a Standard Cyclomatic Complexity of 2 (Highest = 30). 57529
The method 'doStartTag' has a Modified Cyclomatic Complexity of 30. 93195
The method 'doStartTag' has a Cyclomatic Complexity of 30. 93195
Avoid really long methods. 93195
The method doStartTag() has an NPath complexity of 536870912 93195
The method 'doStartTag' has a Standard Cyclomatic Complexity of 30. 93195
Avoid unused private fields such as 'LOG'. 204
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 290
The String literal "boolean" appears 6 times in this file; the first occurrence is on line 298 298
The String literal "false" appears 5 times in this file; the first occurrence is on line 298 298

Tobago Core - org/apache/myfaces/tobago/internal/taglib/extension/LabelExtensionTag.java

Violation Line
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 74
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 75
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 76
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 77
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 78
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 80
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 81
Avoid if (x != y) ..; else ..; 110114
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 119
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 173
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 182
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 191
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 201
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 205
Avoid if (x != y) ..; else ..; 206212
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 236

Tobago Core - org/apache/myfaces/tobago/internal/taglib/extension/MenuCheckboxExtensionTag.java

Violation Line
The class 'MenuCheckboxExtensionTag' has a Modified Cyclomatic Complexity of 2 (Highest = 15). 58339
The class 'MenuCheckboxExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 15). 58339
Too many fields 58339
The class 'MenuCheckboxExtensionTag' has a Standard Cyclomatic Complexity of 2 (Highest = 15). 58339
The method 'doStartTag' has a Modified Cyclomatic Complexity of 15. 78141
The method 'doStartTag' has a Standard Cyclomatic Complexity of 15. 78141
The method 'doStartTag' has a Cyclomatic Complexity of 15. 78141
The method doStartTag() has an NPath complexity of 16384 78141
Avoid if (x != y) ..; else ..; 151156
The String literal "boolean" appears 4 times in this file; the first occurrence is on line 252 252

Tobago Core - org/apache/myfaces/tobago/internal/taglib/extension/MenuRadioExtensionTag.java

Violation Line
The class 'MenuRadioExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 16). 62361
The class 'MenuRadioExtensionTag' has a Modified Cyclomatic Complexity of 2 (Highest = 16). 62361
The class 'MenuRadioExtensionTag' has a Standard Cyclomatic Complexity of 2 (Highest = 16). 62361
Too many fields 62361
The method 'doStartTag' has a Modified Cyclomatic Complexity of 16. 84150
The method 'doStartTag' has a Cyclomatic Complexity of 16. 84150
The method 'doStartTag' has a Standard Cyclomatic Complexity of 16. 84150
The method doStartTag() has an NPath complexity of 32768 84150
Avoid if (x != y) ..; else ..; 160165
The String literal "boolean" appears 4 times in this file; the first occurrence is on line 258 258

Tobago Core - org/apache/myfaces/tobago/internal/taglib/extension/OutExtensionTag.java

Violation Line
The class 'OutExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 12). 54249
The class 'OutExtensionTag' has a Standard Cyclomatic Complexity of 2 (Highest = 12). 54249
The class 'OutExtensionTag' has a Modified Cyclomatic Complexity of 2 (Highest = 12). 54249
The method 'doStartTag' has a Modified Cyclomatic Complexity of 12. 70118
The method 'doStartTag' has a Cyclomatic Complexity of 12. 70118
The method doStartTag() has an NPath complexity of 2048 70118
The method 'doStartTag' has a Standard Cyclomatic Complexity of 12. 70118

Tobago Core - org/apache/myfaces/tobago/internal/taglib/extension/SelectBooleanCheckboxExtensionTag.java

Violation Line
Possible God class (WMC=51, ATFD=31, TCC=0.13846153846153847) 20436
Too many fields 41436
The class 'SelectBooleanCheckboxExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 26). 41436
The class 'SelectBooleanCheckboxExtensionTag' has a Modified Cyclomatic Complexity of 2 (Highest = 26). 41436
The class 'SelectBooleanCheckboxExtensionTag' has a Standard Cyclomatic Complexity of 2 (Highest = 26). 41436
The method 'doStartTag' has a Modified Cyclomatic Complexity of 26. 70162
The method 'doStartTag' has a Standard Cyclomatic Complexity of 26. 70162
The method doStartTag() has an NPath complexity of 33554432 70162
The method 'doStartTag' has a Cyclomatic Complexity of 26. 70162
Avoid if (x != y) ..; else ..; 137141
The String literal "false" appears 4 times in this file; the first occurrence is on line 230 230
The String literal "boolean" appears 5 times in this file; the first occurrence is on line 230 230
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 268

Tobago Core - org/apache/myfaces/tobago/internal/taglib/extension/SelectManyCheckboxExtensionTag.java

Violation Line
Possible God class (WMC=53, ATFD=33, TCC=0.1339031339031339) 20454
The class 'SelectManyCheckboxExtensionTag' has a Modified Cyclomatic Complexity of 2 (Highest = 27). 40454
Too many fields 40454
The class 'SelectManyCheckboxExtensionTag' has a Standard Cyclomatic Complexity of 2 (Highest = 27). 40454
The class 'SelectManyCheckboxExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 27). 40454
The method 'doStartTag' has a Modified Cyclomatic Complexity of 27. 71168
The method 'doStartTag' has a Cyclomatic Complexity of 27. 71168
The method doStartTag() has an NPath complexity of 67108864 71168
The method 'doStartTag' has a Standard Cyclomatic Complexity of 27. 71168
The String literal "false" appears 5 times in this file; the first occurrence is on line 214 214
The String literal "boolean" appears 6 times in this file; the first occurrence is on line 214 214
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 294

Tobago Core - org/apache/myfaces/tobago/internal/taglib/extension/SelectManyListboxExtensionTag.java

Violation Line
Possible God class (WMC=49, ATFD=31, TCC=0.14333333333333334) 20419
The class 'SelectManyListboxExtensionTag' has a Standard Cyclomatic Complexity of 2 (Highest = 25). 40419
Too many fields 40419
The class 'SelectManyListboxExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 25). 40419
The class 'SelectManyListboxExtensionTag' has a Modified Cyclomatic Complexity of 2 (Highest = 25). 40419
The method doStartTag() has an NPath complexity of 16777216 68156
The method 'doStartTag' has a Standard Cyclomatic Complexity of 25. 68156
The method 'doStartTag' has a Modified Cyclomatic Complexity of 25. 68156
The method 'doStartTag' has a Cyclomatic Complexity of 25. 68156
The String literal "false" appears 4 times in this file; the first occurrence is on line 199 199
The String literal "boolean" appears 5 times in this file; the first occurrence is on line 199 199
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 272

Tobago Core - org/apache/myfaces/tobago/internal/taglib/extension/SelectManyShuttleExtensionTag.java

Violation Line
Possible God class (WMC=53, ATFD=33, TCC=0.1339031339031339) 20447
The class 'SelectManyShuttleExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 27). 39447
The class 'SelectManyShuttleExtensionTag' has a Modified Cyclomatic Complexity of 2 (Highest = 27). 39447
Too many fields 39447
The class 'SelectManyShuttleExtensionTag' has a Standard Cyclomatic Complexity of 2 (Highest = 27). 39447
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 41
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 42
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 44
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 45
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 46
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 47
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 49
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 50
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 51
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 52
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 53
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 54
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 56
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 57
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 58
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 59
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 60
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 61
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 62
The method 'doStartTag' has a Standard Cyclomatic Complexity of 27. 69163
The method 'doStartTag' has a Cyclomatic Complexity of 27. 69163
The method 'doStartTag' has a Modified Cyclomatic Complexity of 27. 69163
The method doStartTag() has an NPath complexity of 67108864 69163
The String literal "boolean" appears 5 times in this file; the first occurrence is on line 209 209
The String literal "false" appears 4 times in this file; the first occurrence is on line 209 209
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 210
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 219
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 245
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 254
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 263
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 273
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 282
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 291
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 300
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 330
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 340
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 350
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 359
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 370
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 380
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 386
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 395
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 404
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 413
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 422

Tobago Core - org/apache/myfaces/tobago/internal/taglib/extension/SelectOneChoiceExtensionTag.java

Violation Line
Possible God class (WMC=49, ATFD=30, TCC=0.14333333333333334) 20419
Too many fields 41419
The class 'SelectOneChoiceExtensionTag' has a Standard Cyclomatic Complexity of 2 (Highest = 25). 41419
The class 'SelectOneChoiceExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 25). 41419
The class 'SelectOneChoiceExtensionTag' has a Modified Cyclomatic Complexity of 2 (Highest = 25). 41419
The method 'doStartTag' has a Cyclomatic Complexity of 25. 69156
The method 'doStartTag' has a Standard Cyclomatic Complexity of 25. 69156
The method doStartTag() has an NPath complexity of 16777216 69156
The method 'doStartTag' has a Modified Cyclomatic Complexity of 25. 69156
The String literal "boolean" appears 5 times in this file; the first occurrence is on line 199 199
The String literal "false" appears 4 times in this file; the first occurrence is on line 199 199
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 302

Tobago Core - org/apache/myfaces/tobago/internal/taglib/extension/SelectOneListboxExtensionTag.java

Violation Line
Possible God class (WMC=49, ATFD=31, TCC=0.14333333333333334) 20423
The class 'SelectOneListboxExtensionTag' has a Modified Cyclomatic Complexity of 2 (Highest = 25). 40423
The class 'SelectOneListboxExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 25). 40423
The class 'SelectOneListboxExtensionTag' has a Standard Cyclomatic Complexity of 2 (Highest = 25). 40423
Too many fields 40423
The method 'doStartTag' has a Modified Cyclomatic Complexity of 25. 68159
The method doStartTag() has an NPath complexity of 16777216 68159
The method 'doStartTag' has a Cyclomatic Complexity of 25. 68159
The method 'doStartTag' has a Standard Cyclomatic Complexity of 25. 68159
The String literal "boolean" appears 5 times in this file; the first occurrence is on line 203 203
The String literal "false" appears 4 times in this file; the first occurrence is on line 203 203
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 276

Tobago Core - org/apache/myfaces/tobago/internal/taglib/extension/SelectOneRadioExtensionTag.java

Violation Line
Possible God class (WMC=53, ATFD=32, TCC=0.1339031339031339) 20448
The class 'SelectOneRadioExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 27). 42448
Too many fields 42448
The class 'SelectOneRadioExtensionTag' has a Modified Cyclomatic Complexity of 2 (Highest = 27). 42448
The class 'SelectOneRadioExtensionTag' has a Standard Cyclomatic Complexity of 2 (Highest = 27). 42448
The method 'doStartTag' has a Standard Cyclomatic Complexity of 27. 72166
The method doStartTag() has an NPath complexity of 67108864 72166
The method 'doStartTag' has a Modified Cyclomatic Complexity of 27. 72166
The method 'doStartTag' has a Cyclomatic Complexity of 27. 72166
The String literal "false" appears 5 times in this file; the first occurrence is on line 211 211
The String literal "boolean" appears 6 times in this file; the first occurrence is on line 211 211
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 322

Tobago Core - org/apache/myfaces/tobago/internal/taglib/extension/TextareaExtensionTag.java

Violation Line
Possible God class (WMC=49, ATFD=31, TCC=0.14333333333333334) 20434
The class 'TextareaExtensionTag' has a Standard Cyclomatic Complexity of 2 (Highest = 25). 55434
The class 'TextareaExtensionTag' has a Modified Cyclomatic Complexity of 2 (Highest = 25). 55434
The class 'TextareaExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 25). 55434
Too many fields 55434
The method 'doStartTag' has a Modified Cyclomatic Complexity of 25. 83171
The method 'doStartTag' has a Cyclomatic Complexity of 25. 83171
The method doStartTag() has an NPath complexity of 16777216 83171
The method 'doStartTag' has a Standard Cyclomatic Complexity of 25. 83171
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 249
The String literal "boolean" appears 5 times in this file; the first occurrence is on line 257 257
The String literal "false" appears 4 times in this file; the first occurrence is on line 257 257

Tobago Core - org/apache/myfaces/tobago/internal/taglib/extension/TimeExtensionTag.java

Violation Line
Possible God class (WMC=48, ATFD=29, TCC=0.14) 20432
The class 'TimeExtensionTag' has a Cyclomatic Complexity of 2 (Highest = 24). 54432
The class 'TimeExtensionTag' has a Standard Cyclomatic Complexity of 2 (Highest = 24). 54432
The class 'TimeExtensionTag' has a Modified Cyclomatic Complexity of 2 (Highest = 24). 54432
Too many fields 54432
Avoid unused private fields such as 'converter'. 57
The method 'doStartTag' has a Cyclomatic Complexity of 24. 82169
The method doStartTag() has an NPath complexity of 8388608 82169
The method 'doStartTag' has a Modified Cyclomatic Complexity of 24. 82169
The method 'doStartTag' has a Standard Cyclomatic Complexity of 24. 82169
Unnecessary use of fully qualified name 'javax.el.ValueExpression' due to existing import 'javax.el.ValueExpression' 257
The String literal "false" appears 4 times in this file; the first occurrence is on line 265 265
The String literal "boolean" appears 5 times in this file; the first occurrence is on line 265 265

Tobago Core - org/apache/myfaces/tobago/internal/util/AccessKeyLogger.java

Violation Line
Parameter 'clientId' is not assigned and could be declared final 55
Local variable 'entry' could be declared final 76

Tobago Core - org/apache/myfaces/tobago/internal/util/ArrayUtils.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2234

Tobago Core - org/apache/myfaces/tobago/internal/util/Deprecation.java

Violation Line
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 49

Tobago Core - org/apache/myfaces/tobago/internal/util/FacesContextUtils.java

Violation Line
This class has too many methods, consider refactoring it. 33280

Tobago Core - org/apache/myfaces/tobago/internal/util/FastStringWriter.java

Violation Line
StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 27

Tobago Core - org/apache/myfaces/tobago/internal/util/FindComponentUtils.java

Violation Line
Parameter 'from' is not assigned and could be declared final 41
Parameter 'relativeId' is not assigned and could be declared final 41

Tobago Core - org/apache/myfaces/tobago/internal/util/HtmlWriterUtils.java

Violation Line
The class 'HtmlWriterUtils' has a Modified Cyclomatic Complexity of 7 (Highest = 10). 25124
The class 'HtmlWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14). 25124
The class 'HtmlWriterUtils' has a Standard Cyclomatic Complexity of 7 (Highest = 10). 25124
The method 'writeEncodedValue' has a Cyclomatic Complexity of 14. 62123
The method 'writeEncodedValue' has a Modified Cyclomatic Complexity of 10. 62123
The method 'writeEncodedValue' has a Standard Cyclomatic Complexity of 10. 62123
Avoid if (x != y) ..; else ..; 9599

Tobago Core - org/apache/myfaces/tobago/internal/util/JavascriptWriterUtils.java

Violation Line
The class 'JavascriptWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14). 25120
The class 'JavascriptWriterUtils' has a Modified Cyclomatic Complexity of 7 (Highest = 10). 25120
The class 'JavascriptWriterUtils' has a Standard Cyclomatic Complexity of 7 (Highest = 10). 25120
The method 'writeEncodedValue' has a Modified Cyclomatic Complexity of 10. 58119
The method 'writeEncodedValue' has a Standard Cyclomatic Complexity of 10. 58119
The method 'writeEncodedValue' has a Cyclomatic Complexity of 14. 58119
Avoid if (x != y) ..; else ..; 9195

Tobago Core - org/apache/myfaces/tobago/internal/util/JndiUtils.java

Violation Line
Prefer StringBuffer over += for concatenating strings 57

Tobago Core - org/apache/myfaces/tobago/internal/util/JsonWriterUtils.java

Violation Line
The class 'JsonWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14). 26125
The class 'JsonWriterUtils' has a Modified Cyclomatic Complexity of 7 (Highest = 10). 26125
The class 'JsonWriterUtils' has a Standard Cyclomatic Complexity of 7 (Highest = 10). 26125
The method 'writeEncodedValue' has a Cyclomatic Complexity of 14. 63124
The method 'writeEncodedValue' has a Standard Cyclomatic Complexity of 10. 63124
The method 'writeEncodedValue' has a Modified Cyclomatic Complexity of 10. 63124
Avoid if (x != y) ..; else ..; 96100

Tobago Core - org/apache/myfaces/tobago/internal/util/MimeTypeUtils.java

Violation Line
The class 'MimeTypeUtils' has a Standard Cyclomatic Complexity of 7 (Highest = 18). 2799
The class 'MimeTypeUtils' has a Cyclomatic Complexity of 7 (Highest = 18). 2799
The class 'MimeTypeUtils' has a Modified Cyclomatic Complexity of 7 (Highest = 18). 2799
Avoid using redundant field initializer for 'additionalMimeTypes' 29
The method 'getMimeTypeForFile' has a Modified Cyclomatic Complexity of 18. 3689
The method 'getMimeTypeForFile' has a Cyclomatic Complexity of 18. 3689
The method 'getMimeTypeForFile' has a Standard Cyclomatic Complexity of 18. 3689
Local variable 'length' could be declared final 37
Local variable 'extension' could be declared final 84
Parameter 'servletContext' is not assigned and could be declared final 91
Singleton is not thread safe 9297

Tobago Core - org/apache/myfaces/tobago/internal/util/NumberUtils.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2234

Tobago Core - org/apache/myfaces/tobago/internal/util/ObjectUtils.java

Violation Line
A class which only has private constructors should be final 2232
Parameter 'o1' is not assigned and could be declared final 29
Parameter 'o2' is not assigned and could be declared final 29
Use equals() to compare object references. 30

Tobago Core - org/apache/myfaces/tobago/internal/util/ResponseUtils.java

Violation Line
The class 'ResponseUtils' has a Cyclomatic Complexity of 3 (Highest = 10). 33145
Avoid if (x != y) ..; else ..; 7283
The method 'ensureContentSecurityPolicyHeader' has a Cyclomatic Complexity of 10. 97132
Avoid declaring a variable if it is unreferenced before a possible exit point. 101
Avoid appending characters as strings in StringBuffer.append. 120
These nested if statements could be combined 128130

Tobago Core - org/apache/myfaces/tobago/internal/util/ResponseWriterBuffer.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 62

Tobago Core - org/apache/myfaces/tobago/internal/util/StringUtils.java

Violation Line
Possible God class (WMC=107, ATFD=9, TCC=0.0) 20485
The class 'StringUtils' has a Standard Cyclomatic Complexity of 4 (Highest = 18). 27485
The class 'StringUtils' has a Cyclomatic Complexity of 4 (Highest = 18). 27485
The class 'StringUtils' has a Modified Cyclomatic Complexity of 4 (Highest = 18). 27485
This class has too many methods, consider refactoring it. 27485
Avoid instantiating Integer objects. Call Integer.valueOf() instead. 45
Avoid instantiating new objects inside loops 45
Avoid appending characters as strings in StringBuffer.append. 57
The method 'equalsIgnoreCaseAndWhitespace' has a Modified Cyclomatic Complexity of 11. 113167
The method 'equalsIgnoreCaseAndWhitespace' has a Standard Cyclomatic Complexity of 11. 113167
The method 'equalsIgnoreCaseAndWhitespace' has a Cyclomatic Complexity of 14. 113167
The method equalsIgnoreCaseAndWhitespace() has an NPath complexity of 378 113167
Use equals() to compare object references. 116
The method 'split' has a Cyclomatic Complexity of 18. 221296
The method 'split' has a Modified Cyclomatic Complexity of 18. 221296
The method 'split' has a Standard Cyclomatic Complexity of 18. 221296
Avoid declaring a variable if it is unreferenced before a possible exit point. 222
The method replace() has an NPath complexity of 1080 357382
The method 'replace' has a Cyclomatic Complexity of 10. 357382
Avoid declaring a variable if it is unreferenced before a possible exit point. 358
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 371
No need to call String.valueOf to append to a string. 413
Parameter 'b' is not assigned and could be declared final 463
Parameter 'a' is not assigned and could be declared final 463
Local variable 'colon' could be declared final 474

Tobago Core - org/apache/myfaces/tobago/internal/webapp/DebugContentTypeFilter.java

Violation Line
Document empty method 5860

Tobago Core - org/apache/myfaces/tobago/internal/webapp/DebugContentTypeResponse.java

Violation Line
These nested if statements could be combined 5557
These nested if statements could be combined 6567

Tobago Core - org/apache/myfaces/tobago/internal/webapp/DebugResponseWriterWrapper.java

Violation Line
This class has too many methods, consider refactoring it. 37188
Private field 'stack' could be made final; it is only initialized in the declaration or constructor. 39

Tobago Core - org/apache/myfaces/tobago/internal/webapp/HtmlResponseWriter.java

Violation Line
This class has too many methods, consider refactoring it. 39183
Private field 'javascriptWriter' could be made final; it is only initialized in the declaration or constructor. 45
Avoid reassigning parameters such as 'styles' 149

Tobago Core - org/apache/myfaces/tobago/internal/webapp/JsonResponseWriter.java

Violation Line
This class has too many methods, consider refactoring it. 34191
Private field 'javascriptWriter' could be made final; it is only initialized in the declaration or constructor. 38
Private field 'encodeInJavascriptBlock' could be made final; it is only initialized in the declaration or constructor. 40
Private field 'encodeOutsideJavascriptBlock' could be made final; it is only initialized in the declaration or constructor. 41
Consider using varargs for methods or constructors which take an array the last parameter. 75
Document empty method 185186
Document empty method 189190

Tobago Core - org/apache/myfaces/tobago/internal/webapp/TobagoMultipartFormdataRequest.java

Violation Line
The class 'TobagoMultipartFormdataRequest' has a Modified Cyclomatic Complexity of 3 (Highest = 13). 43200
The class 'TobagoMultipartFormdataRequest' has a Cyclomatic Complexity of 3 (Highest = 13). 43200
The class 'TobagoMultipartFormdataRequest' has a Standard Cyclomatic Complexity of 3 (Highest = 13). 43200
The method 'init' has a Standard Cyclomatic Complexity of 13. 65134
The method init() has an NPath complexity of 401 65134
The method 'init' has a Cyclomatic Complexity of 13. 65134
The method 'init' has a Modified Cyclomatic Complexity of 13. 65134
Avoid if (x != y) ..; else ..; 66133

Tobago Core - org/apache/myfaces/tobago/internal/webapp/TobagoResponseWriterBase.java

Violation Line
Possible God class (WMC=49, ATFD=12, TCC=0.07142857142857142) 20330
This class has too many methods, consider refactoring it. 36329
Avoid if (x != y) ..; else ..; 75
Avoid if (x != y) ..; else ..; 99126
Avoid if (x != y) ..; else ..; 101126
Avoid if (x != y) ..; else ..; 102117
Avoid if (x != y) ..; else ..; 104108
Consider using varargs for methods or constructors which take an array the last parameter. 151
An empty method in an abstract class should be abstract instead 189191
An empty method in an abstract class should be abstract instead 193195

Tobago Core - org/apache/myfaces/tobago/internal/webapp/TobagoResponseWriterWrapper.java

Violation Line
This class has too many methods, consider refactoring it. 32125
Private field 'responseWriter' could be made final; it is only initialized in the declaration or constructor. 34

Tobago Core - org/apache/myfaces/tobago/layout/LayoutTokens.java

Violation Line
The class 'LayoutTokens' has a Cyclomatic Complexity of 2 (Highest = 10). 31170
This class has too many methods, consider refactoring it. 31170
Private field 'tokens' could be made final; it is only initialized in the declaration or constructor. 35
Document empty constructor 3738
Consider using varargs for methods or constructors which take an array the last parameter. 80
The method 'parseToken' has a Cyclomatic Complexity of 10. 114139
Avoid appending characters as strings in StringBuffer.append. 165

Tobago Core - org/apache/myfaces/tobago/layout/Measure.java

Violation Line
Possible God class (WMC=51, ATFD=9, TCC=0.008333333333333333) 20203
This class has too many methods, consider refactoring it. 32203
Avoid unused private fields such as 'LOG'. 36
Avoid if (x != y) ..; else ..; 186190
Avoid if (x != y) ..; else ..; 189
Avoid if (x != y) ..; else ..; 197201
Avoid if (x != y) ..; else ..; 200

Tobago Core - org/apache/myfaces/tobago/layout/PercentLayoutToken.java

Violation Line
Avoid using redundant field initializer for 'percent' 26
Private field 'percent' could be made final; it is only initialized in the declaration or constructor. 26

Tobago Core - org/apache/myfaces/tobago/layout/PixelMeasure.java

Violation Line
This class has too many methods, consider refactoring it. 25131
Avoid instantiating new objects inside loops 35
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 39

Tobago Core - org/apache/myfaces/tobago/layout/RelativeLayoutToken.java

Violation Line
Private field 'factor' could be made final; it is only initialized in the declaration or constructor. 29

Tobago Core - org/apache/myfaces/tobago/layout/TextAlign.java

Violation Line
Avoid if (x != y) ..; else ..; 6468

Tobago Core - org/apache/myfaces/tobago/lifecycle/SecretPhaseListener.java

Violation Line
Document empty method 4950

Tobago Core - org/apache/myfaces/tobago/model/CalendarModel.java

Violation Line
Private field 'calendarArray' could be made final; it is only initialized in the declaration or constructor. 28
Private field 'firstDayOffset' could be made final; it is only initialized in the declaration or constructor. 29
Avoid instantiating new objects inside loops 43
Avoid appending characters as strings in StringBuffer.append. 77
When instantiating a SimpleDateFormat object, specify a Locale 80
Avoid appending characters as strings in StringBuffer.append. 84
Avoid appending characters as strings in StringBuffer.append. 86
Avoid appending characters as strings in StringBuffer.append. 90
Avoid appending characters as strings in StringBuffer.append. 92

Tobago Core - org/apache/myfaces/tobago/model/DateModel.java

Violation Line
Avoid if (x != y) ..; else ..; 7273

Tobago Core - org/apache/myfaces/tobago/model/ExpandedState.java

Violation Line
Private field 'expandedSet' could be made final; it is only initialized in the declaration or constructor. 37
Private field 'collapsedSet' could be made final; it is only initialized in the declaration or constructor. 38
Avoid reassigning parameters such as 'level' 164

Tobago Core - org/apache/myfaces/tobago/model/MixedTreeModel.java

Violation Line
Private field 'junctions' could be made final; it is only initialized in the declaration or constructor. 39

Tobago Core - org/apache/myfaces/tobago/model/SelectItem.java

Violation Line
Avoid using redundant field initializer for 'currentMarkup' 31
Consider using varargs for methods or constructors which take an array the last parameter. 58
Consider using varargs for methods or constructors which take an array the last parameter. 77
Parameter 'tip' is not assigned and could be declared final 99

Tobago Core - org/apache/myfaces/tobago/model/Selectable.java

Violation Line
Avoid if (x != y) ..; else ..; 127131

Tobago Core - org/apache/myfaces/tobago/model/SelectedState.java

Violation Line
Private field 'selected' could be made final; it is only initialized in the declaration or constructor. 32

Tobago Core - org/apache/myfaces/tobago/model/SheetState.java

Violation Line
Overridable method 'reset' called during object construction 51
Consider using varargs for methods or constructors which take an array the last parameter. 137
Parameter 'toBeSorted' is not assigned and could be declared final 167
String.indexOf(char) is faster than String.indexOf(String). 178
Do not add empty strings 180

Tobago Core - org/apache/myfaces/tobago/model/SuggestFilter.java

Violation Line
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 40

Tobago Core - org/apache/myfaces/tobago/model/TreeNodeDataModel.java

Violation Line
Possible God class (WMC=57, ATFD=27, TCC=0.10666666666666667) 20300
Private field 'mapping' could be made final; it is only initialized in the declaration or constructor. 43
Private field 'back' could be made final; it is only initialized in the declaration or constructor. 44
Private field 'showRoot' could be made final; it is only initialized in the declaration or constructor. 45
Overridable method 'reset' called during object construction 59
Avoid instantiation through private constructors from outside of the constructors class. 69
Avoid instantiating new objects inside loops 69
Avoid instantiating new objects inside loops 89
Avoid instantiation through private constructors from outside of the constructors class. 89
Avoid reassigning parameters such as 'node' 103
Avoid instantiating new objects inside loops 208
Avoid if (x != y) ..; else ..; 235239
Private field 'node' could be made final; it is only initialized in the declaration or constructor. 281

Tobago Core - org/apache/myfaces/tobago/model/TreePath.java

Violation Line
Avoid reassigning parameters such as 'node' 90
Avoid appending characters as strings in StringBuffer.append. 129
Avoid appending characters as strings in StringBuffer.append. 142
Avoid reassigning parameters such as 'tree' 156
Avoid if (x != y) ..; else ..; 185

Tobago Core - org/apache/myfaces/tobago/model/TreeSelectable.java

Violation Line
Avoid if (x != y) ..; else ..; 7074

Tobago Core - org/apache/myfaces/tobago/model/TreeState.java

Violation Line
Private field 'expandedState' could be made final; it is only initialized in the declaration or constructor. 26
Private field 'selectedState' could be made final; it is only initialized in the declaration or constructor. 27

Tobago Core - org/apache/myfaces/tobago/model/Wizard.java

Violation Line
Overridable method 'reset' called during object construction 38

Tobago Core - org/apache/myfaces/tobago/model/WizardStep.java

Violation Line
StringBuffer constructor is initialized with size 16, but has at least 21 characters appended. 57
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 58
Avoid appending characters as strings in StringBuffer.append. 58
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 59
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 60
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 61
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 62
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 63
Avoid appending characters as strings in StringBuffer.append. 64

Tobago Core - org/apache/myfaces/tobago/renderkit/AbstractRendererBaseWrapper.java

Violation Line
Avoid unused private fields such as 'LOG'. 35

Tobago Core - org/apache/myfaces/tobago/renderkit/HtmlUtils.java

Violation Line
Avoid if (x != y) ..; else ..; 5960

Tobago Core - org/apache/myfaces/tobago/renderkit/InputRendererBase.java

Violation Line
Local variable 'textarea' could be declared final 63

Tobago Core - org/apache/myfaces/tobago/renderkit/LabelWithAccessKey.java

Violation Line
The class 'LabelWithAccessKey' has a Standard Cyclomatic Complexity of 2 (Highest = 14). 32218
The class 'LabelWithAccessKey' has a Modified Cyclomatic Complexity of 2 (Highest = 14). 32218
The class 'LabelWithAccessKey' has a Cyclomatic Complexity of 3 (Highest = 17). 32218
Avoid unused private fields such as 'ESCAPED_INDICATOR'. 37
The constructor 'LabelWithAccessKey' has a Cyclomatic Complexity of 17. 59132
The constructor 'LabelWithAccessKey' has a Standard Cyclomatic Complexity of 14. 59132
The constructor 'LabelWithAccessKey' has a Modified Cyclomatic Complexity of 14. 59132
Local variable 'auto' could be declared final 84
These nested if statements could be combined 101109
Deeply nested if..then statements are hard to read 101109
Parameter 'accessKey' is not assigned and could be declared final 207

Tobago Core - org/apache/myfaces/tobago/renderkit/LayoutComponentRendererBase.java

Violation Line
Avoid if (x != y) ..; else ..; 118122

Tobago Core - org/apache/myfaces/tobago/renderkit/RendererBase.java

Violation Line
Document empty method 6768
Avoid if (x != y) ..; else ..; 180184
Document empty method 188189
Use block level rather than method level synchronization 191196

Tobago Core - org/apache/myfaces/tobago/renderkit/RendererBaseWrapper.java

Violation Line
Private field 'renderer' could be made final; it is only initialized in the declaration or constructor. 29
Document empty method 3536

Tobago Core - org/apache/myfaces/tobago/renderkit/SelectManyRendererBase.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20799
Possible God class (WMC=117, ATFD=71, TCC=0.0) 20799
The class 'SelectManyRendererBase' has a Standard Cyclomatic Complexity of 6 (Highest = 28). 56799
The class 'SelectManyRendererBase' has a Modified Cyclomatic Complexity of 6 (Highest = 28). 56799
The class 'SelectManyRendererBase' has a Cyclomatic Complexity of 6 (Highest = 31). 56799
Avoid if (x != y) ..; else ..; 72
Deeply nested if..then statements are hard to read 7377
Parameter 'input' is not assigned and could be declared final 87
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 118
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 119
Parameter 'component' is not assigned and could be declared final 121
Parameter 'facesContext' is not assigned and could be declared final 121
Consider using varargs for methods or constructors which take an array the last parameter. 122
Parameter 'submittedValue' is not assigned and could be declared final 122
The method 'getConvertedUISelectManyValue' has a Standard Cyclomatic Complexity of 28. 139315
The method 'getConvertedUISelectManyValue' has a Cyclomatic Complexity of 31. 139315
The method 'getConvertedUISelectManyValue' has a Modified Cyclomatic Complexity of 28. 139315
The method getConvertedUISelectManyValue() has an NPath complexity of 2760 139315
Parameter 'facesContext' is not assigned and could be declared final 139
Parameter 'component' is not assigned and could be declared final 139
Avoid really long methods. 139315
Parameter 'submittedValue' is not assigned and could be declared final 140
Parameter 'considerValueType' is not assigned and could be declared final 140
Local variable 'expression' could be declared final 149
Avoid if (x != y) ..; else ..; 160292
Local variable 'modelType' could be declared final 161162
Local variable 'componentType' could be declared final 168
Local variable 'iterator' could be declared final 198
Local variable 'collectionTypeAttr' could be declared final 202203
Avoid if (x != y) ..; else ..; 204284
Local variable 'collectionType' could be declared final 205
Local variable 'componentValue' could be declared final 233234
Local variable 'cloneMethod' could be declared final 239240
Local variable 'clone' could be declared final 241242
Avoid if (x != y) ..; else ..; 255257
Local variable 'isArray' could be declared final 296
Avoid if (x != y) ..; else ..; 300305
Parameter 'facesContext' is not assigned and could be declared final 328
Avoid reassigning parameters such as 'attribute' 329
Parameter 'facesContext' is not assigned and could be declared final 369
Parameter 'component' is not assigned and could be declared final 369
Local variable 'valueTypeAttr' could be declared final 372
Local variable 'valueType' could be declared final 375
Parameter 'iterator' is not assigned and could be declared final 409
Parameter 'facesContext' is not assigned and could be declared final 409
Local variable 'item' could be declared final 416
Local variable 'groupIterator' could be declared final 418419
Local variable 'selectItemsType' could be declared final 422
Parameter 'component' is not assigned and could be declared final 447
Local variable 'buf' could be declared final 448
The String literal "{Component-Path : " appears 4 times in this file; the first occurrence is on line 451 451
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 451
Avoid appending characters as strings in StringBuffer.append. 459
Parameter 'buf' is not assigned and could be declared final 464
Parameter 'component' is not assigned and could be declared final 464
Local variable 'intBuf' could be declared final 469
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 471
Avoid appending characters as strings in StringBuffer.append. 480
The class 'SelectItemsIterator' has a Cyclomatic Complexity of 6 (Highest = 27). 495771
The class 'SelectItemsIterator' has a Standard Cyclomatic Complexity of 6 (Highest = 23). 495771
The class 'SelectItemsIterator' has a Modified Cyclomatic Complexity of 6 (Highest = 23). 495771
Private field 'facesContext' could be made final; it is only initialized in the declaration or constructor. 513
Parameter 'selectItemsParent' is not assigned and could be declared final 515
Parameter 'facesContext' is not assigned and could be declared final 515
Avoid really long methods. 523633
The method hasNext() has an NPath complexity of 1662 523633
The method 'hasNext' has a Modified Cyclomatic Complexity of 23. 523633
The method 'hasNext' has a Standard Cyclomatic Complexity of 23. 523633
The method 'hasNext' has a Cyclomatic Complexity of 27. 523633
Local variable 'uiSelectItem' could be declared final 554
Local variable 'itemValue' could be declared final 558
Local variable 'description' could be declared final 560
Local variable 'disabled' could be declared final 561
Local variable 'escape' could be declared final 562
Local variable 'noSelectionOption' could be declared final 563
Local variable 'expression' could be declared final 569
Local variable 'value' could be declared final 579
Local variable 'length' could be declared final 588
Local variable 'items' could be declared final 589
Local variable 'map' could be declared final 600
Local variable 'items' could be declared final 601
Local variable 'entry' could be declared final 602
Avoid instantiating new objects inside loops 603
Local variable 'expression' could be declared final 612
Local variable 'objects' could be declared final 613617
Local variable 'message' could be declared final 618620
The method 'next' has a Modified Cyclomatic Complexity of 11. 635708
The method 'next' has a Cyclomatic Complexity of 12. 635708
The method 'next' has a Standard Cyclomatic Complexity of 11. 635708
The method next() has an NPath complexity of 296 635708
Local variable 'value' could be declared final 640
Local variable 'attributeMap' could be declared final 651
Local variable 'var' could be declared final 656
Local variable 'itemDisabled' could be declared final 683
Local variable 'itemLabelEscaped' could be declared final 684
Local variable 'noSelectionValue' could be declared final 685
Avoid if (x != y) ..; else ..; 696702
Parameter 'attrName' is not assigned and could be declared final 718
Parameter 'component' is not assigned and could be declared final 718
Parameter 'defaultValue' is not assigned and could be declared final 718
Local variable 'value' could be declared final 719
Parameter 'component' is not assigned and could be declared final 732
Local variable 'buf' could be declared final 733
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 736
Avoid appending characters as strings in StringBuffer.append. 744
Parameter 'component' is not assigned and could be declared final 749
Parameter 'buf' is not assigned and could be declared final 749
Local variable 'intBuf' could be declared final 754
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 756
Avoid appending characters as strings in StringBuffer.append. 765

Tobago Core - org/apache/myfaces/tobago/renderkit/TobagoRenderKit.java

Violation Line
The class 'TobagoRenderKit' has a Standard Cyclomatic Complexity of 3 (Highest = 10). 48195
The class 'TobagoRenderKit' has a Cyclomatic Complexity of 4 (Highest = 13). 48195
The class 'TobagoRenderKit' has a Modified Cyclomatic Complexity of 3 (Highest = 10). 48195
Private field 'renderers' could be made final; it is only initialized in the declaration or constructor. 56
Avoid instantiation through private constructors from outside of the constructors class. 66
The method 'createResponseWriter' has a Cyclomatic Complexity of 13. 93142
The method createResponseWriter() has an NPath complexity of 400 93142
The method 'createResponseWriter' has a Standard Cyclomatic Complexity of 10. 93142
The method 'createResponseWriter' has a Modified Cyclomatic Complexity of 10. 93142
Avoid declaring a variable if it is unreferenced before a possible exit point. 95
The String literal "text/html" appears 5 times in this file; the first occurrence is on line 101 101
Avoid instantiation through private constructors from outside of the constructors class. 146

Tobago Core - org/apache/myfaces/tobago/renderkit/css/Classes.java

Violation Line
Use block level rather than method level synchronization 86101
Avoid if (x != y) ..; else ..; 108
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 109
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 119

Tobago Core - org/apache/myfaces/tobago/renderkit/css/Style.java

Violation Line
Possible God class (WMC=101, ATFD=48, TCC=0.10638297872340426) 20556
This class has a bunch of public methods and attributes 20556
The class 'Style' has a Cyclomatic Complexity of 2 (Highest = 24). 33556
The class 'Style' has a Modified Cyclomatic Complexity of 2 (Highest = 24). 33556
The class 'Style' has a Standard Cyclomatic Complexity of 2 (Highest = 24). 33556
Too many fields 33556
Document empty constructor 6061
The constructor 'Style' has a Cyclomatic Complexity of 10. 88133
Overridable method 'getDisplay' called during object construction 126
The method 'encode' has a Modified Cyclomatic Complexity of 23. 144258
The method 'encode' has a Cyclomatic Complexity of 23. 144258
The method encode() has an NPath complexity of 4194304 144258
Avoid really long methods. 144258
The method 'encode' has a Standard Cyclomatic Complexity of 23. 144258
StringBuffer constructor is initialized with size 16, but has at least 22 characters appended. 145
Avoid really long methods. 260379
The method 'encodeJson' has a Standard Cyclomatic Complexity of 24. 260379
The method encodeJson() has an NPath complexity of 8388608 260379
The method 'encodeJson' has a Cyclomatic Complexity of 24. 260379
The method 'encodeJson' has a Modified Cyclomatic Complexity of 24. 260379
StringBuffer constructor is initialized with size 17, but has at least 66 characters appended. 261
The String literal "\"," appears 21 times in this file; the first occurrence is on line 265 265
Avoid appending characters as strings in StringBuffer.append. 365
Parameter 'backgroundPosition' is not assigned and could be declared final 537

Tobago Core - org/apache/myfaces/tobago/renderkit/util/EncodeUtils.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3053

Tobago Core - org/apache/myfaces/tobago/sanitizer/IgnoringSanitizer.java

Violation Line
Parameter 'html' is not assigned and could be declared final 34
Parameter 'configuration' is not assigned and could be declared final 38

Tobago Core - org/apache/myfaces/tobago/sanitizer/JsoupSanitizer.java

Violation Line
Avoid using redundant field initializer for 'unmodifiable' 40
Local variable 'key' could be declared final 58

Tobago Core - org/apache/myfaces/tobago/servlet/NonFacesRequestServlet.java

Violation Line
Avoid declaring a variable if it is unreferenced before a possible exit point. 61
An empty method in an abstract class should be abstract instead 9597

Tobago Core - org/apache/myfaces/tobago/servlet/ResourceServlet.java

Violation Line
The class 'ResourceServlet' has a Cyclomatic Complexity of 4 (Highest = 10). 69200
Private field 'resourceDirs' could be made final; it is only initialized in the declaration or constructor. 77
Avoid instantiating Long objects.Call Long.valueOf() instead 94
This call to String.startsWith can be rewritten using String.charAt(0) 119
The method 'doGet' has a Cyclomatic Complexity of 10. 127182
Avoid if (x != y) ..; else ..; 149158
Avoid if (x != y) ..; else ..; 172178
Avoid if (x != y) ..; else ..; 186190

Tobago Core - org/apache/myfaces/tobago/util/ApplyRequestValuesCallback.java

Violation Line
The class 'ApplyRequestValuesCallback' has a Cyclomatic Complexity of 8 (Highest = 13). 3568
Avoid unused private fields such as 'LOG'. 38
The method 'invokeContextCallback' has a Cyclomatic Complexity of 13. 4063
Deeply nested if..then statements are hard to read 4958

Tobago Core - org/apache/myfaces/tobago/util/BeanComparator.java

Violation Line
Private field 'property' could be made final; it is only initialized in the declaration or constructor. 35
Avoid if (x != y) ..; else ..; 73

Tobago Core - org/apache/myfaces/tobago/util/BundleMapWrapper.java

Violation Line
This class has too many methods, consider refactoring it. 30109
Private field 'basename' could be made final; it is only initialized in the declaration or constructor. 32

Tobago Core - org/apache/myfaces/tobago/util/ComparatorBase.java

Violation Line
The class 'ComparatorBase' has a Standard Cyclomatic Complexity of 3 (Highest = 12). 27126
The class 'ComparatorBase' has a Cyclomatic Complexity of 3 (Highest = 14). 27126
The class 'ComparatorBase' has a Modified Cyclomatic Complexity of 3 (Highest = 12). 27126
Document empty constructor 3334
The method 'internalCompare' has a Modified Cyclomatic Complexity of 12. 4989
The method 'internalCompare' has a Standard Cyclomatic Complexity of 12. 4989
The method 'internalCompare' has a Cyclomatic Complexity of 14. 4989
The method internalCompare() has an NPath complexity of 1600 4989
Avoid if (x != y) ..; else ..; 7787
Avoid if (x != y) ..; else ..; 120

Tobago Core - org/apache/myfaces/tobago/util/ComponentUtils.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 201178
High amount of different objects as members denotes a high coupling 201178
Possible God class (WMC=239, ATFD=150, TCC=3.7023324694557573E-4) 201178
This class has a bunch of public methods and attributes 201178
The class 'ComponentUtils' has a Modified Cyclomatic Complexity of 3 (Highest = 10). 791178
The class 'ComponentUtils' has a Standard Cyclomatic Complexity of 3 (Highest = 10). 791178
Avoid really long classes. 791178
This class has too many methods, consider refactoring it. 791178
The class 'ComponentUtils' has a Cyclomatic Complexity of 3 (Highest = 10). 791178
Avoid reassigning parameters such as 'component' 140
Avoid if (x != y) ..; else ..; 163167
Avoid if (x != y) ..; else ..; 172182
Avoid reassigning parameters such as 'component' 185
Avoid reassigning parameters such as 'component' 219
Avoid reassigning parameters such as 'component' 229
Avoid if (x != y) ..; else ..; 287295
Avoid reassigning parameters such as 'component' 422
Consider simply returning the value vs storing it in local variable 'myRenderer' 626
Avoid reassigning parameters such as 'value' 714
String.trim().length()==0 is an inefficient way to validate an empty String. 889
The method 'findComponent' has a Cyclomatic Complexity of 10. 924959
Position literals first in String comparisons 929
These nested if statements could be combined 929931
Consider using varargs for methods or constructors which take an array the last parameter. 965
The method 'getConvertedValue' has a Cyclomatic Complexity of 10. 10031034
The method 'getConvertedValue' has a Standard Cyclomatic Complexity of 10. 10031034
The method 'getConvertedValue' has a Modified Cyclomatic Complexity of 10. 10031034
Avoid if (x != y) ..; else ..; 10071029
Avoid reassigning parameters such as 'markup' 1036
Avoid reassigning parameters such as 'markup' 1036
Avoid reassigning parameters such as 'markup' 1036
Avoid reassigning parameters such as 'markup' 1036
Avoid reassigning parameters such as 'markup' 1036
Local variable 'map' could be declared final 1165
Avoid if (x != y) ..; else ..; 1166

Tobago Core - org/apache/myfaces/tobago/util/CreateComponentUtils.java

Violation Line
This class has too many methods, consider refactoring it. 41179
Avoid if (x != y) ..; else ..; 131135
Avoid if (x != y) ..; else ..; 156161

Tobago Core - org/apache/myfaces/tobago/util/DebugNavigationHandler.java

Violation Line
Private field 'navigationHandler' could be made final; it is only initialized in the declaration or constructor. 33

Tobago Core - org/apache/myfaces/tobago/util/DebugPhaseListener.java

Violation Line
The class 'DebugPhaseListener' has a Modified Cyclomatic Complexity of 8 (Highest = 13). 39154
The class 'DebugPhaseListener' has a Standard Cyclomatic Complexity of 8 (Highest = 13). 39154
The class 'DebugPhaseListener' has a Cyclomatic Complexity of 10 (Highest = 16). 39154
The method 'afterPhase' has a Modified Cyclomatic Complexity of 10. 4591
The method 'afterPhase' has a Standard Cyclomatic Complexity of 10. 4591
The method 'afterPhase' has a Cyclomatic Complexity of 11. 4591
Deeply nested if..then statements are hard to read 6772
Deeply nested if..then statements are hard to read 7577
The method 'beforePhase' has a Standard Cyclomatic Complexity of 13. 93149
The method 'beforePhase' has a Cyclomatic Complexity of 16. 93149
The method 'beforePhase' has a Modified Cyclomatic Complexity of 13. 93149
The method beforePhase() has an NPath complexity of 572 93149
Avoid declaring a variable if it is unreferenced before a possible exit point. 95
Deeply nested if..then statements are hard to read 111127
Deeply nested if..then statements are hard to read 133143
Deeply nested if..then statements are hard to read 144146

Tobago Core - org/apache/myfaces/tobago/util/DebugUtils.java

Violation Line
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 59
Avoid appending characters as strings in StringBuffer.append. 82
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 82
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 83
Avoid appending characters as strings in StringBuffer.append. 84
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 84
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 92
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 93

Tobago Core - org/apache/myfaces/tobago/util/EncodeAjaxCallback.java

Violation Line
Deeply nested if..then statements are hard to read 4547

Tobago Core - org/apache/myfaces/tobago/util/LayoutInfo.java

Violation Line
The class 'LayoutInfo' has a Cyclomatic Complexity of 4 (Highest = 13). 39390
The class 'LayoutInfo' has a Modified Cyclomatic Complexity of 3 (Highest = 11). 39390
This class has too many methods, consider refactoring it. 39390
The class 'LayoutInfo' has a Standard Cyclomatic Complexity of 3 (Highest = 11). 39390
The String literal " clientId='" appears 17 times in this file; the first occurrence is on line 73 73
Avoid reassigning parameters such as 'space' 108
The method 'update' has a Cyclomatic Complexity of 10. 108143
Avoid reassigning parameters such as 'space' 108
These nested if statements could be combined 131137
Consider using varargs for methods or constructors which take an array the last parameter. 171
Consider using varargs for methods or constructors which take an array the last parameter. 179
Avoid appending characters as strings in StringBuffer.append. 183
Avoid appending characters as strings in StringBuffer.append. 188
The method handleSpaceLeft() has an NPath complexity of 330 216250
The method 'handleSpaceLeft' has a Cyclomatic Complexity of 13. 216250
The method 'handleSpaceLeft' has a Modified Cyclomatic Complexity of 11. 216250
The method 'handleSpaceLeft' has a Standard Cyclomatic Complexity of 11. 216250
Consider using varargs for methods or constructors which take an array the last parameter. 253
These nested if statements could be combined 279301
The String literal "set column " appears 5 times in this file; the first occurrence is on line 289 289
The String literal " from " appears 5 times in this file; the first occurrence is on line 289 289
The String literal " to with " appears 4 times in this file; the first occurrence is on line 290 290
The method 'parseColumnLayout' has a Cyclomatic Complexity of 12. 339379
The method 'parseColumnLayout' has a Modified Cyclomatic Complexity of 11. 339379
The method 'parseColumnLayout' has a Standard Cyclomatic Complexity of 11. 339379

Tobago Core - org/apache/myfaces/tobago/util/MessageUtils.java

Violation Line
The class 'MessageUtils' has a Cyclomatic Complexity of 4 (Highest = 15). 43160
The class 'MessageUtils' has a Standard Cyclomatic Complexity of 3 (Highest = 11). 43160
The class 'MessageUtils' has a Modified Cyclomatic Complexity of 3 (Highest = 11). 43160
Consider using varargs for methods or constructors which take an array the last parameter. 52
The method 'getMessage' has a Cyclomatic Complexity of 15. 57104
The method getMessage() has an NPath complexity of 468 57104
The method 'getMessage' has a Standard Cyclomatic Complexity of 11. 57104
The method 'getMessage' has a Modified Cyclomatic Complexity of 11. 57104
Deeply nested if..then statements are hard to read 7678
Deeply nested if..then statements are hard to read 7981
Avoid if (x != y) ..; else ..; 116

Tobago Core - org/apache/myfaces/tobago/util/RequestUtils.java

Violation Line
Do not add empty strings 53

Tobago Core - org/apache/myfaces/tobago/util/ValueBindingComparator.java

Violation Line
The class 'ValueBindingComparator' has a Modified Cyclomatic Complexity of 3 (Highest = 10). 34130
The class 'ValueBindingComparator' has a Standard Cyclomatic Complexity of 3 (Highest = 10). 34130
The class 'ValueBindingComparator' has a Cyclomatic Complexity of 3 (Highest = 11). 34130
Private field 'facesContext' could be made final; it is only initialized in the declaration or constructor. 38
Private field 'var' could be made final; it is only initialized in the declaration or constructor. 40
Private field 'valueBinding' could be made final; it is only initialized in the declaration or constructor. 42
The method 'equals' has a Standard Cyclomatic Complexity of 10. 76100
The method 'equals' has a Cyclomatic Complexity of 11. 76100
The method 'equals' has a Modified Cyclomatic Complexity of 10. 76100
Avoid declaring a variable if it is unreferenced before a possible exit point. 84
Avoid if (x != y) ..; else ..; 89
Avoid if (x != y) ..; else ..; 92
Avoid if (x != y) ..; else ..; 95
Avoid if (x != y) ..; else ..; 104
Avoid if (x != y) ..; else ..; 105
Avoid if (x != y) ..; else ..; 106

Tobago Core - org/apache/myfaces/tobago/util/ValueExpressionComparator.java

Violation Line
The class 'ValueExpressionComparator' has a Standard Cyclomatic Complexity of 3 (Highest = 10). 30132
The class 'ValueExpressionComparator' has a Cyclomatic Complexity of 3 (Highest = 11). 30132
The class 'ValueExpressionComparator' has a Modified Cyclomatic Complexity of 3 (Highest = 10). 30132
Private field 'facesContext' could be made final; it is only initialized in the declaration or constructor. 34
Private field 'var' could be made final; it is only initialized in the declaration or constructor. 36
Private field 'valueExpression' could be made final; it is only initialized in the declaration or constructor. 38
The method 'equals' has a Standard Cyclomatic Complexity of 10. 7498
The method 'equals' has a Modified Cyclomatic Complexity of 10. 7498
The method 'equals' has a Cyclomatic Complexity of 11. 7498
Avoid declaring a variable if it is unreferenced before a possible exit point. 82
Avoid if (x != y) ..; else ..; 87
Avoid if (x != y) ..; else ..; 90
Avoid if (x != y) ..; else ..; 93
Avoid if (x != y) ..; else ..; 102
Avoid if (x != y) ..; else ..; 103
Avoid if (x != y) ..; else ..; 104

Tobago Core - org/apache/myfaces/tobago/util/XmlUtils.java

Violation Line
A switch statement does not contain a break 74100

Tobago Core - org/apache/myfaces/tobago/validator/FileItemValidator.java

Violation Line
The class 'FileItemValidator' has a Cyclomatic Complexity of 2 (Highest = 12). 40127
Avoid using redundant field initializer for 'maxSize' 44
Document empty constructor 5152
The method 'validate' has a Cyclomatic Complexity of 12. 5487
Deeply nested if..then statements are hard to read 6871
Deeply nested if..then statements are hard to read 7579
Consider using varargs for methods or constructors which take an array the last parameter. 103

Tobago Core - org/apache/myfaces/tobago/validator/SubmittedValueLengthValidator.java

Violation Line
Document empty constructor 4445
Avoid if (x != y) ..; else ..; 57
Avoid if (x != y) ..; else ..; 67
Avoid if (x != y) ..; else ..; 121
Avoid if (x != y) ..; else ..; 124
Avoid if (x != y) ..; else ..; 133
Avoid if (x != y) ..; else ..; 134

Tobago Core - org/apache/myfaces/tobago/webapp/LogoutActionListener.java

Violation Line
New exception is thrown in catch block, original stack trace may be lost 58

Tobago Core - org/apache/myfaces/tobago/webapp/Secret.java

Violation Line
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 57
Private field 'secret' could be made final; it is only initialized in the declaration or constructor. 57
Avoid declaring a variable if it is unreferenced before a possible exit point. 83

Tobago Core - org/apache/myfaces/tobago/webapp/SecretSessionListener.java

Violation Line
Document empty method 3637

Tobago Core - org/apache/myfaces/tobago/webapp/TobagoMultipartFormdataFilter.java

Violation Line
Avoid if (x != y) ..; else ..; 8086
Avoid if (x != y) ..; else ..; 8286
Document empty method 127128

Tobago Core - org/apache/myfaces/tobago/webapp/TobagoResponseWriter.java

Violation Line
This class has too many methods, consider refactoring it. 40237
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 232

Tobago Core - org/apache/myfaces/tobago/webapp/TobagoServletContextListener.java

Violation Line
StringBuffer constructor is initialized with size 16, but has at least 87 characters appended. 59
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 60
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 60
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 61
StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. 64

Tobago Deprecation - org/apache/myfaces/tobago/ajax/api/AjaxUtils.java

Violation Line
This class has too many methods, consider refactoring it. 36160
A class which only has private constructors should be final 36160
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 45

Tobago Deprecation - org/apache/myfaces/tobago/compat/FacesInvokeOnComponent12.java

Violation Line
A class which only has private constructors should be final 3383
These nested if statements could be combined 5658

Tobago Deprecation - org/apache/myfaces/tobago/compat/FacesUtils.java

Violation Line
A class which only has private constructors should be final 42245
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 51

Tobago Deprecation - org/apache/myfaces/tobago/component/ComponentUtil.java

Violation Line
This class has a bunch of public methods and attributes 20743
Possible God class (WMC=86, ATFD=55, TCC=0.0) 20743
A class which only has private constructors should be final 56743
This class has too many methods, consider refactoring it. 56743
Unnecessary use of fully qualified name 'javax.faces.component.UICommand' due to existing import 'javax.faces.component.UICommand' 98
Consider using varargs for methods or constructors which take an array the last parameter. 146
Consider using varargs for methods or constructors which take an array the last parameter. 154
Consider using varargs for methods or constructors which take an array the last parameter. 162
Avoid instantiating Integer objects. Call Integer.valueOf() instead. 450
Avoid reassigning parameters such as 'script' 503

Tobago Deprecation - org/apache/myfaces/tobago/component/UIViewRoot.java

Violation Line
Possible God class (WMC=55, ATFD=34, TCC=0.06060606060606061) 20340
The class 'UIViewRoot' has a Modified Cyclomatic Complexity of 4 (Highest = 11). 56340
The class 'UIViewRoot' has a Standard Cyclomatic Complexity of 4 (Highest = 11). 56340
The class 'UIViewRoot' has a Cyclomatic Complexity of 5 (Highest = 12). 56340
The method 'broadcastForPhase' has a Standard Cyclomatic Complexity of 11. 146198
The method 'broadcastForPhase' has a Modified Cyclomatic Complexity of 11. 146198
The method 'broadcastForPhase' has a Cyclomatic Complexity of 12. 146198
Deeply nested if..then statements are hard to read 165167
Avoid if (x != y) ..; else ..; 176180
The String literal "context" appears 4 times in this file; the first occurrence is on line 209 209
Avoid if (x != y) ..; else ..; 212230
The method 'decodeActionComponent' has a Cyclomatic Complexity of 10. 237266
Use equals() to compare object references. 259
Avoid if (x != y) ..; else ..; 276283
Avoid if (x != y) ..; else ..; 296302

Tobago Deprecation - org/apache/myfaces/tobago/config/ThemeConfig.java

Violation Line
A class which only has private constructors should be final 2953

Tobago Deprecation - org/apache/myfaces/tobago/context/FacesContextFactoryWrapper.java

Violation Line
Private field 'facesContextFactory' could be made final; it is only initialized in the declaration or constructor. 32

Tobago Deprecation - org/apache/myfaces/tobago/context/FacesContextWrapper.java

Violation Line
Unnecessary use of fully qualified name 'javax.faces.context.FacesContext' due to existing import 'javax.faces.context.FacesContext' 36
Private field 'context' could be made final; it is only initialized in the declaration or constructor. 37

Tobago Deprecation - org/apache/myfaces/tobago/context/ResourceManagerFactory.java

Violation Line
A class which only has private constructors should be final 3276

Tobago Deprecation - org/apache/myfaces/tobago/context/ResourceManagerUtil.java

Violation Line
A class which only has private constructors should be final 33191
Consider using varargs for methods or constructors which take an array the last parameter. 112
Consider using varargs for methods or constructors which take an array the last parameter. 124

Tobago Deprecation - org/apache/myfaces/tobago/context/TobagoFacesContext.java

Violation Line
Private field 'scriptFiles' could be made final; it is only initialized in the declaration or constructor. 40
Private field 'scriptBlocks' could be made final; it is only initialized in the declaration or constructor. 42
Private field 'styleFiles' could be made final; it is only initialized in the declaration or constructor. 44
Private field 'styleBlocks' could be made final; it is only initialized in the declaration or constructor. 46
Private field 'onloadScripts' could be made final; it is only initialized in the declaration or constructor. 48
Private field 'onunloadScripts' could be made final; it is only initialized in the declaration or constructor. 50
Private field 'onexitScripts' could be made final; it is only initialized in the declaration or constructor. 52
Private field 'onsubmitScripts' could be made final; it is only initialized in the declaration or constructor. 54
Private field 'popups' could be made final; it is only initialized in the declaration or constructor. 56

Tobago Deprecation - org/apache/myfaces/tobago/event/PageActionUtil.java

Violation Line
A class which only has private constructors should be final 2952
Avoid if (x != y) ..; else ..; 4650

Tobago Deprecation - org/apache/myfaces/tobago/event/ValueBindingPopupActionListener.java

Violation Line
Document empty constructor 4748

Tobago Deprecation - org/apache/myfaces/tobago/event/ValueBindingResetInputActionListener.java

Violation Line
Document empty constructor 4849

Tobago Deprecation - org/apache/myfaces/tobago/event/ValueBindingTabChangeListener.java

Violation Line
Document empty constructor 3940
Avoid if (x != y) ..; else ..; 4953
No need to check for null before an instanceof 82

Tobago Deprecation - org/apache/myfaces/tobago/internal/application/ViewHandlerImpl.java

Violation Line
Private field 'base' could be made final; it is only initialized in the declaration or constructor. 44
Consider simply returning the value vs storing it in local variable 'viewRoot' 102

Tobago Deprecation - org/apache/myfaces/tobago/internal/lifecycle/PhaseListenerManager.java

Violation Line
Private field 'lifecycle' could be made final; it is only initialized in the declaration or constructor. 47
Private field 'facesContext' could be made final; it is only initialized in the declaration or constructor. 48
Private field 'phaseListeners' could be made final; it is only initialized in the declaration or constructor. 49
Private field 'listenerSuccessMap' could be made final; it is only initialized in the declaration or constructor. 54
Consider using varargs for methods or constructors which take an array the last parameter. 60
Avoid declaring a variable if it is unreferenced before a possible exit point. 97

Tobago Deprecation - org/apache/myfaces/tobago/internal/lifecycle/RenderResponseExecutor.java

Violation Line
Avoid if (x != y) ..; else ..; 4958

Tobago Deprecation - org/apache/myfaces/tobago/internal/lifecycle/RestoreViewExecutor.java

Violation Line
The class 'RestoreViewExecutor' has a Standard Cyclomatic Complexity of 5 (Highest = 15). 57257
The class 'RestoreViewExecutor' has a Cyclomatic Complexity of 6 (Highest = 16). 57257
The class 'RestoreViewExecutor' has a Modified Cyclomatic Complexity of 5 (Highest = 15). 57257
The method 'execute' has a Modified Cyclomatic Complexity of 15. 61143
The method 'execute' has a Cyclomatic Complexity of 16. 61143
The method 'execute' has a Standard Cyclomatic Complexity of 15. 61143
The method execute() has an NPath complexity of 3360 61143
Avoid if (x != y) ..; else ..; 184
Avoid if (x != y) ..; else ..; 211233
Avoid instantiating new objects inside loops 247

Tobago Deprecation - org/apache/myfaces/tobago/internal/lifecycle/TobagoLifecycle.java

Violation Line
Private field 'lifecycleExecutors' could be made final; it is only initialized in the declaration or constructor. 50
Private field 'renderExecutor' could be made final; it is only initialized in the declaration or constructor. 51
Avoid using redundant field initializer for 'phaseListenerArray' 58
The String literal " in " appears 4 times in this file; the first occurrence is on line 94 94

Tobago Deprecation - org/apache/myfaces/tobago/internal/lifecycle/TobagoLifecycleFactory.java

Violation Line
Avoid unused private fields such as 'LOG'. 38
Private field 'factory' could be made final; it is only initialized in the declaration or constructor. 40
Private field 'defaultLifecycle' could be made final; it is only initialized in the declaration or constructor. 41
Do not add empty strings 51

Tobago Deprecation - org/apache/myfaces/tobago/internal/taglib/TagUtils.java

Violation Line
Possible God class (WMC=60, ATFD=24, TCC=0.0) 20323
A class which only has private constructors should be final 52323
Avoid reassigning parameters such as 'value' 62
These nested if statements could be combined 7173
Deeply nested if..then statements are hard to read 7173
Avoid instantiating Integer objects. Call Integer.valueOf() instead. 75
Consider using varargs for methods or constructors which take an array the last parameter. 163
Consider using varargs for methods or constructors which take an array the last parameter. 176
Consider using varargs for methods or constructors which take an array the last parameter. 189
Consider using varargs for methods or constructors which take an array the last parameter. 202
Consider using varargs for methods or constructors which take an array the last parameter. 214
Consider using varargs for methods or constructors which take an array the last parameter. 227
Consider using varargs for methods or constructors which take an array the last parameter. 239
Consider using varargs for methods or constructors which take an array the last parameter. 256
Avoid reassigning parameters such as 'script' 316

Tobago Deprecation - org/apache/myfaces/tobago/internal/util/AccessKeyMap.java

Violation Line
Avoid unused private fields such as 'LOG'. 32
Private field 'set' could be made final; it is only initialized in the declaration or constructor. 40
Avoid using implementation types like 'HashSet'; use the interface instead 40
StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 41
Avoid using implementation types like 'HashSet'; use the interface instead 58
Avoid reassigning parameters such as 'key' 70

Tobago Deprecation - org/apache/myfaces/tobago/model/DefaultMutableTreeNodeAnalyser.java

Violation Line
Private field 'node' could be made final; it is only initialized in the declaration or constructor. 30

Tobago Deprecation - org/apache/myfaces/tobago/renderkit/RenderUtil.java

Violation Line
A class which only has private constructors should be final 37134
The String literal "Using deprecated API" appears 12 times in this file; the first occurrence is on line 46 46

Tobago Deprecation - org/apache/myfaces/tobago/renderkit/TobagoResponseStateManager.java

Violation Line
Avoid if (x != y) ..; else ..; 7891
Avoid if (x != y) ..; else ..; 97108

Tobago Deprecation - org/apache/myfaces/tobago/renderkit/html/HtmlRendererUtil.java

Violation Line
This class has a bunch of public methods and attributes 20661
Possible God class (WMC=84, ATFD=29, TCC=0.0) 20661
This class has too many methods, consider refactoring it. 51661
Avoid unused private methods such as 'renderErrorFocusId(FacesContext,UIInput)'. 64
Avoid if (x != y) ..; else ..; 6674
The String literal "HtmlRendererUtils.replaceStyleAttribute() no longer supported. Use setter." appears 4 times in this file; the first occurrence is on line 200 200
Avoid unused private methods such as 'ensureStyleAttributeMap(UIComponent)'. 234
Avoid reassigning parameters such as 'style' 256
Avoid if (x != y) ..; else ..; 258
Consider using varargs for methods or constructors which take an array the last parameter. 410
Consider using varargs for methods or constructors which take an array the last parameter. 420
Avoid reassigning parameters such as 'title' 437
Avoid reassigning parameters such as 'title' 437
Avoid reassigning parameters such as 'title' 437
Consider using varargs for methods or constructors which take an array the last parameter. 464
Avoid appending characters as strings in StringBuffer.append. 469
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 507
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 508
Avoid appending characters as strings in StringBuffer.append. 508
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 509
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 520
Avoid appending characters as strings in StringBuffer.append. 521
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 521
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 522
Avoid appending characters as strings in StringBuffer.append. 564
Avoid appending characters as strings in StringBuffer.append. 567
Avoid appending characters as strings in StringBuffer.append. 569
Avoid appending characters as strings in StringBuffer.append. 571
Avoid appending characters as strings in StringBuffer.append. 573
Consider using varargs for methods or constructors which take an array the last parameter. 581
Avoid appending characters as strings in StringBuffer.append. 583
Avoid appending characters as strings in StringBuffer.append. 586
Avoid appending characters as strings in StringBuffer.append. 588
Avoid appending characters as strings in StringBuffer.append. 590
Avoid appending characters as strings in StringBuffer.append. 592
Avoid unused private methods such as 'createDojoDndType(UIComponent,String,String)'. 619

Tobago Deprecation - org/apache/myfaces/tobago/renderkit/html/HtmlStyleMap.java

Violation Line
Avoid reassigning parameters such as 'o' 38
Position literals first in String comparisons 39
Position literals first in String comparisons 39
Avoid appending characters as strings in StringBuffer.append. 68

Tobago Deprecation - org/apache/myfaces/tobago/renderkit/html/StyleClasses.java

Violation Line
Possible God class (WMC=48, ATFD=28, TCC=0.03508771929824561) 20296
This class has too many methods, consider refactoring it. 46296
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 119
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 120
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 148
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 185
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 200
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 201
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 202

Tobago Deprecation - org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/ToolBarRendererBase.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2628

Tobago Deprecation - org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/TreeNodeRendererBase.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2628

Tobago Deprecation - org/apache/myfaces/tobago/renderkit/html/util/CommandRendererHelper.java

Violation Line
The class 'CommandRendererHelper' has a Modified Cyclomatic Complexity of 3 (Highest = 14). 43176
The class 'CommandRendererHelper' has a Cyclomatic Complexity of 4 (Highest = 18). 43176
The class 'CommandRendererHelper' has a Standard Cyclomatic Complexity of 3 (Highest = 14). 43176
The constructor 'CommandRendererHelper' has a Standard Cyclomatic Complexity of 14. 56128
The constructor 'CommandRendererHelper' has a Cyclomatic Complexity of 18. 56128
The constructor 'CommandRendererHelper' has a Modified Cyclomatic Complexity of 14. 56128
These nested if statements could be combined 7173
Position literals first in String comparisons 117
Position literals first in String comparisons 119
Avoid reassigning parameters such as 'onclick' 142
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 146

Tobago Deprecation - org/apache/myfaces/tobago/renderkit/util/JQueryUtils.java

Violation Line
A class which only has private constructors should be final 26102
A switch statement does not contain a break 5686
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 97
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 98

Tobago Deprecation - org/apache/myfaces/tobago/util/MessageFactory.java

Violation Line
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 43
Consider using varargs for methods or constructors which take an array the last parameter. 47
Consider using varargs for methods or constructors which take an array the last parameter. 60
Avoid if (x != y) ..; else ..; 75
Avoid if (x != y) ..; else ..; 8286

Tobago Deprecation - org/apache/myfaces/tobago/util/StringUtil.java

Violation Line
A class which only has private constructors should be final 3262

Tobago Deprecation - org/apache/myfaces/tobago/util/StringUtils.java

Violation Line
A class which only has private constructors should be final 3281
Avoid instantiating new objects inside loops 66
Avoid instantiating Integer objects. Call Integer.valueOf() instead. 66
Avoid appending characters as strings in StringBuffer.append. 77

Tobago Fileupload - org/apache/myfaces/tobago/fileupload/FileUploadFacesContextFactoryImpl.java

Violation Line
The class 'FileUploadFacesContextFactoryImpl' has a Standard Cyclomatic Complexity of 8 (Highest = 11). 64146
The class 'FileUploadFacesContextFactoryImpl' has a Modified Cyclomatic Complexity of 8 (Highest = 11). 64146
The class 'FileUploadFacesContextFactoryImpl' has a Cyclomatic Complexity of 10 (Highest = 11). 64146
Private field 'facesContextFactory' could be made final; it is only initialized in the declaration or constructor. 66
Private field 'repositoryPath' could be made final; it is only initialized in the declaration or constructor. 67
Private field 'maxSize' could be made final; it is only initialized in the declaration or constructor. 68
The constructor 'FileUploadFacesContextFactoryImpl' has a Standard Cyclomatic Complexity of 11. 70119
The constructor 'FileUploadFacesContextFactoryImpl' has a Cyclomatic Complexity of 11. 70119
The constructor 'FileUploadFacesContextFactoryImpl' has a Modified Cyclomatic Complexity of 11. 70119
Avoid if (x != y) ..; else ..; 8492
Avoid if (x != y) ..; else ..; 8792
Avoid reassigning parameters such as 'request' 122
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 126

Tobago Sandbox - org/apache/myfaces/tobago/internal/component/AbstractUISplitLayout.java

Violation Line
Avoid reassigning parameters such as 'a' 68
Avoid reassigning parameters such as 'b' 68
Avoid reassigning parameters such as 'a' 68
Avoid reassigning parameters such as 'b' 68
Document empty method 106107
An empty method in an abstract class should be abstract instead 106107
An empty method in an abstract class should be abstract instead 119120
Document empty method 119120
Avoid if (x != y) ..; else ..; 128

Tobago Sandbox - org/apache/myfaces/tobago/internal/webapp/TobagoResponse.java

Violation Line
Avoid using redundant field initializer for 'printWriter' 36
Avoid using redundant field initializer for 'bufferedWriter' 37
Avoid if (x != y) ..; else ..; 5257

Tobago Sandbox - org/apache/myfaces/tobago/model/AbstractCrud.java

Violation Line
This class has too many methods, consider refactoring it. 22182
Overridable method 'reset' called during object construction 31

Tobago Sandbox - org/apache/myfaces/tobago/renderkit/html/sandbox/standard/tag/NumberSliderRenderer.java

Violation Line
Avoid really long methods. 56166
The String literal "min" appears 4 times in this file; the first occurrence is on line 64 64
The String literal "max" appears 4 times in this file; the first occurrence is on line 65 65

Tobago Sandbox - org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SplitLayoutRenderer.java

Violation Line
Avoid if (x != y) ..; else ..; 6780
Avoid if (x != y) ..; else ..; 121
Avoid if (x != y) ..; else ..; 123
Avoid if (x != y) ..; else ..; 129
Avoid if (x != y) ..; else ..; 131

Tobago Sandbox - org/apache/myfaces/tobago/util/Slf4jLogger.java

Violation Line
Private field 'log' could be made final; it is only initialized in the declaration or constructor. 26

Tobago Security - org/apache/myfaces/tobago/security/AuthorizationUtils.java

Violation Line
The class 'AuthorizationUtils' has a Standard Cyclomatic Complexity of 6 (Highest = 10). 40154
The class 'AuthorizationUtils' has a Cyclomatic Complexity of 6 (Highest = 10). 40154
A class which only has private constructors should be final 40154
The class 'AuthorizationUtils' has a Modified Cyclomatic Complexity of 5 (Highest = 10). 40154
The method 'isAuthorized' has a Standard Cyclomatic Complexity of 10. 5184
The method 'isAuthorized' has a Cyclomatic Complexity of 10. 5184
The method 'isAuthorized' has a Modified Cyclomatic Complexity of 10. 5184
Parameter 'expression' is not assigned and could be declared final 102
Local variable 'beanString' could be declared final 113
Local variable 'methodString' could be declared final 114
A switch statement does not contain a break 119132
Deeply nested if..then statements are hard to read 125127
Avoid if (x != y) ..; else ..; 135139
Parameter 'bean' is not assigned and could be declared final 144
Parameter 'name' is not assigned and could be declared final 144
Local variable 'method' could be declared final 147

Tobago Security - org/apache/myfaces/tobago/security/CheckAuthorisationMethodBinding.java

Violation Line
Document empty constructor 3839
Consider using varargs for methods or constructors which take an array the last parameter. 53

Tobago Security - org/apache/myfaces/tobago/security/CheckAuthorisationMethodExpression.java

Violation Line
Document empty constructor 3839
Consider using varargs for methods or constructors which take an array the last parameter. 51

Tobago Security - org/apache/myfaces/tobago/security/UISecuredButton.java

Violation Line
Document empty constructor 3435
Avoid if (x != y) ..; else ..; 4953

Tobago Security - org/apache/myfaces/tobago/security/UISecuredCommand.java

Violation Line
Document empty constructor 3536
Avoid if (x != y) ..; else ..; 5054

Tobago Security - org/apache/myfaces/tobago/security/UISecuredLink.java

Violation Line
Document empty constructor 3435
Avoid if (x != y) ..; else ..; 4953

Tobago Security - org/apache/myfaces/tobago/security/UISecuredLinkCommand.java

Violation Line
Document empty constructor 3839
Avoid if (x != y) ..; else ..; 5357

Tobago Security - org/apache/myfaces/tobago/security/UISecuredMenuCommand.java

Violation Line
Document empty constructor 3637
Avoid if (x != y) ..; else ..; 5155

Tobago Security - org/apache/myfaces/tobago/security/UISecuredToolBarCommand.java

Violation Line
Document empty constructor 3435
Avoid if (x != y) ..; else ..; 4953

Tobago Theme Speyside - org/apache/myfaces/tobago/renderkit/html/speyside/standard/tag/BoxRenderer.java

Violation Line
Parameter 'writer' is not assigned and could be declared final 152
Parameter 'facesContext' is not assigned and could be declared final 152
Parameter 'box' is not assigned and could be declared final 152
Avoid if (x != y) ..; else ..; 158162

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/BoxRendererBase.java

Violation Line
Avoid unused private fields such as 'LOG'. 37

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/Command.java

Violation Line
The class 'Command' has a Cyclomatic Complexity of 1 (Highest = 11). 39237
Document empty constructor 6061
Avoid long parameter lists. 6365
The constructor 'Command' has a Cyclomatic Complexity of 11. 95135
Avoid reassigning parameters such as 'facetComponent' 95
Avoid if (x != y) ..; else ..; 139
Do not add empty strings 139
Consider using varargs for methods or constructors which take an array the last parameter. 178

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/CommandMap.java

Violation Line
Document empty constructor 4041
Position literals first in String comparisons 59
Avoid if (x != y) ..; else ..; 7377

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/JsonUtils.java

Violation Line
The class 'JsonUtils' has a Cyclomatic Complexity of 4 (Highest = 17). 26218
The class 'JsonUtils' has a Modified Cyclomatic Complexity of 3 (Highest = 14). 26218
A class which only has private constructors should be final 26218
The class 'JsonUtils' has a Standard Cyclomatic Complexity of 3 (Highest = 14). 26218
Consider using varargs for methods or constructors which take an array the last parameter. 31
Avoid appending characters as strings in StringBuffer.append. 32
Avoid appending characters as strings in StringBuffer.append. 36
Consider using varargs for methods or constructors which take an array the last parameter. 39
Parameter 'builder' is not assigned and could be declared final 39
Parameter 'value' is not assigned and could be declared final 39
Avoid appending characters as strings in StringBuffer.append. 40
Avoid appending characters as strings in StringBuffer.append. 44
Avoid appending characters as strings in StringBuffer.append. 46
Avoid appending characters as strings in StringBuffer.append. 48
Avoid appending characters as strings in StringBuffer.append. 51
Avoid appending characters as strings in StringBuffer.append. 55
Avoid appending characters as strings in StringBuffer.append. 59
Avoid appending characters as strings in StringBuffer.append. 63
Avoid appending characters as strings in StringBuffer.append. 67
Avoid reassigning parameters such as 'value' 70
Avoid appending characters as strings in StringBuffer.append. 72
Avoid appending characters as strings in StringBuffer.append. 81
Avoid appending characters as strings in StringBuffer.append. 101
The method encode() has an NPath complexity of 18432 105166
The method 'encode' has a Standard Cyclomatic Complexity of 14. 105166
The method 'encode' has a Cyclomatic Complexity of 17. 105166
The method 'encode' has a Modified Cyclomatic Complexity of 14. 105166
Avoid appending characters as strings in StringBuffer.append. 106
Avoid appending characters as strings in StringBuffer.append. 169
Avoid appending characters as strings in StringBuffer.append. 192
Avoid appending characters as strings in StringBuffer.append. 206
Consider using varargs for methods or constructors which take an array the last parameter. 210

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/Popup.java

Violation Line
A class which only has private constructors should be final 2671
Private field 'command' could be made final; it is only initialized in the declaration or constructor. 31
Private field 'immediate' could be made final; it is only initialized in the declaration or constructor. 36
Avoid if (x != y) ..; else ..; 4856
Position literals first in String comparisons 50
Avoid if (x != y) ..; else ..; 5761

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/BoxRenderer.java

Violation Line
Avoid if (x != y) ..; else ..; 7579

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/ButtonRenderer.java

Violation Line
The class 'ButtonRenderer' has a Modified Cyclomatic Complexity of 8 (Highest = 10). 51146
The class 'ButtonRenderer' has a Cyclomatic Complexity of 8 (Highest = 10). 51146
The class 'ButtonRenderer' has a Standard Cyclomatic Complexity of 8 (Highest = 10). 51146
Avoid unused private fields such as 'LOG'. 53
The method 'encodeEnd' has a Standard Cyclomatic Complexity of 10. 55122
The method 'encodeEnd' has a Cyclomatic Complexity of 10. 55122
The method 'encodeEnd' has a Modified Cyclomatic Complexity of 10. 55122
The method encodeEnd() has an NPath complexity of 440 55122
Avoid if (x != y) ..; else ..; 111

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/CalendarRenderer.java

Violation Line
The class 'CalendarRenderer' has a Cyclomatic Complexity of 7 (Highest = 10). 46207
Avoid really long methods. 49190
The method 'encodeEnd' has a Cyclomatic Complexity of 10. 49190
The String literal "header" appears 5 times in this file; the first occurrence is on line 93 93
Unnecessary use of fully qualified name 'java.util.Calendar.MONTH' due to existing import 'java.util.Calendar' 202

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/DatePickerRenderer.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20273
Avoid really long methods. 65172
Avoid if (x != y) ..; else ..; 81
Avoid if (x != y) ..; else ..; 208217
Avoid if (x != y) ..; else ..; 212216
Avoid if (x != y) ..; else ..; 267271

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/HiddenRenderer.java

Violation Line
Avoid if (x != y) ..; else ..; 60

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/ImageRenderer.java

Violation Line
Avoid if (x != y) ..; else ..; 5166
Avoid if (x != y) ..; else ..; 5862
Avoid unused private methods such as 'createSrc(String,String)'. 96

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/InRenderer.java

Violation Line
The class 'InRenderer' has a Standard Cyclomatic Complexity of 5 (Highest = 12). 45143
The class 'InRenderer' has a Modified Cyclomatic Complexity of 5 (Highest = 12). 45143
The class 'InRenderer' has a Cyclomatic Complexity of 6 (Highest = 15). 45143
The method 'encodeEnd' has a Cyclomatic Complexity of 15. 60137
The method 'encodeEnd' has a Modified Cyclomatic Complexity of 12. 60137
The method 'encodeEnd' has a Standard Cyclomatic Complexity of 12. 60137
The method encodeEnd() has an NPath complexity of 11520 60137
Document empty method 141142

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/LabelRenderer.java

Violation Line
Avoid unused private fields such as 'LOG'. 44

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/LinkRenderer.java

Violation Line
The class 'LinkRenderer' has a Standard Cyclomatic Complexity of 6 (Highest = 11). 49158
The class 'LinkRenderer' has a Modified Cyclomatic Complexity of 6 (Highest = 11). 49158
The class 'LinkRenderer' has a Cyclomatic Complexity of 7 (Highest = 11). 49158
Avoid unused private fields such as 'LOG'. 51
The method encodeBegin() has an NPath complexity of 630 53121
The method 'encodeBegin' has a Cyclomatic Complexity of 11. 53121
The method 'encodeBegin' has a Standard Cyclomatic Complexity of 11. 53121
The method 'encodeBegin' has a Modified Cyclomatic Complexity of 11. 53121
Avoid if (x != y) ..; else ..; 107

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/MediatorRenderer.java

Violation Line
Avoid unused private fields such as 'LOG'. 37

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/MenuCommandRenderer.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20221
The class 'MenuCommandRenderer' has a Cyclomatic Complexity of 6 (Highest = 15). 62221
The class 'MenuCommandRenderer' has a Standard Cyclomatic Complexity of 5 (Highest = 12). 62221
The class 'MenuCommandRenderer' has a Modified Cyclomatic Complexity of 5 (Highest = 12). 62221
Avoid unused private fields such as 'LOG'. 64
Avoid if (x != y) ..; else ..; 74117
Avoid if (x != y) ..; else ..; 85117
Avoid instantiating new objects inside loops 94
Avoid instantiating new objects inside loops 9697
Avoid if (x != y) ..; else ..; 106113
Avoid long parameter lists. 131135
The method encodeItem() has an NPath complexity of 2592 131210
The method 'encodeItem' has a Standard Cyclomatic Complexity of 12. 131210
The method 'encodeItem' has a Cyclomatic Complexity of 15. 131210
The method 'encodeItem' has a Modified Cyclomatic Complexity of 12. 131210
Prefer StringBuffer over += for concatenating strings 152
Document empty method 213214

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/MenuRenderer.java

Violation Line
The class 'MenuRenderer' has a Cyclomatic Complexity of 5 (Highest = 11). 43138
Avoid unused private fields such as 'LOG'. 45
The method 'encodeBegin' has a Cyclomatic Complexity of 11. 59122
The method encodeBegin() has an NPath complexity of 448 59122
Avoid appending characters as strings in StringBuffer.append. 88
Avoid appending characters as strings in StringBuffer.append. 89

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/MessagesRenderer.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20261
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 83
Avoid if (x != y) ..; else ..; 140

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/ObjectRenderer.java

Violation Line
Avoid if (x != y) ..; else ..; 5256

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/OutRenderer.java

Violation Line
The class 'OutRenderer' has a Standard Cyclomatic Complexity of 10 (Highest = 9). 3991
The class 'OutRenderer' has a Cyclomatic Complexity of 10 (Highest = 9). 3991
The class 'OutRenderer' has a Modified Cyclomatic Complexity of 10 (Highest = 9). 3991

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/PageRenderer.java

Violation Line
Possible God class (WMC=100, ATFD=244, TCC=0.01098901098901099) 20746
A high number of imports can indicate a high degree of coupling within an object. 20746
The class 'PageRenderer' has a Standard Cyclomatic Complexity of 6 (Highest = 39). 78746
The class 'PageRenderer' has a Cyclomatic Complexity of 7 (Highest = 42). 78746
The class 'PageRenderer' has a Modified Cyclomatic Complexity of 6 (Highest = 39). 78746
The method 'decode' has a Cyclomatic Complexity of 10. 86128
The String literal "scrollbarWeight" appears 4 times in this file; the first occurrence is on line 106 106
The method 'encodeBegin' has a Cyclomatic Complexity of 42. 131453
The method encodeBegin() has an NCSS line count of 205 131453
The method 'encodeBegin' has a Standard Cyclomatic Complexity of 39. 131453
The method encodeBegin() has an NPath complexity of 70881280 131453
The method 'encodeBegin' has a Modified Cyclomatic Complexity of 39. 131453
Avoid really long methods. 131453
Avoid if (x != y) ..; else ..; 221
Avoid if (x != y) ..; else ..; 247261
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 266
The method encodeEnd() has an NPath complexity of 3360 487613
The method 'encodeEnd' has a Standard Cyclomatic Complexity of 12. 487613
The method 'encodeEnd' has a Modified Cyclomatic Complexity of 12. 487613
The method 'encodeEnd' has a Cyclomatic Complexity of 13. 487613
Avoid really long methods. 487613
Avoid if (x != y) ..; else ..; 633637
Avoid unused private methods such as 'errorMessageForDebugging(String,FacesMessage,ResponseWriter)'. 669
Avoid if (x != y) ..; else ..; 675
The String literal "null" appears 6 times in this file; the first occurrence is on line 675 675
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 689
Avoid if (x != y) ..; else ..; 689
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 690
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 691
Avoid appending characters as strings in StringBuffer.append. 692
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 692
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 693
Avoid if (x != y) ..; else ..; 718722
Avoid if (x != y) ..; else ..; 729733
Avoid if (x != y) ..; else ..; 740744

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/PanelRenderer.java

Violation Line
The class 'PanelRenderer' has a Cyclomatic Complexity of 6 (Highest = 14). 46138
Avoid unused private fields such as 'LOG'. 48
The method 'encodeBegin' has a Cyclomatic Complexity of 14. 64120
The method encodeBegin() has an NPath complexity of 240 64120

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectBooleanCheckboxRenderer.java

Violation Line
The String literal "true" appears 4 times in this file; the first occurrence is on line 61 61

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectManyCheckboxRenderer.java

Violation Line
Avoid unused local variables such as 'ignored'. 131
Local variable 'ignored' could be declared final 131

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectManyShuttleRenderer.java

Violation Line
Avoid really long methods. 44162

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectOneRadioRenderer.java

Violation Line
Local variable 'tobagoItem' could be declared final 113
Avoid unused local variables such as 'ignored'. 147
Local variable 'ignored' could be declared final 147

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectReferenceRenderer.java

Violation Line
Avoid unused private fields such as 'LOG'. 34

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SeparatorRenderer.java

Violation Line
Avoid if (x != y) ..; else ..; 5296

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SheetRenderer.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 201190
Possible God class (WMC=196, ATFD=414, TCC=0.0022988505747126436) 201190
The class 'SheetRenderer' has a Cyclomatic Complexity of 6 (Highest = 59). 941190
This class has too many methods, consider refactoring it. 941190
The class 'SheetRenderer' has a Standard Cyclomatic Complexity of 6 (Highest = 56). 941190
Avoid really long classes. 941190
The class 'SheetRenderer' has a Modified Cyclomatic Complexity of 6 (Highest = 56). 941190
Avoid if (x != y) ..; else ..; 123127
Avoid if (x != y) ..; else ..; 129133
The method 'renderSheet' has a Modified Cyclomatic Complexity of 56. 177573
The method renderSheet() has an NCSS line count of 279 177573
The method 'renderSheet' has a Standard Cyclomatic Complexity of 56. 177573
The method 'renderSheet' has a Cyclomatic Complexity of 59. 177573
Avoid really long methods. 177573
Avoid if (x != y) ..; else ..; 272289
Local variable 'dataWidthsSize' could be declared final 275
Avoid appending characters as strings in StringBuffer.append. 343
Avoid instantiating new objects inside loops 363
Avoid instantiating new objects inside loops 394
Avoid unused local variables such as 'ignored'. 449
Avoid if (x != y) ..; else ..; 453
Avoid instantiating new objects inside loops 454
The String literal "tobago" appears 9 times in this file; the first occurrence is on line 497 497
Local variable 'areaId' could be declared final 508
Local variable 'areaId' could be declared final 536
The method 'createSheetPagingInfo' has a Cyclomatic Complexity of 12. 592622
The method 'createSheetPagingInfo' has a Standard Cyclomatic Complexity of 12. 592622
The method createSheetPagingInfo() has an NPath complexity of 703130 592622
The method 'createSheetPagingInfo' has a Modified Cyclomatic Complexity of 12. 592622
Avoid if (x != y) ..; else ..; 595620
String.trim().length()==0 is an inefficient way to validate an empty String. 635
Avoid if (x != y) ..; else ..; 662
Avoid unused private methods such as 'checkPagingAttribute(String)'. 691
Parameter 'areaId' is not assigned and could be declared final 723
The method 'renderColumnHeaders' has a Cyclomatic Complexity of 28. 753948
The method 'renderColumnHeaders' has a Standard Cyclomatic Complexity of 26. 753948
The method renderColumnHeaders() has an NCSS line count of 136 753948
The method renderColumnHeaders() has an NPath complexity of 528456 753948
The method 'renderColumnHeaders' has a Modified Cyclomatic Complexity of 26. 753948
Avoid really long methods. 753948
Do not add empty strings 769
Avoid instantiating new objects inside loops 818
String.indexOf(char) is faster than String.indexOf(String). 836
Avoid instantiating new objects inside loops 843
Avoid instantiating new objects inside loops 845
Avoid instantiating new objects inside loops 846847
Prefer StringBuffer over += for concatenating strings 854
Prefer StringBuffer over += for concatenating strings 856
Prefer StringBuffer over += for concatenating strings 873
Avoid instantiating new objects inside loops 936
The method writeDirectPagingLinks() has an NPath complexity of 2025000 10211109
The method 'writeDirectPagingLinks' has a Cyclomatic Complexity of 26. 10211109
The method 'writeDirectPagingLinks' has a Standard Cyclomatic Complexity of 23. 10211109
The method 'writeDirectPagingLinks' has a Modified Cyclomatic Complexity of 23. 10211109
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 1071
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 1096

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SubviewRenderer.java

Violation Line
Document empty method 4345

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SuggestRenderer.java

Violation Line
Avoid instantiating new objects inside loops 120

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/TabGroupRenderer.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20387
Possible God class (WMC=48, ATFD=118, TCC=0.0) 20387
The class 'TabGroupRenderer' has a Modified Cyclomatic Complexity of 6 (Highest = 16). 68387
The class 'TabGroupRenderer' has a Cyclomatic Complexity of 6 (Highest = 17). 68387
The class 'TabGroupRenderer' has a Standard Cyclomatic Complexity of 6 (Highest = 16). 68387
The method 'ensureRenderedActiveIndex' has a Modified Cyclomatic Complexity of 10. 142176
The method 'ensureRenderedActiveIndex' has a Cyclomatic Complexity of 10. 142176
The method 'ensureRenderedActiveIndex' has a Standard Cyclomatic Complexity of 10. 142176
Deeply nested if..then statements are hard to read 153155
Avoid if (x != y) ..; else ..; 170174
The method 'encodeHeader' has a Cyclomatic Complexity of 17. 178272
The method encodeHeader() has an NPath complexity of 6342 178272
The method 'encodeHeader' has a Standard Cyclomatic Complexity of 16. 178272
The method 'encodeHeader' has a Modified Cyclomatic Complexity of 16. 178272
Avoid instantiating new objects inside loops 202
Avoid if (x != y) ..; else ..; 243
Avoid if (x != y) ..; else ..; 246250
Avoid declaring a variable if it is unreferenced before a possible exit point. 285
Avoid unused local variables such as 'clientId'. 285
Avoid instantiating new objects inside loops 324
Avoid if (x != y) ..; else ..; 325329

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/TabRenderer.java

Violation Line
Avoid unused private fields such as 'LOG'. 28

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/TextareaRenderer.java

Violation Line
The class 'TextareaRenderer' has a Modified Cyclomatic Complexity of 16 (Highest = 15). 46140
The class 'TextareaRenderer' has a Cyclomatic Complexity of 17 (Highest = 16). 46140
The class 'TextareaRenderer' has a Standard Cyclomatic Complexity of 16 (Highest = 15). 46140
The method encodeEnd() has an NPath complexity of 4992 51139
The method 'encodeEnd' has a Cyclomatic Complexity of 16. 51139
The method 'encodeEnd' has a Standard Cyclomatic Complexity of 15. 51139
The method 'encodeEnd' has a Modified Cyclomatic Complexity of 15. 51139
Prefer StringBuffer over += for concatenating strings 125
Prefer StringBuffer over += for concatenating strings 127
Prefer StringBuffer over += for concatenating strings 129

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/TimeRenderer.java

Violation Line
The class 'TimeRenderer' has a Standard Cyclomatic Complexity of 7 (Highest = 21). 53287
The class 'TimeRenderer' has a Modified Cyclomatic Complexity of 7 (Highest = 21). 53287
The class 'TimeRenderer' has a Cyclomatic Complexity of 8 (Highest = 24). 53287
Parameter 'facesContext' is not assigned and could be declared final 58
Parameter 'component' is not assigned and could be declared final 58
Avoid really long methods. 69256
The method encodeEnd() has an NPath complexity of 9456 69256
The method 'encodeEnd' has a Modified Cyclomatic Complexity of 21. 69256
The method 'encodeEnd' has a Cyclomatic Complexity of 24. 69256
The method encodeEnd() has an NCSS line count of 128 69256
The method 'encodeEnd' has a Standard Cyclomatic Complexity of 21. 69256
Local variable 'tobagoConfig' could be declared final 92
Prefer StringBuffer over += for concatenating strings 102
When instantiating a SimpleDateFormat object, specify a Locale 108
When instantiating a SimpleDateFormat object, specify a Locale 109
When instantiating a SimpleDateFormat object, specify a Locale 110

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/ToolBarRendererBase.java

Violation Line
Possible God class (WMC=109, ATFD=187, TCC=0.0) 20648
A high number of imports can indicate a high degree of coupling within an object. 20648
The class 'ToolBarRendererBase' has a Standard Cyclomatic Complexity of 5 (Highest = 33). 66648
The class 'ToolBarRendererBase' has a Cyclomatic Complexity of 6 (Highest = 43). 66648
This class has too many methods, consider refactoring it. 66648
The class 'ToolBarRendererBase' has a Modified Cyclomatic Complexity of 5 (Highest = 33). 66648
Avoid if (x != y) ..; else ..; 108116
Avoid if (x != y) ..; else ..; 110116
The method 'renderSelectOne' has a Cyclomatic Complexity of 10. 122189
Avoid reassigning parameters such as 'width' 124
Avoid if (x != y) ..; else ..; 147151
Avoid instantiating new objects inside loops 176
Avoid reassigning parameters such as 'width' 196
The method 'renderToolbarButton' has a Standard Cyclomatic Complexity of 33. 221464
The method renderToolbarButton() has an NCSS line count of 165 221464
The method 'renderToolbarButton' has a Modified Cyclomatic Complexity of 33. 221464
The method 'renderToolbarButton' has a Cyclomatic Complexity of 43. 221464
Avoid really long methods. 221464
Avoid if (x != y) ..; else ..; 412417
Avoid unused local variables such as 'iconSmall'. 497
Avoid declaring a variable if it is unreferenced before a possible exit point. 497
The method getImage() has an NPath complexity of 53760 543617
The method 'getImage' has a Standard Cyclomatic Complexity of 20. 543617
The method 'getImage' has a Cyclomatic Complexity of 23. 543617
The method 'getImage' has a Modified Cyclomatic Complexity of 20. 543617
Avoid if (x != y) ..; else ..; 560564
The String literal "SelectedDisabled" appears 4 times in this file; the first occurrence is on line 561 561
Avoid if (x != y) ..; else ..; 566570
Avoid if (x != y) ..; else ..; 574578
The String literal "Disabled" appears 4 times in this file; the first occurrence is on line 575 575
Avoid if (x != y) ..; else ..; 580584
Avoid if (x != y) ..; else ..; 588592
The String literal "Selected" appears 4 times in this file; the first occurrence is on line 589 589
Avoid if (x != y) ..; else ..; 594598
Avoid if (x != y) ..; else ..; 602606
Avoid if (x != y) ..; else ..; 608612
An empty method in an abstract class should be abstract instead 630632
Document empty method 631632

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/TreeCommandRenderer.java

Violation Line
Avoid unused private fields such as 'LOG'. 48

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/TreeDataRenderer.java

Violation Line
Document empty method 3233
Document empty method 4142

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/TreeIconRenderer.java

Violation Line
The class 'TreeIconRenderer' has a Standard Cyclomatic Complexity of 15 (Highest = 14). 40120
The class 'TreeIconRenderer' has a Modified Cyclomatic Complexity of 15 (Highest = 14). 40120
The class 'TreeIconRenderer' has a Cyclomatic Complexity of 15 (Highest = 14). 40120
The method 'encodeBegin' has a Standard Cyclomatic Complexity of 14. 47119
The method 'encodeBegin' has a Cyclomatic Complexity of 14. 47119
The method encodeBegin() has an NPath complexity of 1296 47119
The method 'encodeBegin' has a Modified Cyclomatic Complexity of 14. 47119
Avoid if (x != y) ..; else ..; 6876
Avoid if (x != y) ..; else ..; 6973
Avoid if (x != y) ..; else ..; 7886
Avoid if (x != y) ..; else ..; 7983
Avoid if (x != y) ..; else ..; 9098
Avoid if (x != y) ..; else ..; 9195

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/TreeIndentRenderer.java

Violation Line
The class 'TreeIndentRenderer' has a Modified Cyclomatic Complexity of 4 (Highest = 10). 42164
The class 'TreeIndentRenderer' has a Standard Cyclomatic Complexity of 4 (Highest = 10). 42164
The class 'TreeIndentRenderer' has a Cyclomatic Complexity of 5 (Highest = 12). 42164
The method encodeTreeJunction() has an NPath complexity of 280 105162
The method 'encodeTreeJunction' has a Standard Cyclomatic Complexity of 10. 105162
The method 'encodeTreeJunction' has a Modified Cyclomatic Complexity of 10. 105162
Avoid long parameter lists. 105108
The method 'encodeTreeJunction' has a Cyclomatic Complexity of 12. 105162

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/TreeLabelRenderer.java

Violation Line
Avoid unused private fields such as 'LOG'. 43

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/TreeListboxNodeRenderer.java

Violation Line
Avoid unused local variables such as 'id'. 63
Avoid unused local variables such as 'folder'. 64

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/TreeListboxRenderer.java

Violation Line
Avoid if (x != y) ..; else ..; 110112
Avoid instantiating new objects inside loops 120
Avoid if (x != y) ..; else ..; 173182
Avoid if (x != y) ..; else ..; 177181

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/TreeMenuLabelRenderer.java

Violation Line
Avoid unused private fields such as 'LOG'. 33

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/TreeRenderer.java

Violation Line
The class 'TreeRenderer' has a Cyclomatic Complexity of 3 (Highest = 10). 48156
The method 'encodeEnd' has a Cyclomatic Complexity of 10. 70150
The method encodeEnd() has an NPath complexity of 500 70150
Avoid declaring a variable if it is unreferenced before a possible exit point. 74
Avoid appending characters as strings in StringBuffer.append. 114
Avoid appending characters as strings in StringBuffer.append. 119

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/TreeSelectRenderer.java

Violation Line
The class 'TreeSelectRenderer' has a Cyclomatic Complexity of 5 (Highest = 10). 44152
Avoid declaring a variable if it is unreferenced before a possible exit point. 52
The method 'encodeBegin' has a Cyclomatic Complexity of 10. 79142
Do not add empty strings 146
Do not add empty strings 146
Document empty method 150151

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/VerbatimRenderer.java

Violation Line
Avoid declaring a variable if it is unreferenced before a possible exit point. 43

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/html/util/HtmlRendererUtils.java

Violation Line
This class has a bunch of public methods and attributes 20956
Possible God class (WMC=170, ATFD=107, TCC=0.0) 20956
A high number of imports can indicate a high degree of coupling within an object. 20956
This class has too many methods, consider refactoring it. 67956
The class 'HtmlRendererUtils' has a Standard Cyclomatic Complexity of 3 (Highest = 16). 67956
The class 'HtmlRendererUtils' has a Modified Cyclomatic Complexity of 3 (Highest = 16). 67956
The class 'HtmlRendererUtils' has a Cyclomatic Complexity of 3 (Highest = 20). 67956
Avoid if (x != y) ..; else ..; 8189
Avoid if (x != y) ..; else ..; 122127
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 221
The method 'writeScriptLoader' has a Cyclomatic Complexity of 14. 287337
The method writeScriptLoader() has an NPath complexity of 220 287337
The method 'writeScriptLoader' has a Standard Cyclomatic Complexity of 12. 287337
The method 'writeScriptLoader' has a Modified Cyclomatic Complexity of 12. 287337
Consider using varargs for methods or constructors which take an array the last parameter. 288
Consider using varargs for methods or constructors which take an array the last parameter. 344
Avoid reassigning parameters such as 'title' 359
Avoid reassigning parameters such as 'title' 359
Avoid reassigning parameters such as 'title' 359
Avoid if (x != y) ..; else ..; 389
Avoid if (x != y) ..; else ..; 390
The method 'renderSelectItems' has a Modified Cyclomatic Complexity of 16. 402474
The method 'renderSelectItems' has a Standard Cyclomatic Complexity of 16. 402474
The method renderSelectItems() has an NPath complexity of 9006 402474
The method 'renderSelectItems' has a Cyclomatic Complexity of 20. 402474
Avoid instantiating new objects inside loops 452
Consider using varargs for methods or constructors which take an array the last parameter. 481
Avoid appending characters as strings in StringBuffer.append. 486
Consider using varargs for methods or constructors which take an array the last parameter. 502
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 521
Avoid appending characters as strings in StringBuffer.append. 522
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 522
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 523
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 534
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 535
Avoid appending characters as strings in StringBuffer.append. 535
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 536
Avoid if (x != y) ..; else ..; 558563
Avoid appending characters as strings in StringBuffer.append. 600
Avoid appending characters as strings in StringBuffer.append. 603
Avoid appending characters as strings in StringBuffer.append. 605
Avoid appending characters as strings in StringBuffer.append. 607
Avoid appending characters as strings in StringBuffer.append. 609
Consider using varargs for methods or constructors which take an array the last parameter. 617
Avoid appending characters as strings in StringBuffer.append. 619
Avoid appending characters as strings in StringBuffer.append. 622
Avoid appending characters as strings in StringBuffer.append. 624
Avoid appending characters as strings in StringBuffer.append. 626
Avoid appending characters as strings in StringBuffer.append. 628
The method 'createDojoDndType' has a Standard Cyclomatic Complexity of 12. 669721
The method 'createDojoDndType' has a Cyclomatic Complexity of 12. 669721
The method createDojoDndType() has an NPath complexity of 640 669721
The method 'createDojoDndType' has a Modified Cyclomatic Complexity of 12. 669721
Avoid appending characters as strings in StringBuffer.append. 671
Avoid appending characters as strings in StringBuffer.append. 676
Avoid appending characters as strings in StringBuffer.append. 680
Avoid appending characters as strings in StringBuffer.append. 684
Avoid appending characters as strings in StringBuffer.append. 688
Prefer StringBuffer over += for concatenating strings 699
Avoid appending characters as strings in StringBuffer.append. 709
Avoid appending characters as strings in StringBuffer.append. 713
Avoid appending characters as strings in StringBuffer.append. 717
Avoid instantiating new objects inside loops 742
Avoid instantiating new objects inside loops 745
Avoid instantiating new objects inside loops 764
Avoid instantiating new objects inside loops 766
Avoid if (x != y) ..; else ..; 855865
StringBuffer constructor is initialized with size 16, but has at least 36 characters appended. 877
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 878
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 879

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/util/RenderUtils.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20574
Possible God class (WMC=111, ATFD=87, TCC=0.005847953216374269) 20574
This class has too many methods, consider refactoring it. 62574
The class 'RenderUtils' has a Cyclomatic Complexity of 5 (Highest = 22). 62574
The class 'RenderUtils' has a Standard Cyclomatic Complexity of 4 (Highest = 22). 62574
The class 'RenderUtils' has a Modified Cyclomatic Complexity of 4 (Highest = 22). 62574
A class which only has private constructors should be final 62574
Avoid if (x != y) ..; else ..; 259268
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 259
Avoid instantiating new objects inside loops 266
Avoid if (x != y) ..; else ..; 290296
The method 'getSelectItems' has a Modified Cyclomatic Complexity of 22. 306377
The method 'getSelectItems' has a Cyclomatic Complexity of 22. 306377
The method 'getSelectItems' has a Standard Cyclomatic Complexity of 22. 306377
Avoid instantiating new objects inside loops 323325
Avoid if (x != y) ..; else ..; 324
Avoid instantiating new objects inside loops 362
The method 'decodedStateOfTreeData' has a Modified Cyclomatic Complexity of 12. 391444
The method decodedStateOfTreeData() has an NPath complexity of 410 391444
The method 'decodedStateOfTreeData' has a Cyclomatic Complexity of 12. 391444
The method 'decodedStateOfTreeData' has a Standard Cyclomatic Complexity of 12. 391444
These nested if statements could be combined 428439
Consider using varargs for methods or constructors which take an array the last parameter. 475
Avoid if (x != y) ..; else ..; 482
String.indexOf(char) is faster than String.indexOf(String). 503
The method 'generateUrl' has a Standard Cyclomatic Complexity of 11. 517572
The method 'generateUrl' has a Modified Cyclomatic Complexity of 11. 517572
The method 'generateUrl' has a Cyclomatic Complexity of 11. 517572
Avoid if (x != y) ..; else ..; 525569
Avoid if (x != y) ..; else ..; 528538
This call to String.startsWith can be rewritten using String.charAt(0) 542
Avoid appending characters as strings in StringBuffer.append. 556
Avoid appending characters as strings in StringBuffer.append. 559
Avoid appending characters as strings in StringBuffer.append. 562
Avoid if (x != y) ..; else ..; 565

Tobago Theme Standard - org/apache/myfaces/tobago/renderkit/util/SelectItemUtils.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 44291
Avoid instantiation through private constructors from outside of the constructors class. 59
Local variable 'selectItem' could be declared final 78
The class 'SelectItemsIterator' has a Modified Cyclomatic Complexity of 7 (Highest = 19). 85289
The class 'SelectItemsIterator' has a Standard Cyclomatic Complexity of 7 (Highest = 19). 85289
The class 'SelectItemsIterator' has a Cyclomatic Complexity of 8 (Highest = 21). 85289
The method hasNext() has an NPath complexity of 864 99191
The method 'hasNext' has a Cyclomatic Complexity of 21. 99191
The method 'hasNext' has a Modified Cyclomatic Complexity of 19. 99191
The method 'hasNext' has a Standard Cyclomatic Complexity of 19. 99191
Local variable 'tobagoSelectItem' could be declared final 145146
Local variable 'expression' could be declared final 152
Local variable 'entry' could be declared final 183
Avoid instantiating new objects inside loops 184
The method 'next' has a Standard Cyclomatic Complexity of 12. 193269
The method 'next' has a Modified Cyclomatic Complexity of 12. 193269
The method 'next' has a Cyclomatic Complexity of 13. 193269
The method next() has an NPath complexity of 584 193269
Avoid if (x != y) ..; else ..; 259263

Tobago Maven2 Theme Plugin - org/apache/myfaces/tobago/maven/plugin/IndexThemeMojo.java

Violation Line
The class 'IndexThemeMojo' has a Standard Cyclomatic Complexity of 5 (Highest = 12). 37146
The class 'IndexThemeMojo' has a Modified Cyclomatic Complexity of 5 (Highest = 12). 37146
The class 'IndexThemeMojo' has a Cyclomatic Complexity of 5 (Highest = 13). 37146
The method 'execute' has a Modified Cyclomatic Complexity of 12. 61119
The method execute() has an NPath complexity of 768 61119
The method 'execute' has a Cyclomatic Complexity of 13. 61119
The method 'execute' has a Standard Cyclomatic Complexity of 12. 61119
Avoid instantiation through private constructors from outside of the constructors class. 77
Avoid if (x != y) ..; else ..; 89118
These nested if statements could be combined 9294
Parameter 'file' is not assigned and could be declared final 121
Private field 'lastModified' could be made final; it is only initialized in the declaration or constructor. 130

Tobago Maven2 Theme Plugin - org/apache/myfaces/tobago/maven/plugin/UnPackThemeMojo.java

Violation Line
The class 'UnPackThemeMojo' has a Cyclomatic Complexity of 13 (Highest = 28). 53230
The class 'UnPackThemeMojo' has a Standard Cyclomatic Complexity of 11 (Highest = 23). 53230
The class 'UnPackThemeMojo' has a Modified Cyclomatic Complexity of 11 (Highest = 23). 53230
Position literals first in String comparisons 97
Position literals first in String comparisons 97
Avoid instantiating new objects inside loops 100
The method 'execute' has a Cyclomatic Complexity of 28. 123216
The method 'execute' has a Modified Cyclomatic Complexity of 23. 123216
The method execute() has an NPath complexity of 4575 123216
The method 'execute' has a Standard Cyclomatic Complexity of 23. 123216
Avoid instantiating new objects inside loops 136
Avoid instantiating new objects inside loops 142
Avoid if (x != y) ..; else ..; 144149
Deeply nested if..then statements are hard to read 147149
Avoid instantiating new objects inside loops 156
Deeply nested if..then statements are hard to read 158177
Avoid instantiating new objects inside loops 166
Avoid instantiating new objects inside loops 168
Deeply nested if..then statements are hard to read 183187
Avoid instantiating new objects inside loops 190
Deeply nested if..then statements are hard to read 192195
Deeply nested if..then statements are hard to read 196198
Avoid instantiating new objects inside loops 199

Tobago Tool Apt - org/apache/myfaces/tobago/ant/sniplet/CodeSniplet.java

Violation Line
The class 'CodeSniplet' has a Cyclomatic Complexity of 2 (Highest = 11). 25109
Private field 'code' could be made final; it is only initialized in the declaration or constructor. 28
The method 'getCode' has a Cyclomatic Complexity of 11. 5279
Avoid appending characters as strings in StringBuffer.append. 75

Tobago Tool Apt - org/apache/myfaces/tobago/ant/sniplet/CodeSnipletExtractTask.java

Violation Line
The class 'CodeSnipletExtractTask' has a Standard Cyclomatic Complexity of 2 (Highest = 11). 66211
The class 'CodeSnipletExtractTask' has a Cyclomatic Complexity of 2 (Highest = 11). 66211
The class 'CodeSnipletExtractTask' has a Modified Cyclomatic Complexity of 2 (Highest = 11). 66211
The method 'execute' has a Cyclomatic Complexity of 11. 111161
The method 'execute' has a Standard Cyclomatic Complexity of 11. 111161
The method 'execute' has a Modified Cyclomatic Complexity of 11. 111161
Avoid instantiating new objects inside loops 121122
The String literal "' at line '" appears 4 times in this file; the first occurrence is on line 142 142
Avoid instantiating new objects inside loops 147
Avoid instantiating new objects inside loops 167
Avoid instantiating new objects inside loops 168

Tobago Tool Apt - org/apache/myfaces/tobago/apt/generate/ClassInfo.java

Violation Line
Private field 'className' could be made final; it is only initialized in the declaration or constructor. 27
Private field 'packageName' could be made final; it is only initialized in the declaration or constructor. 28
Private field 'imports' could be made final; it is only initialized in the declaration or constructor. 29
Private field 'interfaces' could be made final; it is only initialized in the declaration or constructor. 31
Private field 'sourceClass' could be made final; it is only initialized in the declaration or constructor. 32
Avoid if (x != y) ..; else ..; 5156
Avoid if (x != y) ..; else ..; 7782

Tobago Tool Apt - org/apache/myfaces/tobago/apt/generate/ClassUtils.java

Violation Line
A class which only has private constructors should be final 2571

Tobago Tool Apt - org/apache/myfaces/tobago/apt/generate/ComponentInfo.java

Violation Line
Private field 'nonTransientProperties' could be made final; it is only initialized in the declaration or constructor. 30
Private field 'transientProperties' could be made final; it is only initialized in the declaration or constructor. 31
Avoid using redundant field initializer for 'index' 35
Avoid using redundant field initializer for 'nonTransientIndex' 36
Avoid if (x != y) ..; else ..; 5561

Tobago Tool Apt - org/apache/myfaces/tobago/apt/generate/Imports.java

Violation Line
Private field 'imports' could be made final; it is only initialized in the declaration or constructor. 28
Document empty constructor 3233
Avoid reassigning parameters such as 'qualifiedName' 39
These nested if statements could be combined 4149
Deeply nested if..then statements are hard to read 4345
Deeply nested if..then statements are hard to read 4648

Tobago Tool Apt - org/apache/myfaces/tobago/apt/generate/PropertyInfo.java

Violation Line
Possible God class (WMC=54, ATFD=14, TCC=0.08478513356562137) 20262
Document empty constructor 4142
Position literals first in String comparisons 125
Consider using varargs for methods or constructors which take an array the last parameter. 135
Consider using varargs for methods or constructors which take an array the last parameter. 143

Tobago Tool Apt - org/apache/myfaces/tobago/apt/generate/TagInfo.java

Violation Line
Private field 'properties' could be made final; it is only initialized in the declaration or constructor. 27

Tobago Tool Apt - org/apache/myfaces/tobago/apt/processor/AbstractGenerator.java

Violation Line
The class 'AbstractGenerator' has a Cyclomatic Complexity of 2 (Highest = 11). 40125
The class 'AbstractGenerator' has a Standard Cyclomatic Complexity of 2 (Highest = 11). 40125
The class 'AbstractGenerator' has a Modified Cyclomatic Complexity of 2 (Highest = 11). 40125
The method 'process' has a Cyclomatic Complexity of 11. 4795
The method 'process' has a Modified Cyclomatic Complexity of 11. 4795
The method 'process' has a Standard Cyclomatic Complexity of 11. 4795
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 56
These nested if statements could be combined 6870
These nested if statements could be combined 7375
A method/constructor shouldnt explicitly throw java.lang.Exception 99

Tobago Tool Apt - org/apache/myfaces/tobago/apt/processor/CheckstyleConfigGenerator.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20286
This class has too many methods, consider refactoring it. 70286
The String literal "name" appears 5 times in this file; the first occurrence is on line 94 94
Avoid if (x != y) ..; else ..; 150159
Avoid if (x != y) ..; else ..; 152159
Avoid if (x != y) ..; else ..; 154159

Tobago Tool Apt - org/apache/myfaces/tobago/apt/processor/ClassesGenerator.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20412
Possible God class (WMC=62, ATFD=71, TCC=0.0) 20412
The class 'ClassesGenerator' has a Cyclomatic Complexity of 4 (Highest = 13). 75412
The class 'ClassesGenerator' has a Standard Cyclomatic Complexity of 4 (Highest = 12). 75412
This class has too many methods, consider refactoring it. 75412
The class 'ClassesGenerator' has a Modified Cyclomatic Complexity of 4 (Highest = 12). 75412
Private field 'renderer' could be made final; it is only initialized in the declaration or constructor. 83
Perhaps 'jsfVersion' could be replaced by a local variable. 85
Perhaps 'tagVersion' could be replaced by a local variable. 86
A method/constructor shouldnt explicitly throw java.lang.Exception 122
Avoid if (x != y) ..; else ..; 124134
The method 'createTagOrComponent' has a Standard Cyclomatic Complexity of 11. 153219
The method 'createTagOrComponent' has a Modified Cyclomatic Complexity of 11. 153219
The method createTagOrComponent() has an NPath complexity of 252 153219
The method 'createTagOrComponent' has a Cyclomatic Complexity of 11. 153219
Position literals first in String comparisons 198
Position literals first in String comparisons 198
The method 'addProperty' has a Modified Cyclomatic Complexity of 12. 317366
The method 'addProperty' has a Cyclomatic Complexity of 13. 317366
The method 'addProperty' has a Standard Cyclomatic Complexity of 12. 317366
The method addProperty() has an NPath complexity of 1403 317366

Tobago Tool Apt - org/apache/myfaces/tobago/apt/processor/FacesConfigGenerator.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20629
Possible God class (WMC=83, ATFD=89, TCC=0.047619047619047616) 20629
This class has too many methods, consider refactoring it. 75629
The class 'FacesConfigGenerator' has a Modified Cyclomatic Complexity of 4 (Highest = 11). 75629
The class 'FacesConfigGenerator' has a Cyclomatic Complexity of 4 (Highest = 11). 75629
The class 'FacesConfigGenerator' has a Standard Cyclomatic Complexity of 4 (Highest = 11). 75629
The method generate() has an NPath complexity of 241 146234
The method 'generate' has a Modified Cyclomatic Complexity of 11. 146234
The method 'generate' has a Cyclomatic Complexity of 11. 146234
The method 'generate' has a Standard Cyclomatic Complexity of 11. 146234
A method/constructor shouldnt explicitly throw java.lang.Exception 146
Avoid if (x != y) ..; else ..; 178184
Avoid if (x != y) ..; else ..; 180184
Avoid unused private methods such as 'getIndexAfter(org.jdom.Element,String)'. 306
These nested if statements could be combined 317321
These nested if statements could be combined 318320
Position literals first in String comparisons 351
Prefer StringBuffer over += for concatenating strings 380
Prefer StringBuffer over += for concatenating strings 506
Avoid instantiating new objects inside loops 551
Avoid instantiating new objects inside loops 554
Avoid instantiating new objects inside loops 558
Avoid instantiating new objects inside loops 561
Avoid instantiating new objects inside loops 562
Prefer StringBuffer over += for concatenating strings 566
A method/constructor shouldnt explicitly throw java.lang.Exception 577
Avoid if (x != y) ..; else ..; 584611
Avoid unused private methods such as 'is20()'. 626

Tobago Tool Apt - org/apache/myfaces/tobago/apt/processor/TaglibGenerator.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20669
Possible God class (WMC=118, ATFD=72, TCC=0.0033333333333333335) 20669
The class 'TaglibGenerator' has a Cyclomatic Complexity of 3 (Highest = 21). 75669
The class 'TaglibGenerator' has a Modified Cyclomatic Complexity of 3 (Highest = 19). 75669
This class has too many methods, consider refactoring it. 75669
The class 'TaglibGenerator' has a Standard Cyclomatic Complexity of 3 (Highest = 19). 75669
Perhaps 'jsfVersion' could be replaced by a local variable. 83
Avoid if (x != y) ..; else ..; 174183
Avoid if (x != y) ..; else ..; 176183
Avoid if (x != y) ..; else ..; 178183
The method 'addDescription' has a Modified Cyclomatic Complexity of 19. 227310
The method 'addDescription' has a Standard Cyclomatic Complexity of 19. 227310
The method addDescription() has an NPath complexity of 83520 227310
The method 'addDescription' has a Cyclomatic Complexity of 21. 227310
StringBuffer constructor is initialized with size 16, but has at least 106 characters appended. 230
The String literal "</p>" appears 4 times in this file; the first occurrence is on line 245 245
Avoid reassigning parameters such as 'string' 312
Avoid reassigning parameters such as 'string' 312
String.indexOf(char) is faster than String.indexOf(String). 320
StringBuffer constructor is initialized with size 16, but has at least 65 characters appended. 340
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 341
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 342
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 343
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 343
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 344
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 345
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 349
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 354
Unnecessary use of fully qualified name 'org.w3c.dom.Element' due to existing import 'org.w3c.dom.Element' 425
Unnecessary use of fully qualified name 'org.w3c.dom.Element' due to existing import 'org.w3c.dom.Element' 431
Unnecessary use of fully qualified name 'org.w3c.dom.Element' due to existing import 'org.w3c.dom.Element' 432
Unnecessary use of fully qualified name 'org.w3c.dom.Element' due to existing import 'org.w3c.dom.Element' 438
Unnecessary use of fully qualified name 'org.w3c.dom.Element' due to existing import 'org.w3c.dom.Element' 439
The class 'Type' has a Modified Cyclomatic Complexity of 6(Highest = 15). 444668
The class 'Type' has a Cyclomatic Complexity of 8(Highest = 18). 444668
The class 'Type' has a Standard Cyclomatic Complexity of 7(Highest = 16). 444668
Avoid reassigning parameters such as 'target' 448
The String literal "Program error" appears 6 times in this file; the first occurrence is on line 456 456
The method 'addTagContent' has a Modified Cyclomatic Complexity of 11. 516580
The method 'addTagContent' has a Cyclomatic Complexity of 13. 516580
The method 'addTagContent' has a Standard Cyclomatic Complexity of 12. 516580
A high ratio of statements to labels in a switch statement. Consider refactoring. 519579
The String literal "handler-class" appears 4 times in this file; the first occurrence is on line 550 550
The method 'addAttributeType' has a Modified Cyclomatic Complexity of 15. 582667
The method 'addAttributeType' has a Cyclomatic Complexity of 18. 582667
The method 'addAttributeType' has a Standard Cyclomatic Complexity of 16. 582667
A high ratio of statements to labels in a switch statement. Consider refactoring. 585665
Avoid if (x != y) ..; else ..; 588626
The String literal "type" appears 4 times in this file; the first occurrence is on line 619 619
Avoid if (x != y) ..; else ..; 634660