PMD Results

The following document contains the results of PMD 4.2.5.

Files

Tobago Core - org/apache/myfaces/tobago/ajax/AjaxUtils.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.43 - 151
The class 'AjaxUtils' has a Cyclomatic Complexity of 2 (Highest = 6).43 - 151
Parameter 'facesContext' is not assigned and could be declared final47
Local variable 'parameterMap' could be declared final48
Local variable 'ajaxComponentIds' could be declared final49
Parameter 'facesContext' is not assigned and could be declared final53
Parameter 'clientId' is not assigned and could be declared final53
Local variable 'ajaxComponents' could be declared final54
Parameter 'facesContext' is not assigned and could be declared final60
Parameter 'clientId' is not assigned and could be declared final60
Parameter 'component' is not assigned and could be declared final64
Parameter 'facesContext' is not assigned and could be declared final64
Local variable 'ajaxComponents' could be declared final69
Parameter 'facesContext' is not assigned and could be declared final75
Local variable 'parameterMap' could be declared final76
Local variable 'ajaxComponentIds' could be declared final77
Local variable 'tokenizer' could be declared final79
Local variable 'ajaxComponents' could be declared final80
Local variable 'ajaxId' could be declared final82
Parameter 'context' is not assigned and could be declared final95
The method 'addUIMessagesToRenderedPartially' has a Cyclomatic Complexity of 6.95 - 116
Local variable 'list' could be declared final99
Local variable 'clientIds' could be declared final100
Parameter 'facesContext' is not assigned and could be declared final118
Parameter 'url' is not assigned and could be declared final118
Local variable 'httpServletResponse' could be declared final122 - 123
Local variable 'writer' could be declared final124
Local variable 'contentType' could be declared final125
Parameter 'writer' is not assigned and could be declared final134
Parameter 'url' is not assigned and could be declared final134
Parameter 'response' is not assigned and could be declared final144
Parameter 'url' is not assigned and could be declared final144
Local variable 'writer' could be declared final145
Local variable 'contentType' could be declared final146

Tobago Core - org/apache/myfaces/tobago/application/ActionListenerImpl.java

ViolationLine
The class 'ActionListenerImpl' has a Cyclomatic Complexity of 3 (Highest = 7).37 - 89
Private field 'base' could be made final; it is only initialized in the declaration or constructor.41
Parameter 'base' is not assigned and could be declared final45
Parameter 'event' is not assigned and could be declared final49
The method 'processAction' has a Cyclomatic Complexity of 7.49 - 80
An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type.53
Local variable 'facesContext' could be declared final63
Local variable 'facesMessage' could be declared final65
Local variable 'source' could be declared final68
Local variable 'actionSource' could be declared final69
Local variable 'application' could be declared final70
Local variable 'expression' could be declared final71
Local variable 'navHandler' could be declared final73
Avoid if (x != y) ..; else ..;75
Local variable 'navBinding' could be declared final75
Assigning an Object to null is a code smell. Consider refactoring.75
Parameter 'errorOutcome' is not assigned and could be declared final86

Tobago Core - org/apache/myfaces/tobago/application/LabelValueBindingFacesMessage.java

ViolationLine
The class 'LabelValueBindingFacesMessage' has a Cyclomatic Complexity of 2 (Highest = 5).34 - 85
Parameter 'summary' is not assigned and could be declared final42
Parameter 'detail' is not assigned and could be declared final42
Parameter 'severity' is not assigned and could be declared final42
Parameter 'args' is not assigned and could be declared final43
Parameter 'locale' is not assigned and could be declared final43
Parameter 'summary' is not assigned and could be declared final49
Parameter 'detail' is not assigned and could be declared final49
Parameter 'summary' is not assigned and could be declared final53
The method 'getDetail' has a Cyclomatic Complexity of 5.58 - 69
Local variable 'detail' could be declared final59
Local variable 'facesContext' could be declared final62
Local variable 'value' could be declared final63
The method 'getSummary' has a Cyclomatic Complexity of 5.72 - 83
Local variable 'summary' could be declared final73
Local variable 'facesContext' could be declared final76
Local variable 'value' could be declared final77

Tobago Core - org/apache/myfaces/tobago/application/LabelValueExpressionFacesMessage.java

ViolationLine
Parameter 'summary' is not assigned and could be declared final31
Parameter 'detail' is not assigned and could be declared final31
Parameter 'severity' is not assigned and could be declared final31
Parameter 'summary' is not assigned and could be declared final35
Parameter 'detail' is not assigned and could be declared final35
Parameter 'summary' is not assigned and could be declared final39
Local variable 'facesContext' could be declared final45
Local variable 'value' could be declared final46 - 47
Local variable 'facesContext' could be declared final53
Local variable 'value' could be declared final54 - 55

Tobago Core - org/apache/myfaces/tobago/compat/FacesInvokeOnComponent12.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.31 - 78
The class 'FacesInvokeOnComponent12' has a Cyclomatic Complexity of 6 (Highest = 7).31 - 78
The method 'invokeOnComponent' has a Cyclomatic Complexity of 7.37 - 62
Parameter 'component' is not assigned and could be declared final38
Parameter 'context' is not assigned and could be declared final38
Parameter 'callback' is not assigned and could be declared final38
Parameter 'clientId' is not assigned and could be declared final38
Local variable 'thisClientId' could be declared final39
These nested if statements could be combined51 - 53
These nested if statements could be combined51 - 53
Parameter 'component' is not assigned and could be declared final69
Parameter 'context' is not assigned and could be declared final69
Parameter 'callback' is not assigned and could be declared final69
Parameter 'clientId' is not assigned and could be declared final69
Local variable 'it' could be declared final70
Local variable 'child' could be declared final71

Tobago Core - org/apache/myfaces/tobago/compat/FacesUtils.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.41 - 233
The class 'FacesUtils' has a Cyclomatic Complexity of 1 (Highest = 5).41 - 233
Avoid unused private fields such as 'LOG'.43
Avoid unused private fields such as 'LOG'.43
Parameter 'component' is not assigned and could be declared final56
Parameter 'context' is not assigned and could be declared final56
Parameter 'callback' is not assigned and could be declared final56
Parameter 'clientId' is not assigned and could be declared final56
Parameter 'facesContext' is not assigned and could be declared final60
Parameter 'event' is not assigned and could be declared final60
Parameter 'methodBinding' is not assigned and could be declared final60
The method 'invokeMethodBinding' has a Cyclomatic Complexity of 5.60 - 73
Local variable 'cause' could be declared final65
Parameter 'component' is not assigned and could be declared final80
Parameter 'name' is not assigned and could be declared final80
Parameter 'context' is not assigned and could be declared final80
Parameter 'component' is not assigned and could be declared final88
Parameter 'name' is not assigned and could be declared final88
Parameter 'component' is not assigned and could be declared final97
Parameter 'name' is not assigned and could be declared final97
Parameter 'context' is not assigned and could be declared final97
Parameter 'component' is not assigned and could be declared final105
Parameter 'name' is not assigned and could be declared final105
Parameter 'component' is not assigned and could be declared final114
Parameter 'context' is not assigned and could be declared final114
Parameter 'value' is not assigned and could be declared final114
Parameter 'bindingName' is not assigned and could be declared final114
Parameter 'bindingOrExpression' is not assigned and could be declared final123
Parameter 'context' is not assigned and could be declared final123
Parameter 'value' is not assigned and could be declared final123
Parameter 'fromComponent' is not assigned and could be declared final132
Parameter 'toName' is not assigned and could be declared final132
Parameter 'fromName' is not assigned and could be declared final132
Parameter 'toComponent' is not assigned and could be declared final132
Parameter 'obj' is not assigned and could be declared final140
Parameter 'string' is not assigned and could be declared final148
Parameter 'editableValueHolder' is not assigned and could be declared final156
Parameter 'validator' is not assigned and could be declared final156
Parameter 'valueHolder' is not assigned and could be declared final164
Parameter 'converterExpression' is not assigned and could be declared final164
Parameter 'component' is not assigned and could be declared final172
Parameter 'valueBindingOrExpression' is not assigned and could be declared final172
Parameter 'name' is not assigned and could be declared final172
Parameter 'component' is not assigned and could be declared final180
Parameter 'valueBindingOrExpression' is not assigned and could be declared final180
Parameter 'name' is not assigned and could be declared final180
Parameter 'source' is not assigned and could be declared final188
Parameter 'type' is not assigned and could be declared final188
Parameter 'bindingOrExpression' is not assigned and could be declared final189
Parameter 'child' is not assigned and could be declared final198
Parameter 'facesContext' is not assigned and could be declared final198
Parameter 'var' is not assigned and could be declared final198
Parameter 'comparator' is not assigned and could be declared final198
Parameter 'descending' is not assigned and could be declared final198
Parameter 'bindingOrExpression' is not assigned and could be declared final206
Parameter 'actionSource' is not assigned and could be declared final206
Parameter 'bindingOrExpression' is not assigned and could be declared final214
Parameter 'actionSource' is not assigned and could be declared final214
Parameter 'context' is not assigned and could be declared final218

Tobago Core - org/apache/myfaces/tobago/compat/FacesUtilsEL.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.47 - 235
The class 'FacesUtilsEL' has a Cyclomatic Complexity of 2 (Highest = 7).47 - 235
This class has too many methods, consider refactoring it.47 - 235
The method 'invokeOnComponent' has a Cyclomatic Complexity of 7.51 - 76
Parameter 'component' is not assigned and could be declared final52
Parameter 'context' is not assigned and could be declared final52
Parameter 'callback' is not assigned and could be declared final52
Parameter 'clientId' is not assigned and could be declared final52
Local variable 'thisClientId' could be declared final53
These nested if statements could be combined65 - 67
These nested if statements could be combined65 - 67
Parameter 'component' is not assigned and could be declared final79
Parameter 'context' is not assigned and could be declared final79
Parameter 'callback' is not assigned and could be declared final79
Parameter 'clientId' is not assigned and could be declared final79
Local variable 'it' could be declared final80
Local variable 'child' could be declared final81
Parameter 'facesContext' is not assigned and could be declared final94
Parameter 'event' is not assigned and could be declared final94
Parameter 'methodBinding' is not assigned and could be declared final94
The method 'invokeMethodBinding' has a Cyclomatic Complexity of 5.94 - 107
Local variable 'cause' could be declared final99
Parameter 'facesContext' is not assigned and could be declared final110
Parameter 'event' is not assigned and could be declared final110
Parameter 'methodExpression' is not assigned and could be declared final110
Parameter 'component' is not assigned and could be declared final126
Parameter 'name' is not assigned and could be declared final126
Parameter 'context' is not assigned and could be declared final126
Parameter 'component' is not assigned and could be declared final131
Parameter 'name' is not assigned and could be declared final131
Parameter 'component' is not assigned and could be declared final136
Parameter 'name' is not assigned and could be declared final136
Parameter 'context' is not assigned and could be declared final136
Parameter 'component' is not assigned and could be declared final141
Parameter 'name' is not assigned and could be declared final141
Parameter 'component' is not assigned and could be declared final146
Parameter 'context' is not assigned and could be declared final146
Parameter 'value' is not assigned and could be declared final146
Parameter 'bindingName' is not assigned and could be declared final146
Local variable 've' could be declared final147
Parameter 'bindingOrExpression' is not assigned and could be declared final154
Parameter 'context' is not assigned and could be declared final154
Parameter 'value' is not assigned and could be declared final154
Local variable 've' could be declared final156
Parameter 'fromComponent' is not assigned and could be declared final162
Parameter 'toName' is not assigned and could be declared final162
Parameter 'fromName' is not assigned and could be declared final162
Parameter 'toComponent' is not assigned and could be declared final162
Local variable 've' could be declared final163
Parameter 'obj' is not assigned and could be declared final169
Local variable 'expression' could be declared final171
Parameter 'string' is not assigned and could be declared final181
Parameter 'string' is not assigned and could be declared final185
Local variable 'facesContext' could be declared final186
Local variable 'expressionFactory' could be declared final187
Parameter 'editableValueHolder' is not assigned and could be declared final191
Parameter 'validator' is not assigned and could be declared final191
Avoid if (x != y) ..; else ..;195
Parameter 'valueHolder' is not assigned and could be declared final199
Parameter 'converterExpression' is not assigned and could be declared final199
Local variable 'expression' could be declared final201
Avoid if (x != y) ..; else ..;202 - 207
Parameter 'component' is not assigned and could be declared final211
Parameter 'valueBindingOrExpression' is not assigned and could be declared final211
Parameter 'name' is not assigned and could be declared final211
Parameter 'source' is not assigned and could be declared final216
Parameter 'bindingOrExpression' is not assigned and could be declared final216
Parameter 'type' is not assigned and could be declared final216
Parameter 'child' is not assigned and could be declared final223
Parameter 'facesContext' is not assigned and could be declared final223
Parameter 'var' is not assigned and could be declared final223
Parameter 'comparator' is not assigned and could be declared final223
Parameter 'descending' is not assigned and could be declared final223
Local variable 'valueBinding' could be declared final224
Parameter 'bindingOrExpression' is not assigned and could be declared final228
Parameter 'actionSource' is not assigned and could be declared final228
Parameter 'bindingOrExpression' is not assigned and could be declared final232
Parameter 'actionSource' is not assigned and could be declared final232

Tobago Core - org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.java

ViolationLine
The class 'MethodBindingToMethodExpression' has a Cyclomatic Complexity of 3 (Highest = 7).37 - 231
This class has too many methods, consider refactoring it.37 - 231
Document empty constructor47 - 48
Parameter 'methodBinding' is not assigned and could be declared final54
Parameter 'methodBinding' is not assigned and could be declared final67
Parameter 'context' is not assigned and could be declared final76
Parameter 'context' is not assigned and could be declared final93
Local variable 'expr' could be declared final111
Parameter 'context' is not assigned and could be declared final119
Parameter 'context' is not assigned and could be declared final133
Parameter 'state' is not assigned and could be declared final133
Assigning an Object to null is a code smell. Consider refactoring.136
Local variable 'values' could be declared final138
Assigning an Object to null is a code smell. Consider refactoring.141
Parameter 'transientFlag' is not assigned and could be declared final145
Parameter 'obj' is not assigned and could be declared final162
The method 'equals' has a Cyclomatic Complexity of 7.162 - 181
Parameter 'instanceName' is not assigned and could be declared final183
Parameter 'notNullInstance' is not assigned and could be declared final183
Parameter 'instanceName' is not assigned and could be declared final189
Parameter 'notNullInstance' is not assigned and could be declared final189
Parameter 'invoker' is not assigned and could be declared final195
Parameter 'type' is not assigned and could be declared final209
The method 'newInstance' has a Cyclomatic Complexity of 7.209 - 229

Tobago Core - org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.java

ViolationLine
Assigning an Object to null is a code smell. Consider refactoring.41
Parameter 'methodExpression' is not assigned and could be declared final47
Parameter 'facesContext' is not assigned and could be declared final56
Parameter 'facesContext' is not assigned and could be declared final68
Parameter 'params' is not assigned and could be declared final68
Parameter 'context' is not assigned and could be declared final81
Parameter 'state' is not assigned and could be declared final81
Parameter 'context' is not assigned and could be declared final87
Parameter 'newTransientValue' is not assigned and could be declared final94

Tobago Core - org/apache/myfaces/tobago/component/Sorter.java

ViolationLine
The class 'Sorter' has a Cyclomatic Complexity of 8 (Highest = 28).49 - 238
The class 'Sorter' has a Cyclomatic Complexity of 8 (Highest = 28).49 - 238
Parameter 'sortEvent' is not assigned and could be declared final55
The method 'perform' has a Cyclomatic Complexity of 28.55 - 181
The method perform() has an NPath complexity of 3496855 - 181
Avoid really long methods.55 - 181
The method 'perform' has a Cyclomatic Complexity of 28.55 - 181
Local variable 'column' could be declared final59
Local variable 'data' could be declared final60
Local variable 'facesContext' could be declared final66
Local variable 'sheetState' could be declared final67
Local variable 'child' could be declared final75
Avoid if (x != y) ..; else ..;76 - 117
Local variable 'attributeName' could be declared final78
Avoid if (x != y) ..; else ..;79 - 112
Local variable 'var' could be declared final80
Local variable 'descending' could be declared final104
Local variable 'expression' could be declared final105
Avoid if (x != y) ..; else ..;179
Parameter 'expressionString' is not assigned and could be declared final185
The method 'isSimpleProperty' has a Cyclomatic Complexity of 5.185 - 197
Local variable 'inner' could be declared final187
Local variable 'parts' could be declared final188
Parameter 'uiColumn' is not assigned and could be declared final199
Parameter 'children' is not assigned and could be declared final204
The method 'getFirstSortableChild' has a Cyclomatic Complexity of 13.204 - 229
The method 'getFirstSortableChild' has a Cyclomatic Complexity of 13.204 - 229
Parameter 'comparator' is not assigned and could be declared final235

Tobago Core - org/apache/myfaces/tobago/component/UIViewRoot.java

ViolationLine
A high number of imports can indicate a high degree of coupling within an object.20 - 344
The class 'UIViewRoot' has a Cyclomatic Complexity of 4 (Highest = 12).54 - 344
This class has too many methods, consider refactoring it.54 - 344
The class 'UIViewRoot' has a Cyclomatic Complexity of 4 (Highest = 12).54 - 344
Parameter 'locale' is not assigned and could be declared final68
Local variable 'clientProperties' could be declared final70
Parameter 'context' is not assigned and could be declared final114
Parameter 'phaseId' is not assigned and could be declared final114
Parameter 'event' is not assigned and could be declared final133
Parameter 'phaseId' is not assigned and could be declared final144
The method 'broadcastForPhase' has a Cyclomatic Complexity of 12.144 - 196
The method 'broadcastForPhase' has a Cyclomatic Complexity of 12.144 - 196
Local variable 'phaseIdOrdinal' could be declared final151
Local variable 'listiterator' could be declared final152
Local variable 'event' could be declared final153
Local variable 'ordinal' could be declared final154
Local variable 'source' could be declared final156
Deeply nested if..then statements are hard to read163 - 165
Avoid if (x != y) ..; else ..;174 - 178
Local variable 'eventIndex' could be declared final184
Assigning an Object to null is a code smell. Consider refactoring.200
Parameter 'context' is not assigned and could be declared final205
The method 'processDecodes' has a Cyclomatic Complexity of 6.205 - 233
The String literal "context" appears 4 times in this file; the first occurrence is on line 207207
Local variable 'ajaxComponents' could be declared final209
Avoid if (x != y) ..; else ..;210 - 228
Local variable 'page' could be declared final212
Parameter 'page' is not assigned and could be declared final235
Parameter 'facesContext' is not assigned and could be declared final235
Parameter 'ajaxComponents' is not assigned and could be declared final235 - 236
The method 'decodeActionComponent' has a Cyclomatic Complexity of 10.235 - 264
The method 'decodeActionComponent' has a Cyclomatic Complexity of 10.235 - 264
Local variable 'actionId' could be declared final237
Local variable 'bugActionId' could be declared final242
Avoid empty catch blocks246 - 248
Avoid empty catch blocks246 - 248
Parameter 'context' is not assigned and could be declared final268
The method 'processValidators' has a Cyclomatic Complexity of 6.268 - 286
Local variable 'ajaxComponents' could be declared final273
Avoid if (x != y) ..; else ..;274 - 281
Parameter 'context' is not assigned and could be declared final289
The method 'processUpdates' has a Cyclomatic Complexity of 6.289 - 305
Local variable 'ajaxComponents' could be declared final293
Avoid if (x != y) ..; else ..;294 - 300
Parameter 'context' is not assigned and could be declared final308
Parameter 'context' is not assigned and could be declared final330
Parameter 'context' is not assigned and could be declared final340
Parameter 'callback' is not assigned and could be declared final340
Parameter 'clientId' is not assigned and could be declared final340

Tobago Core - org/apache/myfaces/tobago/config/ThemeConfig.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.29 - 50
Parameter 'component' is not assigned and could be declared final35
Parameter 'facesContext' is not assigned and could be declared final35
Parameter 'name' is not assigned and could be declared final35
Parameter 'component' is not assigned and could be declared final45
Parameter 'facesContext' is not assigned and could be declared final45
Parameter 'name' is not assigned and could be declared final45

Tobago Core - org/apache/myfaces/tobago/config/TobagoConfig.java

ViolationLine
Parameter 'facesContext' is not assigned and could be declared final33
Parameter 'servletContext' is not assigned and could be declared final37

Tobago Core - org/apache/myfaces/tobago/context/ClientProperties.java

ViolationLine
The class 'ClientProperties' has a Cyclomatic Complexity of 1 (Highest = 6).48 - 248
Parameter 'tobagoConfig' is not assigned and could be declared final79
Parameter 'facesContext' is not assigned and could be declared final84
The constructor 'ClientProperties' has a Cyclomatic Complexity of 6.84 - 116
Local variable 'externalContext' could be declared final86
Local variable 'accept' could be declared final89
These nested if statements could be combined91 - 93
These nested if statements could be combined91 - 93
Local variable 'requestUserAgent' could be declared final100
Local variable 'requestTheme' could be declared final107
Local variable 'config' could be declared final108
Parameter 'facesContext' is not assigned and could be declared final122
Parameter 'viewRoot' is not assigned and could be declared final132
Parameter 'facesContext' is not assigned and could be declared final142
Parameter 'propertyPathMode' is not assigned and could be declared final151
Parameter 'locale' is not assigned and could be declared final151
Local variable 'prefix' could be declared final153
Local variable 'locales' could be declared final154
Parameter 'contentType' is not assigned and could be declared final175
Parameter 'theme' is not assigned and could be declared final184
Parameter 'userAgent' is not assigned and could be declared final193
Parameter 'debugMode' is not assigned and could be declared final202
Parameter 'locale' is not assigned and could be declared final215
Parameter 'verticalScrollbarWeight' is not assigned and could be declared final227
Parameter 'horizontalScrollbarWeight' is not assigned and could be declared final235
Parameter 'facesContext' is not assigned and could be declared final239
Local variable 'externalContext' could be declared final240
Local variable 'requestUserAgent' could be declared final241
Use equals() to compare object references.243

Tobago Core - org/apache/myfaces/tobago/context/FacesContextFactoryWrapper.java

ViolationLine
Private field 'facesContextFactory' could be made final; it is only initialized in the declaration or constructor.28
Parameter 'facesContextFactory' is not assigned and could be declared final30
Parameter 'response' is not assigned and could be declared final34
Parameter 'lifecycle' is not assigned and could be declared final34
Parameter 'request' is not assigned and could be declared final34
Parameter 'context' is not assigned and could be declared final34

Tobago Core - org/apache/myfaces/tobago/context/FacesContextWrapper.java

ViolationLine
Private field 'context' could be made final; it is only initialized in the declaration or constructor.33
Parameter 'context' is not assigned and could be declared final35
Parameter 'clientId' is not assigned and could be declared final63
Parameter 'responseStream' is not assigned and could be declared final83
Parameter 'responseWriter' is not assigned and could be declared final91
Parameter 'root' is not assigned and could be declared final99
Parameter 'message' is not assigned and could be declared final103
Parameter 'clientId' is not assigned and could be declared final103

Tobago Core - org/apache/myfaces/tobago/context/Markup.java

ViolationLine
The class 'Markup' has a Cyclomatic Complexity of 4 (Highest = 8).48 - 313
This class has too many methods, consider refactoring it.48 - 313
Parameter 'values' is not assigned and could be declared final93
Assigning an Object to null is a code smell. Consider refactoring.95
Parameter 'value' is not assigned and could be declared final98
Assigning an Object to null is a code smell. Consider refactoring.99
Parameter 'values' is not assigned and could be declared final103
The method 'valueOf' has a Cyclomatic Complexity of 5.103 - 115
Local variable 'markup' could be declared final109
Parameter 'value' is not assigned and could be declared final117
Local variable 'strings' could be declared final122
Parameter 'value' is not assigned and could be declared final129
The method 'valueOf' has a Cyclomatic Complexity of 7.129 - 150
Local variable 'list' could be declared final143
Parameter 'o' is not assigned and could be declared final153
The method 'equals' has a Cyclomatic Complexity of 7.153 - 171
Local variable 'markup' could be declared final161
Avoid if (x != y) ..; else ..;163
Avoid if (x != y) ..; else ..;175
Avoid if (x != y) ..; else ..;176
Parameter 'markup' is not assigned and could be declared final194
The method 'add' has a Cyclomatic Complexity of 6.194 - 213
Use equals() to compare object references.198
Avoid if (x != y) ..; else ..;201 - 212
Parameter 'summand' is not assigned and could be declared final215
The method 'add' has a Cyclomatic Complexity of 6.215 - 239
Parameter 'markup' is not assigned and could be declared final241
Avoid if (x != y) ..; else ..;242 - 251
Parameter 'summand' is not assigned and could be declared final254
The method 'remove' has a Cyclomatic Complexity of 8.254 - 283
Parameter 'markup' is not assigned and could be declared final285
The method 'contains' has a Cyclomatic Complexity of 6.285 - 301

Tobago Core - org/apache/myfaces/tobago/context/MarkupConfig.java

ViolationLine
Private field 'markups' could be made final; it is only initialized in the declaration or constructor.30
Parameter 'markup' is not assigned and could be declared final32
Parameter 'markup' is not assigned and could be declared final36

Tobago Core - org/apache/myfaces/tobago/context/MarkupEditor.java

ViolationLine
Parameter 'text' is not assigned and could be declared final27

Tobago Core - org/apache/myfaces/tobago/context/ResourceManagerFactory.java

ViolationLine
A class which only has private constructors should be final32 - 75
Parameter 'facesContext' is not assigned and could be declared final48
Parameter 'servletContext' is not assigned and could be declared final56
Parameter 'servletContext' is not assigned and could be declared final64
Parameter 'tobagoConfig' is not assigned and could be declared final64
Parameter 'servletContext' is not assigned and could be declared final72

Tobago Core - org/apache/myfaces/tobago/context/ResourceManagerUtils.java

ViolationLine
A class which only has private constructors should be final30 - 177
Parameter 'facesContext' is not assigned and could be declared final36
Parameter 'bundle' is not assigned and could be declared final36
Parameter 'key' is not assigned and could be declared final36
Parameter 'facesContext' is not assigned and could be declared final41
Parameter 'bundle' is not assigned and could be declared final41
Parameter 'key' is not assigned and could be declared final41
Local variable 'result' could be declared final42 - 43
Parameter 'facesContext' is not assigned and could be declared final54
Parameter 'name' is not assigned and could be declared final54
Parameter 'facesContext' is not assigned and could be declared final63
Parameter 'name' is not assigned and could be declared final63
Parameter 'ignoreMissing' is not assigned and could be declared final63
Local variable 'image' could be declared final64 - 65
Parameter 'facesContext' is not assigned and could be declared final73
Parameter 'name' is not assigned and could be declared final73
Local variable 'contextPath' could be declared final74
Local variable 'styles' could be declared final75 - 76
Parameter 'strings' is not assigned and could be declared final80
Parameter 'contextPath' is not assigned and could be declared final80
Local variable 'withContext' could be declared final81
Parameter 'facesContext' is not assigned and could be declared final88
Parameter 'name' is not assigned and could be declared final88
Local variable 'contextPath' could be declared final89
Local variable 'scripts' could be declared final90 - 91
Parameter 'facesContext' is not assigned and could be declared final95
Parameter 'names' is not assigned and could be declared final95
Local variable 'fileNames' could be declared final96
Parameter 'facesContext' is not assigned and could be declared final103
Parameter 'names' is not assigned and could be declared final103
Local variable 'fileNames' could be declared final104
Parameter 'list' is not assigned and could be declared final111
Local variable 'sb' could be declared final112
Parameter 'facesContext' is not assigned and could be declared final124
Parameter 'image' is not assigned and could be declared final124
Local variable 'filename' could be declared final125
Parameter 'facesContext' is not assigned and could be declared final132
Parameter 'facesContext' is not assigned and could be declared final137
Parameter 'name' is not assigned and could be declared final137
Parameter 'configurable' is not assigned and could be declared final142
Parameter 'facesContext' is not assigned and could be declared final142
Parameter 'name' is not assigned and could be declared final142
Parameter 'value' is not assigned and could be declared final156
Local variable 'upper' could be declared final160
This call to String.startsWith can be rewritten using String.charAt(0)161
Parameter 'facesContext' is not assigned and could be declared final167
Parameter 'image' is not assigned and could be declared final167
Parameter 'disabled' is not assigned and could be declared final167

Tobago Core - org/apache/myfaces/tobago/context/ResourceUtils.java

ViolationLine
A class which only has private constructors should be final22 - 70
Parameter 'folder' is not assigned and could be declared final30
Parameter 'extension' is not assigned and could be declared final30
Parameter 'postfix' is not assigned and could be declared final30
Parameter 'component' is not assigned and could be declared final30
Parameter 'name' is not assigned and could be declared final30
Parameter 'folder' is not assigned and could be declared final44
Parameter 'extension' is not assigned and could be declared final44
Parameter 'component' is not assigned and could be declared final44
Parameter 'name' is not assigned and could be declared final44
Parameter 'postfix' is not assigned and could be declared final56
Parameter 'filename' is not assigned and could be declared final56
Local variable 'dotIndex' could be declared final57
Local variable 'name' could be declared final58
Local variable 'extension' could be declared final59

Tobago Core - org/apache/myfaces/tobago/context/ThemeImpl.java

ViolationLine
The class 'ThemeImpl' has a Cyclomatic Complexity of 2 (Highest = 8).33 - 293
Too many fields33 - 293
Parameter 'name' is not assigned and could be declared final75
Parameter 'displayName' is not assigned and could be declared final83
Parameter 'deprecatedName' is not assigned and could be declared final91
Parameter 'resourcePath' is not assigned and could be declared final99
Parameter 'fallback' is not assigned and could be declared final107
Parameter 'fallbackName' is not assigned and could be declared final115
Parameter 'rendererConfigFromTobagoConfig' is not assigned and could be declared final138
The method 'resolveRendererConfig' has a Cyclomatic Complexity of 8.138 - 162
Local variable 'fallback' could be declared final143
Local variable 'fallbackRenderersConfig' could be declared final146
Deeply nested if..then statements are hard to read147 - 152
Local variable 'fallback' could be declared final165
Local variable 'builder' could be declared final174
Parameter 'renderersConfig' is not assigned and could be declared final187
Parameter 'resources' is not assigned and could be declared final207
Avoid if (x != y) ..; else ..;209 - 213
Avoid if (x != y) ..; else ..;215 - 219
The method 'init' has a Cyclomatic Complexity of 7.223 - 246
Parameter 'resources' is not assigned and could be declared final248
Parameter 'toAddResources' is not assigned and could be declared final248
Use equals() to compare object references.249
Local variable 'script' could be declared final253
Local variable 'style' could be declared final258
Parameter 'production' is not assigned and could be declared final264
Parameter 'production' is not assigned and could be declared final271
Parameter 'versioned' is not assigned and could be declared final282
Parameter 'version' is not assigned and could be declared final290

Tobago Core - org/apache/myfaces/tobago/context/ThemeResource.java

ViolationLine
Parameter 'name' is not assigned and could be declared final35
Parameter 'o' is not assigned and could be declared final40
Local variable 'that' could be declared final48
Avoid if (x != y) ..; else ..;50
Avoid if (x != y) ..; else ..;56

Tobago Core - org/apache/myfaces/tobago/context/ThemeResources.java

ViolationLine
Private field 'scriptList' could be made final; it is only initialized in the declaration or constructor.34
Private field 'styleList' could be made final; it is only initialized in the declaration or constructor.35
Local variable 'resources' could be declared final38
Parameter 'production' is not assigned and could be declared final49
Parameter 'script' is not assigned and could be declared final53
Parameter 'style' is not assigned and could be declared final57

Tobago Core - org/apache/myfaces/tobago/context/TobagoBundle.java

ViolationLine
Private field 'bundleName' could be made final; it is only initialized in the declaration or constructor.41
Parameter 'bundleName' is not assigned and could be declared final43
Parameter 'key' is not assigned and could be declared final47
Local variable 'facesContext' could be declared final51

Tobago Core - org/apache/myfaces/tobago/context/TobagoContext.java

ViolationLine
Local variable 'facesContext' could be declared final34
Local variable 'page' could be declared final35

Tobago Core - org/apache/myfaces/tobago/context/TobagoFacesContext.java

ViolationLine
Private field 'scriptFiles' could be made final; it is only initialized in the declaration or constructor.39
Private field 'scriptBlocks' could be made final; it is only initialized in the declaration or constructor.41
Private field 'styleFiles' could be made final; it is only initialized in the declaration or constructor.43
Private field 'styleBlocks' could be made final; it is only initialized in the declaration or constructor.45
Private field 'onloadScripts' could be made final; it is only initialized in the declaration or constructor.47
Private field 'onunloadScripts' could be made final; it is only initialized in the declaration or constructor.49
Private field 'onexitScripts' could be made final; it is only initialized in the declaration or constructor.51
Private field 'onsubmitScripts' could be made final; it is only initialized in the declaration or constructor.53
Private field 'popups' could be made final; it is only initialized in the declaration or constructor.55
Parameter 'context' is not assigned and could be declared final65
Parameter 'ajax' is not assigned and could be declared final98
Parameter 'ajaxComponentId' is not assigned and could be declared final106
Parameter 'enctype' is not assigned and could be declared final114

Tobago Core - org/apache/myfaces/tobago/context/TransientStateHolder.java

ViolationLine
Document empty constructor33 - 34
Parameter 'object' is not assigned and could be declared final36
Parameter 'context' is not assigned and could be declared final40
Parameter 'object' is not assigned and could be declared final45
Parameter 'context' is not assigned and could be declared final57
Parameter 'state' is not assigned and could be declared final57
Parameter 'newTransientValue' is not assigned and could be declared final65

Tobago Core - org/apache/myfaces/tobago/context/UserAgent.java

ViolationLine
A class which only has private constructors should be final30 - 323
The class 'UserAgent' has a Cyclomatic Complexity of 3 (Highest = 16).30 - 323
The class 'UserAgent' has a Cyclomatic Complexity of 3 (Highest = 16).30 - 323
The String literal "msie" appears 11 times in this file; the first occurrence is on line 3838
The String literal "5_0" appears 4 times in this file; the first occurrence is on line 4444
The String literal "opera" appears 4 times in this file; the first occurrence is on line 9393
The String literal "mozilla" appears 4 times in this file; the first occurrence is on line 117117
The String literal "gecko" appears 5 times in this file; the first occurrence is on line 141141
Parameter 'name' is not assigned and could be declared final182
Parameter 'version' is not assigned and could be declared final182
Parameter 'name' is not assigned and could be declared final186
Parameter 'capabilities' is not assigned and could be declared final186
Parameter 'version' is not assigned and could be declared final186
Parameter 'name' is not assigned and could be declared final190
Parameter 'cspHeader' is not assigned and could be declared final190
Parameter 'capabilities' is not assigned and could be declared final190
Parameter 'version' is not assigned and could be declared final190
Parameter 'capability' is not assigned and could be declared final197
Parameter 'reverseOrder' is not assigned and could be declared final221
Local variable 'list' could be declared final222
Parameter 'header' is not assigned and could be declared final243
The method 'getInstance' has a Cyclomatic Complexity of 16.243 - 285
The method 'getInstance' has a Cyclomatic Complexity of 16.243 - 285
Parameter 'id' is not assigned and could be declared final291
Avoid if (x != y) ..; else ..;301 - 303
Parameter 'name' is not assigned and could be declared final315

Tobago Core - org/apache/myfaces/tobago/convert/CurrencyConverter.java

ViolationLine
Parameter 'component' is not assigned and could be declared final36
Parameter 'facesContext' is not assigned and could be declared final36
Parameter 'string' is not assigned and could be declared final36
Parameter 'component' is not assigned and could be declared final45
Parameter 'facesContext' is not assigned and could be declared final45
Parameter 'object' is not assigned and could be declared final45

Tobago Core - org/apache/myfaces/tobago/convert/DurationConverter.java

ViolationLine
The class 'DurationConverter' has a Cyclomatic Complexity of 8 (Highest = 10).37 - 150
The class 'DurationConverter' has a Cyclomatic Complexity of 8 (Highest = 10).37 - 150
The method 'getAsString' has a Cyclomatic Complexity of 8.51 - 85
Parameter 'component' is not assigned and could be declared final52
Parameter 'facesContext' is not assigned and could be declared final52
Parameter 'object' is not assigned and could be declared final52
Local variable 'factor' could be declared final63
Local variable 'format' could be declared final66
Unnecessary wrapper object creation67
Local variable 'seconds' could be declared final68
Local variable 'minutes' could be declared final70
The method 'getAsObject' has a Cyclomatic Complexity of 5.87 - 119
Parameter 'component' is not assigned and could be declared final88
Parameter 'facesContext' is not assigned and could be declared final88
Parameter 'string' is not assigned and could be declared final88
Local variable 'negative' could be declared final90
Local variable 'tokenizer' could be declared final91
Local variable 'elements' could be declared final92
Local variable 'factor' could be declared final112
Local variable 'value' could be declared final113
Parameter 'component' is not assigned and could be declared final121
The method 'getUnitFactor' has a Cyclomatic Complexity of 10.121 - 148
The method 'getUnitFactor' has a Cyclomatic Complexity of 10.121 - 148

Tobago Core - org/apache/myfaces/tobago/convert/LocaleConverter.java

ViolationLine
Parameter 'component' is not assigned and could be declared final35
Parameter 'facesContext' is not assigned and could be declared final35
Parameter 'value' is not assigned and could be declared final35
Local variable 'locale' could be declared final36
Parameter 'component' is not assigned and could be declared final44
Parameter 'facesContext' is not assigned and could be declared final44
Parameter 'value' is not assigned and could be declared final44

Tobago Core - org/apache/myfaces/tobago/convert/ThemeConverter.java

ViolationLine
Parameter 'component' is not assigned and could be declared final40
Parameter 'facesContext' is not assigned and could be declared final40
Parameter 'object' is not assigned and could be declared final40
Parameter 'component' is not assigned and could be declared final50
Parameter 'facesContext' is not assigned and could be declared final50
Parameter 'string' is not assigned and could be declared final50

Tobago Core - org/apache/myfaces/tobago/el/ConstantMethodBinding.java

ViolationLine
Parameter 'outcome' is not assigned and could be declared final33
Document empty constructor38 - 39
Parameter 'facesContext' is not assigned and could be declared final41
Parameter 'parameters' is not assigned and could be declared final41
Parameter 'facesContext' is not assigned and could be declared final45

Tobago Core - org/apache/myfaces/tobago/el/UserWrapper.java

ViolationLine
This class has too many methods, consider refactoring it.31 - 110
Private field 'roles' could be made final; it is only initialized in the declaration or constructor.35
Local variable 'facesContext' could be declared final42
Local variable 'principal' could be declared final43
This class has too many methods, consider refactoring it.54 - 109
Parameter 'key' is not assigned and could be declared final56
Local variable 'role' could be declared final57
Local variable 'facesContext' could be declared final58
Local variable 'inRole' could be declared final59
Parameter 'key' is not assigned and could be declared final78
Parameter 'value' is not assigned and could be declared final82
Parameter 't' is not assigned and could be declared final90
Parameter 'key' is not assigned and could be declared final102
Parameter 'value' is not assigned and could be declared final106
Parameter 'key' is not assigned and could be declared final106

Tobago Core - org/apache/myfaces/tobago/event/AbstractPopupActionListener.java

ViolationLine
The class 'AbstractPopupActionListener' has a Cyclomatic Complexity of 4 (Highest = 5).33 - 56
Parameter 'actionEvent' is not assigned and could be declared final37
The method 'processAction' has a Cyclomatic Complexity of 5.37 - 53
Local variable 'popup' could be declared final38

Tobago Core - org/apache/myfaces/tobago/event/AbstractResetInputActionListener.java

ViolationLine
Parameter 'component' is not assigned and could be declared final29
Local variable 'it' could be declared final30
Local variable 'child' could be declared final32
Parameter 'editableValueHolder' is not assigned and could be declared final40

Tobago Core - org/apache/myfaces/tobago/event/FacesEventWrapper.java

ViolationLine
Private field 'wrappedFacesEvent' could be made final; it is only initialized in the declaration or constructor.31
Parameter 'facesEvent' is not assigned and could be declared final33
Parameter 'redirectComponent' is not assigned and could be declared final33
Parameter 'phaseId' is not assigned and could be declared final44
Parameter 'faceslistener' is not assigned and could be declared final60
Parameter 'faceslistener' is not assigned and could be declared final65

Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionStateChangeListener.java

ViolationLine
Document empty constructor35 - 36
Parameter 'methodExpression' is not assigned and could be declared final38
Parameter 'actionEvent' is not assigned and could be declared final42
Parameter 'context' is not assigned and could be declared final46
Parameter 'state' is not assigned and could be declared final46
Parameter 'context' is not assigned and could be declared final50
Parameter 'newTransientValue' is not assigned and could be declared final54

Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTabChangeListener.java

ViolationLine
Document empty constructor35 - 36
Parameter 'methodExpression' is not assigned and could be declared final38
Parameter 'actionEvent' is not assigned and could be declared final42
Parameter 'context' is not assigned and could be declared final46
Parameter 'state' is not assigned and could be declared final46
Parameter 'context' is not assigned and could be declared final50
Parameter 'newTransientValue' is not assigned and could be declared final54

Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.java

ViolationLine
Document empty constructor36 - 37
Parameter 'methodExpression' is not assigned and could be declared final39
Parameter 'event' is not assigned and could be declared final43
Avoid unused private methods such as 'elContext()'.47
Avoid unused private methods such as 'elContext()'.47
Parameter 'context' is not assigned and could be declared final51
Parameter 'state' is not assigned and could be declared final51
Parameter 'context' is not assigned and could be declared final55
Parameter 'newTransientValue' is not assigned and could be declared final59

Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTreeMarkedListener.java

ViolationLine
Document empty constructor36 - 37
Parameter 'methodExpression' is not assigned and could be declared final39
Parameter 'event' is not assigned and could be declared final43
Avoid unused private methods such as 'elContext()'.47
Avoid unused private methods such as 'elContext()'.47
Parameter 'context' is not assigned and could be declared final51
Parameter 'state' is not assigned and could be declared final51
Parameter 'context' is not assigned and could be declared final55
Parameter 'newTransientValue' is not assigned and could be declared final59

Tobago Core - org/apache/myfaces/tobago/event/PageAction.java

ViolationLine
Parameter 'token' is not assigned and could be declared final59
Parameter 'name' is not assigned and could be declared final83
Local variable 'value' could be declared final84
Avoid if (x != y) ..; else ..;85 - 89

Tobago Core - org/apache/myfaces/tobago/event/PageActionEvent.java

ViolationLine
Private field 'action' could be made final; it is only initialized in the declaration or constructor.31
Parameter 'component' is not assigned and could be declared final34
Parameter 'action' is not assigned and could be declared final34
Parameter 'value' is not assigned and could be declared final46

Tobago Core - org/apache/myfaces/tobago/event/PopupActionListener.java

ViolationLine
Document empty constructor37 - 38
Parameter 'popupId' is not assigned and could be declared final40
Parameter 'actionEvent' is not assigned and could be declared final48
Local variable 'facesContext' could be declared final49
Local variable 'popup' could be declared final50
Parameter 'context' is not assigned and could be declared final62
Parameter 'state' is not assigned and could be declared final62
Local variable 'values' could be declared final63
Parameter 'context' is not assigned and could be declared final67
Parameter 'newTransientValue' is not assigned and could be declared final73

Tobago Core - org/apache/myfaces/tobago/event/PopupFacetActionListener.java

ViolationLine
Parameter 'actionEvent' is not assigned and could be declared final36
Local variable 'component' could be declared final37

Tobago Core - org/apache/myfaces/tobago/event/ResetFormActionListener.java

ViolationLine
Parameter 'actionEvent' is not assigned and could be declared final30

Tobago Core - org/apache/myfaces/tobago/event/ResetInputActionListener.java

ViolationLine
Document empty constructor34 - 35
Parameter 'clientIds' is not assigned and could be declared final37
Parameter 'clientIds' is not assigned and could be declared final41
Parameter 'event' is not assigned and could be declared final45
Local variable 'component' could be declared final47
Parameter 'newTransientValue' is not assigned and could be declared final58
Parameter 'context' is not assigned and could be declared final62
Parameter 'state' is not assigned and could be declared final62
Local variable 'values' could be declared final63
Parameter 'context' is not assigned and could be declared final67

Tobago Core - org/apache/myfaces/tobago/event/SheetStateChangeEvent.java

ViolationLine
Parameter 'uiComponent' is not assigned and could be declared final30
Parameter 'facesListener' is not assigned and could be declared final34
Parameter 'facesListener' is not assigned and could be declared final38

Tobago Core - org/apache/myfaces/tobago/event/SortActionEvent.java

ViolationLine
Private field 'column' could be made final; it is only initialized in the declaration or constructor.31
Parameter 'column' is not assigned and could be declared final33
Parameter 'sheet' is not assigned and could be declared final33

Tobago Core - org/apache/myfaces/tobago/event/TabChangeEvent.java

ViolationLine
Parameter 'oldTabIndex' is not assigned and could be declared final33
Parameter 'uiComponent' is not assigned and could be declared final33
Parameter 'newTabIndex' is not assigned and could be declared final33
Parameter 'oldState' is not assigned and could be declared final43
Parameter 'newState' is not assigned and could be declared final43
Parameter 'uiComponent' is not assigned and could be declared final43
Overridable method 'setOldState' called during object construction45
Overridable method 'setNewState' called during object construction46
Parameter 'facesListener' is not assigned and could be declared final49
Parameter 'facesListener' is not assigned and could be declared final53
Parameter 'oldTabIndex' is not assigned and could be declared final79
Parameter 'newTabIndex' is not assigned and could be declared final95

Tobago Core - org/apache/myfaces/tobago/event/TreeExpansionEvent.java

ViolationLine
The class 'TreeExpansionEvent' has a Cyclomatic Complexity of 2 (Highest = 6).26 - 72
Private field 'oldExpanded' could be made final; it is only initialized in the declaration or constructor.30
Private field 'newExpanded' could be made final; it is only initialized in the declaration or constructor.31
Parameter 'oldExpanded' is not assigned and could be declared final33
Parameter 'node' is not assigned and could be declared final33
Parameter 'newExpanded' is not assigned and could be declared final33
Parameter 'facesListener' is not assigned and could be declared final39
Parameter 'facesListener' is not assigned and could be declared final43
The method 'processListener' has a Cyclomatic Complexity of 6.43 - 54
Avoid empty if statements50 - 52
Avoid empty if statements50 - 52

Tobago Core - org/apache/myfaces/tobago/event/TreeMarkedEvent.java

ViolationLine
The class 'TreeMarkedEvent' has a Cyclomatic Complexity of 2 (Highest = 6).26 - 67
Private field 'oldMarked' could be made final; it is only initialized in the declaration or constructor.30
Private field 'newMarked' could be made final; it is only initialized in the declaration or constructor.31
Parameter 'node' is not assigned and could be declared final33
Parameter 'oldMarked' is not assigned and could be declared final33
Parameter 'newMarked' is not assigned and could be declared final33
Parameter 'facesListener' is not assigned and could be declared final39
Parameter 'facesListener' is not assigned and could be declared final43
The method 'processListener' has a Cyclomatic Complexity of 6.43 - 53
Avoid empty if statements49 - 51
Avoid empty if statements49 - 51

Tobago Core - org/apache/myfaces/tobago/event/ValueBindingPopupActionListener.java

ViolationLine
Document empty constructor46 - 47
Parameter 'binding' is not assigned and could be declared final49
Parameter 'actionEvent' is not assigned and could be declared final54
Local variable 'id' could be declared final55
Local variable 'popup' could be declared final56
Parameter 'context' is not assigned and could be declared final70
Parameter 'state' is not assigned and could be declared final70
Local variable 'values' could be declared final71
Parameter 'context' is not assigned and could be declared final75
Parameter 'newTransientValue' is not assigned and could be declared final82

Tobago Core - org/apache/myfaces/tobago/event/ValueBindingResetInputActionListener.java

ViolationLine
The class 'ValueBindingResetInputActionListener' has a Cyclomatic Complexity of 2 (Highest = 5).40 - 93
Document empty constructor48 - 49
Parameter 'binding' is not assigned and could be declared final51
Parameter 'event' is not assigned and could be declared final55
The method 'processAction' has a Cyclomatic Complexity of 5.55 - 72
Local variable 'obj' could be declared final56
Local variable 'component' could be declared final67
Parameter 'context' is not assigned and could be declared final78
Parameter 'state' is not assigned and could be declared final78
Local variable 'values' could be declared final79
Parameter 'context' is not assigned and could be declared final83
Parameter 'newTransientValue' is not assigned and could be declared final89

Tobago Core - org/apache/myfaces/tobago/event/ValueBindingTabChangeListener.java

ViolationLine
The class 'ValueBindingTabChangeListener' has a Cyclomatic Complexity of 2 (Highest = 8).34 - 105
Document empty constructor39 - 40
Parameter 'type' is not assigned and could be declared final42
Parameter 'valueBinding' is not assigned and could be declared final42
Parameter 'tabChangeEvent' is not assigned and could be declared final47
Local variable 'handler' could be declared final48
Avoid if (x != y) ..; else ..;49 - 53
Parameter 'context' is not assigned and could be declared final56
Parameter 'context' is not assigned and could be declared final63
Parameter 'state' is not assigned and could be declared final63
Local variable 'values' could be declared final64
Parameter 'newTransientValue' is not assigned and could be declared final74
The method 'getTabChangeListener' has a Cyclomatic Complexity of 8.78 - 93
Local variable 'obj' could be declared final81
No need to check for null before an instanceof82
Parameter 'className' is not assigned and could be declared final95
Local variable 'clazz' could be declared final97

Tobago Core - org/apache/myfaces/tobago/event/ValueExpressionPopupActionListener.java

ViolationLine
Parameter 'expression' is not assigned and could be declared final40
Parameter 'expression' is not assigned and could be declared final48
Document empty constructor55 - 56
Parameter 'actionEvent' is not assigned and could be declared final59
Local variable 'id' could be declared final60
Local variable 'popup' could be declared final61
Parameter 'context' is not assigned and could be declared final75
Parameter 'state' is not assigned and could be declared final75
Local variable 'values' could be declared final76
Parameter 'context' is not assigned and could be declared final80
Parameter 'newTransientValue' is not assigned and could be declared final87

Tobago Core - org/apache/myfaces/tobago/event/ValueExpressionResetInputActionListener.java

ViolationLine
The class 'ValueExpressionResetInputActionListener' has a Cyclomatic Complexity of 2 (Highest = 5).35 - 90
Document empty constructor44 - 45
Parameter 'clientIdsExpression' is not assigned and could be declared final47
Parameter 'event' is not assigned and could be declared final51
The method 'processAction' has a Cyclomatic Complexity of 5.51 - 68
Local variable 'obj' could be declared final52
Local variable 'component' could be declared final63
Parameter 'context' is not assigned and could be declared final74
Parameter 'state' is not assigned and could be declared final74
Local variable 'values' could be declared final75
Parameter 'context' is not assigned and could be declared final79
Parameter 'newTransientValue' is not assigned and could be declared final86

Tobago Core - org/apache/myfaces/tobago/event/ValueExpressionSheetStateChangeListener.java

ViolationLine
The class 'ValueExpressionSheetStateChangeListener' has a Cyclomatic Complexity of 2 (Highest = 8).30 - 102
Document empty constructor37 - 38
Parameter 'valueExpression' is not assigned and could be declared final40
Parameter 'type' is not assigned and could be declared final40
Parameter 'sheetStateChangeEvent' is not assigned and could be declared final45
Local variable 'handler' could be declared final46
Avoid if (x != y) ..; else ..;47 - 51
Parameter 'context' is not assigned and could be declared final54
Parameter 'context' is not assigned and could be declared final61
Parameter 'state' is not assigned and could be declared final61
Local variable 'values' could be declared final62
Parameter 'newTransientValue' is not assigned and could be declared final72
The method 'getSheetStateChangeListener' has a Cyclomatic Complexity of 8.76 - 91
Local variable 'obj' could be declared final79
No need to check for null before an instanceof80
Parameter 'className' is not assigned and could be declared final93
Local variable 'clazz' could be declared final95

Tobago Core - org/apache/myfaces/tobago/event/ValueExpressionTabChangeListener.java

ViolationLine
The class 'ValueExpressionTabChangeListener' has a Cyclomatic Complexity of 2 (Highest = 8).30 - 102
Document empty constructor37 - 38
Parameter 'valueExpression' is not assigned and could be declared final40
Parameter 'type' is not assigned and could be declared final40
Parameter 'tabChangeEvent' is not assigned and could be declared final45
Local variable 'handler' could be declared final46
Avoid if (x != y) ..; else ..;47 - 51
Parameter 'context' is not assigned and could be declared final54
Parameter 'context' is not assigned and could be declared final61
Parameter 'state' is not assigned and could be declared final61
Local variable 'values' could be declared final62
Parameter 'newTransientValue' is not assigned and could be declared final72
The method 'getTabChangeListener' has a Cyclomatic Complexity of 8.76 - 91
Local variable 'obj' could be declared final79
No need to check for null before an instanceof80
Parameter 'className' is not assigned and could be declared final93
Local variable 'clazz' could be declared final95

Tobago Core - org/apache/myfaces/tobago/internal/ajax/AjaxInternalUtils.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.42 - 215
The class 'AjaxInternalUtils' has a Cyclomatic Complexity of 3 (Highest = 6).42 - 215
Parameter 'facesContext' is not assigned and could be declared final51
Parameter 'compClass' is not assigned and could be declared final51
Parameter 'uiComponent' is not assigned and could be declared final51
The method 'checkParamValidity' has a Cyclomatic Complexity of 5.51 - 65
Parameter 'component' is not assigned and could be declared final67
Parameter 'facesContext' is not assigned and could be declared final67
The method 'encodeAjaxComponent' has a Cyclomatic Complexity of 5.67 - 78
Local variable 'renderer' could be declared final74
No need to check for null before an instanceof75
Parameter 'facesContext' is not assigned and could be declared final80
Local variable 'ajaxComponents' could be declared final81
Local variable 'viewRoot' could be declared final83
Local variable 'page' could be declared final84
Parameter 'facesContext' is not assigned and could be declared final88
Parameter 'messages' is not assigned and could be declared final88
Local variable 'attributes' could be declared final89
Parameter 'facesContext' is not assigned and could be declared final100
Parameter 'facesContext' is not assigned and could be declared final104
Local variable 'parameterMap' could be declared final105
Local variable 'component' could be declared final106
Local variable 'clientId' could be declared final107
Local variable 'ids' could be declared final108
Local variable 'list' could be declared final109
Local variable 'tokenizer' could be declared final111
Local variable 'id' could be declared final113
Parameter 'facesContext' is not assigned and could be declared final121
The method 'parseAndStoreComponents' has a Cyclomatic Complexity of 6.121 - 146
Local variable 'parameterMap' could be declared final122
Local variable 'ajaxComponentIds' could be declared final123
Local variable 'tokenizer' could be declared final128
Local variable 'ajaxComponents' could be declared final129
Local variable 'viewRoot' could be declared final132
Local variable 'ajaxId' could be declared final134
Local variable 'ajaxComponent' could be declared final135
Parameter 'facesContext' is not assigned and could be declared final148
Parameter 'component' is not assigned and could be declared final154
Parameter 'facesContext' is not assigned and could be declared final154
Local variable 'ajaxComponents' could be declared final155 - 156
These nested if statements could be combined158 - 160
These nested if statements could be combined158 - 160
Parameter 'value' is not assigned and could be declared final164
Parameter 'component' is not assigned and could be declared final171
Parameter 'ajaxComponents' is not assigned and could be declared final171
Parameter 'context' is not assigned and could be declared final186
Parameter 'componentClientId' is not assigned and could be declared final186
Parameter 'facesContext' is not assigned and could be declared final199
Parameter 'clientId' is not assigned and could be declared final199
Parameter 'component' is not assigned and could be declared final203
Parameter 'facesContext' is not assigned and could be declared final203
Local variable 'ajaxComponents' could be declared final208
These nested if statements could be combined210 - 212
These nested if statements could be combined210 - 212

Tobago Core - org/apache/myfaces/tobago/internal/ajax/AjaxResponseRenderer.java

ViolationLine
The class 'AjaxResponseRenderer' has a Cyclomatic Complexity of 2 (Highest = 6).47 - 224
Private field 'callback' could be made final; it is only initialized in the declaration or constructor.60
Parameter 'facesContext' is not assigned and could be declared final66
Local variable 'renderFactory' could be declared final68 - 69
Local variable 'renderKit' could be declared final70 - 71
Avoid unused local variables such as 'incomingViewRoot'.73
Local variable 'incomingViewRoot' could be declared final73 - 74
Avoid unused local variables such as 'incomingViewRoot'.73
Parameter 'renderKit' is not assigned and could be declared final108
Parameter 'component' is not assigned and could be declared final108
Parameter 'facesContext' is not assigned and could be declared final108
Parameter 'clientId' is not assigned and could be declared final108
Parameter 'renderKit' is not assigned and could be declared final137
Parameter 'facesContext' is not assigned and could be declared final137
Local variable 'stateWriter' could be declared final139
Local variable 'stateManager' could be declared final142
Local variable 'serializedView' could be declared final143
Avoid reassigning parameters such as 'charset'147
Parameter 'facesContext' is not assigned and could be declared final147
Parameter 'contentType' is not assigned and could be declared final147
Local variable 'sb' could be declared final148
Parameter 'renderKit' is not assigned and could be declared final157
Parameter 'facesContext' is not assigned and could be declared final157
Parameter 'reloadRequired' is not assigned and could be declared final157
The method 'writeResponse' has a Cyclomatic Complexity of 6.157 - 201
Local variable 'page' could be declared final162
Avoid if (x != y) ..; else ..;164 - 168
Local variable 'writer' could be declared final171
Local variable 'ajaxComponents' could be declared final176
Local variable 'component' could be declared final185
Parameter 'facesContext' is not assigned and could be declared final203
Local variable 'externalContext' could be declared final204
Parameter 'renderKit' is not assigned and could be declared final214
Parameter 'writer' is not assigned and could be declared final214
Local variable 'newWriter' could be declared final216

Tobago Core - org/apache/myfaces/tobago/internal/application/ViewHandlerImpl.java

ViolationLine
Private field 'base' could be made final; it is only initialized in the declaration or constructor.45
Parameter 'base' is not assigned and could be declared final47
Parameter 'facesContext' is not assigned and could be declared final54
Parameter 'facesContext' is not assigned and could be declared final58
Parameter 'facesContext' is not assigned and could be declared final62
Parameter 'viewId' is not assigned and could be declared final62
Parameter 'facesContext' is not assigned and could be declared final83
Parameter 'viewId' is not assigned and could be declared final83
Parameter 'facesContext' is not assigned and could be declared final92
Parameter 'path' is not assigned and could be declared final92
Parameter 'facesContext' is not assigned and could be declared final96
Parameter 'viewRoot' is not assigned and could be declared final96
Parameter 'facesContext' is not assigned and could be declared final107
Parameter 'viewId' is not assigned and could be declared final107
Local variable 'viewRoot' could be declared final114
Consider simply returning the value vs storing it in local variable 'viewRoot'115
Parameter 'facesContext' is not assigned and could be declared final118

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIBox.java

ViolationLine
Parameter 'context' is not assigned and could be declared final27
Parameter 'context' is not assigned and could be declared final36
Parameter 'context' is not assigned and could be declared final43

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIButton.java

ViolationLine
No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead.24 - 26

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUICell.java

ViolationLine
Parameter 'spanX' is not assigned and could be declared final40
Parameter 'spanY' is not assigned and could be declared final48

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIColumn.java

ViolationLine
An empty method in an abstract class should be abstract instead31 - 33

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIColumnNode.java

ViolationLine
No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead.27 - 28

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIColumnSelector.java

ViolationLine
An empty method in an abstract class should be abstract instead27 - 29

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUICommand.java

ViolationLine
No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead.24 - 27

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUICommandBase.java

ViolationLine
The class 'AbstractUICommandBase' has a Cyclomatic Complexity of 2 (Highest = 5).34 - 96
Parameter 'facesContext' is not assigned and could be declared final37
Parameter 'parent' is not assigned and could be declared final37
Local variable 'popup' could be declared final38
These nested if statements could be combined40 - 42
These nested if statements could be combined40 - 42
Parameter 'context' is not assigned and could be declared final46
The method 'processDecodes' has a Cyclomatic Complexity of 5.46 - 69
Local variable 'kids' could be declared final64
Local variable 'kid' could be declared final66
Parameter 'facesEvent' is not assigned and could be declared final71

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIData.java

ViolationLine
The class 'AbstractUIData' has a Cyclomatic Complexity of 2 (Highest = 7).41 - 249
This class has too many methods, consider refactoring it.41 - 249
The String literal "Not a tree model" appears 4 times in this file; the first occurrence is on line 6767
Avoid if (x != y) ..; else ..;76 - 80
Local variable 'value' could be declared final85
Local variable 'showRoot' could be declared final86
Avoid if (x != y) ..; else ..;98
Parameter 'showRoot' is not assigned and could be declared final109
Parameter 'value' is not assigned and could be declared final109
Parameter 'context' is not assigned and could be declared final117
Avoid if (x != y) ..; else ..;138 - 142
Avoid if (x != y) ..; else ..;147
Avoid if (x != y) ..; else ..;152
An empty method in an abstract class should be abstract instead157 - 159
An empty method in an abstract class should be abstract instead174 - 176
Parameter 'facesContext' is not assigned and could be declared final179
Parameter 'callback' is not assigned and could be declared final179
Parameter 'clientId' is not assigned and could be declared final179
The method 'invokeOnComponent' has a Cyclomatic Complexity of 7.179 - 215
Local variable 'oldRowIndex' could be declared final182
Local variable 'sheetId' could be declared final184
Local variable 'idx' could be declared final192
String.indexOf(char) is faster than String.indexOf(String).192
Local variable 'rowIndex' could be declared final194

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIDatePicker.java

ViolationLine
Avoid unused private fields such as 'LOG'.37
Avoid unused private fields such as 'LOG'.37
Parameter 'facesEvent' is not assigned and could be declared final48
Local variable 'facesContext' could be declared final49
Local variable 'popup' could be declared final50
Local variable 'clientId' could be declared final51
Local variable 'box' could be declared final52
Local variable 'calendar' could be declared final53
Local variable 'time' could be declared final55
Parameter 'context' is not assigned and could be declared final62
Parameter 'parent' is not assigned and could be declared final62
Local variable 'renderer' could be declared final63
An empty method in an abstract class should be abstract instead69 - 71
An empty method in an abstract class should be abstract instead73 - 75

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIFile.java

ViolationLine
The class 'AbstractUIFile' has a Cyclomatic Complexity of 2 (Highest = 5).31 - 59
Parameter 'facesContext' is not assigned and could be declared final33
The method 'validate' has a Cyclomatic Complexity of 5.33 - 47
Local variable 'file' could be declared final36
Parameter 'facesContext' is not assigned and could be declared final49

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIFlowLayout.java

ViolationLine
Document empty method30 - 31
An empty method in an abstract class should be abstract instead30 - 31
Document empty method33 - 34
An empty method in an abstract class should be abstract instead33 - 34
Parameter 'orientation' is not assigned and could be declared final33
Parameter 'auto' is not assigned and could be declared final33
Document empty method36 - 37
An empty method in an abstract class should be abstract instead36 - 37
Parameter 'orientation' is not assigned and could be declared final36
Document empty method39 - 41
An empty method in an abstract class should be abstract instead39 - 41
Parameter 'orientation' is not assigned and could be declared final39
Document empty method43 - 44
An empty method in an abstract class should be abstract instead43 - 44
Parameter 'orientation' is not assigned and could be declared final43

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIForm.java

ViolationLine
The class 'AbstractUIForm' has a Cyclomatic Complexity of 4 (Highest = 5).37 - 121
Parameter 'facesContext' is not assigned and could be declared final45
Local variable 'kids' could be declared final52
Local variable 'kid' could be declared final54
Parameter 'b' is not assigned and could be declared final60
Parameter 'facesContext' is not assigned and could be declared final70
The method 'processValidators' has a Cyclomatic Complexity of 5.70 - 87
Avoid if (x != y) ..; else ..;75 - 86
Local variable 'kids' could be declared final81
Local variable 'kid' could be declared final83
Parameter 'facesContext' is not assigned and could be declared final90
The method 'processUpdates' has a Cyclomatic Complexity of 5.90 - 107
Avoid if (x != y) ..; else ..;95 - 106
Local variable 'kids' could be declared final101
Local variable 'kid' could be declared final103
Parameter 'context' is not assigned and could be declared final110
Parameter 'callback' is not assigned and could be declared final110
Parameter 'clientId' is not assigned and could be declared final110
These nested if statements could be combined114 - 116
These nested if statements could be combined114 - 116

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIGridLayout.java

ViolationLine
The class 'AbstractUIGridLayout' has a Cyclomatic Complexity of 4 (Highest = 21).51 - 496
The class 'AbstractUIGridLayout' has a Cyclomatic Complexity of 4 (Highest = 21).51 - 496
The method 'init' has a Cyclomatic Complexity of 5.62 - 85
Local variable 'components' could be declared final70
Avoid instantiating new objects inside loops74
Parameter 'orientation' is not assigned and could be declared final87
Parameter 'auto' is not assigned and could be declared final87
The method 'fixRelativeInsideAuto' has a Cyclomatic Complexity of 13.87 - 132
The method fixRelativeInsideAuto() has an NPath complexity of 21087 - 132
The method 'fixRelativeInsideAuto' has a Cyclomatic Complexity of 13.87 - 132
Local variable 'heads' could be declared final93
Local variable 'heads2' could be declared final94
Deeply nested if..then statements are hard to read99 - 102
Local variable 'cell' could be declared final111
Local variable 'origin' could be declared final118
Local variable 'component' could be declared final119
Local variable 'layoutManager' could be declared final121
Local variable 'childAuto' could be declared final123
Parameter 'orientation' is not assigned and could be declared final134
The method 'preProcessing' has a Cyclomatic Complexity of 20.134 - 231
The method preProcessing() has an NPath complexity of 5060134 - 231
The method 'preProcessing' has a Cyclomatic Complexity of 20.134 - 231
Local variable 'token' could be declared final147
Local variable 'pixel' could be declared final150
Local variable 'intervalList' could be declared final154
Avoid instantiating new objects inside loops154
Local variable 'cell' could be declared final156
Local variable 'origin' could be declared final158
Local variable 'component' could be declared final159
Avoid instantiating new objects inside loops167
Deeply nested if..then statements are hard to read169 - 172
Avoid empty if statements207 - 210
Avoid empty if statements207 - 210
Assigning an Object to null is a code smell. Consider refactoring.214
Parameter 'orientation' is not assigned and could be declared final233
The method 'mainProcessing' has a Cyclomatic Complexity of 21.233 - 332
The method mainProcessing() has an NPath complexity of 17600233 - 332
The method 'mainProcessing' has a Cyclomatic Complexity of 21.233 - 332
Local variable 'factorList' could be declared final243
Local variable 'container' could be declared final251
Avoid if (x != y) ..; else ..;253 - 287
Local variable 'client' could be declared final266
Local variable 'partition' could be declared final272
Local variable 'cell' could be declared final293
Local variable 'component' could be declared final295
Local variable 'span' could be declared final299
Local variable 'current' could be declared final307
Parameter 'orientation' is not assigned and could be declared final334
The method 'postProcessing' has a Cyclomatic Complexity of 13.334 - 388
The method 'postProcessing' has a Cyclomatic Complexity of 13.334 - 388
Local variable 'cell' could be declared final346
Local variable 'component' could be declared final348
Parameter 'orientation' is not assigned and could be declared final395
Parameter 'orientation' is not assigned and could be declared final399
Parameter 'orientation' is not assigned and could be declared final403
Parameter 'orientation' is not assigned and could be declared final411
Parameter 'startIndex' is not assigned and could be declared final411
Parameter 'length' is not assigned and could be declared final411
The method 'computeSpacing' has a Cyclomatic Complexity of 6.411 - 427
An empty method in an abstract class should be abstract instead457 - 459
Parameter 'depth' is not assigned and could be declared final461
The method 'toString' has a Cyclomatic Complexity of 6.461 - 490
Local variable 'builder' could be declared final462

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIInput.java

ViolationLine
Parameter 'facesContext' is not assigned and could be declared final32

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUILabel.java

ViolationLine
No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead.24 - 26

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUILayoutBase.java

ViolationLine
No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead.24 - 25

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIMediator.java

ViolationLine
Avoid unused private fields such as 'LOG'.34
Avoid unused private fields such as 'LOG'.34
Parameter 'facesContext' is not assigned and could be declared final39
Parameter 'facesContext' is not assigned and could be declared final47
Parameter 'event' is not assigned and could be declared final55
Local variable 'requestMap' could be declared final56
Parameter 'context' is not assigned and could be declared final66
Parameter 'context' is not assigned and could be declared final74
Parameter 'state' is not assigned and could be declared final74
Local variable 'values' could be declared final75
Parameter 'var' is not assigned and could be declared final84

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIMenu.java

ViolationLine
No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead.24 - 25

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIMenuBar.java

ViolationLine
Parameter 'context' is not assigned and could be declared final33
Parameter 'parent' is not assigned and could be declared final33
Local variable 'renderer' could be declared final34

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIMessages.java

ViolationLine
The class 'AbstractUIMessages' has a Cyclomatic Complexity of 3 (Highest = 7).33 - 136
Parameter 'facesContext' is not assigned and could be declared final36
Avoid if (x != y) ..; else ..;41 - 45
Local variable 'messages' could be declared final47
Parameter 'facesContext' is not assigned and could be declared final57
Parameter 'clientIds' is not assigned and could be declared final57
The method 'collectMessageList' has a Cyclomatic Complexity of 7.57 - 77
Local variable 'messages' could be declared final58
Local variable 'clientId' could be declared final60
Local variable 'i' could be declared final61
Local variable 'facesMessage' could be declared final63
Avoid instantiating new objects inside loops73
Parameter 'facesMessage' is not assigned and could be declared final84
Parameter 'clientId' is not assigned and could be declared final84
Parameter 'clientId' is not assigned and could be declared final93
Parameter 'facesMessage' is not assigned and could be declared final101
Parameter 'item2' is not assigned and could be declared final107
Parameter 'item1' is not assigned and could be declared final107
Parameter 'key' is not assigned and could be declared final132
When doing a String.toLowerCase()/toUpperCase() call, use a Locale133

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIOut.java

ViolationLine
No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead.26 - 27

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIPage.java

ViolationLine
A high number of imports can indicate a high degree of coupling within an object.20 - 299
The class 'AbstractUIPage' has a Cyclomatic Complexity of 2 (Highest = 11).57 - 299
The class 'AbstractUIPage' has a Cyclomatic Complexity of 2 (Highest = 11).57 - 299
An empty method in an abstract class should be abstract instead75 - 77
Parameter 'facesContext' is not assigned and could be declared final79
Parameter 'facesContext' is not assigned and could be declared final87
Parameter 'facesContext' is not assigned and could be declared final94
Parameter 'facesContext' is not assigned and could be declared final100
Parameter 'facesContext' is not assigned and could be declared final107
Local variable 'kids' could be declared final116
Local variable 'kid' could be declared final117
Parameter 'facesContext' is not assigned and could be declared final122
The method 'markSubmittedForm' has a Cyclomatic Complexity of 11.122 - 177
The method 'markSubmittedForm' has a Cyclomatic Complexity of 11.122 - 177
Avoid empty catch blocks152 - 154
Avoid empty catch blocks152 - 154
Avoid if (x != y) ..; else ..;163 - 176
Local variable 'form' could be declared final164
Parameter 'facesContext' is not assigned and could be declared final179
The method 'checkTobagoRequest' has a Cyclomatic Complexity of 7.179 - 203
Local variable 'contentType' could be declared final181 - 182
Local variable 'request' could be declared final184
Local variable 'wrappedRequest' could be declared final189 - 190
Parameter 'context' is not assigned and could be declared final213
Document empty method223 - 224
An empty method in an abstract class should be abstract instead223 - 224
Parameter 'facesContext' is not assigned and could be declared final223
Parameter 'facesContext' is not assigned and could be declared final231
Avoid if (x != y) ..; else ..;233 - 243
Parameter 'actionId' is not assigned and could be declared final250
Parameter 'actionPosition' is not assigned and could be declared final258
Parameter 'defaultActionId' is not assigned and could be declared final269
Parameter 'facesContext' is not assigned and could be declared final273
Parameter 'parent' is not assigned and could be declared final273
Parameter 'layoutManager' is not assigned and could be declared final288

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIPanel.java

ViolationLine
Parameter 'facesContext' is not assigned and could be declared final41
Parameter 'facesContext' is not assigned and could be declared final48
Parameter 'facesContext' is not assigned and could be declared final54
Parameter 'facesContext' is not assigned and could be declared final60
Parameter 'parent' is not assigned and could be declared final60
Parameter 'layoutManager' is not assigned and could be declared final75

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIPanelBase.java

ViolationLine
No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead.22 - 25

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIPopup.java

ViolationLine
The class 'AbstractUIPopup' has a Cyclomatic Complexity of 2 (Highest = 5).49 - 213
This class has too many methods, consider refactoring it.51 - 213
Avoid unused private fields such as 'LOG'.53
Avoid unused private fields such as 'LOG'.53
Parameter 'facesContext' is not assigned and could be declared final59
Parameter 'parent' is not assigned and could be declared final59
Parameter 'facesContext' is not assigned and could be declared final70
Parameter 'parent' is not assigned and could be declared final70
Parameter 'activated' is not assigned and could be declared final82
Parameter 'facesContext' is not assigned and could be declared final87
The method 'processDecodes' has a Cyclomatic Complexity of 5.87 - 103
Local variable 'it' could be declared final89
Local variable 'childOrFacet' could be declared final90
Avoid if (x != y) ..; else ..;108 - 113
Local variable 'context' could be declared final109
Local variable 'action' could be declared final117
The method 'isRedisplay' has a Cyclomatic Complexity of 5.121 - 132
Local variable 'action' could be declared final123
Local variable 'command' could be declared final125
No need to check for null before an instanceof126
Parameter 'context' is not assigned and could be declared final140
Local variable 'it' could be declared final142
Local variable 'childOrFacet' could be declared final143
Parameter 'context' is not assigned and could be declared final154
Local variable 'it' could be declared final156
Local variable 'childOrFacet' could be declared final157
Parameter 'context' is not assigned and could be declared final164
Parameter 'savedState' is not assigned and could be declared final172
Parameter 'context' is not assigned and could be declared final172
Local variable 'values' could be declared final173
Parameter 'context' is not assigned and could be declared final179
Parameter 'layoutManager' is not assigned and could be declared final188

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectBooleanCheckbox.java

ViolationLine
The class 'AbstractUISelectBooleanCheckbox' has a Cyclomatic Complexity of 5 (Highest = 6).30 - 58
Parameter 'facesContext' is not assigned and could be declared final45
Parameter 'convertedValue' is not assigned and could be declared final45
The method 'validateValue' has a Cyclomatic Complexity of 6.45 - 57
These nested if statements could be combined47 - 54
These nested if statements could be combined47 - 54

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectItem.java

ViolationLine
Parameter 'facesContext' is not assigned and could be declared final37
Parameter 'parent' is not assigned and could be declared final37
Local variable 'converted' could be declared final39 - 40
Parameter 'itemValue' is not assigned and could be declared final46
Avoid empty if statements49 - 51
Avoid empty if statements49 - 51

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectMany.java

ViolationLine
Local variable 'value' could be declared final32

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectOneBase.java

ViolationLine
The class 'AbstractUISelectOneBase' has a Cyclomatic Complexity of 4 (Highest = 6).30 - 54
Parameter 'facesContext' is not assigned and could be declared final35
The method 'validate' has a Cyclomatic Complexity of 6.35 - 51
Local variable 'submittedValue' could be declared final37
Avoid if (x != y) ..; else ..;39 - 46
Local variable 'requiredMessage' could be declared final40

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectOneChoice.java

ViolationLine
No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead.22 - 23

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectOneListbox.java

ViolationLine
No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead.22 - 23

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectOneRadio.java

ViolationLine
No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead.22 - 23

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISeparator.java

ViolationLine
No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead.26 - 27

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISheet.java

ViolationLine
A high number of imports can indicate a high degree of coupling within an object.20 - 653
This class has a bunch of public methods and attributes20 - 653
The class 'AbstractUISheet' has a Cyclomatic Complexity of 3 (Highest = 19).65 - 653
The class 'AbstractUISheet' has a Cyclomatic Complexity of 3 (Highest = 19).65 - 653
This class has too many methods, consider refactoring it.67 - 653
Avoid unused private fields such as 'ajaxResponseCode'.93
Avoid unused private fields such as 'ajaxResponseCode'.93
Parameter 'context' is not assigned and could be declared final101
Parameter 'facesContext' is not assigned and could be declared final106
The method 'encodeBegin' has a Cyclomatic Complexity of 5.106 - 118
Local variable 'state' could be declared final107
Avoid if (x != y) ..; else ..;111 - 115
Parameter 'state' is not assigned and could be declared final120
Parameter 'facesContext' is not assigned and could be declared final128
Local variable 'columns' could be declared final152
Local variable 'state' could be declared final165
Local variable 'last' could be declared final177
Local variable 'last' could be declared final194
Local variable 'rows' could be declared final202
Local variable 'first' could be declared final207
Parameter 'column' is not assigned and could be declared final240
Local variable 'children' could be declared final241
Avoid if (x != y) ..; else ..;278 - 282
Avoid if (x != y) ..; else ..;288 - 296
Avoid if (x != y) ..; else ..;322 - 330
Local variable 'rows' could be declared final326
Local variable 'rowCount' could be declared final327
Local variable 'tail' could be declared final328
Avoid if (x != y) ..; else ..;329
Parameter 'context' is not assigned and could be declared final334
Parameter 'facesContext' is not assigned and could be declared final339
Local variable 'state' could be declared final340
Local variable 'attributes' could be declared final346
Avoid if (x != y) ..; else ..;349
Parameter 'context' is not assigned and could be declared final359
Parameter 'savedState' is not assigned and could be declared final367
Parameter 'context' is not assigned and could be declared final367
Local variable 'values' could be declared final368
Local variable 'columns' could be declared final374
Local variable 'columns' could be declared final382
Parameter 'facesEvent' is not assigned and could be declared final400
The method 'queueEvent' has a Cyclomatic Complexity of 8.400 - 422
Local variable 'parent' could be declared final401
Local variable 'source' could be declared final412
Local variable 'sourceParent' could be declared final413
Parameter 'facesEvent' is not assigned and could be declared final425
The method 'broadcast' has a Cyclomatic Complexity of 6.425 - 446
Local variable 'methodBinding' could be declared final436
Avoid if (x != y) ..; else ..;437 - 444
Parameter 'listener' is not assigned and could be declared final448
Parameter 'listener' is not assigned and could be declared final456
Parameter 'widthList' is not assigned and could be declared final464
Parameter 'searchId' is not assigned and could be declared final480
Avoid reassigning parameters such as 'searchId'484
The method 'stripRowIndex' has a Cyclomatic Complexity of 6.484 - 498
Local variable 'c' could be declared final487
Parameter 'pageEvent' is not assigned and could be declared final500
The method 'performPaging' has a Cyclomatic Complexity of 19.500 - 562
The method 'performPaging' has a Cyclomatic Complexity of 19.500 - 562
Local variable 'pageIndex' could be declared final540
Avoid if (x != y) ..; else ..;554 - 558
The method 'getComponents' has a Cyclomatic Complexity of 11.564 - 606
The method 'getComponents' has a Cyclomatic Complexity of 11.564 - 606
Avoid empty if statements572 - 574
Avoid empty if statements572 - 574
Avoid if (x != y) ..; else ..;590 - 602
Parameter 'facesContext' is not assigned and could be declared final608
Parameter 'parent' is not assigned and could be declared final608
Parameter 'layoutManager' is not assigned and could be declared final619
An empty method in an abstract class should be abstract instead627 - 629
Parameter 'needVerticalScrollbar' is not assigned and could be declared final637
Parameter 'headerGrid' is not assigned and could be declared final650

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISheetLayout.java

ViolationLine
The class 'AbstractUISheetLayout' has a Cyclomatic Complexity of 6 (Highest = 16).54 - 406
The class 'AbstractUISheetLayout' has a Cyclomatic Complexity of 6 (Highest = 16).54 - 406
Parameter 'orientation' is not assigned and could be declared final72
Parameter 'auto' is not assigned and could be declared final72
Parameter 'orientation' is not assigned and could be declared final87
Avoid unused local variables such as 'intervals'.90
Local variable 'intervals' could be declared final90
Avoid unused local variables such as 'intervals'.90
These nested if statements could be combined94 - 96
These nested if statements could be combined94 - 96
Parameter 'orientation' is not assigned and could be declared final118
The method 'mainProcessing' has a Cyclomatic Complexity of 12.118 - 168
The method 'mainProcessing' has a Cyclomatic Complexity of 12.118 - 168
Local variable 'box' could be declared final149
Deeply nested if..then statements are hard to read160 - 162
Parameter 'orientation' is not assigned and could be declared final170
The method 'postProcessing' has a Cyclomatic Complexity of 5.170 - 195
Local variable 'position' could be declared final180
An empty method in an abstract class should be abstract instead203 - 205
Parameter 'facesContext' is not assigned and could be declared final207
Parameter 'data' is not assigned and could be declared final207
The method 'ensureColumnWidthList' has a Cyclomatic Complexity of 16.207 - 284
The method ensureColumnWidthList() has an NPath complexity of 1080207 - 284
The method 'ensureColumnWidthList' has a Cyclomatic Complexity of 16.207 - 284
Local variable 'renderedColumns' could be declared final210
Local variable 'state' could be declared final214
Assigning an Object to null is a code smell. Consider refactoring.230
Local variable 'tokens' could be declared final234
Local variable 'allColumns' could be declared final235
Local variable 'newTokens' could be declared final236
Local variable 'column' could be declared final238
Local variable 'layoutInfo' could be declared final267 - 268
Avoid if (x != y) ..; else ..;277 - 283
Parameter 'facesContext' is not assigned and could be declared final286
Parameter 'sheet' is not assigned and could be declared final286
The method 'needVerticalScrollbar' has a Cyclomatic Complexity of 13.286 - 331
The method needVerticalScrollbar() has an NPath complexity of 660286 - 331
The method 'needVerticalScrollbar' has a Cyclomatic Complexity of 13.286 - 331
Avoid if (x != y) ..; else ..;312 - 327
Local variable 'first' could be declared final313
Local variable 'rows' could be declared final314 - 316
The method 'parseFixedWidth' has a Cyclomatic Complexity of 9.333 - 364
Parameter 'columnSelectorWidth' is not assigned and could be declared final334
Parameter 'layoutInfo' is not assigned and could be declared final334
Parameter 'renderedColumns' is not assigned and could be declared final334
Local variable 'tokens' could be declared final335
Local variable 'token' could be declared final337
Local variable 'column' could be declared final342
Parameter 'facesContext' is not assigned and could be declared final366
Parameter 'sheet' is not assigned and could be declared final366
Parameter 'facesContext' is not assigned and could be declared final372
Parameter 'sheet' is not assigned and could be declared final372
Parameter 'facesContext' is not assigned and could be declared final376
Parameter 'sheet' is not assigned and could be declared final376
The method 'layoutHeader' has a Cyclomatic Complexity of 5.382 - 405
Avoid instantiating new objects inside loops397

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITabGroup.java

ViolationLine
A high number of imports can indicate a high degree of coupling within an object.20 - 336
The class 'AbstractUITabGroup' has a Cyclomatic Complexity of 2 (Highest = 6).56 - 336
This class has too many methods, consider refactoring it.58 - 336
Parameter 'facesContext' is not assigned and could be declared final72
An empty method in an abstract class should be abstract instead80 - 83
Parameter 'facesContext' is not assigned and could be declared final80
Parameter 'facesContext' is not assigned and could be declared final86
An empty method in an abstract class should be abstract instead97 - 99
Parameter 'event' is not assigned and could be declared final101
Local variable 'tabs' could be declared final121
Parameter 'context' is not assigned and could be declared final140
The method 'processDecodes' has a Cyclomatic Complexity of 6.140 - 163
Avoid if (x != y) ..; else ..;141 - 162
Local variable 'renderedTab' could be declared final149
Parameter 'context' is not assigned and could be declared final166
The method 'processValidators' has a Cyclomatic Complexity of 5.166 - 182
Avoid if (x != y) ..; else ..;167 - 181
Local variable 'renderedTab' could be declared final174
Parameter 'context' is not assigned and could be declared final185
The method 'processUpdates' has a Cyclomatic Complexity of 5.185 - 202
Avoid if (x != y) ..; else ..;186 - 201
Local variable 'renderedTab' could be declared final193
Parameter 'facesEvent' is not assigned and could be declared final204
The method 'broadcast' has a Cyclomatic Complexity of 6.204 - 224
Local variable 'defaultActionListener' could be declared final211
Local variable 'index' could be declared final216
Local variable 'expression' could be declared final217
Avoid if (x != y) ..; else ..;218 - 222
Parameter 'listener' is not assigned and could be declared final226
Local variable 'switchType' could be declared final234
Parameter 'listener' is not assigned and could be declared final238
Parameter 'index' is not assigned and could be declared final256
Parameter 'listener' is not assigned and could be declared final280
Parameter 'listener' is not assigned and could be declared final294
Parameter 'facesContext' is not assigned and could be declared final302
Parameter 'parent' is not assigned and could be declared final302
Parameter 'layoutManager' is not assigned and could be declared final313
Parameter 'context' is not assigned and could be declared final321
Parameter 'componentState' is not assigned and could be declared final321
Local variable 'values' could be declared final322
Parameter 'context' is not assigned and could be declared final328

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITabGroupLayout.java

ViolationLine
The class 'AbstractUITabGroupLayout' has a Cyclomatic Complexity of 4 (Highest = 9).33 - 137
Parameter 'orientation' is not assigned and could be declared final48
Parameter 'auto' is not assigned and could be declared final48
Parameter 'orientation' is not assigned and could be declared final63
The method 'preProcessing' has a Cyclomatic Complexity of 8.63 - 88
Local variable 'intervals' could be declared final66
Avoid instantiating new objects inside loops75
Local variable 'size' could be declared final81
Parameter 'orientation' is not assigned and could be declared final90
The method 'mainProcessing' has a Cyclomatic Complexity of 9.90 - 113
Local variable 'container' could be declared final96
Local variable 'available' could be declared final97
Avoid if (x != y) ..; else ..;98 - 104
Parameter 'orientation' is not assigned and could be declared final115
An empty method in an abstract class should be abstract instead134 - 136

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITime.java

ViolationLine
Local variable 'converter' could be declared final32
Local variable 'application' could be declared final35 - 36
Local variable 'dateTimeConverter' could be declared final37 - 38

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIToolBar.java

ViolationLine
No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead.24 - 38

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIToolBarCommand.java

ViolationLine
No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead.24 - 27

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITree.java

ViolationLine
The class 'AbstractUITree' has a Cyclomatic Complexity of 3 (Highest = 6).38 - 250
Avoid unused private fields such as 'LOG'.42
Avoid unused private fields such as 'LOG'.42
Parameter 'facesContext' is not assigned and could be declared final67
The method 'processValidators' has a Cyclomatic Complexity of 5.67 - 79
Parameter 'facesContext' is not assigned and could be declared final82
The method 'processUpdates' has a Cyclomatic Complexity of 5.82 - 94
An empty method in an abstract class should be abstract instead123 - 125
Parameter 'facesContext' is not assigned and could be declared final128
The method 'processDecodes' has a Cyclomatic Complexity of 6.128 - 147
Parameter 'state' is not assigned and could be declared final204
Parameter 'context' is not assigned and could be declared final238
Parameter 'componentState' is not assigned and could be declared final238
Local variable 'values' could be declared final239
Parameter 'context' is not assigned and could be declared final244

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITreeData.java

ViolationLine
The class 'AbstractUITreeData' has a Cyclomatic Complexity of 2 (Highest = 5).36 - 111
Parameter 'facesContext' is not assigned and could be declared final46
Parameter 'parent' is not assigned and could be declared final46
The method 'onComponentCreated' has a Cyclomatic Complexity of 5.46 - 65
Local variable 've' could be declared final49
Avoid if (x != y) ..; else ..;50 - 54
Local variable 've' could be declared final58
Avoid if (x != y) ..; else ..;59 - 63
Parameter 'var' is not assigned and could be declared final71
Parameter 'context' is not assigned and could be declared final75
Parameter 'componentState' is not assigned and could be declared final75
Local variable 'values' could be declared final76
Parameter 'context' is not assigned and could be declared final81
Parameter 'model' is not assigned and could be declared final92
Parameter 'facesContext' is not assigned and could be declared final92
Parameter 'model' is not assigned and could be declared final100
Parameter 'facesContext' is not assigned and could be declared final100
Parameter 'model' is not assigned and could be declared final108
Parameter 'facesContext' is not assigned and could be declared final108

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITreeIndent.java

ViolationLine
No abstract method which means that the keyword is most likely used to prevent instantiation. use a private or protected constructor instead.26 - 27

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITreeListbox.java

ViolationLine
An empty method in an abstract class should be abstract instead25 - 27

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITreeNode.java

ViolationLine
This class has too many methods, consider refactoring it.41 - 311
Parameter 'facesContext' is not assigned and could be declared final44
Parameter 'facesContext' is not assigned and could be declared final75
Local variable 'dataId' could be declared final78
Consider simply returning the value vs storing it in local variable 'rowData'92
Parameter 'model' is not assigned and could be declared final99
Parameter 'facesContext' is not assigned and could be declared final99
The String literal "Doesn't work anymore." appears 10 times in this file; the first occurrence is on line 100100
Parameter 'model' is not assigned and could be declared final107
Parameter 'facesContext' is not assigned and could be declared final107
Parameter 'model' is not assigned and could be declared final115
Parameter 'facesContext' is not assigned and could be declared final115
Parameter 'depth' is not assigned and could be declared final132
Parameter 'folder' is not assigned and could be declared final140
Parameter 'path' is not assigned and could be declared final148
Parameter 'junctions' is not assigned and could be declared final156
Parameter 'hasNextSibling' is not assigned and could be declared final173
The String literal "treeExpansionListener!" appears 5 times in this file; the first occurrence is on line 182182
Parameter 'treeExpansionListener' is not assigned and could be declared final190
Parameter 'listener' is not assigned and could be declared final198
Return an empty array rather than null.206 - 209
Parameter 'listener' is not assigned and could be declared final215
The String literal "treeMarkedListener!" appears 5 times in this file; the first occurrence is on line 224224
Parameter 'treeMarkedListener' is not assigned and could be declared final232
Parameter 'listener' is not assigned and could be declared final240
Return an empty array rather than null.248 - 251
Parameter 'listener' is not assigned and could be declared final257
Parameter 'b' is not assigned and could be declared final274
Parameter 'expanded' is not assigned and could be declared final291
Parameter 'selected' is not assigned and could be declared final308

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITreeSelect.java

ViolationLine
Overriding method merely calls super30 - 32
Parameter 'context' is not assigned and could be declared final30
Overriding method merely calls super30 - 32

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIWizard.java

ViolationLine
Parameter 'facesContext' is not assigned and could be declared final47
Parameter 'facesContext' is not assigned and could be declared final55
Parameter 'event' is not assigned and could be declared final63
Parameter 'event' is not assigned and could be declared final68
Local variable 'facesContext' could be declared final70
Local variable 'originalEvent' could be declared final74
Parameter 'facesContext' is not assigned and could be declared final85
Parameter 'facesContext' is not assigned and could be declared final93
Parameter 'context' is not assigned and could be declared final100
Parameter 'parent' is not assigned and could be declared final100
Local variable 'wizard' could be declared final101
Parameter 'facesContext' is not assigned and could be declared final112
Parameter 'facesContext' is not assigned and could be declared final121
Parameter 'state' is not assigned and could be declared final121
Local variable 'values' could be declared final122
Local variable 'vb' could be declared final132
Avoid if (x != y) ..; else ..;133 - 137
Parameter 'controller' is not assigned and could be declared final140
Parameter 'var' is not assigned and could be declared final148
Local variable 'vb' could be declared final156
Parameter 'outcome' is not assigned and could be declared final164
Local variable 'vb' could be declared final172
Parameter 'title' is not assigned and could be declared final180
Local variable 'vb' could be declared final188
Local variable 'bool' could be declared final190
Parameter 'allowJumpForward' is not assigned and could be declared final198

Tobago Core - org/apache/myfaces/tobago/internal/config/RendererConfig.java

ViolationLine
Parameter 'name' is not assigned and could be declared final38
Parameter 'o' is not assigned and could be declared final42
Parameter 'markup' is not assigned and could be declared final55
Parameter 'markup' is not assigned and could be declared final63
Parameter 'rendererConfig' is not assigned and could be declared final67

Tobago Core - org/apache/myfaces/tobago/internal/config/RenderersConfigImpl.java

ViolationLine
Private field 'rendererMap' could be made final; it is only initialized in the declaration or constructor.36
Parameter 'merged' is not assigned and could be declared final44
Parameter 'rendererConfig' is not assigned and could be declared final52
Parameter 'markup' is not assigned and could be declared final61
Parameter 'rendererName' is not assigned and could be declared final61
Local variable 'rendererConfig' could be declared final65
Avoid if (x != y) ..; else ..;66 - 71
Parameter 'renderersConfig' is not assigned and could be declared final74
Parameter 'override' is not assigned and could be declared final74
Local variable 'renderers' could be declared final75

Tobago Core - org/apache/myfaces/tobago/internal/config/ThemeParser.java

ViolationLine
Local variable 'theme' could be declared final86

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigBuilder.java

ViolationLine
A class which only has private constructors should be final37 - 187
The class 'TobagoConfigBuilder' has a Cyclomatic Complexity of 5 (Highest = 8).37 - 187
Avoid unused private fields such as 'WEB_INF_TOBAGO_CONFIG_XML'.41
Avoid unused private fields such as 'WEB_INF_TOBAGO_CONFIG_XML'.41
Private field 'list' could be made final; it is only initialized in the declaration or constructor.48
Parameter 'servletContext' is not assigned and could be declared final50
Parameter 'servletContext' is not assigned and could be declared final68
Avoid unused local variables such as 'builder'.70
Avoid unused local variables such as 'builder'.70
Local variable 'error' could be declared final73
Parameter 'servletContext' is not assigned and could be declared final80
The method 'mergeList' has a Cyclomatic Complexity of 8.88 - 144
Local variable 'sorter' could be declared final92
Local variable 'result' could be declared final94
The method 'configFromClasspath' has a Cyclomatic Complexity of 8.146 - 184
Local variable 'parser' could be declared final148
Local variable 'classLoader' could be declared final153
Local variable 'urls' could be declared final154
Avoid instantiating new objects inside loops161
Avoid instantiating new objects inside loops164
Local variable 'protocol' could be declared final169
Local variable 'msg' could be declared final180

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigFragment.java

ViolationLine
Private field 'before' could be made final; it is only initialized in the declaration or constructor.36
Private field 'after' could be made final; it is only initialized in the declaration or constructor.37
Private field 'supportedThemeNames' could be made final; it is only initialized in the declaration or constructor.39
Private field 'resourceDirs' could be made final; it is only initialized in the declaration or constructor.41
Private field 'contentSecurityPolicy' could be made final; it is only initialized in the declaration or constructor.46
Private field 'themeDefinitions' could be made final; it is only initialized in the declaration or constructor.48
Parameter 'name' is not assigned and could be declared final60
Parameter 'defaultThemeName' is not assigned and could be declared final72
Parameter 'resourceDir' is not assigned and could be declared final76
Parameter 'value' is not assigned and could be declared final91
Parameter 'renderersConfig' is not assigned and could be declared final99
Parameter 'name' is not assigned and could be declared final107
Parameter 'name' is not assigned and could be declared final115
Parameter 'name' is not assigned and could be declared final123
Parameter 'theme' is not assigned and could be declared final127
Parameter 'createSessionSecret' is not assigned and could be declared final139
Parameter 'checkSessionSecret' is not assigned and could be declared final147
Parameter 'preventFrameAttacks' is not assigned and could be declared final155
Parameter 'directive' is not assigned and could be declared final163
Parameter 'value' is not assigned and could be declared final169
Parameter 'value' is not assigned and could be declared final175
Parameter 'url' is not assigned and could be declared final183
Avoid if (x != y) ..; else ..;189

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigImpl.java

ViolationLine
The class 'TobagoConfigImpl' has a Cyclomatic Complexity of 2 (Highest = 10).46 - 336
This class has too many methods, consider refactoring it.46 - 336
The class 'TobagoConfigImpl' has a Cyclomatic Complexity of 2 (Highest = 10).46 - 336
Private field 'supportedThemes' could be made final; it is only initialized in the declaration or constructor.52
Private field 'supportedThemeNames' could be made final; it is only initialized in the declaration or constructor.53
Private field 'resourceDirs' could be made final; it is only initialized in the declaration or constructor.56
Private field 'contentSecurityPolicy' could be made final; it is only initialized in the declaration or constructor.63
Parameter 'name' is not assigned and could be declared final76
The method 'resolveThemes' has a Cyclomatic Complexity of 10.80 - 120
The method 'resolveThemes' has a Cyclomatic Complexity of 10.80 - 120
Avoid if (x != y) ..; else ..;81 - 108
Local variable 'theme' could be declared final91
Local variable 'error' could be declared final98 - 100
Local variable 'theme' could be declared final111
Parameter 'name' is not assigned and could be declared final122
Parameter 'theme' is not assigned and could be declared final122
Local variable 'error' could be declared final124 - 126
Parameter 'name' is not assigned and could be declared final132
The method 'getTheme' has a Cyclomatic Complexity of 5.132 - 147
Parameter 'defaultThemeName' is not assigned and could be declared final149
Parameter 'resourceDir' is not assigned and could be declared final157
Parameter 'availableThemes' is not assigned and could be declared final181
Parameter 'renderersConfig' is not assigned and could be declared final192
Parameter 'servletContext' is not assigned and could be declared final200
The method 'initProjectState' has a Cyclomatic Complexity of 10.200 - 238
The method 'initProjectState' has a Cyclomatic Complexity of 10.200 - 238
Local variable 'ctx' could be declared final203
Local variable 'obj' could be declared final204
Avoid empty catch blocks213 - 215
Avoid empty catch blocks213 - 215
Use block level rather than method level synchronization240 - 262
The method 'initDefaultValidatorInfo' has a Cyclomatic Complexity of 6.240 - 262
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()248
Parameter 'createSessionSecret' is not assigned and could be declared final268
Parameter 'checkSessionSecret' is not assigned and could be declared final276
Parameter 'preventFrameAttacks' is not assigned and could be declared final285
Parameter 'directive' is not assigned and could be declared final293
Local variable 'all' could be declared final331

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigParser.java

ViolationLine
Avoid unused private fields such as 'TOBAGO_CONFIG_XSD_1_5'.45
Avoid unused private fields such as 'TOBAGO_CONFIG_XSD_1_5'.45
Avoid unused private fields such as 'TOBAGO_CONFIG_XSD_1_6'.46
Avoid unused private fields such as 'TOBAGO_CONFIG_XSD_1_6'.46
Private field 'digester' could be made final; it is only initialized in the declaration or constructor.48
Parameter 'url' is not assigned and could be declared final57
Local variable 'tobagoConfig' could be declared final63
Parameter 'url' is not assigned and could be declared final76
The String literal "setName" appears 4 times in this file; the first occurrence is on line 9393
Parameter 'publicId' is not assigned and could be declared final174
Parameter 'entityUrl' is not assigned and could be declared final174
Local variable 'url' could be declared final175
Avoid if (x != y) ..; else ..;179 - 183

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigSorter.java

ViolationLine
The class 'TobagoConfigSorter' has a Cyclomatic Complexity of 4 (Highest = 6).30 - 218
Private field 'list' could be made final; it is only initialized in the declaration or constructor.34
Parameter 'list' is not assigned and could be declared final37
Prefer StringBuffer over += for concatenating strings60
The method 'makeTransitive' has a Cyclomatic Complexity of 6.68 - 83
Avoid instantiation through private constructors from outside of the constructor's class.77
Avoid instantiating new objects inside loops77
Local variable 'buffer' could be declared final88
Avoid instantiating new objects inside loops88
The String literal "' < '" appears 4 times in this file; the first occurrence is on line 9191
StringBuffer.append is called 2 consecutive times with literal Strings. Use a single append with a single String.93
Avoid appending characters as strings in StringBuffer.append.96
The method 'ensureAntiSymmetric' has a Cyclomatic Complexity of 6.108 - 135
Local variable 'buffer' could be declared final112
Avoid instantiating new objects inside loops112
StringBuffer.append is called 2 consecutive times with literal Strings. Use a single append with a single String.121
Avoid appending characters as strings in StringBuffer.append.124
Parameter 'b' is not assigned and could be declared final137
Parameter 'a' is not assigned and could be declared final137
The method 'createRelevantPairs' has a Cyclomatic Complexity of 6.147 - 166
Local variable 'before' could be declared final154
Avoid instantiation through private constructors from outside of the constructor's class.156
Avoid instantiating new objects inside loops156
Local variable 'after' could be declared final160
Avoid instantiation through private constructors from outside of the constructor's class.162
Avoid instantiating new objects inside loops162
Parameter 'lower' is not assigned and could be declared final172
Parameter 'higher' is not assigned and could be declared final172
Parameter 'name' is not assigned and could be declared final181
Parameter 'lower' is not assigned and could be declared final199
Parameter 'higher' is not assigned and could be declared final199

Tobago Core - org/apache/myfaces/tobago/internal/context/ClientPropertiesKey.java

ViolationLine
The class 'ClientPropertiesKey' has a Cyclomatic Complexity of 2 (Highest = 8).32 - 129
Parameter 'facesContext' is not assigned and could be declared final43
Local variable 'requestMap' could be declared final45
Local variable 'clientProperties' could be declared final48
Parameter 'facesContext' is not assigned and could be declared final56
Local variable 'requestMap' could be declared final57
Parameter 'clientProperties' is not assigned and could be declared final61
Parameter 'o' is not assigned and could be declared final70
The method 'equals' has a Cyclomatic Complexity of 8.70 - 94
Local variable 'that' could be declared final78

Tobago Core - org/apache/myfaces/tobago/internal/context/ImageCacheKey.java

ViolationLine
Parameter 'clientPropertiesKey' is not assigned and could be declared final27
Parameter 'name' is not assigned and could be declared final27
Parameter 'o' is not assigned and could be declared final34
Local variable 'that' could be declared final42

Tobago Core - org/apache/myfaces/tobago/internal/context/JspCacheKey.java

ViolationLine
Parameter 'cacheKey' is not assigned and could be declared final27
Parameter 'name' is not assigned and could be declared final27
Parameter 'o' is not assigned and could be declared final34
Local variable 'that' could be declared final42

Tobago Core - org/apache/myfaces/tobago/internal/context/MeasureValue.java

ViolationLine
The class 'MeasureValue' has a Cyclomatic Complexity of 2 (Highest = 6).27 - 68
Private field 'value' could be made final; it is only initialized in the declaration or constructor.31
Parameter 'value' is not assigned and could be declared final33
Parameter 'o' is not assigned and could be declared final42
The method 'equals' has a Cyclomatic Complexity of 6.42 - 57
Local variable 'that' could be declared final50
Avoid if (x != y) ..; else ..;52
Avoid if (x != y) ..; else ..;61
Do not add empty strings66

Tobago Core - org/apache/myfaces/tobago/internal/context/MiscCacheKey.java

ViolationLine
Parameter 'cacheKey' is not assigned and could be declared final27
Parameter 'name' is not assigned and could be declared final27
Parameter 'o' is not assigned and could be declared final34
Local variable 'that' could be declared final42

Tobago Core - org/apache/myfaces/tobago/internal/context/PropertyCacheKey.java

ViolationLine
Parameter 'cacheKey' is not assigned and could be declared final28
Parameter 'name' is not assigned and could be declared final28
Parameter 'key' is not assigned and could be declared final28
Parameter 'o' is not assigned and could be declared final36
Local variable 'that' could be declared final44

Tobago Core - org/apache/myfaces/tobago/internal/context/RendererCacheKey.java

ViolationLine
Parameter 'cacheKey' is not assigned and could be declared final27
Parameter 'name' is not assigned and could be declared final27
Parameter 'o' is not assigned and could be declared final34
Local variable 'that' could be declared final42

Tobago Core - org/apache/myfaces/tobago/internal/context/ResourceLocator.java

ViolationLine
The class 'ResourceLocator' has a Cyclomatic Complexity of 7 (Highest = 17).57 - 431
The class 'ResourceLocator' has a Cyclomatic Complexity of 7 (Highest = 17).57 - 431
Private field 'servletContext' could be made final; it is only initialized in the declaration or constructor.65
Private field 'resourceManager' could be made final; it is only initialized in the declaration or constructor.66
Private field 'themeBuilder' could be made final; it is only initialized in the declaration or constructor.67
Parameter 'servletContext' is not assigned and could be declared final70
Parameter 'resourceManager' is not assigned and could be declared final70
Parameter 'themeBuilder' is not assigned and could be declared final70
The method 'locateResourcesInWar' has a Cyclomatic Complexity of 14.84 - 135
The method locateResourcesInWar() has an NPath complexity of 24084 - 135
The method 'locateResourcesInWar' has a Cyclomatic Complexity of 14.84 - 135
Avoid reassigning parameters such as 'path'85
Parameter 'resources' is not assigned and could be declared final85
Parameter 'servletContext' is not assigned and could be declared final85
Local variable 'resourcePaths' could be declared final95
Local variable 'inputStream' could be declared final114
Local variable 'inputStream' could be declared final121
Parameter 'resources' is not assigned and could be declared final137
The method 'locateResourcesFromClasspath' has a Cyclomatic Complexity of 10.137 - 196
The method 'locateResourcesFromClasspath' has a Cyclomatic Complexity of 10.137 - 196
Local variable 'parser' could be declared final140
Local variable 'classLoader' could be declared final145
Local variable 'urls' could be declared final146
Local variable 'tobagoConfig' could be declared final152
Avoid instantiating new objects inside loops152
Local variable 'themeUrlStr' could be declared final155
Local variable 'index' could be declared final156
Local variable 'metaInf' could be declared final157
Local variable 'properties' could be declared final158
Avoid instantiating new objects inside loops158
Avoid instantiating new objects inside loops159
Avoid if (x != y) ..; else ..;172 - 178
Local variable 'msg' could be declared final188
The String literal "while loading " appears 4 times in this file; the first occurrence is on line 188188
Local variable 'msg' could be declared final192
Parameter 'resources' is not assigned and could be declared final198
Parameter 'themeUrl' is not assigned and could be declared final198
Parameter 'theme' is not assigned and could be declared final198
Local variable 'prefix' could be declared final201
Local variable 'protocol' could be declared final203
Parameter 'resources' is not assigned and could be declared final220
The method 'locateResourcesServlet30Alike' has a Cyclomatic Complexity of 8.220 - 254
Local variable 'classLoader' could be declared final226
Local variable 'urls' could be declared final227
Local variable 'resourcesUrl' could be declared final230
Local variable 'protocol' could be declared final240
Local variable 'msg' could be declared final250
Parameter 'skipPrefix' is not assigned and could be declared final256
Parameter 'resources' is not assigned and could be declared final256
Parameter 'themeUrl' is not assigned and could be declared final256
Parameter 'prefix' is not assigned and could be declared final256
The method 'addResources' has a Cyclomatic Complexity of 17.256 - 322
The method addResources() has an NPath complexity of 416256 - 322
The method 'addResources' has a Cyclomatic Complexity of 17.256 - 322
Local variable 'index' could be declared final263
String.indexOf(char) is faster than String.indexOf(String).263
Local variable 'protocol' could be declared final264
Do not add empty strings269
Position literals first in String comparisons273
Local variable 'uri' could be declared final276
Local variable 'tobagoThemeXml' could be declared final277
Local variable 'directoryFile' could be declared final278
Local variable 'resourcePath' could be declared final279
Position literals first in String comparisons288
Local variable 'nextEntry' could be declared final308
Local variable 'name' could be declared final312
Parameter 'resources' is not assigned and could be declared final324
Parameter 'directoryFile' is not assigned and could be declared final324
The method 'resolveTheme' has a Cyclomatic Complexity of 7.324 - 343
Avoid reassigning parameters such as 'inResourcePath'325
Parameter 'resourcePath' is not assigned and could be declared final325
Parameter 'prefix' is not assigned and could be declared final325
Local variable 'files' could be declared final326
Local variable 'currentResourcePath' could be declared final329
Parameter 'skipPrefix' is not assigned and could be declared final345
Parameter 'resources' is not assigned and could be declared final345
Parameter 'name' is not assigned and could be declared final345
The method 'addResource' has a Cyclomatic Complexity of 6.345 - 373
Avoid empty if statements348 - 350
Avoid empty if statements348 - 350
Local variable 'inputStream' could be declared final354
Local variable 'inputStream' could be declared final364
Avoid reassigning parameters such as 'resourcePath'375
Avoid reassigning parameters such as 'resourcePath'375
This call to String.startsWith can be rewritten using String.charAt(0)376
The method 'addProperties' has a Cyclomatic Complexity of 8.385 - 430
Parameter 'skipPrefix' is not assigned and could be declared final386
Parameter 'resources' is not assigned and could be declared final386
Parameter 'stream' is not assigned and could be declared final386
Parameter 'xml' is not assigned and could be declared final386
Parameter 'childPath' is not assigned and could be declared final386
Local variable 'directory' could be declared final389
Local variable 'filename' could be declared final390
Local variable 'locale' could be declared final397
Local variable 'temp' could be declared final400
Local variable 'msg' could be declared final416
Local variable 'e' could be declared final423
Local variable 'key' could be declared final424

Tobago Core - org/apache/myfaces/tobago/internal/context/ResourceManagerFactory.java

ViolationLine
A class which only has private constructors should be final29 - 71
Parameter 'facesContext' is not assigned and could be declared final39
Parameter 'servletContext' is not assigned and could be declared final45
Parameter 'servletContext' is not assigned and could be declared final51
Parameter 'tobagoConfig' is not assigned and could be declared final51
Local variable 'resourceManager' could be declared final54
Local variable 'themeBuilder' could be declared final56
Local variable 'resourceLocator' could be declared final57
Parameter 'servletContext' is not assigned and could be declared final66

Tobago Core - org/apache/myfaces/tobago/internal/context/ResourceManagerImpl.java

ViolationLine
The class 'ResourceManagerImpl' has a Cyclomatic Complexity of 5 (Highest = 30).43 - 582
The class 'ResourceManagerImpl' has a Cyclomatic Complexity of 5 (Highest = 30).43 - 582
Private field 'production' could be made final; it is only initialized in the declaration or constructor.50
Private field 'tobagoConfig' could be made final; it is only initialized in the declaration or constructor.68
Parameter 'tobagoConfig' is not assigned and could be declared final70
Parameter 'resourceKey' is not assigned and could be declared final75
Parameter 'resourceKey' is not assigned and could be declared final82
Parameter 'value' is not assigned and could be declared final82
Parameter 'name' is not assigned and could be declared final90
Parameter 'viewRoot' is not assigned and could be declared final90
Local variable 'clientKey' could be declared final94
Local variable 'cacheKey' could be declared final95
The String literal "name = '" appears 4 times in this file; the first occurrence is on line 106106
The String literal "' clientProperties = '" appears 4 times in this file; the first occurrence is on line 106106
Parameter 'bundle' is not assigned and could be declared final113
Parameter 'propertyKey' is not assigned and could be declared final113
Parameter 'viewRoot' is not assigned and could be declared final113
Parameter 'facesContext' is not assigned and could be declared final117
Parameter 'bundle' is not assigned and could be declared final117
Parameter 'propertyKey' is not assigned and could be declared final117
The method 'getProperty' has a Cyclomatic Complexity of 5.117 - 136
Local variable 'clientKey' could be declared final120
Local variable 'cacheKey' could be declared final121
Local variable 'properties' could be declared final125
Avoid if (x != y) ..; else ..;126 - 130
Parameter 'rendererType' is not assigned and could be declared final139
Parameter 'viewRoot' is not assigned and could be declared final139
Parameter 'rendererType' is not assigned and could be declared final143
Parameter 'facesContext' is not assigned and could be declared final143
The method 'getRenderer' has a Cyclomatic Complexity of 7.143 - 172
Local variable 'clientKey' could be declared final147
Local variable 'cacheKey' could be declared final148
Local variable 'classes' could be declared final157
Avoid if (x != y) ..; else ..;158 - 164
Local variable 'clazz' could be declared final159
Parameter 'name' is not assigned and could be declared final175
Parameter 'viewRoot' is not assigned and could be declared final175
Parameter 'facesContext' is not assigned and could be declared final179
Parameter 'name' is not assigned and could be declared final179
Parameter 'name' is not assigned and could be declared final184
Parameter 'viewRoot' is not assigned and could be declared final184
Parameter 'facesContext' is not assigned and could be declared final188
Parameter 'name' is not assigned and could be declared final188
Parameter 'bundle' is not assigned and could be declared final193
Parameter 'propertyKey' is not assigned and could be declared final193
Parameter 'viewRoot' is not assigned and could be declared final193
The method 'getThemeProperty' has a Cyclomatic Complexity of 5.193 - 212
Local variable 'clientKey' could be declared final196
Local variable 'cacheKey' could be declared final197
Local variable 'properties' could be declared final201
Avoid if (x != y) ..; else ..;202 - 206
Parameter 'configurable' is not assigned and could be declared final214
Parameter 'facesContext' is not assigned and could be declared final214
Parameter 'name' is not assigned and could be declared final214
Parameter 'rendererType' is not assigned and could be declared final218
Parameter 'markup' is not assigned and could be declared final218
Parameter 'facesContext' is not assigned and could be declared final218
Parameter 'name' is not assigned and could be declared final218
The method 'getThemeMeasure' has a Cyclomatic Complexity of 7.218 - 253
Local variable 'clientKey' could be declared final220
Local variable 'cacheKey' could be declared final221
Local variable 'properties' could be declared final226 - 227
Local variable 'mProperties' could be declared final236 - 237
Avoid if (x != y) ..; else ..;245 - 249
Parameter 'name' is not assigned and could be declared final256
Parameter 'viewRoot' is not assigned and could be declared final256
Parameter 'facesContext' is not assigned and could be declared final260
Parameter 'name' is not assigned and could be declared final260
Parameter 'name' is not assigned and could be declared final265
Parameter 'ignoreMissing' is not assigned and could be declared final265
Parameter 'viewRoot' is not assigned and could be declared final265
Parameter 'facesContext' is not assigned and could be declared final269
Parameter 'name' is not assigned and could be declared final269
Parameter 'ignoreMissing' is not assigned and could be declared final269
The method 'getImage' has a Cyclomatic Complexity of 7.269 - 300
Local variable 'clientKey' could be declared final276
Local variable 'cacheKey' could be declared final277
Local variable 'paths' could be declared final281 - 282
Avoid if (x != y) ..; else ..;283 - 287
These nested if statements could be combined291 - 293
These nested if statements could be combined291 - 293
The method 'getPaths' has a Cyclomatic Complexity of 30.302 - 387
The method getPaths() has an NPath complexity of 2100302 - 387
Avoid really long parameter lists.302 - 305
The method 'getPaths' has a Cyclomatic Complexity of 30.302 - 387
Parameter 'prefix' is not assigned and could be declared final303
Parameter 'subDir' is not assigned and could be declared final303
Parameter 'name' is not assigned and could be declared final303
Parameter 'suffix' is not assigned and could be declared final303
Parameter 'clientkey' is not assigned and could be declared final303
Parameter 'reverseOrder' is not assigned and could be declared final304
Parameter 'single' is not assigned and could be declared final304
Parameter 'returnKey' is not assigned and could be declared final304
Parameter 'returnStrings' is not assigned and could be declared final304
Parameter 'key' is not assigned and could be declared final304
Parameter 'ignoreMissing' is not assigned and could be declared final305
Local variable 'matches' could be declared final306
Local variable 'contentType' could be declared final307
Local variable 'theme' could be declared final308
Local variable 'browser' could be declared final309
Local variable 'locales' could be declared final310
Local variable 'found' could be declared final328 - 329
Local variable 'found' could be declared final358 - 360
The method 'checkPath' has a Cyclomatic Complexity of 11.389 - 430
Avoid really long parameter lists.389 - 391
The method 'checkPath' has a Cyclomatic Complexity of 11.389 - 430
Parameter 'reverseOrder' is not assigned and could be declared final390
Parameter 'returnKey' is not assigned and could be declared final390
Parameter 'prefix' is not assigned and could be declared final390
Parameter 'returnStrings' is not assigned and could be declared final390
Parameter 'extension' is not assigned and could be declared final391
Parameter 'matches' is not assigned and could be declared final391
Parameter 'localeSuffix' is not assigned and could be declared final391
Parameter 'name' is not assigned and could be declared final391
Parameter 'minimizeSuffix' is not assigned and could be declared final391
Parameter 'key' is not assigned and could be declared final391
Local variable 'result' could be declared final394 - 397
Avoid if (x != y) ..; else ..;409 - 428
Local variable 'clazz' could be declared final412
The String literal "testing path: " appears 6 times in this file; the first occurrence is on line 414414
The method 'checkPath' has a Cyclomatic Complexity of 14.432 - 478
Avoid really long parameter lists.432 - 435
The method 'checkPath' has a Cyclomatic Complexity of 14.432 - 478
Parameter 'reverseOrder' is not assigned and could be declared final433
Parameter 'returnKey' is not assigned and could be declared final433
Parameter 'prefix' is not assigned and could be declared final433
Parameter 'returnStrings' is not assigned and could be declared final433
Parameter 'browserType' is not assigned and could be declared final434
Parameter 'contentType' is not assigned and could be declared final434
Parameter 'currentTheme' is not assigned and could be declared final434
Parameter 'matches' is not assigned and could be declared final434
Parameter 'resourceDirectory' is not assigned and could be declared final434
Parameter 'localeSuffix' is not assigned and could be declared final435
Parameter 'subDir' is not assigned and could be declared final435
Parameter 'minimizeSuffix' is not assigned and could be declared final435
Parameter 'suffix' is not assigned and could be declared final435
Parameter 'name' is not assigned and could be declared final435
Parameter 'key' is not assigned and could be declared final435
Avoid if (x != y) ..; else ..;457 - 476
Local variable 'clazz' could be declared final460
The method 'makePath' has a Cyclomatic Complexity of 5.480 - 514
Avoid really long parameter lists.480 - 482
Parameter 'project' is not assigned and could be declared final481
Parameter 'theme' is not assigned and could be declared final481
Parameter 'subDir' is not assigned and could be declared final481
Parameter 'browser' is not assigned and could be declared final481
Parameter 'language' is not assigned and could be declared final481
Parameter 'extension' is not assigned and could be declared final482
Parameter 'localeSuffix' is not assigned and could be declared final482
Parameter 'name' is not assigned and could be declared final482
Parameter 'minimizeSuffix' is not assigned and could be declared final482
Parameter 'key' is not assigned and could be declared final482
Parameter 'version' is not assigned and could be declared final482
Local variable 'searchtext' could be declared final483
Parameter 'extension' is not assigned and could be declared final517
Parameter 'localeSuffix' is not assigned and could be declared final517
Parameter 'name' is not assigned and could be declared final517
Parameter 'minimizeSuffix' is not assigned and could be declared final517
Parameter 'key' is not assigned and could be declared final517
Local variable 'searchtext' could be declared final518
Parameter 'rendererType' is not assigned and could be declared final535
Prefer StringBuffer over += for concatenating strings545
Parameter 'facesContext' is not assigned and could be declared final554
Parameter 'name' is not assigned and could be declared final554
Parameter 'type' is not assigned and could be declared final554
The method 'getStrings' has a Cyclomatic Complexity of 6.554 - 580
Local variable 'key' could be declared final562
Local variable 'miscKey' could be declared final563
Local variable 'cacheResult' could be declared final564
Local variable 'matches' could be declared final569 - 570

Tobago Core - org/apache/myfaces/tobago/internal/context/ResponseWriterDivider.java

ViolationLine
A class which only has private constructors should be final37 - 155
Private field 'writers' could be made final; it is only initialized in the declaration or constructor.41
Private field 'buffers' could be made final; it is only initialized in the declaration or constructor.42
Private field 'original' could be made final; it is only initialized in the declaration or constructor.44
Parameter 'facesContext' is not assigned and could be declared final50
Parameter 'nameInRequest' is not assigned and could be declared final50
Parameter 'facesContext' is not assigned and could be declared final62
Parameter 'facesContext' is not assigned and could be declared final76
Local variable 'buffer' could be declared final83
Local variable 'newWriter' could be declared final85
Parameter 'facesContext' is not assigned and could be declared final103
Parameter 'facesContext' is not assigned and could be declared final127
Local variable 'builder' could be declared final139

Tobago Core - org/apache/myfaces/tobago/internal/context/StringValue.java

ViolationLine
The class 'StringValue' has a Cyclomatic Complexity of 3 (Highest = 6).25 - 61
Private field 'value' could be made final; it is only initialized in the declaration or constructor.29
Parameter 'value' is not assigned and could be declared final31
Parameter 'o' is not assigned and could be declared final40
The method 'equals' has a Cyclomatic Complexity of 6.40 - 55
Local variable 'that' could be declared final48
Avoid if (x != y) ..; else ..;50
Avoid if (x != y) ..; else ..;59

Tobago Core - org/apache/myfaces/tobago/internal/context/ThemeBuilder.java

ViolationLine
The class 'ThemeBuilder' has a Cyclomatic Complexity of 4 (Highest = 10).34 - 83
The class 'ThemeBuilder' has a Cyclomatic Complexity of 4 (Highest = 10).34 - 83
Private field 'availableThemes' could be made final; it is only initialized in the declaration or constructor.38
Private field 'tobagoConfig' could be made final; it is only initialized in the declaration or constructor.39
Parameter 'tobagoConfig' is not assigned and could be declared final41
The method 'resolveThemes' has a Cyclomatic Complexity of 10.45 - 78
The method resolveThemes() has an NPath complexity of 38445 - 78
The method 'resolveThemes' has a Cyclomatic Complexity of 10.45 - 78
Local variable 'map' could be declared final46
Local variable 'fallbackName' could be declared final52
Local variable 'fallback' could be declared final53
Local variable 'result' could be declared final62
Parameter 'theme' is not assigned and could be declared final80

Tobago Core - org/apache/myfaces/tobago/internal/context/ThemeConfigCacheKey.java

ViolationLine
The class 'ThemeConfigCacheKey' has a Cyclomatic Complexity of 3 (Highest = 9).24 - 89
Parameter 'rendererType' is not assigned and could be declared final33
Parameter 'markup' is not assigned and could be declared final33
Parameter 'clientPropertiesKey' is not assigned and could be declared final33
Parameter 'name' is not assigned and could be declared final33
Parameter 'o' is not assigned and could be declared final42
The method 'equals' has a Cyclomatic Complexity of 9.42 - 66
Local variable 'cacheKey' could be declared final50
Avoid if (x != y) ..; else ..;58
Avoid if (x != y) ..; else ..;72

Tobago Core - org/apache/myfaces/tobago/internal/layout/BankHead.java

ViolationLine
Parameter 'token' is not assigned and could be declared final39
Parameter 'token' is not assigned and could be declared final48
Parameter 'intervalList' is not assigned and could be declared final56
Parameter 'current' is not assigned and could be declared final64
Parameter 'rendered' is not assigned and could be declared final72

Tobago Core - org/apache/myfaces/tobago/internal/layout/FactorList.java

ViolationLine
The class 'FactorList' has a Cyclomatic Complexity of 5 (Highest = 4).29 - 56
Avoid unused private fields such as 'LOG'.31
Avoid unused private fields such as 'LOG'.31
Parameter 'size' is not assigned and could be declared final33
Local variable 'result' could be declared final35

Tobago Core - org/apache/myfaces/tobago/internal/layout/Grid.java

ViolationLine
The class 'Grid' has a Cyclomatic Complexity of 5 (Highest = 55).32 - 498
This class has too many methods, consider refactoring it.32 - 498
The class 'Grid' has a Cyclomatic Complexity of 5 (Highest = 55).32 - 498
Private field 'cells' could be made final; it is only initialized in the declaration or constructor.40
Private field 'columnHeads' could be made final; it is only initialized in the declaration or constructor.42
Private field 'columnCount' could be made final; it is only initialized in the declaration or constructor.45
Parameter 'columns' is not assigned and could be declared final56
Parameter 'rows' is not assigned and could be declared final56
Avoid instantiating new objects inside loops65
Avoid instantiating new objects inside loops69
Local variable 'size' could be declared final71
Avoid reassigning parameters such as 'columnSpan'78
Avoid reassigning parameters such as 'columnSpan'78
Parameter 'cell' is not assigned and could be declared final78
Parameter 'rowSpan' is not assigned and could be declared final78
The method 'add' has a Cyclomatic Complexity of 9.78 - 121
Avoid instantiating new objects inside loops110
Parameter 'orientation' is not assigned and could be declared final123
Parameter 'j' is not assigned and could be declared final123
Parameter 'i' is not assigned and could be declared final123
Parameter 'column' is not assigned and could be declared final127
Parameter 'row' is not assigned and could be declared final127
Parameter 'cell' is not assigned and could be declared final138
Parameter 'column' is not assigned and could be declared final138
Parameter 'row' is not assigned and could be declared final138
Parameter 'orientation' is not assigned and could be declared final156
Parameter 'newRows' is not assigned and could be declared final160
Local variable 'newRowHeads' could be declared final170
Avoid instantiating new objects inside loops176
Parameter 'orientation' is not assigned and could be declared final182
Parameter 'orientation' is not assigned and could be declared final186
Parameter 'overflow' is not assigned and could be declared final186
Parameter 'columnOverflow' is not assigned and could be declared final198
Parameter 'rowOverflow' is not assigned and could be declared final206
Parameter 'j' is not assigned and could be declared final210
Parameter 'i' is not assigned and could be declared final210
Parameter 'j' is not assigned and could be declared final217
Parameter 'i' is not assigned and could be declared final217
The method 'gridAsString' has a Cyclomatic Complexity of 55.246 - 474
The method gridAsString() has an NPath complexity of 11503356246 - 474
Avoid really long methods.246 - 474
The method 'gridAsString' has a Cyclomatic Complexity of 55.246 - 474
The method gridAsString() has an NCSS line count of 175246 - 474
Local variable 'builder' could be declared final248
Avoid if (x != y) ..; else ..;253 - 257
Local variable 'c' could be declared final259
Local variable 'd' could be declared final260
Avoid if (x != y) ..; else ..;277 - 281
Avoid if (x != y) ..; else ..;284 - 288
Local variable 'b' could be declared final297
Local variable 'd' could be declared final298
Local variable 'a' could be declared final315
Local variable 'b' could be declared final316
Local variable 'c' could be declared final317
Local variable 'd' could be declared final318
Local variable 'a' could be declared final358
Local variable 'c' could be declared final359
Local variable 'a' could be declared final366
Local variable 'c' could be declared final367
Avoid if (x != y) ..; else ..;389 - 393
Local variable 'c' could be declared final395
Local variable 'd' could be declared final396
Local variable 'a' could be declared final412
Local variable 'c' could be declared final413
Avoid if (x != y) ..; else ..;425 - 429
Avoid if (x != y) ..; else ..;436 - 440
Local variable 'a' could be declared final442
Local variable 'b' could be declared final443
Avoid if (x != y) ..; else ..;460 - 464
Avoid if (x != y) ..; else ..;466 - 470
Local variable 'builder' could be declared final478
Parameter 'b' is not assigned and could be declared final489
Parameter 'a' is not assigned and could be declared final489
The method 'connected' has a Cyclomatic Complexity of 5.489 - 497

Tobago Core - org/apache/myfaces/tobago/internal/layout/Interval.java

ViolationLine
The class 'Interval' has a Cyclomatic Complexity of 3 (Highest = 6).29 - 103
Parameter 'orientation' is not assigned and could be declared final41
Parameter 'component' is not assigned and could be declared final41
The constructor 'Interval' has a Cyclomatic Complexity of 5.41 - 47
Parameter 'minimum' is not assigned and could be declared final49
Parameter 'maximum' is not assigned and could be declared final49
Parameter 'current' is not assigned and could be declared final49
Parameter 'preferred' is not assigned and could be declared final49
The constructor 'Interval' has a Cyclomatic Complexity of 6.49 - 62
Parameter 'interval' is not assigned and could be declared final65
Parameter 'divider' is not assigned and could be declared final65
The constructor 'Interval' has a Cyclomatic Complexity of 5.65 - 71
Avoid if (x != y) ..; else ..;66 - 67
Avoid if (x != y) ..; else ..;68
Avoid if (x != y) ..; else ..;69
Avoid if (x != y) ..; else ..;70
Local variable 'builder' could be declared final91

Tobago Core - org/apache/myfaces/tobago/internal/layout/IntervalList.java

ViolationLine
The class 'IntervalList' has a Cyclomatic Complexity of 3 (Highest = 6).29 - 101
Local variable 'minimumList' could be declared final37
Local variable 'maximumList' could be declared final38
Local variable 'maximum' could be declared final40
Local variable 'preferred' could be declared final48
Avoid if (x != y) ..; else ..;49 - 53
Local variable 'result' could be declared final58
Local variable 'result' could be declared final71
Parameter 'min' is not assigned and could be declared final80
Parameter 'max' is not assigned and could be declared final80
The method 'findPreferredInInterval' has a Cyclomatic Complexity of 6.80 - 92
Local variable 'result' could be declared final81

Tobago Core - org/apache/myfaces/tobago/internal/layout/LayoutContext.java

ViolationLine
The class 'LayoutContext' has a Cyclomatic Complexity of 5 (Highest = 12).59 - 159
The class 'LayoutContext' has a Cyclomatic Complexity of 5 (Highest = 12).59 - 159
Private field 'container' could be made final; it is only initialized in the declaration or constructor.63
Parameter 'container' is not assigned and could be declared final65
The method 'layout' has a Cyclomatic Complexity of 12.69 - 120
The method layout() has an NPath complexity of 204869 - 120
The method 'layout' has a Cyclomatic Complexity of 12.69 - 120
Local variable 'layoutManager' could be declared final78
Parameter 'message' is not assigned and could be declared final122
Parameter 'trace' is not assigned and could be declared final122
Local variable 'buffer' could be declared final123
Avoid concatenating nonliterals in a StringBuffer constructor or append().123
Parameter 'buffer' is not assigned and could be declared final132
Parameter 'component' is not assigned and could be declared final132
Parameter 'depth' is not assigned and could be declared final132
The method 'log' has a Cyclomatic Complexity of 5.132 - 158
Local variable 'facesContext' could be declared final133
Avoid appending characters as strings in StringBuffer.append.136
Avoid appending characters as strings in StringBuffer.append.139
Avoid appending characters as strings in StringBuffer.append.143
Local variable 'layoutManager' could be declared final146
Avoid appending characters as strings in StringBuffer.append.148
Avoid appending characters as strings in StringBuffer.append.154

Tobago Core - org/apache/myfaces/tobago/internal/layout/LayoutUtils.java

ViolationLine
The class 'LayoutUtils' has a Cyclomatic Complexity of 3 (Highest = 8).37 - 129
Avoid unused private fields such as 'LOG'.39
Avoid unused private fields such as 'LOG'.39
Parameter 'columns' is not assigned and could be declared final47
Local variable 'st' could be declared final48
Local variable 'token' could be declared final50
Parameter 'container' is not assigned and could be declared final58
Local variable 'result' could be declared final59
Parameter 'result' is not assigned and could be declared final64
Parameter 'component' is not assigned and could be declared final64
Parameter 'orientation' is not assigned and could be declared final76
Parameter 'container' is not assigned and could be declared final76
Parameter 'orientation' is not assigned and could be declared final80
Parameter 'container' is not assigned and could be declared final80
Parameter 'orientation' is not assigned and could be declared final84
Parameter 'container' is not assigned and could be declared final84
Parameter 'orientation' is not assigned and could be declared final88
Parameter 'container' is not assigned and could be declared final88
Parameter 'orientation' is not assigned and could be declared final92
Parameter 'component' is not assigned and could be declared final92
Avoid reassigning parameters such as 'size'96
Avoid reassigning parameters such as 'size'96
Avoid reassigning parameters such as 'size'96
Avoid reassigning parameters such as 'size'96
Avoid reassigning parameters such as 'size'96
Avoid reassigning parameters such as 'size'96
Parameter 'orientation' is not assigned and could be declared final96
Parameter 'component' is not assigned and could be declared final96
The method 'setCurrentSize' has a Cyclomatic Complexity of 8.96 - 128
Avoid if (x != y) ..; else ..;99 - 110
Avoid if (x != y) ..; else ..;114 - 125

Tobago Core - org/apache/myfaces/tobago/internal/layout/MathUtils.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.22 - 108
The class 'MathUtils' has a Cyclomatic Complexity of 2 (Highest = 5).22 - 108
Avoid reassigning parameters such as 'bias'35
Parameter 'list' is not assigned and could be declared final35
Local variable 'remainder' could be declared final56
The method 'findAndAdjustMinRemainder' has a Cyclomatic Complexity of 5.69 - 87
Local variable 'remainder' could be declared final73
Parameter 'v' is not assigned and could be declared final89
Parameter 'factor' is not assigned and could be declared final93
Parameter 'factor' is not assigned and could be declared final97
Parameter 'value' is not assigned and could be declared final101
Parameter 'value' is not assigned and could be declared final105

Tobago Core - org/apache/myfaces/tobago/internal/layout/OriginCell.java

ViolationLine
Private field 'component' could be made final; it is only initialized in the declaration or constructor.27
Parameter 'component' is not assigned and could be declared final31
Parameter 'orientation' is not assigned and could be declared final51
Parameter 'columnSpan' is not assigned and could be declared final59
Parameter 'rowSpan' is not assigned and could be declared final67

Tobago Core - org/apache/myfaces/tobago/internal/layout/SpanCell.java

ViolationLine
Private field 'origin' could be made final; it is only initialized in the declaration or constructor.26
Private field 'horizontalFirst' could be made final; it is only initialized in the declaration or constructor.27
Private field 'verticalFirst' could be made final; it is only initialized in the declaration or constructor.28
Parameter 'verticalFirst' is not assigned and could be declared final30
Parameter 'horizontalFirst' is not assigned and could be declared final30
Parameter 'origin' is not assigned and could be declared final30

Tobago Core - org/apache/myfaces/tobago/internal/lifecycle/ApplyRequestValuesExecutor.java

ViolationLine
Parameter 'facesContext' is not assigned and could be declared final32

Tobago Core - org/apache/myfaces/tobago/internal/lifecycle/InvokeApplicationExecutor.java

ViolationLine
Parameter 'facesContext' is not assigned and could be declared final31

Tobago Core - org/apache/myfaces/tobago/internal/lifecycle/PhaseListenerManager.java

ViolationLine
The class 'PhaseListenerManager' has a Cyclomatic Complexity of 4 (Highest = 6).38 - 111
Private field 'lifecycle' could be made final; it is only initialized in the declaration or constructor.42
Private field 'facesContext' could be made final; it is only initialized in the declaration or constructor.43
Private field 'phaseListeners' could be made final; it is only initialized in the declaration or constructor.44
Private field 'listenerSuccessMap' could be made final; it is only initialized in the declaration or constructor.49
Parameter 'phaseListeners' is not assigned and could be declared final54
Parameter 'lifecycle' is not assigned and could be declared final54
Parameter 'facesContext' is not assigned and could be declared final54
Parameter 'phaseListener' is not assigned and could be declared final60
Parameter 'phaseId' is not assigned and could be declared final60
Local variable 'listenerPhaseId' could be declared final61
Parameter 'phaseId' is not assigned and could be declared final66
The method 'informPhaseListenersBefore' has a Cyclomatic Complexity of 5.66 - 88
Local variable 'phaseListener' could be declared final76
Parameter 'phaseId' is not assigned and could be declared final90
The method 'informPhaseListenersAfter' has a Cyclomatic Complexity of 6.90 - 110
Local variable 'beforePhaseSuccess' could be declared final91
Local variable 'phaseListener' could be declared final99

Tobago Core - org/apache/myfaces/tobago/internal/lifecycle/ProcessValidationsExecutor.java

ViolationLine
Parameter 'facesContext' is not assigned and could be declared final31

Tobago Core - org/apache/myfaces/tobago/internal/lifecycle/RenderResponseExecutor.java

ViolationLine
Parameter 'facesContext' is not assigned and could be declared final38
Local variable 'application' could be declared final39
Local variable 'viewHandler' could be declared final40
Avoid if (x != y) ..; else ..;44 - 53
Local variable 'respObj' could be declared final47
Local variable 'respHttp' could be declared final49

Tobago Core - org/apache/myfaces/tobago/internal/lifecycle/RestoreViewExecutor.java

ViolationLine
The class 'RestoreViewExecutor' has a Cyclomatic Complexity of 6 (Highest = 16).53 - 251
The class 'RestoreViewExecutor' has a Cyclomatic Complexity of 6 (Highest = 16).53 - 251
Parameter 'facesContext' is not assigned and could be declared final57
The method 'execute' has a Cyclomatic Complexity of 16.57 - 139
The method execute() has an NPath complexity of 336057 - 139
The method 'execute' has a Cyclomatic Complexity of 16.57 - 139
Local variable 'externalContext' could be declared final58
Local variable 'sessionMap' could be declared final60
Local variable 'messageHolders' could be declared final66
Local variable 'viewId' could be declared final88
Local variable 'application' could be declared final107
Local variable 'viewHandler' could be declared final108
Local variable 'postBack' could be declared final110
Parameter 'facesContext' is not assigned and could be declared final141
Local variable 'requestParameterMap' could be declared final142
Parameter 'facesContext' is not assigned and could be declared final146
Parameter 'facesContext' is not assigned and could be declared final158
The method 'deriveViewId' has a Cyclomatic Complexity of 7.158 - 195
Local variable 'externalContext' could be declared final159
Local variable 'msg' could be declared final170
Local variable 'defaultSuffix' could be declared final177
Avoid if (x != y) ..; else ..;178
Local variable 'suffix' could be declared final178
Local variable 'msg' could be declared final180
Local variable 'dot' could be declared final185
Assigning an Object to null is a code smell. Consider refactoring.188
Parameter 'facesContext' is not assigned and could be declared final199
The method 'recursivelyHandleComponentReferencesAndSetValid' has a Cyclomatic Complexity of 8.199 - 228
Parameter 'parent' is not assigned and could be declared final200
Local variable 'forceHandle' could be declared final201
Local variable 'handleBindingsMethod' could be declared final203
Avoid if (x != y) ..; else ..;205 - 227
Local variable 'it' could be declared final213
Local variable 'component' could be declared final214
Local variable 'binding' could be declared final216
Parameter 'parent' is not assigned and could be declared final235
Local variable 'interfaces' could be declared final236
Avoid instantiating new objects inside loops241
Avoid empty catch blocks242 - 244
Avoid empty catch blocks242 - 244

Tobago Core - org/apache/myfaces/tobago/internal/lifecycle/TobagoLifecycle.java

ViolationLine
The class 'TobagoLifecycle' has a Cyclomatic Complexity of 4 (Highest = 9).38 - 207
Private field 'lifecycleExecutors' could be made final; it is only initialized in the declaration or constructor.45
Private field 'renderExecutor' could be made final; it is only initialized in the declaration or constructor.46
Parameter 'context' is not assigned and could be declared final68
Local variable 'phaseListenerMgr' could be declared final70
Parameter 'phaseListenerMgr' is not assigned and could be declared final83
Parameter 'facesContext' is not assigned and could be declared final83
Parameter 'executor' is not assigned and could be declared final83
The method 'executePhase' has a Cyclomatic Complexity of 9.83 - 121
The String literal " in " appears 4 times in this file; the first occurrence is on line 8888
Parameter 'facesContext' is not assigned and could be declared final123
The method 'render' has a Cyclomatic Complexity of 5.123 - 150
Local variable 'phaseListenerMgr' could be declared final132
Parameter 'facesContext' is not assigned and could be declared final152
Parameter 'before' is not assigned and could be declared final152
Parameter 'phase' is not assigned and could be declared final152
Parameter 'facesContext' is not assigned and could be declared final165
Parameter 'before' is not assigned and could be declared final165
Parameter 'phase' is not assigned and could be declared final165
Parameter 'phaseListener' is not assigned and could be declared final178
Assigning an Object to null is a code smell. Consider refactoring.184
Parameter 'phaseListener' is not assigned and could be declared final188
Assigning an Object to null is a code smell. Consider refactoring.194

Tobago Core - org/apache/myfaces/tobago/internal/lifecycle/TobagoLifecycleFactory.java

ViolationLine
Private field 'factory' could be made final; it is only initialized in the declaration or constructor.33
Private field 'defaultLifecycle' could be made final; it is only initialized in the declaration or constructor.34
Parameter 'factory' is not assigned and could be declared final36
Parameter 'lifecycle' is not assigned and could be declared final44
Parameter 'lifecycleId' is not assigned and could be declared final44
Do not add empty strings47
Parameter 'lifecycleId' is not assigned and could be declared final51

Tobago Core - org/apache/myfaces/tobago/internal/lifecycle/UpdateModelValuesExecutor.java

ViolationLine
Parameter 'facesContext' is not assigned and could be declared final32

Tobago Core - org/apache/myfaces/tobago/internal/taglib/TagUtils.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.52 - 307
The class 'TagUtils' has a Cyclomatic Complexity of 3 (Highest = 9).52 - 307
Avoid reassigning parameters such as 'value'59
Parameter 'component' is not assigned and could be declared final59
Parameter 'name' is not assigned and could be declared final59
The method 'setIntegerProperty' has a Cyclomatic Complexity of 9.59 - 75
These nested if statements could be combined68 - 70
Deeply nested if..then statements are hard to read68 - 70
These nested if statements could be combined68 - 70
Avoid instantiating Integer objects. Call Integer.valueOf() instead.72
Parameter 'component' is not assigned and could be declared final81
Parameter 'name' is not assigned and could be declared final81
Parameter 'value' is not assigned and could be declared final81
Parameter 'component' is not assigned and could be declared final95
Parameter 'name' is not assigned and could be declared final95
Parameter 'value' is not assigned and could be declared final95
Parameter 'component' is not assigned and could be declared final109
Parameter 'name' is not assigned and could be declared final109
Parameter 'value' is not assigned and could be declared final109
Local variable 'valueBinding' could be declared final114
Local variable 'converter' could be declared final117
Parameter 'component' is not assigned and could be declared final127
Parameter 'name' is not assigned and could be declared final127
Parameter 'value' is not assigned and could be declared final127
Parameter 'component' is not assigned and could be declared final135
Parameter 'name' is not assigned and could be declared final135
Parameter 'value' is not assigned and could be declared final135
Parameter 'component' is not assigned and could be declared final143
Parameter 'name' is not assigned and could be declared final143
Parameter 'value' is not assigned and could be declared final143
Parameter 'value' is not assigned and could be declared final151
Parameter 'component' is not assigned and could be declared final159
Parameter 'args' is not assigned and could be declared final159
Parameter 'value' is not assigned and could be declared final159
Local variable 'methodBinding' could be declared final161
Parameter 'component' is not assigned and could be declared final170
Parameter 'args' is not assigned and could be declared final170
Parameter 'value' is not assigned and could be declared final170
Local variable 'methodBinding' could be declared final172
Parameter 'component' is not assigned and could be declared final181
Parameter 'args' is not assigned and could be declared final181
Parameter 'value' is not assigned and could be declared final181
Local variable 'methodBinding' could be declared final183
Parameter 'component' is not assigned and could be declared final192
Parameter 'args' is not assigned and could be declared final192
Parameter 'value' is not assigned and could be declared final192
Local variable 'methodBinding' could be declared final194
Parameter 'component' is not assigned and could be declared final203
Parameter 'args' is not assigned and could be declared final203
Parameter 'value' is not assigned and could be declared final203
Local variable 'methodBinding' could be declared final205
Parameter 'component' is not assigned and could be declared final214
Parameter 'args' is not assigned and could be declared final214
Parameter 'value' is not assigned and could be declared final214
Local variable 'methodBinding' could be declared final216
Parameter 'component' is not assigned and could be declared final225
Parameter 'args' is not assigned and could be declared final225
Parameter 'value' is not assigned and could be declared final225
Local variable 'methodBinding' could be declared final228 - 229
Parameter 'component' is not assigned and could be declared final241
Parameter 'args' is not assigned and could be declared final241
Parameter 'value' is not assigned and could be declared final241
Local variable 'methodBinding' could be declared final243
Parameter 'component' is not assigned and could be declared final252
Parameter 'name' is not assigned and could be declared final252
Parameter 'value' is not assigned and could be declared final252
The method 'setStringArrayProperty' has a Cyclomatic Complexity of 6.252 - 269
Local variable 'components' could be declared final257
Parameter 'component' is not assigned and could be declared final275
Parameter 'name' is not assigned and could be declared final275
Parameter 'value' is not assigned and could be declared final275
Local variable 'valueBinding' could be declared final277
Parameter 'component' is not assigned and could be declared final286
Parameter 'name' is not assigned and could be declared final286
Parameter 'value' is not assigned and could be declared final286
Avoid reassigning parameters such as 'script'300
Local variable 'valueBinding' could be declared final302

Tobago Core - org/apache/myfaces/tobago/internal/taglib/TobagoBodyTag.java

ViolationLine
Avoid unused private fields such as 'LOG'.31
Avoid unused private fields such as 'LOG'.31
Document empty method39 - 40
An empty method in an abstract class should be abstract instead39 - 40
Local variable 'content' could be declared final43
Local variable 'content' could be declared final50
Local variable 'tmp' could be declared final51
String.trim().length()==0 is an inefficient way to validate an empty String.52
Assigning an Object to null is a code smell. Consider refactoring.69
Parameter 'bodyContent' is not assigned and could be declared final72

Tobago Core - org/apache/myfaces/tobago/internal/taglib/TobagoELTag.java

ViolationLine
Local variable 'result' could be declared final35
Local variable 'component' could be declared final36
Local variable 'component' could be declared final47
Local variable 'result' could be declared final48
Parameter 'renderers' is not assigned and could be declared final57
Local variable 'content' could be declared final67
Local variable 'content' could be declared final79
Local variable 'tmp' could be declared final80
String.trim().length()==0 is an inefficient way to validate an empty String.81

Tobago Core - org/apache/myfaces/tobago/internal/taglib/TobagoTag.java

ViolationLine
Local variable 'result' could be declared final32
Local variable 'component' could be declared final34
Parameter 'renderers' is not assigned and could be declared final43

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/AttributeTag.java

ViolationLine
The class 'AttributeTag' has a Cyclomatic Complexity of 3 (Highest = 8).47 - 141
The method 'doStartTag' has a Cyclomatic Complexity of 8.59 - 95
Local variable 'tag' could be declared final62 - 63
Local variable 'component' could be declared final73
Avoid if (x != y) ..; else ..;83 - 93
Local variable 'components' could be declared final89
Assigning an Object to null is a code smell. Consider refactoring.100
Assigning an Object to null is a code smell. Consider refactoring.101
Parameter 'name' is not assigned and could be declared final108
Parameter 'value' is not assigned and could be declared final116
Parameter 'mode' is not assigned and could be declared final137

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/CellTagDeclaration.java

ViolationLine
The String literal "java.lang.Integer" appears 4 times in this file; the first occurrence is on line 5252

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/CommandTagExtraInfo.java

ViolationLine
Parameter 'data' is not assigned and could be declared final29
Local variable 'action' could be declared final30
Local variable 'onclick' could be declared final31
Local variable 'link' could be declared final32
Parameter 'data' is not assigned and could be declared final40

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/ConverterTag.java

ViolationLine
The class 'ConverterTag' has a Cyclomatic Complexity of 4 (Highest = 12).45 - 137
The class 'ConverterTag' has a Cyclomatic Complexity of 4 (Highest = 12).45 - 137
The method 'doStartTag' has a Cyclomatic Complexity of 12.61 - 113
The method doStartTag() has an NPath complexity of 57661 - 113
The method 'doStartTag' has a Cyclomatic Complexity of 12.61 - 113
Local variable 'tag' could be declared final64 - 65
Local variable 'component' could be declared final75
Local variable 'valueHolder' could be declared final84
Local variable 'localConverterId' could be declared final96
Avoid if (x != y) ..; else ..;102 - 109
Local variable 've' could be declared final103
Assigning an Object to null is a code smell. Consider refactoring.118
Assigning an Object to null is a code smell. Consider refactoring.119
Parameter 'converterId' is not assigned and could be declared final126
Parameter 'binding' is not assigned and could be declared final134

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/DataAttributeTag.java

ViolationLine
Assigning an Object to null is a code smell. Consider refactoring.57
Assigning an Object to null is a code smell. Consider refactoring.58
Local variable 'tag' could be declared final67 - 68
Parameter 'name' is not assigned and could be declared final100
Parameter 'value' is not assigned and could be declared final110

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/FileItemValidatorTag.java

ViolationLine
Assigning an Object to null is a code smell. Consider refactoring.77
Assigning an Object to null is a code smell. Consider refactoring.78
Parameter 'maxSize' is not assigned and could be declared final82
Parameter 'contentType' is not assigned and could be declared final87

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/GridLayoutConstraintTag.java

ViolationLine
The class 'GridLayoutConstraintTag' has a Cyclomatic Complexity of 3 (Highest = 39).46 - 460
The class 'GridLayoutConstraintTag' has a Cyclomatic Complexity of 3 (Highest = 39).46 - 460
Too many fields46 - 460
The method 'doStartTag' has a Cyclomatic Complexity of 39.76 - 236
Avoid really long methods.76 - 236
The method 'doStartTag' has a Cyclomatic Complexity of 39.76 - 236
Local variable 'tag' could be declared final79 - 80
The String literal "Ignoring '" appears 10 times in this file; the first occurrence is on line 113113
The String literal "', because the parent is not a LayoutContainer!" appears 8 times in this file; the first occurrence is on line 177177
Assigning an Object to null is a code smell. Consider refactoring.241
Assigning an Object to null is a code smell. Consider refactoring.242
Assigning an Object to null is a code smell. Consider refactoring.243
Assigning an Object to null is a code smell. Consider refactoring.244
Assigning an Object to null is a code smell. Consider refactoring.245
Assigning an Object to null is a code smell. Consider refactoring.246
Assigning an Object to null is a code smell. Consider refactoring.247
Assigning an Object to null is a code smell. Consider refactoring.248
Assigning an Object to null is a code smell. Consider refactoring.249
Assigning an Object to null is a code smell. Consider refactoring.250
Assigning an Object to null is a code smell. Consider refactoring.251
Assigning an Object to null is a code smell. Consider refactoring.252
Assigning an Object to null is a code smell. Consider refactoring.253
Assigning an Object to null is a code smell. Consider refactoring.254
Assigning an Object to null is a code smell. Consider refactoring.255
Assigning an Object to null is a code smell. Consider refactoring.256
Assigning an Object to null is a code smell. Consider refactoring.257
Assigning an Object to null is a code smell. Consider refactoring.258
Assigning an Object to null is a code smell. Consider refactoring.259
Assigning an Object to null is a code smell. Consider refactoring.260
Assigning an Object to null is a code smell. Consider refactoring.261
Assigning an Object to null is a code smell. Consider refactoring.262
Parameter 'columnSpan' is not assigned and could be declared final269
Parameter 'rowSpan' is not assigned and could be declared final277
The String literal "org.apache.myfaces.tobago.layout.Measure" appears 40 times in this file; the first occurrence is on line 284284
Parameter 'width' is not assigned and could be declared final286
Parameter 'height' is not assigned and could be declared final295
Parameter 'minimumWidth' is not assigned and could be declared final304
Parameter 'minimumHeight' is not assigned and could be declared final313
Parameter 'preferredWidth' is not assigned and could be declared final322
Parameter 'preferredHeight' is not assigned and could be declared final331
Parameter 'maximumWidth' is not assigned and could be declared final340
Parameter 'maximumHeight' is not assigned and could be declared final349
Parameter 'marginLeft' is not assigned and could be declared final358
Parameter 'marginRight' is not assigned and could be declared final367
Parameter 'marginTop' is not assigned and could be declared final376
Parameter 'marginBottom' is not assigned and could be declared final385
Parameter 'borderLeft' is not assigned and could be declared final394
Parameter 'borderRight' is not assigned and could be declared final403
Parameter 'borderTop' is not assigned and could be declared final412
Parameter 'borderBottom' is not assigned and could be declared final421
Parameter 'paddingLeft' is not assigned and could be declared final430
Parameter 'paddingRight' is not assigned and could be declared final439
Parameter 'paddingTop' is not assigned and could be declared final448
Parameter 'paddingBottom' is not assigned and could be declared final457

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/LoadBundleTag.java

ViolationLine
Local variable 'facesContext' could be declared final59
Local variable 'toStore' could be declared final62
Assigning an Object to null is a code smell. Consider refactoring.72
Assigning an Object to null is a code smell. Consider refactoring.73
Parameter 'basename' is not assigned and could be declared final80
Parameter 'var' is not assigned and could be declared final90

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/PopupReferenceTag.java

ViolationLine
The class 'PopupReferenceTag' has a Cyclomatic Complexity of 4 (Highest = 6).44 - 94
The method 'doStartTag' has a Cyclomatic Complexity of 6.50 - 84
Local variable 'tag' could be declared final53 - 54
Local variable 'component' could be declared final64
Local variable 'actionSource' could be declared final73
Parameter 'forValue' is not assigned and could be declared final90

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/ResetInputActionListenerTag.java

ViolationLine
The class 'ResetInputActionListenerTag' has a Cyclomatic Complexity of 3 (Highest = 7).48 - 107
The method 'doStartTag' has a Cyclomatic Complexity of 7.54 - 90
Local variable 'tag' could be declared final57 - 58
Local variable 'component' could be declared final68
Local variable 'actionSource' could be declared final80
Assigning an Object to null is a code smell. Consider refactoring.95
Parameter 'execute' is not assigned and could be declared final103

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/SheetTagDeclaration.java

ViolationLine
The String literal "center" appears 4 times in this file; the first occurrence is on line 152152
The String literal "left" appears 4 times in this file; the first occurrence is on line 153153
The String literal "none" appears 4 times in this file; the first occurrence is on line 153153
The String literal "right" appears 4 times in this file; the first occurrence is on line 153153

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/SubmittedValueLengthValidatorTag.java

ViolationLine
The class 'SubmittedValueLengthValidatorTag' has a Cyclomatic Complexity of 3 (Highest = 5).43 - 84
The method 'createValidator' has a Cyclomatic Complexity of 5.50 - 72
Avoid empty catch blocks60 - 62
Avoid empty catch blocks60 - 62
Avoid empty catch blocks67 - 69
Avoid empty catch blocks67 - 69
Parameter 'minimum' is not assigned and could be declared final75
Parameter 'maximum' is not assigned and could be declared final80

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/TabChangeListenerTag.java

ViolationLine
The class 'TabChangeListenerTag' has a Cyclomatic Complexity of 5 (Highest = 14).45 - 146
The class 'TabChangeListenerTag' has a Cyclomatic Complexity of 5 (Highest = 14).45 - 146
Parameter 'type' is not assigned and could be declared final57
Parameter 'binding' is not assigned and could be declared final65
The method 'doStartTag' has a Cyclomatic Complexity of 14.78 - 130
The method doStartTag() has an NPath complexity of 96078 - 130
The method 'doStartTag' has a Cyclomatic Complexity of 14.78 - 130
Local variable 'tag' could be declared final81 - 82
Local variable 'component' could be declared final92
Local variable 'changeSource' could be declared final101
Local variable 'value' could be declared final107
Avoid if (x != y) ..; else ..;121 - 126
Parameter 'className' is not assigned and could be declared final138
Local variable 'clazz' could be declared final140

Tobago Core - org/apache/myfaces/tobago/internal/taglib/declaration/HasMargins.java

ViolationLine
The String literal "org.apache.myfaces.tobago.layout.Measure" appears 4 times in this file; the first occurrence is on line 3232
The String literal "getMargin() != null\n" appears 4 times in this file; the first occurrence is on line 3333
The String literal " ? getMargin()\n" appears 4 times in this file; the first occurrence is on line 3434

Tobago Core - org/apache/myfaces/tobago/internal/taglib/declaration/IsGridLayoutComponentBase.java

ViolationLine
The String literal "org.apache.myfaces.tobago.layout.Measure" appears 14 times in this file; the first occurrence is on line 3535
The String literal "java.lang.Integer" appears 4 times in this file; the first occurrence is on line 5151
The String literal "((LayoutComponentRenderer) " appears 9 times in this file; the first occurrence is on line 7272

Tobago Core - org/apache/myfaces/tobago/internal/taglib/declaration/IsGridLayoutContainer.java

ViolationLine
The String literal "org.apache.myfaces.tobago.layout.Measure" appears 8 times in this file; the first occurrence is on line 3232
The String literal "((org.apache.myfaces.tobago.renderkit.LayoutComponentRenderer)\n" appears 8 times in this file; the first occurrence is on line 3333

Tobago Core - org/apache/myfaces/tobago/internal/util/AccessKeyMap.java

ViolationLine
A class which only has private constructors should be final27 - 91
Private field 'set' could be made final; it is only initialized in the declaration or constructor.35
Avoid using implementation types like 'HashSet'; use the interface instead35
Avoid using implementation types like 'HashSet'; use the interface instead35
Parameter 'facesContext' is not assigned and could be declared final39
Avoid using implementation types like 'HashSet'; use the interface instead53
Avoid using implementation types like 'HashSet'; use the interface instead53
Parameter 'key' is not assigned and could be declared final61
Avoid reassigning parameters such as 'key'65
Parameter 'facesContext' is not assigned and could be declared final65
Parameter 'facesContext' is not assigned and could be declared final77
Parameter 'facesContext' is not assigned and could be declared final81
Local variable 'set' could be declared final82
Local variable 'sb' could be declared final83

Tobago Core - org/apache/myfaces/tobago/internal/util/ComponentAttributeUtils.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.30 - 68
Avoid unused private fields such as 'LOG'.32
Avoid unused private fields such as 'LOG'.32
Parameter 'component' is not assigned and could be declared final34
Parameter 'name' is not assigned and could be declared final34
Parameter 'value' is not assigned and could be declared final34
Parameter 'component' is not assigned and could be declared final44
Parameter 'name' is not assigned and could be declared final44
Parameter 'value' is not assigned and could be declared final44
Parameter 'value' is not assigned and could be declared final54
Local variable 'start' could be declared final56
Local variable 'end' could be declared final60
Parameter 'value' is not assigned and could be declared final64

Tobago Core - org/apache/myfaces/tobago/internal/util/ContentType.java

ViolationLine
Parameter 'contentType' is not assigned and could be declared final28
Parameter 'contentType' is not assigned and could be declared final32
Local variable 'values' could be declared final34
Parameter 'contentType' is not assigned and could be declared final51
Parameter 's' is not assigned and could be declared final60

Tobago Core - org/apache/myfaces/tobago/internal/util/DateFormatUtils.java

ViolationLine
A class which only has private constructors should be final33 - 109
The class 'DateFormatUtils' has a Cyclomatic Complexity of 4 (Highest = 6).33 - 109
Parameter 'converter' is not assigned and could be declared final54
Local variable 'dateFormat' could be declared final58 - 60
Local variable 'format' could be declared final62
Parameter 'dateStyle' is not assigned and could be declared final70
Parameter 'locale' is not assigned and could be declared final70
Parameter 'timeStyle' is not assigned and could be declared final70
Parameter 'type' is not assigned and could be declared final70
Parameter 'name' is not assigned and could be declared final89
The method 'calcStyle' has a Cyclomatic Complexity of 6.89 - 107

Tobago Core - org/apache/myfaces/tobago/internal/util/FacesContextUtils.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.34 - 278
This class has too many methods, consider refactoring it.34 - 278
Parameter 'context' is not assigned and could be declared final51
Parameter 'ajax' is not assigned and could be declared final55
Parameter 'context' is not assigned and could be declared final55
Parameter 'context' is not assigned and could be declared final59
Parameter 'focusId' is not assigned and could be declared final59
Parameter 'context' is not assigned and could be declared final63
Parameter 'context' is not assigned and could be declared final67
Parameter 'actionId' is not assigned and could be declared final67
Parameter 'context' is not assigned and could be declared final71
Parameter 'context' is not assigned and could be declared final76
Parameter 'context' is not assigned and could be declared final80
Parameter 'ajaxComponentId' is not assigned and could be declared final80
Parameter 'context' is not assigned and could be declared final84
Parameter 'enctype' is not assigned and could be declared final88
Parameter 'context' is not assigned and could be declared final88
Parameter 'context' is not assigned and could be declared final92
Local variable 'list' could be declared final93
Parameter 'file' is not assigned and could be declared final100
Parameter 'context' is not assigned and could be declared final100
Parameter 'context' is not assigned and could be declared final110
Local variable 'set' could be declared final111
Parameter 'context' is not assigned and could be declared final118
Parameter 'script' is not assigned and could be declared final118
Parameter 'context' is not assigned and could be declared final128
Local variable 'set' could be declared final129
Parameter 'context' is not assigned and could be declared final136
Parameter 'script' is not assigned and could be declared final136
Parameter 'context' is not assigned and could be declared final145
Local variable 'set' could be declared final146
Parameter 'context' is not assigned and could be declared final153
Parameter 'script' is not assigned and could be declared final153
Parameter 'context' is not assigned and could be declared final162
Local variable 'list' could be declared final163
Parameter 'file' is not assigned and could be declared final171
Parameter 'context' is not assigned and could be declared final171
Parameter 'position' is not assigned and could be declared final180
Parameter 'file' is not assigned and could be declared final180
Parameter 'context' is not assigned and could be declared final180
Parameter 'context' is not assigned and could be declared final189
Local variable 'set' could be declared final190
Parameter 'context' is not assigned and could be declared final197
Parameter 'script' is not assigned and could be declared final197
Parameter 'context' is not assigned and could be declared final206
Local variable 'set' could be declared final207
Parameter 'context' is not assigned and could be declared final214
Parameter 'script' is not assigned and could be declared final214
Parameter 'context' is not assigned and could be declared final223
Local variable 'set' could be declared final224
Parameter 'context' is not assigned and could be declared final231
Parameter 'script' is not assigned and could be declared final231
Parameter 'context' is not assigned and could be declared final240
Local variable 'set' could be declared final241
Parameter 'context' is not assigned and could be declared final245
Local variable 'set' could be declared final246
Parameter 'context' is not assigned and could be declared final253
Parameter 'script' is not assigned and could be declared final253
Parameter 'context' is not assigned and could be declared final262
Local variable 'set' could be declared final263
Parameter 'popup' is not assigned and could be declared final270
Parameter 'context' is not assigned and could be declared final270

Tobago Core - org/apache/myfaces/tobago/internal/util/FastStringWriter.java

ViolationLine
Parameter 'initialSize' is not assigned and could be declared final33
Parameter 'c' is not assigned and could be declared final37
Parameter 'cbuf' is not assigned and could be declared final41
Parameter 'off' is not assigned and could be declared final41
Parameter 'len' is not assigned and could be declared final41
Parameter 'str' is not assigned and could be declared final45
Parameter 'str' is not assigned and could be declared final49
Parameter 'off' is not assigned and could be declared final49
Parameter 'len' is not assigned and could be declared final49

Tobago Core - org/apache/myfaces/tobago/internal/util/FindComponentUtils.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.26 - 62
The class 'FindComponentUtils' has a Cyclomatic Complexity of 11 (Highest = 10).26 - 62
The class 'FindComponentUtils' has a Cyclomatic Complexity of 11 (Highest = 10).26 - 62
Avoid reassigning parameters such as 'relativeId'28
Avoid reassigning parameters such as 'from'28
The method 'findComponent' has a Cyclomatic Complexity of 10.28 - 61
The method 'findComponent' has a Cyclomatic Complexity of 10.28 - 61
Local variable 'idLength' could be declared final29
These nested if statements could be combined31 - 33
Position literals first in String comparisons31
These nested if statements could be combined31 - 33

Tobago Core - org/apache/myfaces/tobago/internal/util/HtmlWriterUtils.java

ViolationLine
The class 'HtmlWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14).25 - 122
The class 'HtmlWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14).25 - 122
The method 'writeEncodedValue' has a Cyclomatic Complexity of 14.60 - 121
The method 'writeEncodedValue' has a Cyclomatic Complexity of 14.60 - 121
Local variable 'ch' could be declared final67
Avoid if (x != y) ..; else ..;93 - 97
Local variable 'chars' could be declared final105

Tobago Core - org/apache/myfaces/tobago/internal/util/JavascriptWriterUtils.java

ViolationLine
The class 'JavascriptWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14).25 - 120
The class 'JavascriptWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14).25 - 120
The method 'writeEncodedValue' has a Cyclomatic Complexity of 14.58 - 119
The method 'writeEncodedValue' has a Cyclomatic Complexity of 14.58 - 119
Local variable 'ch' could be declared final65
Avoid if (x != y) ..; else ..;91 - 95
Local variable 'chars' could be declared final103

Tobago Core - org/apache/myfaces/tobago/internal/util/JndiUtils.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.30 - 74
The class 'JndiUtils' has a Cyclomatic Complexity of 4 (Highest = 5).30 - 74
Parameter 'ctx' is not assigned and could be declared final34
Parameter 'path' is not assigned and could be declared final34
Parameter 'ctx' is not assigned and could be declared final38
Parameter 'path' is not assigned and could be declared final38
Parameter 'defaultValue' is not assigned and could be declared final38
The method 'getJndiProperty' has a Cyclomatic Complexity of 5.38 - 57
Local variable 'b' could be declared final42
Local variable 'obj' could be declared final47
Prefer StringBuffer over += for concatenating strings53
Parameter 'name' is not assigned and could be declared final59
Parameter 'ctx' is not assigned and could be declared final59
Parameter 'path' is not assigned and could be declared final59
Local variable 'ne' could be declared final61
Local variable 'b' could be declared final63

Tobago Core - org/apache/myfaces/tobago/internal/util/JsonWriterUtils.java

ViolationLine
The class 'JsonWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14).26 - 124
The class 'JsonWriterUtils' has a Cyclomatic Complexity of 9 (Highest = 14).26 - 124
The method 'writeEncodedValue' has a Cyclomatic Complexity of 14.62 - 123
The method 'writeEncodedValue' has a Cyclomatic Complexity of 14.62 - 123
Local variable 'ch' could be declared final69
Avoid if (x != y) ..; else ..;95 - 99
Local variable 'chars' could be declared final107

Tobago Core - org/apache/myfaces/tobago/internal/util/MimeTypeUtils.java

ViolationLine
A class which only has private constructors should be final22 - 47
The class 'MimeTypeUtils' has a Cyclomatic Complexity of 6 (Highest = 9).22 - 47
Parameter 'file' is not assigned and could be declared final29
The method 'getMimeTypeForFile' has a Cyclomatic Complexity of 9.29 - 46

Tobago Core - org/apache/myfaces/tobago/internal/util/ResponseUtils.java

ViolationLine
A class which only has private constructors should be final32 - 99
The class 'ResponseUtils' has a Cyclomatic Complexity of 3 (Highest = 5).32 - 99
Parameter 'facesContext' is not assigned and could be declared final40
Local variable 'externalContext' could be declared final42
Local variable 'response' could be declared final44
Parameter 'response' is not assigned and could be declared final49
Parameter 'facesContext' is not assigned and could be declared final56
Parameter 'contentType' is not assigned and could be declared final56
Local variable 'response' could be declared final59
Parameter 'response' is not assigned and could be declared final64
Parameter 'contentType' is not assigned and could be declared final64
The method 'ensureContentTypeHeader' has a Cyclomatic Complexity of 5.64 - 81
Avoid if (x != y) ..; else ..;65 - 80
Local variable 'responseContentType' could be declared final69
Parameter 'contentSecurityPolicy' is not assigned and could be declared final83
Parameter 'facesContext' is not assigned and could be declared final83

Tobago Core - org/apache/myfaces/tobago/internal/util/StringUtils.java

ViolationLine
The class 'StringUtils' has a Cyclomatic Complexity of 3 (Highest = 7).27 - 104
Parameter 'integerList' is not assigned and could be declared final33
Parameter 'delimiters' is not assigned and could be declared final37
Parameter 'integerList' is not assigned and could be declared final37
Local variable 'list' could be declared final38
Local variable 'tokenizer' could be declared final40
Local variable 'token' could be declared final42
Avoid instantiating new objects inside loops44
Avoid instantiating Integer objects. Call Integer.valueOf() instead.44
Parameter 'list' is not assigned and could be declared final51
Local variable 'buffer' could be declared final52
Parameter 'list' is not assigned and could be declared final60
The method 'getIndices' has a Cyclomatic Complexity of 7.60 - 88
Local variable 'indexList' could be declared final61
Local variable 'st' could be declared final62
Local variable 'token' could be declared final64
Local variable 'idx' could be declared final65
Local variable 'start' could be declared final69
Local variable 'end' could be declared final70
Parameter 'constant' is not assigned and could be declared final90

Tobago Core - org/apache/myfaces/tobago/internal/webapp/DebugContentTypeFilter.java

ViolationLine
Parameter 'filterConfig' is not assigned and could be declared final37
Parameter 'response' is not assigned and could be declared final43
Parameter 'chain' is not assigned and could be declared final43
Parameter 'request' is not assigned and could be declared final43
Document empty method58 - 60

Tobago Core - org/apache/myfaces/tobago/internal/webapp/DebugContentTypeResponse.java

ViolationLine
Parameter 'response' is not assigned and could be declared final31
Parameter 'type' is not assigned and could be declared final36
Local variable 'type' could be declared final45
Parameter 'name' is not assigned and could be declared final53
Parameter 'value' is not assigned and could be declared final53
These nested if statements could be combined55 - 57
These nested if statements could be combined55 - 57
Parameter 'name' is not assigned and could be declared final63
Parameter 'value' is not assigned and could be declared final63
These nested if statements could be combined65 - 67
These nested if statements could be combined65 - 67

Tobago Core - org/apache/myfaces/tobago/internal/webapp/DebugResponseWriterWrapper.java

ViolationLine
This class has too many methods, consider refactoring it.37 - 176
Private field 'stack' could be made final; it is only initialized in the declaration or constructor.39
Parameter 'responseWriter' is not assigned and could be declared final45
Parameter 'string' is not assigned and could be declared final49
Parameter 'comment' is not assigned and could be declared final53
Parameter 'writer' is not assigned and could be declared final64
Parameter 'name' is not assigned and could be declared final69
Parameter 'value' is not assigned and could be declared final69
Parameter 'property' is not assigned and could be declared final69
Parameter 'text' is not assigned and could be declared final74
Parameter 'property' is not assigned and could be declared final74
Parameter 'name' is not assigned and could be declared final82
Parameter 'value' is not assigned and could be declared final82
Parameter 'escape' is not assigned and could be declared final82
Parameter 'script' is not assigned and could be declared final118
Parameter 'name' is not assigned and could be declared final132
Parameter 'value' is not assigned and could be declared final132
Parameter 'property' is not assigned and could be declared final132
Parameter 'text' is not assigned and could be declared final136
Parameter 'off' is not assigned and could be declared final136
Parameter 'len' is not assigned and could be declared final136
Parameter 'chars' is not assigned and could be declared final140
Parameter 'i' is not assigned and could be declared final140
Parameter 'i1' is not assigned and could be declared final140
Parameter 'name' is not assigned and could be declared final149
Parameter 'currentComponent' is not assigned and could be declared final149
Parameter 'name' is not assigned and could be declared final159

Tobago Core - org/apache/myfaces/tobago/internal/webapp/HtmlResponseWriter.java

ViolationLine
This class has too many methods, consider refactoring it.39 - 171
Private field 'javascriptWriter' could be made final; it is only initialized in the declaration or constructor.45
Parameter 'contentType' is not assigned and could be declared final49
Parameter 'writer' is not assigned and could be declared final49
Parameter 'characterEncoding' is not assigned and could be declared final49
Parameter 'string' is not assigned and could be declared final70
Parameter 'script' is not assigned and could be declared final79
Avoid empty if statements107 - 109
Avoid empty if statements107 - 109
Parameter 'value' is not assigned and could be declared final120
Parameter 'escape' is not assigned and could be declared final120
Avoid reassigning parameters such as 'styles'137
Parameter 'component' is not assigned and could be declared final137
Parameter 'name' is not assigned and could be declared final153
Local variable 'javascript' could be declared final155

Tobago Core - org/apache/myfaces/tobago/internal/webapp/JsonResponseWriter.java

ViolationLine
This class has too many methods, consider refactoring it.34 - 186
Private field 'javascriptWriter' could be made final; it is only initialized in the declaration or constructor.38
Private field 'encodeInJavascriptBlock' could be made final; it is only initialized in the declaration or constructor.40
Private field 'encodeOutsideJavascriptBlock' could be made final; it is only initialized in the declaration or constructor.41
Parameter 'contentType' is not assigned and could be declared final43
Parameter 'writer' is not assigned and could be declared final43
Parameter 'characterEncoding' is not assigned and could be declared final43
Parameter 'string' is not assigned and could be declared final61
Parameter 'chars' is not assigned and could be declared final71
Local variable 'stackTraceElements' could be declared final77
Parameter 'script' is not assigned and could be declared final87
Parameter 'name' is not assigned and could be declared final97
Parameter 'writer' is not assigned and could be declared final97
Parameter 'currentComponent' is not assigned and could be declared final97
Parameter 'name' is not assigned and could be declared final109
Parameter 'writer' is not assigned and could be declared final109
Parameter 'name' is not assigned and could be declared final132
Parameter 'value' is not assigned and could be declared final132
Parameter 'writer' is not assigned and could be declared final132
Parameter 'escape' is not assigned and could be declared final132
Local variable 'trace' could be declared final135
Local variable 'error' could be declared final136 - 139
Local variable 'value' could be declared final161
Document empty method180 - 181
Document empty method184 - 185

Tobago Core - org/apache/myfaces/tobago/internal/webapp/TobagoMultipartFormdataRequest.java

ViolationLine
The class 'TobagoMultipartFormdataRequest' has a Cyclomatic Complexity of 3 (Highest = 13).43 - 199
The class 'TobagoMultipartFormdataRequest' has a Cyclomatic Complexity of 3 (Highest = 13).43 - 199
Parameter 'request' is not assigned and could be declared final55
Parameter 'request' is not assigned and could be declared final59
Parameter 'repositoryPath' is not assigned and could be declared final59
Parameter 'maxSize' is not assigned and could be declared final59
Parameter 'request' is not assigned and could be declared final64
Parameter 'repositoryPath' is not assigned and could be declared final64
Parameter 'maxSize' is not assigned and could be declared final64
The method 'init' has a Cyclomatic Complexity of 13.64 - 133
The method init() has an NPath complexity of 40164 - 133
The method 'init' has a Cyclomatic Complexity of 13.64 - 133
Avoid if (x != y) ..; else ..;65 - 132
Local variable 'errorText' could be declared final66
Local variable 'factory' could be declared final72
Local variable 'upload' could be declared final76
Local variable 'key' could be declared final95
Local variable 'e' could be declared final121
Parameter 'newValue' is not assigned and could be declared final135
Parameter 'key' is not assigned and could be declared final135
Parameter 'key' is not assigned and could be declared final148
Parameter 'key' is not assigned and could be declared final155
Local variable 'values' could be declared final157
Parameter 'key' is not assigned and could be declared final168
Parameter 'param' is not assigned and could be declared final176
The method 'getMaxSize' has a Cyclomatic Complexity of 6.176 - 198

Tobago Core - org/apache/myfaces/tobago/internal/webapp/TobagoResponseWriterBase.java

ViolationLine
The class 'TobagoResponseWriterBase' has a Cyclomatic Complexity of 2 (Highest = 7).38 - 331
This class has too many methods, consider refactoring it.38 - 331
Parameter 'contentType' is not assigned and could be declared final74
Parameter 'writer' is not assigned and could be declared final74
Parameter 'characterEncoding' is not assigned and could be declared final74
Avoid if (x != y) ..; else ..;77
Parameter 'component' is not assigned and could be declared final88
Parameter 'startStillOpen' is not assigned and could be declared final96
The method 'findValue' has a Cyclomatic Complexity of 7.100 - 129
Avoid if (x != y) ..; else ..;101 - 128
Avoid if (x != y) ..; else ..;103 - 128
Avoid if (x != y) ..; else ..;104 - 119
Avoid if (x != y) ..; else ..;106 - 110
Parameter 'string' is not assigned and could be declared final137
Parameter 'string' is not assigned and could be declared final141
Parameter 'writer' is not assigned and could be declared final141
Parameter 'i' is not assigned and could be declared final147
Parameter 'chars' is not assigned and could be declared final153
Parameter 'string' is not assigned and could be declared final159
Parameter 'i' is not assigned and could be declared final159
Parameter 'i1' is not assigned and could be declared final159
An empty method in an abstract class should be abstract instead191 - 193
An empty method in an abstract class should be abstract instead195 - 197
Parameter 'name' is not assigned and could be declared final212
Parameter 'writer' is not assigned and could be declared final212
Parameter 'currentComponent' is not assigned and could be declared final212
Local variable 'comment' could be declared final230
Local variable 'clazz' could be declared final272
Local variable 'clazz' could be declared final285
Parameter 'name' is not assigned and could be declared final292
Parameter 'writer' is not assigned and could be declared final292
Parameter 'name' is not assigned and could be declared final308
Parameter 'value' is not assigned and could be declared final308
Parameter 'writer' is not assigned and could be declared final308
Parameter 'escape' is not assigned and could be declared final308
Local variable 'trace' could be declared final311
Local variable 'error' could be declared final312 - 315

Tobago Core - org/apache/myfaces/tobago/internal/webapp/TobagoResponseWriterWrapper.java

ViolationLine
This class has too many methods, consider refactoring it.32 - 125
Private field 'responseWriter' could be made final; it is only initialized in the declaration or constructor.34
Parameter 'responseWriter' is not assigned and could be declared final36
Parameter 'component' is not assigned and could be declared final40
Parameter 'name' is not assigned and could be declared final40
Parameter 'name' is not assigned and could be declared final44
Parameter 'string' is not assigned and could be declared final49
Parameter 'comment' is not assigned and could be declared final53
Parameter 'writer' is not assigned and could be declared final57
Parameter 'name' is not assigned and could be declared final62
Parameter 'value' is not assigned and could be declared final62
Parameter 'property' is not assigned and could be declared final62
Parameter 'text' is not assigned and could be declared final67
Parameter 'property' is not assigned and could be declared final67
Parameter 'name' is not assigned and could be declared final75
Parameter 'value' is not assigned and could be declared final75
Parameter 'escape' is not assigned and could be declared final75
Parameter 'name' is not assigned and could be declared final110
Parameter 'value' is not assigned and could be declared final110
Parameter 'property' is not assigned and could be declared final110
Parameter 'text' is not assigned and could be declared final114
Parameter 'off' is not assigned and could be declared final114
Parameter 'len' is not assigned and could be declared final114
Parameter 'chars' is not assigned and could be declared final118
Parameter 'i' is not assigned and could be declared final118
Parameter 'i1' is not assigned and could be declared final118

Tobago Core - org/apache/myfaces/tobago/internal/webapp/XmlResponseWriter.java

ViolationLine
Parameter 'contentType' is not assigned and could be declared final38
Parameter 'writer' is not assigned and could be declared final38
Parameter 'characterEncoding' is not assigned and could be declared final38
Avoid empty if statements58 - 60
Avoid empty if statements58 - 60
Parameter 'value' is not assigned and could be declared final76
Parameter 'escape' is not assigned and could be declared final76

Tobago Core - org/apache/myfaces/tobago/layout/Box.java

ViolationLine
Parameter 'position' is not assigned and could be declared final27
Parameter 'dimension' is not assigned and could be declared final27
Parameter 'string' is not assigned and could be declared final32
Parameter 'left' is not assigned and could be declared final63
Parameter 'top' is not assigned and could be declared final71
Parameter 'width' is not assigned and could be declared final79
Parameter 'height' is not assigned and could be declared final87

Tobago Core - org/apache/myfaces/tobago/layout/Dimension.java

ViolationLine
Parameter 'height' is not assigned and could be declared final27
Parameter 'width' is not assigned and could be declared final27
Parameter 'string' is not assigned and could be declared final32
Local variable 'comma' could be declared final33
Parameter 'width' is not assigned and could be declared final46
Parameter 'height' is not assigned and could be declared final54

Tobago Core - org/apache/myfaces/tobago/layout/Display.java

ViolationLine
Parameter 'value' is not assigned and could be declared final30

Tobago Core - org/apache/myfaces/tobago/layout/LayoutTokens.java

ViolationLine
The class 'LayoutTokens' has a Cyclomatic Complexity of 2 (Highest = 10).31 - 171
This class has too many methods, consider refactoring it.31 - 171
The class 'LayoutTokens' has a Cyclomatic Complexity of 2 (Highest = 10).31 - 171
Private field 'tokens' could be made final; it is only initialized in the declaration or constructor.35
Document empty constructor37 - 38
Avoid unnecessary constructors - the compiler will generate these for you37 - 38
Parameter 'index' is not assigned and could be declared final44
Parameter 'token' is not assigned and could be declared final44
Parameter 'index' is not assigned and could be declared final52
Parameter 'size' is not assigned and could be declared final56
Parameter 'token' is not assigned and could be declared final62
Parameter 'size' is not assigned and could be declared final62
Parameter 'token' is not assigned and could be declared final68
Parameter 'tokens' is not assigned and could be declared final80
Local variable 'layoutTokens' could be declared final81
Parameter 'tokens' is not assigned and could be declared final88
Parameter 'defaultToken' is not assigned and could be declared final92
Parameter 'tokens' is not assigned and could be declared final92
Local variable 'layoutTokens' could be declared final93
Local variable 'tokenizer' could be declared final98
Local variable 'token' could be declared final101
Parameter 'layoutTokens' is not assigned and could be declared final107
Parameter 'token' is not assigned and could be declared final107
Local variable 'layoutToken' could be declared final108
Parameter 'token' is not assigned and could be declared final114
The method 'parseToken' has a Cyclomatic Complexity of 10.114 - 139
The method 'parseToken' has a Cyclomatic Complexity of 10.114 - 139
Parameter 'token' is not assigned and could be declared final141
Parameter 'token' is not assigned and could be declared final145
Parameter 'token' is not assigned and could be declared final149
Parameter 'token' is not assigned and could be declared final153
Parameter 'suffix' is not assigned and could be declared final153
Parameter 'token' is not assigned and could be declared final158
Parameter 'suffix' is not assigned and could be declared final158
Local variable 'str' could be declared final163

Tobago Core - org/apache/myfaces/tobago/layout/Measure.java

ViolationLine
The class 'Measure' has a Cyclomatic Complexity of 2 (Highest = 5).29 - 193
This class has too many methods, consider refactoring it.29 - 193
Avoid unused private fields such as 'LOG'.33
Avoid unused private fields such as 'LOG'.33
Parameter 'value' is not assigned and could be declared final40
Parameter 'value' is not assigned and could be declared final47
Parameter 'value' is not assigned and could be declared final51
Parameter 'value' is not assigned and could be declared final58
Parameter 'value' is not assigned and could be declared final65
Parameter 'object' is not assigned and could be declared final80
The method 'valueOf' has a Cyclomatic Complexity of 5.80 - 94
Parameter 'value' is not assigned and could be declared final100
Parameter 'm' is not assigned and could be declared final116
Parameter 'measure' is not assigned and could be declared final126
Parameter 'measure' is not assigned and could be declared final130
Parameter 'measure' is not assigned and could be declared final134
Parameter 'measure' is not assigned and could be declared final138
Parameter 'list' is not assigned and could be declared final149
Parameter 'list' is not assigned and could be declared final162
Parameter 'm1' is not assigned and could be declared final175
Parameter 'm2' is not assigned and could be declared final175
Avoid if (x != y) ..; else ..;176 - 180
Avoid if (x != y) ..; else ..;179
Parameter 'm1' is not assigned and could be declared final186
Parameter 'm2' is not assigned and could be declared final186
Avoid if (x != y) ..; else ..;187 - 191
Avoid if (x != y) ..; else ..;190

Tobago Core - org/apache/myfaces/tobago/layout/MeasureEditor.java

ViolationLine
Parameter 'text' is not assigned and could be declared final27

Tobago Core - org/apache/myfaces/tobago/layout/PercentLayoutToken.java

ViolationLine
The class 'PercentLayoutToken' has a Cyclomatic Complexity of 2 (Highest = 5).22 - 60
Private field 'percent' could be made final; it is only initialized in the declaration or constructor.26
Parameter 'percent' is not assigned and could be declared final28
Parameter 'o' is not assigned and could be declared final40
The method 'equals' has a Cyclomatic Complexity of 5.40 - 55
Local variable 'that' could be declared final48

Tobago Core - org/apache/myfaces/tobago/layout/PixelLayoutToken.java

ViolationLine
The class 'PixelLayoutToken' has a Cyclomatic Complexity of 2 (Highest = 5).23 - 61
Private field 'pixel' could be made final; it is only initialized in the declaration or constructor.27
Parameter 'pixel' is not assigned and could be declared final29
Parameter 'o' is not assigned and could be declared final41
The method 'equals' has a Cyclomatic Complexity of 5.41 - 56
Local variable 'that' could be declared final49

Tobago Core - org/apache/myfaces/tobago/layout/PixelMeasure.java

ViolationLine
The class 'PixelMeasure' has a Cyclomatic Complexity of 2 (Highest = 5).25 - 131
This class has too many methods, consider refactoring it.25 - 131
Avoid instantiating new objects inside loops35
Parameter 'pixel' is not assigned and could be declared final41
Parameter 'value' is not assigned and could be declared final45
Parameter 'm' is not assigned and could be declared final52
Parameter 'm' is not assigned and could be declared final60
Parameter 'times' is not assigned and could be declared final64
Parameter 'times' is not assigned and could be declared final68
Parameter 'm' is not assigned and could be declared final72
Parameter 'm' is not assigned and could be declared final83
Parameter 'm' is not assigned and could be declared final91
Parameter 'o' is not assigned and could be declared final110
The method 'equals' has a Cyclomatic Complexity of 5.110 - 125
Local variable 'that' could be declared final118

Tobago Core - org/apache/myfaces/tobago/layout/Position.java

ViolationLine
Parameter 'left' is not assigned and could be declared final27
Parameter 'top' is not assigned and could be declared final27
Parameter 'string' is not assigned and could be declared final32
Local variable 'comma' could be declared final33
Parameter 'left' is not assigned and could be declared final46
Parameter 'top' is not assigned and could be declared final54

Tobago Core - org/apache/myfaces/tobago/layout/RelativeLayoutToken.java

ViolationLine
The class 'RelativeLayoutToken' has a Cyclomatic Complexity of 2 (Highest = 5).22 - 63
Private field 'factor' could be made final; it is only initialized in the declaration or constructor.29
Parameter 'factor' is not assigned and could be declared final31
Parameter 'o' is not assigned and could be declared final43
The method 'equals' has a Cyclomatic Complexity of 5.43 - 58
Local variable 'that' could be declared final51

Tobago Core - org/apache/myfaces/tobago/layout/TextAlign.java

ViolationLine
Parameter 'value' is not assigned and could be declared final41
Parameter 'string' is not assigned and could be declared final59
Local variable 'value' could be declared final63
Avoid if (x != y) ..; else ..;64 - 68

Tobago Core - org/apache/myfaces/tobago/model/AutoSuggestExtensionItem.java

ViolationLine
Parameter 'id' is not assigned and could be declared final31
Parameter 'value' is not assigned and could be declared final39

Tobago Core - org/apache/myfaces/tobago/model/AutoSuggestItem.java

ViolationLine
Parameter 'label' is not assigned and could be declared final36
Parameter 'nextFocusId' is not assigned and could be declared final44
Parameter 'extensionItems' is not assigned and could be declared final52

Tobago Core - org/apache/myfaces/tobago/model/AutoSuggestItems.java

ViolationLine
Parameter 'items' is not assigned and could be declared final37
Parameter 'nextFocusId' is not assigned and could be declared final45
Parameter 'maxSuggestedCount' is not assigned and could be declared final53

Tobago Core - org/apache/myfaces/tobago/model/CalendarModel.java

ViolationLine
Private field 'calendarArray' could be made final; it is only initialized in the declaration or constructor.28
Private field 'firstDayOffset' could be made final; it is only initialized in the declaration or constructor.29
Parameter 'calendar' is not assigned and could be declared final31
Local variable 'weekCount' could be declared final33
Local variable 'c' could be declared final35
Avoid instantiating new objects inside loops43
Parameter 'day' is not assigned and could be declared final61
Parameter 'week' is not assigned and could be declared final61
Parameter 'calendar' is not assigned and could be declared final65
Local variable 'c' could be declared final66
Local variable 'day' could be declared final69
Local variable 'firstDayOfWeek' could be declared final70
Local variable 'buffer' could be declared final76
Local variable 'weekCount' could be declared final78
Local variable 'format' could be declared final79
When instantiating a SimpleDateFormat object, specify a Locale80
Local variable 'dateFormat' could be declared final80
Local variable 'date' could be declared final82
Local variable 'dayName' could be declared final83
Local variable 'date' could be declared final89

Tobago Core - org/apache/myfaces/tobago/model/DateModel.java

ViolationLine
Parameter 'month' is not assigned and could be declared final31
Parameter 'year' is not assigned and could be declared final31
Parameter 'day' is not assigned and could be declared final31
Parameter 'calendar' is not assigned and could be declared final37
Parameter 'year' is not assigned and could be declared final47
Parameter 'month' is not assigned and could be declared final55
Parameter 'day' is not assigned and could be declared final63
Parameter 'locale' is not assigned and could be declared final71
Avoid if (x != y) ..; else ..;72 - 73
Local variable 'calendar' could be declared final72 - 73

Tobago Core - org/apache/myfaces/tobago/model/ExpandedState.java

ViolationLine
The class 'ExpandedState' has a Cyclomatic Complexity of 2 (Highest = 6).34 - 228
This class has too many methods, consider refactoring it.34 - 228
Private field 'expandedSet' could be made final; it is only initialized in the declaration or constructor.37
Private field 'collapsedSet' could be made final; it is only initialized in the declaration or constructor.38
Parameter 'defaultExpandedLevels' is not assigned and could be declared final45
Parameter 'node' is not assigned and could be declared final57
Parameter 'path' is not assigned and could be declared final68
Parameter 'node' is not assigned and could be declared final83
Parameter 'path' is not assigned and could be declared final93
Parameter 'level' is not assigned and could be declared final106
The method 'expand' has a Cyclomatic Complexity of 6.106 - 125
Local variable 'toRemove' could be declared final107
Parameter 'node' is not assigned and could be declared final141
Parameter 'path' is not assigned and could be declared final151
Avoid reassigning parameters such as 'level'164
The method 'collapse' has a Cyclomatic Complexity of 6.164 - 186
Local variable 'toRemove' could be declared final168

Tobago Core - org/apache/myfaces/tobago/model/MarkedState.java

ViolationLine
Parameter 'path' is not assigned and could be declared final29
Avoid if (x != y) ..; else ..;30 - 34
Use equals() to compare object references.33
Parameter 'marked' is not assigned and could be declared final41
Parameter 'marked' is not assigned and could be declared final45
Assigning an Object to null is a code smell. Consider refactoring.53

Tobago Core - org/apache/myfaces/tobago/model/MixedTreeModel.java

ViolationLine
The class 'MixedTreeModel' has a Cyclomatic Complexity of 2 (Highest = 6).33 - 98
Private field 'junctions' could be made final; it is only initialized in the declaration or constructor.39
Local variable 'newNode' could be declared final42
The method 'onEncodeBegin' has a Cyclomatic Complexity of 6.56 - 82
Local variable 'nextSibling' could be declared final71
Assigning an Object to null is a code smell. Consider refactoring.79
Local variable 'top' could be declared final89
Local variable 'result' could be declared final90

Tobago Core - org/apache/myfaces/tobago/model/Node.java

ViolationLine
Parameter 'node' is not assigned and could be declared final36
Parameter 'index' is not assigned and could be declared final53
Parameter 'node' is not assigned and could be declared final62
Local variable 'child' could be declared final64
Assigning an Object to null is a code smell. Consider refactoring.85
Local variable 'result' could be declared final89
Local variable 'index' could be declared final93
Parameter 'parent' is not assigned and could be declared final107

Tobago Core - org/apache/myfaces/tobago/model/PageStateImpl.java

ViolationLine
Parameter 'clientWidth' is not assigned and could be declared final36
Parameter 'clientHeight' is not assigned and could be declared final44

Tobago Core - org/apache/myfaces/tobago/model/SelectItem.java

ViolationLine
Parameter 'value' is not assigned and could be declared final37
Parameter 'value' is not assigned and could be declared final41
Parameter 'label' is not assigned and could be declared final41
Parameter 'description' is not assigned and could be declared final45
Parameter 'value' is not assigned and could be declared final45
Parameter 'label' is not assigned and could be declared final45
Parameter 'description' is not assigned and could be declared final49
Parameter 'value' is not assigned and could be declared final49
Parameter 'image' is not assigned and could be declared final49
Parameter 'label' is not assigned and could be declared final49
Parameter 'markup' is not assigned and could be declared final55
Parameter 'description' is not assigned and could be declared final55
Parameter 'value' is not assigned and could be declared final55
Parameter 'image' is not assigned and could be declared final55
Parameter 'label' is not assigned and could be declared final55
Parameter 'markup' is not assigned and could be declared final59
Parameter 'description' is not assigned and could be declared final59
Parameter 'value' is not assigned and could be declared final59
Parameter 'image' is not assigned and could be declared final59
Parameter 'label' is not assigned and could be declared final59
Parameter 'description' is not assigned and could be declared final63
Parameter 'value' is not assigned and could be declared final63
Parameter 'image' is not assigned and could be declared final63
Parameter 'label' is not assigned and could be declared final63
Parameter 'disabled' is not assigned and could be declared final63
Parameter 'markup' is not assigned and could be declared final68
Parameter 'description' is not assigned and could be declared final68
Parameter 'value' is not assigned and could be declared final68
Parameter 'image' is not assigned and could be declared final68
Parameter 'label' is not assigned and could be declared final68
Parameter 'disabled' is not assigned and could be declared final68
Parameter 'markup' is not assigned and could be declared final72
Parameter 'description' is not assigned and could be declared final72
Parameter 'value' is not assigned and could be declared final72
Parameter 'image' is not assigned and could be declared final72
Parameter 'label' is not assigned and could be declared final72
Parameter 'disabled' is not assigned and could be declared final72
Parameter 'image' is not assigned and could be declared final82
Parameter 'markup' is not assigned and could be declared final90
Parameter 'currentMarkup' is not assigned and could be declared final98

Tobago Core - org/apache/myfaces/tobago/model/Selectable.java

ViolationLine
Parameter 'value' is not assigned and could be declared final98
Parameter 'name' is not assigned and could be declared final119
Local variable 'value' could be declared final126
Avoid if (x != y) ..; else ..;127 - 131

Tobago Core - org/apache/myfaces/tobago/model/SheetState.java

ViolationLine
Overridable method 'resetSelected' called during object construction49
Parameter 'selectedRows' is not assigned and could be declared final60
Parameter 'sortedColumnId' is not assigned and could be declared final69
Parameter 'ascending' is not assigned and could be declared final77
Parameter 'columnWidths' is not assigned and could be declared final85
Parameter 'first' is not assigned and could be declared final93
Parameter 'sortEvent' is not assigned and could be declared final97
Local variable 'actualColumn' could be declared final99
Parameter 'scrollPosition' is not assigned and could be declared final113
Parameter 'expandedState' is not assigned and could be declared final124
Parameter 'value' is not assigned and could be declared final128
Local variable 'sep' could be declared final131
String.indexOf(char) is faster than String.indexOf(String).131
Do not add empty strings133
Local variable 'left' could be declared final138
Local variable 'top' could be declared final139

Tobago Core - org/apache/myfaces/tobago/model/TreeNodeDataModel.java

ViolationLine
The class 'TreeNodeDataModel' has a Cyclomatic Complexity of 2 (Highest = 7).36 - 291
Private field 'mapping' could be made final; it is only initialized in the declaration or constructor.42
Private field 'back' could be made final; it is only initialized in the declaration or constructor.43
Private field 'showRoot' could be made final; it is only initialized in the declaration or constructor.44
Parameter 'expandedState' is not assigned and could be declared final52
Parameter 'showRoot' is not assigned and could be declared final52
Parameter 'data' is not assigned and could be declared final52
Overridable method 'reset' called during object construction58
Avoid instantiation through private constructors from outside of the constructor's class.68
Avoid instantiating new objects inside loops68
Parameter 'expandedState' is not assigned and could be declared final81
The method 'update' has a Cyclomatic Complexity of 5.81 - 100
Avoid instantiation through private constructors from outside of the constructor's class.88
Avoid instantiating new objects inside loops88
Avoid reassigning parameters such as 'node'102
Parameter 'node' is not assigned and could be declared final118
Local variable 'parent' could be declared final119
Parameter 'rowIndex' is not assigned and could be declared final175
Parameter 'data' is not assigned and could be declared final180
The method 'isRowVisible' has a Cyclomatic Complexity of 7.185 - 205
Avoid instantiating new objects inside loops199
Parameter 'clientId' is not assigned and could be declared final215
Avoid if (x != y) ..; else ..;226 - 230
Parameter 'node' is not assigned and could be declared final261
Private field 'node' could be made final; it is only initialized in the declaration or constructor.272
Parameter 'node' is not assigned and could be declared final275
Parameter 'clientId' is not assigned and could be declared final287

Tobago Core - org/apache/myfaces/tobago/model/TreePath.java

ViolationLine
The class 'TreePath' has a Cyclomatic Complexity of 2 (Highest = 6).57 - 192
Parameter 'path' is not assigned and could be declared final61
Parameter 'pathList' is not assigned and could be declared final65
Parameter 'position' is not assigned and could be declared final76
Parameter 'addendum' is not assigned and could be declared final76
Parameter 'string' is not assigned and could be declared final86
Avoid reassigning parameters such as 'node'90
The constructor 'TreePath' has a Cyclomatic Complexity of 6.90 - 113
Local variable 'parent' could be declared final104
Local variable 'child' could be declared final105
Local variable 'builder' could be declared final127
Local variable 'builder' could be declared final140
Avoid reassigning parameters such as 'tree'156
Local variable 'pos' could be declared final161
Parameter 'o' is not assigned and could be declared final171
Local variable 'nodeIndex' could be declared final178
Avoid if (x != y) ..; else ..;185

Tobago Core - org/apache/myfaces/tobago/model/TreeSelectable.java

ViolationLine
Parameter 'value' is not assigned and could be declared final45
Parameter 'name' is not assigned and could be declared final68
Local variable 'value' could be declared final69
Avoid if (x != y) ..; else ..;70 - 74

Tobago Core - org/apache/myfaces/tobago/model/TreeState.java

ViolationLine
Private field 'expandedState' could be made final; it is only initialized in the declaration or constructor.26
Private field 'markedState' could be made final; it is only initialized in the declaration or constructor.27
Parameter 'expandedState' is not assigned and could be declared final29
Parameter 'markedState' is not assigned and could be declared final29

Tobago Core - org/apache/myfaces/tobago/model/Wizard.java

ViolationLine
Overridable method 'reset' called during object construction38
Parameter 'event' is not assigned and could be declared final41
Parameter 'event' is not assigned and could be declared final47
Local variable 'step' could be declared final48
Local variable 'outcome' could be declared final59
Parameter 'event' is not assigned and could be declared final74
Parameter 'event' is not assigned and could be declared final82

Tobago Core - org/apache/myfaces/tobago/model/WizardStep.java

ViolationLine
Parameter 'index' is not assigned and could be declared final28
Parameter 'outcome' is not assigned and could be declared final36
Parameter 'title' is not assigned and could be declared final44
Parameter 'index' is not assigned and could be declared final52
Local variable 'builder' could be declared final57

Tobago Core - org/apache/myfaces/tobago/portlet/PortletUtils.java

ViolationLine
Parameter 'facesContext' is not assigned and could be declared final64
Parameter 'facesContext' is not assigned and could be declared final78
Parameter 'facesContext' is not assigned and could be declared final82
Local variable 'request' could be declared final83
Parameter 'facesContext' is not assigned and could be declared final90
Parameter 'viewId' is not assigned and could be declared final90
Local variable 'response' could be declared final91
Local variable 'url' could be declared final92
Parameter 'facesContext' is not assigned and could be declared final97
Local variable 'request' could be declared final98

Tobago Core - org/apache/myfaces/tobago/renderkit/AbstractAjaxRendererBaseWrapper.java

ViolationLine
Parameter 'component' is not assigned and could be declared final31
Parameter 'context' is not assigned and could be declared final31

Tobago Core - org/apache/myfaces/tobago/renderkit/AbstractLayoutRendererWrapper.java

ViolationLine
Parameter 'component' is not assigned and could be declared final31
Parameter 'facesContext' is not assigned and could be declared final31
Parameter 'component' is not assigned and could be declared final35
Parameter 'facesContext' is not assigned and could be declared final35
Parameter 'component' is not assigned and could be declared final39
Parameter 'facesContext' is not assigned and could be declared final39
Parameter 'component' is not assigned and could be declared final43
Parameter 'facesContext' is not assigned and could be declared final43
Parameter 'component' is not assigned and could be declared final47
Parameter 'facesContext' is not assigned and could be declared final47
Parameter 'component' is not assigned and could be declared final51
Parameter 'facesContext' is not assigned and could be declared final51

Tobago Core - org/apache/myfaces/tobago/renderkit/AbstractLayoutableRendererBaseWrapper.java

ViolationLine
Parameter 'component' is not assigned and could be declared final31
Parameter 'facesContext' is not assigned and could be declared final31
Parameter 'name' is not assigned and could be declared final31
Parameter 'component' is not assigned and could be declared final35
Parameter 'facesContext' is not assigned and could be declared final35
Parameter 'component' is not assigned and could be declared final39
Parameter 'facesContext' is not assigned and could be declared final39
Parameter 'component' is not assigned and could be declared final43
Parameter 'facesContext' is not assigned and could be declared final43
Parameter 'component' is not assigned and could be declared final47
Parameter 'facesContext' is not assigned and could be declared final47
Parameter 'component' is not assigned and could be declared final51
Parameter 'facesContext' is not assigned and could be declared final51
Parameter 'component' is not assigned and could be declared final55
Parameter 'facesContext' is not assigned and could be declared final55
Parameter 'component' is not assigned and could be declared final59
Parameter 'facesContext' is not assigned and could be declared final59
Parameter 'component' is not assigned and could be declared final63
Parameter 'facesContext' is not assigned and could be declared final63
Parameter 'component' is not assigned and could be declared final67
Parameter 'facesContext' is not assigned and could be declared final67
Parameter 'component' is not assigned and could be declared final71
Parameter 'facesContext' is not assigned and could be declared final71
Parameter 'component' is not assigned and could be declared final75
Parameter 'facesContext' is not assigned and could be declared final75
Parameter 'component' is not assigned and could be declared final79
Parameter 'facesContext' is not assigned and could be declared final79
Parameter 'component' is not assigned and could be declared final83
Parameter 'facesContext' is not assigned and could be declared final83
Parameter 'component' is not assigned and could be declared final87
Parameter 'facesContext' is not assigned and could be declared final87
Parameter 'component' is not assigned and could be declared final91
Parameter 'facesContext' is not assigned and could be declared final91
Parameter 'component' is not assigned and could be declared final95
Parameter 'facesContext' is not assigned and could be declared final95
Parameter 'component' is not assigned and could be declared final99
Parameter 'facesContext' is not assigned and could be declared final99
Parameter 'component' is not assigned and could be declared final103
Parameter 'facesContext' is not assigned and could be declared final103
Parameter 'component' is not assigned and could be declared final107
Parameter 'facesContext' is not assigned and could be declared final107
Parameter 'component' is not assigned and could be declared final111
Parameter 'facesContext' is not assigned and could be declared final111
Parameter 'component' is not assigned and could be declared final115
Parameter 'facesContext' is not assigned and could be declared final115

Tobago Core - org/apache/myfaces/tobago/renderkit/AbstractRendererBaseWrapper.java

ViolationLine
Avoid unused private fields such as 'LOG'.35
Avoid unused private fields such as 'LOG'.35
Parameter 'component' is not assigned and could be declared final38
Parameter 'facesContext' is not assigned and could be declared final38
Parameter 'parent' is not assigned and could be declared final38
Parameter 'component' is not assigned and could be declared final43
Parameter 'facesContext' is not assigned and could be declared final43
Parameter 'component' is not assigned and could be declared final51
Parameter 'context' is not assigned and could be declared final51
Parameter 'component' is not assigned and could be declared final61
Parameter 'facesContext' is not assigned and could be declared final61
Parameter 'input' is not assigned and could be declared final66
Parameter 'component' is not assigned and could be declared final71
Parameter 'facesContext' is not assigned and could be declared final71
Parameter 'component' is not assigned and could be declared final76
Parameter 'component' is not assigned and could be declared final81
Parameter 'facesContext' is not assigned and could be declared final81
Parameter 'component' is not assigned and could be declared final86
Parameter 'facesContext' is not assigned and could be declared final86
Parameter 'submittedValue' is not assigned and could be declared final86
Parameter 'component' is not assigned and could be declared final92
Parameter 'facesContext' is not assigned and could be declared final92
Parameter 'component' is not assigned and could be declared final97
Parameter 'facesContext' is not assigned and could be declared final97
Parameter 'component' is not assigned and could be declared final102
Parameter 'facesContext' is not assigned and could be declared final102
Parameter 'facesContext' is not assigned and could be declared final107
Parameter 'clientId' is not assigned and could be declared final107
Parameter 'facesContext' is not assigned and could be declared final111
Local variable 'renderer' could be declared final112 - 113

Tobago Core - org/apache/myfaces/tobago/renderkit/HtmlUtils.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.28 - 81
The class 'HtmlUtils' has a Cyclomatic Complexity of 3 (Highest = 5).28 - 81
Parameter 'name' is not assigned and could be declared final33
Parameter 'value' is not assigned and could be declared final33
The method 'generateAttribute' has a Cyclomatic Complexity of 5.33 - 45
Assigning an Object to null is a code smell. Consider refactoring.36
Parameter 'component' is not assigned and could be declared final47
Parameter 'name' is not assigned and could be declared final47
Parameter 'appendValue' is not assigned and could be declared final48
Local variable 'attribute' could be declared final49
Avoid if (x != y) ..; else ..;50 - 51
Parameter 'component' is not assigned and could be declared final54
Parameter 'facesContext' is not assigned and could be declared final55
Local variable 'onchange' could be declared final74

Tobago Core - org/apache/myfaces/tobago/renderkit/InputRendererBase.java

ViolationLine
The class 'InputRendererBase' has a Cyclomatic Complexity of 6 (Highest = 5).31 - 63
Parameter 'component' is not assigned and could be declared final35
Parameter 'context' is not assigned and could be declared final35
The method 'decode' has a Cyclomatic Complexity of 5.35 - 62
Local variable 'clientId' could be declared final47
Local variable 'requestParameterMap' could be declared final49 - 50
Local variable 'newValue' could be declared final59

Tobago Core - org/apache/myfaces/tobago/renderkit/LabelWithAccessKey.java

ViolationLine
Parameter 'label' is not assigned and could be declared final41
Parameter 'component' is not assigned and could be declared final46
Assigning an Object to null is a code smell. Consider refactoring.53
Avoid reassigning parameters such as 'index'57
Avoid reassigning parameters such as 'escapedIndicatorCount'57
Parameter 'label' is not assigned and could be declared final57
Parameter 'label' is not assigned and could be declared final77
Avoid if (x != y) ..; else ..;78 - 86
Assigning an Object to null is a code smell. Consider refactoring.90
Assigning an Object to null is a code smell. Consider refactoring.91
Parameter 'text' is not assigned and could be declared final107
Parameter 'accessKey' is not assigned and could be declared final111
Parameter 'accessKey' is not assigned and could be declared final122

Tobago Core - org/apache/myfaces/tobago/renderkit/LayoutComponentRendererBase.java

ViolationLine
Parameter 'component' is not assigned and could be declared final32
Parameter 'facesContext' is not assigned and could be declared final32
Parameter 'name' is not assigned and could be declared final32
Parameter 'component' is not assigned and could be declared final36
Parameter 'facesContext' is not assigned and could be declared final36
Parameter 'component' is not assigned and could be declared final40
Parameter 'facesContext' is not assigned and could be declared final40
Parameter 'component' is not assigned and could be declared final44
Parameter 'facesContext' is not assigned and could be declared final44
Parameter 'component' is not assigned and could be declared final48
Parameter 'facesContext' is not assigned and could be declared final48
Parameter 'component' is not assigned and could be declared final52
Parameter 'facesContext' is not assigned and could be declared final52
Parameter 'component' is not assigned and could be declared final56
Parameter 'facesContext' is not assigned and could be declared final56
Parameter 'component' is not assigned and could be declared final60
Parameter 'facesContext' is not assigned and could be declared final60
Parameter 'component' is not assigned and could be declared final64
Parameter 'facesContext' is not assigned and could be declared final64
Parameter 'component' is not assigned and could be declared final68
Parameter 'facesContext' is not assigned and could be declared final68
Parameter 'component' is not assigned and could be declared final72
Parameter 'facesContext' is not assigned and could be declared final72
Parameter 'component' is not assigned and could be declared final76
Parameter 'facesContext' is not assigned and could be declared final76
Parameter 'component' is not assigned and could be declared final80
Parameter 'facesContext' is not assigned and could be declared final80
Parameter 'component' is not assigned and could be declared final84
Parameter 'facesContext' is not assigned and could be declared final84
Parameter 'component' is not assigned and could be declared final88
Parameter 'facesContext' is not assigned and could be declared final88
Parameter 'component' is not assigned and could be declared final92
Parameter 'facesContext' is not assigned and could be declared final92
Parameter 'component' is not assigned and could be declared final96
Parameter 'facesContext' is not assigned and could be declared final96
Parameter 'component' is not assigned and could be declared final100
Parameter 'facesContext' is not assigned and could be declared final100
Parameter 'component' is not assigned and could be declared final104
Parameter 'facesContext' is not assigned and could be declared final104
Parameter 'component' is not assigned and could be declared final108
Parameter 'facesContext' is not assigned and could be declared final108
Parameter 'component' is not assigned and could be declared final112
Parameter 'facesContext' is not assigned and could be declared final112
Parameter 'component' is not assigned and could be declared final116
Parameter 'facesContext' is not assigned and could be declared final116
Avoid if (x != y) ..; else ..;119 - 123

Tobago Core - org/apache/myfaces/tobago/renderkit/PageRendererBase.java

ViolationLine
The class 'PageRendererBase' has a Cyclomatic Complexity of 4 (Highest = 5).36 - 99
Parameter 'component' is not assigned and could be declared final40
Parameter 'facesContext' is not assigned and could be declared final40
Local variable 'page' could be declared final42
Parameter 'page' is not assigned and could be declared final49
Parameter 'facesContext' is not assigned and could be declared final49
The method 'decodeActionPosition' has a Cyclomatic Complexity of 5.49 - 73
Local variable 'actionIdName' could be declared final50
Local variable 'newActionId' could be declared final51
Local variable 'actionPositionName' could be declared final58
Local variable 'actionPositionString' could be declared final59 - 60
Local variable 'actionPosition' could be declared final65
Parameter 'page' is not assigned and could be declared final76
Parameter 'facesContext' is not assigned and could be declared final76
Local variable 'tokenizer' could be declared final83
Local variable 'width' could be declared final84
Local variable 'height' could be declared final85
Local variable 'pageState' could be declared final87

Tobago Core - org/apache/myfaces/tobago/renderkit/RendererBase.java

ViolationLine
The class 'RendererBase' has a Cyclomatic Complexity of 3 (Highest = 8).45 - 200
Parameter 'component' is not assigned and could be declared final54
Parameter 'facesContext' is not assigned and could be declared final54
Local variable 'markup' could be declared final58
Document empty method67 - 68
Parameter 'component' is not assigned and could be declared final67
Parameter 'context' is not assigned and could be declared final67
Parameter 'rendererType' is not assigned and could be declared final74
Parameter 'component' is not assigned and could be declared final82
Parameter 'facesContext' is not assigned and could be declared final82
Parameter 'key' is not assigned and could be declared final82
Parameter 'input' is not assigned and could be declared final86
Local variable 'submittedValue' could be declared final87
Parameter 'component' is not assigned and could be declared final94
Parameter 'facesContext' is not assigned and could be declared final94
The method 'getCurrentValue' has a Cyclomatic Complexity of 5.94 - 109
Local variable 'editableValueHolder' could be declared final97
Local variable 'submittedValue' could be declared final98
Local variable 'currentObj' could be declared final104
Parameter 'component' is not assigned and could be declared final111
Parameter 'context' is not assigned and could be declared final111
Parameter 'currentValue' is not assigned and could be declared final111
The method 'getFormattedValue' has a Cyclomatic Complexity of 7.111 - 140
Local variable 'converterType' could be declared final131
Parameter 'component' is not assigned and could be declared final142
Local variable 'value' could be declared final144
Parameter 'component' is not assigned and could be declared final154
Parameter 'context' is not assigned and could be declared final154
The method 'getConverter' has a Cyclomatic Complexity of 8.154 - 175
Local variable 'valueBinding' could be declared final160
Local variable 'converterType' could be declared final162
Parameter 'component' is not assigned and could be declared final178
Parameter 'submittedValue' is not assigned and could be declared final178
Parameter 'context' is not assigned and could be declared final178
Local variable 'converter' could be declared final183
Avoid if (x != y) ..; else ..;184 - 188
Document empty method191 - 192
Parameter 'component' is not assigned and could be declared final191
Parameter 'facesContext' is not assigned and could be declared final191
Parameter 'parent' is not assigned and could be declared final191
Use block level rather than method level synchronization194 - 199

Tobago Core - org/apache/myfaces/tobago/renderkit/RendererBaseWrapper.java

ViolationLine
Private field 'renderer' could be made final; it is only initialized in the declaration or constructor.29
Parameter 'renderer' is not assigned and could be declared final31
Document empty method35 - 36
Parameter 'component' is not assigned and could be declared final35
Parameter 'facesContext' is not assigned and could be declared final35
Parameter 'component' is not assigned and could be declared final38
Parameter 'submittedValue' is not assigned and could be declared final38
Parameter 'context' is not assigned and could be declared final38
Parameter 'component' is not assigned and could be declared final43
Parameter 'facesContext' is not assigned and could be declared final43
Parameter 'component' is not assigned and could be declared final47
Parameter 'context' is not assigned and could be declared final47
Parameter 'component' is not assigned and could be declared final51
Parameter 'context' is not assigned and could be declared final51
Parameter 'component' is not assigned and could be declared final55
Parameter 'context' is not assigned and could be declared final55
Parameter 'context' is not assigned and could be declared final59
Parameter 'clientId' is not assigned and could be declared final59

Tobago Core - org/apache/myfaces/tobago/renderkit/SelectManyRendererBase.java

ViolationLine
The class 'SelectManyRendererBase' has a Cyclomatic Complexity of 13 (Highest = 26).39 - 199
The class 'SelectManyRendererBase' has a Cyclomatic Complexity of 13 (Highest = 26).39 - 199
Parameter 'component' is not assigned and could be declared final43
Parameter 'facesContext' is not assigned and could be declared final43
The method 'decode' has a Cyclomatic Complexity of 8.43 - 68
Local variable 'uiSelectMany' could be declared final48
Avoid if (x != y) ..; else ..;55
Deeply nested if..then statements are hard to read56 - 60
Parameter 'component' is not assigned and could be declared final71
Parameter 'facesContext' is not assigned and could be declared final71
Parameter 'submittedValue' is not assigned and could be declared final71
Parameter 'facesContext' is not assigned and could be declared final85
The method 'getConvertedUISelectManyValue' has a Cyclomatic Complexity of 26.85 - 197
The method getConvertedUISelectManyValue() has an NPath complexity of 82368085 - 197
Avoid really long methods.85 - 197
The method 'getConvertedUISelectManyValue' has a Cyclomatic Complexity of 26.85 - 197
Parameter 'component' is not assigned and could be declared final86
Parameter 'submittedValue' is not assigned and could be declared final87
Local variable 'vb' could be declared final97
These nested if statements could be combined145 - 147
These nested if statements could be combined145 - 147
Local variable 'len' could be declared final153
Local variable 'length' could be declared final167
Local variable 'list' could be declared final168
Local variable 'len' could be declared final181
Local variable 'convertedValues' could be declared final182
Local variable 'length' could be declared final190
Local variable 'convertedValues' could be declared final191

Tobago Core - org/apache/myfaces/tobago/renderkit/SelectOneRendererBase.java

ViolationLine
The class 'SelectOneRendererBase' has a Cyclomatic Complexity of 5 (Highest = 4).30 - 51
Parameter 'component' is not assigned and could be declared final34
Parameter 'facesContext' is not assigned and could be declared final34
Local variable 'uiSelectOne' could be declared final39
Local variable 'clientId' could be declared final41
Local variable 'newValue' could be declared final42 - 43

Tobago Core - org/apache/myfaces/tobago/renderkit/TobagoRenderKit.java

ViolationLine
The class 'TobagoRenderKit' has a Cyclomatic Complexity of 4 (Highest = 13).49 - 203
The class 'TobagoRenderKit' has a Cyclomatic Complexity of 4 (Highest = 13).49 - 203
Private field 'responseStateManager' could be made final; it is only initialized in the declaration or constructor.55
Private field 'renderers' could be made final; it is only initialized in the declaration or constructor.59
Parameter 'rendererType' is not assigned and could be declared final68
Parameter 'family' is not assigned and could be declared final68
Avoid instantiation through private constructors from outside of the constructor's class.69
Local variable 'renderKit' could be declared final71
Local variable 'rkFactory' could be declared final88
The method 'createResponseWriter' has a Cyclomatic Complexity of 13.96 - 145
The method createResponseWriter() has an NPath complexity of 40096 - 145
The method 'createResponseWriter' has a Cyclomatic Complexity of 13.96 - 145
Parameter 'writer' is not assigned and could be declared final97
Parameter 'contentTypeList' is not assigned and could be declared final97
Parameter 'characterEncoding' is not assigned and could be declared final97
Local variable 'facesContext' could be declared final99
The String literal "text/html" appears 5 times in this file; the first occurrence is on line 104104
Parameter 'rendererType' is not assigned and could be declared final148
Parameter 'family' is not assigned and could be declared final148
Parameter 'renderer' is not assigned and could be declared final148
Avoid instantiation through private constructors from outside of the constructor's class.149
The method 'getResponseStateManager' has a Cyclomatic Complexity of 5.153 - 160
Parameter 'outputStream' is not assigned and could be declared final163
The class 'Key' has a Cyclomatic Complexity of 3 (Highest = 6).167 - 202
Parameter 'rendererType' is not assigned and could be declared final171
Parameter 'family' is not assigned and could be declared final171
Parameter 'o' is not assigned and could be declared final176
The method 'equals' has a Cyclomatic Complexity of 6.176 - 194
Local variable 'key' could be declared final184

Tobago Core - org/apache/myfaces/tobago/renderkit/TobagoResponseStateManager.java

ViolationLine
The class 'TobagoResponseStateManager' has a Cyclomatic Complexity of 4 (Highest = 7).35 - 115
Parameter 'context' is not assigned and could be declared final42
Parameter 'viewId' is not assigned and could be declared final42
Local variable 'treeStructure' could be declared final43
Local variable 'componentStateToRestore' could be declared final44
Parameter 'facescontext' is not assigned and could be declared final51
Parameter 'viewId' is not assigned and could be declared final51
Local variable 'requestMap' could be declared final52
Local variable 'requestViewId' could be declared final53
Parameter 'facesContext' is not assigned and could be declared final63
Local variable 'requestMap' could be declared final64
Parameter 'facesContext' is not assigned and could be declared final68
The method 'writeState' has a Cyclomatic Complexity of 7.68 - 113
Parameter 'serializedview' is not assigned and could be declared final69
Local variable 'responseWriter' could be declared final70
Local variable 'treeStruct' could be declared final71
Local variable 'compStates' could be declared final72
Avoid if (x != y) ..; else ..;74 - 87
Avoid if (x != y) ..; else ..;93 - 104

Tobago Core - org/apache/myfaces/tobago/renderkit/css/Classes.java

ViolationLine
The class 'Classes' has a Cyclomatic Complexity of 2 (Highest = 9).61 - 164
Parameter 'component' is not assigned and could be declared final69
Parameter 'sub' is not assigned and could be declared final73
Parameter 'component' is not assigned and could be declared final73
Parameter 'component' is not assigned and could be declared final77
Parameter 'explicit' is not assigned and could be declared final77
Parameter 'sub' is not assigned and could be declared final81
Parameter 'component' is not assigned and could be declared final81
Parameter 'explicit' is not assigned and could be declared final81
Use block level rather than method level synchronization86 - 100
Parameter 'sub' is not assigned and could be declared final87
Parameter 'component' is not assigned and could be declared final87
Parameter 'explicit' is not assigned and could be declared final87
Parameter 'markupFromComponent' is not assigned and could be declared final87
Parameter 'ignoreCheck' is not assigned and could be declared final87
Parameter 'markup' is not assigned and could be declared final102
Parameter 'sub' is not assigned and could be declared final102
Parameter 'ignoreMarkupCheck' is not assigned and could be declared final102
Parameter 'rendererName' is not assigned and could be declared final102
The constructor 'Classes' has a Cyclomatic Complexity of 9.102 - 135
Avoid if (x != y) ..; else ..;107
Local variable 'builder' could be declared final107
Local variable 'theme' could be declared final115
Parameter 'component' is not assigned and could be declared final143
Parameter 'sub' is not assigned and could be declared final152
Parameter 'explicit' is not assigned and could be declared final152
Parameter 'rendererName' is not assigned and could be declared final152
Parameter 'explicit' is not assigned and could be declared final160
Parameter 'rendererName' is not assigned and could be declared final160

Tobago Core - org/apache/myfaces/tobago/renderkit/css/Overflow.java

ViolationLine
Parameter 'value' is not assigned and could be declared final30

Tobago Core - org/apache/myfaces/tobago/renderkit/css/Position.java

ViolationLine
Parameter 'value' is not assigned and could be declared final31

Tobago Core - org/apache/myfaces/tobago/renderkit/css/Style.java

ViolationLine
This class has a bunch of public methods and attributes20 - 536
The class 'Style' has a Cyclomatic Complexity of 2 (Highest = 23).33 - 536
The class 'Style' has a Cyclomatic Complexity of 2 (Highest = 23).33 - 536
Too many fields33 - 536
Document empty constructor59 - 60
Parameter 'map' is not assigned and could be declared final62
Parameter 'facesContext' is not assigned and could be declared final86
Parameter 'layout' is not assigned and could be declared final86
The constructor 'Style' has a Cyclomatic Complexity of 10.86 - 131
The constructor 'Style' has a Cyclomatic Complexity of 10.86 - 131
Local variable 'rendererType' could be declared final88
Overridable method 'getDisplay' called during object construction124
Assigning an Object to null is a code smell. Consider refactoring.128
Assigning an Object to null is a code smell. Consider refactoring.129
The method 'encode' has a Cyclomatic Complexity of 22.142 - 251
The method encode() has an NPath complexity of 2097152142 - 251
Avoid really long methods.142 - 251
The method 'encode' has a Cyclomatic Complexity of 22.142 - 251
Local variable 'buf' could be declared final143
The method 'encodeJson' has a Cyclomatic Complexity of 23.253 - 367
The method encodeJson() has an NPath complexity of 4194304253 - 367
Avoid really long methods.253 - 367
The method 'encodeJson' has a Cyclomatic Complexity of 23.253 - 367
Local variable 'buf' could be declared final254
The String literal "\"," appears 20 times in this file; the first occurrence is on line 258258
Parameter 'width' is not assigned and could be declared final373
Parameter 'height' is not assigned and could be declared final381
Parameter 'left' is not assigned and could be declared final389
Parameter 'top' is not assigned and could be declared final397
Parameter 'display' is not assigned and could be declared final405
Parameter 'position' is not assigned and could be declared final413
Parameter 'overflowX' is not assigned and could be declared final421
Parameter 'overflowY' is not assigned and could be declared final429
Parameter 'marginLeft' is not assigned and could be declared final437
Parameter 'marginRight' is not assigned and could be declared final445
Parameter 'marginTop' is not assigned and could be declared final453
Parameter 'marginBottom' is not assigned and could be declared final461
Parameter 'margin' is not assigned and could be declared final469
Parameter 'paddingLeft' is not assigned and could be declared final477
Parameter 'paddingRight' is not assigned and could be declared final485
Parameter 'paddingTop' is not assigned and could be declared final493
Parameter 'paddingBottom' is not assigned and could be declared final501
Parameter 'padding' is not assigned and could be declared final509
Parameter 'backgroundImage' is not assigned and could be declared final517
Parameter 'zIndex' is not assigned and could be declared final525
Parameter 'textAlign' is not assigned and could be declared final533

Tobago Core - org/apache/myfaces/tobago/renderkit/html/StyleClasses.java

ViolationLine
The class 'StyleClasses' has a Cyclomatic Complexity of 2 (Highest = 7).46 - 296
This class has too many methods, consider refactoring it.46 - 296
Parameter 'sub' is not assigned and could be declared final66
Parameter 'component' is not assigned and could be declared final66
Overridable method 'addClass' called during object construction68
Parameter 'base' is not assigned and could be declared final71
Parameter 'component' is not assigned and could be declared final76
Local variable 'attributes' could be declared final77
Parameter 'component' is not assigned and could be declared final86
Parameter 'clazz' is not assigned and could be declared final94
Parameter 'clazz' is not assigned and could be declared final101
Parameter 'sub' is not assigned and could be declared final105
Parameter 'renderer' is not assigned and could be declared final105
Parameter 'sub' is not assigned and could be declared final109
Parameter 'renderer' is not assigned and could be declared final109
Parameter 'sub' is not assigned and could be declared final117
Parameter 'renderer' is not assigned and could be declared final117
Local variable 'builder' could be declared final118
Parameter 'markup' is not assigned and could be declared final125
Parameter 'renderer' is not assigned and could be declared final125
Parameter 'markup' is not assigned and could be declared final129
Parameter 'renderer' is not assigned and could be declared final129
Parameter 'sub' is not assigned and could be declared final133
Parameter 'markup' is not assigned and could be declared final133
Parameter 'renderer' is not assigned and could be declared final133
Parameter 'sub' is not assigned and could be declared final137
Parameter 'markup' is not assigned and could be declared final137
Parameter 'renderer' is not assigned and could be declared final137
Parameter 'sub' is not assigned and could be declared final141
Parameter 'markup' is not assigned and could be declared final141
Parameter 'renderer' is not assigned and could be declared final141
Local variable 'builder' could be declared final142
Parameter 'component' is not assigned and could be declared final153
Parameter 'rendererName' is not assigned and could be declared final153
Parameter 'sub' is not assigned and could be declared final159
Parameter 'supportsMarkup' is not assigned and could be declared final159
Parameter 'rendererName' is not assigned and could be declared final159
The method 'addMarkupClass' has a Cyclomatic Complexity of 5.159 - 173
Local variable 'm' could be declared final160
Local variable 'theme' could be declared final163
Parameter 'aspect' is not assigned and could be declared final175
Parameter 'renderer' is not assigned and could be declared final175
Parameter 'aspect' is not assigned and could be declared final179
Parameter 'renderer' is not assigned and could be declared final179
Parameter 'aspect' is not assigned and could be declared final183
Parameter 'renderer' is not assigned and could be declared final183
Local variable 'builder' could be declared final184
Parameter 'sub' is not assigned and could be declared final190
Parameter 'aspect' is not assigned and could be declared final190
Parameter 'renderer' is not assigned and could be declared final190
Parameter 'sub' is not assigned and could be declared final194
Parameter 'aspect' is not assigned and could be declared final194
Parameter 'renderer' is not assigned and could be declared final194
Parameter 'sub' is not assigned and could be declared final198
Parameter 'aspect' is not assigned and could be declared final198
Parameter 'renderer' is not assigned and could be declared final198
Local variable 'builder' could be declared final199
Parameter 'styleClasses' is not assigned and could be declared final207
Parameter 'clazz' is not assigned and could be declared final213
Parameter 'rendererName' is not assigned and could be declared final217
Local variable 'i' could be declared final218
Local variable 'clazz' could be declared final219
Parameter 'component' is not assigned and could be declared final226
Parameter 'rendererName' is not assigned and could be declared final226
Parameter 'component' is not assigned and could be declared final231
Parameter 'rendererName' is not assigned and could be declared final231
The method 'updateClassAttribute' has a Cyclomatic Complexity of 7.231 - 254
Local variable 'input' could be declared final246
Local variable 'buffer' could be declared final261
Local variable 'i' could be declared final262
Local variable 'clazz' could be declared final263

Tobago Core - org/apache/myfaces/tobago/servlet/NonFacesRequestServlet.java

ViolationLine
Parameter 'response' is not assigned and could be declared final47
Parameter 'request' is not assigned and could be declared final47
Local variable 'lFactory' could be declared final50
Local variable 'lifecycle' could be declared final51
Local variable 'fcFactory' could be declared final52
Local variable 'facesContext' could be declared final53
Local variable 'outcome' could be declared final57
Local variable 'application' could be declared final66
Local variable 'viewHandler' could be declared final68
Local variable 'viewId' could be declared final69
Local variable 'view' could be declared final70
Local variable 'navigationHandler' could be declared final74
An empty method in an abstract class should be abstract instead90 - 92

Tobago Core - org/apache/myfaces/tobago/servlet/ResourceServlet.java

ViolationLine
The class 'ResourceServlet' has a Cyclomatic Complexity of 4 (Highest = 8).68 - 193
Private field 'resourceDirs' could be made final; it is only initialized in the declaration or constructor.76
Parameter 'servletConfig' is not assigned and could be declared final79
The method 'init' has a Cyclomatic Complexity of 7.79 - 106
Local variable 'tobagoConfig' could be declared final81
Local variable 'defaultTheme' could be declared final85
Local variable 'expiresString' could be declared final89
Avoid instantiating Long objects.Call Long.valueOf() instead92
Local variable 'bufferSizeString' could be declared final97
Parameter 'themes' is not assigned and could be declared final108
Parameter 'theme' is not assigned and could be declared final114
Local variable 'dir' could be declared final115
This call to String.startsWith can be rewritten using String.charAt(0)116
The method 'doGet' has a Cyclomatic Complexity of 8.124 - 175
Parameter 'response' is not assigned and could be declared final125
Parameter 'request' is not assigned and could be declared final125
Local variable 'requestURI' could be declared final128
Local variable 'contentType' could be declared final143
Avoid if (x != y) ..; else ..;144 - 151
Local variable 'message' could be declared final147
Local variable 'classLoader' could be declared final155
Avoid if (x != y) ..; else ..;165 - 171
Local variable 'message' could be declared final168
Parameter 'request' is not assigned and could be declared final178
Avoid if (x != y) ..; else ..;179 - 183
Parameter 'inputStream' is not assigned and could be declared final186
Parameter 'outputStream' is not assigned and could be declared final186
Local variable 'buffer' could be declared final187

Tobago Core - org/apache/myfaces/tobago/util/ApplyRequestValuesCallback.java

ViolationLine
The class 'ApplyRequestValuesCallback' has a Cyclomatic Complexity of 7 (Highest = 12).34 - 65
The class 'ApplyRequestValuesCallback' has a Cyclomatic Complexity of 7 (Highest = 12).34 - 65
Avoid unused private fields such as 'LOG'.37
Avoid unused private fields such as 'LOG'.37
Parameter 'component' is not assigned and could be declared final39
Parameter 'context' is not assigned and could be declared final39
The method 'invokeContextCallback' has a Cyclomatic Complexity of 12.39 - 60
The method 'invokeContextCallback' has a Cyclomatic Complexity of 12.39 - 60
Local variable 'reload' could be declared final42
Local variable 'immediate' could be declared final45
Deeply nested if..then statements are hard to read46 - 56
Local variable 'update' could be declared final47

Tobago Core - org/apache/myfaces/tobago/util/BeanComparator.java

ViolationLine
Private field 'property' could be made final; it is only initialized in the declaration or constructor.35
Parameter 'property' is not assigned and could be declared final37
Parameter 'reverse' is not assigned and could be declared final41
Parameter 'property' is not assigned and could be declared final41
Parameter 'property' is not assigned and could be declared final46
Parameter 'comparator' is not assigned and could be declared final46
Parameter 'reverse' is not assigned and could be declared final51
Parameter 'property' is not assigned and could be declared final51
Parameter 'comparator' is not assigned and could be declared final51
Parameter 'param1' is not assigned and could be declared final60
Avoid if (x != y) ..; else ..;73
Parameter 'param1' is not assigned and could be declared final85
Parameter 'param2' is not assigned and could be declared final85

Tobago Core - org/apache/myfaces/tobago/util/BundleMapWrapper.java

ViolationLine
This class has too many methods, consider refactoring it.30 - 109
Private field 'basename' could be made final; it is only initialized in the declaration or constructor.32
Parameter 'basename' is not assigned and could be declared final34
Parameter 'key' is not assigned and could be declared final42
Local variable 'value' could be declared final46 - 47
Parameter 'value' is not assigned and could be declared final51
Parameter 'key' is not assigned and could be declared final59
Parameter 'o' is not assigned and could be declared final71
Local variable 'that' could be declared final78
Parameter 'v' is not assigned and could be declared final90
Parameter 'k' is not assigned and could be declared final90
Parameter 't' is not assigned and could be declared final94
Parameter 'k' is not assigned and could be declared final98

Tobago Core - org/apache/myfaces/tobago/util/ComparatorBase.java

ViolationLine
The class 'ComparatorBase' has a Cyclomatic Complexity of 3 (Highest = 14).27 - 126
The class 'ComparatorBase' has a Cyclomatic Complexity of 3 (Highest = 14).27 - 126
Document empty constructor33 - 34
Parameter 'reverse' is not assigned and could be declared final36
Parameter 'comparator' is not assigned and could be declared final36
Parameter 'reverse' is not assigned and could be declared final41
Parameter 'comparator' is not assigned and could be declared final45
Parameter 'obj1' is not assigned and could be declared final49
Parameter 'obj2' is not assigned and could be declared final49
The method 'internalCompare' has a Cyclomatic Complexity of 14.49 - 89
The method 'internalCompare' has a Cyclomatic Complexity of 14.49 - 89
Local variable 'collationKey1' could be declared final71 - 72
Local variable 'collationKey2' could be declared final73 - 74
Avoid if (x != y) ..; else ..;77 - 87
Parameter 'o' is not assigned and could be declared final112
Avoid if (x != y) ..; else ..;120

Tobago Core - org/apache/myfaces/tobago/util/ComponentUtils.java

ViolationLine
High amount of different objects as members denotes a high coupling20 - 1111
A high number of imports can indicate a high degree of coupling within an object.20 - 1111
This class has a bunch of public methods and attributes20 - 1111
A class which only has private constructors should be final77 - 1111
The class 'ComponentUtils' has a Cyclomatic Complexity of 3 (Highest = 10).77 - 1111
This class has too many methods, consider refactoring it.77 - 1111
Avoid really long classes.77 - 1111
The class 'ComponentUtils' has a Cyclomatic Complexity of 3 (Highest = 10).77 - 1111
Parameter 'context' is not assigned and could be declared final103
Local variable 'iter' could be declared final104
Local variable 'message' could be declared final105
Parameter 'command' is not assigned and could be declared final113
Local variable 'actionListeners' could be declared final114
Parameter 'component' is not assigned and could be declared final123
Parameter 'facesContext' is not assigned and could be declared final123
Local variable 'messages' could be declared final124 - 125
Local variable 'stringBuffer' could be declared final126
Local variable 'message' could be declared final128
Avoid reassigning parameters such as 'component'138
Parameter 'context' is not assigned and could be declared final148
Local variable 'view' could be declared final149
Parameter 'component' is not assigned and could be declared final159
Parameter 'faceletContext' is not assigned and could be declared final159
Local variable 'viewRoot' could be declared final160
Avoid if (x != y) ..; else ..;161 - 165
Parameter 'component' is not assigned and could be declared final168
Parameter 'context' is not assigned and could be declared final168
Local variable 'view' could be declared final169
Avoid if (x != y) ..; else ..;170 - 180
Local variable 'page' could be declared final173
Avoid reassigning parameters such as 'component'183
Parameter 'facesContext' is not assigned and could be declared final193
Parameter 'component' is not assigned and could be declared final197
The method 'findPageBreadthFirst' has a Cyclomatic Complexity of 5.197 - 210
Local variable 'result' could be declared final204
Avoid reassigning parameters such as 'component'213
Avoid reassigning parameters such as 'component'223
Parameter 'type' is not assigned and could be declared final223
Parameter 'component' is not assigned and could be declared final238
Local variable 'collect' could be declared final239
Parameter 'component' is not assigned and could be declared final245
Parameter 'collect' is not assigned and could be declared final245
Local variable 'kids' could be declared final246
Local variable 'child' could be declared final248
Parameter 'component' is not assigned and could be declared final260
Parameter 'type' is not assigned and could be declared final260
Parameter 'component' is not assigned and could be declared final277
Parameter 'type' is not assigned and could be declared final277
Local variable 'result' could be declared final279
Parameter 'component' is not assigned and could be declared final297
Parameter 'facesContext' is not assigned and could be declared final297
Local variable 'forComponent' could be declared final298
Local variable 'clientId' could be declared final300
Parameter 'component' is not assigned and could be declared final312
Local variable 'forValue' could be declared final313
Parameter 'component' is not assigned and could be declared final328
The method 'evaluateAutoFor' has a Cyclomatic Complexity of 5.328 - 340
Local variable 'forComponent' could be declared final329
Parameter 'component' is not assigned and could be declared final348
Parameter 'clazz' is not assigned and could be declared final348
The method 'evaluateAutoFor' has a Cyclomatic Complexity of 7.348 - 367
Local variable 'forComponent' could be declared final349
Parameter 'child' is not assigned and could be declared final370
Parameter 'namingContainer' is not assigned and could be declared final370
Parameter 'component' is not assigned and could be declared final370
Parameter 'clazz' is not assigned and could be declared final370
Avoid reassigning parameters such as 'component'384
Local variable 'form' could be declared final387
Parameter 'component' is not assigned and could be declared final397
The method 'getMaximumSeverity' has a Cyclomatic Complexity of 5.397 - 409
Assigning an Object to null is a code smell. Consider refactoring.399
Local variable 'facesContext' could be declared final400
Local variable 'message' could be declared final403
Parameter 'uiInput' is not assigned and could be declared final411
Local variable 'facesContext' could be declared final412
Parameter 'component' is not assigned and could be declared final417
Parameter 'component' is not assigned and could be declared final424
Parameter 'component' is not assigned and could be declared final429
Parameter 'component' is not assigned and could be declared final434
Parameter 'component' is not assigned and could be declared final438
Parameter 'name' is not assigned and could be declared final438
The method 'getBooleanAttribute' has a Cyclomatic Complexity of 5.438 - 460
Parameter 'value' is not assigned and could be declared final464
Parameter 'styleClasses' is not assigned and could be declared final473
Parameter 'component' is not assigned and could be declared final473
The method 'setStyleClasses' has a Cyclomatic Complexity of 5.473 - 487
Local variable 'classes' could be declared final478
Local variable 'styles' could be declared final480
Parameter 'markup' is not assigned and could be declared final493
Parameter 'markupComponent' is not assigned and could be declared final493
Parameter 'component' is not assigned and could be declared final507
Parameter 'name' is not assigned and could be declared final507
Parameter 'component' is not assigned and could be declared final515
Parameter 'name' is not assigned and could be declared final515
Parameter 'component' is not assigned and could be declared final519
Parameter 'name' is not assigned and could be declared final519
Parameter 'component' is not assigned and could be declared final523
Parameter 'name' is not assigned and could be declared final523
Parameter 'component' is not assigned and could be declared final527
Parameter 'name' is not assigned and could be declared final527
The method 'getIntAttribute' has a Cyclomatic Complexity of 5.527 - 546
Parameter 'defaultValue' is not assigned and could be declared final528
Local variable 'integer' could be declared final529
Parameter 'component' is not assigned and could be declared final548
Parameter 'name' is not assigned and could be declared final548
The method 'getCharacterAttribute' has a Cyclomatic Complexity of 5.548 - 562
Local variable 'character' could be declared final549
Local variable 'asString' could be declared final555
Assigning an Object to null is a code smell. Consider refactoring.556
Parameter 'component' is not assigned and could be declared final564
Parameter 'parent' is not assigned and could be declared final564
Local variable 'facet' could be declared final566
Parameter 'component' is not assigned and could be declared final574
Parameter 'facesContext' is not assigned and could be declared final574
Parameter 'rendererType' is not assigned and could be declared final578
Parameter 'facesContext' is not assigned and could be declared final578
Parameter 'family' is not assigned and could be declared final578
Local variable 'requestMap' could be declared final583
Local variable 'key' could be declared final584
Local variable 'myRenderer' could be declared final589
Parameter 'rendererType' is not assigned and could be declared final601
Parameter 'facesContext' is not assigned and could be declared final601
Parameter 'family' is not assigned and could be declared final601
Local variable 'rkFactory' could be declared final602
Local variable 'renderKit' could be declared final603
Local variable 'myRenderer' could be declared final604
Consider simply returning the value vs storing it in local variable 'myRenderer'605
Parameter 'component' is not assigned and could be declared final608
Parameter 'name' is not assigned and could be declared final608
The method 'findParameter' has a Cyclomatic Complexity of 5.608 - 622
Local variable 'parameter' could be declared final611
Parameter 'type' is not assigned and could be declared final624
Local variable 'clazz' could be declared final631
Parameter 'component' is not assigned and could be declared final641
Parameter 'component' is not assigned and could be declared final652
Parameter 'component' is not assigned and could be declared final656
Avoid reassigning parameters such as 'value'669
Parameter 'component' is not assigned and could be declared final669
Parameter 'name' is not assigned and could be declared final669
Avoid instantiating Integer objects. Call Integer.valueOf() instead.675
Avoid reassigning parameters such as 'value'680
Parameter 'name' is not assigned and could be declared final687
Parameter 'value' is not assigned and could be declared final687
Local variable 'context' could be declared final688
Local variable 'valueBinding' could be declared final689
Parameter 'items' is not assigned and could be declared final694
Parameter 'value' is not assigned and could be declared final694
Parameter 'valueBinding' is not assigned and could be declared final703
Parameter 'value' is not assigned and could be declared final707
Parameter 'postfix' is not assigned and could be declared final720
Parameter 'component' is not assigned and could be declared final720
Parameter 'facesContext' is not assigned and could be declared final720
Local variable 'id' could be declared final722
Parameter 'component' is not assigned and could be declared final726
Parameter 'facesContext' is not assigned and could be declared final726
Local variable 'id' could be declared final727
Parameter 'component' is not assigned and could be declared final740
Parameter 'facesContext' is not assigned and could be declared final740
The method 'provideLabel' has a Cyclomatic Complexity of 5.740 - 769
Local variable 'application' could be declared final752
Local variable 'idprefix' could be declared final755
Parameter 'editableValueHolder' is not assigned and could be declared final775
Parameter 'validator' is not assigned and could be declared final775
These nested if statements could be combined777 - 781
These nested if statements could be combined777 - 781
Local variable 'methodBinding' could be declared final778 - 779
Parameter 'converterId' is not assigned and could be declared final789
Parameter 'valueHolder' is not assigned and could be declared final789
The method 'setConverter' has a Cyclomatic Complexity of 5.789 - 803
Local variable 'valueBinding' could be declared final794
Local variable 'converter' could be declared final799
Parameter 'component' is not assigned and could be declared final809
Parameter 'action' is not assigned and could be declared final809
Local variable 'binding' could be declared final814
Parameter 'actionListener' is not assigned and could be declared final826
Parameter 'command' is not assigned and could be declared final826
Local variable 'binding' could be declared final831 - 832
Parameter 'valueChangeListener' is not assigned and could be declared final845
Parameter 'valueHolder' is not assigned and could be declared final845
Local variable 'binding' could be declared final850 - 851
Parameter 'component' is not assigned and could be declared final864
Parameter 'name' is not assigned and could be declared final864
Parameter 'state' is not assigned and could be declared final864
Local variable 'valueBinding' could be declared final867
Parameter 'component' is not assigned and could be declared final876
Parameter 'facesContext' is not assigned and could be declared final876
The method 'getMarkupBinding' has a Cyclomatic Complexity of 7.876 - 899
Local variable 'vb' could be declared final877
Local variable 'markups' could be declared final879
Local variable 'strings' could be declared final883
Local variable 'result' could be declared final884
Parameter 'relativeId' is not assigned and could be declared final913
Parameter 'from' is not assigned and could be declared final913
Parameter 'renderers' is not assigned and could be declared final917
The method 'getConvertedValue' has a Cyclomatic Complexity of 10.921 - 952
The method 'getConvertedValue' has a Cyclomatic Complexity of 10.921 - 952
Parameter 'component' is not assigned and could be declared final922
Parameter 'facesContext' is not assigned and could be declared final922
Parameter 'stringValue' is not assigned and could be declared final922
Local variable 'renderer' could be declared final924
Avoid if (x != y) ..; else ..;925 - 947
Local variable 'vb' could be declared final936
Local variable 'valueType' could be declared final938
Avoid reassigning parameters such as 'markup'954
Avoid reassigning parameters such as 'markup'954
Avoid reassigning parameters such as 'markup'954
Avoid reassigning parameters such as 'markup'954
Avoid reassigning parameters such as 'markup'954
Parameter 'component' is not assigned and could be declared final954
The method 'updateMarkup' has a Cyclomatic Complexity of 6.954 - 975
Local variable 'input' could be declared final965
Parameter 'maximumSeverity' is not assigned and could be declared final977
The method 'markupOfSeverity' has a Cyclomatic Complexity of 5.977 - 988
Parameter 'markup' is not assigned and could be declared final990
Parameter 'component' is not assigned and could be declared final990
Parameter 'facesContext' is not assigned and could be declared final994
Parameter 'container' is not assigned and could be declared final994
Local variable 'clientId' could be declared final996
Local variable 'ids' could be declared final997
Local variable 'id' could be declared final998
The method 'getMaximumSeverityOfChildrenMessages' has a Cyclomatic Complexity of 8.1007 - 1027
Parameter 'facesContext' is not assigned and could be declared final1008
Parameter 'container' is not assigned and could be declared final1008
Local variable 'clientId' could be declared final1010
Local variable 'ids' could be declared final1012
Local variable 'id' could be declared final1013
Local variable 'message' could be declared final1017
Parameter 'facesContext' is not assigned and could be declared final1029
Parameter 'container' is not assigned and could be declared final1029
Local variable 'clientIds' could be declared final1031
Local variable 'clientId' could be declared final1032
Local variable 'ids' could be declared final1033
Local variable 'id' could be declared final1034
Parameter 'component' is not assigned and could be declared final1048
Parameter 'name' is not assigned and could be declared final1048
Parameter 'value' is not assigned and could be declared final1048
Parameter 'component' is not assigned and could be declared final1060
Parameter 'name' is not assigned and could be declared final1060
Parameter 'value' is not assigned and could be declared final1060
Parameter 'component' is not assigned and could be declared final1069
The method 'invokeOnComponent' has a Cyclomatic Complexity of 7.1073 - 1098
Parameter 'component' is not assigned and could be declared final1074
Parameter 'context' is not assigned and could be declared final1074
Parameter 'callback' is not assigned and could be declared final1074
Parameter 'clientId' is not assigned and could be declared final1074
Local variable 'thisClientId' could be declared final1075
These nested if statements could be combined1087 - 1089
These nested if statements could be combined1087 - 1089
Parameter 'component' is not assigned and could be declared final1101
Parameter 'context' is not assigned and could be declared final1101
Parameter 'callback' is not assigned and could be declared final1101
Parameter 'clientId' is not assigned and could be declared final1101
Local variable 'it' could be declared final1102
Local variable 'child' could be declared final1103

Tobago Core - org/apache/myfaces/tobago/util/CreateComponentUtils.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.41 - 168
This class has too many methods, consider refactoring it.41 - 168
Parameter 'rendererType' is not assigned and could be declared final44
Parameter 'componentType' is not assigned and could be declared final44
Parameter 'rendererType' is not assigned and could be declared final48
Parameter 'componentType' is not assigned and could be declared final48
Parameter 'clientId' is not assigned and could be declared final48
Parameter 'rendererType' is not assigned and could be declared final54
Parameter 'facesContext' is not assigned and could be declared final54
Parameter 'componentType' is not assigned and could be declared final54
Parameter 'rendererType' is not assigned and could be declared final59
Parameter 'facesContext' is not assigned and could be declared final59
Parameter 'componentType' is not assigned and could be declared final59
Parameter 'clientId' is not assigned and could be declared final59
Local variable 'component' could be declared final60
Parameter 'sortable' is not assigned and could be declared final67
Parameter 'align' is not assigned and could be declared final67
Parameter 'value' is not assigned and could be declared final67
Parameter 'label' is not assigned and could be declared final67
Parameter 'sortable' is not assigned and could be declared final72
Parameter 'align' is not assigned and could be declared final72
Parameter 'value' is not assigned and could be declared final72
Parameter 'label' is not assigned and could be declared final72
Parameter 'clientId' is not assigned and could be declared final72
Local variable 'text' could be declared final73
Parameter 'child' is not assigned and could be declared final82
Parameter 'sortable' is not assigned and could be declared final82
Parameter 'align' is not assigned and could be declared final82
Parameter 'label' is not assigned and could be declared final82
Parameter 'child' is not assigned and could be declared final87
Parameter 'sortable' is not assigned and could be declared final87
Parameter 'align' is not assigned and could be declared final87
Parameter 'label' is not assigned and could be declared final87
Parameter 'clientId' is not assigned and could be declared final87
Local variable 'column' could be declared final88
Parameter 'sortable' is not assigned and could be declared final95
Parameter 'align' is not assigned and could be declared final95
Parameter 'label' is not assigned and could be declared final95
Parameter 'sortable' is not assigned and could be declared final99
Parameter 'align' is not assigned and could be declared final99
Parameter 'label' is not assigned and could be declared final99
Parameter 'clientId' is not assigned and could be declared final99
Local variable 'column' could be declared final100
Parameter 'facesContext' is not assigned and could be declared final108
Parameter 'command' is not assigned and could be declared final109
Parameter 'facesContext' is not assigned and could be declared final114
Parameter 'command' is not assigned and could be declared final114
Parameter 'clientId' is not assigned and could be declared final114
Local variable 'radio' could be declared final116 - 117
Avoid if (x != y) ..; else ..;121 - 125
Parameter 'facesContext' is not assigned and could be declared final130
Parameter 'command' is not assigned and could be declared final130
Parameter 'facesContext' is not assigned and could be declared final134
Parameter 'command' is not assigned and could be declared final135
Parameter 'facesContext' is not assigned and could be declared final139
Parameter 'command' is not assigned and could be declared final139
Parameter 'clientId' is not assigned and could be declared final140
Local variable 'checkbox' could be declared final141 - 142
Local variable 'valueBinding' could be declared final145
Avoid if (x != y) ..; else ..;146 - 151
Parameter 'rendererType' is not assigned and could be declared final156
Parameter 'facesContext' is not assigned and could be declared final156
Parameter 'parent' is not assigned and could be declared final156
Parameter 'componentType' is not assigned and could be declared final156
Local variable 'layoutManager' could be declared final158 - 159

Tobago Core - org/apache/myfaces/tobago/util/DebugActionListener.java

ViolationLine
Private field 'actionListener' could be made final; it is only initialized in the declaration or constructor.33
Parameter 'actionListener' is not assigned and could be declared final36
Parameter 'actionEvent' is not assigned and could be declared final40

Tobago Core - org/apache/myfaces/tobago/util/DebugNavigationHandler.java

ViolationLine
The class 'DebugNavigationHandler' has a Cyclomatic Complexity of 4 (Highest = 5).29 - 57
Private field 'navigationHandler' could be made final; it is only initialized in the declaration or constructor.33
Parameter 'navigationHandler' is not assigned and could be declared final35
Parameter 'fromAction' is not assigned and could be declared final39
Parameter 'facesContext' is not assigned and could be declared final39
Parameter 'outcome' is not assigned and could be declared final39
The method 'handleNavigation' has a Cyclomatic Complexity of 5.39 - 56

Tobago Core - org/apache/myfaces/tobago/util/DebugPhaseListener.java

ViolationLine
The class 'DebugPhaseListener' has a Cyclomatic Complexity of 8 (Highest = 14).38 - 144
The class 'DebugPhaseListener' has a Cyclomatic Complexity of 8 (Highest = 14).38 - 144
Parameter 'phaseEvent' is not assigned and could be declared final43
The method 'afterPhase' has a Cyclomatic Complexity of 9.43 - 88
Local variable 'end' could be declared final45
Local variable 'facesContext' could be declared final46
Local variable 'map' could be declared final47
Local variable 'start' could be declared final56 - 57
Deeply nested if..then statements are hard to read63 - 68
Local variable 'response' could be declared final64
Local variable 'start' could be declared final70
Deeply nested if..then statements are hard to read71 - 74
Local variable 'iter' could be declared final76
Local variable 'clientId' could be declared final77
Local variable 'msgIter' could be declared final79
Local variable 'msg' could be declared final80
Avoid instantiating new objects inside loops84
Parameter 'phaseEvent' is not assigned and could be declared final91
The method 'beforePhase' has a Cyclomatic Complexity of 14.91 - 139
The method 'beforePhase' has a Cyclomatic Complexity of 14.91 - 139
Local variable 'phaseId' could be declared final95
Local variable 'externalContext' could be declared final98
Deeply nested if..then statements are hard to read100 - 116
Local variable 'request' could be declared final103
Local variable 'servletRequest' could be declared final105
Local variable 'headerMap' could be declared final108
Local variable 'parameterMap' could be declared final112
Deeply nested if..then statements are hard to read129 - 132

Tobago Core - org/apache/myfaces/tobago/util/DebugUtils.java

ViolationLine
A class which only has private constructors should be final32 - 103
The class 'DebugUtils' has a Cyclomatic Complexity of 2 (Highest = 6).32 - 103
Parameter 'component' is not assigned and could be declared final38
Parameter 'offset' is not assigned and could be declared final38
Parameter 'asFacet' is not assigned and could be declared final42
Parameter 'component' is not assigned and could be declared final42
Parameter 'offset' is not assigned and could be declared final42
The method 'toString' has a Cyclomatic Complexity of 6.42 - 70
Local variable 'result' could be declared final43
Local variable 'facets' could be declared final52
Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty()53
Local variable 'facet' could be declared final55
Parameter 'component' is not assigned and could be declared final72
Local variable 'buf' could be declared final73
Parameter 'n' is not assigned and could be declared final89
Local variable 'buffer' could be declared final90
Parameter 'message' is not assigned and could be declared final97
Parameter 'facesContext' is not assigned and could be declared final97

Tobago Core - org/apache/myfaces/tobago/util/EncodeAjaxCallback.java

ViolationLine
The class 'EncodeAjaxCallback' has a Cyclomatic Complexity of 5 (Highest = 9).37 - 111
Parameter 'component' is not assigned and could be declared final39
Parameter 'facesContext' is not assigned and could be declared final39
The method 'invokeContextCallback' has a Cyclomatic Complexity of 9.39 - 68
Local variable 'reload' could be declared final41
Local variable 'immediate' could be declared final43
Local variable 'update' could be declared final45
Deeply nested if..then statements are hard to read46 - 48
Local variable 'layoutContainer' could be declared final53
Local variable 'width' could be declared final54
Local variable 'height' could be declared final55
Local variable 'oldWidth' could be declared final56
Local variable 'oldHeight' could be declared final57
Parameter 'component' is not assigned and could be declared final76
Parameter 'facesContext' is not assigned and could be declared final76
Parameter 'component' is not assigned and could be declared final91
Parameter 'facesContext' is not assigned and could be declared final91
The method 'prepareRendererAll' has a Cyclomatic Complexity of 5.91 - 110
Local variable 'renderer' could be declared final95
Local variable 'it' could be declared final104
Local variable 'child' could be declared final106

Tobago Core - org/apache/myfaces/tobago/util/FacesVersion.java

ViolationLine
Avoid empty catch blocks44 - 46
Avoid empty catch blocks44 - 46
Parameter 'className' is not assigned and could be declared final53
Avoid empty catch blocks63 - 65
Avoid empty catch blocks63 - 65
Avoid empty catch blocks67 - 69
Avoid empty catch blocks67 - 69

Tobago Core - org/apache/myfaces/tobago/util/FacetUtils.java

ViolationLine
A class which only has private constructors should be final30 - 56
Parameter 'component' is not assigned and could be declared final38
Parameter 'component' is not assigned and could be declared final42
Parameter 'menu' is not assigned and could be declared final42
Parameter 'component' is not assigned and could be declared final49
Parameter 'component' is not assigned and could be declared final53
Parameter 'menu' is not assigned and could be declared final53

Tobago Core - org/apache/myfaces/tobago/util/LayoutInfo.java

ViolationLine
The class 'LayoutInfo' has a Cyclomatic Complexity of 4 (Highest = 13).39 - 388
This class has too many methods, consider refactoring it.39 - 388
The class 'LayoutInfo' has a Cyclomatic Complexity of 4 (Highest = 13).39 - 388
Parameter 'layoutTokens' is not assigned and could be declared final52
Parameter 'space' is not assigned and could be declared final52
Parameter 'cellCount' is not assigned and could be declared final52
Parameter 'clientIdForLogging' is not assigned and could be declared final52
Parameter 'layoutTokens' is not assigned and could be declared final56
Parameter 'space' is not assigned and could be declared final56
Parameter 'cellCount' is not assigned and could be declared final56
The constructor 'LayoutInfo' has a Cyclomatic Complexity of 6.56 - 94
Parameter 'ignoreMismatch' is not assigned and could be declared final57
Parameter 'clientIdForLogging' is not assigned and could be declared final57
The String literal " clientId='" appears 17 times in this file; the first occurrence is on line 7272
Parameter 'initValue' is not assigned and could be declared final96
Parameter 'columns' is not assigned and could be declared final96
Parameter 'index' is not assigned and could be declared final103
Parameter 'space' is not assigned and could be declared final103
Avoid reassigning parameters such as 'space'107
Avoid reassigning parameters such as 'space'107
Parameter 'index' is not assigned and could be declared final107
Parameter 'force' is not assigned and could be declared final107
The method 'update' has a Cyclomatic Complexity of 10.107 - 142
The method 'update' has a Cyclomatic Complexity of 10.107 - 142
These nested if statements could be combined130 - 136
These nested if statements could be combined130 - 136
Parameter 'list' is not assigned and could be declared final162
Parameter 'tokens' is not assigned and could be declared final170
Parameter 'tokens' is not assigned and could be declared final178
Local variable 'sb' could be declared final179
Parameter 'column' is not assigned and could be declared final191
Local variable 'list' could be declared final208
The method 'handleSpaceLeft' has a Cyclomatic Complexity of 13.215 - 249
The method handleSpaceLeft() has an NPath complexity of 330215 - 249
The method 'handleSpaceLeft' has a Cyclomatic Complexity of 13.215 - 249
Parameter 'currentSpaces' is not assigned and could be declared final252
Local variable 'sb' could be declared final253
Parameter 'space' is not assigned and could be declared final262
Parameter 'i' is not assigned and could be declared final262
Parameter 'portions' is not assigned and could be declared final274
The method 'parsePortions' has a Cyclomatic Complexity of 9.274 - 302
These nested if statements could be combined278 - 300
These nested if statements could be combined278 - 300
Local variable 'widthForPortions' could be declared final279
Local variable 'token' could be declared final281
Local variable 'portion' could be declared final283
Local variable 'w' could be declared final284
The String literal " from " appears 5 times in this file; the first occurrence is on line 288288
The String literal "set column " appears 5 times in this file; the first occurrence is on line 288288
The String literal " to with " appears 4 times in this file; the first occurrence is on line 289289
Parameter 'space' is not assigned and could be declared final334
Parameter 'space' is not assigned and could be declared final338
Parameter 'padding' is not assigned and could be declared final338
The method 'parseColumnLayout' has a Cyclomatic Complexity of 12.338 - 378
The method 'parseColumnLayout' has a Cyclomatic Complexity of 12.338 - 378
Local variable 'token' could be declared final343
Local variable 'w' could be declared final352
Local variable 'percent' could be declared final361
Local variable 'w' could be declared final362

Tobago Core - org/apache/myfaces/tobago/util/LocaleUtils.java

ViolationLine
A class which only has private constructors should be final29 - 97
Parameter 'value' is not assigned and could be declared final34
Local variable 'strings' could be declared final36
Parameter 'locale' is not assigned and could be declared final57
Local variable 'locales' could be declared final60
Parameter 'locale' is not assigned and could be declared final76
Local variable 'prefix' could be declared final83
Local variable 'locales' could be declared final84

Tobago Core - org/apache/myfaces/tobago/util/MessageUtils.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.45 - 179
The class 'MessageUtils' has a Cyclomatic Complexity of 4 (Highest = 15).45 - 179
The class 'MessageUtils' has a Cyclomatic Complexity of 4 (Highest = 15).45 - 179
Parameter 'component' is not assigned and could be declared final52
Parameter 'facesContext' is not assigned and could be declared final52
Parameter 'severity' is not assigned and could be declared final52
Parameter 'args' is not assigned and could be declared final53
Parameter 'messageId' is not assigned and could be declared final53
The method 'getMessage' has a Cyclomatic Complexity of 15.58 - 105
The method getMessage() has an NPath complexity of 46858 - 105
The method 'getMessage' has a Cyclomatic Complexity of 15.58 - 105
Parameter 'facesContext' is not assigned and could be declared final59
Parameter 'locale' is not assigned and could be declared final59
Parameter 'args' is not assigned and could be declared final60
Parameter 'severity' is not assigned and could be declared final60
Parameter 'messageId' is not assigned and could be declared final60
Local variable 'appBundle' could be declared final62
Local variable 'tobagoBundle' could be declared final67
Local variable 'defBundle' could be declared final76
Deeply nested if..then statements are hard to read77 - 79
Deeply nested if..then statements are hard to read80 - 82
Parameter 'bundle' is not assigned and could be declared final107
Parameter 'key' is not assigned and could be declared final107
Parameter 'facesContext' is not assigned and could be declared final115
Parameter 'locale' is not assigned and could be declared final115
Local variable 'bundleName' could be declared final116
Avoid if (x != y) ..; else ..;117
Local variable 'clazz' could be declared final123
Local variable 'bundle' could be declared final124
The String literal "*********************************************************************************************" appears 6 times in this file; the first occurrence is on line 125125
Parameter 'facesContext' is not assigned and could be declared final139
Parameter 'locale' is not assigned and could be declared final139
Parameter 'facesContext' is not assigned and could be declared final143
Parameter 'locale' is not assigned and could be declared final143
Parameter 'bundleName' is not assigned and could be declared final143
Parameter 'component' is not assigned and could be declared final156
Parameter 'facesContext' is not assigned and could be declared final156
Local variable 'label' could be declared final157
Parameter 'message' is not assigned and could be declared final172
Parameter 'args' is not assigned and could be declared final172
Parameter 'locale' is not assigned and could be declared final172
Local variable 'format' could be declared final174

Tobago Core - org/apache/myfaces/tobago/util/ProcessValidationsCallback.java

ViolationLine
The class 'ProcessValidationsCallback' has a Cyclomatic Complexity of 5 (Highest = 4).28 - 41
Parameter 'component' is not assigned and could be declared final30
Parameter 'facesContext' is not assigned and could be declared final30

Tobago Core - org/apache/myfaces/tobago/util/RequestUtils.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.30 - 50
The class 'RequestUtils' has a Cyclomatic Complexity of 6 (Highest = 5).30 - 50
Parameter 'facesContext' is not assigned and could be declared final34
The method 'ensureEncoding' has a Cyclomatic Complexity of 5.34 - 49
Local variable 'requestObject' could be declared final35
Local variable 'request' could be declared final38
Do not add empty strings47

Tobago Core - org/apache/myfaces/tobago/util/UpdateModelValuesCallback.java

ViolationLine
The class 'UpdateModelValuesCallback' has a Cyclomatic Complexity of 5 (Highest = 4).28 - 41
Parameter 'component' is not assigned and could be declared final30
Parameter 'facesContext' is not assigned and could be declared final30

Tobago Core - org/apache/myfaces/tobago/util/ValueBindingComparator.java

ViolationLine
The class 'ValueBindingComparator' has a Cyclomatic Complexity of 3 (Highest = 11).34 - 132
The class 'ValueBindingComparator' has a Cyclomatic Complexity of 3 (Highest = 11).34 - 132
Private field 'facesContext' could be made final; it is only initialized in the declaration or constructor.38
Private field 'var' could be made final; it is only initialized in the declaration or constructor.40
Private field 'valueBinding' could be made final; it is only initialized in the declaration or constructor.42
Parameter 'facesContext' is not assigned and could be declared final44
Parameter 'var' is not assigned and could be declared final44
Parameter 'valueBinding' is not assigned and could be declared final44
Parameter 'reverse' is not assigned and could be declared final50
Parameter 'facesContext' is not assigned and could be declared final50
Parameter 'var' is not assigned and could be declared final50
Parameter 'valueBinding' is not assigned and could be declared final50
Parameter 'facesContext' is not assigned and could be declared final57
Parameter 'var' is not assigned and could be declared final57
Parameter 'comparator' is not assigned and could be declared final58
Parameter 'valueBinding' is not assigned and could be declared final58
Parameter 'facesContext' is not assigned and could be declared final65
Parameter 'var' is not assigned and could be declared final65
Parameter 'reverse' is not assigned and could be declared final66
Parameter 'comparator' is not assigned and could be declared final66
Parameter 'valueBinding' is not assigned and could be declared final66
Parameter 'o' is not assigned and could be declared final73
The method 'equals' has a Cyclomatic Complexity of 11.73 - 97
The method 'equals' has a Cyclomatic Complexity of 11.73 - 97
Avoid if (x != y) ..; else ..;86
Avoid if (x != y) ..; else ..;89
Avoid if (x != y) ..; else ..;92
Avoid if (x != y) ..; else ..;101
Avoid if (x != y) ..; else ..;102
Avoid if (x != y) ..; else ..;103
Parameter 'param1' is not assigned and could be declared final115
Parameter 'param2' is not assigned and could be declared final115

Tobago Core - org/apache/myfaces/tobago/util/ValueExpressionComparator.java

ViolationLine
The class 'ValueExpressionComparator' has a Cyclomatic Complexity of 3 (Highest = 11).30 - 128
The class 'ValueExpressionComparator' has a Cyclomatic Complexity of 3 (Highest = 11).30 - 128
Private field 'facesContext' could be made final; it is only initialized in the declaration or constructor.34
Private field 'var' could be made final; it is only initialized in the declaration or constructor.36
Private field 'valueExpression' could be made final; it is only initialized in the declaration or constructor.38
Parameter 'valueExpression' is not assigned and could be declared final40
Parameter 'facesContext' is not assigned and could be declared final40
Parameter 'var' is not assigned and could be declared final40
Parameter 'valueExpression' is not assigned and could be declared final46
Parameter 'facesContext' is not assigned and could be declared final46
Parameter 'var' is not assigned and could be declared final46
Parameter 'reverse' is not assigned and could be declared final47
Parameter 'facesContext' is not assigned and could be declared final54
Parameter 'var' is not assigned and could be declared final54
Parameter 'valueExpression' is not assigned and could be declared final55
Parameter 'comparator' is not assigned and could be declared final55
Parameter 'facesContext' is not assigned and could be declared final62
Parameter 'var' is not assigned and could be declared final62
Parameter 'reverse' is not assigned and could be declared final63
Parameter 'valueExpression' is not assigned and could be declared final63
Parameter 'comparator' is not assigned and could be declared final63
Parameter 'o' is not assigned and could be declared final70
The method 'equals' has a Cyclomatic Complexity of 11.70 - 94
The method 'equals' has a Cyclomatic Complexity of 11.70 - 94
Avoid if (x != y) ..; else ..;83
Avoid if (x != y) ..; else ..;86
Avoid if (x != y) ..; else ..;89
Avoid if (x != y) ..; else ..;98
Avoid if (x != y) ..; else ..;99
Avoid if (x != y) ..; else ..;100
Parameter 'param1' is not assigned and could be declared final112
Parameter 'param2' is not assigned and could be declared final112

Tobago Core - org/apache/myfaces/tobago/util/VariableResolverUtils.java

ViolationLine
Parameter 'context' is not assigned and could be declared final36
Parameter 'variable' is not assigned and could be declared final36
Parameter 'facesContext' is not assigned and could be declared final44
Parameter 'context' is not assigned and could be declared final54
Parameter 'variable' is not assigned and could be declared final54

Tobago Core - org/apache/myfaces/tobago/util/XmlUtils.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.38 - 165
The class 'XmlUtils' has a Cyclomatic Complexity of 4 (Highest = 8).38 - 165
Local variable 'len' could be declared final48
Local variable 'buffer' could be declared final49
Local variable 'buffer' could be declared final60
The method 'appendEntityRef' has a Cyclomatic Complexity of 8.67 - 98
Local variable 'propertiesElement' could be declared final110 - 111
Local variable 'factory' could be declared final117
Local variable 'builder' could be declared final123
Local variable 'source' could be declared final125
The method 'importProperties' has a Cyclomatic Complexity of 6.132 - 148
Local variable 'entries' could be declared final133
Local variable 'numEntries' could be declared final134
Local variable 'start' could be declared final135 - 136
Local variable 'child' could be declared final138
Local variable 'entry' could be declared final140
Local variable 'node' could be declared final142
Local variable 'value' could be declared final143
Local variable 'dtd' could be declared final154 - 158
Local variable 'inputSource' could be declared final159

Tobago Core - org/apache/myfaces/tobago/validator/ClearValidatorsActionListener.java

ViolationLine
The class 'ClearValidatorsActionListener' has a Cyclomatic Complexity of 5 (Highest = 8).34 - 83
Parameter 'actionEvent' is not assigned and could be declared final42
The method 'processAction' has a Cyclomatic Complexity of 8.42 - 81
Local variable 'source' could be declared final46
Local variable 'clearValidatorsFieldIds' could be declared final47 - 48
Local variable 'tokenizer' could be declared final56 - 57
Local variable 'clearValidatorsFieldId' could be declared final59
Local variable 'facesContext' could be declared final70

Tobago Core - org/apache/myfaces/tobago/validator/FileItemValidator.java

ViolationLine
The class 'FileItemValidator' has a Cyclomatic Complexity of 2 (Highest = 12).40 - 126
The class 'FileItemValidator' has a Cyclomatic Complexity of 2 (Highest = 12).40 - 126
Document empty constructor51 - 52
Avoid unnecessary constructors - the compiler will generate these for you51 - 52
Parameter 'component' is not assigned and could be declared final54
Parameter 'facesContext' is not assigned and could be declared final54
Parameter 'value' is not assigned and could be declared final54
The method 'validate' has a Cyclomatic Complexity of 12.54 - 86
The method 'validate' has a Cyclomatic Complexity of 12.54 - 86
Local variable 'file' could be declared final56
Local variable 'facesMessage' could be declared final58 - 60
Deeply nested if..then statements are hard to read67 - 70
Deeply nested if..then statements are hard to read74 - 78
Local variable 'facesMessage' could be declared final79 - 81
Parameter 'maxSize' is not assigned and could be declared final92
Parameter 'contentType' is not assigned and could be declared final102
Parameter 'context' is not assigned and could be declared final106
Parameter 'context' is not assigned and could be declared final113
Parameter 'state' is not assigned and could be declared final113
Local variable 'values' could be declared final114
Parameter 'newTransientValue' is not assigned and could be declared final123

Tobago Core - org/apache/myfaces/tobago/validator/SubmittedValueLengthValidator.java

ViolationLine
The class 'SubmittedValueLengthValidator' has a Cyclomatic Complexity of 3 (Highest = 9).38 - 136
Document empty constructor44 - 45
Parameter 'maximum' is not assigned and could be declared final47
Overridable method 'setMaximum' called during object construction48
Parameter 'minimum' is not assigned and could be declared final51
Parameter 'maximum' is not assigned and could be declared final51
Overridable method 'setMaximum' called during object construction52
Overridable method 'setMinimum' called during object construction53
Avoid if (x != y) ..; else ..;57
Parameter 'minimum' is not assigned and could be declared final60
Avoid if (x != y) ..; else ..;67
Parameter 'maximum' is not assigned and could be declared final70
Parameter 'facesContext' is not assigned and could be declared final76
Parameter 'value' is not assigned and could be declared final76
Parameter 'uiComponent' is not assigned and could be declared final76
The method 'validate' has a Cyclomatic Complexity of 7.76 - 92
Local variable 'submittedValue' could be declared final78
Local variable 'args' could be declared final80
Local variable 'facesMessage' could be declared final81 - 82
Local variable 'args' could be declared final86
Local variable 'facesMessage' could be declared final87 - 88
Parameter 'context' is not assigned and could be declared final94
Parameter 'context' is not assigned and could be declared final101
Parameter 'state' is not assigned and could be declared final101
Local variable 'values' could be declared final102
Parameter 'o' is not assigned and could be declared final107
The method 'equals' has a Cyclomatic Complexity of 9.107 - 128
Local variable 'validator' could be declared final118
Avoid if (x != y) ..; else ..;120
Avoid if (x != y) ..; else ..;123
Avoid if (x != y) ..; else ..;132
Avoid if (x != y) ..; else ..;133

Tobago Core - org/apache/myfaces/tobago/webapp/LogoutActionListener.java

ViolationLine
The class 'LogoutActionListener' has a Cyclomatic Complexity of 5 (Highest = 4).34 - 59
Parameter 'event' is not assigned and could be declared final38
Local variable 'facesContext' could be declared final39
Local variable 'externalContext' could be declared final40
Local variable 'session' could be declared final41
These nested if statements could be combined43 - 45
These nested if statements could be combined43 - 45
Local variable 'forward' could be declared final48
New exception is thrown in catch block, original stack trace may be lost54

Tobago Core - org/apache/myfaces/tobago/webapp/Secret.java

ViolationLine
A class which only has private constructors should be final34 - 108
Private field 'secret' could be made final; it is only initialized in the declaration or constructor.55
Local variable 'bytes' could be declared final58
Parameter 'bytes' is not assigned and could be declared final63
Parameter 'bytes' is not assigned and could be declared final67
Local variable 'builder' could be declared final68
Parameter 'facesContext' is not assigned and could be declared final79
Local variable 'requestParameterMap' could be declared final80
Local variable 'fromRequest' could be declared final81
Local variable 'sessionMap' could be declared final82
Local variable 'secret' could be declared final83
Parameter 'facesContext' is not assigned and could be declared final90
Parameter 'writer' is not assigned and could be declared final90
Local variable 'sessionMap' could be declared final95
Local variable 'secret' could be declared final96
Parameter 'session' is not assigned and could be declared final105

Tobago Core - org/apache/myfaces/tobago/webapp/SecretSessionListener.java

ViolationLine
Parameter 'sessionEvent' is not assigned and could be declared final29
Document empty method36 - 37
Parameter 'se' is not assigned and could be declared final36

Tobago Core - org/apache/myfaces/tobago/webapp/TobagoMultipartFormdataFilter.java

ViolationLine
The class 'TobagoMultipartFormdataFilter' has a Cyclomatic Complexity of 4 (Highest = 6).69 - 130
Parameter 'filterConfig' is not assigned and could be declared final76
The method 'init' has a Cyclomatic Complexity of 5.76 - 96
Local variable 'repositoryPath' could be declared final77
Local variable 'file' could be declared final79
Avoid if (x != y) ..; else ..;80 - 86
Avoid if (x != y) ..; else ..;82 - 86
Parameter 'response' is not assigned and could be declared final98
Parameter 'chain' is not assigned and could be declared final98
Parameter 'request' is not assigned and could be declared final98
The method 'doFilter' has a Cyclomatic Complexity of 6.98 - 125
Local variable 'contentType' could be declared final105
Document empty method127 - 128

Tobago Core - org/apache/myfaces/tobago/webapp/TobagoResponseWriter.java

ViolationLine
The class 'TobagoResponseWriter' has a Cyclomatic Complexity of 1 (Highest = 5).41 - 281
This class has too many methods, consider refactoring it.41 - 281
Parameter 'name' is not assigned and could be declared final52
Parameter 'name' is not assigned and could be declared final93
Parameter 'on' is not assigned and could be declared final93
Parameter 'name' is not assigned and could be declared final102
Parameter 'number' is not assigned and could be declared final102
Parameter 'name' is not assigned and could be declared final109
Parameter 'property' is not assigned and could be declared final109
Parameter 'id' is not assigned and could be declared final116
Parameter 'name' is not assigned and could be declared final123
Parameter 'cssClass' is not assigned and could be declared final132
Parameter 'styleClasses' is not assigned and could be declared final141
Parameter 'classes' is not assigned and could be declared final153
Local variable 'styleClasses' could be declared final154
Prefer StringBuffer over += for concatenating strings157
Parameter 'style' is not assigned and could be declared final189
The method 'writeStyleAttribute' has a Cyclomatic Complexity of 5.189 - 222
Parameter 'style' is not assigned and could be declared final229
Parameter 'script' is not assigned and could be declared final233
Parameter 'text' is not assigned and could be declared final254
Parameter 'property' is not assigned and could be declared final261
Local variable 'builder' could be declared final275

Tobago Core - org/apache/myfaces/tobago/webapp/TobagoServletContextListener.java

ViolationLine
Parameter 'event' is not assigned and could be declared final36
Local variable 'servletContext' could be declared final42
Parameter 'event' is not assigned and could be declared final55
Local variable 'servletContext' could be declared final61

Tobago Core - org/apache/myfaces/tobago/webapp/WeblogicWorkaroundServlet.java

ViolationLine
The class 'WeblogicWorkaroundServlet' has a Cyclomatic Complexity of 6 (Highest = 8).41 - 94
The method 'init' has a Cyclomatic Complexity of 8.47 - 79
Local variable 'factory' could be declared final51 - 52
Local variable 'tobagoConfig' could be declared final65 - 66
Parameter 'className' is not assigned and could be declared final81
Local variable 'aClass' could be declared final83
Local variable 'listener' could be declared final84

Tobago Deprecation - org/apache/myfaces/tobago/ajax/api/AjaxUtils.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.36 - 155
This class has too many methods, consider refactoring it.36 - 155
Parameter 'facesContext' is not assigned and could be declared final48
Parameter 'compClass' is not assigned and could be declared final48
Parameter 'uiComponent' is not assigned and could be declared final48
Parameter 'component' is not assigned and could be declared final56
Parameter 'facesContext' is not assigned and could be declared final56
Parameter 'facesContext' is not assigned and could be declared final64
Parameter 'facesContext' is not assigned and could be declared final72
Parameter 'facesContext' is not assigned and could be declared final80
Parameter 'facesContext' is not assigned and could be declared final88
Parameter 'clientId' is not assigned and could be declared final88
Parameter 'facesContext' is not assigned and could be declared final96
Parameter 'clientId' is not assigned and could be declared final96
Parameter 'component' is not assigned and could be declared final104
Parameter 'facesContext' is not assigned and could be declared final104
Parameter 'facesContext' is not assigned and could be declared final112
Parameter 'clientId' is not assigned and could be declared final112
Parameter 'component' is not assigned and could be declared final120
Parameter 'facesContext' is not assigned and could be declared final120
Parameter 'value' is not assigned and could be declared final128
Parameter 'facesContext' is not assigned and could be declared final136
Parameter 'url' is not assigned and could be declared final136
Parameter 'response' is not assigned and could be declared final144
Parameter 'url' is not assigned and could be declared final144
Parameter 'context' is not assigned and could be declared final152

Tobago Deprecation - org/apache/myfaces/tobago/bean/ResourceMap.java

ViolationLine
The class 'ResourceMap' has a Cyclomatic Complexity of 4 (Highest = 6).33 - 90
Parameter 'filename' is not assigned and could be declared final44
The method 'setFilename' has a Cyclomatic Complexity of 6.44 - 63
Local variable 'is' could be declared final49
Parameter 'value' is not assigned and could be declared final69
Parameter 'key' is not assigned and could be declared final69
Parameter 'key' is not assigned and could be declared final80
Local variable 'value' could be declared final81

Tobago Deprecation - org/apache/myfaces/tobago/component/ComponentUtil.java

ViolationLine
This class has a bunch of public methods and attributes20 - 421
A class which only has private constructors should be final56 - 421
This class has too many methods, consider refactoring it.56 - 421
Parameter 'context' is not assigned and could be declared final66
Parameter 'command' is not assigned and could be declared final70
Parameter 'component' is not assigned and could be declared final74
Parameter 'facesContext' is not assigned and could be declared final74
Parameter 'component' is not assigned and could be declared final78
Parameter 'context' is not assigned and could be declared final82
Parameter 'component' is not assigned and could be declared final86
Parameter 'context' is not assigned and could be declared final86
Parameter 'component' is not assigned and could be declared final90
Parameter 'component' is not assigned and could be declared final94
Parameter 'styles' is not assigned and could be declared final94
Parameter 'scripts' is not assigned and could be declared final98
Parameter 'component' is not assigned and could be declared final98
Parameter 'cmds' is not assigned and could be declared final102
Parameter 'component' is not assigned and could be declared final102
Parameter 'facesContext' is not assigned and could be declared final106
Parameter 'component' is not assigned and could be declared final110
Parameter 'component' is not assigned and could be declared final114
Parameter 'component' is not assigned and could be declared final118
Parameter 'type' is not assigned and could be declared final118
Parameter 'component' is not assigned and could be declared final122
Parameter 'facesContext' is not assigned and could be declared final122
Parameter 'component' is not assigned and could be declared final126
Parameter 'component' is not assigned and could be declared final130
Parameter 'uiInput' is not assigned and could be declared final134
Parameter 'component' is not assigned and could be declared final138
Parameter 'component' is not assigned and could be declared final142
Parameter 'component' is not assigned and could be declared final146
Parameter 'component' is not assigned and could be declared final150
Parameter 'component' is not assigned and could be declared final154
Parameter 'name' is not assigned and could be declared final154
Parameter 'renderers' is not assigned and could be declared final158
Parameter 'command' is not assigned and could be declared final158
Parameter 'styleClasses' is not assigned and could be declared final162
Parameter 'component' is not assigned and could be declared final162
Parameter 'markup' is not assigned and could be declared final166
Parameter 'markupComponent' is not assigned and could be declared final166
Parameter 'component' is not assigned and could be declared final170
Parameter 'name' is not assigned and could be declared final170
Parameter 'component' is not assigned and could be declared final174
Parameter 'name' is not assigned and could be declared final174
Parameter 'component' is not assigned and could be dec