PMD Results

The following document contains the results of PMD 5.6.1.

Files

Tobago Core - org/apache/myfaces/tobago/component/Attributes.java

Violation Line
Avoid if (x != y) ..; else ..; 405409

Tobago Core - org/apache/myfaces/tobago/component/Sorter.java

Violation Line
Possible God class (WMC=51, ATFD=25, TCC=0.2) 20259
The class 'Sorter' has a Cyclomatic Complexity of 8 (Highest = 30). 49258
The class 'Sorter' has a Standard Cyclomatic Complexity of 6 (Highest = 28). 49258
The class 'Sorter' has a Modified Cyclomatic Complexity of 6 (Highest = 28). 49258
The method perform() has an NPath complexity of 139872 64201
The method 'perform' has a Cyclomatic Complexity of 30. 64201
Avoid really long methods. 64201
The method 'perform' has a Standard Cyclomatic Complexity of 28. 64201
The method 'perform' has a Modified Cyclomatic Complexity of 28. 64201
Avoid if (x != y) ..; else ..; 96137
Avoid if (x != y) ..; else ..; 99132
Avoid if (x != y) ..; else ..; 199
The method 'getFirstSortableChild' has a Cyclomatic Complexity of 13. 224249

Tobago Core - org/apache/myfaces/tobago/config/TobagoConfig.java

Violation Line
Class contains multiple getInstance methods. Please review. 4143

Tobago Core - org/apache/myfaces/tobago/context/Markup.java

Violation Line
This class has too many methods, consider refactoring it. 55489
The class 'Markup' has a Standard Cyclomatic Complexity of 5 (Highest = 10). 55489
The class 'Markup' has a Cyclomatic Complexity of 5 (Highest = 11). 55489
The class 'Markup' has a Modified Cyclomatic Complexity of 5 (Highest = 10). 55489
Consider using varargs for methods or constructors which take an array the last parameter. 220
Consider using varargs for methods or constructors which take an array the last parameter. 230
Avoid if (x != y) ..; else ..; 290
Avoid unnecessary if..then..else statements when returning booleans 293295
Avoid if (x != y) ..; else ..; 302
Avoid if (x != y) ..; else ..; 303
Use equals() to compare object references. 326
Avoid if (x != y) ..; else ..; 329343
Avoid if (x != y) ..; else ..; 373387
The method 'contains' has a Cyclomatic Complexity of 11. 439469
The method 'contains' has a Modified Cyclomatic Complexity of 10. 439469
The method 'contains' has a Standard Cyclomatic Complexity of 10. 439469
Use equals() to compare object references. 440
Avoid if (x != y) ..; else ..; 446468
Avoid if (x != y) ..; else ..; 447456
Avoid if (x != y) ..; else ..; 458467

Tobago Core - org/apache/myfaces/tobago/context/MarkupConfig.java

Violation Line
Private field 'markups' could be made final; it is only initialized in the declaration or constructor. 30

Tobago Core - org/apache/myfaces/tobago/context/ThemeImpl.java

Violation Line
The class 'ThemeImpl' has a Cyclomatic Complexity of 2 (Highest = 10). 30253
The class 'ThemeImpl' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 30253
The class 'ThemeImpl' has a Modified Cyclomatic Complexity of 2 (Highest = 10). 30253
Private field 'productionResources' could be made final; it is only initialized in the declaration or constructor. 41
Private field 'resources' could be made final; it is only initialized in the declaration or constructor. 42
Avoid using redundant field initializer for 'unmodifiable' 50
The method 'toString' has a Standard Cyclomatic Complexity of 10. 219252
The method 'toString' has a Modified Cyclomatic Complexity of 10. 219252
The method 'toString' has a Cyclomatic Complexity of 10. 219252
StringBuffer constructor is initialized with size 16, but has at least 110 characters appended. 220
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 221
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 222
Avoid if (x != y) ..; else ..; 224230
Avoid appending characters as strings in StringBuffer.append. 225
Avoid appending characters as strings in StringBuffer.append. 227
Avoid if (x != y) ..; else ..; 232
Avoid appending characters as strings in StringBuffer.append. 233
Avoid if (x != y) ..; else ..; 237
Avoid appending characters as strings in StringBuffer.append. 238
Avoid if (x != y) ..; else ..; 242
Avoid appending characters as strings in StringBuffer.append. 243
Avoid if (x != y) ..; else ..; 247
Avoid appending characters as strings in StringBuffer.append. 248

Tobago Core - org/apache/myfaces/tobago/context/ThemeResource.java

Violation Line
Avoid if (x != y) ..; else ..; 50
Avoid if (x != y) ..; else ..; 56

Tobago Core - org/apache/myfaces/tobago/context/TobagoBundle.java

Violation Line
Private field 'bundleName' could be made final; it is only initialized in the declaration or constructor. 49
Private field 'bundle' could be made final; it is only initialized in the declaration or constructor. 50
Private field 'props' could be made final; it is only initialized in the declaration or constructor. 78
Avoid autogenerated methods to access private fields and methods of inner / outer classes 100
Avoid declaring a variable if it is unreferenced before a possible exit point. 113
Avoid autogenerated methods to access private fields and methods of inner / outer classes 114
Avoid instantiation through private constructors from outside of the constructors class. 132

Tobago Core - org/apache/myfaces/tobago/context/TobagoMessageBundle.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3144

Tobago Core - org/apache/myfaces/tobago/context/TobagoResourceBundle.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2941

Tobago Core - org/apache/myfaces/tobago/context/TransientStateHolder.java

Violation Line
Document empty constructor 3334

Tobago Core - org/apache/myfaces/tobago/context/UserAgent.java

Violation Line
The class 'UserAgent' has a Standard Cyclomatic Complexity of 3 (Highest = 19). 33390
The class 'UserAgent' has a Modified Cyclomatic Complexity of 3 (Highest = 19). 33390
The class 'UserAgent' has a Cyclomatic Complexity of 3 (Highest = 20). 33390
The String literal "msie" appears 12 times in this file; the first occurrence is on line 39 39
The String literal "opera" appears 4 times in this file; the first occurrence is on line 103 103
The String literal "mozilla" appears 4 times in this file; the first occurrence is on line 127 127
The String literal "gecko" appears 5 times in this file; the first occurrence is on line 150 150
The method 'getInstance' has a Standard Cyclomatic Complexity of 19. 279334
The method 'getInstance' has a Modified Cyclomatic Complexity of 19. 279334
The method 'getInstance' has a Cyclomatic Complexity of 20. 279334
Avoid if (x != y) ..; else ..; 350352
Consider using varargs for methods or constructors which take an array the last parameter. 364
Consider using varargs for methods or constructors which take an array the last parameter. 382

Tobago Core - org/apache/myfaces/tobago/convert/DurationConverter.java

Violation Line
Unnecessary wrapper object creation 65
Avoid declaring a variable if it is unreferenced before a possible exit point. 89
The default label should be the last label in a switch statement 129145

Tobago Core - org/apache/myfaces/tobago/el/ConstantMethodExpression.java

Violation Line
Document empty constructor 3536
Avoid if (x != y) ..; else ..; 65

Tobago Core - org/apache/myfaces/tobago/el/UserWrapper.java

Violation Line
Private field 'roles' could be made final; it is only initialized in the declaration or constructor. 35
Avoid autogenerated methods to access private fields and methods of inner / outer classes 61
Avoid autogenerated methods to access private fields and methods of inner / outer classes 62

Tobago Core - org/apache/myfaces/tobago/event/FacesEventWrapper.java

Violation Line
Private field 'wrappedFacesEvent' could be made final; it is only initialized in the declaration or constructor. 31

Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionStateChangeListener.java

Violation Line
Avoid using redundant field initializer for 'isTransient' 33
Document empty constructor 3536

Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTabChangeListener.java

Violation Line
Avoid using redundant field initializer for 'isTransient' 33
Document empty constructor 3536

Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.java

Violation Line
Avoid using redundant field initializer for 'isTransient' 34
Document empty constructor 3637
Avoid unused private methods such as 'elContext()'. 48

Tobago Core - org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.java

Violation Line
Avoid using redundant field initializer for 'isTransient' 33
Document empty constructor 3536
Avoid unused private methods such as 'elContext()'. 47

Tobago Core - org/apache/myfaces/tobago/event/PageActionEvent.java

Violation Line
Private field 'action' could be made final; it is only initialized in the declaration or constructor. 31

Tobago Core - org/apache/myfaces/tobago/event/ResetInputActionListener.java

Violation Line
Document empty constructor 3435
Consider using varargs for methods or constructors which take an array the last parameter. 37

Tobago Core - org/apache/myfaces/tobago/event/SortActionEvent.java

Violation Line
Private field 'column' could be made final; it is only initialized in the declaration or constructor. 31

Tobago Core - org/apache/myfaces/tobago/event/TabChangeEvent.java

Violation Line
Overridable method 'setOldState' called during object construction 45
Overridable method 'setNewState' called during object construction 46

Tobago Core - org/apache/myfaces/tobago/event/TobagoActionSource.java

Violation Line
The String literal "JSF 1.1 style is no longer supported!" appears 4 times in this file; the first occurrence is on line 38 38

Tobago Core - org/apache/myfaces/tobago/event/TreeExpansionEvent.java

Violation Line
Private field 'oldExpanded' could be made final; it is only initialized in the declaration or constructor. 30
Private field 'newExpanded' could be made final; it is only initialized in the declaration or constructor. 31

Tobago Core - org/apache/myfaces/tobago/event/TreeSelectedEvent.java

Violation Line
Private field 'oldSelected' could be made final; it is only initialized in the declaration or constructor. 30
Private field 'newSelected' could be made final; it is only initialized in the declaration or constructor. 31

Tobago Core - org/apache/myfaces/tobago/event/ValueExpressionResetInputActionListener.java

Violation Line
Document empty constructor 4445

Tobago Core - org/apache/myfaces/tobago/event/ValueExpressionSheetStateChangeListener.java

Violation Line
Document empty constructor 3738
Avoid if (x != y) ..; else ..; 4852
No need to check for null before an instanceof 85

Tobago Core - org/apache/myfaces/tobago/event/ValueExpressionTabChangeListener.java

Violation Line
Document empty constructor 3738
Avoid if (x != y) ..; else ..; 4852
No need to check for null before an instanceof 85

Tobago Core - org/apache/myfaces/tobago/exception/TobagoConfigurationException.java

Violation Line
Parameter 'message' is not assigned and could be declared final 27
Parameter 'message' is not assigned and could be declared final 31
Parameter 'cause' is not assigned and could be declared final 31
Parameter 'cause' is not assigned and could be declared final 35

Tobago Core - org/apache/myfaces/tobago/exception/TobagoException.java

Violation Line
Parameter 'message' is not assigned and could be declared final 27
Parameter 'message' is not assigned and could be declared final 31
Parameter 'cause' is not assigned and could be declared final 31
Parameter 'cause' is not assigned and could be declared final 35

Tobago Core - org/apache/myfaces/tobago/facelets/AttributeHandler.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20353
Possible God class (WMC=77, ATFD=82, TCC=0.027777777777777776) 20353
The class 'AttributeHandler' has a Cyclomatic Complexity of 7 (Highest = 57). 54353
The class 'AttributeHandler' has a Standard Cyclomatic Complexity of 6 (Highest = 50). 54353
The class 'AttributeHandler' has a Modified Cyclomatic Complexity of 6 (Highest = 50). 54353
Avoid really long methods. 72271
The method 'apply' has a Cyclomatic Complexity of 57. 72271
The method 'apply' has a Modified Cyclomatic Complexity of 50. 72271
The method 'apply' has a Standard Cyclomatic Complexity of 50. 72271
The method apply() has an NCSS line count of 158 72271
Avoid if (x != y) ..; else ..; 79269
Avoid if (x != y) ..; else ..; 83101
Avoid if (x != y) ..; else ..; 106124
Avoid if (x != y) ..; else ..; 192199
Avoid if (x != y) ..; else ..; 260268
Consider using varargs for methods or constructors which take an array the last parameter. 295
Avoid if (x != y) ..; else ..; 301307

Tobago Core - org/apache/myfaces/tobago/facelets/ConverterHandler.java

Violation Line
Avoid declaring a variable if it is unreferenced before a possible exit point. 54
New exception is thrown in catch block, original stack trace may be lost 66
Deeply nested if..then statements are hard to read 6870

Tobago Core - org/apache/myfaces/tobago/facelets/EventHandler.java

Violation Line
Avoid unused local variables such as 'faceletContext'. 141
Avoid declaring a variable if it is unreferenced before a possible exit point. 141142
Document empty constructor 212213

Tobago Core - org/apache/myfaces/tobago/facelets/FixCharacterEncodingFilter.java

Violation Line
Document empty method body 5758

Tobago Core - org/apache/myfaces/tobago/facelets/GridLayoutConstraintHandler.java

Violation Line
Avoid if (x != y) ..; else ..; 47
Avoid if (x != y) ..; else ..; 51

Tobago Core - org/apache/myfaces/tobago/facelets/Resource.java

Violation Line
These nested if statements could be combined 7274
Document empty method body 110111
Avoid autogenerated methods to access private fields and methods of inner / outer classes 115
Avoid autogenerated methods to access private fields and methods of inner / outer classes 116
Avoid if (x != y) ..; else ..; 132

Tobago Core - org/apache/myfaces/tobago/facelets/SheetStateChangeSourceRule.java

Violation Line
These nested if statements could be combined 4042

Tobago Core - org/apache/myfaces/tobago/facelets/SortActionSourceRule.java

Violation Line
These nested if statements could be combined 4143

Tobago Core - org/apache/myfaces/tobago/facelets/SuggestMethodRule.java

Violation Line
These nested if statements could be combined 4244
These nested if statements could be combined 4751
Deeply nested if..then statements are hard to read 4850
These nested if statements could be combined 4850

Tobago Core - org/apache/myfaces/tobago/facelets/TabChangeListenerHandler.java

Violation Line
Avoid declaring a variable if it is unreferenced before a possible exit point. 66
Deeply nested if..then statements are hard to read 7981
Avoid if (x != y) ..; else ..; 8388

Tobago Core - org/apache/myfaces/tobago/facelets/TabChangeSourceRule.java

Violation Line
These nested if statements could be combined 3840

Tobago Core - org/apache/myfaces/tobago/facelets/TagMethodExpression.java

Violation Line
New exception is thrown in catch block, original stack trace may be lost 64
New exception is thrown in catch block, original stack trace may be lost 66
New exception is thrown in catch block, original stack trace may be lost 68
New exception is thrown in catch block, original stack trace may be lost 77
New exception is thrown in catch block, original stack trace may be lost 79
New exception is thrown in catch block, original stack trace may be lost 81

Tobago Core - org/apache/myfaces/tobago/internal/behavior/AttachedListStateWrapper.java

Violation Line
Private field 'wrappedStateList' could be made final; it is only initialized in the declaration or constructor. 34

Tobago Core - org/apache/myfaces/tobago/internal/behavior/AttachedStateWrapper.java

Violation Line
Private field 'clazz' could be made final; it is only initialized in the declaration or constructor. 30
Private field 'wrappedStateObject' could be made final; it is only initialized in the declaration or constructor. 31

Tobago Core - org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.java

Violation Line
Possible God class (WMC=101, ATFD=34, TCC=0.008333333333333333) 20786
The class 'DeltaStateHelper' has a Modified Cyclomatic Complexity of 4 (Highest = 11). 149786
This class has too many methods, consider refactoring it. 149786
The class 'DeltaStateHelper' has a Cyclomatic Complexity of 4 (Highest = 12). 149786
The class 'DeltaStateHelper' has a Standard Cyclomatic Complexity of 4 (Highest = 11). 149786
Private field 'target' could be made final; it is only initialized in the declaration or constructor. 157
Private field 'fullState' could be made final; it is only initialized in the declaration or constructor. 162
Avoid using redundant field initializer for 'transientBoolean' 175
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 448
The method 'restoreState' has a Modified Cyclomatic Complexity of 11. 528582
The method 'restoreState' has a Cyclomatic Complexity of 12. 528582
The method 'restoreState' has a Standard Cyclomatic Complexity of 11. 528582
Avoid autogenerated methods to access private fields and methods of inner / outer classes 635
Document empty method body 686687
Avoid autogenerated methods to access private fields and methods of inner / outer classes 695
Avoid autogenerated methods to access private fields and methods of inner / outer classes 706

Tobago Core - org/apache/myfaces/tobago/internal/behavior/EventBehavior.java

Violation Line
Possible God class (WMC=48, ATFD=8, TCC=0.03260869565217391) 20315
Avoid using redundant field initializer for 'stateHelper' 74
Avoid if (x != y) ..; else ..; 138142
Ternary operators that can be simplified with || or && 170
Ternary operators that can be simplified with || or && 180

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIBar.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2526

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIButton.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2527

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIButtons.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2526

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUICollapsiblePanel.java

Violation Line
Avoid if (x != y) ..; else ..; 9195

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIColumnNode.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2930

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIColumnSelector.java

Violation Line
An empty method in an abstract class should be abstract instead 3537

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUICommand.java

Violation Line
Avoid unused private fields such as 'LOG'. 42

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUICommandBase.java

Violation Line
Avoid instantiating new objects inside loops 55

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIData.java

Violation Line
Possible God class (WMC=47, ATFD=11, TCC=0.12554112554112554) 20317
The String literal "Not a tree model" appears 4 times in this file; the first occurrence is on line 77 77
Avoid if (x != y) ..; else ..; 8690
Avoid if (x != y) ..; else ..; 153157
Avoid if (x != y) ..; else ..; 162
Avoid if (x != y) ..; else ..; 167
String.indexOf(char) is faster than String.indexOf(String). 208
Local variable 'childCount' could be declared final 297
These nested if statements could be combined 300302

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIFlexLayout.java

Violation Line
The class 'AbstractUIFlexLayout' has a Standard Cyclomatic Complexity of 4 (Highest = 12). 41104
The class 'AbstractUIFlexLayout' has a Modified Cyclomatic Complexity of 4 (Highest = 12). 41104
The class 'AbstractUIFlexLayout' has a Cyclomatic Complexity of 4 (Highest = 12). 41104
The method 'processEvent' has a Cyclomatic Complexity of 12. 4695
The method 'processEvent' has a Standard Cyclomatic Complexity of 12. 4695
The method 'processEvent' has a Modified Cyclomatic Complexity of 12. 4695
Deeply nested if..then statements are hard to read 7789

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIFlowLayout.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2730

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIGridLayout.java

Violation Line
The class 'AbstractUIGridLayout' has a Modified Cyclomatic Complexity of 4 (Highest = 17). 54249
The class 'AbstractUIGridLayout' has a Cyclomatic Complexity of 5 (Highest = 19). 54249
The class 'AbstractUIGridLayout' has a Standard Cyclomatic Complexity of 4 (Highest = 17). 54249
The method 'layout' has a Standard Cyclomatic Complexity of 17. 93187
The method layout() has an NPath complexity of 648 93187
The method 'layout' has a Cyclomatic Complexity of 19. 93187
The method 'layout' has a Modified Cyclomatic Complexity of 17. 93187
Avoid if (x != y) ..; else ..; 107131
Avoid if (x != y) ..; else ..; 125131

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIIn.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2527

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUILabel.java

Violation Line
Avoid if (x != y) ..; else ..; 3642
Avoid if (x != y) ..; else ..; 3842

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUILayoutBase.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2728

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUILinks.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2526

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIMessages.java

Violation Line
Avoid if (x != y) ..; else ..; 4347
Avoid declaring a variable if it is unreferenced before a possible exit point. 65
Avoid instantiating new objects inside loops 75

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIObject.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2930

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIPage.java

Violation Line
The class 'AbstractUIPage' has a Cyclomatic Complexity of 4 (Highest = 11). 36129
The method 'markSubmittedForm' has a Cyclomatic Complexity of 11. 72128
Avoid if (x != y) ..; else ..; 8390
Avoid if (x != y) ..; else ..; 114127

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIPanel.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2728

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIPopup.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2729

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIProgress.java

Violation Line
Avoid unused private fields such as 'LOG'. 42
Do not add empty strings 75
Avoid if (x != y) ..; else ..; 7781

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIRow.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2728

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISection.java

Violation Line
Avoid if (x != y) ..; else ..; 6266

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectBooleanCheckbox.java

Violation Line
These nested if statements could be combined 5764

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectItem.java

Violation Line
Consider simply returning the value vs storing it in local variable 'converted' 57

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISelectOneBase.java

Violation Line
Avoid if (x != y) ..; else ..; 4451

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISeparator.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2930

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISheet.java

Violation Line
Possible God class (WMC=122, ATFD=39, TCC=0.014396456256921373) 20575
A high number of imports can indicate a high degree of coupling within an object. 20575
The class 'AbstractUISheet' has a Cyclomatic Complexity of 3 (Highest = 19). 66575
The class 'AbstractUISheet' has a Modified Cyclomatic Complexity of 2 (Highest = 12). 66575
The class 'AbstractUISheet' has a Standard Cyclomatic Complexity of 3 (Highest = 17). 66575
This class has too many methods, consider refactoring it. 68575
Avoid if (x != y) ..; else ..; 8892
Avoid if (x != y) ..; else ..; 269273
Avoid if (x != y) ..; else ..; 279287
Avoid if (x != y) ..; else ..; 301309
Avoid if (x != y) ..; else ..; 308
Avoid if (x != y) ..; else ..; 319
Avoid instantiating new objects inside loops 423
Avoid if (x != y) ..; else ..; 433446
Avoid if (x != y) ..; else ..; 437440
The method 'performPaging' has a Modified Cyclomatic Complexity of 12. 488549
The method 'performPaging' has a Cyclomatic Complexity of 19. 488549
The method 'performPaging' has a Standard Cyclomatic Complexity of 17. 488549
A switch statement does not contain a break 496539
Avoid if (x != y) ..; else ..; 542546

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISplitLayout.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 3642
Avoid unused private fields such as 'submittedLayout'. 41

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUIStyle.java

Violation Line
Avoid if (x != y) ..; else ..; 6986

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUISuggest.java

Violation Line
Avoid if (x != y) ..; else ..; 6271
Avoid if (x != y) ..; else ..; 7684

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITabGroup.java

Violation Line
Possible God class (WMC=55, ATFD=20, TCC=0.0) 20279
The class 'AbstractUITabGroup' has a Modified Cyclomatic Complexity of 2 (Highest = 10). 50279
The class 'AbstractUITabGroup' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 50279
The class 'AbstractUITabGroup' has a Cyclomatic Complexity of 3 (Highest = 10). 50279
This class has too many methods, consider refactoring it. 51279
Document empty method body 5657
An empty method in an abstract class should be abstract instead 5657
The method 'processDecodes' has a Modified Cyclomatic Complexity of 10. 104139
The method 'processDecodes' has a Standard Cyclomatic Complexity of 10. 104139
The method 'processDecodes' has a Cyclomatic Complexity of 10. 104139
Use opposite operator instead of the logic complement operator. 105
Avoid if (x != y) ..; else ..; 105138
These nested if statements could be combined 118120
Avoid if (x != y) ..; else ..; 143156
Use opposite operator instead of the logic complement operator. 143
Use opposite operator instead of the logic complement operator. 161
Avoid if (x != y) ..; else ..; 161175
Use opposite operator instead of the logic complement operator. 196
Avoid if (x != y) ..; else ..; 204208

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITreeCommand.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2526

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITreeIndent.java

Violation Line
No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 2930

Tobago Core - org/apache/myfaces/tobago/internal/component/AbstractUITreeNode.java

Violation Line
An empty method in an abstract class should be abstract instead 2830

Tobago Core - org/apache/myfaces/tobago/internal/config/ContentSecurityPolicy.java

Violation Line
Avoid using redundant field initializer for 'unmodifiable' 33
Avoid if (x != y) ..; else ..; 6468

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigBuilder.java

Violation Line
Avoid instantiating new objects inside loops 110

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigEntityResolver.java

Violation Line
Position literals first in String comparisons 53
Position literals first in String comparisons 55
Position literals first in String comparisons 57
Position literals first in String comparisons 59
Avoid if (x != y) ..; else ..; 6470

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigFragment.java

Violation Line
Too many fields 33204
Avoid unused private fields such as 'LOG'. 35
Private field 'before' could be made final; it is only initialized in the declaration or constructor. 38
Private field 'after' could be made final; it is only initialized in the declaration or constructor. 39
Private field 'supportedThemeNames' could be made final; it is only initialized in the declaration or constructor. 41
Private field 'themeDefinitions' could be made final; it is only initialized in the declaration or constructor. 49
Private field 'mimeTypes' could be made final; it is only initialized in the declaration or constructor. 54
Avoid if (x != y) ..; else ..; 202

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigImpl.java

Violation Line
Possible God class (WMC=56, ATFD=17, TCC=0.08064516129032258) 20377
Too many fields 49377
The class 'TobagoConfigImpl' has a Cyclomatic Complexity of 2 (Highest = 10). 49377
The class 'TobagoConfigImpl' has a Modified Cyclomatic Complexity of 2 (Highest = 10). 49377
The class 'TobagoConfigImpl' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 49377
Private field 'contentSecurityPolicy' could be made final; it is only initialized in the declaration or constructor. 61
Avoid using redundant field initializer for 'unmodifiable' 69
The method 'resolveThemes' has a Standard Cyclomatic Complexity of 10. 114156
The method 'resolveThemes' has a Cyclomatic Complexity of 10. 114156
The method 'resolveThemes' has a Modified Cyclomatic Complexity of 10. 114156
Avoid if (x != y) ..; else ..; 117144
Use block level rather than method level synchronization 220239
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 229
StringBuffer constructor is initialized with size 16, but has at least 282 characters appended. 341
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 342
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 342
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 348
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 349
Avoid if (x != y) ..; else ..; 349
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 350
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 351
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 352
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 353
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 354
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 355
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 356
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 357
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 358
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 359
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 360
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 361
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 362
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 363
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 364
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 365
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 366
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 367
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 371
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 372
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 373

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigParser.java

Violation Line
Possible God class (WMC=106, ATFD=34, TCC=0.05454545454545454) 20473
This class has too many methods, consider refactoring it. 48473
The class 'TobagoConfigParser' has a Cyclomatic Complexity of 6 (Highest = 32). 48473
The class 'TobagoConfigParser' has a Standard Cyclomatic Complexity of 6 (Highest = 32). 48473
StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 110
Perhaps 'extension' could be replaced by a local variable. 114
Perhaps 'type' could be replaced by a local variable. 115
Document empty constructor 119120
The method 'startElement' has a Cyclomatic Complexity of 14. 167264
The method 'startElement' has a Standard Cyclomatic Complexity of 14. 167264
A switch statement does not contain a break 176263
Avoid really long methods. 272429
The method endElement() has an NCSS line count of 116 272429
The method 'endElement' has a Cyclomatic Complexity of 32. 272429
The method 'endElement' has a Standard Cyclomatic Complexity of 32. 272429
A switch statement does not contain a break 282306

Tobago Core - org/apache/myfaces/tobago/internal/config/TobagoConfigSorter.java

Violation Line
Possible God class (WMC=62, ATFD=59, TCC=0.17142857142857143) 20327
The class 'TobagoConfigSorter' has a Modified Cyclomatic Complexity of 4 (Highest = 16). 36327
The class 'TobagoConfigSorter' has a Standard Cyclomatic Complexity of 4 (Highest = 16). 36327
The class 'TobagoConfigSorter' has a Cyclomatic Complexity of 5 (Highest = 16). 36327
Private field 'list' could be made final; it is only initialized in the declaration or constructor. 40
Prefer StringBuffer over += for concatenating strings 66
The method merge() has an NPath complexity of 12291 73157
The method 'merge' has a Standard Cyclomatic Complexity of 16. 73157
The method 'merge' has a Cyclomatic Complexity of 16. 73157
The method 'merge' has a Modified Cyclomatic Complexity of 16. 73157
Avoid instantiating new objects inside loops 168
Avoid instantiation through private constructors from outside of the constructors class. 168
Avoid instantiating new objects inside loops 179
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 180
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 181
The String literal "' < '" appears 4 times in this file; the first occurrence is on line 182 182
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 182
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 183
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 184
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 184
Avoid appending characters as strings in StringBuffer.append. 187
Avoid instantiating new objects inside loops 203
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 204
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 205
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 206
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 207
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 208
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 209
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 210
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 211
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 212
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 212
Avoid appending characters as strings in StringBuffer.append. 215
Avoid instantiation through private constructors from outside of the constructors class. 248
Avoid instantiating new objects inside loops 248
Avoid instantiating new objects inside loops 254
Avoid instantiation through private constructors from outside of the constructors class. 254
Avoid unused method parameters such as 'tobagoConfig'. 282

Tobago Core - org/apache/myfaces/tobago/internal/context/DateTimeI18n.java

Violation Line
A class which only has private constructors should be final 31106
Use block level rather than method level synchronization 7381

Tobago Core - org/apache/myfaces/tobago/internal/context/Nonce.java

Violation Line
A class which only has private constructors should be final 3049

Tobago Core - org/apache/myfaces/tobago/internal/layout/Grid.java

Violation Line
The class 'Grid' has a Modified Cyclomatic Complexity of 6 (Highest = 51). 34452
The class 'Grid' has a Cyclomatic Complexity of 6 (Highest = 55). 34452
The class 'Grid' has a Standard Cyclomatic Complexity of 6 (Highest = 51). 34452
Private field 'cells' could be made final; it is only initialized in the declaration or constructor. 42
Private field 'columns' could be made final; it is only initialized in the declaration or constructor. 44
Private field 'rows' could be made final; it is only initialized in the declaration or constructor. 45
Private field 'columnCount' could be made final; it is only initialized in the declaration or constructor. 47
Avoid instantiating new objects inside loops 105
Avoid really long methods. 208436
The method gridAsString() has an NPath complexity of 11503356 208436
The method 'gridAsString' has a Standard Cyclomatic Complexity of 51. 208436
The method 'gridAsString' has a Modified Cyclomatic Complexity of 51. 208436
The method 'gridAsString' has a Cyclomatic Complexity of 55. 208436
The method gridAsString() has an NCSS line count of 175 208436
StringBuffer constructor is initialized with size 16, but has at least 17 characters appended. 210
Avoid if (x != y) ..; else ..; 215219
Avoid appending characters as strings in StringBuffer.append. 216
Avoid appending characters as strings in StringBuffer.append. 218
Avoid appending characters as strings in StringBuffer.append. 224
Avoid appending characters as strings in StringBuffer.append. 227
Avoid appending characters as strings in StringBuffer.append. 230
Avoid appending characters as strings in StringBuffer.append. 232
Avoid appending characters as strings in StringBuffer.append. 234
Avoid if (x != y) ..; else ..; 239243
Avoid appending characters as strings in StringBuffer.append. 240
Avoid appending characters as strings in StringBuffer.append. 242
Avoid if (x != y) ..; else ..; 246250
Avoid appending characters as strings in StringBuffer.append. 247
Avoid appending characters as strings in StringBuffer.append. 249
Avoid appending characters as strings in StringBuffer.append. 251
Avoid appending characters as strings in StringBuffer.append. 262
Avoid appending characters as strings in StringBuffer.append. 265
Avoid appending characters as strings in StringBuffer.append. 268
Avoid appending characters as strings in StringBuffer.append. 270
Avoid appending characters as strings in StringBuffer.append. 272
Avoid appending characters as strings in StringBuffer.append. 287
Avoid appending characters as strings in StringBuffer.append. 289
Avoid appending characters as strings in StringBuffer.append. 292
Avoid appending characters as strings in StringBuffer.append. 297
Avoid appending characters as strings in StringBuffer.append. 299
Avoid appending characters as strings in StringBuffer.append. 301
Avoid appending characters as strings in StringBuffer.append. 306
Avoid appending characters as strings in StringBuffer.append. 308
Avoid appending characters as strings in StringBuffer.append. 312
Avoid appending characters as strings in StringBuffer.append. 314
Avoid appending characters as strings in StringBuffer.append. 323
Avoid appending characters as strings in StringBuffer.append. 325
Avoid appending characters as strings in StringBuffer.append. 331
Avoid appending characters as strings in StringBuffer.append. 334
Avoid appending characters as strings in StringBuffer.append. 337
Avoid appending characters as strings in StringBuffer.append. 339
Avoid appending characters as strings in StringBuffer.append. 341
Avoid appending characters as strings in StringBuffer.append. 345
Avoid if (x != y) ..; else ..; 351355
Avoid appending characters as strings in StringBuffer.append. 352
Avoid appending characters as strings in StringBuffer.append. 354
Avoid appending characters as strings in StringBuffer.append. 360
Avoid appending characters as strings in StringBuffer.append. 362
Avoid appending characters as strings in StringBuffer.append. 366
Avoid appending characters as strings in StringBuffer.append. 369
Avoid appending characters as strings in StringBuffer.append. 372
Avoid appending characters as strings in StringBuffer.append. 377
Avoid appending characters as strings in StringBuffer.append. 379
Avoid appending characters as strings in StringBuffer.append. 383
Avoid if (x != y) ..; else ..; 387391
Avoid appending characters as strings in StringBuffer.append. 388
Avoid appending characters as strings in StringBuffer.append. 390
Avoid appending characters as strings in StringBuffer.append. 392
Avoid if (x != y) ..; else ..; 398402
Avoid appending characters as strings in StringBuffer.append. 399
Avoid appending characters as strings in StringBuffer.append. 401
Avoid appending characters as strings in StringBuffer.append. 407
Avoid appending characters as strings in StringBuffer.append. 410
Avoid appending characters as strings in StringBuffer.append. 413
Avoid appending characters as strings in StringBuffer.append. 415
Avoid appending characters as strings in StringBuffer.append. 417
Avoid if (x != y) ..; else ..; 422426
Avoid appending characters as strings in StringBuffer.append. 423
Avoid appending characters as strings in StringBuffer.append. 425
Avoid if (x != y) ..; else ..; 428432
Avoid appending characters as strings in StringBuffer.append. 429
Avoid appending characters as strings in StringBuffer.append. 431
Avoid appending characters as strings in StringBuffer.append. 433

Tobago Core - org/apache/myfaces/tobago/internal/layout/LayoutUtils.java

Violation Line
Avoid if (x != y) ..; else ..; 7680
Avoid if (x != y) ..; else ..; 8387

Tobago Core - org/apache/myfaces/tobago/internal/layout/MathUtils.java

Violation Line
Avoid unused local variables such as 'ignored'. 42
Consider using varargs for methods or constructors which take an array the last parameter. 58
Consider using varargs for methods or constructors which take an array the last parameter. 75

Tobago Core - org/apache/myfaces/tobago/internal/layout/OriginCell.java

Violation Line
Private field 'component' could be made final; it is only initialized in the declaration or constructor. 30

Tobago Core - org/apache/myfaces/tobago/internal/layout/SpanCell.java

Violation Line
Private field 'origin' could be made final; it is only initialized in the declaration or constructor. 30
Private field 'horizontalFirst' could be made final; it is only initialized in the declaration or constructor. 31
Private field 'verticalFirst' could be made final; it is only initialized in the declaration or constructor. 32

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/Collapse.java

Violation Line
Private field 'action' could be made final; it is only initialized in the declaration or constructor. 24
Private field 'forId' could be made final; it is only initialized in the declaration or constructor. 25

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/Command.java

Violation Line
The class 'Command' has a Cyclomatic Complexity of 2 (Highest = 13). 39264
The class 'Command' has a Modified Cyclomatic Complexity of 2 (Highest = 13). 39264
The class 'Command' has a Standard Cyclomatic Complexity of 2 (Highest = 13). 39264
Document empty constructor 5758
Avoid long parameter lists. 6063
Overridable method 'setExecute' called during object construction 67
Overridable method 'setRender' called during object construction 68
Do not add empty strings 129
The method 'merge' has a Standard Cyclomatic Complexity of 13. 220263
The method 'merge' has a Modified Cyclomatic Complexity of 13. 220263
The method merge() has an NPath complexity of 2304 220263
The method 'merge' has a Cyclomatic Complexity of 13. 220263
Avoid if (x != y) ..; else ..; 234240
Avoid if (x != y) ..; else ..; 241247

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/CommandMap.java

Violation Line
Document empty constructor 4546
Avoid if (x != y) ..; else ..; 7680
Avoid if (x != y) ..; else ..; 99117

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/BoxRenderer.java

Violation Line
The class 'BoxRenderer' has a Cyclomatic Complexity of 6 (Highest = 10). 39103
The method 'encodeBegin' has a Cyclomatic Complexity of 10. 4295
The method encodeBegin() has an NPath complexity of 220 4295

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/ButtonRenderer.java

Violation Line
The class 'ButtonRenderer' has a Modified Cyclomatic Complexity of 5 (Highest = 12). 3273
The class 'ButtonRenderer' has a Standard Cyclomatic Complexity of 5 (Highest = 12). 3273
The class 'ButtonRenderer' has a Cyclomatic Complexity of 5 (Highest = 12). 3273
The method 'getButtonColor' has a Modified Cyclomatic Complexity of 12. 4972
The method 'getButtonColor' has a Standard Cyclomatic Complexity of 12. 4972
The method 'getButtonColor' has a Cyclomatic Complexity of 12. 4972

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/ColumnRenderer.java

Violation Line
Avoid unused private methods such as 'isPure(UIColumn)'. 39

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/CommandRendererBase.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20253
The class 'CommandRendererBase' has a Standard Cyclomatic Complexity of 4 (Highest = 15). 55253
The class 'CommandRendererBase' has a Cyclomatic Complexity of 4 (Highest = 15). 55253
The class 'CommandRendererBase' has a Modified Cyclomatic Complexity of 4 (Highest = 15). 55253
Avoid unused private fields such as 'LOG'. 57
The method encodeBegin() has an NPath complexity of 43200 60156
The method 'encodeBegin' has a Cyclomatic Complexity of 15. 60156
The method 'encodeBegin' has a Modified Cyclomatic Complexity of 15. 60156
The method 'encodeBegin' has a Standard Cyclomatic Complexity of 15. 60156
The method 'encodeChildren' has a Cyclomatic Complexity of 10. 164206
An empty method in an abstract class should be abstract instead 240242
Return an empty array rather than null. 240242
Return an empty array rather than null. 246248
An empty method in an abstract class should be abstract instead 246248
Return an empty array rather than null. 250252
An empty method in an abstract class should be abstract instead 250252

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/DateRenderer.java

Violation Line
When instantiating a SimpleDateFormat object, specify a Locale 58

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/FileRenderer.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20218
Avoid instantiating new objects inside loops 89
Avoid instantiating new objects inside loops 91
Avoid appending characters as strings in StringBuffer.append. 195

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/FlowLayoutRenderer.java

Violation Line
Avoid if (x != y) ..; else ..; 54

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/GridLayoutRenderer.java

Violation Line
Avoid unused private fields such as 'LOG'. 43

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/HiddenRenderer.java

Violation Line
Avoid if (x != y) ..; else ..; 56

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/ImageRenderer.java

Violation Line
Avoid if (x != y) ..; else ..; 73

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/InRenderer.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20225
The class 'InRenderer' has a Cyclomatic Complexity of 6 (Highest = 21). 56225
The class 'InRenderer' has a Standard Cyclomatic Complexity of 5 (Highest = 17). 56225
The class 'InRenderer' has a Modified Cyclomatic Complexity of 5 (Highest = 17). 56225
The method 'encodeBeginField' has a Cyclomatic Complexity of 21. 61166
The method encodeBeginField() has an NPath complexity of 245760 61166
Avoid really long methods. 61166
The method 'encodeBeginField' has a Modified Cyclomatic Complexity of 17. 61166
The method 'encodeBeginField' has a Standard Cyclomatic Complexity of 17. 61166
Document empty method body 208209
Document empty method body 217218

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/LabelLayoutRendererBase.java

Violation Line
Possible God class (WMC=57, ATFD=45, TCC=0.0) 20251
The class 'LabelLayoutRendererBase' has a Cyclomatic Complexity of 5 (Highest = 16). 49251
The class 'LabelLayoutRendererBase' has a Modified Cyclomatic Complexity of 4 (Highest = 10). 49251
The class 'LabelLayoutRendererBase' has a Standard Cyclomatic Complexity of 5 (Highest = 16). 49251
Local variable 'childCount' could be declared final 106
The method 'encodeBeginSurroundingLabel' has a Standard Cyclomatic Complexity of 16. 125201
The method 'encodeBeginSurroundingLabel' has a Cyclomatic Complexity of 16. 125201
The method encodeBeginSurroundingLabel() has an NPath complexity of 12000 125201
The method 'encodeBeginSurroundingLabel' has a Modified Cyclomatic Complexity of 10. 125201
Avoid declaring a variable if it is unreferenced before a possible exit point. 128
Avoid declaring a variable if it is unreferenced before a possible exit point. 130
A switch statement does not contain a break 144169
Prefer StringBuffer over += for concatenating strings 153
Prefer StringBuffer over += for concatenating strings 159
A switch statement does not contain a break 182200

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/LabelRenderer.java

Violation Line
Avoid if (x != y) ..; else ..; 64

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/MessageLayoutRendererBase.java

Violation Line
The class 'MessageLayoutRendererBase' has a Standard Cyclomatic Complexity of 4 (Highest = 20). 38178
The class 'MessageLayoutRendererBase' has a Modified Cyclomatic Complexity of 4 (Highest = 20). 38178
The class 'MessageLayoutRendererBase' has a Cyclomatic Complexity of 4 (Highest = 20). 38178
The method 'getTitle' has a Cyclomatic Complexity of 20. 98168
The method getTitle() has an NPath complexity of 930 98168
The method 'getTitle' has a Standard Cyclomatic Complexity of 20. 98168
The method 'getTitle' has a Modified Cyclomatic Complexity of 20. 98168
Avoid appending characters as strings in StringBuffer.append. 132
Avoid appending characters as strings in StringBuffer.append. 144

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/MessagesRenderer.java

Violation Line
The class 'MessagesRenderer' has a Cyclomatic Complexity of 10 (Highest = 10). 47180
The method 'encodeEnd' has a Cyclomatic Complexity of 10. 52148
Use equals() to compare object references. 94
Use equals() to compare object references. 98
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 122

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/PageRenderer.java

Violation Line
Possible God class (WMC=64, ATFD=135, TCC=0.0) 20469
A high number of imports can indicate a high degree of coupling within an object. 20469
The class 'PageRenderer' has a Cyclomatic Complexity of 8 (Highest = 32). 80469
The class 'PageRenderer' has a Standard Cyclomatic Complexity of 8 (Highest = 30). 80469
The class 'PageRenderer' has a Modified Cyclomatic Complexity of 8 (Highest = 30). 80469
The method encodeBegin() has an NCSS line count of 138 103311
The method 'encodeBegin' has a Standard Cyclomatic Complexity of 30. 103311
The method 'encodeBegin' has a Cyclomatic Complexity of 32. 103311
The method 'encodeBegin' has a Modified Cyclomatic Complexity of 30. 103311
Avoid really long methods. 103311
Avoid if (x != y) ..; else ..; 192
The class 'HeadResources' has a Standard Cyclomatic Complexity of 3 (Highest = 10). 383468
The class 'HeadResources' has a Modified Cyclomatic Complexity of 3 (Highest = 10). 383468
The class 'HeadResources' has a Cyclomatic Complexity of 3 (Highest = 11). 383468
Private field 'metas' could be made final; it is only initialized in the declaration or constructor. 385
Private field 'styles' could be made final; it is only initialized in the declaration or constructor. 386
Private field 'scripts' could be made final; it is only initialized in the declaration or constructor. 387
Private field 'misc' could be made final; it is only initialized in the declaration or constructor. 388
The constructor 'HeadResources' has a Modified Cyclomatic Complexity of 10. 390430
The constructor 'HeadResources' has a Cyclomatic Complexity of 11. 390430
The constructor 'HeadResources' has a Standard Cyclomatic Complexity of 10. 390430
Avoid autogenerated methods to access private fields and methods of inner / outer classes 406
Avoid autogenerated methods to access private fields and methods of inner / outer classes 407

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/ProgressRenderer.java

Violation Line
Avoid unused private fields such as 'LOG'. 49

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/RowRenderer.java

Violation Line
Avoid if (x != y) ..; else ..; 3943

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SectionRenderer.java

Violation Line
The class 'SectionRenderer' has a Cyclomatic Complexity of 7 (Highest = 12). 39120
The class 'SectionRenderer' has a Standard Cyclomatic Complexity of 6 (Highest = 11). 39120
The method 'encodeBegin' has a Cyclomatic Complexity of 12. 42111
The method 'encodeBegin' has a Standard Cyclomatic Complexity of 11. 42111
The method encodeBegin() has an NPath complexity of 720 42111
A switch statement does not contain a break 6280

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SegmentLayoutRenderer.java

Violation Line
Avoid unused private fields such as 'LOG'. 48
Avoid declaring a variable if it is unreferenced before a possible exit point. 75

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectBooleanCheckboxRenderer.java

Violation Line
The String literal "true" appears 4 times in this file; the first occurrence is on line 66 66
Return an empty array rather than null. 147149

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyCheckboxRenderer.java

Violation Line
The class 'SelectManyCheckboxRenderer' has a Standard Cyclomatic Complexity of 4 (Highest = 14). 44163
The class 'SelectManyCheckboxRenderer' has a Cyclomatic Complexity of 4 (Highest = 14). 44163
The class 'SelectManyCheckboxRenderer' has a Modified Cyclomatic Complexity of 4 (Highest = 14). 44163
The method 'encodeBeginField' has a Cyclomatic Complexity of 14. 47143
The method encodeBeginField() has an NPath complexity of 24980 47143
The method 'encodeBeginField' has a Modified Cyclomatic Complexity of 14. 47143
The method 'encodeBeginField' has a Standard Cyclomatic Complexity of 14. 47143
Return an empty array rather than null. 155157

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyListboxRenderer.java

Violation Line
Avoid if (x != y) ..; else ..; 58

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyRendererBase.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20807
Possible God class (WMC=116, ATFD=71, TCC=0.0) 20807
The class 'SelectManyRendererBase' has a Cyclomatic Complexity of 6 (Highest = 31). 57807
The class 'SelectManyRendererBase' has a Standard Cyclomatic Complexity of 6 (Highest = 28). 57807
The class 'SelectManyRendererBase' has a Modified Cyclomatic Complexity of 6 (Highest = 28). 57807
Avoid if (x != y) ..; else ..; 74
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 122
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 123
Consider using varargs for methods or constructors which take an array the last parameter. 126
The method 'getConvertedUISelectManyValue' has a Cyclomatic Complexity of 31. 143320
The method 'getConvertedUISelectManyValue' has a Standard Cyclomatic Complexity of 28. 143320
Avoid really long methods. 143320
The method 'getConvertedUISelectManyValue' has a Modified Cyclomatic Complexity of 28. 143320
The method getConvertedUISelectManyValue() has an NPath complexity of 2760 143320
Avoid if (x != y) ..; else ..; 165297
Avoid if (x != y) ..; else ..; 209289
Avoid if (x != y) ..; else ..; 260262
Avoid if (x != y) ..; else ..; 305310
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 452
The String literal "{Component-Path : " appears 4 times in this file; the first occurrence is on line 452 452
Avoid appending characters as strings in StringBuffer.append. 460
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 472
Avoid appending characters as strings in StringBuffer.append. 481
The class 'SelectItemsIterator' has a Modified Cyclomatic Complexity of 6 (Highest = 23). 496776
The class 'SelectItemsIterator' has a Cyclomatic Complexity of 6 (Highest = 27). 496776
The class 'SelectItemsIterator' has a Standard Cyclomatic Complexity of 6 (Highest = 23). 496776
Private field 'facesContext' could be made final; it is only initialized in the declaration or constructor. 514
Avoid really long methods. 525635
The method hasNext() has an NPath complexity of 1662 525635
The method 'hasNext' has a Standard Cyclomatic Complexity of 23. 525635
The method 'hasNext' has a Cyclomatic Complexity of 27. 525635
The method 'hasNext' has a Modified Cyclomatic Complexity of 23. 525635
Avoid instantiating new objects inside loops 605
Avoid autogenerated methods to access private fields and methods of inner / outer classes 612
Avoid autogenerated methods to access private fields and methods of inner / outer classes 613
Avoid autogenerated methods to access private fields and methods of inner / outer classes 624
Avoid autogenerated methods to access private fields and methods of inner / outer classes 626
The method next() has an NPath complexity of 296 638711
The method 'next' has a Modified Cyclomatic Complexity of 11. 638711
The method 'next' has a Cyclomatic Complexity of 12. 638711
The method 'next' has a Standard Cyclomatic Complexity of 11. 638711
Avoid if (x != y) ..; else ..; 699705
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 741
Avoid appending characters as strings in StringBuffer.append. 749
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 761
Avoid appending characters as strings in StringBuffer.append. 770

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectManyShuttleRenderer.java

Violation Line
Avoid really long methods. 47154
Avoid unused local variables such as 'hasLabel'. 68
Avoid if (x != y) ..; else ..; 81

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectOneListboxRenderer.java

Violation Line
Avoid if (x != y) ..; else ..; 57

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectOneRadioRenderer.java

Violation Line
The class 'SelectOneRadioRenderer' has a Modified Cyclomatic Complexity of 4 (Highest = 14). 44162
The class 'SelectOneRadioRenderer' has a Cyclomatic Complexity of 4 (Highest = 14). 44162
The class 'SelectOneRadioRenderer' has a Standard Cyclomatic Complexity of 4 (Highest = 14). 44162
The method 'encodeBeginField' has a Modified Cyclomatic Complexity of 14. 47142
The method encodeBeginField() has an NPath complexity of 24980 47142
The method 'encodeBeginField' has a Standard Cyclomatic Complexity of 14. 47142
The method 'encodeBeginField' has a Cyclomatic Complexity of 14. 47142
Return an empty array rather than null. 154156

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SelectReferenceRenderer.java

Violation Line
Avoid unused private fields such as 'LOG'. 34

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SeparatorRenderer.java

Violation Line
Avoid if (x != y) ..; else ..; 4968

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 201162
Possible God class (WMC=210, ATFD=472, TCC=0.004761904761904762) 201162
The class 'SheetRenderer' has a Standard Cyclomatic Complexity of 9 (Highest = 46). 871162
The class 'SheetRenderer' has a Modified Cyclomatic Complexity of 9 (Highest = 46). 871162
This class has too many methods, consider refactoring it. 871162
The class 'SheetRenderer' has a Cyclomatic Complexity of 10 (Highest = 51). 871162
Avoid really long classes. 871162
The method 'encodeBegin' has a Cyclomatic Complexity of 10. 143209
Avoid if (x != y) ..; else ..; 161165
Avoid if (x != y) ..; else ..; 167171
Avoid appending characters as strings in StringBuffer.append. 206
The method encodeEnd() has an NCSS line count of 174 222466
The method 'encodeEnd' has a Cyclomatic Complexity of 33. 222466
The method 'encodeEnd' has a Standard Cyclomatic Complexity of 33. 222466
The method 'encodeEnd' has a Modified Cyclomatic Complexity of 33. 222466
The method encodeEnd() has an NPath complexity of 1158342528 222466
Avoid really long methods. 222466
Avoid if (x != y) ..; else ..; 295344
Avoid if (x != y) ..; else ..; 392439
The method encodeTableBody() has an NCSS line count of 132 468701
Avoid really long methods. 468701
The method 'encodeTableBody' has a Cyclomatic Complexity of 51. 468701
The method 'encodeTableBody' has a Standard Cyclomatic Complexity of 46. 468701
The method encodeTableBody() has an NPath complexity of 1649725344 468701
The method 'encodeTableBody' has a Modified Cyclomatic Complexity of 46. 468701
Avoid long parameter lists. 468471
Avoid if (x != y) ..; else ..; 475
Avoid if (x != y) ..; else ..; 494
Avoid if (x != y) ..; else ..; 522
Avoid appending characters as strings in StringBuffer.append. 570
These nested if statements could be combined 599605
These nested if statements could be combined 618656
Avoid if (x != y) ..; else ..; 733
Avoid unused private methods such as 'getMarkupForAlign(UIColumn)'. 740
The method encodeHeaderRows() has an NCSS line count of 106 757910
The method 'encodeHeaderRows' has a Cyclomatic Complexity of 29. 757910
The method 'encodeHeaderRows' has a Standard Cyclomatic Complexity of 25. 757910
The method 'encodeHeaderRows' has a Modified Cyclomatic Complexity of 23. 757910
The method encodeHeaderRows() has an NPath complexity of 46385 757910
Avoid really long methods. 757910
Avoid if (x != y) ..; else ..; 795811
A switch statement does not contain a break 796808
String.indexOf(char) is faster than String.indexOf(String). 827
Prefer StringBuffer over += for concatenating strings 843
Prefer StringBuffer over += for concatenating strings 845
Prefer StringBuffer over += for concatenating strings 862
These nested if statements could be combined 893895
Avoid unused method parameters such as 'sheet'. 912
The method encodeLink() has an NPath complexity of 200 9811020
Avoid if (x != y) ..; else ..; 10111017
Avoid unused method parameters such as 'sheet'. 1026
Avoid unused private methods such as 'encodeResizing(TobagoResponseWriter,AbstractUISheet,int)'. 1026
The method encodeDirectPagingLinks() has an NPath complexity of 648000 10351108
The method 'encodeDirectPagingLinks' has a Cyclomatic Complexity of 23. 10351108
The method 'encodeDirectPagingLinks' has a Standard Cyclomatic Complexity of 20. 10351108
The method 'encodeDirectPagingLinks' has a Modified Cyclomatic Complexity of 20. 10351108
Avoid unused local variables such as 'command'. 1039
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 1080
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 1099
Avoid unused private methods such as 'findReloadBehavior(ClientBehaviorHolder)'. 1154

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SplitLayoutRenderer.java

Violation Line
Avoid unused method parameters such as 'layout'. 112

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/StyleRenderer.java

Violation Line
The class 'StyleRenderer' has a Cyclomatic Complexity of 18 (Highest = 65). 44298
The class 'StyleRenderer' has a Modified Cyclomatic Complexity of 10 (Highest = 35). 44298
The class 'StyleRenderer' has a Standard Cyclomatic Complexity of 10 (Highest = 35). 44298
Avoid unused private fields such as 'LOG'. 46
Avoid really long methods. 49258
The method encodeBegin() has an NCSS line count of 123 49258
The method 'encodeBegin' has a Standard Cyclomatic Complexity of 35. 49258
The method 'encodeBegin' has a Modified Cyclomatic Complexity of 35. 49258
The method 'encodeBegin' has a Cyclomatic Complexity of 65. 49258
Avoid if (x != y) ..; else ..; 147152
A switch with less than three branches is inefficient, use a if statement instead. 264275
A switch statement does not contain a break 264275

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SubviewRenderer.java

Violation Line
Document empty method body 4547

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/SuggestRenderer.java

Violation Line
The class 'SuggestRenderer' has a Cyclomatic Complexity of 8 (Highest = 11). 49163
The method 'encodeBegin' has a Cyclomatic Complexity of 11. 74133
Avoid if (x != y) ..; else ..; 82106
Avoid if (x != y) ..; else ..; 116120
Avoid instantiating new objects inside loops 147

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TabGroupRenderer.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20355
Possible God class (WMC=54, ATFD=113, TCC=0.0) 20355
The class 'TabGroupRenderer' has a Standard Cyclomatic Complexity of 7 (Highest = 19). 69355
The class 'TabGroupRenderer' has a Cyclomatic Complexity of 8 (Highest = 22). 69355
The class 'TabGroupRenderer' has a Modified Cyclomatic Complexity of 7 (Highest = 19). 69355
A switch statement does not contain a break 85109
Avoid instantiating new objects inside loops 92
Avoid instantiating new objects inside loops 100
The method 'ensureRenderedActiveIndex' has a Cyclomatic Complexity of 10. 175209
The method 'ensureRenderedActiveIndex' has a Modified Cyclomatic Complexity of 10. 175209
The method 'ensureRenderedActiveIndex' has a Standard Cyclomatic Complexity of 10. 175209
Deeply nested if..then statements are hard to read 186188
Avoid if (x != y) ..; else ..; 203207
Avoid really long methods. 211319
The method 'encodeHeader' has a Modified Cyclomatic Complexity of 19. 211319
The method 'encodeHeader' has a Cyclomatic Complexity of 22. 211319
The method 'encodeHeader' has a Standard Cyclomatic Complexity of 19. 211319
The method encodeHeader() has an NPath complexity of 207363 211319
Avoid instantiating new objects inside loops 226
Avoid if (x != y) ..; else ..; 230

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TextareaRenderer.java

Violation Line
The class 'TextareaRenderer' has a Modified Cyclomatic Complexity of 5 (Highest = 15). 49173
The class 'TextareaRenderer' has a Standard Cyclomatic Complexity of 5 (Highest = 15). 49173
The class 'TextareaRenderer' has a Cyclomatic Complexity of 6 (Highest = 18). 49173
The method 'encodeBeginField' has a Cyclomatic Complexity of 18. 75162
The method 'encodeBeginField' has a Standard Cyclomatic Complexity of 15. 75162
The method 'encodeBeginField' has a Modified Cyclomatic Complexity of 15. 75162
The method encodeBeginField() has an NPath complexity of 6656 75162
Prefer StringBuffer over += for concatenating strings 152
Prefer StringBuffer over += for concatenating strings 154
Prefer StringBuffer over += for concatenating strings 156
Document empty method body 165166

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TobagoClientBehaviorRenderer.java

Violation Line
Avoid declaring a variable if it is unreferenced before a possible exit point. 66
Avoid if (x != y) ..; else ..; 8589
Prefer StringBuffer over += for concatenating strings 86
Avoid if (x != y) ..; else ..; 102109
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 194

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TreeIndentRenderer.java

Violation Line
Avoid declaring a variable if it is unreferenced before a possible exit point. 58

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TreeLabelRenderer.java

Violation Line
Avoid unused private fields such as 'LOG'. 42

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TreeListboxRenderer.java

Violation Line
The method encodeEnd() has an NPath complexity of 250 54146
Avoid if (x != y) ..; else ..; 105
Avoid if (x != y) ..; else ..; 106108
Avoid unused private methods such as 'encodeSelectBox(FacesContext,AbstractUITreeListbox,TobagoResponseWriter,int,List,int)'. 148150
Avoid if (x != y) ..; else ..; 169178
Avoid if (x != y) ..; else ..; 173177

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TreeNodeRenderer.java

Violation Line
Avoid unused local variables such as 'expanded'. 75
Deeply nested if..then statements are hard to read 8890
Avoid if (x != y) ..; else ..; 96106
Avoid unused local variables such as 'markedValue'. 98
The method encodeBegin() has an NPath complexity of 459 111162
Avoid unused method parameters such as 'writer'. 189
Avoid unused method parameters such as 'expanded'. 189
Avoid unused method parameters such as 'facesContext'. 189
Avoid unused method parameters such as 'node'. 190

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TreeRenderer.java

Violation Line
The class 'TreeRenderer' has a Cyclomatic Complexity of 4 (Highest = 10). 48163
The method 'encodeEnd' has a Cyclomatic Complexity of 10. 76162
The method encodeEnd() has an NPath complexity of 500 76162
Avoid declaring a variable if it is unreferenced before a possible exit point. 78
Avoid declaring a variable if it is unreferenced before a possible exit point. 80
Avoid declaring a variable if it is unreferenced before a possible exit point. 81
Avoid appending characters as strings in StringBuffer.append. 121
Avoid appending characters as strings in StringBuffer.append. 126

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/TreeSelectRenderer.java

Violation Line
The class 'TreeSelectRenderer' has a Cyclomatic Complexity of 5 (Highest = 10). 49165
Avoid declaring a variable if it is unreferenced before a possible exit point. 58
The method 'encodeBegin' has a Cyclomatic Complexity of 10. 85155
Do not add empty strings 159
Document empty method body 163164

Tobago Core - org/apache/myfaces/tobago/internal/renderkit/renderer/VerbatimRenderer.java

Violation Line
Avoid declaring a variable if it is unreferenced before a possible exit point. 37

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/GridLayoutConstraintTagDeclaration.java

Violation Line
The String literal "java.lang.Integer" appears 4 times in this file; the first occurrence is on line 38 38

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/InTagDeclaration.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20102

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/MessagesTagDeclaration.java

Violation Line
The String literal "boolean" appears 4 times in this file; the first occurrence is on line 58 58

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/SegmentLayoutConstraintTagDeclaration.java

Violation Line
The String literal "java.lang.Integer" appears 5 times in this file; the first occurrence is on line 110 110

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/SegmentLayoutTagDeclaration.java

Violation Line
The String literal "org.apache.myfaces.tobago.layout.SegmentMeasureList" appears 5 times in this file; the first occurrence is on line 57 57

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/SheetTagDeclaration.java

Violation Line
The String literal "boolean" appears 4 times in this file; the first occurrence is on line 104 104

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/StyleTagDeclaration.java

Violation Line
The String literal "org.apache.myfaces.tobago.layout.Measure" appears 19 times in this file; the first occurrence is on line 82 82

Tobago Core - org/apache/myfaces/tobago/internal/taglib/component/SuggestTagDeclaration.java

Violation Line
The String literal "java.lang.Integer" appears 4 times in this file; the first occurrence is on line 88 88

Tobago Core - org/apache/myfaces/tobago/internal/util/AccessKeyLogger.java

Violation Line
getInstance method always creates a new object and hence does not comply to Singleton Design Pattern behaviour. Please review 4553

Tobago Core - org/apache/myfaces/tobago/internal/util/ArrayUtils.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2238
Use equals() to compare object references. 31

Tobago Core - org/apache/myfaces/tobago/internal/util/AuthorizationHelper.java

Violation Line
The class 'AuthorizationHelper' has a Cyclomatic Complexity of 5 (Highest = 13). 47227
The class 'AuthorizationHelper' has a Modified Cyclomatic Complexity of 5 (Highest = 12). 47227
The class 'AuthorizationHelper' has a Standard Cyclomatic Complexity of 5 (Highest = 13). 47227
The method 'isAuthorized' has a Cyclomatic Complexity of 10. 96129
The method 'isAuthorized' has a Standard Cyclomatic Complexity of 10. 96129
The method 'isAuthorized' has a Modified Cyclomatic Complexity of 10. 96129
The method 'getSecurityAnnotation' has a Cyclomatic Complexity of 13. 131191
The method 'getSecurityAnnotation' has a Standard Cyclomatic Complexity of 13. 131191
The method 'getSecurityAnnotation' has a Modified Cyclomatic Complexity of 12. 131191
Avoid if (x != y) ..; else ..; 147158
A switch statement does not contain a break 163173

Tobago Core - org/apache/myfaces/tobago/internal/util/CookieUtils.java

Violation Line
The class 'CookieUtils' has a Standard Cyclomatic Complexity of 6 (Highest = 12). 29121
A class which only has private constructors should be final 29121
The class 'CookieUtils' has a Cyclomatic Complexity of 6 (Highest = 12). 29121
The class 'CookieUtils' has a Modified Cyclomatic Complexity of 6 (Highest = 12). 29121
Deeply nested if..then statements are hard to read 5254
The method 'setThemeNameToCookie' has a Cyclomatic Complexity of 12. 62103
The method 'setThemeNameToCookie' has a Standard Cyclomatic Complexity of 12. 62103
The method 'setThemeNameToCookie' has a Modified Cyclomatic Complexity of 12. 62103
Deeply nested if..then statements are hard to read 7375
Deeply nested if..then statements are hard to read 7984
Deeply nested if..then statements are hard to read 8590

Tobago Core - org/apache/myfaces/tobago/internal/util/Deprecation.java

Violation Line
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 49

Tobago Core - org/apache/myfaces/tobago/internal/util/HtmlRendererUtils.java

Violation Line
Possible God class (WMC=51, ATFD=51, TCC=0.0) 20293
The class 'HtmlRendererUtils' has a Modified Cyclomatic Complexity of 3 (Highest = 16). 53293
The class 'HtmlRendererUtils' has a Cyclomatic Complexity of 4 (Highest = 20). 53293
The class 'HtmlRendererUtils' has a Standard Cyclomatic Complexity of 3 (Highest = 16). 53293
Prefer StringBuffer over += for concatenating strings 161
Prefer StringBuffer over += for concatenating strings 165
Avoid if (x != y) ..; else ..; 189
Avoid if (x != y) ..; else ..; 190
The method 'renderSelectItems' has a Modified Cyclomatic Complexity of 16. 193270
The method renderSelectItems() has an NPath complexity of 9006 193270
The method 'renderSelectItems' has a Standard Cyclomatic Complexity of 16. 193270
The method 'renderSelectItems' has a Cyclomatic Complexity of 20. 193270

Tobago Core - org/apache/myfaces/tobago/internal/util/HtmlWriterHelper.java

Violation Line
The class 'HtmlWriterHelper' has a Cyclomatic Complexity of 9 (Highest = 14). 25126
The class 'HtmlWriterHelper' has a Modified Cyclomatic Complexity of 7 (Highest = 10). 25126
The class 'HtmlWriterHelper' has a Standard Cyclomatic Complexity of 7 (Highest = 10). 25126
The method 'writeEncodedValue' has a Cyclomatic Complexity of 14. 64125
The method 'writeEncodedValue' has a Modified Cyclomatic Complexity of 10. 64125
The method 'writeEncodedValue' has a Standard Cyclomatic Complexity of 10. 64125
Avoid if (x != y) ..; else ..; 97101

Tobago Core - org/apache/myfaces/tobago/internal/util/HttpPartWrapper.java

Violation Line
Document empty constructor 3637
Document empty method body 112113
Document empty method body 121122

Tobago Core - org/apache/myfaces/tobago/internal/util/JQueryUtils.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2232

Tobago Core - org/apache/myfaces/tobago/internal/util/JndiUtils.java

Violation Line
Prefer StringBuffer over += for concatenating strings 57

Tobago Core - org/apache/myfaces/tobago/internal/util/JsonUtils.java

Violation Line
Possible God class (WMC=55, ATFD=30, TCC=0.0) 20312
This class has too many methods, consider refactoring it. 38312
The class 'JsonUtils' has a Standard Cyclomatic Complexity of 3 (Highest = 12). 38312
A class which only has private constructors should be final 38312
The class 'JsonUtils' has a Cyclomatic Complexity of 4 (Highest = 14). 38312
The class 'JsonUtils' has a Modified Cyclomatic Complexity of 3 (Highest = 12). 38312
Consider using varargs for methods or constructors which take an array the last parameter. 45
Avoid appending characters as strings in StringBuffer.append. 46
Avoid appending characters as strings in StringBuffer.append. 50
Consider using varargs for methods or constructors which take an array the last parameter. 53
Avoid appending characters as strings in StringBuffer.append. 54
Avoid appending characters as strings in StringBuffer.append. 58
Avoid appending characters as strings in StringBuffer.append. 60
Avoid appending characters as strings in StringBuffer.append. 62
Avoid appending characters as strings in StringBuffer.append. 65
Avoid appending characters as strings in StringBuffer.append. 69
Avoid appending characters as strings in StringBuffer.append. 73
Avoid appending characters as strings in StringBuffer.append. 78
Avoid appending characters as strings in StringBuffer.append. 82
Avoid appending characters as strings in StringBuffer.append. 86
Avoid appending characters as strings in StringBuffer.append. 90
Avoid appending characters as strings in StringBuffer.append. 94
Avoid appending characters as strings in StringBuffer.append. 98
Avoid appending characters as strings in StringBuffer.append. 112
Avoid appending characters as strings in StringBuffer.append. 132
The method 'encode' has a Modified Cyclomatic Complexity of 12. 136189
The method 'encode' has a Standard Cyclomatic Complexity of 12. 136189
The method encode() has an NPath complexity of 4608 136189
The method 'encode' has a Cyclomatic Complexity of 14. 136189
Avoid appending characters as strings in StringBuffer.append. 137
Avoid appending characters as strings in StringBuffer.append. 192
Avoid appending characters as strings in StringBuffer.append. 215
Avoid appending characters as strings in StringBuffer.append. 229
Consider using varargs for methods or constructors which take an array the last parameter. 233
Avoid appending characters as strings in StringBuffer.append. 252
Avoid appending characters as strings in StringBuffer.append. 270
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 303

Tobago Core - org/apache/myfaces/tobago/internal/util/MimeTypeUtils.java

Violation Line
The class 'MimeTypeUtils' has a Standard Cyclomatic Complexity of 9 (Highest = 22). 27109
The class 'MimeTypeUtils' has a Modified Cyclomatic Complexity of 9 (Highest = 22). 27109
The class 'MimeTypeUtils' has a Cyclomatic Complexity of 9 (Highest = 22). 27109
Avoid using redundant field initializer for 'additionalMimeTypes' 29
The method 'getMimeTypeForFile' has a Modified Cyclomatic Complexity of 22. 3699
The method 'getMimeTypeForFile' has a Standard Cyclomatic Complexity of 22. 3699
The method getMimeTypeForFile() has an NPath complexity of 546 3699
The method 'getMimeTypeForFile' has a Cyclomatic Complexity of 22. 3699
These nested if statements could be combined 8789
Singleton is not thread safe 102107

Tobago Core - org/apache/myfaces/tobago/internal/util/NumberUtils.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2234

Tobago Core - org/apache/myfaces/tobago/internal/util/ObjectUtils.java

Violation Line
A class which only has private constructors should be final 2232
Use equals() to compare object references. 30

Tobago Core - org/apache/myfaces/tobago/internal/util/PartUtils.java

Violation Line
Possible God class (WMC=50, ATFD=11, TCC=0.1388888888888889) 20361
Deeply nested if..then statements are hard to read 94103
Avoid if (x != y) ..; else ..; 94103
The class 'ParameterParser' has a Cyclomatic Complexity of 4 (Highest = 10). 111360
Avoid using redundant field initializer for 'chars' 116
Avoid using redundant field initializer for 'pos' 121
Avoid using redundant field initializer for 'len' 126
Avoid using redundant field initializer for 'i1' 131
Avoid using redundant field initializer for 'i2' 136
Avoid using redundant field initializer for 'lowerCaseNames' 141
The method 'getToken' has a Cyclomatic Complexity of 10. 169191
Consider using varargs for methods or constructors which take an array the last parameter. 201
Consider using varargs for methods or constructors which take an array the last parameter. 220
Consider using varargs for methods or constructors which take an array the last parameter. 244
The method 'parse' has a Cyclomatic Complexity of 10. 320359
Avoid instantiating new objects inside loops 337339
Avoid instantiating new objects inside loops 343345

Tobago Core - org/apache/myfaces/tobago/internal/util/RandomUtils.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3147

Tobago Core - org/apache/myfaces/tobago/internal/util/RenderUtils.java

Violation Line
Possible God class (WMC=68, ATFD=53, TCC=0.0) 20350
A high number of imports can indicate a high degree of coupling within an object. 20350
The class 'RenderUtils' has a Modified Cyclomatic Complexity of 5 (Highest = 14). 55350
The class 'RenderUtils' has a Standard Cyclomatic Complexity of 5 (Highest = 14). 55350
The class 'RenderUtils' has a Cyclomatic Complexity of 6 (Highest = 15). 55350
The method 'decodedStateOfTreeData' has a Standard Cyclomatic Complexity of 14. 151214
The method decodedStateOfTreeData() has an NPath complexity of 2570 151214
The method 'decodedStateOfTreeData' has a Cyclomatic Complexity of 15. 151214
The method 'decodedStateOfTreeData' has a Modified Cyclomatic Complexity of 14. 151214
The method 'generateUrl' has a Cyclomatic Complexity of 12. 232290
The method 'generateUrl' has a Modified Cyclomatic Complexity of 11. 232290
The method 'generateUrl' has a Standard Cyclomatic Complexity of 11. 232290
Avoid if (x != y) ..; else ..; 240253
Avoid appending characters as strings in StringBuffer.append. 262
Avoid appending characters as strings in StringBuffer.append. 265
Avoid appending characters as strings in StringBuffer.append. 268
Avoid appending characters as strings in StringBuffer.append. 283
The method 'getBehaviorCommands' has a Cyclomatic Complexity of 10. 292327

Tobago Core - org/apache/myfaces/tobago/internal/util/ResponseUtils.java

Violation Line
The class 'ResponseUtils' has a Cyclomatic Complexity of 3 (Highest = 10). 35157
Avoid if (x != y) ..; else ..; 7485
The method 'ensureContentSecurityPolicyHeader' has a Cyclomatic Complexity of 10. 99137
Avoid declaring a variable if it is unreferenced before a possible exit point. 103
Avoid appending characters as strings in StringBuffer.append. 124
Avoid appending characters as strings in StringBuffer.append. 126
These nested if statements could be combined 133135

Tobago Core - org/apache/myfaces/tobago/internal/util/ResponseWriterBuffer.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 62

Tobago Core - org/apache/myfaces/tobago/internal/util/SelectItemUtils.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 45282
Avoid instantiation through private constructors from outside of the constructors class. 61
The class 'SelectItemsIterator' has a Standard Cyclomatic Complexity of 8 (Highest = 19). 87280
The class 'SelectItemsIterator' has a Modified Cyclomatic Complexity of 8 (Highest = 19). 87280
The class 'SelectItemsIterator' has a Cyclomatic Complexity of 9 (Highest = 21). 87280
The method 'hasNext' has a Modified Cyclomatic Complexity of 19. 102194
The method 'hasNext' has a Cyclomatic Complexity of 21. 102194
The method hasNext() has an NPath complexity of 864 102194
The method 'hasNext' has a Standard Cyclomatic Complexity of 19. 102194
Avoid instantiating new objects inside loops 187
The method 'next' has a Standard Cyclomatic Complexity of 12. 197274
The method 'next' has a Cyclomatic Complexity of 13. 197274
The method 'next' has a Modified Cyclomatic Complexity of 12. 197274
The method next() has an NPath complexity of 584 197274
Avoid unused local variables such as 'attributeMap'. 213
Avoid if (x != y) ..; else ..; 264268

Tobago Core - org/apache/myfaces/tobago/internal/util/StringUtils.java

Violation Line
Possible God class (WMC=125, ATFD=12, TCC=0.0) 20573
This class has too many methods, consider refactoring it. 27573
The class 'StringUtils' has a Standard Cyclomatic Complexity of 4 (Highest = 18). 27573
The class 'StringUtils' has a Modified Cyclomatic Complexity of 4 (Highest = 18). 27573
The class 'StringUtils' has a Cyclomatic Complexity of 4 (Highest = 18). 27573
Avoid instantiating new objects inside loops 45
Avoid instantiating Integer objects. Call Integer.valueOf() instead. 45
Avoid appending characters as strings in StringBuffer.append. 57
The method 'equalsIgnoreCaseAndWhitespace' has a Standard Cyclomatic Complexity of 11. 125179
The method 'equalsIgnoreCaseAndWhitespace' has a Modified Cyclomatic Complexity of 11. 125179
The method equalsIgnoreCaseAndWhitespace() has an NPath complexity of 378 125179
The method 'equalsIgnoreCaseAndWhitespace' has a Cyclomatic Complexity of 14. 125179
Use equals() to compare object references. 128
The method 'split' has a Standard Cyclomatic Complexity of 18. 233308
The method 'split' has a Cyclomatic Complexity of 18. 233308
The method 'split' has a Modified Cyclomatic Complexity of 18. 233308
Avoid declaring a variable if it is unreferenced before a possible exit point. 234
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 381
No need to call String.valueOf to append to a string. 420
The method 'containsAny' has a Cyclomatic Complexity of 11. 526558

Tobago Core - org/apache/myfaces/tobago/internal/util/StyleRenderUtils.java

Violation Line
A class which only has private constructors should be final 3280

Tobago Core - org/apache/myfaces/tobago/internal/webapp/DebugContentTypeFilter.java

Violation Line
Document empty method body 6163

Tobago Core - org/apache/myfaces/tobago/internal/webapp/DebugContentTypeResponse.java

Violation Line
These nested if statements could be combined 5557
These nested if statements could be combined 6567

Tobago Core - org/apache/myfaces/tobago/internal/webapp/DebugResponseWriterWrapper.java

Violation Line
This class has too many methods, consider refactoring it. 39225
Private field 'stack' could be made final; it is only initialized in the declaration or constructor. 41
Private field 'usedAttributes' could be made final; it is only initialized in the declaration or constructor. 42

Tobago Core - org/apache/myfaces/tobago/internal/webapp/HtmlResponseWriter.java

Violation Line
Document empty method body 107108

Tobago Core - org/apache/myfaces/tobago/internal/webapp/LoggingMdcFilter.java

Violation Line
Document empty method body 7577

Tobago Core - org/apache/myfaces/tobago/internal/webapp/TobagoResponseWriterBase.java

Violation Line
Possible God class (WMC=64, ATFD=16, TCC=0.1339031339031339) 20369
This class has too many methods, consider refactoring it. 36368
Avoid using redundant field initializer for 'i' 44
Avoid using redundant field initializer for 'inlineStack' 46
Avoid if (x != y) ..; else ..; 63
Avoid if (x != y) ..; else ..; 88111
Avoid if (x != y) ..; else ..; 90111
Avoid if (x != y) ..; else ..; 91104
Avoid if (x != y) ..; else ..; 9397
An empty method in an abstract class should be abstract instead 173175
An empty method in an abstract class should be abstract instead 178180

Tobago Core - org/apache/myfaces/tobago/internal/webapp/TobagoResponseWriterWrapper.java

Violation Line
This class has too many methods, consider refactoring it. 32150
Private field 'responseWriter' could be made final; it is only initialized in the declaration or constructor. 34

Tobago Core - org/apache/myfaces/tobago/internal/webapp/XmlResponseWriter.java

Violation Line
Document empty method body 8586
Document empty method body 8990

Tobago Core - org/apache/myfaces/tobago/layout/Display.java

Violation Line
A switch with less than three branches is inefficient, use a if statement instead. 5560

Tobago Core - org/apache/myfaces/tobago/layout/GridSpan.java

Violation Line
A class which only has private constructors should be final 2883
Position literals first in String comparisons 44
Avoid if (x != y) ..; else ..; 6173
Avoid if (x != y) ..; else ..; 6266
Avoid if (x != y) ..; else ..; 6872

Tobago Core - org/apache/myfaces/tobago/layout/MarginTokens.java

Violation Line
Private field 'margins' could be made final; it is only initialized in the declaration or constructor. 33

Tobago Core - org/apache/myfaces/tobago/layout/Measure.java

Violation Line
This class has too many methods, consider refactoring it. 31223
The class 'Measure' has a Cyclomatic Complexity of 3 (Highest = 10). 31223
The method 'valueOf' has a Cyclomatic Complexity of 10. 93124
Position literals first in String comparisons 109
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 115
Avoid if (x != y) ..; else ..; 187
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 216

Tobago Core - org/apache/myfaces/tobago/layout/MeasureList.java

Violation Line
Private field 'list' could be made final; it is only initialized in the declaration or constructor. 29
Document empty constructor 3132
Avoid appending characters as strings in StringBuffer.append. 66

Tobago Core - org/apache/myfaces/tobago/layout/PixelMeasure.java

Violation Line
Avoid unused private fields such as 'LOG'. 27
Avoid instantiating new objects inside loops 35
Avoid unnecessary if..then..else statements when returning booleans 6769

Tobago Core - org/apache/myfaces/tobago/layout/SegmentMeasureList.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2740

Tobago Core - org/apache/myfaces/tobago/lifecycle/SecretPhaseListener.java

Violation Line
Document empty method body 5152

Tobago Core - org/apache/myfaces/tobago/model/DateModel.java

Violation Line
Avoid if (x != y) ..; else ..; 7273

Tobago Core - org/apache/myfaces/tobago/model/ExpandedState.java

Violation Line
This class has too many methods, consider refactoring it. 34252
Private field 'expandedSet' could be made final; it is only initialized in the declaration or constructor. 37
Private field 'collapsedSet' could be made final; it is only initialized in the declaration or constructor. 38

Tobago Core - org/apache/myfaces/tobago/model/ScrollPosition.java

Violation Line
Avoid if (x != y) ..; else ..; 36
Avoid if (x != y) ..; else ..; 36
String.indexOf(char) is faster than String.indexOf(String). 49

Tobago Core - org/apache/myfaces/tobago/model/SelectedState.java

Violation Line
Private field 'selected' could be made final; it is only initialized in the declaration or constructor. 32

Tobago Core - org/apache/myfaces/tobago/model/SheetState.java

Violation Line
Avoid unused private fields such as 'LOG'. 36
Overridable method 'reset' called during object construction 51
Avoid if (x != y) ..; else ..; 6771
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 123

Tobago Core - org/apache/myfaces/tobago/model/SuggestFilter.java

Violation Line
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 33
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 40

Tobago Core - org/apache/myfaces/tobago/model/TreeNodeDataModel.java

Violation Line
Possible God class (WMC=57, ATFD=27, TCC=0.10666666666666667) 20306
Private field 'mapping' could be made final; it is only initialized in the declaration or constructor. 43
Private field 'back' could be made final; it is only initialized in the declaration or constructor. 44
Private field 'showRoot' could be made final; it is only initialized in the declaration or constructor. 45
Overridable method 'reset' called during object construction 59
Avoid instantiation through private constructors from outside of the constructors class. 69
Avoid instantiating new objects inside loops 69
Avoid instantiation through private constructors from outside of the constructors class. 89
Avoid instantiating new objects inside loops 89
Avoid instantiating new objects inside loops 210
Avoid if (x != y) ..; else ..; 240244
Private field 'node' could be made final; it is only initialized in the declaration or constructor. 287

Tobago Core - org/apache/myfaces/tobago/model/TreePath.java

Violation Line
Avoid if (x != y) ..; else ..; 126

Tobago Core - org/apache/myfaces/tobago/renderkit/RendererBase.java

Violation Line
Avoid if (x != y) ..; else ..; 6670
Document empty method body 7475

Tobago Core - org/apache/myfaces/tobago/renderkit/TobagoRenderKit.java

Violation Line
Private field 'renderers' could be made final; it is only initialized in the declaration or constructor. 53
Avoid instantiation through private constructors from outside of the constructors class. 66
Avoid instantiation through private constructors from outside of the constructors class. 102
Avoid unnecessary if..then..else statements when returning booleans 152154

Tobago Core - org/apache/myfaces/tobago/renderkit/css/BootstrapClass.java

Violation Line
Possible God class (WMC=96, ATFD=50, TCC=0.05128205128205128) 20822
Avoid using redundant field initializer for 'index' 605
Avoid long parameter lists. 607611
Avoid if (x != y) ..; else ..; 664672
Avoid autogenerated methods to access private fields and methods of inner / outer classes 679
Avoid autogenerated methods to access private fields and methods of inner / outer classes 682
Avoid if (x != y) ..; else ..; 693701
Consider using varargs for methods or constructors which take an array the last parameter. 704
The String literal "_AUTO" appears 4 times in this file; the first occurrence is on line 722 722
Avoid autogenerated methods to access private fields and methods of inner / outer classes 749
Avoid autogenerated methods to access private fields and methods of inner / outer classes 750
Avoid autogenerated methods to access private fields and methods of inner / outer classes 754
Avoid autogenerated methods to access private fields and methods of inner / outer classes 755
Avoid autogenerated methods to access private fields and methods of inner / outer classes 759
Avoid autogenerated methods to access private fields and methods of inner / outer classes 760
Avoid autogenerated methods to access private fields and methods of inner / outer classes 764
Avoid autogenerated methods to access private fields and methods of inner / outer classes 765
Avoid autogenerated methods to access private fields and methods of inner / outer classes 769
Avoid autogenerated methods to access private fields and methods of inner / outer classes 770

Tobago Core - org/apache/myfaces/tobago/renderkit/css/CustomClass.java

Violation Line
Avoid if (x != y) ..; else ..; 5568
Avoid if (x != y) ..; else ..; 5768
Avoid if (x != y) ..; else ..; 6165

Tobago Core - org/apache/myfaces/tobago/renderkit/css/FontAwesomeIconEncoder.java

Violation Line
Avoid unused private fields such as 'PATTERN'. 45
Avoid instantiating new objects inside loops 53
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 53
Private field 'name' could be made final; it is only initialized in the declaration or constructor. 90

Tobago Core - org/apache/myfaces/tobago/renderkit/css/Icons.java

Violation Line
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 66
Avoid autogenerated methods to access private fields and methods of inner / outer classes 80
Avoid autogenerated methods to access private fields and methods of inner / outer classes 83

Tobago Core - org/apache/myfaces/tobago/renderkit/css/Style.java

Violation Line
This class has a bunch of public methods and attributes 201097
Possible God class (WMC=204, ATFD=26, TCC=0.3278886872353297) 201097
The class 'Style' has a Cyclomatic Complexity of 2 (Highest = 28). 401097
Too many fields 401097
The class 'Style' has a Standard Cyclomatic Complexity of 2 (Highest = 28). 401097
The class 'Style' has a Modified Cyclomatic Complexity of 2 (Highest = 28). 401097
Avoid really long classes. 401097
Document empty constructor 111112
Overridable method 'checkEmptiness' called during object construction 153
The method 'encode' has a Cyclomatic Complexity of 28. 208349
The method encode() has an NCSS line count of 114 208349
Avoid really long methods. 208349
The method 'encode' has a Modified Cyclomatic Complexity of 28. 208349
The method encode() has an NPath complexity of 100663296 208349
The method 'encode' has a Standard Cyclomatic Complexity of 28. 208349
StringBuffer constructor is initialized with size 16, but has at least 26 characters appended. 211
Avoid if (x != y) ..; else ..; 213221
The method 'encodeJson' has a Standard Cyclomatic Complexity of 28. 351520
The method 'encodeJson' has a Cyclomatic Complexity of 28. 351520
Avoid really long methods. 351520
The method 'encodeJson' has a Modified Cyclomatic Complexity of 28. 351520
The method encodeJson() has an NPath complexity of 134217728 351520
The method encodeJson() has an NCSS line count of 136 351520
StringBuffer constructor is initialized with size 17, but has at least 78 characters appended. 352
The String literal "\"," appears 25 times in this file; the first occurrence is on line 358 358
Avoid appending characters as strings in StringBuffer.append. 505
Avoid if (x != y) ..; else ..; 523529
Avoid if (x != y) ..; else ..; 525529
Avoid if (x != y) ..; else ..; 543549
Avoid if (x != y) ..; else ..; 545549
Avoid if (x != y) ..; else ..; 563569
Avoid if (x != y) ..; else ..; 565569
Avoid if (x != y) ..; else ..; 583589
Avoid if (x != y) ..; else ..; 585589
Avoid if (x != y) ..; else ..; 603609
Avoid if (x != y) ..; else ..; 605609
Avoid if (x != y) ..; else ..; 623629
Avoid if (x != y) ..; else ..; 625629
Avoid if (x != y) ..; else ..; 643649
Avoid if (x != y) ..; else ..; 645649
Avoid if (x != y) ..; else ..; 663669
Avoid if (x != y) ..; else ..; 665669
Avoid if (x != y) ..; else ..; 683689
Avoid if (x != y) ..; else ..; 685689
Avoid if (x != y) ..; else ..; 703709
Avoid if (x != y) ..; else ..; 705709
Avoid if (x != y) ..; else ..; 723729
Avoid if (x != y) ..; else ..; 725729
Avoid if (x != y) ..; else ..; 743749
Avoid if (x != y) ..; else ..; 745749
Avoid if (x != y) ..; else ..; 763769
Avoid if (x != y) ..; else ..; 765769
Avoid if (x != y) ..; else ..; 783789
Avoid if (x != y) ..; else ..; 785789
Avoid if (x != y) ..; else ..; 803809
Avoid if (x != y) ..; else ..; 805809
Avoid if (x != y) ..; else ..; 823829
Avoid if (x != y) ..; else ..; 825829
Avoid if (x != y) ..; else ..; 843849
Avoid if (x != y) ..; else ..; 845849
Avoid if (x != y) ..; else ..; 863869
Avoid if (x != y) ..; else ..; 865869
Avoid if (x != y) ..; else ..; 883896
Avoid if (x != y) ..; else ..; 887891
Avoid if (x != y) ..; else ..; 892896
Avoid if (x != y) ..; else ..; 910923
Avoid if (x != y) ..; else ..; 914918
Avoid if (x != y) ..; else ..; 919923
Avoid if (x != y) ..; else ..; 937950
Avoid if (x != y) ..; else ..; 941945
Avoid if (x != y) ..; else ..; 946950
Avoid if (x != y) ..; else ..; 964977
Avoid if (x != y) ..; else ..; 968972
Avoid if (x != y) ..; else ..; 973977
Avoid if (x != y) ..; else ..; 992998
Avoid if (x != y) ..; else ..; 994998
Avoid if (x != y) ..; else ..; 10151021
Avoid if (x != y) ..; else ..; 10171021
Avoid if (x != y) ..; else ..; 10381051
Avoid if (x != y) ..; else ..; 10421046
Avoid if (x != y) ..; else ..; 10471051
Avoid if (x != y) ..; else ..; 10671080
Avoid if (x != y) ..; else ..; 10711075
Avoid if (x != y) ..; else ..; 10761080

Tobago Core - org/apache/myfaces/tobago/renderkit/css/Styles.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 68

Tobago Core - org/apache/myfaces/tobago/renderkit/css/TobagoClass.java

Violation Line
Avoid if (x != y) ..; else ..; 254262
Avoid instantiating new objects inside loops 257
Avoid instantiation through private constructors from outside of the constructors class. 257
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 279
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 280

Tobago Core - org/apache/myfaces/tobago/sanitizer/JsoupSanitizer.java

Violation Line
Avoid using redundant field initializer for 'unmodifiable' 40

Tobago Core - org/apache/myfaces/tobago/servlet/NonFacesRequestServlet.java

Violation Line
Avoid declaring a variable if it is unreferenced before a possible exit point. 61
An empty method in an abstract class should be abstract instead 9597

Tobago Core - org/apache/myfaces/tobago/servlet/ResourceServlet.java

Violation Line
Avoid instantiating Long objects.Call Long.valueOf() instead 87
Avoid if (x != y) ..; else ..; 117127
Avoid if (x != y) ..; else ..; 130136
Parameter 'resource' is not assigned and could be declared final 140
Avoid if (x != y) ..; else ..; 154158

Tobago Core - org/apache/myfaces/tobago/util/AjaxUtils.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3277

Tobago Core - org/apache/myfaces/tobago/util/BeanComparator.java

Violation Line
Private field 'property' could be made final; it is only initialized in the declaration or constructor. 35
Avoid if (x != y) ..; else ..; 72

Tobago Core - org/apache/myfaces/tobago/util/ComparatorBase.java

Violation Line
The class 'ComparatorBase' has a Modified Cyclomatic Complexity of 3 (Highest = 12). 27112
The class 'ComparatorBase' has a Standard Cyclomatic Complexity of 3 (Highest = 12). 27112
The class 'ComparatorBase' has a Cyclomatic Complexity of 3 (Highest = 14). 27112
Document empty constructor 3334
The method 'internalCompare' has a Modified Cyclomatic Complexity of 12. 4989
The method 'internalCompare' has a Standard Cyclomatic Complexity of 12. 4989
The method 'internalCompare' has a Cyclomatic Complexity of 14. 4989
The method internalCompare() has an NPath complexity of 1600 4989
Avoid if (x != y) ..; else ..; 7787
Parameter 'o' is not assigned and could be declared final 91
Avoid if (x != y) ..; else ..; 101
Avoid if (x != y) ..; else ..; 106

Tobago Core - org/apache/myfaces/tobago/util/ComponentUtils.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20902
Possible God class (WMC=196, ATFD=111, TCC=7.84313725490196E-4) 20902
This class has a bunch of public methods and attributes 20902
The class 'ComponentUtils' has a Cyclomatic Complexity of 3 (Highest = 12). 67902
The class 'ComponentUtils' has a Standard Cyclomatic Complexity of 3 (Highest = 12). 67902
This class has too many methods, consider refactoring it. 67902
The class 'ComponentUtils' has a Modified Cyclomatic Complexity of 3 (Highest = 12). 67902
Avoid if (x != y) ..; else ..; 151155
Avoid if (x != y) ..; else ..; 160170
Avoid if (x != y) ..; else ..; 276284
Avoid if (x != y) ..; else ..; 475
Consider simply returning the value vs storing it in local variable 'myRenderer' 577
The method 'findComponent' has a Cyclomatic Complexity of 10. 616651
Consider using varargs for methods or constructors which take an array the last parameter. 657
Avoid if (x != y) ..; else ..; 691
The method 'getConvertedValue' has a Cyclomatic Complexity of 12. 699738
The method 'getConvertedValue' has a Modified Cyclomatic Complexity of 12. 699738
The method 'getConvertedValue' has a Standard Cyclomatic Complexity of 12. 699738
Avoid if (x != y) ..; else ..; 703733
Avoid if (x != y) ..; else ..; 812
These nested if statements could be combined 836838
Avoid if (x != y) ..; else ..; 858862

Tobago Core - org/apache/myfaces/tobago/util/DebugNavigationHandler.java

Violation Line
Private field 'navigationHandler' could be made final; it is only initialized in the declaration or constructor. 32

Tobago Core - org/apache/myfaces/tobago/util/DebugPhaseListener.java

Violation Line
The class 'DebugPhaseListener' has a Standard Cyclomatic Complexity of 8 (Highest = 13). 38156
The class 'DebugPhaseListener' has a Cyclomatic Complexity of 10 (Highest = 16). 38156
The class 'DebugPhaseListener' has a Modified Cyclomatic Complexity of 8 (Highest = 13). 38156
The method 'afterPhase' has a Cyclomatic Complexity of 11. 4591
The method 'afterPhase' has a Modified Cyclomatic Complexity of 10. 4591
The method 'afterPhase' has a Standard Cyclomatic Complexity of 10. 4591
Deeply nested if..then statements are hard to read 6772
Deeply nested if..then statements are hard to read 7577
The method 'beforePhase' has a Modified Cyclomatic Complexity of 13. 94150
The method beforePhase() has an NPath complexity of 572 94150
The method 'beforePhase' has a Standard Cyclomatic Complexity of 13. 94150
The method 'beforePhase' has a Cyclomatic Complexity of 16. 94150
Avoid declaring a variable if it is unreferenced before a possible exit point. 96
Deeply nested if..then statements are hard to read 112128
Deeply nested if..then statements are hard to read 134144
Deeply nested if..then statements are hard to read 145147

Tobago Core - org/apache/myfaces/tobago/util/DebugUtils.java

Violation Line
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 57
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 80
Avoid appending characters as strings in StringBuffer.append. 80
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 81
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 82
Avoid appending characters as strings in StringBuffer.append. 82
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 90
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 91

Tobago Core - org/apache/myfaces/tobago/util/MessageFormat.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2782
Avoid long parameter lists. 7173

Tobago Core - org/apache/myfaces/tobago/util/MessageUtils.java

Violation Line
The class 'MessageUtils' has a Cyclomatic Complexity of 4 (Highest = 15). 43149
The class 'MessageUtils' has a Standard Cyclomatic Complexity of 3 (Highest = 11). 43149
The class 'MessageUtils' has a Modified Cyclomatic Complexity of 3 (Highest = 11). 43149
Consider using varargs for methods or constructors which take an array the last parameter. 52
The method getMessage() has an NPath complexity of 468 57104
The method 'getMessage' has a Standard Cyclomatic Complexity of 11. 57104
The method 'getMessage' has a Cyclomatic Complexity of 15. 57104
The method 'getMessage' has a Modified Cyclomatic Complexity of 11. 57104
Deeply nested if..then statements are hard to read 7678
Deeply nested if..then statements are hard to read 7981
Avoid if (x != y) ..; else ..; 117

Tobago Core - org/apache/myfaces/tobago/util/ValueExpressionComparator.java

Violation Line
The class 'ValueExpressionComparator' has a Standard Cyclomatic Complexity of 3 (Highest = 10). 30131
The class 'ValueExpressionComparator' has a Modified Cyclomatic Complexity of 3 (Highest = 10). 30131
The class 'ValueExpressionComparator' has a Cyclomatic Complexity of 3 (Highest = 11). 30131
Private field 'facesContext' could be made final; it is only initialized in the declaration or constructor. 34
Private field 'var' could be made final; it is only initialized in the declaration or constructor. 36
Private field 'valueExpression' could be made final; it is only initialized in the declaration or constructor. 38
The method 'equals' has a Cyclomatic Complexity of 11. 77101
The method 'equals' has a Modified Cyclomatic Complexity of 10. 77101
The method 'equals' has a Standard Cyclomatic Complexity of 10. 77101
Avoid declaring a variable if it is unreferenced before a possible exit point. 85
Avoid if (x != y) ..; else ..; 90
Avoid if (x != y) ..; else ..; 93
Avoid unnecessary if..then..else statements when returning booleans 9698
Avoid if (x != y) ..; else ..; 96
Avoid if (x != y) ..; else ..; 105
Avoid if (x != y) ..; else ..; 106
Avoid if (x != y) ..; else ..; 107

Tobago Core - org/apache/myfaces/tobago/util/WebXmlUtils.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 44188
The class 'WebXmlUtils' has a Modified Cyclomatic Complexity of 5 (Highest = 13). 44188
The class 'WebXmlUtils' has a Standard Cyclomatic Complexity of 5 (Highest = 13). 44188
The class 'WebXmlUtils' has a Cyclomatic Complexity of 5 (Highest = 14). 44188
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 49
The method 'init' has a Cyclomatic Complexity of 14. 68121
The method 'init' has a Standard Cyclomatic Complexity of 13. 68121
The method 'init' has a Modified Cyclomatic Complexity of 13. 68121
Avoid if (x != y) ..; else ..; 102110
Avoid if (x != y) ..; else ..; 115
Avoid if (x != y) ..; else ..; 151162
Avoid if (x != y) ..; else ..; 170186
Avoid if (x != y) ..; else ..; 179

Tobago Core - org/apache/myfaces/tobago/validator/FileItemValidator.java

Violation Line
The class 'FileItemValidator' has a Cyclomatic Complexity of 2 (Highest = 12). 40132
Avoid using redundant field initializer for 'maxSize' 44
Document empty constructor 5152
The method 'validate' has a Cyclomatic Complexity of 12. 5588
Deeply nested if..then statements are hard to read 6972
Deeply nested if..then statements are hard to read 7680
Consider using varargs for methods or constructors which take an array the last parameter. 104

Tobago Core - org/apache/myfaces/tobago/validator/SubmittedValueLengthValidator.java

Violation Line
Document empty constructor 4445
Avoid if (x != y) ..; else ..; 58
Avoid if (x != y) ..; else ..; 70
Avoid if (x != y) ..; else ..; 128
Avoid unnecessary if..then..else statements when returning booleans 131133
Avoid if (x != y) ..; else ..; 131
Avoid if (x != y) ..; else ..; 140
Avoid if (x != y) ..; else ..; 141

Tobago Core - org/apache/myfaces/tobago/webapp/AjaxExceptionHandler.java

Violation Line
Private field 'wrapped' could be made final; it is only initialized in the declaration or constructor. 46
Avoid if (x != y) ..; else ..; 7093

Tobago Core - org/apache/myfaces/tobago/webapp/AjaxExceptionHandlerFactory.java

Violation Line
Private field 'parent' could be made final; it is only initialized in the declaration or constructor. 27

Tobago Core - org/apache/myfaces/tobago/webapp/LogoutActionListener.java

Violation Line
New exception is thrown in catch block, original stack trace may be lost 59

Tobago Core - org/apache/myfaces/tobago/webapp/Secret.java

Violation Line
Private field 'secret' could be made final; it is only initialized in the declaration or constructor. 41

Tobago Core - org/apache/myfaces/tobago/webapp/SecretSessionListener.java

Violation Line
Document empty method body 3839

Tobago Core - org/apache/myfaces/tobago/webapp/TobagoResponseWriter.java

Violation Line
This class has too many methods, consider refactoring it. 45281
Private field 'iconEncoder' could be made final; it is only initialized in the declaration or constructor. 47

Tobago Core - org/apache/myfaces/tobago/webapp/TobagoServletContextListener.java

Violation Line
Avoid if (x != y) ..; else ..; 4650
StringBuffer constructor is initialized with size 16, but has at least 87 characters appended. 59
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 60
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 60
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 61
StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. 64

Tobago Example Data - org/apache/myfaces/tobago/example/data/CantorInterval.java

Violation Line
Private field 'begin' could be made final; it is only initialized in the declaration or constructor. 34
Private field 'end' could be made final; it is only initialized in the declaration or constructor. 35
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 82
Avoid appending characters as strings in StringBuffer.append. 82
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 83
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 84
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 85
Avoid appending characters as strings in StringBuffer.append. 86
Avoid appending characters as strings in StringBuffer.append. 147

Tobago Example Data - org/apache/myfaces/tobago/example/data/CategoryTree.java

Violation Line
A class which only has private constructors should be final 2691
Avoid instantiating new objects inside loops 84

Tobago Example Data - org/apache/myfaces/tobago/example/data/CommandNode.java

Violation Line
Private field 'name' could be made final; it is only initialized in the declaration or constructor. 26

Tobago Example Data - org/apache/myfaces/tobago/example/data/CommandNodeFactory.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2240

Tobago Example Data - org/apache/myfaces/tobago/example/data/LocaleList.java

Violation Line
A class which only has private constructors should be final 3297
Avoid instantiating new objects inside loops 46

Tobago Example Data - org/apache/myfaces/tobago/example/data/MixedCommandTree.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2246

Tobago Example Data - org/apache/myfaces/tobago/example/data/NamedNode.java

Violation Line
Private field 'name' could be made final; it is only initialized in the declaration or constructor. 32

Tobago Example Data - org/apache/myfaces/tobago/example/data/SmallTree.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2434

Tobago Example Data - org/apache/myfaces/tobago/example/data/SolarObject.java

Violation Line
Overridable method 'getPopulation' called during object construction 86
The String literal "Sun" appears 13 times in this file; the first occurrence is on line 103 103
Position literals first in String comparisons 103
Position literals first in String comparisons 106
Avoid if (x != y) ..; else ..; 187
Position literals first in String comparisons 199
Avoid instantiating new objects inside loops 217
Position literals first in String comparisons 220
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 251
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 252253
The String literal "III" appears 5 times in this file; the first occurrence is on line 253 253
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 254
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 256345
The String literal "Jupiter" appears 28 times in this file; the first occurrence is on line 262 262
The String literal "Saturn" appears 19 times in this file; the first occurrence is on line 263 263
The String literal "VII" appears 5 times in this file; the first occurrence is on line 264 264
The String literal "Uranus" appears 22 times in this file; the first occurrence is on line 264 264
The String literal "Herschel" appears 5 times in this file; the first occurrence is on line 264 264
The String literal "VIII" appears 5 times in this file; the first occurrence is on line 265 265
The String literal "Neptune" appears 9 times in this file; the first occurrence is on line 265 265
The String literal "Galileo" appears 4 times in this file; the first occurrence is on line 274 274
The String literal "Sheppard" appears 11 times in this file; the first occurrence is on line 278 278
The String literal "Nicholson" appears 5 times in this file; the first occurrence is on line 281 281
The String literal "Cassini" appears 4 times in this file; the first occurrence is on line 305 305
The String literal "Voyager 2" appears 15 times in this file; the first occurrence is on line 315 315

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/BootstrapUtils.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2432

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/CkeditorController.java

Violation Line
Private field 'contentSecurityPolicyMode' could be made final; it is only initialized in the declaration or constructor. 33

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/CollapsibleBoxController.java

Violation Line
Avoid using redundant field initializer for 'collapsed' 30

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/CollapsiblePanelController.java

Violation Line
Avoid using redundant field initializer for 'panelCollapsed' 30

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/CollapsibleSectionController.java

Violation Line
Avoid using redundant field initializer for 'collapsed' 30

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ConversationController.java

Violation Line
Avoid unused private fields such as 'LOG'. 35
Avoid using redundant field initializer for 'count' 39
Avoid if (x != y) ..; else ..; 42

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/CurrentValueController.java

Violation Line
Private field 'string' could be made final; it is only initialized in the declaration or constructor. 38
Private field 'currency' could be made final; it is only initialized in the declaration or constructor. 40
When instantiating a SimpleDateFormat object, specify a Locale 47
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 56
Avoid if (x != y) ..; else ..; 56

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/DateController.java

Violation Line
When instantiating a SimpleDateFormat object, specify a Locale 44

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/DemoBundle.java

Violation Line
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 2942

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/DemoController.java

Violation Line
Private field 'currencyItems' could be made final; it is only initialized in the declaration or constructor. 63
Do not add empty strings 113
Avoid instantiating new objects inside loops 115
Consider using varargs for methods or constructors which take an array the last parameter. 120
Do not add empty strings 125
Avoid instantiating new objects inside loops 127
Avoid if (x != y) ..; else ..; 139143
Consider using varargs for methods or constructors which take an array the last parameter. 210

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/DemoException.java

Violation Line
Parameter 'message' is not assigned and could be declared final 24

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/EventController.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20353
Private field 'eventsOnComponents' could be made final; it is only initialized in the declaration or constructor. 98
Avoid using redundant field initializer for 'action' 101
Avoid using redundant field initializer for 'actionListener' 102
Avoid using redundant field initializer for 'ajaxListener' 103
Avoid using redundant field initializer for 'valueChangeListener' 104
Private field 'planets' could be made final; it is only initialized in the declaration or constructor. 105
The String literal "Sun" appears 8 times in this file; the first occurrence is on line 164 164
Avoid if (x != y) ..; else ..; 195
This class has too many methods, consider refactoring it. 239343
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 245
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 327

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ExceptionHandlerController.java

Violation Line
Private field 'solarList' could be made final; it is only initialized in the declaration or constructor. 39

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ForEachController.java

Violation Line
Overridable method 'reset' called during object construction 39
Private field 'name' could be made final; it is only initialized in the declaration or constructor. 92
Private field 'length' could be made final; it is only initialized in the declaration or constructor. 93
Private field 'discharge' could be made final; it is only initialized in the declaration or constructor. 94

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/FormController.java

Violation Line
Avoid unused private fields such as 'LOG'. 33

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/InputSuggestController.java

Violation Line
Private field 'suggestData' could be made final; it is only initialized in the declaration or constructor. 51
The String literal "Niedersachsen" appears 6 times in this file; the first occurrence is on line 52 52
Avoid instantiating new objects inside loops 158
Avoid instantiating new objects inside loops 161
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 170
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 170
Avoid instantiating new objects inside loops 171
Avoid instantiating new objects inside loops 174

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/LocaleController.java

Violation Line
Avoid if (x != y) ..; else ..; 5660
Avoid if (x != y) ..; else ..; 97101
Avoid if (x != y) ..; else ..; 115119

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ManifestReader.java

Violation Line
Avoid instantiating new objects inside loops 67
Avoid instantiating new objects inside loops 70
Avoid instantiating new objects inside loops 73
When instantiating a SimpleDateFormat object, specify a Locale 76
Avoid instantiating new objects inside loops 76

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/NavigationNode.java

Violation Line
Private field 'tree' could be made final; it is only initialized in the declaration or constructor. 40
Avoid unused local variables such as 'extension'. 55

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/NavigationState.java

Violation Line
Private field 'state' could be made final; it is only initialized in the declaration or constructor. 47
Avoid if (x != y) ..; else ..; 7782
Avoid if (x != y) ..; else ..; 9196

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/NavigationTree.java

Violation Line
Avoid instantiating new objects inside loops 80
Position literals first in String comparisons 98
Avoid if (x != y) ..; else ..; 148152

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/PartialReloadController.java

Violation Line
Do not add empty strings 117

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/PlanetExample.java

Violation Line
This abstract class does not have any abstract methods 2476
Private field 'planets' could be made final; it is only initialized in the declaration or constructor. 26
Private field 'earthMoons' could be made final; it is only initialized in the declaration or constructor. 27
Private field 'marsMoons' could be made final; it is only initialized in the declaration or constructor. 28
Private field 'jupiterMoons' could be made final; it is only initialized in the declaration or constructor. 29

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/PrettyUrlForMenuNavigationHandler.java

Violation Line
Private field 'navigationHandler' could be made final; it is only initialized in the declaration or constructor. 34

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ProgressController.java

Violation Line
Avoid unused private fields such as 'LOG'. 37
Private field 'progress' could be made final; it is only initialized in the declaration or constructor. 39
When instantiating a SimpleDateFormat object, specify a Locale 64
When instantiating a SimpleDateFormat object, specify a Locale 69
When instantiating a SimpleDateFormat object, specify a Locale 74

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SelectController.java

Violation Line
Private field 'entries' could be made final; it is only initialized in the declaration or constructor. 32

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SelectItemModel.java

Violation Line
Avoid instantiating new objects inside loops 51

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SelectManyListboxController.java

Violation Line
Private field 'deserts' could be made final; it is only initialized in the declaration or constructor. 35

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SelectManyShuttleController.java

Violation Line
Private field 'planets' could be made final; it is only initialized in the declaration or constructor. 35
Private field 'stars' could be made final; it is only initialized in the declaration or constructor. 37
Consider using varargs for methods or constructors which take an array the last parameter. 52
Consider using varargs for methods or constructors which take an array the last parameter. 68

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SelectOneListboxController.java

Violation Line
Private field 'mountains' could be made final; it is only initialized in the declaration or constructor. 33

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ServerInfo.java

Violation Line
Private field 'version' could be made final; it is only initialized in the declaration or constructor. 55
Private field 'enabled' could be made final; it is only initialized in the declaration or constructor. 60

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SheetConfig.java

Violation Line
Private field 'sheetDirectLinkCountItems' could be made final; it is only initialized in the declaration or constructor. 39
Private field 'sheetPagingPositionItems' could be made final; it is only initialized in the declaration or constructor. 40
Consider using varargs for methods or constructors which take an array the last parameter. 75
Avoid instantiating new objects inside loops 79
Consider using varargs for methods or constructors which take an array the last parameter. 174

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SheetController.java

Violation Line
Avoid instantiating new objects inside loops 63
Private field 'solarList' could be made final; it is only initialized in the declaration or constructor. 67
Private field 'hugeSolarList' could be made final; it is only initialized in the declaration or constructor. 68
Avoid instantiating new objects inside loops 82
Avoid if (x != y) ..; else ..; 108114

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SheetFilterController.java

Violation Line
Possible God class (WMC=55, ATFD=29, TCC=0.05026455026455026) 20308
The class 'SheetFilterController' has a Modified Cyclomatic Complexity of 2 (Highest = 10). 43308
The class 'SheetFilterController' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 43308
The class 'SheetFilterController' has a Cyclomatic Complexity of 2 (Highest = 16). 43308
Private field 'filteredSolarList' could be made final; it is only initialized in the declaration or constructor. 47
Private field 'distanceItems' could be made final; it is only initialized in the declaration or constructor. 49
Private field 'minYearItems' could be made final; it is only initialized in the declaration or constructor. 50
Private field 'maxYearItems' could be made final; it is only initialized in the declaration or constructor. 51
Private field 'distanceRangeConverter' could be made final; it is only initialized in the declaration or constructor. 53
Avoid instantiating new objects inside loops 88
Overridable method 'filter' called during object construction 98
The method 'filter' has a Modified Cyclomatic Complexity of 10. 101135
The method filter() has an NPath complexity of 1088 101135
The method 'filter' has a Standard Cyclomatic Complexity of 10. 101135
The method 'filter' has a Cyclomatic Complexity of 16. 101135
Avoid if (x != y) ..; else ..; 218
Private field 'min' could be made final; it is only initialized in the declaration or constructor. 232
Private field 'max' could be made final; it is only initialized in the declaration or constructor. 233
No need to call String.valueOf to append to a string. 239
No need to call String.valueOf to append to a string. 239
Avoid autogenerated methods to access private fields and methods of inner / outer classes 283
Avoid autogenerated methods to access private fields and methods of inner / outer classes 288
Avoid autogenerated methods to access private fields and methods of inner / outer classes 290
Avoid autogenerated methods to access private fields and methods of inner / outer classes 291
Avoid autogenerated methods to access private fields and methods of inner / outer classes 299
Avoid autogenerated methods to access private fields and methods of inner / outer classes 305

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SheetSortingController.java

Violation Line
Avoid if (x != y) ..; else ..; 64

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SheetTreeController.java

Violation Line
Private field 'solarTree' could be made final; it is only initialized in the declaration or constructor. 33

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SourceFileReader.java

Violation Line
This abstract class does not have any abstract methods 3149
String.indexOf(char) is faster than String.indexOf(String). 39

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/SuggestController.java

Violation Line
Private field 'solarObjects' could be made final; it is only initialized in the declaration or constructor. 40
Avoid if (x != y) ..; else ..; 58

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/TabController.java

Violation Line
Avoid unused private fields such as 'LOG'. 35
Private field 'open' could be made final; it is only initialized in the declaration or constructor. 37
Private field 'close' could be made final; it is only initialized in the declaration or constructor. 38
Avoid if (x != y) ..; else ..; 5559
Avoid if (x != y) ..; else ..; 6367
Avoid if (x != y) ..; else ..; 7175

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/TestController.java

Violation Line
Avoid instantiating new objects inside loops 66
Avoid instantiating new objects inside loops 93

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/TestExceptionHandler.java

Violation Line
Private field 'wrapped' could be made final; it is only initialized in the declaration or constructor. 37
Avoid instantiating new objects inside loops 61

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/TestExceptionHandlerFactory.java

Violation Line
Private field 'parent' could be made final; it is only initialized in the declaration or constructor. 27

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/ThemeController.java

Violation Line
Avoid instantiating new objects inside loops 50
Consider using varargs for methods or constructors which take an array the last parameter. 67

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/TreeCommandTypesController.java

Violation Line
Private field 'sample' could be made final; it is only initialized in the declaration or constructor. 33
Avoid using redundant field initializer for 'actionOneCount' 34
Avoid using redundant field initializer for 'actionTwoCount' 35

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/TreeController.java

Violation Line
Private field 'sample' could be made final; it is only initialized in the declaration or constructor. 33
Avoid using redundant field initializer for 'treeShowRoot' 34
Avoid using redundant field initializer for 'treeShowRootJunction' 35

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/TreeEditorController.java

Violation Line
This class has too many methods, consider refactoring it. 37220
Avoid if (x != y) ..; else ..; 6570
Avoid if (x != y) ..; else ..; 7685
Avoid if (x != y) ..; else ..; 7782
Avoid if (x != y) ..; else ..; 129141
Avoid if (x != y) ..; else ..; 177183
Avoid if (x != y) ..; else ..; 192198

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/TreeSelectController.java

Violation Line
Private field 'sample' could be made final; it is only initialized in the declaration or constructor. 34
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 76

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/UniversalLoggingInfo.java

Violation Line
Private field 'jul' could be made final; it is only initialized in the declaration or constructor. 46
Private field 'slf4j' could be made final; it is only initialized in the declaration or constructor. 51
Private field 'log4j' could be made final; it is only initialized in the declaration or constructor. 53
Private field 'log4j2' could be made final; it is only initialized in the declaration or constructor. 55
Private field 'commonsLogging' could be made final; it is only initialized in the declaration or constructor. 57
The String literal "getLogger" appears 4 times in this file; the first occurrence is on line 62 62
The String literal "info" appears 5 times in this file; the first occurrence is on line 67 67
The String literal "trace" appears 4 times in this file; the first occurrence is on line 71 71
The String literal "debug" appears 4 times in this file; the first occurrence is on line 72 72
The String literal "warn" appears 4 times in this file; the first occurrence is on line 74 74
The String literal "error" appears 4 times in this file; the first occurrence is on line 75 75
Overridable method 'update' called during object construction 97
Avoid if (x != y) ..; else ..; 134138
Private field 'id' could be made final; it is only initialized in the declaration or constructor. 143
Private field 'calls' could be made final; it is only initialized in the declaration or constructor. 145
Private field 'factoryClassName' could be made final; it is only initialized in the declaration or constructor. 147
Private field 'factoryMethod' could be made final; it is only initialized in the declaration or constructor. 148
Private field 'usesString' could be made final; it is only initialized in the declaration or constructor. 149
Overridable method 'reset' called during object construction 158
Avoid autogenerated methods to access private fields and methods of inner / outer classes 166
A method/constructor shouldnt explicitly throw java.lang.Exception 171
Avoid autogenerated methods to access private fields and methods of inner / outer classes 193
Avoid if (x != y) ..; else ..; 196213
Avoid autogenerated methods to access private fields and methods of inner / outer classes 206
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 235
Consider simply returning the value vs storing it in local variable 'hasLevel' 237
When doing a String.toLowerCase()/toUpperCase() call, use a Locale 249
Consider simply returning the value vs storing it in local variable 'hasLevel' 251

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/UploadController.java

Violation Line
Private field 'uploadItems' could be made final; it is only initialized in the declaration or constructor. 46
Consider using varargs for methods or constructors which take an array the last parameter. 104

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/UploadItem.java

Violation Line
Avoid unused private fields such as 'LOG'. 29

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/actionlistener/SimpleTabChangeListener.java

Violation Line
Avoid using redundant field initializer for 'count' 27

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/bestpractice/BestPracticeController.java

Violation Line
Parameter 'facesContext' is not assigned and could be declared final 73
Parameter 'pdf' is not assigned and could be declared final 73

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/bestpractice/ToolBarCustomizer.java

Violation Line
Overridable method 'resetList' called during object construction 39
Avoid instantiation through private constructors from outside of the constructors class. 44
Avoid instantiation through private constructors from outside of the constructors class. 45
Avoid instantiation through private constructors from outside of the constructors class. 46
Private field 'label' could be made final; it is only initialized in the declaration or constructor. 76
Private field 'name' could be made final; it is only initialized in the declaration or constructor. 77

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/info/ActivityList.java

Violation Line
Private field 'data' could be made final; it is only initialized in the declaration or constructor. 42
Avoid if (x != y) ..; else ..; 6367
Avoid if (x != y) ..; else ..; 7276

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/info/ActivityPhaseListener.java

Violation Line
Document empty constructor 3738
Document empty method body 5354

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/nonfacesrequest/FishPond.java

Violation Line
Private field 'fishes' could be made final; it is only initialized in the declaration or constructor. 38
Avoid using redundant field initializer for 'selectedFishId' 40

Tobago Example Demo - org/apache/myfaces/tobago/example/demo/sudoku/Sudoku.java

Violation Line
Avoid instantiation through private constructors from outside of the constructors class. 62
Avoid instantiation through private constructors from outside of the constructors class. 82
Avoid instantiating new objects inside loops 132
Avoid instantiating new objects inside loops 149
Avoid instantiating new objects inside loops 166
Avoid autogenerated methods to access private fields and methods of inner / outer classes 183
Avoid instantiation through private constructors from outside of the constructors class. 183
Do not add empty strings 183
Do not add empty strings 187
Do not add empty strings 189
Avoid if (x != y) ..; else ..; 201205
Private field 'n' could be made final; it is only initialized in the declaration or constructor. 215
Private field 'list' could be made final; it is only initialized in the declaration or constructor. 216
Avoid autogenerated methods to access private fields and methods of inner / outer classes 230

Tobago Example Demo - org/apache/myfaces/tobago/example/test/Bootstrap.java

Violation Line
Overridable method 'reset' called during object construction 27

Tobago Example Demo - org/apache/myfaces/tobago/example/test/DateController.java

Violation Line
When instantiating a SimpleDateFormat object, specify a Locale 38

Tobago Example Demo - org/apache/myfaces/tobago/example/test/DynamicBean.java

Violation Line
Private field 'panels' could be made final; it is only initialized in the declaration or constructor. 30
A switch statement does not contain a break 3447

Tobago Example Demo - org/apache/myfaces/tobago/example/test/DynamicPanel.java

Violation Line
This abstract class does not have any abstract methods 2240

Tobago Example Demo - org/apache/myfaces/tobago/example/test/Hidden.java

Violation Line
Avoid unused private fields such as 'LOG'. 31

Tobago Example Demo - org/apache/myfaces/tobago/example/test/Immediate.java

Violation Line
Private field 'selectItems' could be made final; it is only initialized in the declaration or constructor. 35
Consider using varargs for methods or constructors which take an array the last parameter. 73

Tobago Example Demo - org/apache/myfaces/tobago/example/test/MeasureBean.java

Violation Line
Private field 'value' could be made final; it is only initialized in the declaration or constructor. 84

Tobago Example Demo - org/apache/myfaces/tobago/example/test/Partially.java

Violation Line
StringBuffer constructor is initialized with size 16, but has at least 30 characters appended. 31
Avoid appending characters as strings in StringBuffer.append. 42

Tobago Example Demo - org/apache/myfaces/tobago/example/test/PopupReferenceController.java

Violation Line
Private field 'sheet' could be made final; it is only initialized in the declaration or constructor. 38
Avoid instantiating new objects inside loops 44

Tobago Example Demo - org/apache/myfaces/tobago/example/test/ResourceEntry.java

Violation Line
Perhaps 'key' could be replaced by a local variable. 27
Avoid unused private fields such as 'key'. 27

Tobago Example Demo - org/apache/myfaces/tobago/example/test/ScriptEvent.java

Violation Line
Private field 'items' could be made final; it is only initialized in the declaration or constructor. 28

Tobago Example Demo - org/apache/myfaces/tobago/example/test/ScriptEventItem.java

Violation Line
Private field 'name' could be made final; it is only initialized in the declaration or constructor. 31
Private field 'time' could be made final; it is only initialized in the declaration or constructor. 32

Tobago Example Demo - org/apache/myfaces/tobago/example/test/ScriptEventServlet.java

Violation Line
Position literals first in String comparisons 44
Position literals first in String comparisons 46
Position literals first in String comparisons 48

Tobago Example Demo - org/apache/myfaces/tobago/example/test/SelectManyListboxBean.java

Violation Line
Private field 'currencyItems' could be made final; it is only initialized in the declaration or constructor. 42
Consider using varargs for methods or constructors which take an array the last parameter. 65
Consider using varargs for methods or constructors which take an array the last parameter. 97

Tobago Example Demo - org/apache/myfaces/tobago/example/test/SheetController.java

Violation Line
Private field 'solarArray' could be made final; it is only initialized in the declaration or constructor. 33
Private field 'solarArray3' could be made final; it is only initialized in the declaration or constructor. 34
Private field 'undefined' could be made final; it is only initialized in the declaration or constructor. 35
System.arraycopy is more efficient 4345
Private field 'localeList' could be made final; it is only initialized in the declaration or constructor. 50
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 50

Tobago Example Demo - org/apache/myfaces/tobago/example/test/SheetSortController.java

Violation Line
Avoid instantiating new objects inside loops 47
Avoid instantiation through private constructors from outside of the constructors class. 47
Do not add empty strings 66
Do not add empty strings 68
Do not add empty strings 70
Do not add empty strings 72
Avoid autogenerated methods to access private fields and methods of inner / outer classes 80
Do not add empty strings 83

Tobago Example Demo - org/apache/myfaces/tobago/example/test/TreeController.java

Violation Line
Private field 'tree' could be made final; it is only initialized in the declaration or constructor. 36
Private field 'small' could be made final; it is only initialized in the declaration or constructor. 38
Private field 'state' could be made final; it is only initialized in the declaration or constructor. 40
Private field 'treeInSheet' could be made final; it is only initialized in the declaration or constructor. 42
Private field 'infinite' could be made final; it is only initialized in the declaration or constructor. 44

Tobago Example Demo - org/apache/myfaces/tobago/example/test/UndefinedRowCountDataModel.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 28

Tobago Example Demo - org/apache/myfaces/tobago/example/test/WaitFilter.java

Violation Line
Document empty method body 4142
Document empty method body 6263

Tobago Tool Apt - org/apache/myfaces/tobago/apt/generate/ClassInfo.java

Violation Line
Private field 'className' could be made final; it is only initialized in the declaration or constructor. 27
Private field 'packageName' could be made final; it is only initialized in the declaration or constructor. 28
Private field 'imports' could be made final; it is only initialized in the declaration or constructor. 29
Private field 'interfaces' could be made final; it is only initialized in the declaration or constructor. 31
Private field 'sourceClass' could be made final; it is only initialized in the declaration or constructor. 32
Avoid if (x != y) ..; else ..; 5156
Avoid if (x != y) ..; else ..; 7782

Tobago Tool Apt - org/apache/myfaces/tobago/apt/generate/ClassUtils.java

Violation Line
A class which only has private constructors should be final 2571

Tobago Tool Apt - org/apache/myfaces/tobago/apt/generate/ComponentInfo.java

Violation Line
Private field 'nonTransientProperties' could be made final; it is only initialized in the declaration or constructor. 30
Private field 'transientProperties' could be made final; it is only initialized in the declaration or constructor. 31
Avoid using redundant field initializer for 'index' 35
Avoid using redundant field initializer for 'nonTransientIndex' 36
Private field 'behaviors' could be made final; it is only initialized in the declaration or constructor. 37
Avoid if (x != y) ..; else ..; 5763

Tobago Tool Apt - org/apache/myfaces/tobago/apt/generate/Imports.java

Violation Line
Private field 'imports' could be made final; it is only initialized in the declaration or constructor. 28
Document empty constructor 3233
These nested if statements could be combined 4147
Avoid if (x != y) ..; else ..; 43
Deeply nested if..then statements are hard to read 4446

Tobago Tool Apt - org/apache/myfaces/tobago/apt/generate/PropertyInfo.java

Violation Line
Possible God class (WMC=54, ATFD=14, TCC=0.08478513356562137) 20262
Document empty constructor 4142
Position literals first in String comparisons 125
Consider using varargs for methods or constructors which take an array the last parameter. 135
Consider using varargs for methods or constructors which take an array the last parameter. 143

Tobago Tool Apt - org/apache/myfaces/tobago/apt/generate/RendererInfo.java

Violation Line
Consider using varargs for methods or constructors which take an array the last parameter. 29

Tobago Tool Apt - org/apache/myfaces/tobago/apt/generate/TagInfo.java

Violation Line
Private field 'properties' could be made final; it is only initialized in the declaration or constructor. 27
Consider using varargs for methods or constructors which take an array the last parameter. 34

Tobago Tool Apt - org/apache/myfaces/tobago/apt/processor/AbstractGenerator.java

Violation Line
The class 'AbstractGenerator' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 36119
The class 'AbstractGenerator' has a Modified Cyclomatic Complexity of 2 (Highest = 10). 36119
The class 'AbstractGenerator' has a Cyclomatic Complexity of 2 (Highest = 10). 36119
The method 'process' has a Standard Cyclomatic Complexity of 10. 4286
The method 'process' has a Modified Cyclomatic Complexity of 10. 4286
The method 'process' has a Cyclomatic Complexity of 10. 4286
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 51
These nested if statements could be combined 6365
These nested if statements could be combined 6870
A method/constructor shouldnt explicitly throw java.lang.Exception 91
Avoid if (x != y) ..; else ..; 108

Tobago Tool Apt - org/apache/myfaces/tobago/apt/processor/CheckstyleConfigGenerator.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20347
Possible God class (WMC=48, ATFD=54, TCC=0.009523809523809525) 20347
The class 'CheckstyleConfigGenerator' has a Cyclomatic Complexity of 3 (Highest = 10). 71347
This class has too many methods, consider refactoring it. 71347
The String literal "name" appears 5 times in this file; the first occurrence is on line 97 97
Avoid if (x != y) ..; else ..; 153160
Avoid if (x != y) ..; else ..; 155160
The method 'addAttributesForTag' has a Cyclomatic Complexity of 10. 196236
Position literals first in String comparisons 230
StringBuffer constructor is initialized with size 16, but has at least 67 characters appended. 328
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 329
Avoid appending characters as strings in StringBuffer.append. 329
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 330
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 331
Avoid appending characters as strings in StringBuffer.append. 331
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 332

Tobago Tool Apt - org/apache/myfaces/tobago/apt/processor/ClassesGenerator.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 20287
The class 'ClassesGenerator' has a Standard Cyclomatic Complexity of 4 (Highest = 13). 67287
The class 'ClassesGenerator' has a Cyclomatic Complexity of 5 (Highest = 13). 67287
The class 'ClassesGenerator' has a Modified Cyclomatic Complexity of 4 (Highest = 13). 67287
The method 'createTagOrComponent' has a Modified Cyclomatic Complexity of 13. 102165
The method createTagOrComponent() has an NPath complexity of 559 102165
The method 'createTagOrComponent' has a Standard Cyclomatic Complexity of 13. 102165
The method 'createTagOrComponent' has a Cyclomatic Complexity of 13. 102165
Avoid declaring a variable if it is unreferenced before a possible exit point. 108
Deeply nested if..then statements are hard to read 123130
Deeply nested if..then statements are hard to read 132135
Position literals first in String comparisons 144
Position literals first in String comparisons 144
The method 'addProperty' has a Modified Cyclomatic Complexity of 11. 208257
The method 'addProperty' has a Cyclomatic Complexity of 12. 208257
The method 'addProperty' has a Standard Cyclomatic Complexity of 11. 208257
The method addProperty() has an NPath complexity of 703 208257
Deeply nested if..then statements are hard to read 215217
Deeply nested if..then statements are hard to read 220223
Deeply nested if..then statements are hard to read 231233
Avoid unused private methods such as 'writeFile(ClassInfo,StringTemplate)'. 274

Tobago Tool Apt - org/apache/myfaces/tobago/apt/processor/FacesConfigGenerator.java

Violation Line
Possible God class (WMC=81, ATFD=90, TCC=0.047619047619047616) 20631
A high number of imports can indicate a high degree of coupling within an object. 20631
The class 'FacesConfigGenerator' has a Cyclomatic Complexity of 4 (Highest = 12). 76631
The class 'FacesConfigGenerator' has a Standard Cyclomatic Complexity of 4 (Highest = 12). 76631
The class 'FacesConfigGenerator' has a Modified Cyclomatic Complexity of 4 (Highest = 12). 76631
This class has too many methods, consider refactoring it. 76631
The method generate() has an NPath complexity of 720 152238
The method 'generate' has a Standard Cyclomatic Complexity of 12. 152238
The method 'generate' has a Modified Cyclomatic Complexity of 12. 152238
A method/constructor shouldnt explicitly throw java.lang.Exception 152
The method 'generate' has a Cyclomatic Complexity of 12. 152238
Avoid if (x != y) ..; else ..; 182188
Avoid if (x != y) ..; else ..; 184188
These nested if statements could be combined 332336
These nested if statements could be combined 333335
Avoid instantiating new objects inside loops 363
Position literals first in String comparisons 365
Avoid instantiating new objects inside loops 368
Avoid instantiating new objects inside loops 371
Avoid instantiating new objects inside loops 374
Avoid instantiating new objects inside loops 377
Avoid appending characters as strings in StringBuffer.append. 394
Avoid appending characters as strings in StringBuffer.append. 520
Avoid instantiating new objects inside loops 566
Avoid instantiating new objects inside loops 569
Avoid instantiating new objects inside loops 573
Avoid instantiating new objects inside loops 576
Avoid instantiating new objects inside loops 578
Avoid instantiating new objects inside loops 580
Avoid appending characters as strings in StringBuffer.append. 582
A method/constructor shouldnt explicitly throw java.lang.Exception 593
Avoid if (x != y) ..; else ..; 600617

Tobago Tool Apt - org/apache/myfaces/tobago/apt/processor/TaglibGenerator.java

Violation Line
Possible God class (WMC=81, ATFD=47, TCC=0.004329004329004329) 20545
A high number of imports can indicate a high degree of coupling within an object. 20545
The class 'TaglibGenerator' has a Cyclomatic Complexity of 4 (Highest = 17). 76545
This class has too many methods, consider refactoring it. 76545
The class 'TaglibGenerator' has a Standard Cyclomatic Complexity of 3 (Highest = 16). 76545
The class 'TaglibGenerator' has a Modified Cyclomatic Complexity of 3 (Highest = 16). 76545
Prefer StringBuffer over += for concatenating strings 155
The method 'addDescription' has a Standard Cyclomatic Complexity of 16. 239307
The method 'addDescription' has a Modified Cyclomatic Complexity of 16. 239307
The method 'addDescription' has a Cyclomatic Complexity of 17. 239307
The method addDescription() has an NPath complexity of 18000 239307
StringBuffer constructor is initialized with size 16, but has at least 106 characters appended. 242
String.indexOf(char) is faster than String.indexOf(String). 318
Avoid unused private methods such as 'getInterfaceDeclaration(String)'. 328
StringBuffer constructor is initialized with size 16, but has at least 98 characters appended. 338
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 339
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 340
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 341
StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. 341
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 342
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 354
StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 354
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 358
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 363
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 372
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 377
Avoid if (x != y) ..; else ..; 516542

Tobago Tool Apt - org/apache/myfaces/tobago/apt/processor/TobagoGeneratorException.java

Violation Line
Parameter 'message' is not assigned and could be declared final 27
Parameter 'message' is not assigned and could be declared final 31
Parameter 'cause' is not assigned and could be declared final 31