Apache MyFaces
UI-Component Sets
Foundation

FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.3.9

Threshold is low

Effort is min

Summary

ClassesBugsErrorsMissing Classes
1176300

Files

ClassBugs
org.apache.myfaces.test.base.AbstractJsfTestCase1
org.apache.myfaces.test.base.junit4.AbstractJsfConfigurableMockTestCase1
org.apache.myfaces.test.base.junit4.AbstractJsfTestCase1
org.apache.myfaces.test.cargo.CargoTestSetup1
org.apache.myfaces.test.config.ConfigParser1
org.apache.myfaces.test.config.ConfigParser$ComponentBean1
org.apache.myfaces.test.config.ConfigParser$ConverterBean1
org.apache.myfaces.test.config.ConfigParser$RenderKitIdRule1
org.apache.myfaces.test.config.ConfigParser$RenderKitRule1
org.apache.myfaces.test.config.ConfigParser$RendererBean1
org.apache.myfaces.test.config.ConfigParser$ValidatorBean1
org.apache.myfaces.test.el.ExpressionTokenizer1
org.apache.myfaces.test.el.FacesImplicitObjectELResolver1
org.apache.myfaces.test.el.FacesPropertyResolverChainWrapper4
org.apache.myfaces.test.el.FacesResourceBundleELResolver1
org.apache.myfaces.test.el.FacesVariableResolverChainWrapper2
org.apache.myfaces.test.el.MockCompositeValueExpression1
org.apache.myfaces.test.el.MockExpressionFactory8
org.apache.myfaces.test.el.MockMethodExpression2
org.apache.myfaces.test.el.MockValueExpression1
org.apache.myfaces.test.el.MockVariableValueExpression1
org.apache.myfaces.test.jmock.AbstractJmockJsfTestCase1
org.apache.myfaces.test.mock.MockApplication121
org.apache.myfaces.test.mock.MockExternalContext$11
org.apache.myfaces.test.mock.MockExternalContext$LocalesIterator1
org.apache.myfaces.test.mock.MockFacesContext1
org.apache.myfaces.test.mock.MockHttpServletResponse2
org.apache.myfaces.test.mock.MockMethodBinding3
org.apache.myfaces.test.mock.MockPortletContext2
org.apache.myfaces.test.mock.MockPortletRequest1
org.apache.myfaces.test.mock.MockPropertyResolver3
org.apache.myfaces.test.mock.MockRenderKit$11
org.apache.myfaces.test.mock.MockResponseStateManager1
org.apache.myfaces.test.mock.MockServlet1
org.apache.myfaces.test.mock.MockServletContext2
org.apache.myfaces.test.mock._Hex1
org.apache.myfaces.test.mock.lifecycle.RestoreViewExecutor1
org.apache.myfaces.test.runners.TestClassLoader7

org.apache.myfaces.test.base.AbstractJsfTestCase

BugCategoryDetailsLinePriority

org.apache.myfaces.test.base.junit4.AbstractJsfConfigurableMockTestCase

BugCategoryDetailsLinePriority

org.apache.myfaces.test.base.junit4.AbstractJsfTestCase

BugCategoryDetailsLinePriority

org.apache.myfaces.test.cargo.CargoTestSetup

BugCategoryDetailsLinePriority
CargoTestSetup.container not initialized in constructorSTYLEUWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTORLow

org.apache.myfaces.test.config.ConfigParser

BugCategoryDetailsLinePriority
Usage of GetResource in org.apache.myfaces.test.config.ConfigParser.translate(String[]) may be unsafe if class is extendedBAD_PRACTICEUI_INHERITANCE_UNSAFE_GETRESOURCE236Low

org.apache.myfaces.test.config.ConfigParser$ComponentBean

BugCategoryDetailsLinePriority
Should org.apache.myfaces.test.config.ConfigParser$ComponentBean be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC247Medium

org.apache.myfaces.test.config.ConfigParser$ConverterBean

BugCategoryDetailsLinePriority
Should org.apache.myfaces.test.config.ConfigParser$ConverterBean be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC300Medium

org.apache.myfaces.test.config.ConfigParser$RenderKitIdRule

BugCategoryDetailsLinePriority
Should org.apache.myfaces.test.config.ConfigParser$RenderKitIdRule be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC421Medium

org.apache.myfaces.test.config.ConfigParser$RenderKitRule

BugCategoryDetailsLinePriority
Should org.apache.myfaces.test.config.ConfigParser$RenderKitRule be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC399Medium

org.apache.myfaces.test.config.ConfigParser$RendererBean

BugCategoryDetailsLinePriority
Should org.apache.myfaces.test.config.ConfigParser$RendererBean be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC444Medium

org.apache.myfaces.test.config.ConfigParser$ValidatorBean

BugCategoryDetailsLinePriority
Should org.apache.myfaces.test.config.ConfigParser$ValidatorBean be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC523Medium

org.apache.myfaces.test.el.ExpressionTokenizer

BugCategoryDetailsLinePriority
Switch statement found in org.apache.myfaces.test.el.ExpressionTokenizer.tokenize(CharSequence) where default case is missingSTYLESF_SWITCH_NO_DEFAULT60Low

org.apache.myfaces.test.el.FacesImplicitObjectELResolver

BugCategoryDetailsLinePriority
Dead store to fcontext in org.apache.myfaces.test.el.FacesImplicitObjectELResolver.getFeatureDescriptors(ELContext, Object)STYLEDLS_DEAD_LOCAL_STORE100Medium

org.apache.myfaces.test.el.FacesPropertyResolverChainWrapper

BugCategoryDetailsLinePriority
Dead store to elContext in org.apache.myfaces.test.el.FacesPropertyResolverChainWrapper.getType(ELContext, Object, Object)STYLEDLS_DEAD_LOCAL_STORE91Medium
Dead store to elContext in org.apache.myfaces.test.el.FacesPropertyResolverChainWrapper.getValue(ELContext, Object, Object)STYLEDLS_DEAD_LOCAL_STORE144Medium
Dead store to elContext in org.apache.myfaces.test.el.FacesPropertyResolverChainWrapper.isReadOnly(ELContext, Object, Object)STYLEDLS_DEAD_LOCAL_STORE196Medium
Dead store to elContext in org.apache.myfaces.test.el.FacesPropertyResolverChainWrapper.setValue(ELContext, Object, Object, Object)STYLEDLS_DEAD_LOCAL_STORE250Medium

org.apache.myfaces.test.el.FacesResourceBundleELResolver

BugCategoryDetailsLinePriority
Dead store to value in org.apache.myfaces.test.el.FacesResourceBundleELResolver.getFeatureDescriptors(ELContext, Object)STYLEDLS_DEAD_LOCAL_STORE92Low

org.apache.myfaces.test.el.FacesVariableResolverChainWrapper

BugCategoryDetailsLinePriority
Dead store to econtext in org.apache.myfaces.test.el.FacesVariableResolverChainWrapper.getValue(ELContext, Object, Object)STYLEDLS_DEAD_LOCAL_STORE113Medium
Dead store to elContext in org.apache.myfaces.test.el.FacesVariableResolverChainWrapper.getValue(ELContext, Object, Object)STYLEDLS_DEAD_LOCAL_STORE116Medium

org.apache.myfaces.test.el.MockCompositeValueExpression

BugCategoryDetailsLinePriority
org.apache.myfaces.test.el.MockCompositeValueExpression doesn't override MockValueExpression.equals(Object)STYLEEQ_DOESNT_OVERRIDE_EQUALS43Medium

org.apache.myfaces.test.el.MockExpressionFactory

BugCategoryDetailsLinePriority
Method org.apache.myfaces.test.el.MockExpressionFactory.coerce(Number, Class) invokes inefficient Double.valueOf(double) constructor; use MockExpressionFactory.java:[line 237] insteadPERFORMANCEDM_FP_NUMBER_CTOR237Low
Method org.apache.myfaces.test.el.MockExpressionFactory.coerce(Number, Class) invokes inefficient Float.valueOf(float) constructor; use MockExpressionFactory.java:[line 241] insteadPERFORMANCEDM_FP_NUMBER_CTOR241Low
Method org.apache.myfaces.test.el.MockExpressionFactory.<static initializer>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR47Medium
Method org.apache.myfaces.test.el.MockExpressionFactory.coerce(Number, Class) invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) insteadPERFORMANCEDM_NUMBER_CTOR233Medium
Method org.apache.myfaces.test.el.MockExpressionFactory.coerce(Number, Class) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR245Medium
Method org.apache.myfaces.test.el.MockExpressionFactory.coerce(Number, Class) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR249Medium
Method org.apache.myfaces.test.el.MockExpressionFactory.coerce(Number, Class) invokes inefficient new Short(short) constructor; use Short.valueOf(short) insteadPERFORMANCEDM_NUMBER_CTOR253Medium
Method org.apache.myfaces.test.el.MockExpressionFactory.coerceToType(Object, Class) invokes inefficient new Character(char) constructor; use Character.valueOf(char) insteadPERFORMANCEDM_NUMBER_CTOR133Medium

org.apache.myfaces.test.el.MockMethodExpression

BugCategoryDetailsLinePriority
new org.apache.myfaces.test.el.MockMethodExpression(String, Class[], Class) may expose internal representation by storing an externally mutable object into MockMethodExpression.signatureMALICIOUS_CODEEI_EXPOSE_REP261Medium
Questionable use of non-short-circuit logic in org.apache.myfaces.test.el.MockMethodExpression.equals(Object)STYLENS_NON_SHORT_CIRCUIT100Low

org.apache.myfaces.test.el.MockValueExpression

BugCategoryDetailsLinePriority
Questionable use of non-short-circuit logic in org.apache.myfaces.test.el.MockValueExpression.equals(Object)STYLENS_NON_SHORT_CIRCUIT93Low

org.apache.myfaces.test.el.MockVariableValueExpression

BugCategoryDetailsLinePriority
Questionable use of non-short-circuit logic in org.apache.myfaces.test.el.MockVariableValueExpression.equals(Object)STYLENS_NON_SHORT_CIRCUIT81Low

org.apache.myfaces.test.jmock.AbstractJmockJsfTestCase

BugCategoryDetailsLinePriority

org.apache.myfaces.test.mock.MockApplication12

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.apache.myfaces.test.mock.MockApplication12.createComponent(ValueExpression, FacesContext, String)STYLEREC_CATCH_EXCEPTION182Low

org.apache.myfaces.test.mock.MockExternalContext$1

BugCategoryDetailsLinePriority
The class org.apache.myfaces.test.mock.MockExternalContext$1 could be refactored into a named _static_ inner classPERFORMANCESIC_INNER_SHOULD_BE_STATIC_ANON353Low

org.apache.myfaces.test.mock.MockExternalContext$LocalesIterator

BugCategoryDetailsLinePriority
Should org.apache.myfaces.test.mock.MockExternalContext$LocalesIterator be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATIC481Medium

org.apache.myfaces.test.mock.MockFacesContext

BugCategoryDetailsLinePriority
Unread field: org.apache.myfaces.test.mock.MockFacesContext.lifecyclePERFORMANCEURF_UNREAD_FIELD110Medium

org.apache.myfaces.test.mock.MockHttpServletResponse

BugCategoryDetailsLinePriority
Unread field: org.apache.myfaces.test.mock.MockHttpServletResponse.contentLengthPERFORMANCEURF_UNREAD_FIELD139Medium

org.apache.myfaces.test.mock.MockMethodBinding

BugCategoryDetailsLinePriority
new org.apache.myfaces.test.mock.MockMethodBinding(Application, String, Class[]) may expose internal representation by storing an externally mutable object into MockMethodBinding.argsMALICIOUS_CODEEI_EXPOSE_REP269Medium
Comparison of String objects using == or != in org.apache.myfaces.test.mock.MockMethodBinding.equals(Object) BAD_PRACTICEES_COMPARING_STRINGS_WITH_EQ220Low
Unread field: org.apache.myfaces.test.mock.MockMethodBinding.applicationPERFORMANCEURF_UNREAD_FIELD68Medium

org.apache.myfaces.test.mock.MockPortletContext

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.apache.myfaces.test.mock.MockPortletContext.getResourceAsStream(String)STYLEREC_CATCH_EXCEPTION246Low
Method org.apache.myfaces.test.mock.MockPortletContext.getResourcePaths(String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION295Medium

org.apache.myfaces.test.mock.MockPortletRequest

BugCategoryDetailsLinePriority
Field only ever set to null: org.apache.myfaces.test.mock.MockPortletRequest.contextPathCORRECTNESSUWF_NULL_FIELDMedium

org.apache.myfaces.test.mock.MockPropertyResolver

BugCategoryDetailsLinePriority
Method call in org.apache.myfaces.test.mock.MockPropertyResolver.getType(Object, int) passes null for nonnull parameter of getType(Object, Object)CORRECTNESSNP_NULL_PARAM_DEREF237Medium
Method call in org.apache.myfaces.test.mock.MockPropertyResolver.getValue(Object, int) passes null for nonnull parameter of getValue(Object, Object)CORRECTNESSNP_NULL_PARAM_DEREF99Medium
Method call in org.apache.myfaces.test.mock.MockPropertyResolver.setValue(Object, int, Object) passes null for nonnull parameter of setValue(Object, Object, Object)CORRECTNESSNP_NULL_PARAM_DEREF154Medium

org.apache.myfaces.test.mock.MockRenderKit$1

BugCategoryDetailsLinePriority
The class org.apache.myfaces.test.mock.MockRenderKit$1 could be refactored into a named _static_ inner classPERFORMANCESIC_INNER_SHOULD_BE_STATIC_ANON109Low

org.apache.myfaces.test.mock.MockResponseStateManager

BugCategoryDetailsLinePriority
Should org.apache.myfaces.test.mock.MockResponseStateManager.getSavedState(FacesContext) return a zero length array rather than null?STYLEPZLA_PREFER_ZERO_LENGTH_ARRAYS272Low

org.apache.myfaces.test.mock.MockServlet

BugCategoryDetailsLinePriority
org.apache.myfaces.test.mock.MockServlet.config is a mutable servlet fieldMT_CORRECTNESSMSF_MUTABLE_SERVLET_FIELD89Low

org.apache.myfaces.test.mock.MockServletContext

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.apache.myfaces.test.mock.MockServletContext.getResourceAsStream(String)STYLEREC_CATCH_EXCEPTION257Low
Method org.apache.myfaces.test.mock.MockServletContext.getResourcePaths(String) concatenates strings using + in a loopPERFORMANCESBSC_USE_STRINGBUFFER_CONCATENATION304Medium

org.apache.myfaces.test.mock._Hex

BugCategoryDetailsLinePriority
Should org.apache.myfaces.test.mock._Hex.getBytesUnchecked(String, String) return a zero length array rather than null?STYLEPZLA_PREFER_ZERO_LENGTH_ARRAYS274Low

org.apache.myfaces.test.mock.lifecycle.RestoreViewExecutor

BugCategoryDetailsLinePriority
Private method org.apache.myfaces.test.mock.lifecycle.RestoreViewExecutor.deriveViewId(FacesContext) is never calledPERFORMANCEUPM_UNCALLED_PRIVATE_METHOD141Low

org.apache.myfaces.test.runners.TestClassLoader

BugCategoryDetailsLinePriority
org.apache.myfaces.test.runners.TestClassLoader.getClassData(File) may fail to close stream on exceptionBAD_PRACTICEOS_OPEN_STREAM_EXCEPTION_PATH214Low
Should org.apache.myfaces.test.runners.TestClassLoader.getClassData(File) return a zero length array rather than null?STYLEPZLA_PREFER_ZERO_LENGTH_ARRAYS228Low
Should org.apache.myfaces.test.runners.TestClassLoader.loadFileData(String, String) return a zero length array rather than null?STYLEPZLA_PREFER_ZERO_LENGTH_ARRAYS207Low
Should org.apache.myfaces.test.runners.TestClassLoader.loadJarData(String, String) return a zero length array rather than null?STYLEPZLA_PREFER_ZERO_LENGTH_ARRAYS245Low
Redundant nullcheck of c which is known to be null in org.apache.myfaces.test.runners.TestClassLoader.loadClass(String, boolean)STYLERCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE137Low
Usage of GetResource in org.apache.myfaces.test.runners.TestClassLoader.readExcludedPackages() may be unsafe if class is extendedBAD_PRACTICEUI_INHERITANCE_UNSAFE_GETRESOURCE297Low