FindBugs Bug Detector Report
The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is low
Effort is min
Summary
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 7 | 20 | 0 | 0 |
Files
guessNumber.MessageFactory
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in guessNumber.MessageFactory.getMessage(Locale, String, Object[]) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 143 | Medium |
| Load of known null value in guessNumber.MessageFactory.getMessage(FacesContext, String, Object[]) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 178 | Medium |
| Redundant comparison of non-null value to null in guessNumber.MessageFactory.getMessage(Locale, String, Object[]) | STYLE | RCN_REDUNDANT_COMPARISON_OF_NULL_AND_NONNULL_VALUE | 142 | Low |
| Redundant nullcheck of context, which is known to be non-null in guessNumber.MessageFactory.getMessage(FacesContext, String, Object[]) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 172 | Low |
guessNumber.MessageFactory$BindingFacesMessage
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| guessNumber.MessageFactory$BindingFacesMessage is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 270 | Low |
guessNumber.UserNumberBean
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method guessNumber.UserNumberBean.validate(FacesContext, UIComponent, Object) invokes inefficient Double.valueOf(double) constructor; use UserNumberBean.java:[line 161] instead | PERFORMANCE | DM_FP_NUMBER_CTOR | 161 | Low |
| Method new guessNumber.UserNumberBean() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 41 | Medium |
| Method guessNumber.UserNumberBean.validate(FacesContext, UIComponent, Object) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 135 | Medium |
| guessNumber.UserNumberBean.getStatus() may expose internal representation by returning UserNumberBean.status | MALICIOUS_CODE | EI_EXPOSE_REP | 83 | Medium |
| guessNumber.UserNumberBean.setStatus(String[]) may expose internal representation by storing an externally mutable object into UserNumberBean.status | MALICIOUS_CODE | EI_EXPOSE_REP2 | 88 | Medium |
| Unread field: guessNumber.UserNumberBean.response | PERFORMANCE | URF_UNREAD_FIELD | 35 | Medium |
org.apache.myfaces.portlet.faces.application.BridgeMyFacesRenderFilter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.servlet.ServletResponse to javax.servlet.http.HttpServletResponse in org.apache.myfaces.portlet.faces.application.BridgeMyFacesRenderFilter.doFilter(ServletRequest, ServletResponse, FilterChain) | STYLE | BC_UNCONFIRMED_CAST | 74 | Low |
| Suspicious comparison of Boolean references in org.apache.myfaces.portlet.faces.application.BridgeMyFacesRenderFilter.doFilter(ServletRequest, ServletResponse, FilterChain) | BAD_PRACTICE | RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN | 66 | Medium |
org.apache.myfaces.portlet.faces.application.BridgeMyFacesRenderFilter$BridgeRenderFilterResponseWrapper
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.portlet.faces.application.BridgeMyFacesRenderFilter$BridgeRenderFilterResponseWrapper.getBytes() return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 286 | Low |
| Should org.apache.myfaces.portlet.faces.application.BridgeMyFacesRenderFilter$BridgeRenderFilterResponseWrapper.getChars() return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 299 | Low |
| BridgeMyFacesRenderFilter$BridgeRenderFilterResponseWrapper.mByteStream not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Low | |
| BridgeMyFacesRenderFilter$BridgeRenderFilterResponseWrapper.mCharWriter not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Low | |
| BridgeMyFacesRenderFilter$BridgeRenderFilterResponseWrapper.mPrintWriter not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Low |
org.apache.myfaces.portlet.faces.application.BridgeMyFacesRenderFilter$DirectByteArrayOutputStream
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.portlet.faces.application.BridgeMyFacesRenderFilter$DirectByteArrayOutputStream be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 439 | Medium |
org.apache.myfaces.portlet.faces.application.BridgeMyFacesRenderFilter$DirectByteArrayServletOutputStream
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.portlet.faces.application.BridgeMyFacesRenderFilter$DirectByteArrayServletOutputStream could be refactored into a _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_NEEDS_THIS | 403 | Low |