Tag List Report
The following document contains the listing of user tags found in the code. Below is the summary of the occurrences per tag.
| Tag Class | Total number of occurrences | Tag strings used by tag class |
|---|---|---|
| @todo | 0 | @todo |
| TODO | 7 | TODO |
Each tag is detailed below:
TODO
Number of occurrences found in the code: 7
| org.apache.myfaces.orchestra.flow.FlowHandler | Line |
|---|---|
| some modal dialog libraries (eg myfaces sandbox s:modalDialog) provide a "cancel button" that closes the modal dialog. If this is done then the webapp will work but the child context will not get deleted. Eventually the conversationContext-timeout will remove it but that could be 30 minutes or more. One option could be to always delete all child contexts whenever a request for a context is received. That doesn't work when multiple windows have the same conversationContext id, but that is broken for other reasons anyway (eg access-scope). | 174 |
| discard all flow stacks here for safety? | 599 |
| possibly check that viewToRestore.viewId == newViewId. This should always be true, as we only set that attribute immediately before sending a redirect to the matching id. | 764 |
| org.apache.myfaces.orchestra.flow.FlowInfo | Line |
| save the serialized view tree, not just a ref to the viewroot | 105 |
| determine whether to save the view tree or not (see comments on callerViewRoot property) | 106 |
| org.apache.myfaces.orchestra.flow.FlowNavigationHandler | Line |
| what about restoring state that is not in the view tree, eg FacesMessage objects (which are attached to a FacesContext)? I guess if this is important then it can also be attached to the FlowInfo object... | 49 |
| org.apache.myfaces.orchestra.flow.components.ModalFlow | Line |
| maybe here we should use StringSubstitutor to insert variables like ${viewURL} into the provided script? | 222 |