Apache MyFaces
MyFaces Orchestra
MyFaces Orchestra - Modules
Foundation

FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.2.0

Threshold is Low

Effort is Default

Summary

Classes Bugs Errors Missing Classes
221 56 0 0

Files

Class Bugs
org.apache.myfaces.examples.ballot.backings.BallotTopic 3
org.apache.myfaces.examples.ballot.backings.BallotTopicVotes 4
org.apache.myfaces.examples.ballot.backings.BallotVoteTopic 5
org.apache.myfaces.examples.ballot.backings.BallotVoter 1
org.apache.myfaces.examples.ballot.dto.AddressDto 1
org.apache.myfaces.examples.ballot.dto.CompanyDto 1
org.apache.myfaces.examples.ballot.dto.PersonDto 1
org.apache.myfaces.examples.ballot.model.Vote 4
org.apache.myfaces.examples.configurator.backings.ConfiguratorData 3
org.apache.myfaces.examples.dynaForm.model.SimpleEntity 6
org.apache.myfaces.examples.mops.backings.CustomerLogin 3
org.apache.myfaces.examples.mops.backings.EditCustomerGroup 1
org.apache.myfaces.examples.mops.backings.EditProduct 1
org.apache.myfaces.examples.mops.backings.PetstoreData 2
org.apache.myfaces.examples.mops.backings.ProductDetail 3
org.apache.myfaces.examples.mops.backings.SearchProduct 3
org.apache.myfaces.examples.mops.dao.CustomerGroupDao 1
org.apache.myfaces.examples.mops.dao.CustomerGroupSuggest 1
org.apache.myfaces.examples.mops.dao.ProductDao$1 2
org.apache.myfaces.examples.mops.lib.CustomerGroupPkConverter 1
org.apache.myfaces.examples.mops.model.ProductPrice 4
org.apache.myfaces.examples.simple.backings.CompanyView 1
org.apache.myfaces.examples.simple.backings.ReservationBookView 1
org.apache.myfaces.examples.simple.backings.ReservationView 1
org.apache.myfaces.examples.simple.model.Reservation 2

org.apache.myfaces.examples.ballot.backings.BallotTopic

Bug Category Details Line
BallotTopic.itemDao not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available
BallotTopic.topic not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available
BallotTopic.topicDao not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

org.apache.myfaces.examples.ballot.backings.BallotTopicVotes

Bug Category Details Line
BallotTopicVotes.itemDao not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available
BallotTopicVotes.topicDao not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available
BallotTopicVotes.voteDao not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available
BallotTopicVotes.voterDao not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

org.apache.myfaces.examples.ballot.backings.BallotVoteTopic

Bug Category Details Line
BallotVoteTopic.itemDao not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available
BallotVoteTopic.itemInfos not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available
BallotVoteTopic.topicDao not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available
BallotVoteTopic.voteDao not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available
BallotVoteTopic.voterDao not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

org.apache.myfaces.examples.ballot.backings.BallotVoter

Bug Category Details Line
BallotVoter.voterDao not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

org.apache.myfaces.examples.ballot.dto.AddressDto

Bug Category Details Line
org.apache.myfaces.examples.ballot.dto.AddressDto is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID Not available

org.apache.myfaces.examples.ballot.dto.CompanyDto

Bug Category Details Line
org.apache.myfaces.examples.ballot.dto.CompanyDto is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID Not available

org.apache.myfaces.examples.ballot.dto.PersonDto

Bug Category Details Line
org.apache.myfaces.examples.ballot.dto.PersonDto is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID Not available

org.apache.myfaces.examples.ballot.model.Vote

Bug Category Details Line
org.apache.myfaces.examples.ballot.model.Vote.getChanged() may expose internal representation by returning Vote.changed MALICIOUS_CODE EI_EXPOSE_REP 121
org.apache.myfaces.examples.ballot.model.Vote.getCreated() may expose internal representation by returning Vote.created MALICIOUS_CODE EI_EXPOSE_REP 111
org.apache.myfaces.examples.ballot.model.Vote.setChanged(Date) may expose internal representation by storing an externally mutable object into Vote.changed MALICIOUS_CODE EI_EXPOSE_REP2 126
org.apache.myfaces.examples.ballot.model.Vote.setCreated(Date) may expose internal representation by storing an externally mutable object into Vote.created MALICIOUS_CODE EI_EXPOSE_REP2 116

org.apache.myfaces.examples.configurator.backings.ConfiguratorData

Bug Category Details Line
ConfiguratorData.componentDao not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available
ConfiguratorData.orderHeadDao not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available
ConfiguratorData.pieceDao not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

org.apache.myfaces.examples.dynaForm.model.SimpleEntity

Bug Category Details Line
org.apache.myfaces.examples.dynaForm.model.SimpleEntity.getLastChanged() may expose internal representation by returning SimpleEntity.lastChanged MALICIOUS_CODE EI_EXPOSE_REP 116
org.apache.myfaces.examples.dynaForm.model.SimpleEntity.getStartDate() may expose internal representation by returning SimpleEntity.startDate MALICIOUS_CODE EI_EXPOSE_REP 96
org.apache.myfaces.examples.dynaForm.model.SimpleEntity.getStartTime() may expose internal representation by returning SimpleEntity.startTime MALICIOUS_CODE EI_EXPOSE_REP 106
org.apache.myfaces.examples.dynaForm.model.SimpleEntity.setLastChanged(Date) may expose internal representation by storing an externally mutable object into SimpleEntity.lastChanged MALICIOUS_CODE EI_EXPOSE_REP2 121
org.apache.myfaces.examples.dynaForm.model.SimpleEntity.setStartDate(Date) may expose internal representation by storing an externally mutable object into SimpleEntity.startDate MALICIOUS_CODE EI_EXPOSE_REP2 101
org.apache.myfaces.examples.dynaForm.model.SimpleEntity.setStartTime(Date) may expose internal representation by storing an externally mutable object into SimpleEntity.startTime MALICIOUS_CODE EI_EXPOSE_REP2 111

org.apache.myfaces.examples.mops.backings.CustomerLogin

Bug Category Details Line
CustomerLogin.petstoreData not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available
CustomerLogin.shopCustomer not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available
CustomerLogin.shopCustomerDao not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

org.apache.myfaces.examples.mops.backings.EditCustomerGroup

Bug Category Details Line
EditCustomerGroup.customerGroupDao not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

org.apache.myfaces.examples.mops.backings.EditProduct

Bug Category Details Line
EditProduct.productDao not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

org.apache.myfaces.examples.mops.backings.PetstoreData

Bug Category Details Line
PetstoreData.productDao not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available
PetstoreData.shopCustomerDao not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

org.apache.myfaces.examples.mops.backings.ProductDetail

Bug Category Details Line
ProductDetail.petstoreData not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available
ProductDetail.productDao not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available
ProductDetail.productPriceDao not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

org.apache.myfaces.examples.mops.backings.SearchProduct

Bug Category Details Line
SearchProduct.petstoreData not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available
SearchProduct.productDao not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available
SearchProduct.productPriceDao not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

org.apache.myfaces.examples.mops.dao.CustomerGroupDao

Bug Category Details Line
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 46

org.apache.myfaces.examples.mops.dao.CustomerGroupSuggest

Bug Category Details Line
CustomerGroupSuggest.customerGroupDao not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

org.apache.myfaces.examples.mops.dao.ProductDao$1

Bug Category Details Line
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 57
The class org.apache.myfaces.examples.mops.dao.ProductDao$1 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON Not available

org.apache.myfaces.examples.mops.lib.CustomerGroupPkConverter

Bug Category Details Line
CustomerGroupPkConverter.customerGroupDao not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

org.apache.myfaces.examples.mops.model.ProductPrice

Bug Category Details Line
org.apache.myfaces.examples.mops.model.ProductPrice.getValidFrom() may expose internal representation by returning ProductPrice.validFrom MALICIOUS_CODE EI_EXPOSE_REP 94
org.apache.myfaces.examples.mops.model.ProductPrice.getValidTo() may expose internal representation by returning ProductPrice.validTo MALICIOUS_CODE EI_EXPOSE_REP 105
org.apache.myfaces.examples.mops.model.ProductPrice.setValidFrom(Date) may expose internal representation by storing an externally mutable object into ProductPrice.validFrom MALICIOUS_CODE EI_EXPOSE_REP2 99
org.apache.myfaces.examples.mops.model.ProductPrice.setValidTo(Date) may expose internal representation by storing an externally mutable object into ProductPrice.validTo MALICIOUS_CODE EI_EXPOSE_REP2 110

org.apache.myfaces.examples.simple.backings.CompanyView

Bug Category Details Line
Class org.apache.myfaces.examples.simple.backings.CompanyView defines non-transient non-serializable instance field log BAD_PRACTICE SE_BAD_FIELD Not available

org.apache.myfaces.examples.simple.backings.ReservationBookView

Bug Category Details Line
Unread field: org.apache.myfaces.examples.simple.backings.ReservationBookView.log PERFORMANCE URF_UNREAD_FIELD 30

org.apache.myfaces.examples.simple.backings.ReservationView

Bug Category Details Line
Unread field: org.apache.myfaces.examples.simple.backings.ReservationView.log PERFORMANCE URF_UNREAD_FIELD 34

org.apache.myfaces.examples.simple.model.Reservation

Bug Category Details Line
org.apache.myfaces.examples.simple.model.Reservation.getStart() may expose internal representation by returning Reservation.start MALICIOUS_CODE EI_EXPOSE_REP 39
org.apache.myfaces.examples.simple.model.Reservation.setStart(Date) may expose internal representation by storing an externally mutable object into Reservation.start MALICIOUS_CODE EI_EXPOSE_REP2 43