UI-Component Sets

PMD Results

The following document contains the results of PMD 4.2.5.

Files

org/apache/myfaces/application/ApplicationImpl.java

ViolationLine
Avoid unused private fields such as 'PROJECT_STAGE_PARAM_NAME'.149
Avoid empty catch blocks804 - 807
Avoid empty catch blocks808 - 817
These nested if statements could be combined1799 - 1802
These nested if statements could be combined2196 - 2199
These nested if statements could be combined2345 - 2348
These nested if statements could be combined2575 - 2578

org/apache/myfaces/application/NavigationHandlerImpl.java

ViolationLine
These nested if statements could be combined184 - 190
Avoid empty catch blocks464 - 470
These nested if statements could be combined648 - 668
These nested if statements could be combined677 - 686
Avoid unused method parameters such as 'facesContext'.770 - 826
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.849

org/apache/myfaces/application/ResourceHandlerImpl.java

ViolationLine
Avoid empty catch blocks530 - 533

org/apache/myfaces/application/ViewHandlerImpl.java

ViolationLine
Avoid empty if statements416 - 418

org/apache/myfaces/application/jsp/JspStateManagerImpl.java

ViolationLine
These nested if statements could be combined848 - 855
Avoid empty while statements1128 - 1130

org/apache/myfaces/application/jsp/JspViewHandlerImpl.java

ViolationLine
Avoid unused method parameters such as 'renderKit'.480 - 486
Avoid unused method parameters such as 'externalContext'.480 - 486

org/apache/myfaces/application/viewstate/RandomKeyFactory.java

ViolationLine
Avoid empty catch blocks101 - 105

org/apache/myfaces/application/viewstate/SecureRandomKeyFactory.java

ViolationLine
Avoid empty catch blocks123 - 127

org/apache/myfaces/application/viewstate/SerializedViewCollection.java

ViolationLine
These nested if statements could be combined76 - 91
Avoid empty while statements96 - 98
Avoid empty while statements121 - 123

org/apache/myfaces/application/viewstate/ServerSideStateCacheImpl.java

ViolationLine
These nested if statements could be combined288 - 294
These nested if statements could be combined321 - 330

org/apache/myfaces/application/viewstate/SessionIdGenerator.java

ViolationLine
These nested if statements could be combined277 - 281

org/apache/myfaces/component/visit/PartialVisitContext.java

ViolationLine
Avoid empty if statements310 - 312

org/apache/myfaces/config/ConfigFilesXmlValidationUtils.java

ViolationLine
These nested if statements could be combined167 - 171
Avoid empty catch blocks278 - 281
Avoid empty catch blocks287 - 290
Avoid empty catch blocks301 - 303
Avoid empty catch blocks452 - 455
Avoid empty catch blocks460 - 463
Avoid empty catch blocks474 - 476

org/apache/myfaces/config/DefaultFacesConfigurationMerger.java

ViolationLine
These nested if statements could be combined124 - 129
These nested if statements could be combined186 - 192
These nested if statements could be combined355 - 359

org/apache/myfaces/config/FacesConfigurator.java

ViolationLine
Avoid empty catch blocks286 - 289

org/apache/myfaces/config/annotation/AnnotationConfigurator.java

ViolationLine
These nested if statements could be combined417 - 421
These nested if statements could be combined449 - 454

org/apache/myfaces/config/annotation/DefaultAnnotationProvider.java

ViolationLine
Avoid unused private fields such as 'STANDARD_FACES_CONFIG_RESOURCE'.95
Avoid unused method parameters such as 'context'.440 - 528
Avoid empty catch blocks497 - 500
Avoid empty catch blocks512 - 515
Avoid empty catch blocks516 - 519
Avoid empty catch blocks635 - 638
Avoid empty catch blocks654 - 657
Avoid empty catch blocks658 - 661

org/apache/myfaces/config/annotation/DefaultLifecycleProviderFactory.java

ViolationLine
Avoid empty catch blocks218 - 221
Avoid empty catch blocks222 - 225

org/apache/myfaces/config/annotation/Tomcat7AnnotationLifecycleProvider.java

ViolationLine
Avoid unused constructor parameters such as 'externalContext'.46 - 49
Avoid empty catch blocks111 - 114

org/apache/myfaces/config/annotation/TomcatAnnotationLifecycleProvider.java

ViolationLine
Avoid empty catch blocks79 - 82

org/apache/myfaces/config/annotation/_ClassByteCodeAnnotationFilter.java

ViolationLine
Avoid unused local variables such as 'minorVersion'.102

org/apache/myfaces/config/util/Vertex.java

ViolationLine
Avoid unused private fields such as 'm_seen'.41

org/apache/myfaces/context/FacesContextFactoryImpl.java

ViolationLine
These nested if statements could be combined89 - 93

org/apache/myfaces/context/PartialResponseWriterImpl.java

ViolationLine
Avoid unused local variables such as 'elem'.194
Overriding method merely calls super351 - 354

org/apache/myfaces/el/unified/resolver/CompositeComponentELResolver.java

ViolationLine
These nested if statements could be combined105 - 115
These nested if statements could be combined120 - 124

org/apache/myfaces/el/unified/resolver/ManagedBeanResolver.java

ViolationLine
These nested if statements could be combined192 - 195
These nested if statements could be combined212 - 215

org/apache/myfaces/lifecycle/DefaultRestoreViewSupport.java

ViolationLine
Avoid empty catch blocks567 - 570

org/apache/myfaces/logging/MyfacesLogger.java

ViolationLine
Avoid empty catch blocks1812 - 1815

org/apache/myfaces/renderkit/ErrorPageWriter.java

ViolationLine
Avoid empty catch blocks289 - 292
These nested if statements could be combined831 - 838
Avoid empty catch blocks1005 - 1008
These nested if statements could be combined1198 - 1207
Avoid empty catch blocks1332 - 1335
Avoid empty catch blocks1352 - 1355

org/apache/myfaces/renderkit/RenderKitFactoryImpl.java

ViolationLine
These nested if statements could be combined67 - 70

org/apache/myfaces/renderkit/html/HtmlAjaxBehaviorRenderer.java

ViolationLine
Avoid unused method parameters such as 'facesContext'.297 - 323

org/apache/myfaces/renderkit/html/HtmlCompositeFacetRenderer.java

ViolationLine
Avoid unused private fields such as 'log'.39

org/apache/myfaces/renderkit/html/HtmlRenderKitImpl.java

ViolationLine
Avoid unused private methods such as 'checkNull(Object,String)'.359

org/apache/myfaces/renderkit/html/HtmlResponseStateManager.java

ViolationLine
Avoid empty if statements149 - 151

org/apache/myfaces/resource/TempDirFileCacheResourceLoader.java

ViolationLine
Overriding method merely calls super213 - 216
Avoid empty catch blocks305 - 308

org/apache/myfaces/shared_impl/webapp/webxml/FilterMapping.java

ViolationLine
These nested if statements could be combined41 - 44

org/apache/myfaces/shared_impl/webapp/webxml/WebXmlParser.java

ViolationLine
Avoid empty if statements263 - 265
Avoid empty if statements345 - 347
Avoid empty if statements388 - 390

org/apache/myfaces/spi/impl/DefaultAnnotationProviderFactory.java

ViolationLine
Avoid empty catch blocks96 - 99
Avoid empty catch blocks100 - 103

org/apache/myfaces/spi/impl/DefaultFaceletConfigResourceProviderFactory.java

ViolationLine
Avoid empty catch blocks82 - 85
Avoid empty catch blocks86 - 89

org/apache/myfaces/spi/impl/DefaultFacesConfigResourceProviderFactory.java

ViolationLine
Avoid empty catch blocks81 - 84
Avoid empty catch blocks85 - 88

org/apache/myfaces/spi/impl/DefaultFacesConfigurationMergerFactory.java

ViolationLine
Avoid empty catch blocks81 - 84
Avoid empty catch blocks85 - 88

org/apache/myfaces/spi/impl/DefaultFacesConfigurationProviderFactory.java

ViolationLine
Avoid empty catch blocks90 - 93
Avoid empty catch blocks94 - 97

org/apache/myfaces/spi/impl/DefaultServiceProviderFinder.java

ViolationLine
Avoid empty catch blocks141 - 144

org/apache/myfaces/spi/impl/DefaultWebConfigProviderFactory.java

ViolationLine
Avoid empty catch blocks85 - 88
Avoid empty catch blocks89 - 92

org/apache/myfaces/taglib/core/AttributeTag.java

ViolationLine
These nested if statements could be combined123 - 133

org/apache/myfaces/taglib/core/DelegateValueChangeListener.java

ViolationLine
Avoid empty catch blocks111 - 115
Avoid empty catch blocks139 - 143

org/apache/myfaces/taglib/core/GenericMinMaxValidatorTag.java

ViolationLine
These nested if statements could be combined84 - 87

org/apache/myfaces/taglib/core/ValidateRequiredTag.java

ViolationLine
These nested if statements could be combined90 - 93

org/apache/myfaces/util/CDataEndEscapeFilterWriter.java

ViolationLine
These nested if statements could be combined50 - 54

org/apache/myfaces/util/ContainerUtils.java

ViolationLine
Avoid empty catch blocks58 - 61

org/apache/myfaces/util/DebugUtils.java

ViolationLine
Avoid empty if statements219 - 221

org/apache/myfaces/view/ViewDeclarationLanguageFactoryImpl.java

ViolationLine
These nested if statements could be combined167 - 172

org/apache/myfaces/view/facelets/DefaultFaceletsStateManagementHelper.java

ViolationLine
These nested if statements could be combined214 - 221
Avoid empty while statements478 - 480

org/apache/myfaces/view/facelets/DefaultFaceletsStateManagementStrategy.java

ViolationLine
Avoid unused private fields such as 'CHECK_ID_PRODUCTION_MODE_FALSE'.162
Avoid unused local variables such as 'viewParameters'.245
These nested if statements could be combined480 - 499
Avoid unused local variables such as 'externalContext'.566
These nested if statements could be combined677 - 689
Avoid unused private methods such as 'checkIds(FacesContext,UIComponent,Set)'.1098
Avoid unused local variables such as 'children'.1101

org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java

ViolationLine
These nested if statements could be combined562 - 565
Avoid unused private methods such as '_publishPreRemoveFromViewEvent(FacesContext,UIComponent)'.626
These nested if statements could be combined1137 - 1142
Avoid unused method parameters such as 'attributeName'.1412 - 1440
Avoid unused method parameters such as 'targetAttributeName'.1412 - 1440
Avoid unused method parameters such as 'mctx'.1412 - 1440
Avoid unused method parameters such as 'topLevelComponent'.1412 - 1440
Avoid unused method parameters such as 'attributeName'.1442 - 1490
Avoid unused method parameters such as 'topLevelComponent'.1442 - 1490
Avoid unused method parameters such as 'attributeName'.1492 - 1534
Avoid unused method parameters such as 'topLevelComponent'.1492 - 1534
Avoid unused method parameters such as 'attributeName'.1536 - 1585
Avoid unused method parameters such as 'topLevelComponent'.1536 - 1585
Avoid unused method parameters such as 'elContext'.1587 - 1654
Avoid unused local variables such as 'request'.2391

org/apache/myfaces/view/facelets/FaceletViewHandler.java

ViolationLine
Avoid unused private fields such as 'developmentMode'.130

org/apache/myfaces/view/facelets/compiler/Compiler.java

ViolationLine
Avoid empty catch blocks194 - 197

org/apache/myfaces/view/facelets/compiler/FaceletsProcessingInstructions.java

ViolationLine
Unnecessary final modifier in final class72 - 94
Unnecessary final modifier in final class96 - 123

org/apache/myfaces/view/facelets/compiler/NamespaceManager.java

ViolationLine
Unnecessary final modifier in final class95 - 108

org/apache/myfaces/view/facelets/compiler/SAXCompiler.java

ViolationLine
Overriding method merely calls super143 - 146
Overriding method merely calls super349 - 352
Overriding method merely calls super572 - 575
These nested if statements could be combined590 - 596
These nested if statements could be combined704 - 710
Unnecessary final modifier in final class894 - 923
Unnecessary final modifier in final class925 - 951
These nested if statements could be combined939 - 942
Unnecessary final modifier in final class953 - 967

org/apache/myfaces/view/facelets/compiler/TagLibraryConfig.java

ViolationLine
Avoid empty if statements461 - 463
Avoid empty if statements506 - 508
Avoid empty if statements510 - 512
Avoid empty if statements514 - 516
Unnecessary final modifier in final class853 - 879

org/apache/myfaces/view/facelets/compiler/TextUnit.java

ViolationLine
Do not use if statements that are always true or always false389
Unnecessary final modifier in final class486 - 510
Unnecessary final modifier in final class512 - 598
These nested if statements could be combined529 - 532
Unnecessary final modifier in final class609 - 760
These nested if statements could be combined662 - 665
Avoid unused private methods such as 'getFirstTextCharLocationIgnoringSpacesTabsAndCarriageReturn(String)'.762

org/apache/myfaces/view/facelets/compiler/_ComponentUtils.java

ViolationLine
Avoid unused method parameters such as 'separatorChar'.239 - 261
Avoid unused private methods such as 'dynamicIdIsEqual(String,String)'.263

org/apache/myfaces/view/facelets/el/ContextAwareTagMethodExpression.java

ViolationLine
Avoid empty catch blocks125 - 128

org/apache/myfaces/view/facelets/el/ContextAwareTagValueExpression.java

ViolationLine
Avoid empty catch blocks120 - 123

org/apache/myfaces/view/facelets/el/DefaultVariableMapper.java

ViolationLine
These nested if statements could be combined85 - 93
These nested if statements could be combined118 - 121

org/apache/myfaces/view/facelets/el/ELText.java

ViolationLine
These nested if statements could be combined508 - 531
These nested if statements could be combined510 - 530
These nested if statements could be combined593 - 616
These nested if statements could be combined595 - 615
Avoid unused local variables such as 'vlen'.652
These nested if statements could be combined668 - 676
These nested if statements could be combined670 - 675

org/apache/myfaces/view/facelets/impl/DefaultFacelet.java

ViolationLine
Unnecessary final modifier in final class225 - 285
Unnecessary final modifier in final class287 - 311

org/apache/myfaces/view/facelets/impl/FaceletCompositionContextImpl.java

ViolationLine
These nested if statements could be combined844 - 855

org/apache/myfaces/view/facelets/tag/MetaRulesetImpl.java

ViolationLine
Unnecessary final modifier in final class238 - 267

org/apache/myfaces/view/facelets/tag/composite/AttributeHandler.java

ViolationLine
Avoid unused method parameters such as 'parent'.314 - 403
Avoid empty catch blocks340 - 343

org/apache/myfaces/view/facelets/tag/composite/CompositeComponentDefinitionTagHandler.java

ViolationLine
These nested if statements could be combined125 - 129
Avoid unused method parameters such as 'ctx'.266 - 272

org/apache/myfaces/view/facelets/tag/composite/CompositeComponentResourceTagHandler.java

ViolationLine
Avoid unused method parameters such as 'parent'.535 - 562

org/apache/myfaces/view/facelets/tag/composite/CompositeResourceLibrary.java

ViolationLine
These nested if statements could be combined193 - 197
These nested if statements could be combined206 - 224
These nested if statements could be combined240 - 270

org/apache/myfaces/view/facelets/tag/composite/FacetHandler.java

ViolationLine
Avoid unused method parameters such as 'parent'.288 - 324

org/apache/myfaces/view/facelets/tag/composite/InsertFacetHandler.java

ViolationLine
Avoid unused local variables such as 'parentCompositeComponent'.154
Avoid unused method parameters such as 'parent'.162 - 185

org/apache/myfaces/view/facelets/tag/jsf/ComponentTagHandlerDelegate.java

ViolationLine
Avoid unused method parameters such as 'facesContext'.666 - 736
These nested if statements could be combined710 - 714
These nested if statements could be combined722 - 731
Avoid unused method parameters such as 'ctx'.738 - 785
Avoid unused method parameters such as 'facesContext'.801 - 839
Avoid unused method parameters such as 'mctx'.801 - 839
These nested if statements could be combined824 - 834

org/apache/myfaces/view/facelets/tag/jsf/core/SelectItemsHandler.java

ViolationLine
Avoid unused private methods such as 'getNoSelectionValue()'.53

org/apache/myfaces/view/facelets/tag/jstl/core/ChooseHandler.java

ViolationLine
These nested if statements could be combined107 - 145
These nested if statements could be combined159 - 165
These nested if statements could be combined179 - 185

org/apache/myfaces/view/facelets/tag/jstl/core/ForEachHandler.java

ViolationLine
Unnecessary final modifier in final class322 - 329
Unnecessary final modifier in final class331 - 338
Unnecessary final modifier in final class340 - 347
Unnecessary final modifier in final class349 - 356
Unnecessary final modifier in final class358 - 365
Unnecessary final modifier in final class367 - 382
Unnecessary final modifier in final class384 - 391
Unnecessary final modifier in final class393 - 400
Unnecessary final modifier in final class402 - 425

org/apache/myfaces/view/facelets/tag/jstl/core/IfHandler.java

ViolationLine
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.110

org/apache/myfaces/view/facelets/tag/jstl/core/SetHandler.java

ViolationLine
These nested if statements could be combined142 - 145

org/apache/myfaces/view/facelets/tag/jstl/fn/JstlFunction.java

ViolationLine
Avoid empty if statements109 - 111

org/apache/myfaces/view/facelets/tag/ui/ParamHandler.java

ViolationLine
These nested if statements could be combined97 - 101

org/apache/myfaces/view/facelets/tag/ui/RepeatHandler.java

ViolationLine
Avoid empty catch blocks90 - 93

org/apache/myfaces/view/facelets/util/Classpath.java

ViolationLine
Avoid empty catch blocks218 - 220
Avoid empty catch blocks351 - 354
Avoid empty catch blocks381 - 385

org/apache/myfaces/view/facelets/util/FastWriter.java

ViolationLine
Unnecessary final modifier in final class58 - 66

org/apache/myfaces/view/facelets/util/ParameterCheck.java

ViolationLine
Unnecessary final modifier in final class28 - 34

org/apache/myfaces/view/facelets/util/Path.java

ViolationLine
Unnecessary final modifier in final class28 - 69
Unnecessary final modifier in final class71 - 97
Unnecessary final modifier in final class99 - 107

org/apache/myfaces/view/facelets/util/Resource.java

ViolationLine
These nested if statements could be combined78 - 81
Avoid empty catch blocks107 - 111

org/apache/myfaces/webapp/AbstractFacesInitializer.java

ViolationLine
Avoid unused method parameters such as 'servletContext'.282 - 287

org/apache/myfaces/webapp/Jsp21FacesInitializer.java

ViolationLine
Avoid empty catch blocks90 - 93

org/apache/myfaces/webapp/StartupServletContextListener.java

ViolationLine
Avoid empty catch blocks229 - 232
These nested if statements could be combined305 - 308