FindBugs Bug Detector Report
The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is low
Effort is min
Files
org.apache.myfaces.shared.application.DefaultViewHandlerSupport
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of mapping, which is known to be non-null in org.apache.myfaces.shared.application.DefaultViewHandlerSupport.calculateActionURL(FacesContext, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 202 | Low |
| Redundant nullcheck of viewId, which is known to be non-null in org.apache.myfaces.shared.application.DefaultViewHandlerSupport.calculateAndCheckViewId(FacesContext, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 165 | Low |
| Redundant nullcheck of viewId, which is known to be non-null in org.apache.myfaces.shared.application.DefaultViewHandlerSupport.calculateAndCheckViewId(FacesContext, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 174 | Low |
| Redundant nullcheck of viewId, which is known to be non-null in org.apache.myfaces.shared.application.DefaultViewHandlerSupport.calculateViewId(FacesContext, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 130 | Low |
org.apache.myfaces.shared.context.flash.SubKeyMap$Entry
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of key, which is known to be non-null in org.apache.myfaces.shared.context.flash.SubKeyMap$Entry.hashCode() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 294 | Low |
org.apache.myfaces.shared.renderkit.ContentTypeUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.shared.renderkit.ContentTypeUtils.AJAX_XHTML_ALLOWED_CONTENT_TYPES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 47 | Low |
| org.apache.myfaces.shared.renderkit.ContentTypeUtils.HTML_ALLOWED_CONTENT_TYPES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 37 | Low |
| org.apache.myfaces.shared.renderkit.ContentTypeUtils.XHTML_ALLOWED_CONTENT_TYPES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 44 | Low |
org.apache.myfaces.shared.renderkit.RendererUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true in org.apache.myfaces.shared.renderkit.RendererUtils.getConvertedUISelectOneValue(FacesContext, UISelectOne, Object), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 977 | Medium |
| Method org.apache.myfaces.shared.renderkit.RendererUtils.getViewSequence(FacesContext) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 1204 | Medium |
| Possible null pointer dereference of content in org.apache.myfaces.shared.renderkit.RendererUtils.loadResourceFile(FacesContext, String) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 1419 | Medium |
org.apache.myfaces.shared.renderkit._SharedRendererUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.myfaces.shared.renderkit._SharedRendererUtils.getConvertedUISelectManyValue(FacesContext, UISelectMany, String[], boolean) | STYLE | REC_CATCH_EXCEPTION | 254 | Low |
org.apache.myfaces.shared.renderkit.html.HTML
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.shared.renderkit.html.HTML.ANCHOR_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 218 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.ANCHOR_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 231 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.ANCHOR_PASSTHROUGH_ATTRIBUTES_WITHOUT_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 246 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.ANCHOR_PASSTHROUGH_ATTRIBUTES_WITHOUT_ONCLICK_WITHOUT_STYLE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 241 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.ANCHOR_PASSTHROUGH_ATTRIBUTES_WITHOUT_STYLE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 236 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.ANCHOR_PASSTHROUGH_ATTRIBUTES_WITHOUT_STYLE_AND_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 250 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.BODY_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 517 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.BODY_ATTRIBUTES_WITHOUT_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 529 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.BODY_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 539 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.BODY_PASSTHROUGH_ATTRIBUTES_WITHOUT_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 543 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.BUTTON_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 361 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.BUTTON_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 374 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_FIELD_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 143 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_FIELD_EVENT_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 89 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_FIELD_EVENT_ATTRIBUTES_WITHOUT_ONFOCUS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 97 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_FIELD_EVENT_ATTRIBUTES_WITHOUT_ONSELECT_AND_ONCHANGE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 104 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 170 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 199 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONCLICK should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 190 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONFOCUS_AND_ONCLICK should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 185 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_STYLE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 175 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_STYLE_AND_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 203 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_PASSTROUGH_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 154 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_PASSTROUGH_ATTRIBUTES_WITHOUT_ONCLICK should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 162 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_PASSTROUGH_ATTRIBUTES_WITHOUT_ONCLICK_WITHOUT_STYLE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 166 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_PASSTROUGH_ATTRIBUTES_WITHOUT_ONMOUSEOVER_AND_ONMOUSEOUT should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 195 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_PASSTROUGH_ATTRIBUTES_WITHOUT_STYLE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 158 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.EVENT_HANDLER_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 81 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.EVENT_HANDLER_ATTRIBUTES_WITHOUT_ONCLICK should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 58 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.EVENT_HANDLER_ATTRIBUTES_WITHOUT_ONMOUSEOVER_AND_ONMOUSEOUT should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 70 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.FORM_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 260 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.FORM_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 269 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.FORM_PASSTHROUGH_ATTRIBUTES_WITHOUT_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 273 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.IMG_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 287 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.IMG_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 300 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.IMG_PASSTHROUGH_ATTRIBUTES_WITHOUT_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 308 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.INPUT_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 318 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.INPUT_FILE_UPLOAD_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 461 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 326 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 340 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_STYLE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 330 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_STYLE_AND_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 345 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.LABEL_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 385 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.LABEL_ATTRIBUTES_WITHOUT_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 392 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.MESSAGE_PASSTHROUGH_ATTRIBUTES_WITHOUT_TITLE_STYLE_AND_STYLE_CLASS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 481 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.SELECT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 408 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.SELECT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 410 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.SELECT_TABLE_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 488 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.TABLE_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 420 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.TABLE_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 431 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.TABLE_PASSTHROUGH_ATTRIBUTES_WITHOUT_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 435 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.TEXTAREA_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 444 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.TEXTAREA_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 451 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.TEXTAREA_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 455 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.UL_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 492 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.UNIVERSAL_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 130 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.UNIVERSAL_ATTRIBUTES_WITHOUT_STYLE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 117 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.UNIVERSAL_ATTRIBUTES_WITHOUT_STYLE_AND_TITLE should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 125 | Medium |
| org.apache.myfaces.shared.renderkit.html.HTML.BUTTON_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 366 | Low |
| org.apache.myfaces.shared.renderkit.html.HTML.BUTTON_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONCLICK should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 370 | Low |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_FIELD_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 148 | Low |
| org.apache.myfaces.shared.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONFOCUS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 180 | Low |
| org.apache.myfaces.shared.renderkit.html.HTML.IMG_PASSTHROUGH_ATTRIBUTES_WITHOUT_ONMOUSEOVER_AND_ONMOUSEOUT should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 304 | Low |
| org.apache.myfaces.shared.renderkit.html.HTML.INPUT_FILE_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 465 | Low |
| org.apache.myfaces.shared.renderkit.html.HTML.INPUT_FILE_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 469 | Low |
| org.apache.myfaces.shared.renderkit.html.HTML.INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONFOCUS_AND_ONCLICK should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 335 | Low |
| org.apache.myfaces.shared.renderkit.html.HTML.LABEL_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 396 | Low |
| org.apache.myfaces.shared.renderkit.html.HTML.LABEL_PASSTHROUGH_ATTRIBUTES_WITHOUT_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 400 | Low |
| org.apache.myfaces.shared.renderkit.html.HTML.UL_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 496 | Low |
| org.apache.myfaces.shared.renderkit.html.HTML.UL_PASSTHROUGH_ATTRIBUTES_WITHOUT_EVENTS should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 500 | Low |
org.apache.myfaces.shared.renderkit.html.HtmlButtonRendererBase
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to externalContext in org.apache.myfaces.shared.renderkit.html.HtmlButtonRendererBase.encodeEnd(FacesContext, UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 177 | Medium |
| Method org.apache.myfaces.shared.renderkit.html.HtmlButtonRendererBase.encodeEnd(FacesContext, UIComponent) invokes toString() method on a String | PERFORMANCE | DM_STRING_TOSTRING | 213 | Low |
| Private method org.apache.myfaces.shared.renderkit.html.HtmlButtonRendererBase.getImage(UIComponent) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 710-714 | Low |
| Private method org.apache.myfaces.shared.renderkit.html.HtmlButtonRendererBase.hasSubmittingBehavior(Map, String) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 326-337 | Low |
org.apache.myfaces.shared.renderkit.html.HtmlCheckboxRendererBase
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.model.SelectItem to javax.faces.model.SelectItemGroup in org.apache.myfaces.shared.renderkit.html.HtmlCheckboxRendererBase.renderGroupOrItemCheckbox(FacesContext, UIComponent, SelectItem, boolean, Set, Converter, boolean, Integer) | STYLE | BC_UNCONFIRMED_CAST | 248 | Low |
org.apache.myfaces.shared.renderkit.html.HtmlFormRendererBase
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIForm in org.apache.myfaces.shared.renderkit.html.HtmlFormRendererBase.decode(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 266 | Low |
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIForm in org.apache.myfaces.shared.renderkit.html.HtmlFormRendererBase.encodeBegin(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 65 | Low |
| Private method org.apache.myfaces.shared.renderkit.html.HtmlFormRendererBase.getAcceptCharset(UIComponent) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 320-324 | Medium |
org.apache.myfaces.shared.renderkit.html.HtmlGroupRendererBase
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.html.HtmlPanelGroup in org.apache.myfaces.shared.renderkit.html.HtmlGroupRendererBase.encodeEnd(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 65 | Low |
org.apache.myfaces.shared.renderkit.html.HtmlLinkRendererBase
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Private method org.apache.myfaces.shared.renderkit.html.HtmlLinkRendererBase.renderLinkParameter(String, Object, StringBuilder, String, UIComponent) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 1229-1241 | Low |
org.apache.myfaces.shared.renderkit.html.HtmlRadioRendererBase
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UISelectOne in org.apache.myfaces.shared.renderkit.html.HtmlRadioRendererBase.encodeEnd(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 65 | Low |
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UISelectOne in org.apache.myfaces.shared.renderkit.html.HtmlRadioRendererBase.getConvertedValue(FacesContext, UIComponent, Object) | STYLE | BC_UNCONFIRMED_CAST | 449 | Low |
| Unchecked/unconfirmed cast from javax.faces.model.SelectItem to javax.faces.model.SelectItemGroup in org.apache.myfaces.shared.renderkit.html.HtmlRadioRendererBase.renderGroupOrItemRadio(FacesContext, UIComponent, SelectItem, Object, Converter, boolean, Integer) | STYLE | BC_UNCONFIRMED_CAST | 222 | Low |
| Load of known null value in org.apache.myfaces.shared.renderkit.html.HtmlRadioRendererBase.renderGroupOrItemRadio(FacesContext, UIComponent, SelectItem, Object, Converter, boolean, Integer) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 248 | Medium |
org.apache.myfaces.shared.renderkit.html.HtmlRendererUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIOutput in org.apache.myfaces.shared.renderkit.html.HtmlRendererUtils.findUIOutputConverterFailSafe(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 511 | Low |
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UISelectMany in org.apache.myfaces.shared.renderkit.html.HtmlRendererUtils.findUISelectManyConverterFailsafe(FacesContext, UIComponent, boolean) | STYLE | BC_UNCONFIRMED_CAST | 493 | Low |
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UISelectMany in org.apache.myfaces.shared.renderkit.html.HtmlRendererUtils.getSubmittedOrSelectedValuesAsSet(boolean, UIComponent, FacesContext, Converter) | STYLE | BC_UNCONFIRMED_CAST | 447 | Low |
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UISelectOne in org.apache.myfaces.shared.renderkit.html.HtmlRendererUtils.getSubmittedOrSelectedValuesAsSet(boolean, UIComponent, FacesContext, Converter) | STYLE | BC_UNCONFIRMED_CAST | 458 | Low |
| org.apache.myfaces.shared.renderkit.html.HtmlRendererUtils.isTrue(Object) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 206 | Medium |
| public static org.apache.myfaces.shared.renderkit.html.HtmlRendererUtils.getSupportedContentTypes() may expose internal representation by returning HtmlRendererUtils.SUPPORTED_CONTENT_TYPES | MALICIOUS_CODE | MS_EXPOSE_REP | 1823 | Medium |
| Method call in org.apache.myfaces.shared.renderkit.html.HtmlRendererUtils.renderDisplayValueOnlyForSelects(FacesContext, UIComponent, boolean) passes null for nonnull parameter of renderSelectOptionsAsText(FacesContext, UIComponent, Converter, Set, List, boolean) | CORRECTNESS | NP_NULL_PARAM_DEREF | 1044 | Medium |
| Private method org.apache.myfaces.shared.renderkit.html.HtmlRendererUtils.getClientBehaviorScript(FacesContext, UIComponent, String, Map, HtmlRendererUtils$ScriptContext, Collection) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 1941 | Medium |
org.apache.myfaces.shared.renderkit.html.HtmlResponseWriterImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 240 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 764 | Low |
org.apache.myfaces.shared.renderkit.html.HtmlSecretRendererBase
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIOutput in org.apache.myfaces.shared.renderkit.html.HtmlSecretRendererBase.getConvertedValue(FacesContext, UIComponent, Object) | STYLE | BC_UNCONFIRMED_CAST | 238 | Low |
org.apache.myfaces.shared.renderkit.html.HtmlTableRendererBase
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIData in org.apache.myfaces.shared.renderkit.html.HtmlTableRendererBase.encodeChildren(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 212 | Low |
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIData in org.apache.myfaces.shared.renderkit.html.HtmlTableRendererBase.encodeEnd(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 889 | Low |
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIData in org.apache.myfaces.shared.renderkit.html.HtmlTableRendererBase.encodeInnerHtml(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 363 | Low |
| Method org.apache.myfaces.shared.renderkit.html.HtmlTableRendererBase.renderColumnFooterCell(FacesContext, ResponseWriter, UIComponent, UIComponent, String, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 1350 | Medium |
| Method org.apache.myfaces.shared.renderkit.html.HtmlTableRendererBase.renderColumnHeaderCell(FacesContext, ResponseWriter, UIComponent, UIComponent, String, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 1295 | Medium |
| Method org.apache.myfaces.shared.renderkit.html.HtmlTableRendererBase.renderTableHeaderOrFooterRow(FacesContext, ResponseWriter, UIComponent, UIComponent, String, String, int, boolean) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 1124 | Medium |
| Redundant nullcheck of elemName, which is known to be non-null in org.apache.myfaces.shared.renderkit.html.HtmlTableRendererBase.renderFacet(FacesContext, ResponseWriter, UIComponent, boolean) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 987 | Low |
org.apache.myfaces.shared.renderkit.html.HtmlTextRendererBase
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIOutput in org.apache.myfaces.shared.renderkit.html.HtmlTextRendererBase.getConvertedValue(FacesContext, UIComponent, Object) | STYLE | BC_UNCONFIRMED_CAST | 355 | Low |
| Check for sign of bitwise operation in org.apache.myfaces.shared.renderkit.html.HtmlTextRendererBase.renderOutput(FacesContext, UIComponent) | BAD_PRACTICE | BIT_SIGNED_CHECK | 116 | Medium |
org.apache.myfaces.shared.renderkit.html.HtmlTextareaRendererBase
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIOutput in org.apache.myfaces.shared.renderkit.html.HtmlTextareaRendererBase.getConvertedValue(FacesContext, UIComponent, Object) | STYLE | BC_UNCONFIRMED_CAST | 208 | Low |
org.apache.myfaces.shared.renderkit.html.util.HTMLEncoder
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to builder in org.apache.myfaces.shared.renderkit.html.util.HTMLEncoder.percentEncodeNonUsAsciiCharacter(Writer, char, String) | STYLE | DLS_DEAD_LOCAL_STORE | 1141 | High |
| Redundant nullcheck of app which is known to be null in org.apache.myfaces.shared.renderkit.html.util.HTMLEncoder.encodeURIAtributte(Writer, String, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 1064 | Medium |
org.apache.myfaces.shared.renderkit.html.util.JavascriptUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 159 | Low |
org.apache.myfaces.shared.resource.BaseResourceHandlerSupport
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.shared.resource.BaseResourceHandlerSupport.getResourceLoaders() return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 65 | Low |
| Redundant nullcheck of mapping, which is known to be non-null in org.apache.myfaces.shared.resource.BaseResourceHandlerSupport.calculateResourceBasePath(FacesContext) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 73 | Low |
| Redundant nullcheck of mapping, which is known to be non-null in org.apache.myfaces.shared.resource.BaseResourceHandlerSupport.getMapping() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 135 | Low |
org.apache.myfaces.shared.resource.ResourceLoader$VersionComparator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.shared.resource.ResourceLoader$VersionComparator be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 86-147 | Medium |
org.apache.myfaces.shared.resource.ResourceLoaderUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.shared.resource.ResourceLoaderUtils.parseDateHeader(String) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 75 | Medium |
org.apache.myfaces.shared.resource.ValueExpressionFilterInputStream
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unwritten field: org.apache.myfaces.shared.resource.ValueExpressionFilterInputStream.libraryName | CORRECTNESS | UWF_UNWRITTEN_FIELD | 121 | Medium |
| Unwritten field: org.apache.myfaces.shared.resource.ValueExpressionFilterInputStream.resourceName | CORRECTNESS | UWF_UNWRITTEN_FIELD | 121 | Medium |
org.apache.myfaces.shared.test.ClassElementHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| ClassElementHandler.buffer not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available | Low |
org.apache.myfaces.shared.trace.TracingIterator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.shared.trace.TracingIterator.next() can't throw NoSuchElementException | BAD_PRACTICE | IT_NO_SUCH_ELEMENT | 69 | Low |
org.apache.myfaces.shared.util.ClassUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to plugins in org.apache.myfaces.shared.util.ClassUtils.classForName(String) | STYLE | DLS_DEAD_LOCAL_STORE | 173 | Medium |
| org.apache.myfaces.shared.util.ClassUtils.classLoadingExtensions should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 73 | Medium |
org.apache.myfaces.shared.util.ConcurrentLRUCache
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to newNewestEntry in org.apache.myfaces.shared.util.ConcurrentLRUCache.markAndSweep() | STYLE | DLS_DEAD_LOCAL_STORE | 350 | Low |
| integral division result cast to double or float in new org.apache.myfaces.shared.util.ConcurrentLRUCache(int, int) | STYLE | ICAST_IDIV_CAST_TO_DOUBLE | 92 | Medium |
| new org.apache.myfaces.shared.util.ConcurrentLRUCache(int, int, int, int, boolean, boolean, ConcurrentLRUCache$EvictionListener) invokes org.apache.myfaces.shared.util.ConcurrentLRUCache$CleanupThread.start() | MT_CORRECTNESS | SC_START_IN_CTOR | 86 | Medium |
org.apache.myfaces.shared.util.ConcurrentLRUCache$CleanupThread
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.myfaces.shared.util.ConcurrentLRUCache$CleanupThread.stop; locked 66% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 779 | Medium |
| Naked notify in org.apache.myfaces.shared.util.ConcurrentLRUCache$CleanupThread.wakeThread() | MT_CORRECTNESS | NN_NAKED_NOTIFY | 796 | Medium |
| Using notify rather than notifyAll in org.apache.myfaces.shared.util.ConcurrentLRUCache$CleanupThread.stopThread() | MT_CORRECTNESS | NO_NOTIFY_NOT_NOTIFYALL | 805 | Low |
| Using notify rather than notifyAll in org.apache.myfaces.shared.util.ConcurrentLRUCache$CleanupThread.wakeThread() | MT_CORRECTNESS | NO_NOTIFY_NOT_NOTIFYALL | 796 | Low |
org.apache.myfaces.shared.util.ExceptionUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.myfaces.shared.util.ExceptionUtils.getExceptions(Throwable) | STYLE | REC_CATCH_EXCEPTION | 60 | Low |
org.apache.myfaces.shared.util.StateUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true in org.apache.myfaces.shared.util.StateUtils.getMacSecret(ExternalContext), since all javax.crypto.SecretKey are instances of javax.crypto.SecretKey | STYLE | BC_VACUOUS_INSTANCEOF | 1000 | Medium |
| instanceof will always return true in org.apache.myfaces.shared.util.StateUtils.getSecret(ExternalContext), since all javax.crypto.SecretKey are instances of javax.crypto.SecretKey | STYLE | BC_VACUOUS_INSTANCEOF | 845 | Medium |
| Dead store of null to baos in org.apache.myfaces.shared.util.StateUtils.compress(byte[]) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 371 | Low |
| Dead store of null to gzip in org.apache.myfaces.shared.util.StateUtils.compress(byte[]) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 370 | Low |
| Dead store of null to bais in org.apache.myfaces.shared.util.StateUtils.decompress(byte[]) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 450 | Low |
| Dead store of null to baos in org.apache.myfaces.shared.util.StateUtils.decompress(byte[]) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 449 | Low |
| Dead store of null to gis in org.apache.myfaces.shared.util.StateUtils.decompress(byte[]) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 451 | Low |
| Dead store of null to outputStream in org.apache.myfaces.shared.util.StateUtils.getAsByteArray(Object, ExternalContext) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 297 | Low |
| Dead store of null to writer in org.apache.myfaces.shared.util.StateUtils.getAsByteArray(Object, ExternalContext) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 296 | Low |
| Random object created and used only once in org.apache.myfaces.shared.util.StateUtils.findMacSecret(String, String) | BAD_PRACTICE | DMI_RANDOM_USED_ONLY_ONCE | 1055 | High |
| Random object created and used only once in org.apache.myfaces.shared.util.StateUtils.findSecret(String, String) | BAD_PRACTICE | DMI_RANDOM_USED_ONLY_ONCE | 900 | High |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 710 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 723 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 687 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 669 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 923 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 937 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 1016 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 1028 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 861 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 873 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 971 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 816 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 774 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 199 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.shared.util.StateUtils.decrypt(byte[], ExternalContext) | STYLE | REC_CATCH_EXCEPTION | 525 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.shared.util.StateUtils.encrypt(byte[], ExternalContext) | STYLE | REC_CATCH_EXCEPTION | 353 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.shared.util.StateUtils.getAsObject(byte[], ExternalContext) | STYLE | REC_CATCH_EXCEPTION | 590 | Low |
org.apache.myfaces.shared.util.StreamCharBuffer$StreamCharBufferSubChunkReader
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.apache.myfaces.shared.util.StreamCharBuffer$StreamCharBufferSubChunkReader.parent | PERFORMANCE | URF_UNREAD_FIELD | 1909 | Medium |
org.apache.myfaces.shared.util.StringCharArrayAccessor
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.shared.util.StringCharArrayAccessor.createString(char[]) invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 195 | Medium |
| org.apache.myfaces.shared.util.StringCharArrayAccessor.<static initializer>() invokes reflect.Field.setAccessible(boolean), which should be invoked from within a doPrivileged block | BAD_PRACTICE | DP_DO_INSIDE_DO_PRIVILEGED | 65 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.shared.util.StringCharArrayAccessor.<static initializer>() | STYLE | REC_CATCH_EXCEPTION | 73 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.shared.util.StringCharArrayAccessor.createString(char[]) | STYLE | REC_CATCH_EXCEPTION | 216 | Low |
org.apache.myfaces.shared.util.servlet.SourceCodeServlet
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.shared.util.servlet.SourceCodeServlet is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 32-72 | Low |
org.apache.myfaces.shared.view.JspViewDeclarationLanguageBase
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to response in org.apache.myfaces.shared.view.JspViewDeclarationLanguageBase.getResponseSwitch(Object) | STYLE | DLS_DEAD_LOCAL_STORE | 438 | High |
| Dead store to stateManager in org.apache.myfaces.shared.view.JspViewDeclarationLanguageBase.isViewStateAlreadyEncoded(FacesContext) | STYLE | DLS_DEAD_LOCAL_STORE | 268 | Medium |
org.apache.myfaces.shared.webapp.webxml.WebXmlParser
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.myfaces.shared.webapp.webxml.WebXmlParser.parse() | STYLE | REC_CATCH_EXCEPTION | 114 | Low |