UI-Component Sets

PMD Results

The following document contains the results of PMD 4.2.5.

Files

org/apache/myfaces/application/ApplicationImpl.java

ViolationLine
Avoid unused private fields such as 'PROJECT_STAGE_PARAM_NAME'.149
Avoid empty catch blocks804 - 807
Avoid empty catch blocks808 - 817
These nested if statements could be combined1799 - 1802
These nested if statements could be combined2196 - 2199
These nested if statements could be combined2345 - 2348
These nested if statements could be combined2575 - 2578

org/apache/myfaces/application/NavigationHandlerImpl.java

ViolationLine
These nested if statements could be combined184 - 190
Avoid empty catch blocks464 - 470
These nested if statements could be combined648 - 668
These nested if statements could be combined677 - 686
Avoid unused method parameters such as 'facesContext'.770 - 826
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.849

org/apache/myfaces/application/ResourceHandlerImpl.java

ViolationLine
Avoid empty catch blocks530 - 533

org/apache/myfaces/application/StateManagerImpl.java

ViolationLine
Avoid unused local variables such as 'externalContext'.231

org/apache/myfaces/application/ViewHandlerImpl.java

ViolationLine
Avoid empty if statements383 - 385

org/apache/myfaces/application/jsp/JspStateManagerImpl.java

ViolationLine
These nested if statements could be combined720 - 727
Avoid empty while statements970

org/apache/myfaces/application/jsp/JspViewHandlerImpl.java

ViolationLine
Avoid unused method parameters such as 'renderKit'.471 - 488
Avoid unused method parameters such as 'externalContext'.471 - 488

org/apache/myfaces/application/viewstate/RandomKeyFactory.java

ViolationLine
Avoid empty catch blocks101 - 107

org/apache/myfaces/application/viewstate/SecureRandomKeyFactory.java

ViolationLine
Avoid empty catch blocks123 - 129

org/apache/myfaces/application/viewstate/SerializedViewCollection.java

ViolationLine
These nested if statements could be combined76 - 91
Avoid empty while statements96 - 98
Avoid empty while statements121 - 123

org/apache/myfaces/application/viewstate/ServerSideStateCacheImpl.java

ViolationLine
These nested if statements could be combined288 - 294
These nested if statements could be combined321 - 330

org/apache/myfaces/application/viewstate/SessionIdGenerator.java

ViolationLine
These nested if statements could be combined280 - 284

org/apache/myfaces/component/visit/PartialVisitContext.java

ViolationLine
Avoid empty if statements310 - 312

org/apache/myfaces/config/ConfigFilesXmlValidationUtils.java

ViolationLine
These nested if statements could be combined164 - 167
Avoid empty catch blocks270 - 273
Avoid empty catch blocks279 - 282
Avoid empty catch blocks293 - 295
Avoid empty catch blocks429 - 432
Avoid empty catch blocks437 - 440
Avoid empty catch blocks451 - 453

org/apache/myfaces/config/DefaultFacesConfigurationMerger.java

ViolationLine
These nested if statements could be combined124 - 129
These nested if statements could be combined183 - 189
These nested if statements could be combined352 - 356

org/apache/myfaces/config/FacesConfigurator.java

ViolationLine
Avoid empty catch blocks279 - 282

org/apache/myfaces/config/annotation/AnnotationConfigurator.java

ViolationLine
Avoid unused private fields such as 'rkFactory'.83
These nested if statements could be combined391 - 394
These nested if statements could be combined421 - 424

org/apache/myfaces/config/annotation/DefaultAnnotationProvider.java

ViolationLine
Avoid unused private fields such as 'STANDARD_FACES_CONFIG_RESOURCE'.95
Avoid unused method parameters such as 'context'.440 - 528
Avoid empty catch blocks497 - 500
Avoid empty catch blocks512 - 515
Avoid empty catch blocks516 - 519
Avoid empty catch blocks635 - 638
Avoid empty catch blocks654 - 657
Avoid empty catch blocks658 - 661

org/apache/myfaces/config/annotation/DefaultLifecycleProviderFactory.java

ViolationLine
Avoid empty catch blocks205 - 208
Avoid empty catch blocks209 - 212

org/apache/myfaces/config/annotation/Tomcat7AnnotationLifecycleProvider.java

ViolationLine
Avoid unused constructor parameters such as 'externalContext'.46 - 49
Avoid empty catch blocks111 - 114

org/apache/myfaces/config/annotation/TomcatAnnotationLifecycleProvider.java

ViolationLine
Avoid empty catch blocks79 - 82

org/apache/myfaces/config/annotation/_ClassByteCodeAnnotationFilter.java

ViolationLine
Avoid unused local variables such as 'minorVersion'.102

org/apache/myfaces/config/impl/digester/DigesterFacesConfigDispenserImpl.java

ViolationLine
Avoid unused private fields such as 'faceletCacheFactories'.67

org/apache/myfaces/config/util/Vertex.java

ViolationLine
Avoid unused private fields such as 'm_seen'.41

org/apache/myfaces/context/FacesContextFactoryImpl.java

ViolationLine
These nested if statements could be combined90 - 94

org/apache/myfaces/context/PartialResponseWriterImpl.java

ViolationLine
Avoid unused local variables such as 'elem'.194
Overriding method merely calls super351 - 354

org/apache/myfaces/context/servlet/ServletExternalContextImplBase.java

ViolationLine
These nested if statements could be combined108 - 112

org/apache/myfaces/el/unified/resolver/CompositeComponentELResolver.java

ViolationLine
These nested if statements could be combined105 - 115
These nested if statements could be combined120 - 124

org/apache/myfaces/el/unified/resolver/ManagedBeanResolver.java

ViolationLine
These nested if statements could be combined191 - 194
These nested if statements could be combined211 - 214

org/apache/myfaces/lifecycle/DefaultRestoreViewSupport.java

ViolationLine
Avoid empty catch blocks514 - 517

org/apache/myfaces/logging/MyfacesLogger.java

ViolationLine
Avoid empty catch blocks1781 - 1783

org/apache/myfaces/renderkit/ErrorPageWriter.java

ViolationLine
Avoid empty catch blocks289 - 292
These nested if statements could be combined831 - 838
Avoid empty catch blocks1005 - 1008
These nested if statements could be combined1198 - 1207
Avoid empty catch blocks1332 - 1335
Avoid empty catch blocks1352 - 1355

org/apache/myfaces/renderkit/RenderKitFactoryImpl.java

ViolationLine
These nested if statements could be combined63 - 66

org/apache/myfaces/renderkit/html/HtmlAjaxBehaviorRenderer.java

ViolationLine
Avoid unused method parameters such as 'facesContext'.297 - 323

org/apache/myfaces/renderkit/html/HtmlCompositeFacetRenderer.java

ViolationLine
Avoid unused private fields such as 'log'.39

org/apache/myfaces/renderkit/html/HtmlRenderKitImpl.java

ViolationLine
Avoid unused private methods such as 'checkNull(Object,String)'.359

org/apache/myfaces/renderkit/html/HtmlResponseStateManager.java

ViolationLine
Avoid empty if statements152 - 154

org/apache/myfaces/shared_impl/webapp/webxml/FilterMapping.java

ViolationLine
These nested if statements could be combined41 - 44

org/apache/myfaces/shared_impl/webapp/webxml/WebXmlParser.java

ViolationLine
Avoid empty if statements254 - 256
Avoid empty if statements322 - 324
Avoid empty if statements358 - 360

org/apache/myfaces/spi/impl/DefaultAnnotationProviderFactory.java

ViolationLine
Avoid empty catch blocks94 - 97
Avoid empty catch blocks98 - 101

org/apache/myfaces/spi/impl/DefaultFaceletConfigResourceProviderFactory.java

ViolationLine
Avoid empty catch blocks80 - 83
Avoid empty catch blocks84 - 87

org/apache/myfaces/spi/impl/DefaultFacesConfigResourceProviderFactory.java

ViolationLine
Avoid empty catch blocks80 - 83
Avoid empty catch blocks84 - 87

org/apache/myfaces/spi/impl/DefaultFacesConfigurationMergerFactory.java

ViolationLine
Avoid empty catch blocks81 - 84
Avoid empty catch blocks85 - 88

org/apache/myfaces/spi/impl/DefaultFacesConfigurationProviderFactory.java

ViolationLine
Avoid empty catch blocks86 - 89
Avoid empty catch blocks90 - 93

org/apache/myfaces/spi/impl/DefaultServiceProviderFinder.java

ViolationLine
Avoid empty catch blocks141 - 144

org/apache/myfaces/spi/impl/DefaultWebConfigProviderFactory.java

ViolationLine
Avoid empty catch blocks84 - 87
Avoid empty catch blocks88 - 91

org/apache/myfaces/taglib/core/AttributeTag.java

ViolationLine
These nested if statements could be combined123 - 133

org/apache/myfaces/taglib/core/DelegateValueChangeListener.java

ViolationLine
Avoid empty catch blocks111 - 115
Avoid empty catch blocks139 - 143

org/apache/myfaces/taglib/core/GenericMinMaxValidatorTag.java

ViolationLine
These nested if statements could be combined84 - 87

org/apache/myfaces/taglib/core/ValidateRequiredTag.java

ViolationLine
These nested if statements could be combined90 - 93

org/apache/myfaces/util/CDataEndEscapeFilterWriter.java

ViolationLine
These nested if statements could be combined50 - 54

org/apache/myfaces/util/ContainerUtils.java

ViolationLine
An empty statement (semicolon) not part of a loop58

org/apache/myfaces/util/DebugUtils.java

ViolationLine
Avoid empty if statements219 - 221

org/apache/myfaces/view/ViewDeclarationLanguageFactoryImpl.java

ViolationLine
These nested if statements could be combined167 - 172

org/apache/myfaces/view/facelets/DefaultFaceletsStateManagementHelper.java

ViolationLine
These nested if statements could be combined213 - 220
Avoid empty while statements448

org/apache/myfaces/view/facelets/DefaultFaceletsStateManagementStrategy.java

ViolationLine
Avoid unused private fields such as 'CHECK_ID_PRODUCTION_MODE_FALSE'.160
Avoid unused local variables such as 'viewParameters'.240
These nested if statements could be combined470 - 489
Avoid unused local variables such as 'externalContext'.556
These nested if statements could be combined667 - 679
Avoid unused private methods such as 'checkIds(FacesContext,UIComponent,Set)'.1088
Avoid unused local variables such as 'children'.1091

org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java

ViolationLine
Avoid unused private methods such as '_publishPreRemoveFromViewEvent(FacesContext,UIComponent)'.512
These nested if statements could be combined995 - 1000
Avoid unused local variables such as 'request'.2049

org/apache/myfaces/view/facelets/FaceletViewHandler.java

ViolationLine
Avoid unused private fields such as 'developmentMode'.131

org/apache/myfaces/view/facelets/compiler/Compiler.java

ViolationLine
Avoid empty catch blocks190 - 193

org/apache/myfaces/view/facelets/compiler/NamespaceManager.java

ViolationLine
Unnecessary final modifier in final class95 - 108

org/apache/myfaces/view/facelets/compiler/SAXCompiler.java

ViolationLine
Overriding method merely calls super131 - 134
Overriding method merely calls super318 - 321
Overriding method merely calls super520 - 523
These nested if statements could be combined538 - 544
These nested if statements could be combined644 - 650
Unnecessary final modifier in final class817 - 843
Unnecessary final modifier in final class845 - 871
These nested if statements could be combined859 - 862
Unnecessary final modifier in final class873 - 887

org/apache/myfaces/view/facelets/compiler/TagLibraryConfig.java

ViolationLine
Avoid empty if statements321 - 323
Avoid empty if statements366 - 368
Avoid empty if statements370 - 372
Avoid empty if statements374 - 376
Unnecessary final modifier in final class712 - 738

org/apache/myfaces/view/facelets/compiler/TextUnit.java

ViolationLine
Do not use if statements that are always true or always false280
Unnecessary final modifier in final class368 - 392

org/apache/myfaces/view/facelets/compiler/_ComponentUtils.java

ViolationLine
Avoid unused method parameters such as 'separatorChar'.239 - 261
Avoid unused private methods such as 'dynamicIdIsEqual(String,String)'.263

org/apache/myfaces/view/facelets/el/ContextAwareTagMethodExpression.java

ViolationLine
Avoid empty catch blocks123 - 126

org/apache/myfaces/view/facelets/el/ContextAwareTagValueExpression.java

ViolationLine
Avoid empty catch blocks118 - 121

org/apache/myfaces/view/facelets/el/DefaultVariableMapper.java

ViolationLine
These nested if statements could be combined85 - 93
These nested if statements could be combined98 - 106

org/apache/myfaces/view/facelets/el/ELText.java

ViolationLine
These nested if statements could be combined482 - 505
These nested if statements could be combined484 - 504

org/apache/myfaces/view/facelets/impl/DefaultFacelet.java

ViolationLine
Unnecessary final modifier in final class225 - 285
Unnecessary final modifier in final class287 - 311

org/apache/myfaces/view/facelets/impl/FaceletCompositionContextImpl.java

ViolationLine
These nested if statements could be combined841 - 852

org/apache/myfaces/view/facelets/tag/MetaRulesetImpl.java

ViolationLine
Unnecessary final modifier in final class238 - 267

org/apache/myfaces/view/facelets/tag/composite/AttributeHandler.java

ViolationLine
Avoid unused method parameters such as 'parent'.307 - 390
Avoid empty catch blocks333 - 336

org/apache/myfaces/view/facelets/tag/composite/CompositeComponentDefinitionTagHandler.java

ViolationLine
These nested if statements could be combined121 - 125
Avoid unused method parameters such as 'ctx'.223 - 229

org/apache/myfaces/view/facelets/tag/composite/CompositeComponentResourceTagHandler.java

ViolationLine
Avoid unused method parameters such as 'parent'.535 - 562

org/apache/myfaces/view/facelets/tag/composite/CompositeResourceLibrary.java

ViolationLine
These nested if statements could be combined65 - 69
These nested if statements could be combined78 - 88
These nested if statements could be combined104 - 125

org/apache/myfaces/view/facelets/tag/composite/FacetHandler.java

ViolationLine
Avoid unused method parameters such as 'parent'.288 - 324

org/apache/myfaces/view/facelets/tag/composite/InsertFacetHandler.java

ViolationLine
Avoid unused local variables such as 'parentCompositeComponent'.153
Avoid unused method parameters such as 'parent'.162 - 185

org/apache/myfaces/view/facelets/tag/jsf/ComponentTagHandlerDelegate.java

ViolationLine
Avoid unused method parameters such as 'facesContext'.666 - 736
These nested if statements could be combined710 - 714
These nested if statements could be combined722 - 731
Avoid unused method parameters such as 'ctx'.738 - 785
Avoid unused method parameters such as 'facesContext'.801 - 839
Avoid unused method parameters such as 'mctx'.801 - 839
These nested if statements could be combined824 - 834

org/apache/myfaces/view/facelets/tag/jsf/core/SelectItemsHandler.java

ViolationLine
Avoid unused private methods such as 'getNoSelectionValue()'.53

org/apache/myfaces/view/facelets/tag/jstl/core/ChooseHandler.java

ViolationLine
These nested if statements could be combined107 - 145
These nested if statements could be combined159 - 165
These nested if statements could be combined179 - 185

org/apache/myfaces/view/facelets/tag/jstl/core/ForEachHandler.java

ViolationLine
Unnecessary final modifier in final class321 - 328
Unnecessary final modifier in final class330 - 337
Unnecessary final modifier in final class339 - 346
Unnecessary final modifier in final class348 - 355
Unnecessary final modifier in final class357 - 364
Unnecessary final modifier in final class366 - 381
Unnecessary final modifier in final class383 - 390
Unnecessary final modifier in final class392 - 399
Unnecessary final modifier in final class401 - 423

org/apache/myfaces/view/facelets/tag/jstl/core/IfHandler.java

ViolationLine
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.110

org/apache/myfaces/view/facelets/tag/jstl/core/SetHandler.java

ViolationLine
These nested if statements could be combined140 - 143

org/apache/myfaces/view/facelets/tag/jstl/fn/JstlFunction.java

ViolationLine
Avoid empty if statements109 - 111

org/apache/myfaces/view/facelets/tag/ui/ParamHandler.java

ViolationLine
These nested if statements could be combined97 - 101

org/apache/myfaces/view/facelets/tag/ui/RepeatHandler.java

ViolationLine
Avoid empty catch blocks90 - 93

org/apache/myfaces/view/facelets/util/Classpath.java

ViolationLine
Avoid empty catch blocks218 - 220
Avoid empty catch blocks351 - 354
Avoid empty catch blocks381 - 385

org/apache/myfaces/view/facelets/util/FastWriter.java

ViolationLine
Unnecessary final modifier in final class58 - 66

org/apache/myfaces/view/facelets/util/ParameterCheck.java

ViolationLine
Unnecessary final modifier in final class28 - 34

org/apache/myfaces/view/facelets/util/Path.java

ViolationLine
Unnecessary final modifier in final class28 - 67
Unnecessary final modifier in final class69 - 95
Unnecessary final modifier in final class97 - 105

org/apache/myfaces/view/facelets/util/Resource.java

ViolationLine
These nested if statements could be combined78 - 81
Avoid empty catch blocks107 - 111

org/apache/myfaces/webapp/AbstractFacesInitializer.java

ViolationLine
Avoid unused method parameters such as 'servletContext'.282 - 287

org/apache/myfaces/webapp/Jsp21FacesInitializer.java

ViolationLine
An empty statement (semicolon) not part of a loop88

org/apache/myfaces/webapp/StartupServletContextListener.java

ViolationLine
Avoid empty catch blocks227 - 230
These nested if statements could be combined304 - 307