FindBugs Bug Detector Report
The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is low
Effort is min
Files
org.apache.myfaces.application.ActionListenerImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of cause, which is known to be non-null in org.apache.myfaces.application.ActionListenerImpl.processAction(ActionEvent) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 93 | Low |
org.apache.myfaces.application.ApplicationImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true in org.apache.myfaces.application.ApplicationImpl.addDefaultValidatorId(String), since all Class are instances of Class | STYLE | BC_VACUOUS_INSTANCEOF | 304 | Medium |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 273 | Low |
| Synchronization performed on java.util.concurrent.ConcurrentHashMap in org.apache.myfaces.application.ApplicationImpl.subscribeToEvent(Class, Class, SystemEventListener) | MT_CORRECTNESS | JLM_JSR166_UTILCONCURRENT_MONITORENTER | 971 | Medium |
| converterClass could be null and is guaranteed to be dereferenced in org.apache.myfaces.application.ApplicationImpl.internalCreateConverter(Class) | CORRECTNESS | NP_GUARANTEED_DEREF | 1581 | High |
| Load of known null value in org.apache.myfaces.application.ApplicationImpl.publishEvent(FacesContext, Class, Class, Object) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 574 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.application.ApplicationImpl.internalCreateConverter(Class) | STYLE | REC_CATCH_EXCEPTION | 1568 | Medium |
| Exception is caught when Exception is not thrown in org.apache.myfaces.application.ApplicationImpl._createEvent(Class, Object, SystemEvent) | STYLE | REC_CATCH_EXCEPTION | 1994 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.application.ApplicationImpl.createBehavior(String) | STYLE | REC_CATCH_EXCEPTION | 1193 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.application.ApplicationImpl.internalCreateConverter(Class) | STYLE | REC_CATCH_EXCEPTION | 1588 | Low |
org.apache.myfaces.application.ApplicationImpl$SystemListenerEntry
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.myfaces.application.ApplicationImpl$SystemListenerEntry._lstSystemEventListener; locked 42% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 2559 | Medium |
| Inconsistent synchronization of org.apache.myfaces.application.ApplicationImpl$SystemListenerEntry._sourceClassMap; locked 40% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 2554 | Medium |
org.apache.myfaces.application.DefaultResourceHandlerSupport
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.application.DefaultResourceHandlerSupport.getResourceLoaders() may expose internal representation by returning DefaultResourceHandlerSupport._resourceLoaders | MALICIOUS_CODE | EI_EXPOSE_REP | 81 | Medium |
org.apache.myfaces.application.NavigationHandlerImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.application.NavigationHandlerImpl.convertNavigationCasesToAPI(NavigationRule) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 769 | Medium |
| integral division result cast to double or float in org.apache.myfaces.application.NavigationHandlerImpl.getOutcomeNavigationCase(FacesContext, String, String) | STYLE | ICAST_IDIV_CAST_TO_DOUBLE | 428 | Medium |
| Inconsistent synchronization of org.apache.myfaces.application.NavigationHandlerImpl._navigationCases; locked 40% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 683 | Medium |
| Inconsistent synchronization of org.apache.myfaces.application.NavigationHandlerImpl._wildcardKeys; locked 50% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 673 | Low |
org.apache.myfaces.application.NavigationHandlerImpl$KeyComparator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.application.NavigationHandlerImpl$KeyComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 748-752 | Medium |
org.apache.myfaces.application.ResourceHandlerImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of resourceBasePath, which is known to be non-null in org.apache.myfaces.application.ResourceHandlerImpl.handleResourceRequest(FacesContext) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 327 | Low |
org.apache.myfaces.application.StateManagerImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to externalContext in org.apache.myfaces.application.StateManagerImpl.saveView(FacesContext) | STYLE | DLS_DEAD_LOCAL_STORE | 227 | Medium |
org.apache.myfaces.application.jsp.JspStateManagerImpl$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.application.jsp.JspStateManagerImpl$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 883-886 | Low |
org.apache.myfaces.application.jsp.JspStateManagerImpl$SerializedViewCollection
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.application.jsp.JspStateManagerImpl$SerializedViewCollection defines non-transient non-serializable instance field _keys | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.application.jsp.JspStateManagerImpl$SerializedViewCollection defines non-transient non-serializable instance field _serializedViews | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| The field org.apache.myfaces.application.jsp.JspStateManagerImpl$SerializedViewCollection._oldSerializedViews is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Not available | Low |
org.apache.myfaces.application.jsp.ServletViewResponseWrapper
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.application.jsp.ServletViewResponseWrapper.toString() may return null | BAD_PRACTICE | NP_TOSTRING_COULD_RETURN_NULL | 168 | Medium |
org.apache.myfaces.config.DefaultFacesConfigurationMerger$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.config.DefaultFacesConfigurationMerger$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 812-855 | Low |
org.apache.myfaces.config.FacesConfigValidator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in org.apache.myfaces.config.FacesConfigValidator.validateNavRule(NavigationRule, List, ExternalContext) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 108 | Medium |
org.apache.myfaces.config.FacesConfigurator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 624 | Low |
| Write to static field org.apache.myfaces.config.FacesConfigurator.lastUpdate from instance method org.apache.myfaces.config.FacesConfigurator.configure() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 429 | Medium |
org.apache.myfaces.config.ManagedBeanBuilder
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Switch statement found in org.apache.myfaces.config.ManagedBeanBuilder.initializeProperties(FacesContext, ManagedBean, Object) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 321-325 | Low |
org.apache.myfaces.config.ManagedBeanDestroyer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.config.ManagedBeanDestroyer.processEvent(SystemEvent) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 107 | Medium |
org.apache.myfaces.config.NamedEventManager
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 123 | Low |
org.apache.myfaces.config.annotation.DefaultAnnotationProvider
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.config.annotation.DefaultAnnotationProvider.getAnnotatedMetaInfClasses(ExternalContext, Set) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 224-244 | High |
| org.apache.myfaces.config.annotation.DefaultAnnotationProvider.getBaseUrls() is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 202-219 | High |
| org.apache.myfaces.config.annotation.DefaultAnnotationProvider.getBaseUrls() is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 216 | High |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 312 | Low |
org.apache.myfaces.config.annotation.NoInjectionAnnotationLifecycleProvider
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The parameter metadata to org.apache.myfaces.config.annotation.NoInjectionAnnotationLifecycleProvider.createDeclaredMethodBeansMap(ClassLoader, Map) is dead upon entry but overwritten | CORRECTNESS | IP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN | 76 | Low |
| Load of known null value in org.apache.myfaces.config.annotation.NoInjectionAnnotationLifecycleProvider.getDeclaredMethodBeansMap() | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 66 | Medium |
| Redundant nullcheck of methods, which is known to be non-null in org.apache.myfaces.config.annotation.NoInjectionAnnotationLifecycleProvider.postConstruct(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 121 | Low |
org.apache.myfaces.config.annotation.ResourceAnnotationLifecycleProvider
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.config.annotation.ResourceAnnotationLifecycleProvider.lookupFieldResource(Context, Object, Field, String) invokes reflect.Field.setAccessible(boolean), which should be invoked from within a doPrivileged block | BAD_PRACTICE | DP_DO_INSIDE_DO_PRIVILEGED | 193 | Low |
| org.apache.myfaces.config.annotation.ResourceAnnotationLifecycleProvider.lookupMethodResource(Context, Object, Method, String) invokes reflect.Method.setAccessible(boolean), which should be invoked from within a doPrivileged block | BAD_PRACTICE | DP_DO_INSIDE_DO_PRIVILEGED | 229 | Low |
| The parameter metadata to org.apache.myfaces.config.annotation.ResourceAnnotationLifecycleProvider.createDeclaredFieldBeansMap(ClassLoader, Map) is dead upon entry but overwritten | CORRECTNESS | IP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN | 77 | Low |
| Load of known null value in org.apache.myfaces.config.annotation.ResourceAnnotationLifecycleProvider.getDeclaredFieldBeansMap() | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 67 | Medium |
org.apache.myfaces.config.annotation._ClassByteCodeAnnotationFilter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.config.annotation._ClassByteCodeAnnotationFilter.couldContainAnnotationsOnClassDef(DataInput, Set) uses the same code for two switch clauses | STYLE | DB_DUPLICATE_SWITCH_CLAUSES | 139-140 | Low |
| Method org.apache.myfaces.config.annotation._ClassByteCodeAnnotationFilter.couldContainAnnotationsOnClassDef(DataInput, Set) uses the same code for two switch clauses | STYLE | DB_DUPLICATE_SWITCH_CLAUSES | 146-148 | Low |
| Dead store to minorVersion in org.apache.myfaces.config.annotation._ClassByteCodeAnnotationFilter.couldContainAnnotationsOnClassDef(DataInput, Set) | STYLE | DLS_DEAD_LOCAL_STORE | 102 | Medium |
org.apache.myfaces.config.annotation._PackageInfo
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 160 | Low |
org.apache.myfaces.config.annotation._PackageInfo$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 261 | Low |
org.apache.myfaces.config.impl.FacesConfigEntityResolver
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method call in org.apache.myfaces.config.impl.FacesConfigEntityResolver.resolveEntity(String, String) passes null for nonnull parameter of java.util.jar.JarFile.getInputStream(ZipEntry) | CORRECTNESS | NP_NULL_PARAM_DEREF | 91 | High |
org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The field name org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl.ViewDeclarationLanguageFactories doesn't start with a lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field ViewDeclarationLanguageFactories | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field actionListeners | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field applicationFactories | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field behaviors | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field components | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field converterByClass | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field converterById | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field converterConfigurationByClassName | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field defaultAnnotatedValidatorIds | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field defaultValidatorIds | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field elResolvers | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field exceptionHandlerFactories | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field externalContextFactories | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field faceletCacheFactories | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field facesContextFactories | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field lifecycleFactories | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field lifecyclePhaseListeners | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field managedBeans | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field namedEvents | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field navigationHandlers | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field navigationRules | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field partialViewContextFactories | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field propertyResolver | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field renderKitFactories | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field renderKits | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field resourceBundles | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field resourceHandlers | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field stateManagers | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field systemEventListeners | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field tagHandlerDelegateFactories | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field validators | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field variableResolver | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field viewHandlers | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.DigesterFacesConfigDispenserImpl defines non-transient non-serializable instance field visitContextFactories | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
org.apache.myfaces.config.impl.digester.elements.AbsoluteOrdering
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.config.impl.digester.elements.AbsoluteOrdering defines non-transient non-serializable instance field orderList | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| org.apache.myfaces.config.impl.digester.elements.AbsoluteOrdering is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 25-37 | Low |
org.apache.myfaces.config.impl.digester.elements.Application
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.config.impl.digester.elements.Application defines non-transient non-serializable instance field actionListener | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Application defines non-transient non-serializable instance field defaultRenderkitId | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Application defines non-transient non-serializable instance field defaultValidatorIds | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Application defines non-transient non-serializable instance field elResolver | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Application defines non-transient non-serializable instance field localeConfig | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Application defines non-transient non-serializable instance field messageBundle | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Application defines non-transient non-serializable instance field navigationHandler | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Application defines non-transient non-serializable instance field partialTraversal | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Application defines non-transient non-serializable instance field propertyResolver | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Application defines non-transient non-serializable instance field resourceBundle | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Application defines non-transient non-serializable instance field resourceHandler | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Application defines non-transient non-serializable instance field stateManager | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Application defines non-transient non-serializable instance field systemEventListeners | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Application defines non-transient non-serializable instance field variableResolver | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Application defines non-transient non-serializable instance field viewHandler | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| org.apache.myfaces.config.impl.digester.elements.Application is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 28-206 | Low |
org.apache.myfaces.config.impl.digester.elements.Attribute
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.config.impl.digester.elements.Attribute defines non-transient non-serializable instance field _attributeExtension | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Attribute defines non-transient non-serializable instance field _description | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Attribute defines non-transient non-serializable instance field _displayName | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Attribute defines non-transient non-serializable instance field _icon | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| org.apache.myfaces.config.impl.digester.elements.Attribute is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 41-170 | Low |
org.apache.myfaces.config.impl.digester.elements.Behavior
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.config.impl.digester.elements.Behavior defines non-transient non-serializable instance field attributes | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Behavior defines non-transient non-serializable instance field properties | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| org.apache.myfaces.config.impl.digester.elements.Behavior is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 29-77 | Low |
org.apache.myfaces.config.impl.digester.elements.ClientBehaviorRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.config.impl.digester.elements.ClientBehaviorRenderer is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 27-50 | Low |
org.apache.myfaces.config.impl.digester.elements.Component
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.config.impl.digester.elements.Component is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 27-54 | Low |
org.apache.myfaces.config.impl.digester.elements.ConfigOthersSlot
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.config.impl.digester.elements.ConfigOthersSlot is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 23 | Low |
org.apache.myfaces.config.impl.digester.elements.Converter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.config.impl.digester.elements.Converter defines non-transient non-serializable instance field _attributes | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Converter defines non-transient non-serializable instance field _properties | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| org.apache.myfaces.config.impl.digester.elements.Converter is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 31-113 | Low |
org.apache.myfaces.config.impl.digester.elements.FacesConfig
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.config.impl.digester.elements.FacesConfig defines non-transient non-serializable instance field applications | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.FacesConfig defines non-transient non-serializable instance field behaviors | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.FacesConfig defines non-transient non-serializable instance field components | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.FacesConfig defines non-transient non-serializable instance field converters | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.FacesConfig defines non-transient non-serializable instance field factories | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.FacesConfig defines non-transient non-serializable instance field lifecyclePhaseListener | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.FacesConfig defines non-transient non-serializable instance field managedBeans | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.FacesConfig defines non-transient non-serializable instance field namedEvents | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.FacesConfig defines non-transient non-serializable instance field navigationRules | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.FacesConfig defines non-transient non-serializable instance field renderKits | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.FacesConfig defines non-transient non-serializable instance field validators | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| org.apache.myfaces.config.impl.digester.elements.FacesConfig is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 30-228 | Low |
org.apache.myfaces.config.impl.digester.elements.FacesConfigNameSlot
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.config.impl.digester.elements.FacesConfigNameSlot is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 23-35 | Low |
org.apache.myfaces.config.impl.digester.elements.Factory
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The field name org.apache.myfaces.config.impl.digester.elements.Factory.ViewDeclarationLanguageFactories doesn't start with a lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Factory defines non-transient non-serializable instance field ViewDeclarationLanguageFactories | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Factory defines non-transient non-serializable instance field applicationFactories | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Factory defines non-transient non-serializable instance field exceptionHandlerFactories | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Factory defines non-transient non-serializable instance field externalContextFactories | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Factory defines non-transient non-serializable instance field facesContextFactories | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Factory defines non-transient non-serializable instance field lifecycleFactories | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Factory defines non-transient non-serializable instance field partialViewContextFactories | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Factory defines non-transient non-serializable instance field renderKitFactories | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Factory defines non-transient non-serializable instance field tagHandlerDelegateFactories | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Factory defines non-transient non-serializable instance field visitContextFactories | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| org.apache.myfaces.config.impl.digester.elements.Factory is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 28-138 | Low |
org.apache.myfaces.config.impl.digester.elements.ListEntries
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.config.impl.digester.elements.ListEntries defines non-transient non-serializable instance field entries | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| org.apache.myfaces.config.impl.digester.elements.ListEntries is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 30-62 | Low |
org.apache.myfaces.config.impl.digester.elements.ListEntries$Entry
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.config.impl.digester.elements.ListEntries$Entry is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 62-88 | Low |
org.apache.myfaces.config.impl.digester.elements.LocaleConfig
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.config.impl.digester.elements.LocaleConfig defines non-transient non-serializable instance field supportedLocales | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| org.apache.myfaces.config.impl.digester.elements.LocaleConfig is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 29-56 | Low |
org.apache.myfaces.config.impl.digester.elements.ManagedBean
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.config.impl.digester.elements.ManagedBean defines non-transient non-serializable instance field property | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| org.apache.myfaces.config.impl.digester.elements.ManagedBean is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 36-191 | Low |
org.apache.myfaces.config.impl.digester.elements.ManagedProperty
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.config.impl.digester.elements.ManagedProperty defines non-transient non-serializable instance field _valueBinding | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| org.apache.myfaces.config.impl.digester.elements.ManagedProperty is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 36-141 | Low |
org.apache.myfaces.config.impl.digester.elements.MapEntries
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.config.impl.digester.elements.MapEntries defines non-transient non-serializable instance field entries | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| org.apache.myfaces.config.impl.digester.elements.MapEntries is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 30-72 | Low |
org.apache.myfaces.config.impl.digester.elements.MapEntries$Entry
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.config.impl.digester.elements.MapEntries$Entry is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 72-111 | Low |
org.apache.myfaces.config.impl.digester.elements.NamedEvent
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.config.impl.digester.elements.NamedEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 30-51 | Low |
org.apache.myfaces.config.impl.digester.elements.NavigationCase
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.config.impl.digester.elements.NavigationCase is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 30-93 | Low |
org.apache.myfaces.config.impl.digester.elements.NavigationRule
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.config.impl.digester.elements.NavigationRule defines non-transient non-serializable instance field navigationCases | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| org.apache.myfaces.config.impl.digester.elements.NavigationRule is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 32-59 | Low |
org.apache.myfaces.config.impl.digester.elements.OrderSlot
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.config.impl.digester.elements.OrderSlot is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 23 | Low |
org.apache.myfaces.config.impl.digester.elements.Ordering
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.config.impl.digester.elements.Ordering defines non-transient non-serializable instance field afterList | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Ordering defines non-transient non-serializable instance field beforeList | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| org.apache.myfaces.config.impl.digester.elements.Ordering is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 25-48 | Low |
org.apache.myfaces.config.impl.digester.elements.Property
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.config.impl.digester.elements.Property defines non-transient non-serializable instance field _description | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Property defines non-transient non-serializable instance field _displayName | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Property defines non-transient non-serializable instance field _icon | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.Property defines non-transient non-serializable instance field _propertyExtension | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| org.apache.myfaces.config.impl.digester.elements.Property is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 43-170 | Low |
org.apache.myfaces.config.impl.digester.elements.Redirect
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.config.impl.digester.elements.Redirect defines non-transient non-serializable instance field viewParams | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| org.apache.myfaces.config.impl.digester.elements.Redirect is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 30-60 | Low |
org.apache.myfaces.config.impl.digester.elements.RenderKit
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.config.impl.digester.elements.RenderKit defines non-transient non-serializable instance field clientBehaviorRenderers | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.RenderKit defines non-transient non-serializable instance field renderKitClasses | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.config.impl.digester.elements.RenderKit defines non-transient non-serializable instance field renderer | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| org.apache.myfaces.config.impl.digester.elements.RenderKit is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 28-81 | Low |
org.apache.myfaces.config.impl.digester.elements.Renderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.config.impl.digester.elements.Renderer is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 27-68 | Low |
org.apache.myfaces.config.impl.digester.elements.ResourceBundle
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.config.impl.digester.elements.ResourceBundle is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 27-73 | Low |
org.apache.myfaces.config.impl.digester.elements.SystemEventListener
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.config.impl.digester.elements.SystemEventListener is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 24-57 | Low |
org.apache.myfaces.config.impl.digester.elements.ViewParam
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.config.impl.digester.elements.ViewParam is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 24-47 | Low |
org.apache.myfaces.config.util.Vertex
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.config.util.Vertex defines compareTo(Vertex) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 188-201 | Medium |
org.apache.myfaces.context.FacesContextFactoryImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.apache.myfaces.context.FacesContextFactoryImpl() invokes reflect.Field.setAccessible(boolean), which should be invoked from within a doPrivileged block | BAD_PRACTICE | DP_DO_INSIDE_DO_PRIVILEGED | 86 | Low |
| Redundant nullcheck of firstExternalContextInstance which is known to be null in new org.apache.myfaces.context.FacesContextFactoryImpl() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 90 | Low |
org.apache.myfaces.context.MyFacesExceptionHandlerWrapperImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.event.SystemEvent to javax.faces.event.ExceptionQueuedEvent in org.apache.myfaces.context.MyFacesExceptionHandlerWrapperImpl.processEvent(SystemEvent) | STYLE | BC_UNCONFIRMED_CAST | 329 | Low |
org.apache.myfaces.context.PartialResponseWriterImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to elem in org.apache.myfaces.context.PartialResponseWriterImpl.popAndEncodeCurrentStackEntry() | STYLE | DLS_DEAD_LOCAL_STORE | 194 | Medium |
org.apache.myfaces.context.PartialResponseWriterImpl$StackEntry
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.context.PartialResponseWriterImpl$StackEntry be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 80-103 | Medium |
org.apache.myfaces.context.servlet.FacesContextImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of org.apache.myfaces.context.servlet.FacesContextImpl._facesContextFactory which is known to be null in org.apache.myfaces.context.servlet.FacesContextImpl.release() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 147 | Medium |
org.apache.myfaces.context.servlet.PartialViewContextImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to grandchild in org.apache.myfaces.context.servlet.PartialViewContextImpl.findBodyComponent(UIViewRoot) | STYLE | DLS_DEAD_LOCAL_STORE | 691 | Low |
| Dead store to grandchild in org.apache.myfaces.context.servlet.PartialViewContextImpl.findHeadComponent(UIViewRoot) | STYLE | DLS_DEAD_LOCAL_STORE | 669 | Low |
| Redundant nullcheck of updatedComponents which is known to be null in org.apache.myfaces.context.servlet.PartialViewContextImpl.processPartialRendering(UIViewRoot, PhaseId) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 499 | Low |
org.apache.myfaces.context.servlet.PartialViewContextImpl$PhaseAwareVisitCallback
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.context.servlet.PartialViewContextImpl$PhaseAwareVisitCallback be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 720-817 | Medium |
org.apache.myfaces.context.servlet.ServletExternalContextImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.servlet.ServletRequest to javax.servlet.http.HttpServletRequest in new org.apache.myfaces.context.servlet.ServletExternalContextImpl(ServletContext, ServletRequest, ServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 100 | Low |
| Unchecked/unconfirmed cast from javax.servlet.ServletResponse to javax.servlet.http.HttpServletResponse in new org.apache.myfaces.context.servlet.ServletExternalContextImpl(ServletContext, ServletRequest, ServletResponse) | STYLE | BC_UNCONFIRMED_CAST | 101 | Low |
org.apache.myfaces.el.CompositeELResolver
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.myfaces.el.CompositeELResolver._elResolvers; locked 75% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 42 | Low |
org.apache.myfaces.el.ResolverForJSPInitializer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.el.ResolverForJSPInitializer defines non-transient non-serializable instance field _resolverForJSP | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
org.apache.myfaces.el.convert.ValueBindingToValueExpression
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.el.convert.ValueBindingToValueExpression defines non-transient non-serializable instance field _valueBinding | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
org.apache.myfaces.el.unified.CustomFirstELResolverComparator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.el.unified.CustomFirstELResolverComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 39-101 | Low |
org.apache.myfaces.el.unified.CustomLastELResolverComparator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.el.unified.CustomLastELResolverComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 34-42 | Low |
org.apache.myfaces.el.unified.OpenWebBeansELResolverComparator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.el.unified.OpenWebBeansELResolverComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 33-48 | Medium |
org.apache.myfaces.el.unified.ResolverBuilderBase
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of facesContext, which is known to be non-null in org.apache.myfaces.el.unified.ResolverBuilderBase.addFromRuntimeConfig(List) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 106 | Low |
org.apache.myfaces.el.unified.resolver.CompositeComponentELResolver$CompositeComponentAttributesMapWrapper
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.el.unified.resolver.CompositeComponentELResolver$CompositeComponentAttributesMapWrapper be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 270-400 | Medium |
| Method org.apache.myfaces.el.unified.resolver.CompositeComponentELResolver$CompositeComponentAttributesMapWrapper.putAll(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 384 | Medium |
org.apache.myfaces.lifecycle.DefaultRestoreViewSupport
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of viewId, which is known to be non-null in org.apache.myfaces.lifecycle.DefaultRestoreViewSupport.deriveViewId(FacesContext, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 264 | Low |
org.apache.myfaces.lifecycle.RenderResponseExecutor
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Comparison of String objects using == or != in org.apache.myfaces.lifecycle.RenderResponseExecutor.execute(FacesContext) | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 96 | Low |
| Load of known null value in org.apache.myfaces.lifecycle.RenderResponseExecutor.execute(FacesContext) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 96 | Medium |
org.apache.myfaces.logging.MyfacesLogMessage
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.logging.MyfacesLogMessage is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 29-42 | Low |
org.apache.myfaces.renderkit.ErrorPageWriter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.renderkit.ErrorPageWriter._writeVariables(Writer, Map, String) invokes toString() method on a String | PERFORMANCE | DM_STRING_TOSTRING | 792 | Low |
| Incorrect lazy initialization of static field org.apache.myfaces.renderkit.ErrorPageWriter.debugParts in org.apache.myfaces.renderkit.ErrorPageWriter._init(FacesContext) | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 624-626 | Low |
| Incorrect lazy initialization of static field org.apache.myfaces.renderkit.ErrorPageWriter.errorParts in org.apache.myfaces.renderkit.ErrorPageWriter._init(FacesContext) | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 619-621 | Low |
| org.apache.myfaces.renderkit.ErrorPageWriter.handleThrowable(FacesContext, Throwable) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 537 | Medium |
| Exception is caught when Exception is not thrown in org.apache.myfaces.renderkit.ErrorPageWriter._writeAttributes(Writer, UIComponent, boolean) | STYLE | REC_CATCH_EXCEPTION | 1319 | High |
| Exception is caught when Exception is not thrown in org.apache.myfaces.renderkit.ErrorPageWriter._initCauseIfAvailable(Throwable, Throwable) | STYLE | REC_CATCH_EXCEPTION | 1413 | Medium |
| Exception is caught when Exception is not thrown in org.apache.myfaces.renderkit.ErrorPageWriter._initCausePerReflection(Throwable, String) | STYLE | REC_CATCH_EXCEPTION | 1394 | Medium |
| Exception is caught when Exception is not thrown in org.apache.myfaces.renderkit.ErrorPageWriter._writeAttributes(Writer, UIComponent, boolean) | STYLE | REC_CATCH_EXCEPTION | 1299 | Medium |
| Exception is caught when Exception is not thrown in org.apache.myfaces.renderkit.ErrorPageWriter._writeAttributes(Writer, UIComponent, boolean) | STYLE | REC_CATCH_EXCEPTION | 1299 | Low |
org.apache.myfaces.renderkit.ErrorPageWriter$ErrorPageBean
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.myfaces.renderkit.ErrorPageWriter$ErrorPageBean.getErrorPageHtml() | STYLE | REC_CATCH_EXCEPTION | 157 | Low |
org.apache.myfaces.renderkit.ErrorPageWriter$ExtendedComponentTreeVisitCallback
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.renderkit.ErrorPageWriter$ExtendedComponentTreeVisitCallback.visit(VisitContext, UIComponent) invokes reflect.Method.setAccessible(boolean), which should be invoked from within a doPrivileged block | BAD_PRACTICE | DP_DO_INSIDE_DO_PRIVILEGED | 1000 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.renderkit.ErrorPageWriter$ExtendedComponentTreeVisitCallback.visit(VisitContext, UIComponent) | STYLE | REC_CATCH_EXCEPTION | 1003 | Medium |
org.apache.myfaces.renderkit.ServerSideStateCacheImpl$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.renderkit.ServerSideStateCacheImpl$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 486-490 | Low |
org.apache.myfaces.renderkit.ServerSideStateCacheImpl$SerializedViewCollection
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.renderkit.ServerSideStateCacheImpl$SerializedViewCollection defines non-transient non-serializable instance field _keys | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.renderkit.ServerSideStateCacheImpl$SerializedViewCollection defines non-transient non-serializable instance field _precedence | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.renderkit.ServerSideStateCacheImpl$SerializedViewCollection defines non-transient non-serializable instance field _serializedViews | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| The field org.apache.myfaces.renderkit.ServerSideStateCacheImpl$SerializedViewCollection._oldSerializedViews is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Not available | Low |
org.apache.myfaces.renderkit.html.HtmlAjaxBehaviorRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.behavior.ClientBehavior to javax.faces.component.behavior.AjaxBehavior in org.apache.myfaces.renderkit.html.HtmlAjaxBehaviorRenderer.decode(FacesContext, UIComponent, ClientBehavior) | STYLE | BC_UNCONFIRMED_CAST | 80 | Low |
| Unchecked/unconfirmed cast from javax.faces.component.behavior.ClientBehavior to javax.faces.component.behavior.AjaxBehavior in org.apache.myfaces.renderkit.html.HtmlAjaxBehaviorRenderer.getScript(ClientBehaviorContext, ClientBehavior) | STYLE | BC_UNCONFIRMED_CAST | 94 | Low |
| Method org.apache.myfaces.renderkit.html.HtmlAjaxBehaviorRenderer.makeAjax(ClientBehaviorContext, AjaxBehavior) invokes toString() method on a String | PERFORMANCE | DM_STRING_TOSTRING | 215 | Low |
org.apache.myfaces.renderkit.html.HtmlHiddenRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIOutput in org.apache.myfaces.renderkit.html.HtmlHiddenRenderer.getConvertedValue(FacesContext, UIComponent, Object) | STYLE | BC_UNCONFIRMED_CAST | 74 | Low |
org.apache.myfaces.renderkit.html.HtmlRenderKitImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Private method org.apache.myfaces.renderkit.html.HtmlRenderKitImpl.checkNull(Object, String) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 337-341 | Low |
org.apache.myfaces.renderkit.html.HtmlResponseStateManager
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in org.apache.myfaces.renderkit.html.HtmlResponseStateManager.getSavedState(FacesContext) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 265 | Medium |
| Should org.apache.myfaces.renderkit.html.HtmlResponseStateManager.getSavedState(FacesContext) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 244 | Low |
org.apache.myfaces.renderkit.html.HtmlScriptRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in org.apache.myfaces.renderkit.html.HtmlScriptRenderer.encodeEnd(FacesContext, UIComponent) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 228 | Medium |
| Repeated conditional test in org.apache.myfaces.renderkit.html.HtmlScriptRenderer.processEvent(ComponentSystemEvent) | CORRECTNESS | RpC_REPEATED_CONDITIONAL_TEST | 101 | Low |
org.apache.myfaces.renderkit.html.HtmlStylesheetRenderer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in org.apache.myfaces.renderkit.html.HtmlStylesheetRenderer.encodeEnd(FacesContext, UIComponent) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 195 | Medium |
| Repeated conditional test in org.apache.myfaces.renderkit.html.HtmlStylesheetRenderer.processEvent(ComponentSystemEvent) | CORRECTNESS | RpC_REPEATED_CONDITIONAL_TEST | 100 | Low |
org.apache.myfaces.shared_impl.webapp.webxml.WebXmlParser
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.myfaces.shared_impl.webapp.webxml.WebXmlParser.parse() | STYLE | REC_CATCH_EXCEPTION | 114 | Low |
org.apache.myfaces.spi.AnnotationProvider
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.spi.AnnotationProvider.getBaseUrls() is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | Not available | High |
org.apache.myfaces.spi.AnnotationProviderWrapper
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.spi.AnnotationProviderWrapper.getBaseUrls() is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 53 | High |
org.apache.myfaces.spi.FactoryFinderProviderFactory
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.spi.FactoryFinderProviderFactory.setInstance(FactoryFinderProviderFactory) invokes reflect.Field.setAccessible(boolean), which should be invoked from within a doPrivileged block | BAD_PRACTICE | DP_DO_INSIDE_DO_PRIVILEGED | 152 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.spi.FactoryFinderProviderFactory.setInstance(FactoryFinderProviderFactory) | STYLE | REC_CATCH_EXCEPTION | 172 | Low |
org.apache.myfaces.spi.impl.DefaultServiceProviderFinder
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.spi.impl.DefaultServiceProviderFinder.getURLs(String) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 50-70 | High |
org.apache.myfaces.taglib.core.ConverterImplTag
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.myfaces.taglib.core.ConverterImplTag.createClassicConverter() | STYLE | REC_CATCH_EXCEPTION | 153 | Low |
org.apache.myfaces.taglib.core.ConverterTag
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.myfaces.taglib.core.ConverterTag.createConverter() | STYLE | REC_CATCH_EXCEPTION | 124 | Low |
org.apache.myfaces.taglib.core.DelegateConverter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.myfaces.taglib.core.DelegateConverter._createConverter() | STYLE | REC_CATCH_EXCEPTION | 155 | Low |
org.apache.myfaces.taglib.core.DelegateValidator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.myfaces.taglib.core.DelegateValidator._createValidator() | STYLE | REC_CATCH_EXCEPTION | 132 | Low |
org.apache.myfaces.taglib.core.DelegateValueChangeListener
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in org.apache.myfaces.taglib.core.DelegateValueChangeListener._createValueChangeListener() | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 137 | Low |
org.apache.myfaces.taglib.core.LoadBundleTag$BundleMap
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of java.util.ResourceBundle.getObject(String), which is known to be non-null in org.apache.myfaces.taglib.core.LoadBundleTag$BundleMap.containsKey(Object) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 186 | Low |
org.apache.myfaces.taglib.core.PhaseListenerTag
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.taglib.core.PhaseListenerTag is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 48-144 | Low |
org.apache.myfaces.taglib.core.SetPropertyActionListenerTag
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.taglib.core.SetPropertyActionListenerTag is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 41-130 | Low |
org.apache.myfaces.taglib.core.ValidatorImplTag
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.myfaces.taglib.core.ValidatorImplTag.createClassicValidator() | STYLE | REC_CATCH_EXCEPTION | 151 | Low |
| org.apache.myfaces.taglib.core.ValidatorImplTag is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 55-164 | Low |
org.apache.myfaces.taglib.core.ValidatorTag
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.myfaces.taglib.core.ValidatorTag.createValidator() | STYLE | REC_CATCH_EXCEPTION | 107 | Low |
| org.apache.myfaces.taglib.core.ValidatorTag is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 36-120 | Low |
org.apache.myfaces.util.DebugUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.util.DebugUtils.printAttribute(PrintStream, String, Object) invokes toString() method on a String | PERFORMANCE | DM_STRING_TOSTRING | 355 | Low |
org.apache.myfaces.util.ExternalSpecifications
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization and update of static field org.apache.myfaces.util.ExternalSpecifications.unifiedELAvailable in org.apache.myfaces.util.ExternalSpecifications.isUnifiedELAvailable() | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | 104-111 | High |
| Incorrect lazy initialization and update of static field org.apache.myfaces.util.ExternalSpecifications.beanValidationAvailable in org.apache.myfaces.util.ExternalSpecifications.isBeanValidationAvailable() | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | 55-61 | Medium |
org.apache.myfaces.view.ViewDeclarationLanguageFactoryImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 144 | Low |
| org.apache.myfaces.view.ViewDeclarationLanguageFactoryImpl._supportedLanguages is a volatile reference to an array; the array elements are non-volatile | MT_CORRECTNESS | VO_VOLATILE_REFERENCE_TO_ARRAY | Not available | Low |
org.apache.myfaces.view.facelets.DefaultFaceletsStateManagementHelper$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.view.facelets.DefaultFaceletsStateManagementHelper$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 376-379 | Low |
org.apache.myfaces.view.facelets.DefaultFaceletsStateManagementHelper$SerializedViewCollection
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.view.facelets.DefaultFaceletsStateManagementHelper$SerializedViewCollection defines non-transient non-serializable instance field _keys | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.view.facelets.DefaultFaceletsStateManagementHelper$SerializedViewCollection defines non-transient non-serializable instance field _serializedViews | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| The field org.apache.myfaces.view.facelets.DefaultFaceletsStateManagementHelper$SerializedViewCollection._oldSerializedViews is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Not available | Low |
org.apache.myfaces.view.facelets.DefaultFaceletsStateManagementStrategy
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to externalContext in org.apache.myfaces.view.facelets.DefaultFaceletsStateManagementStrategy.saveView(FacesContext) | STYLE | DLS_DEAD_LOCAL_STORE | 506 | Medium |
| Dead store to viewParameters in org.apache.myfaces.view.facelets.DefaultFaceletsStateManagementStrategy.restoreView(FacesContext, String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 238 | Low |
| Redundant nullcheck of state, which is known to be non-null in org.apache.myfaces.view.facelets.DefaultFaceletsStateManagementStrategy.restoreView(FacesContext, String, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 248 | Low |
org.apache.myfaces.view.facelets.DefaultFaceletsStateManagementStrategy$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.view.facelets.DefaultFaceletsStateManagementStrategy$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 349-376 | Low |
org.apache.myfaces.view.facelets.FaceletViewDeclarationLanguage
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to request in org.apache.myfaces.view.facelets.FaceletViewDeclarationLanguage.getResponseEncoding(FacesContext, String) | STYLE | DLS_DEAD_LOCAL_STORE | 1980 | Medium |
| Exception is caught when Exception is not thrown in org.apache.myfaces.view.facelets.FaceletViewDeclarationLanguage.loadDecorators(FacesContext, Compiler) | STYLE | REC_CATCH_EXCEPTION | 2101 | Low |
org.apache.myfaces.view.facelets.FaceletViewHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.myfaces.view.facelets.FaceletViewHandler.initializeCompiler(Compiler) | STYLE | REC_CATCH_EXCEPTION | 330 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.view.facelets.FaceletViewHandler.renderView(FacesContext, UIViewRoot) | STYLE | REC_CATCH_EXCEPTION | 712 | Low |
org.apache.myfaces.view.facelets.PostBuildComponentTreeOnRestoreViewEvent
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.view.facelets.PostBuildComponentTreeOnRestoreViewEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 44-53 | Low |
org.apache.myfaces.view.facelets.StateWriter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| StateWriter.fast not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available | Low |
org.apache.myfaces.view.facelets.compiler.AddFacesMessageInstruction
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.el.ELContext to org.apache.myfaces.view.facelets.AbstractFaceletContext in org.apache.myfaces.view.facelets.compiler.AddFacesMessageInstruction.apply(ExpressionFactory, ELContext) | STYLE | BC_UNCONFIRMED_CAST | 55 | Low |
org.apache.myfaces.view.facelets.compiler.SAXCompiler$CompilationHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| SAXCompiler$CompilationHandler.locator not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available | Low |
org.apache.myfaces.view.facelets.compiler.SAXCompiler$CompositeComponentMetadataHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| SAXCompiler$CompositeComponentMetadataHandler.locator not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available | Low |
org.apache.myfaces.view.facelets.compiler.SAXCompiler$ViewMetadataHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| SAXCompiler$ViewMetadataHandler.locator not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available | Low |
org.apache.myfaces.view.facelets.compiler.TagLibraryConfig
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.view.facelets.compiler.TagLibraryConfig is final but declares protected field org.apache.myfaces.view.facelets.compiler.TagLibraryConfig.log | STYLE | CI_CONFUSED_INHERITANCE | Not available | Low |
org.apache.myfaces.view.facelets.compiler.TagLibraryConfig$LibraryHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| TagLibraryConfig$LibraryHandler.locator not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available | Low |
org.apache.myfaces.view.facelets.compiler.UILeaf
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.view.facelets.compiler.UILeaf.getFacesListeners(Class) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 517 | Low |
org.apache.myfaces.view.facelets.compiler.UILiteralTextHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.view.facelets.compiler.UILiteralTextHandler is final but declares protected field org.apache.myfaces.view.facelets.compiler.UILiteralTextHandler.txtString | STYLE | CI_CONFUSED_INHERITANCE | Not available | Low |
org.apache.myfaces.view.facelets.compiler._ComponentUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Private method org.apache.myfaces.view.facelets.compiler._ComponentUtils.dynamicIdIsEqual(String, String) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 265 | Low |
org.apache.myfaces.view.facelets.component.UIRepeat$IndexedEvent
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.view.facelets.component.UIRepeat$IndexedEvent is serializable but also an inner class of a non-serializable class | BAD_PRACTICE | SE_BAD_FIELD_INNER_CLASS | 1351-1412 | Low |
| org.apache.myfaces.view.facelets.component.UIRepeat$IndexedEvent is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 1351-1412 | Low |
org.apache.myfaces.view.facelets.el.ContextAwareELException
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.view.facelets.el.DefaultContextAwareELException stored into non-transient field ContextAwareELException._delegate | BAD_PRACTICE | SE_BAD_FIELD_STORE | 49 | Medium |
org.apache.myfaces.view.facelets.el.ContextAwareException
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.view.facelets.el.DefaultContextAwareELException stored into non-transient field ContextAwareException._delegate | BAD_PRACTICE | SE_BAD_FIELD_STORE | 44 | Medium |
org.apache.myfaces.view.facelets.el.ContextAwareMethodNotFoundException
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.view.facelets.el.DefaultContextAwareELException stored into non-transient field ContextAwareMethodNotFoundException._delegate | BAD_PRACTICE | SE_BAD_FIELD_STORE | 49 | Medium |
org.apache.myfaces.view.facelets.el.ContextAwarePropertyNotFoundException
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.view.facelets.el.DefaultContextAwareELException stored into non-transient field ContextAwarePropertyNotFoundException._delegate | BAD_PRACTICE | SE_BAD_FIELD_STORE | 51 | Medium |
org.apache.myfaces.view.facelets.el.ContextAwarePropertyNotWritableException
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.view.facelets.el.DefaultContextAwareELException stored into non-transient field ContextAwarePropertyNotWritableException._delegate | BAD_PRACTICE | SE_BAD_FIELD_STORE | 40 | Medium |
org.apache.myfaces.view.facelets.el.DefaultContextAwareELException
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.view.facelets.el.DefaultContextAwareELException is not derived from an Exception, even though it is named as such | BAD_PRACTICE | NM_CLASS_NOT_EXCEPTION | 28-60 | Medium |
org.apache.myfaces.view.facelets.el.ELText
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.view.facelets.el.ELText.parse(ExpressionFactory, ELContext, String) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 499 | Medium |
org.apache.myfaces.view.facelets.el.ELText$ELCacheableTextVariable
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.el.ELContext to org.apache.myfaces.view.facelets.AbstractFaceletContext in org.apache.myfaces.view.facelets.el.ELText$ELCacheableTextVariable.apply(ExpressionFactory, ELContext) | STYLE | BC_UNCONFIRMED_CAST | 252 | Low |
org.apache.myfaces.view.facelets.el.ELText$LiteralValueExpression
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.view.facelets.el.ELText$LiteralValueExpression.equals(Object) always returns false | CORRECTNESS | EQ_ALWAYS_FALSE | 79 | High |
org.apache.myfaces.view.facelets.impl.DefaultFaceletContext
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.view.facelets.impl.DefaultFaceletContext.generateUniqueId(String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 307 | Medium |
| Bad attempt to compute absolute value of signed 32-bit hashcode in org.apache.myfaces.view.facelets.impl.DefaultFaceletContext.generateUniqueId(String) | CORRECTNESS | RV_ABSOLUTE_VALUE_OF_HASHCODE | 307 | High |
org.apache.myfaces.view.facelets.impl.DefaultFaceletContext$CompositeComponentTemplateManager
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.view.facelets.impl.DefaultFaceletContext$CompositeComponentTemplateManager is final but declares protected field org.apache.myfaces.view.facelets.impl.DefaultFaceletContext$CompositeComponentTemplateManager._target | STYLE | CI_CONFUSED_INHERITANCE | Not available | Low |
| org.apache.myfaces.view.facelets.impl.DefaultFaceletContext$CompositeComponentTemplateManager.equals(Object) is unusual | STYLE | EQ_UNUSUAL | 709 | Medium |
org.apache.myfaces.view.facelets.impl.DefaultFaceletFactory
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.view.facelets.impl.DefaultFaceletFactory is final but declares protected field org.apache.myfaces.view.facelets.impl.DefaultFaceletFactory.log | STYLE | CI_CONFUSED_INHERITANCE | Not available | Low |
| Redundant nullcheck of url, which is known to be non-null in org.apache.myfaces.view.facelets.impl.DefaultFaceletFactory.getCompositeComponentMetadataFacelet(String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 426 | Low |
| Redundant nullcheck of url, which is known to be non-null in org.apache.myfaces.view.facelets.impl.DefaultFaceletFactory.getFacelet(String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 129 | Low |
| Redundant nullcheck of url, which is known to be non-null in org.apache.myfaces.view.facelets.impl.DefaultFaceletFactory.getViewMetadataFacelet(String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 373 | Low |
org.apache.myfaces.view.facelets.impl.SectionUniqueIdCounter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.apache.myfaces.view.facelets.impl.SectionUniqueIdCounter(String, String[]) may expose internal representation by storing an externally mutable object into SectionUniqueIdCounter._uniqueIdsCache | MALICIOUS_CODE | EI_EXPOSE_REP2 | 77 | Medium |
org.apache.myfaces.view.facelets.impl.TemplateContextImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Call to equals() comparing different types in org.apache.myfaces.view.facelets.impl.TemplateContextImpl.includeDefinition(FaceletContext, Facelet, UIComponent, String) | CORRECTNESS | EC_UNRELATED_TYPES | 127 | High |
org.apache.myfaces.view.facelets.impl.TemplateContextImpl$TemplateManagerImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.view.facelets.impl.TemplateContextImpl$TemplateManagerImpl.equals(Object) is unusual | STYLE | EQ_UNUSUAL | 216-222 | Medium |
org.apache.myfaces.view.facelets.tag.CompositeFaceletHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.view.facelets.tag.CompositeFaceletHandler.getHandlers() may expose internal representation by returning CompositeFaceletHandler.children | MALICIOUS_CODE | EI_EXPOSE_REP | 61 | Medium |
| new org.apache.myfaces.view.facelets.tag.CompositeFaceletHandler(FaceletHandler[]) may expose internal representation by storing an externally mutable object into CompositeFaceletHandler.children | MALICIOUS_CODE | EI_EXPOSE_REP2 | 46 | Medium |
org.apache.myfaces.view.facelets.tag.CompositeTagDecorator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.apache.myfaces.view.facelets.tag.CompositeTagDecorator(TagDecorator[]) may expose internal representation by storing an externally mutable object into CompositeTagDecorator.decorators | MALICIOUS_CODE | EI_EXPOSE_REP2 | 41 | Medium |
org.apache.myfaces.view.facelets.tag.CompositeTagLibrary
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.apache.myfaces.view.facelets.tag.CompositeTagLibrary(TagLibrary[]) may expose internal representation by storing an externally mutable object into CompositeTagLibrary.libraries | MALICIOUS_CODE | EI_EXPOSE_REP2 | 44 | Medium |
org.apache.myfaces.view.facelets.tag.MetaRulesetImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The parameter metadata to org.apache.myfaces.view.facelets.tag.MetaRulesetImpl.createMetaData(ClassLoader, Map) is dead upon entry but overwritten | CORRECTNESS | IP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN | 95 | Medium |
| Load of known null value in org.apache.myfaces.view.facelets.tag.MetaRulesetImpl.getMetaData() | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 86 | Medium |
org.apache.myfaces.view.facelets.tag.MetadataImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.apache.myfaces.view.facelets.tag.MetadataImpl(Metadata[]) may expose internal representation by storing an externally mutable object into MetadataImpl._mappers | MALICIOUS_CODE | EI_EXPOSE_REP2 | 36 | Medium |
org.apache.myfaces.view.facelets.tag.MethodRule
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.apache.myfaces.view.facelets.tag.MethodRule(String, Class, Class[]) may expose internal representation by storing an externally mutable object into MethodRule.params | MALICIOUS_CODE | EI_EXPOSE_REP2 | 51 | Medium |
org.apache.myfaces.view.facelets.tag.MethodRule$MethodExpressionMetadata
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.view.facelets.tag.MethodRule$MethodExpressionMetadata be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 83-106 | Medium |
org.apache.myfaces.view.facelets.tag.TagAttributeImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.myfaces.view.facelets.tag.TagAttributeImpl.getMethodExpression(FaceletContext, Class, Class[]) | STYLE | REC_CATCH_EXCEPTION | 291 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.view.facelets.tag.TagAttributeImpl.getValueExpression(FaceletContext, Class) | STYLE | REC_CATCH_EXCEPTION | 493 | Low |
| org.apache.myfaces.view.facelets.tag.TagAttributeImpl.cachedExpression is a volatile reference to an array; the array elements are non-volatile | MT_CORRECTNESS | VO_VOLATILE_REFERENCE_TO_ARRAY | Not available | Low |
org.apache.myfaces.view.facelets.tag.TagAttributesImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.view.facelets.tag.TagAttributesImpl.getAll() may expose internal representation by returning TagAttributesImpl._attributes | MALICIOUS_CODE | EI_EXPOSE_REP | 97 | Medium |
| org.apache.myfaces.view.facelets.tag.TagAttributesImpl.getNamespaces() may expose internal representation by returning TagAttributesImpl._namespaces | MALICIOUS_CODE | EI_EXPOSE_REP | 176 | Medium |
| new org.apache.myfaces.view.facelets.tag.TagAttributesImpl(TagAttribute[]) may expose internal representation by storing an externally mutable object into TagAttributesImpl._attributes | MALICIOUS_CODE | EI_EXPOSE_REP2 | 58 | Medium |
org.apache.myfaces.view.facelets.tag.UserTagHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.view.facelets.tag.UserTagHandler is final but declares protected field org.apache.myfaces.view.facelets.tag.UserTagHandler._handlers | STYLE | CI_CONFUSED_INHERITANCE | Not available | Low |
| Class org.apache.myfaces.view.facelets.tag.UserTagHandler is final but declares protected field org.apache.myfaces.view.facelets.tag.UserTagHandler._location | STYLE | CI_CONFUSED_INHERITANCE | Not available | Low |
| Class org.apache.myfaces.view.facelets.tag.UserTagHandler is final but declares protected field org.apache.myfaces.view.facelets.tag.UserTagHandler._vars | STYLE | CI_CONFUSED_INHERITANCE | Not available | Low |
org.apache.myfaces.view.facelets.tag.composite.ClientBehaviorRedirectEventComponentWrapper
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.view.facelets.tag.composite.ClientBehaviorRedirectEventComponentWrapper.getFacesListeners(Class) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 424 | Low |
org.apache.myfaces.view.facelets.tag.composite.CompositeComponentBeanInfo
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.view.facelets.tag.composite.CompositeComponentBeanInfo.getPropertyDescriptors() may expose internal representation by returning CompositeComponentBeanInfo._propertyDescriptorsArray | MALICIOUS_CODE | EI_EXPOSE_REP | 137 | Medium |
org.apache.myfaces.view.facelets.tag.composite.CompositeComponentRule$LiteralAttributeMetadata
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.view.facelets.tag.composite.CompositeComponentRule$LiteralAttributeMetadata be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 47-57 | Medium |
org.apache.myfaces.view.facelets.tag.composite.CompositeComponentRule$TypedLiteralAttributeMetadata
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.view.facelets.tag.composite.CompositeComponentRule$TypedLiteralAttributeMetadata be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 67-76 | Medium |
org.apache.myfaces.view.facelets.tag.composite.InsertFacetHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to parentCompositeComponent in org.apache.myfaces.view.facelets.tag.composite.InsertFacetHandler.apply(FaceletContext, UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE | 153 | Medium |
| org.apache.myfaces.view.facelets.tag.composite.InsertFacetHandler.INSERT_FACET_KEYS isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 63 | High |
| org.apache.myfaces.view.facelets.tag.composite.InsertFacetHandler.INSERT_FACET_USED isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 57 | High |
org.apache.myfaces.view.facelets.tag.composite.RenderFacetHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.view.facelets.tag.composite.RenderFacetHandler.RENDER_FACET_USED isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 51 | High |
org.apache.myfaces.view.facelets.tag.jsf.ActionSourceRule
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.view.facelets.tag.jsf.ActionSourceRule.ACTION_LISTENER_SIG should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 45 | Medium |
org.apache.myfaces.view.facelets.tag.jsf.BehaviorTagHandlerDelegate
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.behavior.ClientBehaviorHolder in org.apache.myfaces.view.facelets.tag.jsf.BehaviorTagHandlerDelegate.applyAttachedObject(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 151 | Low |
org.apache.myfaces.view.facelets.tag.jsf.ComponentRule$LiteralAttributeMetadata
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.view.facelets.tag.jsf.ComponentRule$LiteralAttributeMetadata be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 45-53 | Medium |
org.apache.myfaces.view.facelets.tag.jsf.ComponentSupport
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 219 | Low |
org.apache.myfaces.view.facelets.tag.jsf.ComponentTagHandlerDelegate
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of parent, which is known to be non-null in org.apache.myfaces.view.facelets.tag.jsf.ComponentTagHandlerDelegate.apply(FaceletContext, UIComponent) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 304 | Low |
org.apache.myfaces.view.facelets.tag.jsf.ConverterTagHandlerDelegate
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.ValueHolder in org.apache.myfaces.view.facelets.tag.jsf.ConverterTagHandlerDelegate.applyAttachedObject(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 135 | Low |
org.apache.myfaces.view.facelets.tag.jsf.FaceletState
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.view.facelets.tag.jsf.FaceletState defines non-transient non-serializable instance field stateMap | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
org.apache.myfaces.view.facelets.tag.jsf.ValidatorTagHandlerDelegate
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.EditableValueHolder in org.apache.myfaces.view.facelets.tag.jsf.ValidatorTagHandlerDelegate.applyAttachedObject(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 259 | Low |
org.apache.myfaces.view.facelets.tag.jsf.core.ActionListenerHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.ActionSource in org.apache.myfaces.view.facelets.tag.jsf.core.ActionListenerHandler.applyAttachedObject(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 192 | Low |
org.apache.myfaces.view.facelets.tag.jsf.core.AjaxHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.behavior.ClientBehaviorHolder in org.apache.myfaces.view.facelets.tag.jsf.core.AjaxHandler.applyAttachedObject(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 318 | Low |
| org.apache.myfaces.view.facelets.tag.jsf.core.AjaxHandler.AJAX_BEHAVIOR_LISTENER_SIG should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 90 | Medium |
org.apache.myfaces.view.facelets.tag.jsf.core.FacetHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.view.facelets.tag.jsf.core.FacetHandler is final but declares protected field org.apache.myfaces.view.facelets.tag.jsf.core.FacetHandler.name | STYLE | CI_CONFUSED_INHERITANCE | Not available | Low |
org.apache.myfaces.view.facelets.tag.jsf.core.LoadBundleHandler$ResourceBundleMap
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.view.facelets.tag.jsf.core.LoadBundleHandler$ResourceBundleMap is final but declares protected field org.apache.myfaces.view.facelets.tag.jsf.core.LoadBundleHandler$ResourceBundleMap.bundle | STYLE | CI_CONFUSED_INHERITANCE | Not available | Low |
org.apache.myfaces.view.facelets.tag.jsf.core.LoadBundleHandler$ResourceBundleMap$ResourceEntry
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.view.facelets.tag.jsf.core.LoadBundleHandler$ResourceBundleMap$ResourceEntry is final but declares protected field org.apache.myfaces.view.facelets.tag.jsf.core.LoadBundleHandler$ResourceBundleMap$ResourceEntry.key | STYLE | CI_CONFUSED_INHERITANCE | Not available | Low |
| Class org.apache.myfaces.view.facelets.tag.jsf.core.LoadBundleHandler$ResourceBundleMap$ResourceEntry is final but declares protected field org.apache.myfaces.view.facelets.tag.jsf.core.LoadBundleHandler$ResourceBundleMap$ResourceEntry.value | STYLE | CI_CONFUSED_INHERITANCE | Not available | Low |
org.apache.myfaces.view.facelets.tag.jsf.core.SelectItemsHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Private method org.apache.myfaces.view.facelets.tag.jsf.core.SelectItemsHandler.getNoSelectionValue() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 54 | Low |
org.apache.myfaces.view.facelets.tag.jsf.core.SetPropertyActionListenerHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.ActionSource in org.apache.myfaces.view.facelets.tag.jsf.core.SetPropertyActionListenerHandler.applyAttachedObject(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 141 | Low |
org.apache.myfaces.view.facelets.tag.jsf.core.ValueChangeListenerHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.EditableValueHolder in org.apache.myfaces.view.facelets.tag.jsf.core.ValueChangeListenerHandler.applyAttachedObject(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 181 | Low |
org.apache.myfaces.view.facelets.tag.jstl.core.ForEachHandler$ArrayIterator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.view.facelets.tag.jstl.core.ForEachHandler$ArrayIterator.next() can't throw NoSuchElementException | BAD_PRACTICE | IT_NO_SUCH_ELEMENT | 82 | Medium |
org.apache.myfaces.view.facelets.tag.jstl.core.IfHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.view.facelets.tag.jstl.core.IfHandler.apply(FaceletContext, UIComponent) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 110 | Medium |
org.apache.myfaces.view.facelets.tag.jstl.core.IterationStatusExpression
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.view.facelets.tag.jstl.core.IterationStatusExpression.equals(Object) checks for operand being a IterationStatus | BAD_PRACTICE | EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS | 113 | High |
org.apache.myfaces.view.facelets.tag.jstl.core.MappedValueExpression$Entry
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.view.facelets.tag.jstl.core.MappedValueExpression$Entry defines non-transient non-serializable instance field src | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| org.apache.myfaces.view.facelets.tag.jstl.core.MappedValueExpression$Entry is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 39-56 | Low |
org.apache.myfaces.view.facelets.tag.jstl.core.SetHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of SetHandler.value at line 150 of value previously dereferenced in org.apache.myfaces.view.facelets.tag.jstl.core.SetHandler.apply(FaceletContext, UIComponent) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 101 | Medium |
org.apache.myfaces.view.facelets.tag.jstl.fn.JstlFunction
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 59 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 379 | Low |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 394 | Low |
org.apache.myfaces.view.facelets.tag.ui.CompositionHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.view.facelets.tag.ui.CompositionHandler is final but declares protected field org.apache.myfaces.view.facelets.tag.ui.CompositionHandler._handlers | STYLE | CI_CONFUSED_INHERITANCE | Not available | Low |
| Class org.apache.myfaces.view.facelets.tag.ui.CompositionHandler is final but declares protected field org.apache.myfaces.view.facelets.tag.ui.CompositionHandler._params | STYLE | CI_CONFUSED_INHERITANCE | Not available | Low |
| Class org.apache.myfaces.view.facelets.tag.ui.CompositionHandler is final but declares protected field org.apache.myfaces.view.facelets.tag.ui.CompositionHandler._template | STYLE | CI_CONFUSED_INHERITANCE | Not available | Low |
org.apache.myfaces.view.facelets.tag.ui.DebugPhaseListener
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.view.facelets.tag.ui.DebugPhaseListener defines non-transient non-serializable instance field _currentPhase | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Class org.apache.myfaces.view.facelets.tag.ui.DebugPhaseListener defines non-transient non-serializable instance field _visitCallback | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
org.apache.myfaces.view.facelets.tag.ui.InsertHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Comparison of String parameter using == or != in org.apache.myfaces.view.facelets.tag.ui.InsertHandler.apply(FaceletContext, UIComponent, String) | BAD_PRACTICE | ES_COMPARING_PARAMETER_STRING_WITH_EQ | 109 | Low |
org.apache.myfaces.view.facelets.tag.ui.RepeatHandler$TagMetaData
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in new org.apache.myfaces.view.facelets.tag.ui.RepeatHandler$TagMetaData(RepeatHandler, Class) | STYLE | REC_CATCH_EXCEPTION | 90 | Low |
org.apache.myfaces.view.facelets.tag.ui.UIDebug
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 239 | Low |
org.apache.myfaces.view.facelets.tag.ui.UIDebug$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.apache.myfaces.view.facelets.tag.ui.UIDebug$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 84-92 | Low |
org.apache.myfaces.view.facelets.util.Classpath
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.view.facelets.util.Classpath._searchDir(Set, File, String) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 116-134 | High |
| org.apache.myfaces.view.facelets.util.Classpath._searchFromURL(Set, String, String, URL) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 153-213 | High |
| org.apache.myfaces.view.facelets.util.Classpath._searchJar(ClassLoader, Set, JarFile, String, String) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 292-312 | High |
| org.apache.myfaces.view.facelets.util.Classpath._searchResource(Set, ClassLoader, String, String, String) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 72-112 | High |
| Exception is caught when Exception is not thrown in org.apache.myfaces.view.facelets.util.Classpath._searchFromURL(Set, String, String, URL) | STYLE | REC_CATCH_EXCEPTION | 193 | Medium |
org.apache.myfaces.view.facelets.util.ReflectionUtil
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.view.facelets.util.ReflectionUtil.PRIMITIVES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 34 | Medium |
| org.apache.myfaces.view.facelets.util.ReflectionUtil.PRIMITIVE_NAMES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 31 | Medium |
| Should org.apache.myfaces.view.facelets.util.ReflectionUtil.toTypeArray(String[]) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 101 | Low |
| Should org.apache.myfaces.view.facelets.util.ReflectionUtil.toTypeNameArray(Class[]) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 123 | Low |
org.apache.myfaces.view.facelets.util.Resource
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.apache.myfaces.view.facelets.util.Resource is final but declares protected field org.apache.myfaces.view.facelets.util.Resource.log | STYLE | CI_CONFUSED_INHERITANCE | Not available | Low |
org.apache.myfaces.view.jsp.JspViewDeclarationLanguage
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.view.jsp.JspViewDeclarationLanguage.FACELETS_ONLY_F_TAGS should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 61 | Medium |
| org.apache.myfaces.view.jsp.JspViewDeclarationLanguage.FACELETS_ONLY_H_TAGS should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 62 | Medium |
org.apache.myfaces.webapp.AbstractFacesInitializer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 172 | Low |
| org.apache.myfaces.webapp.AbstractFacesInitializer.destroyFaces(ServletContext) invokes reflect.Method.setAccessible(boolean), which should be invoked from within a doPrivileged block | BAD_PRACTICE | DP_DO_INSIDE_DO_PRIVILEGED | 327 | Low |
| Exception is caught when Exception is not thrown in org.apache.myfaces.webapp.AbstractFacesInitializer.initFaces(ServletContext) | STYLE | REC_CATCH_EXCEPTION | 197 | Low |
org.apache.myfaces.webapp.Jsp20FacesInitializer$ErrorExpressionFactory
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.webapp.Jsp20FacesInitializer$ErrorExpressionFactory be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 137-165 | Medium |
org.apache.myfaces.webapp.MyFacesServlet
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.webapp.MyFacesServlet._facesInitializer is a mutable servlet field | MT_CORRECTNESS | MSF_MUTABLE_SERVLET_FIELD | 55 | Low |